@ledgerhq/live-common 34.45.0-nightly.2 → 34.45.0

package/src/bridge/generic-alpaca/utils.ts

@@ -1,56 +1,23 @@
 import { encodeOperationId } from "@ledgerhq/coin-framework/operation";
 import { Account, Operation, OperationType, TransactionCommon } from "@ledgerhq/types-live";
-import BigNumber from "bignumber.js";
-import { fromBigNumberToBigInt } from "@ledgerhq/coin-framework/utils";
 import {
   Balance,
   Operation as CoreOperation,
   TransactionIntent,
 } from "@ledgerhq/coin-framework/api/types";
+import BigNumber from "bignumber.js";
+import { fromBigNumberToBigInt } from "@ledgerhq/coin-framework/utils";
 
 export function extractBalance(balances: Balance[], type: string): Balance {
-  return (
-    balances.find(balance => balance.asset.type === type) ?? {
-      asset: { type },
-      value: 0n,
-    }
-  );
+  return balances.find(balance => balance.asset.type === type) ?? { asset: { type }, value: 0n };
 }
 
 export function adaptCoreOperationToLiveOperation(accountId: string, op: CoreOperation): Operation {
-  const opType = op.type as OperationType;
-
-  const extra: {
-    assetReference?: string;
-    assetOwner?: string;
-    assetAmount?: string | undefined;
-    ledgerOpType?: string | undefined;
-    memo?: string | undefined;
-  } = {};
-
-  if (op.details?.ledgerOpType !== undefined) {
-    extra.ledgerOpType = op.details.ledgerOpType as string;
-  }
-
-  if (op.details?.assetAmount !== undefined) {
-    extra.assetAmount = op.details.assetAmount as string;
-  }
-
-  if (op.asset?.type !== "native") {
-    extra.assetReference =
-      "assetReference" in (op.asset ?? {}) ? (op.asset as any).assetReference : "";
-    extra.assetOwner = "assetOwner" in (op.asset ?? {}) ? (op.asset as any).assetOwner : "";
-  }
-  if (op.details?.memo) {
-    extra.memo = op.details.memo as string;
-  }
-  const res = {
-    id: extra.ledgerOpType
-      ? encodeOperationId(accountId, op.tx.hash, extra.ledgerOpType)
-      : encodeOperationId(accountId, op.tx.hash, op.type),
+  return {
+    id: encodeOperationId(accountId, op.tx.hash, op.type),
     hash: op.tx.hash,
     accountId,
-    type: opType,
+    type: op.type as OperationType,
     value: new BigNumber(op.value.toString()),
     fee: new BigNumber(op.tx.fees.toString()),
     blockHash: op.tx.block.hash,
@@ -59,94 +26,21 @@ export function adaptCoreOperationToLiveOperation(accountId: string, op: CoreOpe
     recipients: op.recipients,
     date: op.tx.date,
     transactionSequenceNumber: op.details?.sequence as number,
-    hasFailed: (op.details as unknown as { status?: string })?.status === "failed",
-    extra,
+    extra: {},
   };
-
-  return res;
 }
 
-/**
- * Converts a transaction object into a `TransactionIntent` object, which is used to represent
- * the intent of a transaction in a standardized format.
- *
- * @template MemoType - The type of memo supported by the transaction, defaults to `MemoNotSupported`.
- *
- * @param account - The account initiating the transaction. Contains details such as the sender's address.
- * @param transaction - The transaction object containing details about the operation to be performed.
- *   - `assetOwner` (optional): The issuer of the asset, if applicable.
- *   - `assetReference` (optional): The code of the asset, if applicable.
- *   - `mode` (optional): The mode of the transaction, e.g., "changetrust" or "send".
- *   - `fees` (optional): The fees associated with the transaction.
- *   - `memoType` (optional): The type of memo to attach to the transaction.
- *   - `memoValue` (optional): The value of the memo to attach to the transaction.
- *
- * @returns A `TransactionIntent` object containing the standardized representation of the transaction.
- *   - Includes details such as type, sender, recipient, amount, fees, asset, and an optional memo.
- *   - If `assetReference` and `assetOwner` are provided, the asset is represented as a token.
- *   - If `memoType` and `memoValue` are provided, a memo is included; otherwise, a default memo of type "NO_MEMO" is added.
- *
- * @throws An error if the transaction mode is unsupported.
- */
 export function transactionToIntent(
   account: Account,
-  transaction: TransactionCommon & {
-    assetOwner?: string;
-    assetReference?: string;
-    mode?: string;
-    fees?: bigint | null | undefined;
-    memoType?: string;
-    memoValue?: string;
-    useAllAmount?: boolean;
-  },
-): TransactionIntent<any> & { memo?: { type: string; value?: string } } {
-  let transactionType = "Payment"; // NOTE: assuming payment by default here, can be changed based on transaction.mode
-  if (transaction.mode) {
-    switch (transaction.mode) {
-      case "changeTrust":
-        transactionType = "changeTrust";
-        break;
-      case "send":
-        transactionType = "send";
-        break;
-      default:
-        throw new Error(`Unsupported transaction mode: ${transaction.mode}`);
-    }
-  }
-  const res: TransactionIntent & { memo?: { type: string; value?: string } } = {
-    fees: transaction?.fees ? transaction.fees : null,
-    type: transactionType,
+  transaction: TransactionCommon,
+): TransactionIntent<any> {
+  return {
+    type: "Payment",
     sender: account.freshAddress,
     recipient: transaction.recipient,
     amount: fromBigNumberToBigInt(transaction.amount, BigInt(0)),
-    asset: { type: "native", name: account.currency.name, unit: account.currency.units[0] },
-    useAllAmount: !!transaction.useAllAmount,
+    asset: { type: "native" },
   };
-  if (transaction.assetReference && transaction.assetOwner) {
-    const { subAccountId } = transaction;
-    const { subAccounts } = account;
-
-    const tokenAccount = !subAccountId
-      ? null
-      : subAccounts && subAccounts.find(ta => ta.id === subAccountId);
-
-    res.asset = {
-      type: tokenAccount?.token.tokenType ?? "token",
-      assetReference: transaction.assetReference,
-      name: tokenAccount?.token.name ?? transaction.assetReference, // NOTE: for stellar, assetReference = tokenAccount.name, this is futureproofing
-      unit: account.currency.units[0],
-      assetOwner: transaction.assetOwner,
-    };
-  }
-  if (transaction.memoType && transaction.memoValue) {
-    res.memo = {
-      type: transaction.memoType,
-      value: transaction.memoValue,
-    };
-  } else {
-    res.memo = { type: "NO_MEMO" };
-  }
-  return res;
 }
 
 export const buildOptimisticOperation = (
@@ -154,17 +48,12 @@ export const buildOptimisticOperation = (
   transaction: TransactionCommon,
   sequenceNumber?: number,
 ): Operation => {
-  const type = transaction["mode"] === "changeTrust" ? "OPT_IN" : "OUT";
-  const fees = BigInt(transaction["fees"]?.toString() || "0");
-  const { subAccountId } = transaction;
-  const { subAccounts } = account;
-
-  const operation: Operation = {
-    id: encodeOperationId(account.id, "", type),
+  return {
+    id: encodeOperationId(account.id, "", "OUT"),
     hash: "",
-    type: type,
-    value: subAccountId ? new BigNumber(fees.toString()) : transaction.amount, // match old behavior
-    fee: new BigNumber(fees.toString()),
+    type: "OUT",
+    value: transaction.amount,
+    fee: transaction["fees"] ?? BigNumber(0),
     blockHash: null,
     blockHeight: null,
     senders: [account.freshAddress.toString()],
@@ -172,35 +61,6 @@ export const buildOptimisticOperation = (
     transactionSequenceNumber: sequenceNumber ?? 0,
     accountId: account.id,
     date: new Date(),
-    extra: {
-      ledgerOpType: type,
-      blockTime: new Date(),
-      index: "0",
-    },
+    extra: {},
   };
-
-  const tokenAccount = !subAccountId
-    ? null
-    : subAccounts && subAccounts.find(ta => ta.id === subAccountId);
-  if (tokenAccount && subAccountId) {
-    operation.subOperations = [
-      {
-        id: `${subAccountId}--OUT`,
-        hash: "",
-        type: "OUT",
-        value: transaction.useAllAmount ? tokenAccount.balance : transaction.amount,
-        fee: new BigNumber(0),
-        blockHash: null,
-        blockHeight: null,
-        senders: [account.freshAddress],
-        recipients: [transaction.recipient],
-        accountId: subAccountId,
-        date: new Date(),
-        extra: {
-          ledgerOpType: type,
-        },
-      },
-    ];
-  }
-  return operation;
 };

package/src/bridge/impl.ts

@@ -26,12 +26,11 @@ import { getCryptoAssetsStore, setCryptoAssetsStore } from "./crypto-assets";
 
 const alpacaized = {
   xrp: true,
-  stellar: true,
 };
 
 // let accountBridgeInstance: AccountBridge<any> | null = null;
 const bridgeCache: Record<string, AccountBridge<any>> = {};
-const currencyBridgeCache: Record<string, CurrencyBridge> = {};
+let currencyBridgeInstance: CurrencyBridge | null = null;
 
 export const getCurrencyBridge = (currency: CryptoCurrency): CurrencyBridge => {
   if (getEnv("MOCK")) {
@@ -43,10 +42,10 @@ export const getCurrencyBridge = (currency: CryptoCurrency): CurrencyBridge => {
   }
 
   if (alpacaized[currency.family]) {
-    if (!currencyBridgeCache[currency.family]) {
-      currencyBridgeCache[currency.family] = getAlpacaCurrencyBridge(currency.family, "local");
+    if (!currencyBridgeInstance) {
+      currencyBridgeInstance = getAlpacaCurrencyBridge(currency.family, "local");
     }
-    return currencyBridgeCache[currency.family];
+    return currencyBridgeInstance;
   }
 
   const jsBridge = jsBridges[currency.family];

package/src/e2e/enum/Account.ts

@@ -94,25 +94,25 @@ export class Account {
 
   static readonly BSC_1 = new Account(
     Currency.BSC,
-    "BNB Chain 1",
+    "Binance Smart Chain 1",
     "0x4BE2E2B8872AA298D6d123b9211B53E41f611566",
     0,
   );
   static readonly BSC_BUSD_1 = new Account(
     Currency.BSC_BUSD,
-    "BNB Chain 1",
+    "Binance Smart Chain 1",
     "0x4BE2E2B8872AA298D6d123b9211B53E41f611566",
     0,
   );
   static readonly BSC_BUSD_2 = new Account(
     Currency.BSC_BUSD,
-    "BNB Chain 2",
+    "Binance Smart Chain 2",
     "0xa1baa625c5E6A9304cB7AcD86d2fee6B710eC3eB",
     1,
   );
   static readonly BSC_SHIBA = new Account(
     Currency.BSC_SHIBA,
-    "BNB Chain 1",
+    "Binance Smart Chain 1",
     "0x4BE2E2B8872AA298D6d123b9211B53E41f611566",
     0,
   );

package/src/e2e/enum/AppInfos.ts

@@ -43,7 +43,7 @@ export class AppInfos {
 
   static readonly POLYGON = new AppInfos("Polygon");
 
-  static readonly BNB_CHAIN = new AppInfos("BNB Chain");
+  static readonly BINANCE_SMART_CHAIN = new AppInfos("Binance Smart Chain");
 
   static readonly TON = new AppInfos("Ton");
 

package/src/e2e/enum/Currency.ts

@@ -63,7 +63,12 @@ export class Currency {
   static readonly ATOM = new Currency("Cosmos", "ATOM", "cosmos", AppInfos.COSMOS);
   static readonly XTZ = new Currency("Tezos", "XTZ", "tezos", AppInfos.TEZOS);
   static readonly POL = new Currency("Polygon", "POL", "polygon", AppInfos.POLYGON);
-  static readonly BSC = new Currency("BNB Chain", "BNB", "bsc", AppInfos.BNB_CHAIN);
+  static readonly BSC = new Currency(
+    "Binance Smart Chain",
+    "BNB",
+    "bsc",
+    AppInfos.BINANCE_SMART_CHAIN,
+  );
   static readonly TON = new Currency("TON", "TON", "ton", AppInfos.TON);
   static readonly ETH_USDT = new Currency(
     "Tether USD",
@@ -93,9 +98,14 @@ export class Currency {
     "Binance-Peg BUSD Token",
     "BUSD",
     "bsc",
-    AppInfos.BNB_CHAIN,
+    AppInfos.BINANCE_SMART_CHAIN,
+  );
+  static readonly BSC_SHIBA = new Currency(
+    "Shiba Inu",
+    "SHIB",
+    "bsc",
+    AppInfos.BINANCE_SMART_CHAIN,
   );
-  static readonly BSC_SHIBA = new Currency("Shiba Inu", "SHIB", "bsc", AppInfos.BNB_CHAIN);
   static readonly POL_DAI = new Currency(
     "(PoS) Dai Stablecoin",
     "DAI",

package/src/e2e/speculos.ts

@@ -260,7 +260,7 @@ export const specs: Specs = {
     },
     dependency: "",
   },
-  BNB_Chain: {
+  Binance_Smart_Chain: {
     currency: getCryptoCurrencyById("bsc"),
     appQuery: {
       model: getSpeculosModel(),
@@ -620,7 +620,7 @@ export async function goToSettings() {
 
 const APP_LABEL_MAP = new Map<AppInfos, [string, string]>([
   [AppInfos.ETHEREUM, [DeviceLabels.VERIFY_ETHEREUM, DeviceLabels.CONFIRM]],
-  [AppInfos.BNB_CHAIN, [DeviceLabels.VERIFY_BSC, DeviceLabels.CONFIRM]],
+  [AppInfos.BINANCE_SMART_CHAIN, [DeviceLabels.VERIFY_BSC, DeviceLabels.CONFIRM]],
   [AppInfos.POLYGON, [DeviceLabels.VERIFY_POLYGON, DeviceLabels.CONFIRM]],
   [AppInfos.SOLANA, [DeviceLabels.PUBKEY, DeviceLabels.APPROVE]],
   [AppInfos.POLKADOT, [DeviceLabels.PLEASE_REVIEW, DeviceLabels.CAPS_APPROVE]],

package/src/exchange/index.ts

@@ -24,7 +24,6 @@ const exchangeSupportAppVersions = {
   tron: "0.4.100",
   zcash: "1.5.0",
   zencash: "1.5.0",
-  sui: "1.2.0",
 };
 
 type ExchangeCurrencyNameAndSignature = {

package/src/families/canton/bridge.integration.test.ts

@@ -0,0 +1,6 @@
+import "../../__tests__/test-helpers/setup";
+
+import { dataset } from "@ledgerhq/coin-canton/test/index";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
+
+testBridge(dataset);