@ledgerhq/live-common 34.37.0-nightly.2 → 34.37.0-nightly.4

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@ledgerhq/live-common",
   "description": "Common ground for the Ledger Live apps",
-  "version": "34.37.0-nightly.2",
+  "version": "34.37.0-nightly.4",
   "repository": {
     "type": "git",
     "url": "https://github.com/LedgerHQ/ledger-live.git"
@@ -162,72 +162,72 @@
     "xstate": "^5.19.2",
     "yargs": "^17.0.0",
     "zod": "^3.22.4",
-    "@ledgerhq/coin-algorand": "^0.9.9-nightly.1",
-    "@ledgerhq/coin-aptos": "^2.2.0-nightly.1",
-    "@ledgerhq/coin-bitcoin": "^0.15.9-nightly.1",
-    "@ledgerhq/coin-cardano": "^0.8.9-nightly.1",
-    "@ledgerhq/coin-casper": "^1.7.4-nightly.1",
-    "@ledgerhq/coin-celo": "^1.1.7-nightly.1",
-    "@ledgerhq/coin-cosmos": "^0.15.1-nightly.1",
-    "@ledgerhq/coin-evm": "^2.22.3-nightly.1",
-    "@ledgerhq/coin-filecoin": "^1.9.9-nightly.1",
-    "@ledgerhq/coin-framework": "^5.3.0-nightly.1",
-    "@ledgerhq/coin-hedera": "^1.7.1-nightly.1",
-    "@ledgerhq/coin-icon": "^0.10.9-nightly.1",
-    "@ledgerhq/coin-internet_computer": "^1.7.9-nightly.1",
-    "@ledgerhq/coin-mina": "^1.1.8-nightly.1",
-    "@ledgerhq/coin-multiversx": "^0.4.9-nightly.1",
-    "@ledgerhq/coin-near": "^0.11.9-nightly.1",
-    "@ledgerhq/coin-polkadot": "^6.1.3-nightly.1",
-    "@ledgerhq/coin-solana": "^0.25.1-nightly.1",
-    "@ledgerhq/coin-stacks": "^0.8.9-nightly.1",
-    "@ledgerhq/coin-stellar": "^5.1.2-nightly.1",
-    "@ledgerhq/coin-sui": "^0.4.2-nightly.1",
-    "@ledgerhq/coin-tezos": "^5.2.2-nightly.1",
-    "@ledgerhq/coin-ton": "^0.12.1-nightly.1",
-    "@ledgerhq/coin-tron": "^4.2.0-nightly.2",
-    "@ledgerhq/coin-vechain": "^2.7.9-nightly.1",
-    "@ledgerhq/coin-xrp": "^6.1.4-nightly.1",
+    "@ledgerhq/coin-algorand": "^0.9.9-nightly.3",
+    "@ledgerhq/coin-aptos": "^2.2.0-nightly.3",
+    "@ledgerhq/coin-bitcoin": "^0.15.9-nightly.3",
+    "@ledgerhq/coin-cardano": "^0.8.9-nightly.3",
+    "@ledgerhq/coin-casper": "^1.7.4-nightly.3",
+    "@ledgerhq/coin-celo": "^1.1.7-nightly.3",
+    "@ledgerhq/coin-cosmos": "^0.15.1-nightly.3",
+    "@ledgerhq/coin-evm": "^2.22.3-nightly.3",
+    "@ledgerhq/coin-filecoin": "^1.9.9-nightly.3",
+    "@ledgerhq/coin-framework": "^5.3.0-nightly.3",
+    "@ledgerhq/coin-hedera": "^1.7.1-nightly.3",
+    "@ledgerhq/coin-icon": "^0.10.9-nightly.3",
+    "@ledgerhq/coin-internet_computer": "^1.7.9-nightly.3",
+    "@ledgerhq/coin-mina": "^1.1.8-nightly.3",
+    "@ledgerhq/coin-multiversx": "^0.4.9-nightly.3",
+    "@ledgerhq/coin-near": "^0.11.9-nightly.3",
+    "@ledgerhq/coin-polkadot": "^6.1.3-nightly.3",
+    "@ledgerhq/coin-solana": "^0.26.0-nightly.3",
+    "@ledgerhq/coin-stacks": "^0.8.9-nightly.3",
+    "@ledgerhq/coin-stellar": "^5.1.2-nightly.3",
+    "@ledgerhq/coin-sui": "^0.4.2-nightly.3",
+    "@ledgerhq/coin-tezos": "^5.2.2-nightly.3",
+    "@ledgerhq/coin-ton": "^0.12.1-nightly.3",
+    "@ledgerhq/coin-tron": "^4.2.0-nightly.4",
+    "@ledgerhq/coin-vechain": "^2.7.9-nightly.3",
+    "@ledgerhq/coin-xrp": "^6.1.4-nightly.3",
     "@ledgerhq/crypto-icons-ui": "^1.15.0-nightly.0",
-    "@ledgerhq/cryptoassets": "^13.18.1-nightly.0",
-    "@ledgerhq/device-core": "^0.4.27-nightly.1",
-    "@ledgerhq/devices": "8.4.6",
-    "@ledgerhq/errors": "^6.21.0",
-    "@ledgerhq/hw-app-algorand": "^6.31.2",
-    "@ledgerhq/hw-app-aptos": "^6.34.2",
-    "@ledgerhq/hw-app-btc": "^10.9.2",
-    "@ledgerhq/hw-app-celo": "^6.33.5-nightly.1",
-    "@ledgerhq/hw-app-cosmos": "^6.32.2",
-    "@ledgerhq/hw-app-eth": "^6.45.7-nightly.1",
-    "@ledgerhq/hw-app-exchange": "^0.10.2",
-    "@ledgerhq/hw-app-hedera": "^1.2.2",
-    "@ledgerhq/hw-app-icon": "^1.3.2",
-    "@ledgerhq/hw-app-multiversx": "^6.24.2",
-    "@ledgerhq/hw-app-near": "^6.31.2",
-    "@ledgerhq/hw-app-polkadot": "^6.34.2",
-    "@ledgerhq/hw-app-str": "^7.2.2",
+    "@ledgerhq/cryptoassets": "^13.19.0-nightly.1",
+    "@ledgerhq/device-core": "^0.4.27-nightly.3",
+    "@ledgerhq/devices": "8.4.7-nightly.0",
+    "@ledgerhq/errors": "^6.22.0-nightly.0",
+    "@ledgerhq/hw-app-algorand": "^6.31.3-nightly.0",
+    "@ledgerhq/hw-app-aptos": "^6.34.3-nightly.0",
+    "@ledgerhq/hw-app-btc": "^10.9.3-nightly.0",
+    "@ledgerhq/hw-app-celo": "^6.33.5-nightly.3",
+    "@ledgerhq/hw-app-cosmos": "^6.32.3-nightly.0",
+    "@ledgerhq/hw-app-eth": "^6.45.7-nightly.3",
+    "@ledgerhq/hw-app-exchange": "^0.10.3-nightly.0",
+    "@ledgerhq/hw-app-hedera": "^1.2.3-nightly.0",
+    "@ledgerhq/hw-app-icon": "^1.3.3-nightly.0",
+    "@ledgerhq/hw-app-multiversx": "^6.24.3-nightly.0",
+    "@ledgerhq/hw-app-near": "^6.31.3-nightly.0",
+    "@ledgerhq/hw-app-polkadot": "^6.34.3-nightly.0",
+    "@ledgerhq/hw-app-str": "^7.2.3-nightly.0",
     "@ledgerhq/hw-app-sui": "^1.1.0",
-    "@ledgerhq/hw-app-tezos": "^6.31.2",
-    "@ledgerhq/hw-app-trx": "^6.31.2",
-    "@ledgerhq/hw-app-vet": "^0.5.5",
-    "@ledgerhq/hw-app-xrp": "^6.31.2",
-    "@ledgerhq/hw-transport": "^6.31.6",
-    "@ledgerhq/hw-transport-mocker": "^6.29.6",
-    "@ledgerhq/ledger-cal-service": "^0.6.0-nightly.0",
+    "@ledgerhq/hw-app-tezos": "^6.31.3-nightly.0",
+    "@ledgerhq/hw-app-trx": "^6.31.3-nightly.0",
+    "@ledgerhq/hw-app-vet": "^0.5.6-nightly.1",
+    "@ledgerhq/hw-app-xrp": "^6.31.3-nightly.0",
+    "@ledgerhq/hw-transport": "^6.31.7-nightly.0",
+    "@ledgerhq/hw-transport-mocker": "^6.29.7-nightly.0",
+    "@ledgerhq/ledger-cal-service": "^1.0.0-nightly.2",
     "@ledgerhq/live-config": "^3.1.0",
-    "@ledgerhq/live-countervalues": "^0.5.9-nightly.1",
-    "@ledgerhq/live-dmk-shared": "^0.9.0",
-    "@ledgerhq/live-countervalues-react": "^0.2.38-nightly.1",
+    "@ledgerhq/live-countervalues": "^0.5.9-nightly.3",
+    "@ledgerhq/live-dmk-shared": "^0.9.1-nightly.0",
+    "@ledgerhq/live-countervalues-react": "^0.2.38-nightly.3",
     "@ledgerhq/live-env": "^2.9.1-nightly.0",
     "@ledgerhq/live-hooks": "0.1.0",
-    "@ledgerhq/live-network": "^2.0.9",
-    "@ledgerhq/live-nft": "^0.8.9-nightly.1",
+    "@ledgerhq/live-network": "^2.0.10-nightly.0",
+    "@ledgerhq/live-nft": "^0.8.9-nightly.3",
     "@ledgerhq/live-promise": "^0.1.1",
-    "@ledgerhq/live-signer-evm": "^0.5.2-nightly.1",
-    "@ledgerhq/live-signer-solana": "^0.2.1-nightly.1",
-    "@ledgerhq/live-wallet": "^0.10.12-nightly.1",
+    "@ledgerhq/live-signer-evm": "^0.5.2-nightly.3",
+    "@ledgerhq/live-signer-solana": "^0.3.0-nightly.3",
+    "@ledgerhq/live-wallet": "^0.10.12-nightly.3",
     "@ledgerhq/logs": "^6.13.0",
-    "@ledgerhq/speculos-transport": "^0.2.2",
+    "@ledgerhq/speculos-transport": "^0.2.3-nightly.0",
     "@ledgerhq/wallet-api-acre-module": "^0.5.0",
     "@ledgerhq/wallet-api-exchange-module": "^0.13.0"
   },
@@ -277,10 +277,10 @@
     "undici": "6.19.2",
     "uuid": "^8.3.2",
     "ws": "7",
-    "@ledgerhq/device-react": "^0.2.33-nightly.1",
+    "@ledgerhq/device-react": "^0.2.33-nightly.3",
     "@ledgerhq/types-cryptoassets": "^7.23.0",
     "@ledgerhq/types-devices": "^6.25.3",
-    "@ledgerhq/types-live": "^6.73.0-nightly.1"
+    "@ledgerhq/types-live": "^6.73.0-nightly.2"
   },
   "scripts": {
     "build": "zx ./scripts/build-ts.mjs",

package/src/exchange/swap/completeExchange.ts

@@ -25,8 +25,6 @@ import { CompleteExchangeStep, convertTransportError } from "../error";
 import type { CompleteExchangeInputSwap, CompleteExchangeRequestEvent } from "../platform/types";
 import { convertToAppExchangePartnerKey, getSwapProvider } from "../providers";
 import { CEXProviderConfig } from "../providers/swap";
-import { isAddressSanctioned } from "../../sanction";
-import { RecipientAddressSanctionedError } from "../../sanction/errors";
 
 const COMPLETE_EXCHANGE_LOG = "SWAP-CompleteExchange";
 
@@ -66,19 +64,6 @@ const completeExchange = (
         const payoutCurrency = getAccountCurrency(toAccount);
         const refundCurrency = getAccountCurrency(fromAccount);
         const mainRefundCurrency = getAccountCurrency(refundAccount);
-
-        const isPayoutSanctioned = await isAddressSanctioned(
-          payoutAccount.currency,
-          payoutAccount.freshAddress,
-        );
-        const isRefundSanctioned = await isAddressSanctioned(
-          refundAccount.currency,
-          refundAccount.freshAddress,
-        );
-
-        if (isPayoutSanctioned || isRefundSanctioned) {
-          throw new RecipientAddressSanctionedError();
-        }
         if (mainPayoutCurrency.type !== "CryptoCurrency")
           throw new Error("This should be a cryptocurrency");
         if (mainRefundCurrency.type !== "CryptoCurrency")

package/src/families/evm/config.ts

@@ -104,7 +104,7 @@ const evmConfig: CurrencyLiveConfigDefinition = {
         type: "ledger",
         explorerId: "eth",
       },
-      showNfts: true,
+      showNfts: false,
     },
   },
   config_currency_sonic: {
@@ -266,7 +266,7 @@ const evmConfig: CurrencyLiveConfigDefinition = {
         type: "ledger",
         explorerId: "matic",
       },
-      showNfts: true,
+      showNfts: false,
     },
   },
   config_currency_reosc: {

package/src/featureFlags/defaultFeatures.ts

@@ -396,6 +396,13 @@ export const DEFAULT_FEATURES: Features = {
     },
   },
 
+  buySellLoader: {
+    enabled: false,
+    params: {
+      durationMs: 0,
+    },
+  },
+
   buySellShortcut: {
     enabled: false,
   },

package/src/hooks/useShowProviderLoadingTransition.test.ts

@@ -0,0 +1,112 @@
+/**
+ * @jest-environment jsdom
+ */
+
+import { renderHook } from "@testing-library/react";
+import { LiveAppManifest } from "../platform/types";
+import { INTERNAL_APP_IDS } from "../wallet-api/constants";
+import { useFeature } from "../featureFlags";
+import { useInternalAppIds } from "./useInternalAppIds";
+
+import { useShowProviderLoadingTransition } from "./useShowProviderLoadingTransition";
+
+jest.mock("../featureFlags", () => ({
+  useFeature: jest.fn(),
+}));
+jest.mock("../wallet-api/constants", () => ({
+  INTERNAL_APP_IDS: ["internal-app-id-1", "internal-app-id-2"],
+}));
+jest.mock("./useInternalAppIds", () => ({
+  useInternalAppIds: jest.fn(),
+}));
+
+describe("useShowProviderLoadingTransition", () => {
+  const mockUseFeature = useFeature as jest.Mock;
+  const mockUseInternalAppIds = useInternalAppIds as jest.Mock;
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it("should return false when feature is disabled", () => {
+    mockUseFeature.mockReturnValue({ enabled: false, params: {} });
+    const { result } = renderHook(() =>
+      useShowProviderLoadingTransition({
+        manifest: { id: "test-app-id" } as LiveAppManifest,
+        isLoading: true,
+      }),
+    );
+    expect(result.current).toBe(false);
+  });
+
+  it("should return false for internal apps", () => {
+    mockUseFeature.mockReturnValue({ enabled: true, params: {} });
+    mockUseInternalAppIds.mockReturnValue(INTERNAL_APP_IDS);
+    const { result } = renderHook(() =>
+      useShowProviderLoadingTransition({
+        manifest: { id: "internal-app-id-1" } as LiveAppManifest,
+        isLoading: true,
+      }),
+    );
+    expect(result.current).toBe(false);
+  });
+
+  it("should return true when loading and feature is enabled", () => {
+    mockUseFeature.mockReturnValue({ enabled: true, params: {} });
+    mockUseInternalAppIds.mockReturnValue([]);
+    const { result } = renderHook(() =>
+      useShowProviderLoadingTransition({
+        manifest: { id: "test-app-id" } as LiveAppManifest,
+        isLoading: true,
+      }),
+    );
+    expect(result.current).toBe(true);
+  });
+
+  it("should handle extended loading state", () => {
+    jest.useFakeTimers();
+    mockUseFeature.mockReturnValue({ enabled: true, params: { durationMs: 1000 } });
+    mockUseInternalAppIds.mockReturnValue([]);
+
+    const { result, rerender } = renderHook(
+      ({ isLoading }) =>
+        useShowProviderLoadingTransition({
+          manifest: { id: "test-app-id" } as LiveAppManifest,
+          isLoading,
+        }),
+      {
+        initialProps: { isLoading: true },
+      },
+    );
+
+    expect(result.current).toBe(true);
+
+    // Simulate the timeout
+    jest.advanceTimersByTime(1000);
+
+    rerender({ isLoading: false });
+
+    expect(result.current).toBe(false);
+
+    jest.useRealTimers();
+  });
+  it("should clear timeout on unmount", () => {
+    jest.useFakeTimers();
+    mockUseFeature.mockReturnValue({ enabled: true, params: { durationMs: 1000 } });
+    mockUseInternalAppIds.mockReturnValue([]);
+
+    const { unmount } = renderHook(() =>
+      useShowProviderLoadingTransition({
+        manifest: { id: "test-app-id" } as LiveAppManifest,
+        isLoading: true,
+      }),
+    );
+
+    unmount();
+
+    // Advance timers to ensure no memory leaks
+    jest.advanceTimersByTime(1000);
+
+    jest.useRealTimers();
+  });
+});

package/src/hooks/useShowProviderLoadingTransition.ts

@@ -0,0 +1,57 @@
+import { useEffect, useRef, useState } from "react";
+
+import { useFeature } from "../featureFlags/index";
+import { INTERNAL_APP_IDS } from "../wallet-api/constants";
+import { useInternalAppIds } from "./useInternalAppIds";
+import { LiveAppManifest } from "../platform/types";
+
+export function useShowProviderLoadingTransition({
+  isLoading,
+  manifest,
+}: {
+  manifest: LiveAppManifest;
+  isLoading: boolean;
+}) {
+  const isEnabled = useProviderInterstitalEnabled({ manifest });
+  const [extendedInitialLoading, setExtendedInitialLoading] = useState(false);
+
+  const timeoutRef = useRef<NodeJS.Timeout | null>(null);
+  const buySellLoaderFF = useFeature("buySellLoader");
+  const durationMs = buySellLoaderFF?.params?.durationMs ?? 0;
+  const internalAppIds = useInternalAppIds() || INTERNAL_APP_IDS;
+  const isAppInternal = internalAppIds.includes(manifest.id);
+
+  useEffect(() => {
+    if (isEnabled && isLoading && !extendedInitialLoading) {
+      setExtendedInitialLoading(true);
+
+      if (timeoutRef.current) clearTimeout(timeoutRef.current);
+
+      timeoutRef.current = setTimeout(() => {
+        setExtendedInitialLoading(false);
+      }, durationMs);
+    }
+  }, [durationMs, extendedInitialLoading, isAppInternal, isEnabled, isLoading]);
+
+  useEffect(() => {
+    return () => {
+      if (timeoutRef.current) clearTimeout(timeoutRef.current);
+    };
+  }, []);
+
+  return isEnabled && (isLoading || extendedInitialLoading);
+}
+
+export function useProviderInterstitalEnabled({ manifest }: { manifest?: LiveAppManifest }) {
+  const buySellLoaderFF = useFeature("buySellLoader");
+  const internalAppIds = useInternalAppIds() || INTERNAL_APP_IDS;
+
+  if (!manifest) {
+    return false;
+  }
+
+  const isAppInternal = internalAppIds.includes(manifest.id);
+  const isEnabled = buySellLoaderFF?.enabled && !isAppInternal;
+
+  return isEnabled;
+}

package/src/wallet-api/Exchange/server.ts

@@ -65,6 +65,8 @@ export type CompleteExchangeUiRequest = {
   swapId?: string;
   amountExpectedTo?: number;
   magnitudeAwareRate?: BigNumber;
+  refundAddress?: string;
+  payoutAddress?: string;
 };
 
 type ExchangeStartParamsUiRequest =
@@ -286,11 +288,15 @@ export const handlers = ({
 
         let amountExpectedTo;
         let magnitudeAwareRate;
+        let refundAddress;
+        let payoutAddress;
         if (params.exchangeType === "SWAP") {
           // Get amountExpectedTo and magnitudeAwareRate from binary payload
           const decodePayload = await decodeSwapPayload(params.hexBinaryPayload);
           amountExpectedTo = new BigNumber(decodePayload.amountToWallet.toString());
           magnitudeAwareRate = tx.amount && amountExpectedTo.dividedBy(tx.amount);
+          refundAddress = decodePayload.refundAddress;
+          payoutAddress = decodePayload.payoutAddress;
         }
 
         return new Promise((resolve, reject) =>
@@ -306,6 +312,8 @@ export const handlers = ({
               swapId: params.exchangeType === "SWAP" ? params.swapId : undefined,
               amountExpectedTo,
               magnitudeAwareRate,
+              refundAddress,
+              payoutAddress,
             },
             onSuccess: (transactionHash: string) => {
               tracking.completeExchangeSuccess({