@ledgerhq/live-common 34.34.0-nightly.3 → 34.34.0-nightly.5

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@ledgerhq/live-common",
   "description": "Common ground for the Ledger Live apps",
-  "version": "34.34.0-nightly.3",
+  "version": "34.34.0-nightly.5",
   "repository": {
     "type": "git",
     "url": "https://github.com/LedgerHQ/ledger-live.git"
@@ -162,74 +162,72 @@
     "xstate": "4.38.3",
     "yargs": "^17.0.0",
     "zod": "^3.22.4",
-    "@ledgerhq/coin-algorand": "^0.9.6-nightly.0",
-    "@ledgerhq/coin-aptos": "^2.0.0-nightly.2",
-    "@ledgerhq/coin-bitcoin": "^0.15.6-nightly.0",
-    "@ledgerhq/coin-cardano": "^0.8.6-nightly.0",
-    "@ledgerhq/coin-casper": "^1.7.1-nightly.0",
-    "@ledgerhq/coin-celo": "^1.1.4-nightly.0",
-    "@ledgerhq/coin-cosmos": "^0.14.2-nightly.0",
-    "@ledgerhq/coin-evm": "^2.21.1-nightly.0",
-    "@ledgerhq/coin-filecoin": "^1.9.6-nightly.0",
-    "@ledgerhq/coin-framework": "^5.1.0-nightly.0",
-    "@ledgerhq/coin-icon": "^0.10.6-nightly.0",
-    "@ledgerhq/coin-hedera": "^1.6.6-nightly.0",
-    "@ledgerhq/coin-internet_computer": "^1.7.6-nightly.0",
-    "@ledgerhq/coin-mina": "^1.1.5-nightly.0",
-    "@ledgerhq/coin-multiversx": "^0.4.6-nightly.0",
-    "@ledgerhq/coin-near": "^0.11.6-nightly.0",
-    "@ledgerhq/coin-polkadot": "^6.0.2-nightly.0",
-    "@ledgerhq/coin-solana": "^0.23.0-nightly.0",
-    "@ledgerhq/coin-stacks": "^0.8.6-nightly.0",
-    "@ledgerhq/coin-stellar": "^5.1.0-nightly.0",
-    "@ledgerhq/coin-tezos": "^5.0.2-nightly.0",
-    "@ledgerhq/coin-sui": "^0.3.3-nightly.0",
-    "@ledgerhq/coin-ton": "^0.10.1-nightly.0",
-    "@ledgerhq/coin-tron": "^4.0.1-nightly.0",
-    "@ledgerhq/coin-vechain": "^2.7.6-nightly.0",
-    "@ledgerhq/coin-xrp": "^6.1.1-nightly.0",
+    "@ledgerhq/coin-aptos": "^2.0.0-nightly.4",
+    "@ledgerhq/coin-bitcoin": "^0.15.6-nightly.2",
+    "@ledgerhq/coin-cardano": "^0.8.6-nightly.2",
+    "@ledgerhq/coin-casper": "^1.7.1-nightly.2",
+    "@ledgerhq/coin-algorand": "^0.9.6-nightly.2",
+    "@ledgerhq/coin-celo": "^1.1.4-nightly.2",
+    "@ledgerhq/coin-cosmos": "^0.14.2-nightly.2",
+    "@ledgerhq/coin-evm": "^2.21.1-nightly.2",
+    "@ledgerhq/coin-filecoin": "^1.9.6-nightly.2",
+    "@ledgerhq/coin-framework": "^5.1.0-nightly.2",
+    "@ledgerhq/coin-hedera": "^1.6.6-nightly.2",
+    "@ledgerhq/coin-internet_computer": "^1.7.6-nightly.2",
+    "@ledgerhq/coin-icon": "^0.10.6-nightly.2",
+    "@ledgerhq/coin-mina": "^1.1.5-nightly.2",
+    "@ledgerhq/coin-multiversx": "^0.4.6-nightly.2",
+    "@ledgerhq/coin-near": "^0.11.6-nightly.2",
+    "@ledgerhq/coin-polkadot": "^6.0.2-nightly.2",
+    "@ledgerhq/coin-solana": "^0.23.0-nightly.2",
+    "@ledgerhq/coin-stacks": "^0.8.6-nightly.2",
+    "@ledgerhq/coin-stellar": "^5.1.0-nightly.2",
+    "@ledgerhq/coin-sui": "^0.3.3-nightly.2",
+    "@ledgerhq/coin-tezos": "^5.0.2-nightly.2",
+    "@ledgerhq/coin-ton": "^0.10.1-nightly.2",
+    "@ledgerhq/coin-tron": "^4.0.1-nightly.2",
+    "@ledgerhq/coin-vechain": "^2.7.6-nightly.2",
+    "@ledgerhq/coin-xrp": "^6.1.1-nightly.2",
     "@ledgerhq/crypto-icons-ui": "^1.14.0-nightly.0",
     "@ledgerhq/cryptoassets": "^13.17.0-nightly.1",
-    "@ledgerhq/device-core": "^0.4.25-nightly.0",
-    "@ledgerhq/errors": "^6.20.0-nightly.1",
-    "@ledgerhq/devices": "8.4.5-nightly.1",
-    "@ledgerhq/hw-app-algorand": "^6.31.1-nightly.0",
-    "@ledgerhq/hw-app-celo": "^6.33.3-nightly.0",
-    "@ledgerhq/hw-app-btc": "^10.9.1-nightly.0",
-    "@ledgerhq/hw-app-eth": "^6.45.5-nightly.0",
-    "@ledgerhq/hw-app-exchange": "^0.10.1-nightly.0",
-    "@ledgerhq/hw-app-hedera": "^1.2.1-nightly.0",
-    "@ledgerhq/hw-app-cosmos": "^6.32.1-nightly.0",
-    "@ledgerhq/hw-app-icon": "^1.3.1-nightly.0",
-    "@ledgerhq/hw-app-multiversx": "^6.24.1-nightly.0",
-    "@ledgerhq/hw-app-near": "^6.31.1-nightly.0",
-    "@ledgerhq/hw-app-aptos": "^6.34.1-nightly.0",
-    "@ledgerhq/hw-app-polkadot": "^6.34.1-nightly.0",
-    "@ledgerhq/hw-app-solana": "^7.4.1-nightly.0",
-    "@ledgerhq/hw-app-str": "^7.2.1-nightly.0",
+    "@ledgerhq/device-core": "^0.4.25-nightly.2",
+    "@ledgerhq/errors": "^6.21.0-nightly.0",
+    "@ledgerhq/hw-app-algorand": "^6.31.1-nightly.1",
+    "@ledgerhq/hw-app-aptos": "^6.34.1-nightly.1",
+    "@ledgerhq/hw-app-btc": "^10.9.1-nightly.1",
+    "@ledgerhq/hw-app-celo": "^6.33.3-nightly.2",
+    "@ledgerhq/devices": "8.4.5-nightly.2",
+    "@ledgerhq/hw-app-cosmos": "^6.32.1-nightly.1",
+    "@ledgerhq/hw-app-eth": "^6.45.5-nightly.2",
+    "@ledgerhq/hw-app-exchange": "^0.10.1-nightly.1",
+    "@ledgerhq/hw-app-hedera": "^1.2.1-nightly.1",
+    "@ledgerhq/hw-app-icon": "^1.3.1-nightly.1",
+    "@ledgerhq/hw-app-multiversx": "^6.24.1-nightly.1",
+    "@ledgerhq/hw-app-near": "^6.31.1-nightly.1",
+    "@ledgerhq/hw-app-polkadot": "^6.34.1-nightly.1",
+    "@ledgerhq/hw-app-str": "^7.2.1-nightly.1",
     "@ledgerhq/hw-app-sui": "^1.1.0",
-    "@ledgerhq/hw-app-tezos": "^6.31.1-nightly.0",
-    "@ledgerhq/hw-app-trx": "^6.31.1-nightly.0",
-    "@ledgerhq/hw-app-vet": "^0.5.3-nightly.1",
-    "@ledgerhq/hw-app-xrp": "^6.31.1-nightly.0",
-    "@ledgerhq/hw-bolos": "6.32.1-nightly.1",
-    "@ledgerhq/hw-transport": "^6.31.5-nightly.1",
-    "@ledgerhq/ledger-cal-service": "^0.4.3-nightly.0",
+    "@ledgerhq/hw-app-tezos": "^6.31.1-nightly.1",
+    "@ledgerhq/hw-app-vet": "^0.5.3-nightly.2",
+    "@ledgerhq/hw-app-trx": "^6.31.1-nightly.1",
+    "@ledgerhq/hw-app-xrp": "^6.31.1-nightly.1",
+    "@ledgerhq/hw-transport": "^6.31.5-nightly.2",
+    "@ledgerhq/hw-transport-mocker": "^6.29.5-nightly.2",
+    "@ledgerhq/ledger-cal-service": "^0.4.3-nightly.1",
     "@ledgerhq/live-config": "^3.1.0",
-    "@ledgerhq/live-countervalues": "^0.5.6-nightly.0",
-    "@ledgerhq/ledger-trust-service": "0.3.3-nightly.0",
-    "@ledgerhq/live-countervalues-react": "^0.2.35-nightly.0",
-    "@ledgerhq/hw-transport-mocker": "^6.29.5-nightly.1",
+    "@ledgerhq/live-countervalues": "^0.5.6-nightly.2",
+    "@ledgerhq/live-countervalues-react": "^0.2.35-nightly.2",
     "@ledgerhq/live-env": "^2.9.0-nightly.0",
     "@ledgerhq/live-hooks": "0.1.0",
-    "@ledgerhq/live-network": "^2.0.8-nightly.0",
-    "@ledgerhq/live-nft": "^0.8.6-nightly.0",
+    "@ledgerhq/live-network": "^2.0.8-nightly.1",
+    "@ledgerhq/live-nft": "^0.8.6-nightly.2",
     "@ledgerhq/live-promise": "^0.1.0",
-    "@ledgerhq/live-signer-evm": "^0.4.1-nightly.0",
-    "@ledgerhq/live-wallet": "^0.10.9-nightly.0",
+    "@ledgerhq/live-signer-solana": "^0.1.1-nightly.1",
+    "@ledgerhq/live-signer-evm": "^0.4.1-nightly.2",
+    "@ledgerhq/live-wallet": "^0.10.9-nightly.2",
     "@ledgerhq/logs": "^6.12.0",
+    "@ledgerhq/speculos-transport": "^0.2.1-nightly.1",
     "@ledgerhq/wallet-api-acre-module": "^0.5.0",
-    "@ledgerhq/speculos-transport": "^0.2.1-nightly.0",
     "@ledgerhq/wallet-api-exchange-module": "^0.13.0"
   },
   "devDependencies": {
@@ -278,10 +276,10 @@
     "undici": "6.19.2",
     "uuid": "^8.3.2",
     "ws": "7",
-    "@ledgerhq/device-react": "^0.2.31-nightly.0",
-    "@ledgerhq/types-cryptoassets": "^7.23.0",
+    "@ledgerhq/device-react": "^0.2.31-nightly.2",
     "@ledgerhq/types-devices": "^6.25.3",
-    "@ledgerhq/types-live": "^6.71.0-nightly.0"
+    "@ledgerhq/types-live": "^6.71.0-nightly.1",
+    "@ledgerhq/types-cryptoassets": "^7.23.0"
   },
   "scripts": {
     "build": "zx ./scripts/build-ts.mjs",

package/src/apps/logic.ts

@@ -5,9 +5,10 @@ import semver from "semver";
 import { getDeviceModel } from "@ledgerhq/devices";
 import { AppOp, State, Action, ListAppsResult, AppsDistribution, SkipReason } from "./types";
 import { findCryptoCurrency, findCryptoCurrencyById, isCurrencySupported } from "../currencies";
-import { LatestFirmwareVersionRequired, NoSuchAppOnProvider } from "../errors";
+import { NoSuchAppOnProvider } from "../errors";
 import { App } from "@ledgerhq/types-live";
 import { getEnv } from "@ledgerhq/live-env";
+import { LatestFirmwareVersionRequired } from "@ledgerhq/errors";
 
 export const initState = (
   { deviceModelId, appsListNames, installed, appByName, ...listAppsResult }: ListAppsResult,

package/src/errors.ts

@@ -7,10 +7,6 @@ export const GetAppAndVersionUnsupportedFormat = createCustomErrorClass(
   "GetAppAndVersionUnsupportedFormat",
 );
 
-export const LatestFirmwareVersionRequired = createCustomErrorClass(
-  "LatestFirmwareVersionRequired",
-);
-
 export const FeeEstimationFailed = createCustomErrorClass("FeeEstimationFailed");
 export const TransactionRefusedOnDevice = createCustomErrorClass("TransactionRefusedOnDevice");
 

package/src/families/solana/setup.test.ts

@@ -1,4 +1,4 @@
-import Solana from "@ledgerhq/hw-app-solana";
+import { LegacySignerSolana } from "@ledgerhq/live-signer-solana";
 import Transport from "@ledgerhq/hw-transport";
 import { Account, AnyMessage } from "@ledgerhq/types-live";
 import { PubKeyDisplayMode } from "@ledgerhq/coin-solana/signer";
@@ -29,20 +29,22 @@ const signOffchainMessageMock = jest.fn(() =>
   }),
 );
 
-jest.mock("@ledgerhq/hw-app-solana", () => {
-  return jest.fn().mockImplementation(() => {
-    return {
-      signOffchainMessage: signOffchainMessageMock,
-      getAppConfiguration: getAppConfigurationMock,
-    };
-  });
+jest.mock("@ledgerhq/live-signer-solana", () => {
+  return {
+    LegacySignerSolana: jest.fn().mockImplementation(() => {
+      return {
+        signMessage: signOffchainMessageMock,
+        getAppConfiguration: getAppConfigurationMock,
+      };
+    }),
+  };
 });
 
 LiveConfig.setConfig(solanaConfig);
 
 describe("Testing setup on Solana", () => {
   describe("Testing message signer", () => {
-    it("should call hardware for off-chain message signature", async () => {
+    it("should call the underlying signer for off-chain message signature", async () => {
       const freshAddressPath = "44'/60'/0'/0/0";
       const freshAddress = "8DpKDisipx6f76cEmuGvCX9TrA3SjeR76HaTRePxHBDe";
       const message = "4c6f6e67204f66662d436861696e2054657374204d6573736167652e";
@@ -52,7 +54,7 @@ describe("Testing setup on Solana", () => {
         { message: message } as AnyMessage,
       );
 
-      expect(Solana).toHaveBeenCalledTimes(1);
+      expect(LegacySignerSolana).toHaveBeenCalledTimes(1);
       expect(signOffchainMessageMock).toHaveBeenCalledTimes(1);
 
       const args = signOffchainMessageMock.mock.calls[0] as unknown[];

package/src/families/solana/setup.ts

@@ -1,7 +1,5 @@
 // Goal of this file is to inject all necessary device/signer dependency to coin-modules
 
-import semver from "semver";
-import Solana from "@ledgerhq/hw-app-solana";
 import Transport from "@ledgerhq/hw-transport";
 import type { Bridge } from "@ledgerhq/types-live";
 import { SolanaSigner } from "@ledgerhq/coin-solana/signer";
@@ -9,101 +7,21 @@ import { createBridges } from "@ledgerhq/coin-solana/bridge/js";
 import makeCliTools from "@ledgerhq/coin-solana/cli-transaction";
 import solanaResolver from "@ledgerhq/coin-solana/hw-getAddress";
 import { SolanaAccount, Transaction, TransactionStatus } from "@ledgerhq/coin-solana/types";
-import { DeviceModelId } from "@ledgerhq/devices";
-import { loadPKI } from "@ledgerhq/hw-bolos";
-import calService from "@ledgerhq/ledger-cal-service";
-import trustService from "@ledgerhq/ledger-trust-service";
-import { TransportStatusError, UpdateYourApp } from "@ledgerhq/errors";
 import {
   CreateSigner,
   createMessageSigner,
   createResolver,
   executeWithSigner,
 } from "../../bridge/setup";
-import { LatestFirmwareVersionRequired } from "../../errors";
 import type { Resolver } from "../../hw/getAddress/types";
 import { getCurrencyConfiguration } from "../../config";
 import { SolanaCoinConfig } from "@ledgerhq/coin-solana/config";
 import { getCryptoCurrencyById } from "../../currencies";
 import { signMessage } from "@ledgerhq/coin-solana/hw-signMessage";
+import { LegacySignerSolana } from "@ledgerhq/live-signer-solana";
 
-const TRUSTED_NAME_MIN_VERSION = "1.7.1";
-const MANAGER_APP_NAME = "Solana";
-
-async function checkVersion(app: Solana) {
-  const { version } = await app.getAppConfiguration();
-  if (semver.lt(version, TRUSTED_NAME_MIN_VERSION)) {
-    throw new UpdateYourApp(undefined, {
-      managerAppName: MANAGER_APP_NAME,
-    });
-  }
-}
-
-function isPKIUnsupportedError(err: unknown): err is TransportStatusError {
-  return err instanceof TransportStatusError && err.message.includes("0x6a81");
-}
-
-const createSigner: CreateSigner<SolanaSigner> = (transport: Transport) => {
-  const app = new Solana(transport);
-  return {
-    getAppConfiguration: app.getAppConfiguration,
-    getAddress: app.getAddress,
-    signTransaction: async (path, tx, resolution) => {
-      if (resolution) {
-        if (!resolution.deviceModelId) {
-          throw new Error("Resolution provided without a deviceModelId");
-        }
-
-        if (resolution.deviceModelId !== DeviceModelId.nanoS) {
-          const { descriptor, signature } = await calService.getCertificate(
-            resolution.deviceModelId,
-          );
-
-          try {
-            await loadPKI(transport, "TRUSTED_NAME", descriptor, signature);
-          } catch (err) {
-            if (isPKIUnsupportedError(err)) {
-              throw new LatestFirmwareVersionRequired("LatestFirmwareVersionRequired");
-            }
-          }
-
-          if (resolution.tokenAddress) {
-            await checkVersion(app);
-
-            const challenge = await app.getChallenge();
-            const { signedDescriptor } = await trustService.getOwnerAddress(
-              resolution.tokenAddress,
-              challenge,
-            );
-
-            if (signedDescriptor) {
-              await app.provideTrustedName(signedDescriptor);
-            }
-          }
-          if (resolution.createATA) {
-            await checkVersion(app);
-
-            const challenge = await app.getChallenge();
-            const { signedDescriptor } = await trustService.computedTokenAddress(
-              resolution.createATA.address,
-              resolution.createATA.mintAddress,
-              challenge,
-            );
-
-            if (signedDescriptor) {
-              await app.provideTrustedName(signedDescriptor);
-            }
-          }
-        }
-      }
-
-      return app.signTransaction(path, tx);
-    },
-    signMessage: (path: string, messageHex: string) => {
-      return app.signOffchainMessage(path, Buffer.from(messageHex, "hex"));
-    },
-  };
-};
+const createSigner: CreateSigner<SolanaSigner> = (transport: Transport) =>
+  new LegacySignerSolana(transport);
 
 const getCurrencyConfig = () => {
   return getCurrencyConfiguration<SolanaCoinConfig>(getCryptoCurrencyById("solana"));

package/src/featureFlags/defaultFeatures.ts

@@ -616,6 +616,7 @@ export const DEFAULT_FEATURES: Features = {
       chains: ["ethereum", "polygon", "base", "arbitrum"],
     },
   },
+  ldmkConnectApp: DEFAULT_FEATURE,
 };
 
 // Firebase SDK treat JSON values as strings

package/src/hw/connectApp.ts

@@ -11,6 +11,7 @@ import {
   DisconnectedDevice,
   StatusCodes,
   LockedDeviceError,
+  LatestFirmwareVersionRequired,
 } from "@ledgerhq/errors";
 import type Transport from "@ledgerhq/hw-transport";
 import { type DerivationMode, DeviceInfo, FirmwareUpdateContext } from "@ledgerhq/types-live";
@@ -25,7 +26,6 @@ import getDeviceInfo from "./getDeviceInfo";
 import getAddress from "./getAddress";
 import openApp from "./openApp";
 import quitApp from "./quitApp";
-import { LatestFirmwareVersionRequired } from "../errors";
 import { mustUpgrade } from "../apps";
 import isUpdateAvailable from "./isUpdateAvailable";
 import { LockedDeviceEvent } from "./actions/types";
@@ -479,4 +479,15 @@ const cmd = ({ deviceId, request }: Input): Observable<ConnectAppEvent> => {
   );
 };
 
-export default cmd;
+export default function connectAppFactory(
+  {
+    isLdmkConnectAppEnabled,
+  }: {
+    isLdmkConnectAppEnabled: boolean;
+  } = { isLdmkConnectAppEnabled: false },
+) {
+  if (!isLdmkConnectAppEnabled) {
+    return cmd;
+  }
+  throw new Error("LdkmConnectApp is not supported yet");
+}