@ledgerhq/live-common 31.2.0 → 31.3.0-next.0

package/src/exchange/swap/utils/index.test.ts

@@ -12,6 +12,7 @@ import {
   getNoticeType,
   shouldShowKYCBanner,
   shouldShowLoginBanner,
+  getCustomDappUrl,
 } from "./index";
 import { ValidKYCStatus } from "../types";
 
@@ -346,3 +347,32 @@ describe("swap/utils/getNoticeType", function () {
     expect(result).toEqual(expectedResult);
   });
 });
+
+describe("swap/utils/getCustomDappUrl", () => {
+  it("should convert correct paraswap URL", async () => {
+    const customDappUrl = getCustomDappUrl({
+      provider: "paraswap",
+      providerURL:
+        "/platform/paraswap/#/0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-0xdac17f958d2ee523a2206206994597c13d831ec7/0.004?network=1",
+    });
+    expect(customDappUrl).toBe(
+      "https://embedded.paraswap.io?referrer=ledger2&embed=true&enableStaking=false&displayMenu=false&enableNetworkSwitch=false&network=1#/0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-0xdac17f958d2ee523a2206206994597c13d831ec7/0.004",
+    );
+  });
+  it("should convert correct 1inch URL", async () => {
+    const customDappUrl = getCustomDappUrl({
+      provider: "oneinch",
+      providerURL: "/platform/1inch/#/1/unified/swap/eth/usdt?sourceTokenAmount=0.04",
+    });
+    expect(customDappUrl).toBe(
+      "https://app.1inch.io/#/1/simple/swap/eth/usdt?ledgerLive=true&sourceTokenAmount=0.04",
+    );
+  });
+  it("should not update URL when complete URL is provided", async () => {
+    const customDappUrl = getCustomDappUrl({
+      provider: "oneinch",
+      providerURL: "https://app.1inch.io/#/test",
+    });
+    expect(customDappUrl).toBe("https://app.1inch.io/#/test");
+  });
+});

package/src/exchange/swap/utils/index.ts

@@ -14,6 +14,13 @@ export const KYC_STATUS = {
   upgradeRequired: "upgradeRequired",
 } as const;
 
+export const FILTER = {
+  centralised: "centralised",
+  decentralised: "decentralised",
+  float: "float",
+  fixed: "fixed",
+} as const;
+
 export type KYCStatus = (typeof KYC_STATUS)[keyof typeof KYC_STATUS];
 
 export type AccountTuple = {
@@ -206,3 +213,73 @@ export const getNoticeType = (provider: string): { message: string; learnMore: b
       return { message: "default", learnMore: true };
   }
 };
+
+const isValidUrl = (urlString: string) => {
+  try {
+    return Boolean(new URL(urlString));
+  } catch (e) {
+    return false;
+  }
+};
+
+/**
+ * Get complete DAPP URL
+ * @param provider
+ * @param providerURL
+ *
+ * This Func is to ensure a complete DAPP URL is generated if partial & incorrect path is provided.
+ *
+ * Example 1:
+ *  actual: /platform/paraswap/#/0xdac17f958d2ee523a2206206994597c13d831ec7-0x2260fac5e5542a773aa44fbcfedf7c193bc2c599/21.3?network=1
+ *  expected: https://embedded.paraswap.io?referrer=ledger2&embed=true&enableStaking=false&displayMenu=false&enableNetworkSwitch=false&network=1#/0xdac17f958d2ee523a2206206994597c13d831ec7-0x2260fac5e5542a773aa44fbcfedf7c193bc2c599/21.3
+ *
+ * Example 2:
+ *  expected: /platform/1inch/#/1/unified/swap/usdt/shib?sourceTokenAmount=24.6
+ *  actual: https://app.1inch.io/#/1/simple/swap/usdt/shib?ledgerLive=true&sourceTokenAmount=24.6
+ */
+export const getCustomDappUrl = ({
+  provider,
+  providerURL = "",
+}: {
+  provider: string;
+  providerURL?: string;
+}): string => {
+  if (isValidUrl(providerURL)) {
+    return providerURL;
+  }
+
+  const dappUrl =
+    provider === "paraswap"
+      ? "https://embedded.paraswap.io/?referrer=ledger2&embed=true&enableStaking=false&displayMenu=false&enableNetworkSwitch=false"
+      : "https://app.1inch.io/?ledgerLive=true";
+  const newUrl = `https://www.prefix.com/${providerURL}`;
+  const isValidNewdUrl = isValidUrl(newUrl);
+
+  if (isValidNewdUrl) {
+    const { origin, search } = new URL(dappUrl);
+    const { hash: fragment, searchParams } = new URL(newUrl);
+    const [realFragment, query] = fragment.split("?");
+    const urlSearchParams = new URLSearchParams(query);
+    const allParams = {
+      ...Object.fromEntries(new URLSearchParams(search)),
+      ...Object.fromEntries(urlSearchParams.entries()),
+      ...Object.fromEntries(searchParams),
+    };
+
+    /**
+     * Providers should use the standard structure: query + fragment
+     *
+     * 1inch is currently not using the standard (fragment + query). To be refactored once providers follow the standard structure.
+     * @see https://www.rfc-editor.org/rfc/rfc3986#section-4.2
+     */
+    const newDappUrl =
+      provider === "oneinch"
+        ? `${origin}/${realFragment}?${new URLSearchParams(allParams).toString()}`.replace(
+            "/unified/",
+            "/simple/",
+          )
+        : `${origin}?${new URLSearchParams(allParams).toString()}${realFragment}`;
+    return newDappUrl;
+  }
+  return "";
+};

package/src/families/algorand/bridge/mock.ts

@@ -12,6 +12,7 @@ import {
   sync,
   isInvalidRecipient,
 } from "../../../bridge/mockHelpers";
+import { defaultUpdateTransaction } from "@ledgerhq/coin-framework/bridge/jsHelpers";
 import { getMainAccount } from "@ledgerhq/coin-framework/account/index";
 import { assignToAccountRaw, assignFromAccountRaw } from "@ledgerhq/coin-algorand/serialization";
 import { initAccount } from "@ledgerhq/coin-algorand/initAccount";
@@ -31,8 +32,6 @@ const createTransaction = (): AlgorandTransaction => ({
   assetId: null,
 });
 
-const updateTransaction = (t, patch) => ({ ...t, ...patch });
-
 const estimateMaxSpendable = ({ account, parentAccount, transaction }) => {
   const mainAccount = getMainAccount(account, parentAccount);
   const estimatedFees = transaction
@@ -85,7 +84,7 @@ const prepareTransaction = async (a, t) => {
 const accountBridge: AccountBridge<AlgorandTransaction> = {
   estimateMaxSpendable,
   createTransaction,
-  updateTransaction,
+  updateTransaction: defaultUpdateTransaction,
   getTransactionStatus,
   prepareTransaction,
   sync,

package/src/families/bitcoin/bridge/js.ts

@@ -9,6 +9,7 @@ import broadcast from "../js-broadcast";
 import { calculateFees } from "./../cache";
 import { perCoinLogic } from "../logic";
 import { makeAccountBridgeReceive } from "../../../bridge/jsHelpers";
+import { defaultUpdateTransaction } from "@ledgerhq/coin-framework/bridge/jsHelpers";
 import { AccountBridge, CurrencyBridge } from "@ledgerhq/types-live";
 import { assignFromAccountRaw, assignToAccountRaw } from "../serialization";
 import { withDevice } from "../../../hw/deviceAccess";
@@ -26,8 +27,8 @@ const receive = makeAccountBridgeReceive({
   },
 });
 
-const updateTransaction = (t, patch): any => {
-  const updatedT = { ...t, ...patch };
+const updateTransaction = (tx, patch): any => {
+  const updatedT = defaultUpdateTransaction(tx, patch);
 
   // We accept case-insensitive addresses as input from user,
   // but segwit addresses need to be converted to lowercase to be valid

package/src/families/bitcoin/bridge/mock.ts

@@ -17,6 +17,7 @@ import {
   sync,
   isInvalidRecipient,
 } from "../../../bridge/mockHelpers";
+import { defaultUpdateTransaction } from "@ledgerhq/coin-framework/bridge/jsHelpers";
 import { getMainAccount } from "../../../account";
 import type { Account, AccountBridge, CurrencyBridge } from "@ledgerhq/types-live";
 import cryptoFactory from "../wallet-btc/crypto/factory";
@@ -41,8 +42,6 @@ const createTransaction = (): Transaction => ({
   },
 });
 
-const updateTransaction = (t, patch): any => ({ ...t, ...patch });
-
 const estimateMaxSpendable = ({ account, parentAccount, transaction }): Promise<BigNumber> => {
   const mainAccount = getMainAccount(account, parentAccount);
   const estimatedFees = transaction
@@ -121,7 +120,7 @@ const prepareTransaction = async (
 const accountBridge: AccountBridge<Transaction> = {
   estimateMaxSpendable,
   createTransaction,
-  updateTransaction,
+  updateTransaction: defaultUpdateTransaction,
   getTransactionStatus,
   prepareTransaction,
   sync,

package/src/families/bitcoin/hw-signMessage.ts

@@ -1,10 +1,14 @@
 import Btc from "@ledgerhq/hw-app-btc";
 import type { SignMessage } from "../../hw/signMessage/types";
 
-const signMessage: SignMessage = async (transport, { path, message }) => {
+const signMessage: SignMessage = async (transport, account, { message }) => {
+  if (typeof message !== "string") {
+    throw new Error("Invalid message type");
+  }
+
   const btc = new Btc({ transport });
-  const hexMessage = Buffer.from(message as string).toString("hex");
-  const result = await btc.signMessage(path, hexMessage);
+  const hexMessage = Buffer.from(message).toString("hex");
+  const result = await btc.signMessage(account.freshAddressPath, hexMessage);
   const v = result["v"] + 27 + 4;
   const signature = Buffer.from(`${v.toString(16)}${result["r"]}${result["s"]}`, "hex").toString(
     "base64",

package/src/families/bitcoin/logic.ts

@@ -216,7 +216,8 @@ export const mapTxToOperations = (
       : tx.outputs.map(o => o.output_index).reduce((p, c) => (p > c ? p : c));
 
   for (const output of tx.outputs) {
-    if (output.address) {
+    // ledger explorer returns "unknown" as recipient for OP_RETURN outputs, we don't want to display it in our UI
+    if (output.address && !output.address.includes("unknown")) {
       if (!accountAddresses.has(output.address)) {
         // The output doesn't belong to this account
         if (

package/src/families/bitcoin/logic.unit.test.ts

@@ -0,0 +1,54 @@
+import { mapTxToOperations } from "./logic";
+import { TX } from "./wallet-btc";
+
+describe("mapTxToOperations", () => {
+  it("should filter out outputs that have unknown in their address", () => {
+    const ops = mapTxToOperations(
+      {
+        outputs: [
+          {
+            address: "<unknown>",
+          },
+        ],
+        inputs: [],
+      } as unknown as TX,
+      "bitcoin",
+      "accountId",
+      new Set(["myAddress"]),
+      new Set(["changeAddress"]),
+    );
+    expect(ops.length).toEqual(0);
+  });
+
+  it("should filter out outputs that have no address", () => {
+    const ops = mapTxToOperations(
+      {
+        outputs: [{}],
+        inputs: [],
+      } as unknown as TX,
+      "bitcoin",
+      "accountId",
+      new Set(["myAddress"]),
+      new Set(["changeAddress"]),
+    );
+    expect(ops.length).toEqual(0);
+  });
+
+  it("shouldn't filter out outputs with address", () => {
+    const ops = mapTxToOperations(
+      {
+        outputs: [
+          {
+            address: "myAddress",
+          },
+        ],
+        inputs: [],
+      } as unknown as TX,
+      "bitcoin",
+      "accountId",
+      new Set(["myAddress"]),
+      new Set(["changeAddress"]),
+    );
+    expect(ops.length).toEqual(1);
+  });
+});

package/src/families/bitcoin/specs.ts

@@ -77,32 +77,24 @@ const genericTest = ({
   });
 
   botTest("operation matches tx senders and recipients", () => {
-    if (transaction.opReturnData) {
-      // transaction.recipient has format <coinId>:<address>
-      const [, recipientAddress] = transaction.recipient.split(":");
-      expect(operation.recipients).toContain(recipientAddress);
-      expect(operation.recipients.length).toBe(2);
-    } else {
-      let expectedSenders = nonDeterministicPicking
-        ? operation.senders
-        : (txInputs!.map(t => t.address).filter(Boolean) as string[]);
+    let expectedSenders = nonDeterministicPicking
+      ? operation.senders
+      : (txInputs!.map(t => t.address).filter(Boolean) as string[]);
 
-      let expectedRecipients = txOutputs!
-        .filter(o => o.address && !o.isChange)
-        .map(o => o.address) as string[];
+    let expectedRecipients = txOutputs!
+      .filter(o => o.address && !o.isChange)
+      .map(o => o.address) as string[];
 
-      if (account.currency.id === "bitcoin_cash") {
-        expectedSenders = expectedSenders.map(bchToCashaddrAddressWithoutPrefix);
-        expectedRecipients = expectedRecipients.map(bchToCashaddrAddressWithoutPrefix);
-      }
-
-      expect(asSorted(operation)).toMatchObject(
-        asSorted({
-          senders: expectedSenders,
-          recipients: expectedRecipients,
-        }),
-      );
+    if (account.currency.id === "bitcoin_cash") {
+      expectedSenders = expectedSenders.map(bchToCashaddrAddressWithoutPrefix);
+      expectedRecipients = expectedRecipients.map(bchToCashaddrAddressWithoutPrefix);
     }
+    expect(asSorted(operation)).toMatchObject(
+      asSorted({
+        senders: expectedSenders,
+        recipients: expectedRecipients,
+      }),
+    );
   });
 
   const utxosPicked = ((status as TransactionStatus).txInputs || [])
@@ -124,7 +116,7 @@ const genericTest = ({
 
 const testDestination = genericTestDestination;
 
-const genericMinimalAmount = new BigNumber(10000);
+const genericMinimalAmount = new BigNumber(15000);
 
 const bitcoinLikeMutations = ({
   minimalAmount = genericMinimalAmount,
@@ -212,7 +204,11 @@ const bitcoinLikeMutations = ({
         ...bridge.createTransaction(account),
         feePerByte: new BigNumber(0.0001),
       };
-      const utxo = sample((bitcoinResources as BitcoinResources).utxos.filter(u => u.blockHeight));
+      const utxo = sample(
+        (bitcoinResources as BitcoinResources).utxos.filter(
+          u => u.blockHeight && u.value.gt(genericMinimalAmount),
+        ),
+      );
       invariant(utxo, "no confirmed utxo");
       return {
         transaction,
@@ -446,6 +442,7 @@ const pivx: AppSpec<Transaction> = {
   mutations: bitcoinLikeMutations(),
   minViableAmount: genericMinimalAmount,
 };
+const minQtum = parseCurrencyUnit(getCryptoCurrencyById("qtum").units[0], "0.001");
 const qtum: AppSpec<Transaction> = {
   name: "Qtum",
   currency: getCryptoCurrencyById("qtum"),
@@ -457,8 +454,10 @@ const qtum: AppSpec<Transaction> = {
   },
   genericDeviceAction: acceptTransaction,
   test: genericTest,
-  mutations: bitcoinLikeMutations(),
-  minViableAmount: genericMinimalAmount,
+  mutations: bitcoinLikeMutations({
+    minimalAmount: minQtum,
+  }),
+  minViableAmount: minQtum,
 };
 const vertcoin: AppSpec<Transaction> = {
   name: "Vertcoin",
@@ -474,6 +473,7 @@ const vertcoin: AppSpec<Transaction> = {
   mutations: bitcoinLikeMutations(),
   minViableAmount: genericMinimalAmount,
 };
+const minViacoin = parseCurrencyUnit(getCryptoCurrencyById("viacoin").units[0], "0.001");
 const viacoin: AppSpec<Transaction> = {
   name: "Viacoin",
   currency: getCryptoCurrencyById("viacoin"),
@@ -485,8 +485,10 @@ const viacoin: AppSpec<Transaction> = {
   },
   genericDeviceAction: acceptTransaction,
   test: genericTest,
-  mutations: bitcoinLikeMutations(),
-  minViableAmount: genericMinimalAmount,
+  mutations: bitcoinLikeMutations({
+    minimalAmount: minViacoin,
+  }),
+  minViableAmount: minViacoin,
 };
 const minDash = parseCurrencyUnit(getCryptoCurrencyById("dash").units[0], "0.001");
 const dash: AppSpec<Transaction> = {

package/src/families/bitcoin/wallet-btc/crypto/doge.ts

@@ -4,7 +4,9 @@ class Doge extends Base {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   constructor({ network }: { network: any }) {
     super({ network });
-    this.network.dustThreshold = 10000;
+    // https://github.com/dogecoin/dogecoin/blob/master/doc/fee-recommendation.md
+    // set 0.01 DOGE as dustThreshold
+    this.network.dustThreshold = 1000000;
     this.network.dustPolicy = "FIXED";
     this.network.usesTimestampedTransaction = false;
   }

package/src/families/bitcoin/wallet-btc/crypto/qtum.ts

@@ -4,7 +4,7 @@ class Qtum extends Base {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   constructor({ network }: { network: any }) {
     super({ network });
-    this.network.dustThreshold = 10000;
+    this.network.dustThreshold = 100000;
     this.network.dustPolicy = "FIXED";
     this.network.usesTimestampedTransaction = false;
   }

package/src/families/bitcoin/wallet-btc/crypto/via.ts

@@ -4,7 +4,7 @@ class ViaCoin extends Base {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   constructor({ network }: { network: any }) {
     super({ network });
-    this.network.dustThreshold = 10000;
+    this.network.dustThreshold = 100000;
     this.network.dustPolicy = "FIXED";
     this.network.usesTimestampedTransaction = false;
   }

package/src/families/cardano/bridge/js.ts

@@ -1,11 +1,12 @@
 import type { Transaction } from "../types";
 import { SignerContext, scanAccounts, sync } from "../js-synchronisation";
 import estimateMaxSpendable from "../js-estimateMaxSpendable";
-import { createTransaction, prepareTransaction, updateTransaction } from "../js-transaction";
+import { createTransaction, prepareTransaction } from "../js-transaction";
 import getTransactionStatus from "../js-getTransactionStatus";
 import signOperation from "../js-signOperation";
 import broadcast from "../js-broadcast";
 import { makeAccountBridgeReceive } from "../../../bridge/jsHelpers";
+import { defaultUpdateTransaction } from "@ledgerhq/coin-framework/bridge/jsHelpers";
 import type { AccountBridge, CurrencyBridge } from "@ledgerhq/types-live";
 import { assignToAccountRaw, assignFromAccountRaw } from "../serialization";
 import Ada, { ExtendedPublicKey } from "@cardano-foundation/ledgerjs-hw-app-cardano";
@@ -24,7 +25,7 @@ const signerContext: SignerContext = (
 const accountBridge: AccountBridge<Transaction> = {
   estimateMaxSpendable,
   createTransaction,
-  updateTransaction,
+  updateTransaction: defaultUpdateTransaction,
   getTransactionStatus,
   prepareTransaction,
   sync: sync(signerContext),

package/src/families/cardano/js-transaction.ts

@@ -1,7 +1,8 @@
 import { BigNumber } from "bignumber.js";
-import { CardanoAccount, Transaction } from "./types";
 import { types as TyphonTypes, address as TyphonAddress } from "@stricahq/typhonjs";
+import { defaultUpdateTransaction } from "@ledgerhq/coin-framework/bridge/jsHelpers";
 
+import { CardanoAccount, Transaction } from "./types";
 import { buildTransaction } from "./js-buildTransaction";
 
 /**
@@ -18,17 +19,6 @@ export const createTransaction = (): Transaction => ({
   fees: new BigNumber(0),
 });
 
-/**
- * Apply patch to transaction
- *
- * @param {*} t
- * @param {*} patch
- */
-export const updateTransaction = (t: Transaction, patch: Partial<Transaction>): Transaction => ({
-  ...t,
-  ...patch,
-});
-
 /**
  * Prepare transaction before checking status
  *
@@ -39,25 +29,26 @@ export const prepareTransaction = async (
   a: CardanoAccount,
   t: Transaction,
 ): Promise<Transaction> => {
-  let transaction;
+  let patch = {};
   try {
-    transaction = await buildTransaction(a, t);
+    const cardanoTransaction = await buildTransaction(a, t);
+    const transactionFees = cardanoTransaction.getFee();
+    const transactionAmount = t.subAccountId
+      ? t.amount
+      : cardanoTransaction
+          .getOutputs()
+          .filter(
+            o =>
+              !(o.address instanceof TyphonAddress.BaseAddress) ||
+              !(o.address.paymentCredential.type === TyphonTypes.HashType.ADDRESS) ||
+              o.address.paymentCredential.bipPath === undefined,
+          )
+          .reduce((total, o) => total.plus(o.amount), new BigNumber(0));
+
+    patch = { fees: transactionFees, amount: transactionAmount };
   } catch (error) {
-    return { ...t, fees: new BigNumber(0), amount: t.amount };
+    patch = { fees: new BigNumber(0), amount: t.amount };
   }
 
-  const transactionFees = transaction.getFee();
-  const transactionAmount = t.subAccountId
-    ? t.amount
-    : transaction
-        .getOutputs()
-        .filter(
-          o =>
-            !(o.address instanceof TyphonAddress.BaseAddress) ||
-            !(o.address.paymentCredential.type === TyphonTypes.HashType.ADDRESS) ||
-            o.address.paymentCredential.bipPath === undefined,
-        )
-        .reduce((total, o) => total.plus(o.amount), new BigNumber(0));
-
-  return { ...t, fees: transactionFees, amount: transactionAmount };
+  return defaultUpdateTransaction(t, patch);
 };

package/src/families/celo/bridge/js.ts

@@ -1,6 +1,7 @@
 import type { AccountBridge, CurrencyBridge } from "@ledgerhq/types-live";
 import type { Transaction } from "../types";
 import { makeAccountBridgeReceive } from "../../../bridge/jsHelpers";
+import { defaultUpdateTransaction } from "@ledgerhq/coin-framework/bridge/jsHelpers";
 import { sync, scanAccounts } from "../js-synchronisation";
 import { getPreloadStrategy, preload, hydrate } from "../preload";
 import signOperation from "../js-signOperation";
@@ -11,8 +12,6 @@ import prepareTransaction from "../js-prepareTransaction";
 import createTransaction from "../js-createTransaction";
 import { assignFromAccountRaw, assignToAccountRaw } from "../serialization";
 
-const updateTransaction = (t, patch) => ({ ...t, ...patch });
-
 const receive = makeAccountBridgeReceive();
 
 const currencyBridge: CurrencyBridge = {
@@ -24,7 +23,7 @@ const currencyBridge: CurrencyBridge = {
 const accountBridge: AccountBridge<Transaction> = {
   estimateMaxSpendable,
   createTransaction,
-  updateTransaction,
+  updateTransaction: defaultUpdateTransaction,
   getTransactionStatus,
   prepareTransaction,
   sync,

package/src/families/cosmos/bridge/js.test.ts

@@ -0,0 +1,47 @@
+import { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
+import currencyBridge from "./js";
+jest.mock("../chain/chain");
+import cryptoFactory from "../chain/chain";
+jest.mock("../CosmosValidatorsManager");
+import cosmosBase from "../chain/cosmosBase";
+const mockedCryptoFactory = jest.mocked(cryptoFactory);
+
+describe("currencyBridge", () => {
+  describe("hydrate", () => {
+    afterEach(() => {
+      jest.resetAllMocks();
+    });
+
+    const currencyMock = {} as CryptoCurrency;
+    it("shouldn't update configuration if data is undefined", () => {
+      currencyBridge.currencyBridge.hydrate(undefined, currencyMock);
+      expect(mockedCryptoFactory).not.toHaveBeenCalled();
+    });
+
+    it("shouldn't update configuration if data is not an object", () => {
+      currencyBridge.currencyBridge.hydrate("definitely not an object", currencyMock);
+      expect(mockedCryptoFactory).not.toHaveBeenCalled();
+    });
+
+    it("should update configuration if data is an object", () => {
+      const config = {
+        lcd: "oldLcd",
+        minGasPrice: 42,
+        ledgerValidator: "oldAddress",
+      };
+      const newConfig = {
+        lcd: "lcdUrl",
+        minGasPrice: 1,
+        ledgerValidator: "ledgerValidatorAddress",
+      };
+      mockedCryptoFactory.mockReturnValue(config as cosmosBase);
+      currencyBridge.currencyBridge.hydrate(
+        {
+          config: newConfig,
+        },
+        currencyMock,
+      );
+      expect(config).toMatchObject(newConfig);
+    });
+  });
+});

package/src/families/cosmos/bridge/js.ts

@@ -45,12 +45,12 @@ const currencyBridge: CurrencyBridge = {
     currency: CryptoCurrency,
   ) => {
     if (!data || typeof data !== "object") return;
-    const { validators } = data;
-    if (!validators || typeof validators !== "object" || !Array.isArray(validators)) return;
     const relatedImpl = cryptoFactory(currency.id);
     relatedImpl.lcd = data.config.lcd;
     relatedImpl.minGasPrice = data.config.minGasPrice;
     relatedImpl.ledgerValidator = data.config.ledgerValidator;
+    const { validators } = data;
+    if (!validators || typeof validators !== "object" || !Array.isArray(validators)) return;
     const cosmosValidatorsManager = new CosmosValidatorsManager(getCryptoCurrencyById(currency.id));
     cosmosValidatorsManager.hydrateValidators(validators);
     setCosmosPreloadData(currency.id, asSafeCosmosPreloadData(data));

package/src/families/cosmos/bridge/mock.ts

@@ -7,11 +7,12 @@ import {
   broadcast,
   sync,
   isInvalidRecipient,
+  makeAccountBridgeReceive,
 } from "../../../bridge/mockHelpers";
+import { defaultUpdateTransaction } from "@ledgerhq/coin-framework/bridge/jsHelpers";
 import { setCosmosPreloadData, asSafeCosmosPreloadData } from "../preloadedData";
 import { getMainAccount } from "../../../account";
 import mockPreloadedData from "../preloadedData.mock";
-import { makeAccountBridgeReceive } from "../../../bridge/mockHelpers";
 import type { Account, AccountBridge, CurrencyBridge } from "@ledgerhq/types-live";
 const receive = makeAccountBridgeReceive();
 
@@ -31,8 +32,6 @@ const createTransaction = (): Transaction => ({
   useAllAmount: false,
 });
 
-const updateTransaction = (t, patch) => ({ ...t, ...patch });
-
 const estimateMaxSpendable = ({ account, parentAccount, transaction }) => {
   const mainAccount = getMainAccount(account, parentAccount);
   const estimatedFees = transaction
@@ -93,7 +92,7 @@ const prepareTransaction = async (a: CosmosAccount, t: Transaction): Promise<Tra
 const accountBridge: AccountBridge<Transaction> = {
   estimateMaxSpendable,
   createTransaction,
-  updateTransaction,
+  updateTransaction: defaultUpdateTransaction,
   getTransactionStatus,
   prepareTransaction,
   sync,