@ledgerhq/live-common 27.3.2 → 27.4.0-next.1

package/src/families/bitcoin/account.ts

@@ -5,7 +5,7 @@ import { perCoinLogic } from "./logic";
 
 const sortUTXO = (a, b) => b.value.minus(a.value).toNumber();
 
-function injectGetAddressParams(account: BitcoinAccount) {
+function injectGetAddressParams(account: BitcoinAccount): any {
   const perCoin = perCoinLogic[account.currency.id];
 
   if (perCoin && perCoin.injectGetAddressParams) {

package/src/families/bitcoin/bech32m.ts

@@ -114,12 +114,12 @@ function __decode(str: string, LIMIT?: number) {
   return { prefix, words };
 }
 
-function decodeUnsafe(str: string, LIMIT?: number) {
+function decodeUnsafe(str: string, LIMIT?: number): any {
   const res = __decode(str, LIMIT);
   if (typeof res === "object") return res;
 }
 
-function decode(str: string, LIMIT?: number) {
+function decode(str: string, LIMIT?: number): any {
   const res = __decode(str, LIMIT);
   if (typeof res === "object") return res;
 

package/src/families/bitcoin/bridge/js.ts

@@ -11,6 +11,7 @@ import { perCoinLogic } from "../logic";
 import { makeAccountBridgeReceive } from "../../../bridge/jsHelpers";
 import * as explorerConfigAPI from "../../../api/explorerConfig";
 import { AccountBridge, CurrencyBridge } from "@ledgerhq/types-live";
+import { FullConfigOverrides } from "../../../api/explorerConfig/types";
 
 const receive = makeAccountBridgeReceive({
   injectGetAddressParams: (account) => {
@@ -22,7 +23,7 @@ const receive = makeAccountBridgeReceive({
   },
 });
 
-const updateTransaction = (t, patch) => {
+const updateTransaction = (t, patch): any => {
   const updatedT = { ...t, ...patch };
 
   // We accept case-insensitive addresses as input from user,
@@ -34,14 +35,16 @@ const updateTransaction = (t, patch) => {
   return updatedT;
 };
 
-const preload = async () => {
+const preload = async (): Promise<{
+  explorerConfig: FullConfigOverrides | null | undefined;
+}> => {
   const explorerConfig = await explorerConfigAPI.preload();
   return {
     explorerConfig,
   };
 };
 
-const hydrate = (maybeConfig: any) => {
+const hydrate = (maybeConfig: any): void => {
   if (
     typeof maybeConfig === "object" &&
     maybeConfig &&

package/src/families/bitcoin/bridge/mock.ts

@@ -37,9 +37,13 @@ const createTransaction = (): Transaction => ({
   },
 });
 
-const updateTransaction = (t, patch) => ({ ...t, ...patch });
+const updateTransaction = (t, patch): any => ({ ...t, ...patch });
 
-const estimateMaxSpendable = ({ account, parentAccount, transaction }) => {
+const estimateMaxSpendable = ({
+  account,
+  parentAccount,
+  transaction,
+}): Promise<BigNumber> => {
   const mainAccount = getMainAccount(account, parentAccount);
   const estimatedFees = transaction
     ? defaultGetFees(mainAccount, transaction)

package/src/families/bitcoin/js-getFeesForTransaction.ts

@@ -10,7 +10,7 @@ const getFeesForTransaction = async ({
 }: {
   account: Account;
   transaction: Transaction;
-}) => {
+}): Promise<{ fees: BigNumber; txInputs: any; txOutputs: any }> => {
   const walletTx = await buildTransaction(account, transaction);
   const fees = new BigNumber(walletTx.fee).integerValue();
   let txInputs = walletTx.inputs.map((i) => {

package/src/families/bitcoin/js-synchronisation.ts

@@ -164,7 +164,6 @@ const getAccountShape: GetAccountShape = async (info) => {
   const blockHeight = currentBlock?.height;
 
   span = startSpan("sync", "getAccountTransactions");
-  // @ts-expect-error return from wallet-btc should be typed
   const { txs: transactions } = await wallet.getAccountTransactions(
     walletAccount
   );

package/src/families/bitcoin/logic.ts

@@ -35,7 +35,10 @@ const minFees = {
 };
 export const getMinRelayFee = (currency: CryptoCurrency): number =>
   minFees[currency.id] || 0;
-export const inferFeePerByte = (t: Transaction, networkInfo: NetworkInfo) => {
+export const inferFeePerByte = (
+  t: Transaction,
+  networkInfo: NetworkInfo
+): BigNumber => {
   if (t.feesStrategy) {
     const speed = networkInfo.feeItems.items.find(
       (item) => t.feesStrategy === item.speed
@@ -137,7 +140,7 @@ type CoinLogic = {
   injectGetAddressParams?: (arg0: Account) => any;
 };
 
-export const bchToCashaddrAddressWithoutPrefix = (recipient) =>
+export const bchToCashaddrAddressWithoutPrefix = (recipient): string =>
   recipient ? recipient.substring(recipient.indexOf(":") + 1) : recipient;
 
 export const perCoinLogic: Record<

package/src/families/bitcoin/presync.ts

@@ -1,6 +1,6 @@
 import type { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
 import { requiresSatStackReady } from "./satstack";
-export default async function presync(currency: CryptoCurrency) {
+export default async function presync(currency: CryptoCurrency): Promise<void> {
   if (currency.id === "bitcoin") {
     await requiresSatStackReady();
   }

package/src/families/bitcoin/specs.ts

@@ -56,7 +56,7 @@ const genericTest = ({
   transaction,
   status,
   accountBeforeTransaction,
-}) => {
+}): void => {
   invariant(
     Date.now() - operation.date < 1000000,
     "operation time to be recent"

package/src/families/bitcoin/wallet-btc/crypto/base.ts

@@ -1,8 +1,6 @@
 // from https://github.com/LedgerHQ/xpub-scan/blob/master/src/actions/deriveAddresses.ts
 
 import * as bjs from "bitcoinjs-lib";
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
 import { toOutputScript } from "bitcoinjs-lib/src/address";
 import bs58check from "bs58check";
 import { DerivationModes } from "../types";
@@ -27,12 +25,10 @@ export function fallbackValidateAddress(address: string): boolean {
 }
 
 class Base implements ICrypto {
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   network: any;
   protected static bip32Cache = {}; // xpub + account + index to publicKey
   public static addressCache = {}; // derivationMode + xpub + account + index to address
 
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   constructor({ network }: { network: any }) {
     this.network = network;
     this.network.dustThreshold = 3000;
@@ -181,22 +177,6 @@ class Base implements ICrypto {
     }
   }
 
-  // infer address type from its syntax
-  getDerivationMode(address: string): DerivationModes {
-    if (address.match("^(bc1|tb1).*")) {
-      return DerivationModes.NATIVE_SEGWIT;
-    }
-    if (address.match("^(3|2|M).*")) {
-      return DerivationModes.SEGWIT;
-    }
-    if (address.match("^(1|n|m|L).*")) {
-      return DerivationModes.LEGACY;
-    }
-    throw new Error(
-      "INVALID ADDRESS: ".concat(address).concat(" is not a valid address")
-    );
-  }
-
   toOutputScript(address: string): Buffer {
     return toOutputScript(address, this.network);
   }

package/src/families/bitcoin/wallet-btc/crypto/bip32.ts

@@ -4,14 +4,15 @@ import { getSecp256k1Instance } from "./secp256k1";
 
 // the BIP32 class is inspired from https://github.com/bitcoinjs/bip32/blob/master/src/bip32.js
 class BIP32 {
-  publicKey: any;
-  chainCode: any;
+  publicKey: Buffer;
+  chainCode: Buffer;
   network: any;
   depth: number;
   index: number;
   constructor(
-    publicKey: any,
-    chainCode: any,
+    publicKey: Buffer,
+    chainCode: Buffer,
+    // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
     network: any,
     depth = 0,
     index = 0
@@ -24,7 +25,7 @@ class BIP32 {
     this.depth = depth;
     this.index = index;
   }
-  async derive(index: number) {
+  async derive(index: number): Promise<BIP32> {
     const data = Buffer.allocUnsafe(37);
     this.publicKey.copy(data, 0);
     data.writeUInt32BE(index, 33);

package/src/families/bitcoin/wallet-btc/crypto/bitcoincash.ts

@@ -1,9 +1,6 @@
 import bchaddr from "bchaddrjs";
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
 import { toOutputScript } from "bitcoinjs-lib/src/address";
 import { InvalidAddress } from "@ledgerhq/errors";
-import { DerivationModes } from "../types";
 import Base from "./base";
 
 // a mock explorer class that just use js objects
@@ -41,12 +38,7 @@ class BitcoinCash extends Base {
     return await this.getLegacyBitcoinCashAddress(xpub, account, index);
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  getDerivationMode(address: string) {
-    return DerivationModes.LEGACY;
-  }
-
-  toOutputScript(address: string) {
+  toOutputScript(address: string): Buffer {
     if (!this.validateAddress(address)) {
       throw new InvalidAddress();
     }

package/src/families/bitcoin/wallet-btc/crypto/factory.ts

@@ -1,11 +1,8 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
 import coininfo from "coininfo";
 import { Currency, ICrypto } from "./types";
 import * as crypto from "./index";
 
-export default function cryptoFactory(currency: Currency) {
+export default function cryptoFactory(currency: Currency): ICrypto {
   let res: ICrypto;
   switch (currency) {
     case "bitcoin": {

package/src/families/bitcoin/wallet-btc/crypto/litecoin.ts

@@ -1,8 +1,5 @@
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
 import { toOutputScript } from "bitcoinjs-lib/src/address";
 import * as bech32 from "bech32";
-import { DerivationModes } from "../types";
 import Base from "./base";
 
 // Todo copy paste from bitcoin.ts. we can merge them later
@@ -18,23 +15,7 @@ class Litecoin extends Base {
     this.network.usesTimestampedTransaction = false;
   }
 
-  // infer address type from its syntax
-  getDerivationMode(address: string) {
-    if (address.match("^(ltc1).*")) {
-      return DerivationModes.NATIVE_SEGWIT;
-    }
-    if (address.match("^(3|2|M).*")) {
-      return DerivationModes.SEGWIT;
-    }
-    if (address.match("^(1|n|m|L).*")) {
-      return DerivationModes.LEGACY;
-    }
-    throw new Error(
-      "INVALID ADDRESS: ".concat(address).concat(" is not a valid address")
-    );
-  }
-
-  toOutputScript(address: string) {
+  toOutputScript(address: string): Buffer {
     return toOutputScript(address, this.network);
   }
 

package/src/families/bitcoin/wallet-btc/crypto/types.ts

@@ -13,9 +13,6 @@ export interface ICrypto {
     account: number,
     index: number
   ): Promise<string>;
-
-  getDerivationMode(address: string): string;
-
   toOutputScript(address: string): Buffer;
   validateAddress(address: string): boolean;
   isTaprootAddress(address: string): boolean;

package/src/families/bitcoin/wallet-btc/crypto/zec.ts

@@ -1,7 +1,6 @@
 import bs58check from "bs58check";
 import * as bjs from "bitcoinjs-lib";
 import { InvalidAddress } from "@ledgerhq/errors";
-import { DerivationModes } from "../types";
 import Base from "./base";
 
 class ZCash extends Base {
@@ -44,12 +43,7 @@ class ZCash extends Base {
     return await this.getLegacyAddress(xpub, account, index);
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  getDerivationMode(address: string) {
-    return DerivationModes.LEGACY;
-  }
-
-  toOutputScript(address: string) {
+  toOutputScript(address: string): Buffer {
     if (!this.validateAddress(address)) {
       throw new InvalidAddress();
     }

package/src/families/bitcoin/wallet-btc/crypto/zen.ts

@@ -1,6 +1,5 @@
 import bs58check from "bs58check";
 import { InvalidAddress } from "@ledgerhq/errors";
-import { DerivationModes } from "../types";
 import Base from "./base";
 import * as bjs from "bitcoinjs-lib";
 
@@ -62,12 +61,7 @@ class Zen extends Base {
     return await this.getLegacyAddress(xpub, account, index);
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  getDerivationMode(address: string) {
-    return DerivationModes.LEGACY;
-  }
-
-  toOutputScript(address: string) {
+  toOutputScript(address: string): Buffer {
     if (!this.validateAddress(address)) {
       throw new InvalidAddress();
     }

package/src/families/bitcoin/wallet-btc/explorer/index.ts

@@ -6,7 +6,6 @@ import genericPool, { Pool } from "generic-pool";
 
 import JSONBigNumber from "@ledgerhq/json-bignumber";
 import { Address, Block, TX } from "../storage/types";
-import EventEmitter from "../utils/eventemitter";
 import { IExplorer } from "./types";
 import {
   requestInterceptor,
@@ -14,7 +13,15 @@ import {
   errorInterceptor,
 } from "../../../../network";
 
-class BitcoinLikeExplorer extends EventEmitter implements IExplorer {
+type ExplorerParams = {
+  no_token?: string;
+  noToken?: string;
+  batch_size?: number;
+  block_hash?: string;
+  blockHash?: string;
+};
+
+class BitcoinLikeExplorer implements IExplorer {
   client: Pool<{ client: AxiosInstance }>;
 
   underlyingClient: AxiosInstance;
@@ -32,8 +39,6 @@ class BitcoinLikeExplorer extends EventEmitter implements IExplorer {
     explorerVersion: "v2" | "v3";
     disableBatchSize?: boolean;
   }) {
-    super();
-
     const clientParams: AxiosRequestConfig = {
       baseURL: explorerURI,
     };
@@ -82,7 +87,7 @@ class BitcoinLikeExplorer extends EventEmitter implements IExplorer {
     client.interceptors.response.use(responseInterceptor, errorInterceptor);
   }
 
-  async broadcast(tx: string) {
+  async broadcast(tx: string): Promise<any> {
     const url = "/transactions/send";
     const client = await this.client.acquire();
     const res = await client.client.post(url, { tx });
@@ -90,32 +95,24 @@ class BitcoinLikeExplorer extends EventEmitter implements IExplorer {
     return res;
   }
 
-  async getTxHex(txId: string) {
+  async getTxHex(txId: string): Promise<string> {
     const url = `/transactions/${txId}/hex`;
 
-    this.emit("fetching-transaction-tx", { url, txId });
-
     // TODO add a test for failure (at the sync level)
     const client = await this.client.acquire();
     const res: any = (await client.client.get(url)).data;
     await this.client.release(client);
 
-    this.emit("fetched-transaction-tx", { url, tx: res[0] });
-
     return res[0].hex;
   }
 
-  async getCurrentBlock() {
+  async getCurrentBlock(): Promise<Block | null> {
     const url = `/blocks/current`;
 
-    this.emit("fetching-block", { url });
-
     const client = await this.client.acquire();
     const res: any = (await client.client.get(url)).data;
     await this.client.release(client);
 
-    this.emit("fetched-block", { url, block: res });
-
     if (!res) {
       return null;
     }
@@ -129,17 +126,13 @@ class BitcoinLikeExplorer extends EventEmitter implements IExplorer {
     return block;
   }
 
-  async getBlockByHeight(height: number) {
+  async getBlockByHeight(height: number): Promise<Block | null> {
     const url = `/blocks/${height}`;
 
-    this.emit("fetching-block", { url, height });
-
     const client = await this.client.acquire();
     const res: any = (await client.client.get(url)).data;
     await this.client.release(client);
 
-    this.emit("fetched-block", { url, block: res[0] });
-
     if (!res[0]) {
       return null;
     }
@@ -153,36 +146,26 @@ class BitcoinLikeExplorer extends EventEmitter implements IExplorer {
     return block;
   }
 
-  async getFees() {
+  async getFees(): Promise<any> {
     const url = `/fees`;
 
-    this.emit("fetching-fees", { url });
-
     // TODO add a test for failure (at the sync level)
     const client = await this.client.acquire();
     const fees = (await client.client.get(url)).data;
     await this.client.release(client);
 
-    this.emit("fetching-fees", { url, fees });
-
     return fees;
   }
 
-  async getRelayFee() {
+  async getRelayFee(): Promise<number> {
     const client = await this.client.acquire();
     const fees = (await client.client.get(`/network`)).data;
     await this.client.release(client);
     return parseFloat(fees["relay_fee"]);
   }
 
-  async getPendings(address: Address, nbMax?: number) {
-    const params: {
-      no_token?: string;
-      noToken?: string;
-      batch_size?: number;
-      block_hash?: string;
-      blockHash?: string;
-    } =
+  async getPendings(address: Address, nbMax?: number): Promise<TX[]> {
+    const params: ExplorerParams =
       this.explorerVersion === "v2"
         ? {
             noToken: "true",
@@ -199,12 +182,12 @@ class BitcoinLikeExplorer extends EventEmitter implements IExplorer {
     return pendingsTxs;
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  async fetchTxs(address: Address, params: any) {
+  async fetchTxs(
+    address: Address,
+    params: ExplorerParams
+  ): Promise<{ txs: TX[] }> {
     const url = `/addresses/${address.address}/transactions`;
 
-    this.emit("fetching-address-transaction", { url, params });
-
     // TODO add a test for failure (at the sync level)
     const client = await this.client.acquire();
     let res: { txs: TX[] } = { txs: [] };
@@ -229,12 +212,10 @@ class BitcoinLikeExplorer extends EventEmitter implements IExplorer {
     } finally {
       await this.client.release(client);
     }
-    this.emit("fetched-address-transaction", { url, params, res });
     return res;
   }
 
-  // eslint-disable-next-line class-methods-use-this,@typescript-eslint/no-explicit-any
-  hydrateTx(address: Address, tx: TX) {
+  hydrateTx(address: Address, tx: TX): void {
     // no need to keep those as they change
     // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
@@ -281,14 +262,8 @@ class BitcoinLikeExplorer extends EventEmitter implements IExplorer {
     batchSize: number,
     address: Address,
     lastTx: TX | undefined
-  ) {
-    const params: {
-      no_token?: string;
-      noToken?: string;
-      batch_size?: number;
-      block_hash?: string;
-      blockHash?: string;
-    } =
+  ): Promise<TX[]> {
+    const params: ExplorerParams =
       this.explorerVersion === "v2"
         ? {
             noToken: "true",

package/src/families/bitcoin/wallet-btc/pickingstrategies/CoinSelect.ts

@@ -15,7 +15,12 @@ export class CoinSelect extends PickingStrategy {
     xpub: Xpub,
     outputs: OutputInfo[],
     feePerByte: number
-  ) {
+  ): Promise<{
+    unspentUtxos: Output[];
+    totalValue: BigNumber;
+    fee: number;
+    needChangeoutput: boolean;
+  }> {
     // get the utxos to use as input
     // from all addresses of the account
     const addresses = await xpub.getXpubAddresses();

package/src/families/bitcoin/wallet-btc/pickingstrategies/DeepFirst.ts

@@ -14,7 +14,12 @@ export class DeepFirst extends PickingStrategy {
     xpub: Xpub,
     outputs: OutputInfo[],
     feePerByte: number
-  ) {
+  ): Promise<{
+    unspentUtxos: Output[];
+    totalValue: BigNumber;
+    fee: number;
+    needChangeoutput: boolean;
+  }> {
     // get the utxos to use as input
     // from all addresses of the account
     const addresses = await xpub.getXpubAddresses();

package/src/families/bitcoin/wallet-btc/pickingstrategies/Merge.ts

@@ -14,7 +14,12 @@ export class Merge extends PickingStrategy {
     xpub: Xpub,
     outputs: OutputInfo[],
     feePerByte: number
-  ) {
+  ): Promise<{
+    unspentUtxos: Output[];
+    totalValue: BigNumber;
+    fee: number;
+    needChangeoutput: boolean;
+  }> {
     // get the utxos to use as input
     // from all addresses of the account
     const addresses = await xpub.getXpubAddresses();