@ledgerhq/live-common 27.2.0 → 27.3.0-nightly.0

package/src/exchange/swap/index.ts

@@ -11,6 +11,7 @@ import {
   JSONRPCResponseError,
   NoIPHeaderError,
   NotImplementedError,
+  SwapGenericAPIError,
   TradeMethodNotSupportedError,
   UnexpectedError,
   ValidationError,
@@ -36,6 +37,19 @@ export const isSwapOperationPending: (status: string) => boolean = (status) =>
 
 const getSwapAPIBaseURL: () => string = () => getEnv("SWAP_API_BASE");
 
+const SWAP_API_BASE_PATTERN = /.*\/v(?<version>\d+)\/*$/;
+const getSwapAPIVersion: () => number = () => {
+  const version = Number(
+    getSwapAPIBaseURL().match(SWAP_API_BASE_PATTERN)?.groups?.version
+  );
+  if (version == null || isNaN(version)) {
+    throw new SwapGenericAPIError(
+      "Configured swap API base URL is invalid, should end with /v<number>"
+    );
+  }
+  return version;
+};
+
 const ftx = {
   nameAndPubkey: Buffer.concat([
     Buffer.from([3]),
@@ -179,6 +193,7 @@ export const getSwapAPIError = (errorCode: number, errorMessage?: string) => {
 
 export {
   getSwapAPIBaseURL,
+  getSwapAPIVersion,
   getProviderConfig,
   getProviders,
   getExchangeRates,

package/src/exchange/swap/mock.ts

@@ -7,7 +7,7 @@ import {
   SwapExchangeRateAmountTooHigh,
   SwapExchangeRateAmountTooLow,
 } from "../../errors";
-import { getSwapAPIBaseURL } from "./";
+import { getSwapAPIVersion } from "./";
 import type {
   CheckQuote,
   Exchange,
@@ -129,7 +129,7 @@ export const mockInitSwap = (
 export const mockGetProviders: GetProviders = async () => {
   //Fake delay to show loading UI
   await new Promise((r) => setTimeout(r, 800));
-  const usesV3 = getSwapAPIBaseURL().endsWith("v3");
+  const usesV3 = getSwapAPIVersion() >= 3;
 
   return usesV3
     ? [

package/src/exchange/swap/types.ts

@@ -83,6 +83,17 @@ export type AvailableProviderV3 = {
   pairs: Array<{ from: string; to: string; tradeMethod: string }>;
 };
 
+type TradeMethodGroup = {
+  methods: TradeMethod[];
+  pairs: {
+    [currencyIndex: number]: number[];
+  };
+};
+export type ProvidersResponseV4 = {
+  currencies: { [currencyIndex: number]: string };
+  providers: { [providerName: string]: TradeMethodGroup[] };
+};
+
 type CheckQuoteOkStatus = {
   codeName: "RATE_VALID";
 };

package/src/exchange/swap/utils/index.test.ts

@@ -10,6 +10,7 @@ import { genAccount } from "../../../mock/account";
 import {
   getAccountTuplesForCurrency,
   getAvailableAccountsById,
+  isRegistrationRequired,
   getProviderName,
   KYCStatus,
   shouldShowKYCBanner,
@@ -303,6 +304,24 @@ describe("swap/utils/shouldShowKYCBanner", () => {
   });
 });
 
+describe("swap/utils/isRegistrationRequired", () => {
+  test("should return registration is required for ftx", () => {
+    const expectedResult = true;
+
+    const result = isRegistrationRequired("ftx");
+
+    expect(result).toBe(expectedResult);
+  });
+
+  test("should return registration is not required for changelly", () => {
+    const expectedResult = false;
+
+    const result = isRegistrationRequired("changelly");
+
+    expect(result).toBe(expectedResult);
+  });
+});
+
 describe("swap/utils/getProviderName", () => {
   test("should return uppercase provider name for ftx", () => {
     const expectedResult = "FTX";

package/src/exchange/swap/utils/index.ts

@@ -172,6 +172,11 @@ export const shouldShowKYCBanner = ({
   return kycStatus !== KYC_STATUS.approved;
 };
 
+export const isRegistrationRequired = (provider: string): boolean => {
+  const { needsBearerToken, needsKYC } = getProviderConfig(provider);
+  return needsBearerToken || needsKYC;
+};
+
 export const getProviderName = (provider: string): string => {
   switch (provider) {
     case "ftx":

package/src/families/algorand/speculos-deviceActions.ts

@@ -1,26 +1,10 @@
 import type { DeviceAction } from "../../bot/types";
 import type { AlgorandTransaction } from "./types";
-import { formatCurrencyUnit, findTokenById } from "../../currencies";
-import { deviceActionFlow } from "../../bot/specs";
+import { findTokenById } from "../../currencies";
+import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
 import { extractTokenId, addPrefixToken } from "./tokens";
 import { displayTokenValue } from "./deviceTransactionConfig";
 
-// Will be useful when unit is gonna be algo
-const expectedAmount = ({ account, status }) =>
-  formatCurrencyUnit(
-    {
-      ...account.unit,
-      code: account.currency.deviceTicker || account.unit.code,
-      prefixCode: true,
-    },
-    status.amount,
-    {
-      showCode: true,
-      disableRounding: true,
-      joinFragmentsSeparator: " ",
-    }
-  );
-
 export const acceptTransaction: DeviceAction<AlgorandTransaction, any> =
   deviceActionFlow({
     steps: [
@@ -42,19 +26,7 @@ export const acceptTransaction: DeviceAction<AlgorandTransaction, any> =
         title: "Fee",
         button: "Rr",
         expectedValue: ({ account, status }) =>
-          formatCurrencyUnit(
-            {
-              ...account.unit,
-              code: account.currency.deviceTicker || account.unit.code,
-              prefixCode: true,
-            },
-            status.estimatedFees,
-            {
-              showCode: true,
-              disableRounding: true,
-              joinFragmentsSeparator: " ",
-            }
-          ),
+          formatDeviceAmount(account.currency, status.estimatedFees),
       },
       {
         title: "Asset ID",
@@ -95,10 +67,7 @@ export const acceptTransaction: DeviceAction<AlgorandTransaction, any> =
         expectedValue: ({ account, status, transaction }) =>
           transaction.mode === "claimReward"
             ? "0"
-            : expectedAmount({
-                account,
-                status,
-              }),
+            : formatDeviceAmount(account.currency, status.amount),
       },
       {
         title: "APPROVE",

package/src/families/bitcoin/specs.ts

@@ -310,7 +310,6 @@ const bitcoin: AppSpec<Transaction> = {
   mutations: bitcoinLikeMutations(),
 };
 const bitcoinTestnet: AppSpec<Transaction> = {
-  multipleRuns: 2,
   name: "Bitcoin Testnet",
   currency: getCryptoCurrencyById("bitcoin_testnet"),
   dependency: "Bitcoin",

package/src/families/bitcoin/speculos-deviceActions.ts

@@ -1,7 +1,6 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { formatCurrencyUnit } from "../../currencies";
-import { deviceActionFlow } from "../../bot/specs";
+import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
 import { perCoinLogic } from "./logic";
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
@@ -11,37 +10,15 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         title: "Amount",
         button: "Rr",
         ignoreAssertionFailure: true,
-        // https://ledgerhq.atlassian.net/browse/LLC-676
         expectedValue: ({ account, status }) =>
-          formatCurrencyUnit(
-            {
-              ...account.unit,
-              code: account.currency.deviceTicker || account.unit.code,
-            },
-            status.amount,
-            {
-              showCode: true,
-              disableRounding: true,
-            }
-          ).replace(/\s/g, " "),
+          formatDeviceAmount(account.currency, status.amount),
       },
       {
         title: "Fees",
         button: "Rr",
         ignoreAssertionFailure: true,
-        // https://ledgerhq.atlassian.net/browse/LLC-676
         expectedValue: ({ account, status }) =>
-          formatCurrencyUnit(
-            {
-              ...account.unit,
-              code: account.currency.deviceTicker || account.unit.code,
-            },
-            status.estimatedFees,
-            {
-              showCode: true,
-              disableRounding: true,
-            }
-          ).replace(/\s/g, " "),
+          formatDeviceAmount(account.currency, status.estimatedFees),
       },
       {
         title: "Address",

package/src/families/cardano/specs.ts

@@ -12,6 +12,7 @@ import { parseCurrencyUnit } from "../../currencies";
 import { SubAccount } from "@ledgerhq/types-live";
 import { acceptTransaction } from "./speculos-deviceActions";
 
+const maxAccounts = 5;
 const currency = getCryptoCurrencyById("cardano");
 const minBalanceRequired = parseCurrencyUnit(currency.units[0], "2.2");
 const minBalanceRequiredForMaxSend = parseCurrencyUnit(currency.units[0], "1");
@@ -35,7 +36,7 @@ const cardano: AppSpec<Transaction> = {
       maxRun: 1,
       transaction: ({ account, siblings, bridge, maxSpendable }) => {
         invariant(maxSpendable.gt(minBalanceRequired), "balance is too low");
-        const sibling = pickSiblings(siblings, 3);
+        const sibling = pickSiblings(siblings, maxAccounts);
         const recipient = sibling.freshAddress;
         const transaction = bridge.createTransaction(account);
 
@@ -77,7 +78,7 @@ const cardano: AppSpec<Transaction> = {
           maxSpendable.gt(minBalanceRequiredForMaxSend),
           "balance is too low"
         );
-        const sibling = pickSiblings(siblings, 3);
+        const sibling = pickSiblings(siblings, maxAccounts);
         const recipient = sibling.freshAddress;
         const transaction = bridge.createTransaction(account);
 
@@ -117,7 +118,7 @@ const cardano: AppSpec<Transaction> = {
           maxSpendable.gte(minSpendableRequiredForTokenTx),
           "balance is too low"
         );
-        const sibling = pickSiblings(siblings, 3);
+        const sibling = pickSiblings(siblings, maxAccounts);
         const recipient = sibling.freshAddress;
         const transaction = bridge.createTransaction(account);
 

package/src/families/cardano/speculos-deviceActions.ts

@@ -1,17 +1,6 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { formatCurrencyUnit } from "../../currencies";
-import { deviceActionFlow } from "../../bot/specs";
-import type { Unit } from "@ledgerhq/types-cryptoassets";
-import BigNumber from "bignumber.js";
-
-function expectedValue(unit: Unit, value: BigNumber) {
-  return formatCurrencyUnit(unit, value, {
-    showCode: true,
-    disableRounding: true,
-    showAllDigits: true,
-  });
-}
+import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -38,7 +27,7 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         button: "LRlr",
         ignoreAssertionFailure: true,
         expectedValue: ({ account, status }) =>
-          expectedValue(account.unit, status.amount),
+          formatDeviceAmount(account.currency, status.amount),
       },
       {
         title: "Asset fingerprint",
@@ -60,7 +49,7 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         button: "LRlr",
         ignoreAssertionFailure: true,
         expectedValue: ({ account, status }) =>
-          expectedValue(account.unit, status.estimatedFees),
+          formatDeviceAmount(account.currency, status.estimatedFees),
       },
       {
         title: "Transaction TTL",

package/src/families/celo/speculos-deviceActions.ts

@@ -1,7 +1,7 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { deviceActionFlow } from "../../bot/specs";
-import { formatCurrencyUnit } from "../../currencies";
+import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
+
 const typeWording = {
   send: "Send",
   lock: "Lock",
@@ -23,18 +23,10 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
       {
         title: "Amount",
         button: "Rr",
-        expectedValue: ({ account, status }) => {
-          const formattedValue =
-            "CELO " +
-            formatCurrencyUnit(account.unit, status.amount, {
-              disableRounding: true,
-            });
-          if (!formattedValue.includes(".")) {
-            // if the value is pure integer, in the app it will automatically add an .0
-            return formattedValue + ".0";
-          }
-          return formattedValue;
-        },
+        expectedValue: ({ account, status }) =>
+          formatDeviceAmount(account.currency, status.amount, {
+            forceFloating: true,
+          }),
       },
       {
         title: "Address",

package/src/families/elrond/speculos-deviceActions.ts

@@ -1,7 +1,6 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { deviceActionFlow } from "../../bot/specs";
-import { formatCurrencyUnit } from "../../currencies";
+import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -15,13 +14,9 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         title: "Amount",
         button: "Rr",
         expectedValue: ({ account, transaction }) =>
-          formatCurrencyUnit(account.unit, transaction.amount, {
-            showCode: true,
-            disableRounding: true,
-            joinFragmentsSeparator: " ",
-          })
-            .replace(/\s+/g, " ")
-            .replace("egld", "EGLD"), // FIXME
+          formatDeviceAmount(account.currency, transaction.amount, {
+            postfixCode: true,
+          }),
       },
       {
         title: "Fee",

package/src/families/ethereum/speculos-deviceActions.ts

@@ -1,7 +1,6 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { formatCurrencyUnit, findCompoundToken } from "../../currencies";
-import { deviceActionFlow } from "../../bot/specs";
+import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
 
 function subAccount(subAccountId, account) {
   const sub = (account.subAccounts || []).find((a) => a.id === subAccountId);
@@ -10,28 +9,8 @@ function subAccount(subAccountId, account) {
   return sub;
 }
 
-function expectedCompoundToken(t) {
-  if (!t) {
-    throw new Error("compound token was expected");
-  }
-
-  return t;
-}
-
 const maxFeesExpectedValue = ({ account, status }) =>
-  formatCurrencyUnit(
-    {
-      ...account.unit,
-      code: account.currency.deviceTicker || account.unit.code,
-      prefixCode: true,
-    },
-    status.estimatedFees,
-    {
-      showCode: true,
-      disableRounding: true,
-      joinFragmentsSeparator: " ",
-    }
-  ).replace(/\s/g, " ");
+  formatDeviceAmount(account.currency, status.estimatedFees);
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -66,16 +45,6 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
             return "Unlimited " + a.token.ticker;
           }
 
-          const unit = !a
-            ? {
-                ...account.unit,
-                code: account.currency.deviceTicker || account.unit.code,
-              }
-            : (transaction.mode === "compound.withdraw" &&
-              transaction.useAllAmount
-                ? expectedCompoundToken(findCompoundToken(a.token))
-                : a.token
-              ).units[0];
           const amount =
             a &&
             a.compoundBalance &&
@@ -83,19 +52,20 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
             transaction.useAllAmount
               ? a.compoundBalance
               : status.amount;
-          return formatCurrencyUnit(
-            {
-              ...unit,
-              code: account.currency.deviceTicker || account.unit.code,
-              prefixCode: true,
-            },
-            amount,
-            {
-              showCode: true,
-              disableRounding: true,
-              joinFragmentsSeparator: " ",
-            }
-          ).replace(/\s/g, " ");
+
+          if (
+            a &&
+            transaction.mode === "compound.withdraw" &&
+            transaction.useAllAmount
+          ) {
+            return formatDeviceAmount(a.compoundBalance, amount);
+          }
+
+          if (a) {
+            return formatDeviceAmount(a.token, amount);
+          }
+
+          return formatDeviceAmount(account.currency, amount);
         },
       },
       {

package/src/families/evm/specs.ts

@@ -3,7 +3,7 @@ import invariant from "invariant";
 import { DeviceModelId } from "@ledgerhq/devices";
 import { getCryptoCurrencyById, parseCurrencyUnit } from "../../currencies";
 import { acceptTransaction } from "./speculos-deviceActions";
-import { pickSiblings } from "../../bot/specs";
+import { botTest, pickSiblings } from "../../bot/specs";
 import type { AppSpec } from "../../bot/types";
 import type { Transaction } from "./types";
 
@@ -14,7 +14,7 @@ const transactionCheck =
   ({ maxSpendable }) => {
     invariant(
       maxSpendable.gt(
-        parseCurrencyUnit(getCryptoCurrencyById(currencyId).units[0], "0.01")
+        parseCurrencyUnit(getCryptoCurrencyById(currencyId).units[0], "1")
       ),
       `${currencyId} balance is too low`
     );
@@ -45,13 +45,17 @@ const evmBasicMutations = ({ maxAccount }) => [
         "operation time to be older than 60s"
       );
       const estimatedGas = transaction.gasLimit.times(
-        transaction.gasPrice || 0
+        transaction.gasPrice || transaction.maxFeePerGas || 0
       );
-      expect(operation.fee.toNumber()).toBeLessThanOrEqual(
-        estimatedGas.toNumber()
+      botTest("operation fee is not exceeding estimated gas", () =>
+        expect(operation.fee.toNumber()).toBeLessThanOrEqual(
+          estimatedGas.toNumber()
+        )
       );
-      expect(account.balance.toString()).toBe(
-        accountBeforeTransaction.balance.minus(operation.value).toString()
+      botTest("account balance moved with operation value", () =>
+        expect(account.balance.toString()).toBe(
+          accountBeforeTransaction.balance.minus(operation.value).toString()
+        )
       );
     },
   },
@@ -118,7 +122,7 @@ const songbird: AppSpec<Transaction> = {
 };
 
 const flare: AppSpec<Transaction> = {
-  name: "Moonbeam",
+  name: "Flare",
   currency: getCryptoCurrencyById("flare"),
   appQuery: {
     model: DeviceModelId.nanoS,

package/src/families/evm/speculos-deviceActions.ts

@@ -1,7 +1,6 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { formatCurrencyUnit } from "../../currencies";
-import { deviceActionFlow } from "../../bot/specs";
+import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
 
 function subAccount(subAccountId, account) {
   const sub = (account.subAccounts || []).find((a) => a.id === subAccountId);
@@ -11,19 +10,7 @@ function subAccount(subAccountId, account) {
 }
 
 const maxFeesExpectedValue = ({ account, status }) =>
-  formatCurrencyUnit(
-    {
-      ...account.unit,
-      code: account.currency.deviceTicker || account.unit.code,
-      prefixCode: true,
-    },
-    status.estimatedFees,
-    {
-      showCode: true,
-      disableRounding: true,
-      joinFragmentsSeparator: " ",
-    }
-  ).replace(/\s/g, " ");
+  formatDeviceAmount(account.currency, status.estimatedFees);
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -44,26 +31,11 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
             ? subAccount(transaction.subAccountId, account)
             : null;
 
-          const unit = !a
-            ? {
-                ...account.unit,
-                code: account.currency.deviceTicker || account.unit.code,
-              }
-            : a.token.units[0];
-          const amount = status.amount;
-          return formatCurrencyUnit(
-            {
-              ...unit,
-              code: account.currency.deviceTicker || account.unit.code,
-              prefixCode: true,
-            },
-            amount,
-            {
-              showCode: true,
-              disableRounding: true,
-              joinFragmentsSeparator: " ",
-            }
-          ).replace(/\s/g, " ");
+          if (a) {
+            return formatDeviceAmount(a.token, status.amount);
+          }
+
+          return formatDeviceAmount(account.currency, status.amount);
         },
       },
       {

package/src/families/filecoin/speculos-deviceActions.ts

@@ -1,7 +1,6 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { deviceActionFlow } from "../../bot/specs";
-import { formatCurrencyUnit } from "../../currencies";
+import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -25,8 +24,8 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         title: "Value",
         button: "Rr",
         expectedValue: ({ account, status }) =>
-          formatCurrencyUnit(account.unit, status.amount, {
-            disableRounding: true,
+          formatDeviceAmount(account.currency, status.amount, {
+            hideCode: true,
             showAllDigits: true,
           }),
       },
@@ -39,8 +38,8 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         title: "Gas Premium",
         button: "Rr",
         expectedValue: ({ account, transaction }) =>
-          formatCurrencyUnit(account.unit, transaction.gasPremium, {
-            disableRounding: true,
+          formatDeviceAmount(account.currency, transaction.gasPremium, {
+            hideCode: true,
             showAllDigits: true,
           }),
       },
@@ -48,8 +47,8 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         title: "Gas Fee Cap",
         button: "Rr",
         expectedValue: ({ account, transaction }) =>
-          formatCurrencyUnit(account.unit, transaction.gasFeeCap, {
-            disableRounding: true,
+          formatDeviceAmount(account.currency, transaction.gasFeeCap, {
+            hideCode: true,
             showAllDigits: true,
           }),
       },

package/src/families/polkadot/speculos-deviceActions.ts

@@ -1,7 +1,6 @@
 import type { DeviceAction } from "../../bot/types";
 import type { PolkadotAccount, Transaction } from "./types";
-import { deviceActionFlow } from "../../bot/specs";
-import { formatCurrencyUnit } from "../../currencies";
+import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -22,20 +21,10 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
       {
         title: "Amount",
         button: "Rr",
-        expectedValue: ({ account, transaction }) => {
-          const formattedValue =
-            "DOT " +
-            formatCurrencyUnit(account.unit, transaction.amount, {
-              disableRounding: true,
-            });
-
-          if (!formattedValue.includes(".")) {
-            // if the value is pure integer, in the app it will automatically add an .0
-            return formattedValue + ".0";
-          }
-
-          return formattedValue;
-        },
+        expectedValue: ({ account, transaction }) =>
+          formatDeviceAmount(account.currency, transaction.amount, {
+            forceFloating: true,
+          }),
       },
       {
         title: "Chain",