@ledgerhq/live-common 27.2.0 → 27.3.0-next.0

package/src/families/celo/specs/createSendMutation.ts

@@ -1,16 +1,17 @@
 import invariant from "invariant";
 import { getCryptoCurrencyById, parseCurrencyUnit } from "../../../currencies";
-import { pickSiblings } from "../../../bot/specs";
+import { genericTestDestination, pickSiblings } from "../../../bot/specs";
 import { MutationSpec } from "../../../bot/types";
 import type { Transaction } from "../types";
 
-const maxAccount = 3;
+const maxAccount = 10;
 const currency = getCryptoCurrencyById("celo");
-const minimalAmount = parseCurrencyUnit(currency.units[0], "0.001");
+export const minimalAmount = parseCurrencyUnit(currency.units[0], "0.001");
 
 export const createSend50PercentMutation = (): MutationSpec<Transaction> => ({
   name: "Celo: Move 50% to another account",
   maxRun: 1,
+  testDestination: genericTestDestination,
   transaction: ({ account, siblings, bridge, maxSpendable }) => {
     invariant(
       maxSpendable.gt(minimalAmount),
@@ -29,6 +30,7 @@ export const createSend50PercentMutation = (): MutationSpec<Transaction> => ({
 export const createSendMaxMutation = (): MutationSpec<Transaction> => ({
   name: "Celo: Send max to another account",
   maxRun: 1,
+  testDestination: genericTestDestination,
   transaction: ({ account, siblings, bridge, maxSpendable }) => {
     invariant(
       maxSpendable.gt(minimalAmount),

package/src/families/celo/specs.ts

@@ -1,6 +1,7 @@
 import { DeviceModelId } from "@ledgerhq/devices";
 import { getCryptoCurrencyById } from "../../currencies";
 import {
+  minimalAmount,
   createLockMutation,
   createRegisterAccountMutation,
   createSend50PercentMutation,
@@ -35,6 +36,7 @@ const celo: AppSpec<Transaction> = {
   },
   testTimeout: 2 * 60 * 1000,
   genericDeviceAction: acceptTransaction,
+  minViableAmount: minimalAmount,
   mutations: [
     send50PercentMutation,
     sendMaxMutation,

package/src/families/celo/speculos-deviceActions.ts

@@ -1,7 +1,7 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { deviceActionFlow } from "../../bot/specs";
-import { formatCurrencyUnit } from "../../currencies";
+import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
+
 const typeWording = {
   send: "Send",
   lock: "Lock",
@@ -23,18 +23,10 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
       {
         title: "Amount",
         button: "Rr",
-        expectedValue: ({ account, status }) => {
-          const formattedValue =
-            "CELO " +
-            formatCurrencyUnit(account.unit, status.amount, {
-              disableRounding: true,
-            });
-          if (!formattedValue.includes(".")) {
-            // if the value is pure integer, in the app it will automatically add an .0
-            return formattedValue + ".0";
-          }
-          return formattedValue;
-        },
+        expectedValue: ({ account, status }) =>
+          formatDeviceAmount(account.currency, status.amount, {
+            forceFloating: true,
+          }),
       },
       {
         title: "Address",

package/src/families/cosmos/__snapshots__/bridge.integration.test.ts.snap

@@ -217,23 +217,19 @@ Array [
             "address": "cosmosvaloper1vf44d85es37hwl9f4h9gv0e064m0lla60j9luj",
             "amount": "180",
           },
-          Object {
-            "address": "cosmosvaloper1vf44d85es37hwl9f4h9gv0e064m0lla60j9luj",
-            "amount": "180",
-          },
         ],
       },
       "fee": "10619",
       "hash": "1F069773A16D0B028E3F90E23290B52DA7708082D258A22B8B786C615C272D5C",
-      "id": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:-1F069773A16D0B028E3F90E23290B52DA7708082D258A22B8B786C615C272D5C-DELEGATE",
+      "id": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:-1F069773A16D0B028E3F90E23290B52DA7708082D258A22B8B786C615C272D5C-REWARD",
       "operator": undefined,
       "recipients": Array [],
       "senders": Array [],
       "standard": undefined,
       "tokenId": undefined,
       "transactionSequenceNumber": 89,
-      "type": "DELEGATE",
-      "value": "10619",
+      "type": "REWARD",
+      "value": "180",
     },
     Object {
       "accountId": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:",
@@ -258,7 +254,7 @@ Array [
       "tokenId": undefined,
       "transactionSequenceNumber": 86,
       "type": "REWARD",
-      "value": "5847",
+      "value": "12037",
     },
     Object {
       "accountId": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:",
@@ -403,7 +399,7 @@ Array [
       "tokenId": undefined,
       "transactionSequenceNumber": 75,
       "type": "REWARD",
-      "value": "7392",
+      "value": "239",
     },
     Object {
       "accountId": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:",
@@ -465,23 +461,19 @@ Array [
             "address": "cosmosvaloper1hjct6q7npsspsg3dgvzk3sdf89spmlpfdn6m9d",
             "amount": "6166",
           },
-          Object {
-            "address": "cosmosvaloper1hjct6q7npsspsg3dgvzk3sdf89spmlpfdn6m9d",
-            "amount": "6166",
-          },
         ],
       },
       "fee": "10650",
       "hash": "72E55F86B856BA8558F63075D653D02795A1FF4F33053398F221FF3FBBB02601",
-      "id": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:-72E55F86B856BA8558F63075D653D02795A1FF4F33053398F221FF3FBBB02601-DELEGATE",
+      "id": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:-72E55F86B856BA8558F63075D653D02795A1FF4F33053398F221FF3FBBB02601-REWARD",
       "operator": undefined,
       "recipients": Array [],
       "senders": Array [],
       "standard": undefined,
       "tokenId": undefined,
       "transactionSequenceNumber": 87,
-      "type": "DELEGATE",
-      "value": "10650",
+      "type": "REWARD",
+      "value": "6166",
     },
     Object {
       "accountId": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:",
@@ -542,23 +534,19 @@ Array [
             "address": "cosmosvaloper1grgelyng2v6v3t8z87wu3sxgt9m5s03xfytvz7",
             "amount": "65",
           },
-          Object {
-            "address": "cosmosvaloper1grgelyng2v6v3t8z87wu3sxgt9m5s03xfytvz7",
-            "amount": "65",
-          },
         ],
       },
       "fee": "10414",
       "hash": "8440FE9905C9BCBD71A6A366AC150ECBD0EFFD040F5D39B255EE4708364497A2",
-      "id": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:-8440FE9905C9BCBD71A6A366AC150ECBD0EFFD040F5D39B255EE4708364497A2-DELEGATE",
+      "id": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:-8440FE9905C9BCBD71A6A366AC150ECBD0EFFD040F5D39B255EE4708364497A2-REWARD",
       "operator": undefined,
       "recipients": Array [],
       "senders": Array [],
       "standard": undefined,
       "tokenId": undefined,
       "transactionSequenceNumber": 88,
-      "type": "DELEGATE",
-      "value": "10414",
+      "type": "REWARD",
+      "value": "65",
     },
     Object {
       "accountId": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:",
@@ -607,7 +595,7 @@ Array [
       "tokenId": undefined,
       "transactionSequenceNumber": 0,
       "type": "REWARD",
-      "value": "9838",
+      "value": "15935",
     },
     Object {
       "accountId": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:",
@@ -704,7 +692,7 @@ Array [
       "tokenId": undefined,
       "transactionSequenceNumber": 85,
       "type": "REWARD",
-      "value": "5854",
+      "value": "136432",
     },
     Object {
       "accountId": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:",
@@ -753,7 +741,7 @@ Array [
       "tokenId": undefined,
       "transactionSequenceNumber": 84,
       "type": "REWARD",
-      "value": "6208",
+      "value": "47300",
     },
     Object {
       "accountId": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:",
@@ -790,23 +778,19 @@ Array [
             "address": "cosmosvaloper1crqm3598z6qmyn2kkcl9dz7uqs4qdqnr6s8jdn",
             "amount": "34610",
           },
-          Object {
-            "address": "cosmosvaloper1crqm3598z6qmyn2kkcl9dz7uqs4qdqnr6s8jdn",
-            "amount": "34610",
-          },
         ],
       },
       "fee": "10913",
       "hash": "B8D042E6B4AFB580E2D6DD20F2EDCD4E97791EF46DDD0AE112D7B771F6A9B0A4",
-      "id": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:-B8D042E6B4AFB580E2D6DD20F2EDCD4E97791EF46DDD0AE112D7B771F6A9B0A4-DELEGATE",
+      "id": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:-B8D042E6B4AFB580E2D6DD20F2EDCD4E97791EF46DDD0AE112D7B771F6A9B0A4-REWARD",
       "operator": undefined,
       "recipients": Array [],
       "senders": Array [],
       "standard": undefined,
       "tokenId": undefined,
       "transactionSequenceNumber": 82,
-      "type": "DELEGATE",
-      "value": "10913",
+      "type": "REWARD",
+      "value": "34610",
     },
     Object {
       "accountId": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:",
@@ -928,7 +912,7 @@ Array [
       "tokenId": undefined,
       "transactionSequenceNumber": 81,
       "type": "REWARD",
-      "value": "6197",
+      "value": "2347",
     },
     Object {
       "accountId": "js:2:cosmos:cosmos1g84934jpu3v5de5yqukkkhxmcvsw3u2ajxvpdl:",
@@ -977,7 +961,7 @@ Array [
       "tokenId": undefined,
       "transactionSequenceNumber": 83,
       "type": "REWARD",
-      "value": "5972",
+      "value": "281690",
     },
   ],
   Array [
@@ -1078,7 +1062,7 @@ Array [
       "tokenId": undefined,
       "transactionSequenceNumber": 3,
       "type": "REDELEGATE",
-      "value": "11237",
+      "value": "11233",
     },
     Object {
       "accountId": "js:2:cosmos:cosmos108uy5q9jt59gwugq5yrdhkzcd9jryslmpcstk5:",
@@ -1491,7 +1475,7 @@ Array [
       "tokenId": undefined,
       "transactionSequenceNumber": 5,
       "type": "DELEGATE",
-      "value": "11042",
+      "value": "10906",
     },
   ],
   Array [
@@ -1724,23 +1708,19 @@ Array [
             "address": "cosmosvaloper17zcpywlhgcpk7ff505vr8mnc4wwpv5fcta6enz",
             "amount": "0",
           },
-          Object {
-            "address": "cosmosvaloper17zcpywlhgcpk7ff505vr8mnc4wwpv5fcta6enz",
-            "amount": "1",
-          },
         ],
       },
       "fee": "8399",
       "hash": "DF458FE6A82C310837D7A33735FA5298BCF71B0BFF7A4134641AAE30F6F10501",
-      "id": "js:2:cosmos:cosmos1cgc696ay2pg6d4gcejek2y8la66j7e5y3c7kyw:-DF458FE6A82C310837D7A33735FA5298BCF71B0BFF7A4134641AAE30F6F10501-DELEGATE",
+      "id": "js:2:cosmos:cosmos1cgc696ay2pg6d4gcejek2y8la66j7e5y3c7kyw:-DF458FE6A82C310837D7A33735FA5298BCF71B0BFF7A4134641AAE30F6F10501-REWARD",
       "operator": undefined,
       "recipients": Array [],
       "senders": Array [],
       "standard": undefined,
       "tokenId": undefined,
       "transactionSequenceNumber": 25,
-      "type": "DELEGATE",
-      "value": "8399",
+      "type": "REWARD",
+      "value": "0",
     },
     Object {
       "accountId": "js:2:cosmos:cosmos1cgc696ay2pg6d4gcejek2y8la66j7e5y3c7kyw:",

package/src/families/cosmos/helpers.ts

@@ -0,0 +1,21 @@
+type Message = {
+  type: string;
+  attributes: { [key: string]: any };
+};
+
+export const getMainMessage = (messages: Message[]): Message => {
+  const messagePriorities: string[] = [
+    "withdraw_rewards",
+    "unbond",
+    "redelegate",
+    "delegate",
+    "transfer",
+  ];
+  const sortedTypes = messages
+    .filter((m) => messagePriorities.includes(m.type))
+    .sort(
+      (a, b) =>
+        messagePriorities.indexOf(a.type) - messagePriorities.indexOf(b.type)
+    );
+  return sortedTypes[0];
+};

package/src/families/cosmos/helpers.unit.test.ts

@@ -0,0 +1,63 @@
+import { getMainMessage } from "./helpers";
+
+describe("getMainMessage", () => {
+  it("should return reward message with delegate and reward messages (claim rewards, compound)", () => {
+    const exec = getMainMessage([
+      {
+        type: "delegate",
+        attributes: {},
+      },
+      {
+        type: "withdraw_rewards",
+        attributes: {},
+      },
+    ]);
+    expect(exec.type).toEqual("withdraw_rewards");
+  });
+
+  it("should return unbond message with unbound and transfer messages", () => {
+    expect(
+      getMainMessage([
+        {
+          type: "unbond",
+          attributes: {},
+        },
+        {
+          type: "transfer",
+          attributes: {},
+        },
+      ]).type
+    ).toEqual("unbond");
+  });
+
+  it("should return first transfer message with multiple transfer messages", () => {
+    const firstTransfer = {
+      type: "transfer",
+      attributes: {},
+    };
+    expect(
+      getMainMessage([
+        firstTransfer,
+        {
+          type: "transfer",
+          attributes: {},
+        },
+      ])
+    ).toEqual(firstTransfer);
+  });
+
+  it("should return redelegate message with delegate/redelegate messages", () => {
+    expect(
+      getMainMessage([
+        {
+          type: "delegate",
+          attributes: {},
+        },
+        {
+          type: "redelegate",
+          attributes: {},
+        },
+      ]).type
+    ).toEqual("redelegate");
+  });
+});

package/src/families/cosmos/js-signOperation.ts

@@ -153,9 +153,12 @@ const signOperation = ({
           id: encodeOperationId(accountId, hash, type),
           hash,
           type,
-          value: transaction.useAllAmount
-            ? account.spendableBalance
-            : transaction.amount.plus(fee),
+          value:
+            type === "REWARD"
+              ? new BigNumber(0)
+              : transaction.useAllAmount
+              ? account.spendableBalance
+              : transaction.amount.plus(fee),
           fee,
           extra,
           blockHash: null,

package/src/families/cosmos/js-synchronisation.ts

@@ -11,6 +11,25 @@ import { pubkeyToAddress, decodeBech32Pubkey } from "@cosmjs/amino";
 import { encodeOperationId } from "../../operation";
 import { CosmosDelegationInfo } from "./types";
 import type { Operation, OperationType } from "@ledgerhq/types-live";
+import { getMainMessage } from "./helpers";
+
+const getBlankOperation = (tx, fees, id) => ({
+  id: "",
+  hash: tx.txhash,
+  type: "" as OperationType,
+  value: new BigNumber(0),
+  fee: fees,
+  blockHash: null,
+  blockHeight: tx.height,
+  senders: [] as string[],
+  recipients: [] as string[],
+  accountId: id,
+  date: new Date(tx.timestamp),
+  extra: {
+    validators: [] as CosmosDelegationInfo[],
+  },
+  transactionSequenceNumber: parseInt(tx.tx.auth_info.signer_infos[0].sequence),
+});
 
 const txToOps = (info: any, id: string, txs: any): Operation[] => {
   const { address, currency } = info;
@@ -23,126 +42,108 @@ const txToOps = (info: any, id: string, txs: any): Operation[] => {
       if (elem.denom === currency.units[1].code) fees = fees.plus(elem.amount);
     });
 
-    const op: Operation = {
-      id: "",
-      hash: tx.txhash,
-      type: "" as OperationType,
-      value: new BigNumber(0),
-      fee: fees,
-      blockHash: null,
-      blockHeight: tx.height,
-      senders: [] as string[],
-      recipients: [] as string[],
-      accountId: id,
-      date: new Date(tx.timestamp),
-      extra: {
-        validators: [] as CosmosDelegationInfo[],
-      },
-      transactionSequenceNumber: parseInt(
-        tx.tx.auth_info.signer_infos[0].sequence
-      ),
-    };
-
-    tx.logs.forEach((log) => {
-      log.events.forEach((message) => {
-        // parse attributes as key:value
-        const attributes: { [id: string]: any } = {};
-        message.attributes.forEach(
-          (item) => (attributes[item.key] = item.value)
-        );
-
-        // https://docs.cosmos.network/v0.42/modules/staking/07_events.html
-        switch (message.type) {
-          case "transfer":
-            if (
-              attributes.sender &&
-              attributes.recipient &&
-              attributes.amount
-            ) {
-              op.senders.push(attributes.sender);
-              op.recipients.push(attributes.recipient);
-
-              if (attributes.amount.indexOf(currency.units[1].code) != -1) {
-                op.value = op.value.plus(
-                  attributes.amount.replace(currency.units[1].code, "")
-                );
-              }
-
-              if (!op.type && attributes.sender === address) {
-                op.type = "OUT";
-                op.value = op.value.plus(fees);
-              } else if (!op.type && attributes.recipient === address) {
-                op.type = "IN";
-              }
-            }
-            break;
-
-          case "withdraw_rewards":
-            if (
-              (attributes.amount &&
-                attributes.amount.indexOf(currency.units[1].code) != -1) ||
-              // handle specifc case with empty amount value like
-              // tx DF458FE6A82C310837D7A33735FA5298BCF71B0BFF7A4134641AAE30F6F1050
-              attributes.amount === ""
-            ) {
-              op.type = "REWARD";
-              op.value = new BigNumber(fees);
-              op.extra.validators.push({
-                address: attributes.validator,
-                amount:
-                  attributes.amount.replace(currency.units[1].code, "") || 0,
-              });
-            }
-            break;
-
-          case "delegate":
-            if (
-              attributes.amount &&
-              attributes.amount.indexOf(currency.units[1].code) != -1
-            ) {
-              op.type = "DELEGATE";
-              op.value = new BigNumber(fees);
-              op.extra.validators.push({
-                address: attributes.validator,
-                amount: attributes.amount.replace(currency.units[1].code, ""),
-              });
-            }
-            break;
-
-          case "redelegate":
-            if (
-              attributes.amount &&
-              attributes.amount.indexOf(currency.units[1].code) != -1 &&
-              attributes.destination_validator &&
-              attributes.source_validator
-            ) {
-              op.type = "REDELEGATE";
-              op.value = new BigNumber(fees);
-              op.extra.validators.push({
-                address: attributes.destination_validator,
-                amount: attributes.amount.replace(currency.units[1].code, ""),
-              });
-              op.extra.sourceValidator = attributes.source_validator;
-            }
-            break;
-
-          case "unbond":
-            if (
-              attributes.amount &&
-              attributes.amount.indexOf(currency.units[1].code) != -1 &&
-              attributes.validator
-            ) {
-              op.type = "UNDELEGATE";
-              op.value = new BigNumber(fees);
-              op.extra.validators.push({
-                address: attributes.validator,
-                amount: attributes.amount.replace(currency.units[1].code, ""),
-              });
-            }
-            break;
+    const op: Operation = getBlankOperation(tx, fees, id);
+
+    const messages = tx.logs.map((log) => log.events).flat(1);
+
+    const message = getMainMessage(messages);
+
+    if (message == null) {
+      continue;
+    }
+
+    // parse attributes as key:value
+    const attributes: { [id: string]: any } = {};
+    message.attributes.forEach((item) => (attributes[item.key] = item.value));
+
+    // https://docs.cosmos.network/v0.42/modules/staking/07_events.html
+    switch (message.type) {
+      case "transfer":
+        if (attributes.sender && attributes.recipient && attributes.amount) {
+          op.senders.push(attributes.sender);
+          op.recipients.push(attributes.recipient);
+
+          if (attributes.amount.indexOf(currency.units[1].code) != -1) {
+            op.value = op.value.plus(
+              attributes.amount.replace(currency.units[1].code, "")
+            );
+          }
+
+          if (!op.type && attributes.sender === address) {
+            op.type = "OUT";
+            op.value = op.value.plus(fees);
+          } else if (!op.type && attributes.recipient === address) {
+            op.type = "IN";
+          }
         }
-      });
-    });
+        break;
+
+      case "withdraw_rewards":
+        if (
+          (attributes.amount &&
+            attributes.amount.indexOf(currency.units[1].code) != -1) ||
+          // handle specifc case with empty amount value like
+          // tx DF458FE6A82C310837D7A33735FA5298BCF71B0BFF7A4134641AAE30F6F1050
+          attributes.amount === ""
+        ) {
+          op.type = "REWARD";
+          const reward = message.attributes
+            .find((attr) => attr.key === "amount")
+            .value.replace("uatom", "");
+          op.value = new BigNumber(reward || 0);
+          op.extra.validators.push({
+            address: attributes.validator,
+            amount: attributes.amount.replace(currency.units[1].code, "") || 0,
+          });
+        }
+        break;
+
+      case "delegate":
+        if (
+          attributes.amount &&
+          attributes.amount.indexOf(currency.units[1].code) != -1
+        ) {
+          op.type = "DELEGATE";
+          op.value = new BigNumber(fees);
+          op.extra.validators.push({
+            address: attributes.validator,
+            amount: attributes.amount.replace(currency.units[1].code, ""),
+          });
+        }
+        break;
+
+      case "redelegate":
+        if (
+          attributes.amount &&
+          attributes.amount.indexOf(currency.units[1].code) != -1 &&
+          attributes.destination_validator &&
+          attributes.source_validator
+        ) {
+          op.type = "REDELEGATE";
+          op.value = new BigNumber(fees);
+          op.extra.validators.push({
+            address: attributes.destination_validator,
+            amount: attributes.amount.replace(currency.units[1].code, ""),
+          });
+          op.extra.sourceValidator = attributes.source_validator;
+        }
+        break;
+
+      case "unbond":
+        if (
+          attributes.amount &&
+          attributes.amount.indexOf(currency.units[1].code) != -1 &&
+          attributes.validator
+        ) {
+          op.type = "UNDELEGATE";
+          op.value = new BigNumber(fees);
+          op.extra.validators.push({
+            address: attributes.validator,
+            amount: attributes.amount.replace(currency.units[1].code, ""),
+          });
+        }
+        break;
+    }
 
     if (!["IN", "OUT"].includes(op.type)) {
       op.senders = [];