@ledgerhq/live-common 27.2.0-nightly.4 → 27.2.0

package/src/families/cardano/speculos-deviceActions.ts

@@ -1,6 +1,17 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
+import { formatCurrencyUnit } from "../../currencies";
+import { deviceActionFlow } from "../../bot/specs";
+import type { Unit } from "@ledgerhq/types-cryptoassets";
+import BigNumber from "bignumber.js";
+
+function expectedValue(unit: Unit, value: BigNumber) {
+  return formatCurrencyUnit(unit, value, {
+    showCode: true,
+    disableRounding: true,
+    showAllDigits: true,
+  });
+}
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -27,7 +38,7 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         button: "LRlr",
         ignoreAssertionFailure: true,
         expectedValue: ({ account, status }) =>
-          formatDeviceAmount(account.currency, status.amount),
+          expectedValue(account.unit, status.amount),
       },
       {
         title: "Asset fingerprint",
@@ -49,7 +60,7 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         button: "LRlr",
         ignoreAssertionFailure: true,
         expectedValue: ({ account, status }) =>
-          formatDeviceAmount(account.currency, status.estimatedFees),
+          expectedValue(account.unit, status.estimatedFees),
       },
       {
         title: "Transaction TTL",

package/src/families/celo/speculos-deviceActions.ts

@@ -1,7 +1,7 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
-
+import { deviceActionFlow } from "../../bot/specs";
+import { formatCurrencyUnit } from "../../currencies";
 const typeWording = {
   send: "Send",
   lock: "Lock",
@@ -23,10 +23,18 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
       {
         title: "Amount",
         button: "Rr",
-        expectedValue: ({ account, status }) =>
-          formatDeviceAmount(account.currency, status.amount, {
-            forceFloating: true,
-          }),
+        expectedValue: ({ account, status }) => {
+          const formattedValue =
+            "CELO " +
+            formatCurrencyUnit(account.unit, status.amount, {
+              disableRounding: true,
+            });
+          if (!formattedValue.includes(".")) {
+            // if the value is pure integer, in the app it will automatically add an .0
+            return formattedValue + ".0";
+          }
+          return formattedValue;
+        },
       },
       {
         title: "Address",

package/src/families/elrond/speculos-deviceActions.ts

@@ -1,6 +1,7 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
+import { deviceActionFlow } from "../../bot/specs";
+import { formatCurrencyUnit } from "../../currencies";
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -14,9 +15,13 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         title: "Amount",
         button: "Rr",
         expectedValue: ({ account, transaction }) =>
-          formatDeviceAmount(account.currency, transaction.amount, {
-            postfixCode: true,
-          }),
+          formatCurrencyUnit(account.unit, transaction.amount, {
+            showCode: true,
+            disableRounding: true,
+            joinFragmentsSeparator: " ",
+          })
+            .replace(/\s+/g, " ")
+            .replace("egld", "EGLD"), // FIXME
       },
       {
         title: "Fee",

package/src/families/ethereum/speculos-deviceActions.ts

@@ -1,6 +1,7 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
+import { formatCurrencyUnit, findCompoundToken } from "../../currencies";
+import { deviceActionFlow } from "../../bot/specs";
 
 function subAccount(subAccountId, account) {
   const sub = (account.subAccounts || []).find((a) => a.id === subAccountId);
@@ -9,8 +10,28 @@ function subAccount(subAccountId, account) {
   return sub;
 }
 
+function expectedCompoundToken(t) {
+  if (!t) {
+    throw new Error("compound token was expected");
+  }
+
+  return t;
+}
+
 const maxFeesExpectedValue = ({ account, status }) =>
-  formatDeviceAmount(account.currency, status.estimatedFees);
+  formatCurrencyUnit(
+    {
+      ...account.unit,
+      code: account.currency.deviceTicker || account.unit.code,
+      prefixCode: true,
+    },
+    status.estimatedFees,
+    {
+      showCode: true,
+      disableRounding: true,
+      joinFragmentsSeparator: " ",
+    }
+  ).replace(/\s/g, " ");
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -45,6 +66,16 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
             return "Unlimited " + a.token.ticker;
           }
 
+          const unit = !a
+            ? {
+                ...account.unit,
+                code: account.currency.deviceTicker || account.unit.code,
+              }
+            : (transaction.mode === "compound.withdraw" &&
+              transaction.useAllAmount
+                ? expectedCompoundToken(findCompoundToken(a.token))
+                : a.token
+              ).units[0];
           const amount =
             a &&
             a.compoundBalance &&
@@ -52,20 +83,19 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
             transaction.useAllAmount
               ? a.compoundBalance
               : status.amount;
-
-          if (
-            a &&
-            transaction.mode === "compound.withdraw" &&
-            transaction.useAllAmount
-          ) {
-            return formatDeviceAmount(a.compoundBalance, amount);
-          }
-
-          if (a) {
-            return formatDeviceAmount(a.token, amount);
-          }
-
-          return formatDeviceAmount(account.currency, amount);
+          return formatCurrencyUnit(
+            {
+              ...unit,
+              code: account.currency.deviceTicker || account.unit.code,
+              prefixCode: true,
+            },
+            amount,
+            {
+              showCode: true,
+              disableRounding: true,
+              joinFragmentsSeparator: " ",
+            }
+          ).replace(/\s/g, " ");
         },
       },
       {

package/src/families/evm/specs.ts

@@ -3,7 +3,7 @@ import invariant from "invariant";
 import { DeviceModelId } from "@ledgerhq/devices";
 import { getCryptoCurrencyById, parseCurrencyUnit } from "../../currencies";
 import { acceptTransaction } from "./speculos-deviceActions";
-import { botTest, pickSiblings } from "../../bot/specs";
+import { pickSiblings } from "../../bot/specs";
 import type { AppSpec } from "../../bot/types";
 import type { Transaction } from "./types";
 
@@ -14,7 +14,7 @@ const transactionCheck =
   ({ maxSpendable }) => {
     invariant(
       maxSpendable.gt(
-        parseCurrencyUnit(getCryptoCurrencyById(currencyId).units[0], "1")
+        parseCurrencyUnit(getCryptoCurrencyById(currencyId).units[0], "0.01")
       ),
       `${currencyId} balance is too low`
     );
@@ -45,17 +45,13 @@ const evmBasicMutations = ({ maxAccount }) => [
         "operation time to be older than 60s"
       );
       const estimatedGas = transaction.gasLimit.times(
-        transaction.gasPrice || transaction.maxFeePerGas || 0
+        transaction.gasPrice || 0
       );
-      botTest("operation fee is not exceeding estimated gas", () =>
-        expect(operation.fee.toNumber()).toBeLessThanOrEqual(
-          estimatedGas.toNumber()
-        )
+      expect(operation.fee.toNumber()).toBeLessThanOrEqual(
+        estimatedGas.toNumber()
       );
-      botTest("account balance moved with operation value", () =>
-        expect(account.balance.toString()).toBe(
-          accountBeforeTransaction.balance.minus(operation.value).toString()
-        )
+      expect(account.balance.toString()).toBe(
+        accountBeforeTransaction.balance.minus(operation.value).toString()
       );
     },
   },
@@ -122,7 +118,7 @@ const songbird: AppSpec<Transaction> = {
 };
 
 const flare: AppSpec<Transaction> = {
-  name: "Flare",
+  name: "Moonbeam",
   currency: getCryptoCurrencyById("flare"),
   appQuery: {
     model: DeviceModelId.nanoS,

package/src/families/evm/speculos-deviceActions.ts

@@ -1,6 +1,7 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
+import { formatCurrencyUnit } from "../../currencies";
+import { deviceActionFlow } from "../../bot/specs";
 
 function subAccount(subAccountId, account) {
   const sub = (account.subAccounts || []).find((a) => a.id === subAccountId);
@@ -10,7 +11,19 @@ function subAccount(subAccountId, account) {
 }
 
 const maxFeesExpectedValue = ({ account, status }) =>
-  formatDeviceAmount(account.currency, status.estimatedFees);
+  formatCurrencyUnit(
+    {
+      ...account.unit,
+      code: account.currency.deviceTicker || account.unit.code,
+      prefixCode: true,
+    },
+    status.estimatedFees,
+    {
+      showCode: true,
+      disableRounding: true,
+      joinFragmentsSeparator: " ",
+    }
+  ).replace(/\s/g, " ");
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -31,11 +44,26 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
             ? subAccount(transaction.subAccountId, account)
             : null;
 
-          if (a) {
-            return formatDeviceAmount(a.token, status.amount);
-          }
-
-          return formatDeviceAmount(account.currency, status.amount);
+          const unit = !a
+            ? {
+                ...account.unit,
+                code: account.currency.deviceTicker || account.unit.code,
+              }
+            : a.token.units[0];
+          const amount = status.amount;
+          return formatCurrencyUnit(
+            {
+              ...unit,
+              code: account.currency.deviceTicker || account.unit.code,
+              prefixCode: true,
+            },
+            amount,
+            {
+              showCode: true,
+              disableRounding: true,
+              joinFragmentsSeparator: " ",
+            }
+          ).replace(/\s/g, " ");
         },
       },
       {

package/src/families/filecoin/speculos-deviceActions.ts

@@ -1,6 +1,7 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
+import { deviceActionFlow } from "../../bot/specs";
+import { formatCurrencyUnit } from "../../currencies";
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -24,8 +25,8 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         title: "Value",
         button: "Rr",
         expectedValue: ({ account, status }) =>
-          formatDeviceAmount(account.currency, status.amount, {
-            hideCode: true,
+          formatCurrencyUnit(account.unit, status.amount, {
+            disableRounding: true,
             showAllDigits: true,
           }),
       },
@@ -38,8 +39,8 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         title: "Gas Premium",
         button: "Rr",
         expectedValue: ({ account, transaction }) =>
-          formatDeviceAmount(account.currency, transaction.gasPremium, {
-            hideCode: true,
+          formatCurrencyUnit(account.unit, transaction.gasPremium, {
+            disableRounding: true,
             showAllDigits: true,
           }),
       },
@@ -47,8 +48,8 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         title: "Gas Fee Cap",
         button: "Rr",
         expectedValue: ({ account, transaction }) =>
-          formatDeviceAmount(account.currency, transaction.gasFeeCap, {
-            hideCode: true,
+          formatCurrencyUnit(account.unit, transaction.gasFeeCap, {
+            disableRounding: true,
             showAllDigits: true,
           }),
       },

package/src/families/polkadot/speculos-deviceActions.ts

@@ -1,6 +1,7 @@
 import type { DeviceAction } from "../../bot/types";
 import type { PolkadotAccount, Transaction } from "./types";
-import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
+import { deviceActionFlow } from "../../bot/specs";
+import { formatCurrencyUnit } from "../../currencies";
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -21,10 +22,20 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
       {
         title: "Amount",
         button: "Rr",
-        expectedValue: ({ account, transaction }) =>
-          formatDeviceAmount(account.currency, transaction.amount, {
-            forceFloating: true,
-          }),
+        expectedValue: ({ account, transaction }) => {
+          const formattedValue =
+            "DOT " +
+            formatCurrencyUnit(account.unit, transaction.amount, {
+              disableRounding: true,
+            });
+
+          if (!formattedValue.includes(".")) {
+            // if the value is pure integer, in the app it will automatically add an .0
+            return formattedValue + ".0";
+          }
+
+          return formattedValue;
+        },
       },
       {
         title: "Chain",

package/src/families/ripple/speculos-deviceActions.ts

@@ -1,6 +1,7 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
+import { formatCurrencyUnit } from "../../currencies";
+import { deviceActionFlow } from "../../bot/specs";
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -14,13 +15,37 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         title: "Amount",
         button: "Rr",
         expectedValue: ({ account, status }) =>
-          formatDeviceAmount(account.currency, status.amount),
+          formatCurrencyUnit(
+            {
+              ...account.unit,
+              code: account.currency.deviceTicker || account.unit.code,
+              prefixCode: true,
+            },
+            status.amount,
+            {
+              showCode: true,
+              disableRounding: true,
+              joinFragmentsSeparator: " ",
+            }
+          ).replace(/\s/g, " "),
       },
       {
         title: "Fee",
         button: "Rr",
         expectedValue: ({ account, status }) =>
-          formatDeviceAmount(account.currency, status.estimatedFees),
+          formatCurrencyUnit(
+            {
+              ...account.unit,
+              code: account.currency.deviceTicker || account.unit.code,
+              prefixCode: true,
+            },
+            status.estimatedFees,
+            {
+              showCode: true,
+              disableRounding: true,
+              joinFragmentsSeparator: " ",
+            }
+          ).replace(/\s/g, " "),
       },
       {
         title: "Destination Tag",

package/src/families/solana/speculos-deviceActions.ts

@@ -1,6 +1,7 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
+import { formatCurrencyUnit } from "../../currencies";
+import { deviceActionFlow } from "../../bot/specs";
 import { getCryptoCurrencyById } from "@ledgerhq/cryptoassets";
 import BigNumber from "bignumber.js";
 import type { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
@@ -16,11 +17,12 @@ function ellipsis(str: string) {
   return `${str.slice(0, 7)}..${str.slice(-7)}`;
 }
 
-function formatAmount(c: CryptoCurrency, amount: number) {
-  const currency = getMainCurrency(c);
-  return formatDeviceAmount(currency, new BigNumber(amount), {
-    postfixCode: true,
-  });
+function formatAmount(currency: CryptoCurrency, amount: number) {
+  const unit = getMainCurrency(currency).units[0];
+  return formatCurrencyUnit(unit, new BigNumber(amount), {
+    disableRounding: true,
+    showCode: true,
+  }).replace(/\s/g, " ");
 }
 
 export const acceptTransferTransaction: DeviceAction<Transaction, any> =

package/src/families/stellar/api/horizon.ts

@@ -3,7 +3,7 @@ import StellarSdk, {
   // @ts-expect-error stellar-sdk ts definition missing?
   AccountRecord,
   NotFoundError,
-  NetworkError as StellarSdkNetworkError,
+  NetworkError,
 } from "stellar-sdk";
 import { getEnv } from "../../../env";
 import { getCryptoCurrencyById, parseCurrencyUnit } from "../../../currencies";
@@ -14,7 +14,7 @@ import {
   rawOperationsToOperations,
   getReservedBalance,
 } from "../logic";
-import { LedgerAPI4xx, LedgerAPI5xx, NetworkError } from "@ledgerhq/errors";
+import { NetworkDown, LedgerAPI4xx, LedgerAPI5xx } from "@ledgerhq/errors";
 import { requestInterceptor, responseInterceptor } from "../../../network";
 import type { BalanceAsset } from "../types";
 import { NetworkCongestionLevel, Signer } from "../types";
@@ -127,12 +127,8 @@ export const fetchAccount = async (
     assets = account.balances?.filter((balance) => {
       return balance.asset_type !== "native";
     });
-  } catch (e: any) {
-    if (e instanceof NotFoundError || e?.response?.status === 400) {
-      balance.balance = "0";
-    } else {
-      throw new NetworkError();
-    }
+  } catch (e) {
+    balance.balance = "0";
   }
 
   const formattedBalance = parseCurrencyUnit(
@@ -209,11 +205,11 @@ export const fetchOperations = async ({
     }
 
     if (
-      e instanceof StellarSdkNetworkError ||
+      e instanceof NetworkError ||
       errorMsg.match(/ECONNRESET|ECONNREFUSED|ENOTFOUND|EPIPE|ETIMEDOUT/) ||
       errorMsg.match(/undefined is not an object/)
     ) {
-      throw new NetworkError();
+      throw new NetworkDown();
     }
 
     throw e;

package/src/families/stellar/speculos-deviceActions.ts

@@ -1,11 +1,14 @@
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
 import { formatCurrencyUnit } from "../../currencies";
-import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
+import { deviceActionFlow } from "../../bot/specs";
 
 const expectedAmount = ({ account, status, transaction }) => {
   if (transaction.assetCode && transaction.assetIssuer) {
-    const amount = formatDeviceAmount(account.currency, status.amount);
+    const amount = formatCurrencyUnit(account.unit, status.amount, {
+      disableRounding: true,
+      useGrouping: false,
+    });
 
     return `${amount} ${transaction.assetCode}@${truncateAddress(
       transaction.assetIssuer,
@@ -14,9 +17,12 @@ const expectedAmount = ({ account, status, transaction }) => {
     )}`;
   }
 
-  return formatDeviceAmount(account.currency, status.amount, {
-    postfixCode: true,
-  });
+  return (
+    formatCurrencyUnit(account.unit, status.amount, {
+      disableRounding: true,
+      useGrouping: false,
+    }) + " XLM"
+  );
 };
 
 const truncateAddress = (stellarAddress: string, start = 6, end = 6) =>

package/src/families/tezos/speculos-deviceActions.ts

@@ -1,7 +1,8 @@
 // @flow
 import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
-import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
+import { formatCurrencyUnit } from "../../currencies";
+import { deviceActionFlow } from "../../bot/specs";
 
 export const acceptTransaction: DeviceAction<Transaction, any> =
   deviceActionFlow({
@@ -37,18 +38,24 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
       {
         title: "Amount",
         button: "Rr",
-        expectedValue: ({ account, transaction }) =>
-          formatDeviceAmount(account.currency, transaction.amount, {
-            hideCode: true,
-          }),
+        expectedValue: ({ account, transaction }) => {
+          const amount = transaction.amount;
+          return formatCurrencyUnit(account.unit, amount, {
+            disableRounding: true,
+            joinFragmentsSeparator: " ",
+          }).replace(/\s/g, " ");
+        },
       },
       {
         title: "Fee",
         button: "Rr",
-        expectedValue: ({ account, status }) =>
-          formatDeviceAmount(account.currency, status.estimatedFees, {
-            hideCode: true,
-          }),
+        expectedValue: ({ account, status }) => {
+          const amount = status.estimatedFees;
+          return formatCurrencyUnit(account.currency.units[0], amount, {
+            disableRounding: true,
+            joinFragmentsSeparator: " ",
+          }).replace(/\s/g, " ");
+        },
       },
       {
         title: "Source",

package/src/families/tron/speculos-deviceActions.ts

@@ -1,5 +1,6 @@
 import type { DeviceAction } from "../../bot/types";
-import { deviceActionFlow, formatDeviceAmount } from "../../bot/specs";
+import { deviceActionFlow } from "../../bot/specs";
+import { formatCurrencyUnit } from "../../currencies";
 import type { Transaction, Vote } from "./types";
 
 function subAccount(subAccountId, account) {
@@ -39,9 +40,16 @@ export const acceptTransaction: DeviceAction<Transaction, any> =
         title: "Amount",
         button: "Rr",
         expectedValue: ({ account, status }) =>
-          formatDeviceAmount(account.currency, status.amount, {
-            hideCode: true,
-          }),
+          formatCurrencyUnit(
+            {
+              ...account.unit,
+              code: account.currency.deviceTicker || account.unit.code,
+            },
+            status.amount,
+            {
+              disableRounding: true,
+            }
+          ),
       },
       {
         title: "Token",

package/src/featureFlags/defaultFeatures.ts

@@ -109,7 +109,4 @@ export const defaultFeatures: DefaultFeatures = {
   ptxSmartRoutingMobile: {
     enabled: false,
   },
-  mockFeature: {
-    enabled: false,
-  },
 };