@ledgerhq/live-common 27.0.0 → 27.1.0-next.1

package/src/families/cosmos/specs.ts

@@ -13,7 +13,7 @@ import type {
 } from "../../families/cosmos/types";
 import { getCurrentCosmosPreloadData } from "../../families/cosmos/preloadedData";
 import { getCryptoCurrencyById } from "../../currencies";
-import { pickSiblings } from "../../bot/specs";
+import { pickSiblings, botTest } from "../../bot/specs";
 import type { AppSpec } from "../../bot/types";
 import { toOperationRaw } from "../../account";
 import {
@@ -24,6 +24,7 @@ import {
   getMaxDelegationAvailable,
 } from "./logic";
 import { DeviceModelId } from "@ledgerhq/devices";
+import { acceptTransaction } from "./speculos-deviceActions";
 
 const minAmount = new BigNumber(20000);
 const maxAccounts = 32;
@@ -53,6 +54,7 @@ const cosmos: AppSpec<Transaction> = {
     model: DeviceModelId.nanoS,
     appName: "Cosmos",
   },
+  genericDeviceAction: acceptTransaction,
   testTimeout: 2 * 60 * 1000,
   transactionCheck: ({ maxSpendable }) => {
     invariant(maxSpendable.gt(minAmount), "balance is too low");
@@ -64,9 +66,11 @@ const cosmos: AppSpec<Transaction> = {
     if (allOperationsMatchingId.length > 1) {
       console.warn(allOperationsMatchingId);
     }
-    expect({ allOperationsMatchingId }).toEqual({
-      allOperationsMatchingId: [operation],
-    });
+    botTest("only one operation resulted", () =>
+      expect({ allOperationsMatchingId }).toEqual({
+        allOperationsMatchingId: [operation],
+      })
+    );
     const opExpected: Record<string, any> = toOperationRaw({
       ...optimisticOperation,
     });
@@ -78,8 +82,12 @@ const cosmos: AppSpec<Transaction> = {
     const extra = opExpected.extra;
     delete opExpected.extra;
     const op = toOperationRaw(operation);
-    expect(op).toMatchObject(opExpected);
-    expect(approximateExtra(op.extra)).toMatchObject(approximateExtra(extra));
+    botTest("optimistic operation matches", () =>
+      expect(op).toMatchObject(opExpected)
+    );
+    botTest("optimistic operation extra matches", () =>
+      expect(approximateExtra(op.extra)).toMatchObject(approximateExtra(extra))
+    );
   },
   mutations: [
     {
@@ -129,7 +137,9 @@ const cosmos: AppSpec<Transaction> = {
         };
       },
       test: ({ account }) => {
-        expect(account.spendableBalance.toString()).toBe("0");
+        botTest("spendableBalance should go to ZERO", () =>
+          expect(account.spendableBalance.toString()).toBe("0")
+        );
       },
     },
     {
@@ -198,13 +208,15 @@ const cosmos: AppSpec<Transaction> = {
             (d) => d.validatorAddress === v.address
           );
           invariant(d, "delegated %s must be found in account", v.address);
-          expect({
-            address: v.address,
-            amount: approximateValue(v.amount),
-          }).toMatchObject({
-            address: (d as CosmosDelegation).validatorAddress,
-            amount: approximateValue((d as CosmosDelegation).amount),
-          });
+          botTest("delegator have planned address and amount", () =>
+            expect({
+              address: v.address,
+              amount: approximateValue(v.amount),
+            }).toMatchObject({
+              address: (d as CosmosDelegation).validatorAddress,
+              amount: approximateValue((d as CosmosDelegation).amount),
+            })
+          );
         });
       },
     },
@@ -266,13 +278,15 @@ const cosmos: AppSpec<Transaction> = {
             (d) => d.validatorAddress === v.address
           );
           invariant(d, "undelegated %s must be found in account", v.address);
-          expect({
-            address: v.address,
-            amount: approximateValue(v.amount),
-          }).toMatchObject({
-            address: (d as CosmosUnbonding).validatorAddress,
-            amount: approximateValue((d as CosmosUnbonding).amount),
-          });
+          botTest("validator have planned address and amount", () =>
+            expect({
+              address: v.address,
+              amount: approximateValue(v.amount),
+            }).toMatchObject({
+              address: (d as CosmosUnbonding).validatorAddress,
+              amount: approximateValue((d as CosmosUnbonding).amount),
+            })
+          );
         });
       },
     },
@@ -344,13 +358,15 @@ const cosmos: AppSpec<Transaction> = {
                   d.validatorSrcAddress === transaction.sourceValidator
               );
             invariant(d, "redelegated %s must be found in account", v.address);
-            expect({
-              address: v.address,
-              amount: approximateValue(v.amount),
-            }).toMatchObject({
-              address: (d as CosmosRedelegation).validatorDstAddress,
-              amount: approximateValue((d as CosmosRedelegation).amount),
-            });
+            botTest("validator have planned address and amount", () =>
+              expect({
+                address: v.address,
+                amount: approximateValue(v.amount),
+              }).toMatchObject({
+                address: (d as CosmosRedelegation).validatorDstAddress,
+                amount: approximateValue((d as CosmosRedelegation).amount),
+              })
+            );
           }
         });
       },

package/src/families/cosmos/speculos-deviceActions.ts

@@ -9,86 +9,85 @@ const typeWording = {
   claimReward: "Withdraw Reward",
   claimRewardCompound: "(not tested)",
 };
-const acceptTransaction: DeviceAction<Transaction, any> = deviceActionFlow({
-  steps: [
-    {
-      title: "Sequence",
-      button: "Rr",
-    },
-    {
-      title: "Chain ID",
-      button: "Rr",
-    },
-    {
-      title: "Account",
-      button: "Rr",
-    },
-    {
-      title: "Type",
-      button: "Rr",
-      expectedValue: ({ transaction }) => typeWording[transaction.mode],
-    },
-    {
-      title: "Validator Source",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.sourceValidator || "",
-    },
-    {
-      title: "Validator Dest",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.validators[0].address,
-    },
-    {
-      title: "Validator",
-      button: "Rr",
-      expectedValue: ({ transaction }, acc) =>
-        transaction.validators[
-          acc.filter((a) => a.title === "Validator").length
-        ].address,
-    },
-    {
-      title: "Memo",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.memo || "",
-    },
-    {
-      title: "Fee",
-      button: "Rr",
-    },
-    {
-      title: "Gas",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.gas?.toString() || "",
-    },
-    {
-      title: "Amount",
-      button: "Rr",
-    },
-    {
-      title: "From",
-      button: "Rr",
-      expectedValue: ({ account }) => account.freshAddress,
-    },
-    {
-      title: "To",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.recipient,
-    },
-    {
-      title: "Delegator",
-      button: "Rr",
-      expectedValue: ({ account }) => account.freshAddress,
-    },
-    {
-      title: "APPROVE",
-      button: "LRlr",
-      final: true,
-    },
-    {
-      title: "REJECT",
-    },
-  ],
-});
-export default {
-  acceptTransaction,
-};
+
+export const acceptTransaction: DeviceAction<Transaction, any> =
+  deviceActionFlow({
+    steps: [
+      {
+        title: "Sequence",
+        button: "Rr",
+      },
+      {
+        title: "Chain ID",
+        button: "Rr",
+      },
+      {
+        title: "Account",
+        button: "Rr",
+      },
+      {
+        title: "Type",
+        button: "Rr",
+        expectedValue: ({ transaction }) => typeWording[transaction.mode],
+      },
+      {
+        title: "Validator Source",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.sourceValidator || "",
+      },
+      {
+        title: "Validator Dest",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.validators[0].address,
+      },
+      {
+        title: "Validator",
+        button: "Rr",
+        expectedValue: ({ transaction }, acc) =>
+          transaction.validators[
+            acc.filter((a) => a.title === "Validator").length
+          ].address,
+      },
+      {
+        title: "Memo",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.memo || "",
+      },
+      {
+        title: "Fee",
+        button: "Rr",
+      },
+      {
+        title: "Gas",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.gas?.toString() || "",
+      },
+      {
+        title: "Amount",
+        button: "Rr",
+      },
+      {
+        title: "From",
+        button: "Rr",
+        expectedValue: ({ account }) => account.freshAddress,
+      },
+      {
+        title: "To",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.recipient,
+      },
+      {
+        title: "Delegator",
+        button: "Rr",
+        expectedValue: ({ account }) => account.freshAddress,
+      },
+      {
+        title: "APPROVE",
+        button: "LRlr",
+        final: true,
+      },
+      {
+        title: "REJECT",
+      },
+    ],
+  });

package/src/families/crypto_org/specs.ts

@@ -4,6 +4,7 @@ import { getCryptoCurrencyById, parseCurrencyUnit } from "../../currencies";
 import { pickSiblings } from "../../bot/specs";
 import type { AppSpec } from "../../bot/types";
 import { DeviceModelId } from "@ledgerhq/devices";
+import { acceptTransaction } from "./speculos-deviceActions";
 
 const sharedMutations = ({ maxAccount }) => [
   {
@@ -28,6 +29,7 @@ const crypto_org_croeseid: AppSpec<Transaction> = {
     model: DeviceModelId.nanoS,
     appName: "Crypto.orgChain",
   },
+  genericDeviceAction: acceptTransaction,
   testTimeout: 4 * 60 * 1000,
   transactionCheck: ({ maxSpendable }) => {
     invariant(
@@ -50,6 +52,7 @@ const crypto_org: AppSpec<Transaction> = {
     model: DeviceModelId.nanoS,
     appName: "Crypto.orgChain",
   },
+  genericDeviceAction: acceptTransaction,
   testTimeout: 4 * 60 * 1000,
   transactionCheck: ({ maxSpendable }) => {
     invariant(

package/src/families/crypto_org/speculos-deviceActions.ts

@@ -2,62 +2,61 @@ import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
 import { deviceActionFlow } from "../../bot/specs";
 
-const acceptTransaction: DeviceAction<Transaction, any> = deviceActionFlow({
-  steps: [
-    {
-      title: "Review",
-      button: "Rr",
-    },
-    {
-      title: "Chain ID",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Account",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Sequence",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Type",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Amount",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "From",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Fee",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Gas",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "To",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.recipient,
-    },
-    {
-      title: "Approve",
-      button: "LRlr",
-    },
-  ],
-});
-
-export default { acceptTransaction };
+export const acceptTransaction: DeviceAction<Transaction, any> =
+  deviceActionFlow({
+    steps: [
+      {
+        title: "Review",
+        button: "Rr",
+      },
+      {
+        title: "Chain ID",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Account",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Sequence",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Type",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Amount",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "From",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Fee",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Gas",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "To",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.recipient,
+      },
+      {
+        title: "Approve",
+        button: "LRlr",
+      },
+    ],
+  });

package/src/families/elrond/specs.ts

@@ -1,14 +1,24 @@
 import type { Transaction } from "../../families/elrond/types";
 import invariant from "invariant";
 import { getCryptoCurrencyById } from "../../currencies";
-import { pickSiblings } from "../../bot/specs";
-import type { AppSpec } from "../../bot/types";
+import { botTest, pickSiblings } from "../../bot/specs";
+import type { AppSpec, TransactionTestInput } from "../../bot/types";
 import { toOperationRaw } from "../../account";
 import { DeviceModelId } from "@ledgerhq/devices";
 import BigNumber from "bignumber.js";
 import expect from "expect";
+import { acceptTransaction } from "./speculos-deviceActions";
 
 const ELROND_MIN_SAFE = new BigNumber(10000);
+const maxAccounts = 6;
+
+function expectCorrectBalanceChange(input: TransactionTestInput<Transaction>) {
+  const { account, operation, accountBeforeTransaction } = input;
+  expect(account.balance.toNumber()).toBe(
+    accountBeforeTransaction.balance.minus(operation.value).toNumber()
+  );
+}
+
 const elrondSpec: AppSpec<Transaction> = {
   name: "Elrond",
   currency: getCryptoCurrencyById("elrond"),
@@ -16,6 +26,7 @@ const elrondSpec: AppSpec<Transaction> = {
     model: DeviceModelId.nanoS,
     appName: "Elrond",
   },
+  genericDeviceAction: acceptTransaction,
   testTimeout: 2 * 60 * 1000,
   transactionCheck: ({ maxSpendable }) => {
     invariant(maxSpendable.gt(ELROND_MIN_SAFE), "balance is too low");
@@ -30,14 +41,17 @@ const elrondSpec: AppSpec<Transaction> = {
     delete opExpected.date;
     delete opExpected.blockHash;
     delete opExpected.blockHeight;
-    expect(toOperationRaw(operation)).toMatchObject(opExpected);
+    botTest("optimistic operation matches", () =>
+      expect(toOperationRaw(operation)).toMatchObject(opExpected)
+    );
   },
   mutations: [
     {
       name: "send 50%~",
       maxRun: 1,
       transaction: ({ account, siblings, bridge }) => {
-        const sibling = pickSiblings(siblings, 2);
+        invariant(account.spendableBalance.gt(0), "balance is 0");
+        const sibling = pickSiblings(siblings, maxAccounts);
         let amount = account.spendableBalance
           .div(1.9 + 0.2 * Math.random())
           .integerValue();
@@ -62,6 +76,9 @@ const elrondSpec: AppSpec<Transaction> = {
           ],
         };
       },
+      test: (input) => {
+        expectCorrectBalanceChange(input);
+      },
     },
   ],
 };

package/src/families/elrond/speculos-deviceActions.ts

@@ -2,45 +2,44 @@ import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
 import { deviceActionFlow } from "../../bot/specs";
 import { formatCurrencyUnit } from "../../currencies";
-const acceptTransaction: DeviceAction<Transaction, any> = deviceActionFlow({
-  steps: [
-    {
-      title: "Receiver",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.recipient,
-    },
-    {
-      title: "Amount",
-      button: "Rr",
-      expectedValue: ({ account, transaction }) =>
-        formatCurrencyUnit(account.unit, transaction.amount, {
-          showCode: true,
-          disableRounding: true,
-          joinFragmentsSeparator: " ",
-        })
-          .replace(/\s+/g, " ")
-          .replace("egld", "EGLD"), // FIXME
-    },
-    {
-      title: "Fee",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Data",
-      button: "Rr",
-    },
-    {
-      title: "Sign",
-      button: "LRlr",
-    },
-    {
-      title: "Network",
-      button: "Rr",
-      expectedValue: () => "Mainnet",
-    },
-  ],
-});
-export default {
-  acceptTransaction,
-};
+
+export const acceptTransaction: DeviceAction<Transaction, any> =
+  deviceActionFlow({
+    steps: [
+      {
+        title: "Receiver",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.recipient,
+      },
+      {
+        title: "Amount",
+        button: "Rr",
+        expectedValue: ({ account, transaction }) =>
+          formatCurrencyUnit(account.unit, transaction.amount, {
+            showCode: true,
+            disableRounding: true,
+            joinFragmentsSeparator: " ",
+          })
+            .replace(/\s+/g, " ")
+            .replace("egld", "EGLD"), // FIXME
+      },
+      {
+        title: "Fee",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Data",
+        button: "Rr",
+      },
+      {
+        title: "Sign",
+        button: "LRlr",
+      },
+      {
+        title: "Network",
+        button: "Rr",
+        expectedValue: () => "Mainnet",
+      },
+    ],
+  });