@ledgerhq/live-common 25.1.0 → 25.2.0-next.0

package/src/api/socket.ts

@@ -12,7 +12,7 @@ import {
 } from "@ledgerhq/errors";
 import { cancelDeviceAction } from "../hw/deviceAccess";
 import { getEnv } from "../env";
-import type { SocketEvent } from "../types/manager";
+import type { SocketEvent } from "@ledgerhq/types-live";
 const warningsSubject = new Subject<string>();
 export const warnings: Observable<string> = warningsSubject.asObservable();
 const ALLOW_MANAGER_DELAY = 500;

package/src/apps/filtering.test.ts

@@ -5,7 +5,7 @@ import { sortFilterApps } from "./filtering";
 import { setSupportedCurrencies } from "../currencies/support";
 import { setPlatformVersion } from "../platform/version";
 
-setPlatformVersion("1.0.0");
+setPlatformVersion("1.1.0");
 
 type FilteringScenario = {
   name: string;

package/src/apps/filtering.ts

@@ -1,7 +1,7 @@
-import type { App } from "../types/manager";
 import type { InstalledItem } from "./types";
 import { getCryptoCurrencyById, isCurrencySupported } from "../currencies";
 import { useMemo } from "react";
+import type { App } from "@ledgerhq/types-live";
 
 export type SortOptions = {
   type?: "name" | "marketcap" | "default";

package/src/apps/hw.ts

@@ -4,8 +4,6 @@ import { UnexpectedBootloader } from "@ledgerhq/errors";
 import { concat, of, EMPTY, from, Observable, throwError, defer } from "rxjs";
 import { mergeMap, map } from "rxjs/operators";
 import type { Exec, AppOp, ListAppsEvent, ListAppsResult } from "./types";
-import type { App, DeviceInfo } from "../types/manager";
-import { AppType } from "../types/manager";
 import manager, { getProviderId } from "../manager";
 import installApp from "../hw/installApp";
 import uninstallApp from "../hw/uninstallApp";
@@ -28,6 +26,7 @@ import {
 } from "../apps/logic";
 import { runAllWithProgress } from "../apps/runner";
 import type { ConnectAppEvent } from "../hw/connectApp";
+import { App, AppType, DeviceInfo } from "@ledgerhq/types-live";
 
 export const execWithTransport =
   (transport: Transport): Exec =>

package/src/apps/logic.ts

@@ -3,7 +3,6 @@ import { Subject } from "rxjs";
 import flatMap from "lodash/flatMap";
 import semver from "semver";
 import { getDeviceModel } from "@ledgerhq/devices";
-import type { App } from "../types/manager";
 import type {
   AppOp,
   State,
@@ -17,6 +16,7 @@ import {
   isCurrencySupported,
 } from "../currencies";
 import { LatestFirmwareVersionRequired, NoSuchAppOnProvider } from "../errors";
+import { App } from "@ledgerhq/types-live";
 
 export const initState = (
   {

package/src/apps/mock.ts

@@ -10,9 +10,9 @@ import {
 } from "./polyfill";
 import { findCryptoCurrency } from "../currencies";
 import type { ListAppsResult, AppOp, Exec, InstalledItem } from "./types";
-import type { App, DeviceInfo, FinalFirmware } from "../types/manager";
 import { getBTCValues } from "../countervalues/mock";
 import { DeviceModelId } from "@ledgerhq/devices";
+import { App, DeviceInfo, FinalFirmware } from "@ledgerhq/types-live";
 
 export const deviceInfo155 = {
   version: "1.5.5",

package/src/apps/polyfill.ts

@@ -1,10 +1,10 @@
 // polyfill the unfinished support of apps logic
 import uniq from "lodash/uniq";
-import type { App, Application } from "../types/manager";
 import {
   listCryptoCurrencies,
   findCryptoCurrencyById,
 } from "@ledgerhq/cryptoassets";
+import { App, Application } from "@ledgerhq/types-live";
 const directDep = {};
 const reverseDep = {};
 export function declareDep(name: string, dep: string) {

package/src/apps/react.ts

@@ -1,6 +1,5 @@
 import { useState, useReducer, useEffect, useMemo } from "react";
 import type { Exec, State, Action, ListAppsResult } from "./types";
-import type { App } from "../types/manager";
 import type { AppType, SortOptions } from "./filtering";
 import { useSortedFilteredApps } from "./filtering";
 import {
@@ -11,6 +10,7 @@ import {
   predictOptimisticState,
 } from "./logic";
 import { runAppOp } from "./runner";
+import { App } from "@ledgerhq/types-live";
 
 type UseAppsRunnerResult = [State, (arg0: Action) => void];
 // use for React apps. support dynamic change of the state.

package/src/apps/types.ts

@@ -1,7 +1,7 @@
+import { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
 import type { DeviceModel, DeviceModelId } from "@ledgerhq/devices";
+import { App, DeviceInfo, FinalFirmware } from "@ledgerhq/types-live";
 import type { Observable, Subject } from "rxjs";
-import type { CryptoCurrency } from "../types/currencies";
-import type { App, DeviceInfo, FinalFirmware } from "../types/manager";
 export type Exec = (
   appOp: AppOp,
   targetId: string | number,

package/src/bot/engine.ts

@@ -13,14 +13,6 @@ import {
   timeoutWith,
 } from "rxjs/operators";
 import { log } from "@ledgerhq/logs";
-import type {
-  TransactionStatus,
-  Transaction,
-  Account,
-  Operation,
-  SignOperationEvent,
-  CryptoCurrency,
-} from "../types";
 import { getCurrencyBridge, getAccountBridge } from "../bridge";
 import { promiseAllBatched } from "../promise";
 import { isAccountEmpty, formatAccount } from "../account";
@@ -53,6 +45,13 @@ import type {
 } from "./types";
 import { makeBridgeCacheSystem } from "../bridge/cache";
 import { accountDataToAccount, accountToAccountData } from "../cross";
+import type {
+  Account,
+  Operation,
+  SignOperationEvent,
+} from "@ledgerhq/types-live";
+import type { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
+import type { Transaction, TransactionStatus } from "../generated/types";
 
 let appCandidates;
 const localCache = {};

package/src/bot/formatters.ts

@@ -1,5 +1,4 @@
 import groupBy from "lodash/groupBy";
-import type { Transaction } from "../types";
 import { formatOperation, formatAccount } from "../account";
 import {
   toSignedOperationRaw,
@@ -8,6 +7,7 @@ import {
 } from "../transaction";
 import { formatCurrencyUnit } from "../currencies";
 import type { MutationReport, AppCandidate } from "./types";
+import type { Transaction } from "../generated/types";
 export const formatTime = (t: number) =>
   t > 3000
     ? `${Math.round(t / 100) / 10}s`
@@ -21,11 +21,13 @@ export function formatAppCandidate(appCandidate: AppCandidate) {
 
 export function formatError(e: any) {
   if (!e || typeof e !== "object" || e instanceof Error) return String(e);
+  let out;
   try {
-    return "raw object: " + JSON.stringify(e).slice(0, 400);
+    out = "raw object: " + JSON.stringify(e);
   } catch (_e) {
-    return String(e);
+    out = String(e);
   }
+  return out.replace(/\n/g, " ").slice(0, 400);
 }
 
 export function formatReportForConsole<T extends Transaction>({

package/src/bot/index.ts

@@ -8,7 +8,6 @@ import invariant from "invariant";
 import flatMap from "lodash/flatMap";
 import { getEnv } from "../env";
 import allSpecs from "../generated/specs";
-import { Account } from "../types";
 import type { MutationReport, SpecReport } from "./types";
 import { promiseAllBatched } from "../promise";
 import {
@@ -26,6 +25,7 @@ import {
   inferTrackingPairForAccounts,
 } from "../countervalues/logic";
 import { getPortfolio } from "../portfolio/v2";
+import { Account } from "@ledgerhq/types-live";
 type Arg = Partial<{
   currency: string;
   family: string;
@@ -201,10 +201,27 @@ export async function bot({ currency, family, mutation }: Arg = {}) {
         (s.mutations && s.mutations.every((r) => !r.mutation)))
   );
 
+  const fullySuccessfulSpecs = results.filter(
+    (s) =>
+      !s.fatalError &&
+      s.mutations &&
+      !specsWithoutFunds.includes(s) &&
+      s.mutations.every((r) => !r.mutation || r.operation)
+  );
+
+  const specsWithErrors = results.filter(
+    (s) =>
+      !s.fatalError &&
+      s.mutations &&
+      !specsWithoutFunds.includes(s) &&
+      s.mutations.some((r) => r.mutation && !r.operation)
+  );
+
   const specsWithoutOperations = results.filter(
     (s) =>
       !s.fatalError &&
       !specsWithoutFunds.includes(s) &&
+      !specsWithErrors.includes(s) &&
       s.mutations &&
       s.mutations.every((r) => !r.operation)
   );
@@ -225,7 +242,7 @@ export async function bot({ currency, family, mutation }: Arg = {}) {
 
   let body = "";
   let title = "";
-  const runURL = `https://github.com/LedgerHQ/ledger-live-common/actions/runs/${String(
+  const runURL = `https://github.com/LedgerHQ/ledger-live/actions/runs/${String(
     GITHUB_RUN_ID
   )}`;
   const success = mutationReports.length - errorCases.length;
@@ -264,8 +281,42 @@ export async function bot({ currency, family, mutation }: Arg = {}) {
   body += "\n\n";
   body += subtitle;
 
-  if (uncoveredMutations.length) {
-    body += `> ⚠️ ${uncoveredMutations.length} mutations uncovered\n`;
+  if (fullySuccessfulSpecs.length) {
+    const msg = `> ✅ ${
+      fullySuccessfulSpecs.length
+    } specs are successful: _${fullySuccessfulSpecs
+      .map((o) => o.spec.name)
+      .join(", ")}_\n`;
+    body += msg;
+    slackBody += msg;
+  }
+
+  if (specsWithErrors.length) {
+    const msg = `> ❌ ${
+      specsWithErrors.length
+    } specs have problems: _${specsWithErrors
+      .map((o) => o.spec.name)
+      .join(", ")}_\n`;
+    body += msg;
+    slackBody += msg;
+  }
+
+  if (withoutFunds.length) {
+    const missingFundsWarn = `> 💰 ${
+      withoutFunds.length
+    } specs may miss funds: _${withoutFunds.join(", ")}_\n`;
+    body += missingFundsWarn;
+    slackBody += missingFundsWarn;
+  }
+
+  if (specsWithoutOperations.length) {
+    const warn = `> ⚠️ ${
+      specsWithoutOperations.length
+    } specs may have issues: *${specsWithoutOperations
+      .map((o) => o.spec.name)
+      .join(", ")}*\n`;
+    body += warn;
+    slackBody += warn;
   }
 
   body += "\n\n";
@@ -340,28 +391,10 @@ export async function bot({ currency, family, mutation }: Arg = {}) {
     body += "</details>\n\n";
   }
 
-  body += "### Portfolio" + (totalUSD ? " (" + totalUSD + ")" : "") + "\n\n";
-
-  if (withoutFunds.length) {
-    const missingFundsWarn = `> ⚠️ ${
-      withoutFunds.length
-    } specs may miss funds: **${withoutFunds.join(", ")}**\n`;
-    body += missingFundsWarn;
-    slackBody += missingFundsWarn;
-  }
-
-  if (specsWithoutOperations.length) {
-    const warn = `> ⚠️ ${
-      specsWithoutOperations.length
-    } specs may have issues: **${specsWithoutOperations
-      .map((o) => o.spec.name)
-      .join(", ")}**\n`;
-    body += warn;
-    slackBody += warn;
-  }
-
   body += "<details>\n";
-  body += `<summary>Details of the ${results.length} currencies</summary>\n\n`;
+  body += `<summary>Portfolio ${
+    totalUSD ? " (" + totalUSD + ")" : ""
+  } – Details of the ${results.length} currencies</summary>\n\n`;
   body += "| Spec (accounts) | Operations | Balance | funds? |\n";
   body += "|-----------------|------------|---------|--------|\n";
   results.forEach((r) => {

package/src/bot/specs.ts

@@ -5,7 +5,8 @@ import expect from "expect";
 import sample from "lodash/sample";
 import { isAccountEmpty } from "../account";
 import type { DeviceAction, DeviceActionArg } from "./types";
-import type { Account, Transaction } from "../types";
+import { Account } from "@ledgerhq/types-live";
+import type { Transaction } from "../generated/types";
 
 const stepValueTransformDefault = (s) => s.trim();
 

package/src/bot/types.ts

@@ -1,17 +1,16 @@
 import { BigNumber } from "bignumber.js";
 import Transport from "@ledgerhq/hw-transport";
-import type {
+import type { Transaction, TransactionStatus } from "../generated/types";
+import type { DeviceModelId } from "@ledgerhq/devices";
+import type { AppCandidate } from "../load/speculos";
+import {
   Account,
   AccountBridge,
-  Transaction,
-  TransactionStatus,
-  SignedOperation,
   Operation,
-  CryptoCurrency,
+  SignedOperation,
   SignOperationEvent,
-} from "../types";
-import type { DeviceModelId } from "@ledgerhq/devices";
-import type { AppCandidate } from "../load/speculos";
+} from "@ledgerhq/types-live";
+import type { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
 export type { AppCandidate };
 type DeviceActionEvent = {
   text: string;

package/src/bridge/cache.ts

@@ -1,4 +1,4 @@
-import type { CryptoCurrency } from "../types";
+import type { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
 import { makeLRUCache } from "../cache";
 import { getCurrencyBridge } from "./";
 export type BridgeCacheSystem = {

package/src/bridge/impl.ts

@@ -1,16 +1,16 @@
 import { CurrencyNotSupported } from "@ledgerhq/errors";
-import type {
-  CryptoCurrency,
-  Account,
-  AccountLike,
-  CurrencyBridge,
-  AccountBridge,
-} from "../types";
 import { decodeAccountId, getMainAccount } from "../account";
 import { getEnv } from "../env";
 import { checkAccountSupported } from "../account/support";
 import jsBridges from "../generated/bridge/js";
 import mockBridges from "../generated/bridge/mock";
+import type { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
+import {
+  Account,
+  AccountBridge,
+  AccountLike,
+  CurrencyBridge,
+} from "@ledgerhq/types-live";
 
 export const getCurrencyBridge = (currency: CryptoCurrency): CurrencyBridge => {
   if (getEnv("MOCK")) {

package/src/bridge/index.ts

@@ -1,12 +1,12 @@
+import type { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
 import type {
-  CryptoCurrency,
   Account,
+  AccountBridge,
   AccountLike,
   CurrencyBridge,
-  AccountBridge,
-  ScanAccountEventRaw,
   ScanAccountEvent,
-} from "../types";
+  ScanAccountEventRaw,
+} from "@ledgerhq/types-live";
 import { fromAccountRaw, toAccountRaw } from "../account";
 import * as impl from "./impl";
 export type Proxy = {

package/src/bridge/jsHelpers.ts

@@ -13,6 +13,7 @@ import {
   derivationModeSupportsIndex,
   getMandatoryEmptyAccountSkip,
   getDerivationModeStartsAt,
+  DerivationMode,
 } from "../derivation";
 import {
   getAccountPlaceholderName,
@@ -27,19 +28,19 @@ import {
   encodeAccountId,
 } from "../account";
 import { FreshAddressIndexInvalid, UnsupportedDerivation } from "../errors";
+import getAddress from "../hw/getAddress";
+import type { Result, GetAddressOptions } from "../hw/getAddress/types";
+import { withDevice } from "../hw/deviceAccess";
+import type { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
 import type {
-  Operation,
   Account,
+  AccountBridge,
+  CurrencyBridge,
+  Operation,
+  ProtoNFT,
   ScanAccountEvent,
   SyncConfig,
-  CryptoCurrency,
-  DerivationMode,
-  ProtoNFT,
-} from "../types";
-import type { CurrencyBridge, AccountBridge } from "../types/bridge";
-import getAddress from "../hw/getAddress";
-import type { Result, GetAddressOptions } from "../hw/getAddress/types";
-import { withDevice } from "../hw/deviceAccess";
+} from "@ledgerhq/types-live";
 
 // Customize the way to iterate on the keychain derivation
 type IterateResult = ({
@@ -193,7 +194,7 @@ export const makeSync =
         try {
           const freshAddressPath = getSeedIdentifierDerivation(
             initial.currency,
-            initial.derivationMode
+            initial.derivationMode as DerivationMode
           );
 
           const shape = await getAccountShape(
@@ -202,7 +203,7 @@ export const makeSync =
               index: initial.index,
               address: initial.freshAddress,
               derivationPath: freshAddressPath,
-              derivationMode: initial.derivationMode,
+              derivationMode: initial.derivationMode as DerivationMode,
               initialAccount: needClear ? clearAccount(initial) : initial,
             },
             syncConfig

package/src/bridge/mockHelpers.ts

@@ -7,10 +7,14 @@ import { genAccount, genOperation } from "../mock/account";
 import { getOperationAmountNumber } from "../operation";
 import { validateNameEdition } from "../account";
 import { delay } from "../promise";
-import type { Operation, Account } from "../types";
-import type { CurrencyBridge, AccountBridge } from "../types/bridge";
 import { getEnv } from "../env";
 import perFamilyMock from "../generated/mock";
+import {
+  Account,
+  AccountBridge,
+  CurrencyBridge,
+  Operation,
+} from "@ledgerhq/types-live";
 const MOCK_DATA_SEED = getEnv("MOCK") || "MOCK";
 const broadcasted: Record<string, Operation[]> = {};
 const syncTimeouts = {};

package/src/bridge/react/BridgeSync.test.tsx

@@ -0,0 +1,108 @@
+/**
+ * @jest-environment jsdom
+ */
+import "../../__tests__/test-helpers/dom-polyfill";
+import React from "react";
+import { render, screen } from "@testing-library/react";
+import { getCryptoCurrencyById } from "@ledgerhq/cryptoassets";
+import { genAccount } from "../../mock/account";
+import { BridgeSync } from "./BridgeSync";
+import { setSupportedCurrencies } from "../../currencies";
+
+jest.setTimeout(30000);
+
+const defaultsBridgeSyncOpts = {
+  accounts: [],
+  updateAccountWithUpdater: () => {},
+  recoverError: (e) => e,
+  trackAnalytics: () => {},
+  prepareCurrency: () => Promise.resolve(),
+  hydrateCurrency: () => Promise.resolve(),
+  blacklistedTokenIds: [],
+};
+
+setSupportedCurrencies(["bitcoin", "ethereum"]);
+
+describe("BridgeSync", () => {
+  test("initialize without an error", async () => {
+    render(<BridgeSync {...defaultsBridgeSyncOpts}>LOADED</BridgeSync>);
+    expect(screen.getByText("LOADED")).not.toBeNull();
+  });
+
+  test("executes a sync at start tracked as reason=initial", async () => {
+    await new Promise((resolve) => {
+      const BTC = getCryptoCurrencyById("bitcoin");
+      const accounts = [genAccount("btc1", { currency: BTC })];
+      function track(type, opts) {
+        if (type === "SyncSuccess") {
+          expect(opts).toMatchObject({
+            reason: "initial",
+            currencyName: "Bitcoin",
+          });
+          resolve(null);
+        }
+      }
+      render(
+        <BridgeSync
+          {...defaultsBridgeSyncOpts}
+          accounts={accounts}
+          trackAnalytics={track}
+        >
+          {null}
+        </BridgeSync>
+      );
+    });
+  });
+
+  test("sync all accounts in parallel at start tracked as reason=initial", async () => {
+    await new Promise((resolve) => {
+      const BTC = getCryptoCurrencyById("bitcoin");
+      const ETH = getCryptoCurrencyById("ethereum");
+      const accounts = [
+        genAccount("2btc1", { currency: BTC }),
+        genAccount("2btc2", { currency: BTC }),
+        genAccount("2eth1", { currency: ETH }),
+      ];
+      const synced: Array<any> = [];
+      let resolveFirst;
+      function prepareCurrency() {
+        if (!resolveFirst) {
+          return new Promise((resolve, reject) => {
+            resolveFirst = resolve;
+            setTimeout(
+              reject,
+              5000,
+              new Error("prepareCurrency doesn't seem to be called in parallel")
+            );
+          });
+        }
+        // if we reach here, it means, we managed to have
+        // a SECOND sync that need to prepare currency
+        // so it's a proof that sync correctly runs in parallel
+        // otherwise it would timeout
+        resolveFirst();
+        return Promise.resolve();
+      }
+      function track(type, opts) {
+        expect(type).not.toEqual("SyncError");
+        if (type === "SyncSuccess") {
+          synced.push(opts);
+          expect(opts).toMatchObject({
+            reason: "initial",
+          });
+          if (synced.length === accounts.length) resolve(null);
+        }
+      }
+      render(
+        <BridgeSync
+          {...defaultsBridgeSyncOpts}
+          prepareCurrency={prepareCurrency}
+          accounts={accounts}
+          trackAnalytics={track}
+        >
+          {null}
+        </BridgeSync>
+      );
+    });
+  });
+});