@ledgerhq/live-common 25.0.0 → 25.1.0-next.2

package/src/__tests__/test-helpers/bridge.ts

@@ -3,7 +3,11 @@ import { BigNumber } from "bignumber.js";
 import { reduce, filter, map } from "rxjs/operators";
 import flatMap from "lodash/flatMap";
 import omit from "lodash/omit";
-import { InvalidAddress, RecipientRequired } from "@ledgerhq/errors";
+import {
+  InvalidAddress,
+  RecipientRequired,
+  AmountRequired,
+} from "@ledgerhq/errors";
 import type {
   Account,
   Transaction,
@@ -618,6 +622,13 @@ export function testBridge<T extends Transaction>(data: DatasetTest<T>): void {
             const status = await bridge.getTransactionStatus(account, t);
             expect(status.errors.recipient).toBeInstanceOf(InvalidAddress);
           });
+          makeTest("Default empty amount has an amount error", async () => {
+            const account = await getSynced();
+            const t = { ...bridge.createTransaction(account) };
+            const status = await bridge.getTransactionStatus(account, t);
+            expect(status.errors.amount).toBeInstanceOf(AmountRequired);
+          });
+
           const accountDataTest = accountData.test;
 
           if (accountDataTest) {

package/src/apps/react.test.ts

@@ -57,7 +57,7 @@ test("Apps hooks - useAppInstallProgress - Queued or unknown app", () => {
   const { result } = renderHook(() =>
     useAppInstallProgress(mockedState, "not_in_queue")
   );
-  expect(result.current).toBe(1);
+  expect(result.current).toBe(0);
 });
 test("Apps hooks - useAppInstallProgress - Current app", () => {
   const currentProgressSubject: Subject<number> = new Subject();

package/src/apps/react.ts

@@ -151,7 +151,7 @@ export function useAppInstallProgress(state: State, name: string): number {
     return progress;
   }
 
-  return 1;
+  return 0;
 }
 
 // if the app needs deps to be installed, we want to display a modal

package/src/apps/support.ts

@@ -31,7 +31,7 @@ export function shouldUpgrade(
 const appVersionsRequired = {
   Cosmos: ">= 2.34.4",
   Algorand: ">= 1.2.9",
-  Polkadot: ">= 12.9180.0",
+  Polkadot: ">= 13.9250.0",
   Elrond: ">= 1.0.11",
   Ethereum: ">= 1.9.17",
   Solana: ">= 1.2.0",

package/src/bot/index.ts

@@ -194,14 +194,33 @@ export async function bot({ currency, family, mutation }: Arg = {}) {
     );
   }
 
-  const withoutFunds = results
+  const specsWithoutFunds = results.filter(
+    (s) =>
+      !s.fatalError &&
+      ((s.accountsBefore && s.accountsBefore.every(isAccountEmpty)) ||
+        (s.mutations && s.mutations.every((r) => !r.mutation)))
+  );
+
+  const specsWithoutOperations = results.filter(
+    (s) =>
+      !s.fatalError &&
+      !specsWithoutFunds.includes(s) &&
+      s.mutations &&
+      s.mutations.every((r) => !r.operation)
+  );
+
+  const withoutFunds = specsWithoutFunds
     .filter(
       (s) =>
-        !s.fatalError &&
-        ((s.accountsBefore && s.accountsBefore.every(isAccountEmpty)) ||
-          (s.mutations && s.mutations.every((r) => !r.mutation)))
+        // ignore coin that are backed by testnet that have funds
+        !results.some(
+          (o) =>
+            o.spec.currency.isTestnetFor === s.spec.currency.id &&
+            !specsWithoutFunds.includes(o)
+        )
     )
     .map((s) => s.spec.name);
+
   const { GITHUB_RUN_ID, GITHUB_WORKFLOW } = process.env;
 
   let body = "";
@@ -326,11 +345,21 @@ export async function bot({ currency, family, mutation }: Arg = {}) {
   if (withoutFunds.length) {
     const missingFundsWarn = `> ⚠️ ${
       withoutFunds.length
-    } specs don't have enough funds! (${withoutFunds.join(", ")})\n`;
+    } specs may miss funds: **${withoutFunds.join(", ")}**\n`;
     body += missingFundsWarn;
     slackBody += missingFundsWarn;
   }
 
+  if (specsWithoutOperations.length) {
+    const warn = `> ⚠️ ${
+      specsWithoutOperations.length
+    } specs may have issues: **${specsWithoutOperations
+      .map((o) => o.spec.name)
+      .join(", ")}**\n`;
+    body += warn;
+    slackBody += warn;
+  }
+
   body += "<details>\n";
   body += `<summary>Details of the ${results.length} currencies</summary>\n\n`;
   body += "| Spec (accounts) | Operations | Balance | funds? |\n";

package/src/currencies/__snapshots__/sortByMarketcap.test.ts.snap

@@ -155,7 +155,7 @@ Array [
   "ethereum/erc20/ela_coin",
   "ethereum/erc20/playfuel",
   "ethereum/erc20/thorecoin",
-  "ethereum/erc20/husd_stablecoin ",
+  "ethereum/erc20/husd_stablecoin",
   "ethereum/erc20/insight_chain",
   "ethereum/erc20/flexacoin",
   "ethereum/erc20/cofinex",
@@ -516,6 +516,7 @@ Array [
   "ethereum/erc20/asian_fintech",
   "ethereum/erc20/abyss",
   "ethereum/erc20/linkeye_token",
+  "ethereum/erc20/atomic_wallet_token",
   "ethereum/erc20/likecoin",
   "ethereum/erc20/noia_token",
   "ethereum/erc20/czr",
@@ -791,6 +792,7 @@ Array [
   "ethereum/erc20/eristica",
   "ethereum/erc20/hoqu_token",
   "ethereum/erc20/kubo_coin",
+  "ethereum/erc20/sparkpoint",
   "ethereum/erc20/eszcoin",
   "ethereum/erc20/ipsx",
   "ethereum/erc20/pla_token",
@@ -1550,6 +1552,7 @@ Array [
   "ethereum/erc20/ammbr",
   "ethereum/erc20/amp",
   "ethereum/erc20/ampleforth_governance",
+  "ethereum/erc20/amplify_token",
   "ethereum/erc20/ampnet_apx_token",
   "ethereum/erc20/amun_defi_index",
   "ethereum/erc20/amun_defi_momentum_index",
@@ -1576,11 +1579,13 @@ Array [
   "ethereum/erc20/apecoin_dev",
   "ethereum/erc20/apehaven",
   "ethereum/erc20/apenft",
+  "ethereum/erc20/apenftio",
   "ethereum/erc20/api3",
   "ethereum/erc20/apiary_fund_coin",
   "ethereum/erc20/apis",
   "ethereum/erc20/apollo",
   "ethereum/erc20/apollo18",
+  "ethereum/erc20/apollo_inu",
   "ethereum/erc20/apot",
   "ethereum/erc20/app_alliance_association",
   "ethereum/erc20/apple_protocol_token",
@@ -2226,6 +2231,7 @@ Array [
   "ethereum/erc20/covalent_query_token",
   "ethereum/erc20/cover_protocol_governance_token",
   "ethereum/erc20/covir",
+  "ethereum/erc20/cow_protocol_token",
   "ethereum/erc20/cowboy_finance",
   "ethereum/erc20/coweye",
   "ethereum/erc20/cp3rtoken",
@@ -2327,6 +2333,7 @@ Array [
   "ethereum/erc20/curve_fi_eursseur",
   "ethereum/erc20/curve_fi_renbtcwbtc",
   "ethereum/erc20/curve_fi_renbtcwbtcsbtc",
+  "ethereum/erc20/curve_fi_usd-btc-eth",
   "ethereum/erc20/curve_fi_usdk_3crv",
   "ethereum/erc20/cute_coin",
   "ethereum/erc20/cvault_finance",
@@ -2422,6 +2429,7 @@ Array [
   "ethereum/erc20/degenvc",
   "ethereum/erc20/dego_finance",
   "ethereum/erc20/degov",
+  "ethereum/erc20/degrain",
   "ethereum/erc20/dehive_finance",
   "ethereum/erc20/deipool",
   "ethereum/erc20/delphi_tech_token",
@@ -2576,6 +2584,7 @@ Array [
   "ethereum/erc20/dreamcatcher",
   "ethereum/erc20/dripcoin",
   "ethereum/erc20/dripper_finance",
+  "ethereum/erc20/dripto",
   "ethereum/erc20/driveholic_token",
   "ethereum/erc20/dronefly",
   "ethereum/erc20/droplex",
@@ -2612,6 +2621,7 @@ Array [
   "ethereum/erc20/easticoin",
   "ethereum/erc20/easy",
   "ethereum/erc20/easy_v2",
+  "ethereum/erc20/easy_v2_",
   "ethereum/erc20/easyhomes",
   "ethereum/erc20/easyswap",
   "ethereum/erc20/eauric",
@@ -2916,6 +2926,7 @@ Array [
   "ethereum/erc20/freq_set_dollar",
   "ethereum/erc20/friends_with_benefits",
   "ethereum/erc20/friends_with_benefits_pro",
+  "ethereum/erc20/fringe",
   "ethereum/erc20/frmx_token",
   "ethereum/erc20/frogdao_dime",
   "ethereum/erc20/froge_finance_old",
@@ -2951,6 +2962,7 @@ Array [
   "ethereum/erc20/gambler_shiba",
   "ethereum/erc20/game_coin",
   "ethereum/erc20/game_of_bitcoins",
+  "ethereum/erc20/game_on_players",
   "ethereum/erc20/game_x_coin",
   "ethereum/erc20/gamecity",
   "ethereum/erc20/gamee",
@@ -3239,6 +3251,7 @@ Array [
   "ethereum/erc20/idledai",
   "ethereum/erc20/idleusdc",
   "ethereum/erc20/idltoken",
+  "ethereum/erc20/idna",
   "ethereum/erc20/idol",
   "ethereum/erc20/iearn_busd",
   "ethereum/erc20/iearn_tusd",
@@ -3940,7 +3953,6 @@ Array [
   "ethereum/erc20/orao_network",
   "ethereum/erc20/orbicularv2",
   "ethereum/erc20/orbit_chain",
-  "ethereum/erc20/orca_token",
   "ethereum/erc20/orica",
   "ethereum/erc20/orient",
   "ethereum/erc20/orientum_plus",
@@ -4180,6 +4192,7 @@ Array [
   "ethereum/erc20/public_mint",
   "ethereum/erc20/puglife",
   "ethereum/erc20/pulltherug_finance",
+  "ethereum/erc20/pulsedogecoin",
   "ethereum/erc20/pundi_x_token",
   "ethereum/erc20/pundi_x_token_old",
   "ethereum/erc20/punk",
@@ -4313,6 +4326,7 @@ Array [
   "ethereum/erc20/ri_token",
   "ethereum/erc20/rice",
   "ethereum/erc20/ridertoken",
+  "ethereum/erc20/ridotto",
   "ethereum/erc20/rigel_finance",
   "ethereum/erc20/rigeltoken",
   "ethereum/erc20/rigo_token",
@@ -4740,8 +4754,8 @@ Array [
   "ethereum/erc20/swtcoin",
   "ethereum/erc20/sybc_coin",
   "ethereum/erc20/sylo",
-  "ethereum/erc20/synapse",
   "ethereum/erc20/synapse_network",
+  "ethereum/erc20/synapse_protocol",
   "ethereum/erc20/sync",
   "ethereum/erc20/synchrocoin",
   "ethereum/erc20/synlev",
@@ -4954,6 +4968,7 @@ Array [
   "ethereum/erc20/tower",
   "ethereum/erc20/tozex",
   "ethereum/erc20/tr3zor",
+  "ethereum/erc20/trace_network",
   "ethereum/erc20/traceability_chain_coin",
   "ethereum/erc20/tradcoin",
   "ethereum/erc20/trade_butler_bot",
@@ -5284,6 +5299,7 @@ Array [
   "ethereum/erc20/wrapped_etho",
   "ethereum/erc20/wrapped_fct",
   "ethereum/erc20/wrapped_filecoin",
+  "ethereum/erc20/wrapped_flow",
   "ethereum/erc20/wrapped_gen_0",
   "ethereum/erc20/wrapped_hns",
   "ethereum/erc20/wrapped_ilcoin",
@@ -5591,6 +5607,7 @@ Array [
   "polygon/erc20/amp",
   "polygon/erc20/ampleforth_governance",
   "polygon/erc20/ankr_eth2_reward_bearing_certificate",
+  "polygon/erc20/apwine_token_(pos)",
   "polygon/erc20/armor",
   "polygon/erc20/augury_finance",
   "polygon/erc20/aurusgold",
@@ -5631,6 +5648,9 @@ Array [
   "polygon/erc20/crv_(pos)",
   "polygon/erc20/cryption_network_token",
   "polygon/erc20/crypto_development_services",
+  "polygon/erc20/curve.fi_amdaiamusdcamusdt",
+  "polygon/erc20/curve.fi_factory_plain_pool_2jpy",
+  "polygon/erc20/curve.fi_factory_plain_pool_4eur",
   "polygon/erc20/dappradar",
   "polygon/erc20/data_economy_index_(pos)",
   "polygon/erc20/decentr",
@@ -5665,6 +5685,7 @@ Array [
   "polygon/erc20/fish",
   "polygon/erc20/flare_token",
   "polygon/erc20/foam_token",
+  "polygon/erc20/foodchain_global",
   "polygon/erc20/fox",
   "polygon/erc20/fractal_protocol_token",
   "polygon/erc20/frax",
@@ -5708,6 +5729,7 @@ Array [
   "polygon/erc20/jarvis_reward_token",
   "polygon/erc20/jarvis_synthetic_canadian_dollar",
   "polygon/erc20/jarvis_synthetic_euro",
+  "polygon/erc20/jarvis_synthetic_swiss_franc",
   "polygon/erc20/kart_racing_league",
   "polygon/erc20/kastatoken",
   "polygon/erc20/keep_token",
@@ -5731,7 +5753,9 @@ Array [
   "polygon/erc20/meta",
   "polygon/erc20/metaverse_index_(pos)",
   "polygon/erc20/mimatic",
-  "polygon/erc20/moonwolf.io",
+  "polygon/erc20/moo_curve_atricrypto3",
+  "polygon/erc20/moo_mai_usdc-mimatic",
+  "polygon/erc20/moonwolf_io",
   "polygon/erc20/mover",
   "polygon/erc20/mysterium_(pos)",
   "polygon/erc20/nakamoto.games",
@@ -5795,6 +5819,7 @@ Array [
   "polygon/erc20/sekuritance_(pos)",
   "polygon/erc20/sentinel",
   "polygon/erc20/serum",
+  "polygon/erc20/shiba_inu_(pos)",
   "polygon/erc20/shopping.io",
   "polygon/erc20/singularitynet_token",
   "polygon/erc20/spacerat",
@@ -5837,6 +5862,7 @@ Array [
   "polygon/erc20/voyager",
   "polygon/erc20/waultswap_polygon",
   "polygon/erc20/wepower",
+  "polygon/erc20/wlitidao",
   "polygon/erc20/woofy",
   "polygon/erc20/wootrade_network",
   "polygon/erc20/wrapped_celo",
@@ -6074,6 +6100,7 @@ Array [
   "bsc/bep20/faracrystal",
   "bsc/bep20/fegtoken",
   "bsc/bep20/ferrum_network_token",
+  "bsc/bep20/fibo_token",
   "bsc/bep20/finnexus",
   "bsc/bep20/firo",
   "bsc/bep20/flash_token",
@@ -6106,6 +6133,7 @@ Array [
   "bsc/bep20/gourmetgalaxy",
   "bsc/bep20/green_metaverse_token",
   "bsc/bep20/gummy_bull_token",
+  "bsc/bep20/hachiro_inu",
   "bsc/bep20/hacken_token",
   "bsc/bep20/hakka_finance_on_xdai_on_bsc",
   "bsc/bep20/happinesstoken",
@@ -6123,6 +6151,7 @@ Array [
   "bsc/bep20/hunny_token",
   "bsc/bep20/hyfi",
   "bsc/bep20/iassets",
+  "bsc/bep20/immutable",
   "bsc/bep20/impossible_finance",
   "bsc/bep20/injective_protocol",
   "bsc/bep20/innovativebioresearchcoin",
@@ -6142,6 +6171,7 @@ Array [
   "bsc/bep20/kindcow_finance",
   "bsc/bep20/kiwi_token",
   "bsc/bep20/kmoncoin",
+  "bsc/bep20/kunci_coin",
   "bsc/bep20/lamden",
   "bsc/bep20/lien_on_xdai_from_xdai",
   "bsc/bep20/linear_token",
@@ -6196,6 +6226,7 @@ Array [
   "bsc/bep20/nftb",
   "bsc/bep20/nftbooks",
   "bsc/bep20/nobility",
+  "bsc/bep20/noe_crypto_bank",
   "bsc/bep20/nominex",
   "bsc/bep20/num_token_[via_chainport.io]",
   "bsc/bep20/nyanswop_token",
@@ -6264,7 +6295,9 @@ Array [
   "bsc/bep20/revv",
   "bsc/bep20/rfox",
   "bsc/bep20/rigeltoken",
+  "bsc/bep20/right_side",
   "bsc/bep20/roobee",
+  "bsc/bep20/rubic",
   "bsc/bep20/rusd",
   "bsc/bep20/safemoon",
   "bsc/bep20/safemoon_",
@@ -6401,6 +6434,7 @@ Array [
   "bsc/bep20/yield_guild_games_token",
   "bsc/bep20/yieldwatch",
   "bsc/bep20/yourkiss",
+  "bsc/bep20/yummy",
   "bsc/bep20/zeroswaptoken",
   "bsc/bep20/zilliqa",
   "bsc/bep20/zmine_token",

package/src/env.ts

@@ -554,6 +554,11 @@ const envDefinitions = {
     parser: intParser,
     desc: "version used for ledger status api",
   },
+  TEZOS_MAX_TX_QUERIES: {
+    def: 100,
+    parser: intParser,
+    desc: "safe max on maximum number of queries to synchronize a tezos account",
+  },
   PLATFORM_DEBUG: {
     def: false,
     parser: boolParser,

package/src/families/ethereum/hw-signMessage.test.ts

@@ -0,0 +1,110 @@
+import "../../__tests__/test-helpers/setup";
+
+import EIP712Message from "@ledgerhq/hw-app-eth/tests/sample-messages/0.json";
+import hwSignMessage from "./hw-signMessage";
+import { setEnv } from "../../env";
+
+const signPersonalMessage = jest.fn(() =>
+  Promise.resolve({
+    r: "r",
+    s: "s",
+    v: 28,
+  })
+);
+const signEIP712HashedMessage = jest.fn(() =>
+  Promise.resolve({
+    r: "r",
+    s: "s",
+    v: 28,
+  })
+);
+const signEIP712Message = jest.fn(() =>
+  Promise.resolve({
+    r: "r",
+    s: "s",
+    v: 28,
+  })
+);
+jest.mock("@ledgerhq/hw-app-eth", () => {
+  return class {
+    signPersonalMessage = signPersonalMessage;
+    signEIP712HashedMessage = signEIP712HashedMessage;
+    signEIP712Message = signEIP712Message;
+  };
+});
+
+describe("Eth hw-signMessage", () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  describe("parsing", () => {
+    it("should be using the signPersonalMessage method with string message", async () => {
+      await hwSignMessage({} as any, {
+        path: "",
+        message: "test",
+        rawMessage: "0xtest",
+      });
+
+      expect(signPersonalMessage).toHaveBeenCalledTimes(1);
+    });
+
+    it("should be using the signEIP712HashedMessage method with stringified message", async () => {
+      await hwSignMessage({} as any, {
+        path: "",
+        message: JSON.stringify(EIP712Message),
+        rawMessage: "0xtest",
+      });
+
+      expect(signEIP712HashedMessage).toHaveBeenCalledTimes(1);
+    });
+
+    it("should be using the signEIP712Message method with stringified message", async () => {
+      setEnv("EXPERIMENTAL_EIP712", true);
+
+      await hwSignMessage({} as any, {
+        path: "",
+        message: EIP712Message,
+        rawMessage: "0xtest",
+      });
+
+      expect(signEIP712Message).toHaveBeenCalledTimes(1);
+      setEnv("EXPERIMENTAL_EIP712", false);
+    });
+  });
+
+  describe("value of v", () => {
+    it("should returning parity for signPersonalMessage", async () => {
+      const { rsv } = await hwSignMessage({} as any, {
+        path: "",
+        message: "test",
+        rawMessage: "0xtest",
+      });
+
+      expect(rsv.v).toBe(1);
+    });
+
+    it("should not be returning parity for signEIP712HashedMessage", async () => {
+      const { rsv } = await hwSignMessage({} as any, {
+        path: "",
+        message: JSON.stringify(EIP712Message),
+        rawMessage: "0xtest",
+      });
+
+      expect(rsv.v).toBe(28);
+    });
+
+    it("should not be returning parity for signEIP712Message", async () => {
+      setEnv("EXPERIMENTAL_EIP712", true);
+
+      const { rsv } = await hwSignMessage({} as any, {
+        path: "",
+        message: EIP712Message,
+        rawMessage: "0xtest",
+      });
+
+      expect(rsv.v).toBe(28);
+      setEnv("EXPERIMENTAL_EIP712", false);
+    });
+  });
+});

package/src/families/ethereum/hw-signMessage.ts

@@ -1,15 +1,18 @@
+import { EIP712Message } from "@ledgerhq/hw-app-eth/lib/modules/EIP712/EIP712.types";
 import Eth from "@ledgerhq/hw-app-eth";
 import Transport from "@ledgerhq/hw-transport";
 import { TypedDataUtils } from "eth-sig-util";
 import { bufferToHex } from "ethereumjs-util";
 import { getEnv } from "../../env";
 import type { MessageData, Result } from "../../hw/signMessage/types";
-import type { TypedMessageData, TypedMessage } from "./types";
+import type { TypedMessageData } from "./types";
 type EthResolver = (
   arg0: Transport,
-  arg1: MessageData | TypedMessageData
+  arg1: Pick<MessageData | TypedMessageData, "path" | "message"> &
+    Partial<Pick<MessageData, "rawMessage">>
 ) => Promise<Result>;
-export const domainHash = (message: TypedMessage) => {
+
+export const domainHash = (message: EIP712Message): Buffer => {
   return TypedDataUtils.hashStruct(
     "EIP712Domain",
     message.domain,
@@ -17,7 +20,7 @@ export const domainHash = (message: TypedMessage) => {
     true
   );
 };
-export const messageHash = (message: TypedMessage) => {
+export const messageHash = (message: EIP712Message): Buffer => {
   return TypedDataUtils.hashStruct(
     message.primaryType,
     message.message,
@@ -28,29 +31,34 @@ export const messageHash = (message: TypedMessage) => {
 
 const resolver: EthResolver = async (
   transport,
-  // @ts-expect-error only available on MessageData. (type guard)
   { path, message, rawMessage }
 ) => {
   const eth = new Eth(transport);
-  let result;
+  const parsedMessage = (() => {
+    try {
+      return JSON.parse(message as string);
+    } catch (e) {
+      return message;
+    }
+  })();
 
-  if (typeof message === "string") {
-    result = await eth.signPersonalMessage(path, rawMessage.slice(2));
+  let result: Awaited<ReturnType<typeof eth.signPersonalMessage>>;
+  if (typeof parsedMessage === "string") {
+    result = await eth.signPersonalMessage(path, rawMessage?.slice(2) || "");
+    result.v -= 27;
+    // here the expected v is the parity/recoveryId, so we need to remove 27 (v is either 27 or 28)
   } else {
-    if (getEnv("EXPERIMENTAL_EIP712")) {
-      result = await eth.signEIP712Message(path, message);
-    } else {
-      result = await eth.signEIP712HashedMessage(
-        path,
-        bufferToHex(domainHash(message)),
-        bufferToHex(messageHash(message))
-      );
-    }
+    result = getEnv("EXPERIMENTAL_EIP712")
+      ? await eth.signEIP712Message(path, parsedMessage)
+      : await eth.signEIP712HashedMessage(
+          path,
+          bufferToHex(domainHash(parsedMessage)),
+          bufferToHex(messageHash(parsedMessage))
+        );
+    // result.v stays untouched for EIP712 as the expected v is already good (27 or 28)
   }
 
-  let v: string | number = result["v"] - 27;
-  v = v.toString(16);
-
+  let v = result.v.toString(16);
   if (v.length < 2) {
     v = "0" + v;
   }

package/src/families/ethereum/types.ts

@@ -1,3 +1,4 @@
+import { EIP712Message } from "@ledgerhq/hw-app-eth/lib/modules/EIP712/EIP712.types";
 import type { BigNumber } from "bignumber.js";
 import type { Unit } from "../../types";
 import type {
@@ -59,35 +60,12 @@ export type TransactionRaw = TransactionCommonRaw & {
   collectionName?: string;
   quantities?: string[];
 };
-export type TypedMessage = {
-  types: {
-    EIP712Domain: [
-      {
-        type: string;
-        name: string;
-      }
-    ];
-    [key: string]: [
-      {
-        type: string;
-        name: string;
-      }
-    ];
-  };
-  primaryType: string;
-  domain: any;
-  message: any;
-  hashes: {
-    domainHash: string;
-    messageHash: string;
-  };
-};
 export type TypedMessageData = {
   currency: CryptoCurrency;
   path: string;
   verify?: boolean;
   derivationMode: DerivationMode;
-  message: TypedMessage;
+  message: EIP712Message;
   hashes: {
     stringHash: string;
   };

package/src/families/stellar/js-getTransactionStatus.ts

@@ -196,10 +196,10 @@ const getTransactionStatus = async (
         totalSpent = new BigNumber(0);
         amount = new BigNumber(0);
       }
+    }
 
-      if (!errors.amount && amount.eq(0)) {
-        errors.amount = new AmountRequired();
-      }
+    if (!errors.amount && amount.eq(0)) {
+      errors.amount = new AmountRequired();
     }
   }
 

package/src/families/tezos/synchronisation.integration.test.ts

@@ -0,0 +1,22 @@
+import { getEnv, setEnv } from "../../env";
+import { fetchAllTransactions } from "./synchronisation";
+
+jest.setTimeout(2 * 60 * 1000);
+
+describe("TEZOS_MAX_TX_QUERIES", () => {
+  const bigAccount = "tz1boBHAVpwcvKkNFAQHYr7mjxAz1PpVgKq7";
+  test("default have more than 100 txs", async () => {
+    const txs = await fetchAllTransactions(bigAccount);
+    expect(txs.length).toBeGreaterThan(100);
+  });
+  test("lowering it to 1 will only fetch a few txs", async () => {
+    const cur = getEnv("TEZOS_MAX_TX_QUERIES");
+    setEnv("TEZOS_MAX_TX_QUERIES", 1);
+    try {
+      const txs = await fetchAllTransactions(bigAccount);
+      expect(txs.length).toBeLessThanOrEqual(100);
+    } finally {
+      setEnv("TEZOS_MAX_TX_QUERIES", cur);
+    }
+  });
+});