@ledgerhq/live-common 25.0.0-next.2 → 25.0.0-next.5

package/src/families/hedera/js-synchronisation.ts

@@ -1,4 +1,5 @@
 import invariant from "invariant";
+import { BigNumber } from "bignumber.js";
 import { Account, getDerivationScheme, runDerivationScheme } from "../../types";
 import type {
   GetAccountShape,
@@ -31,14 +32,15 @@ const getAccountShape: GetAccountShape = async (
 
   // grab latest operation's consensus timestamp for incremental sync
   const oldOperations = initialAccount?.operations ?? [];
-  const latestOperationTimestamp =
-    oldOperations[0]?.extra?.consensus_timestamp ?? 0;
+  const latestOperationTimestamp = oldOperations[0]
+    ? Math.floor(oldOperations[0].date.getTime() / 1000)
+    : 0;
 
   // merge new operations w/ previously synced ones
   const newOperations = await getOperationsForAccount(
     liveAccountId,
     address,
-    latestOperationTimestamp
+    new BigNumber(latestOperationTimestamp).toString()
   );
   const operations = mergeOps(oldOperations, newOperations);
 

package/src/families/hedera/specs.ts

@@ -2,12 +2,18 @@ import expect from "expect";
 import invariant from "invariant";
 import { getCryptoCurrencyById, parseCurrencyUnit } from "../../currencies";
 import { DeviceModelId } from "@ledgerhq/devices";
-import type { AppSpec } from "../../bot/types";
+import type {
+  AppSpec,
+  TransactionTestInput,
+  TransactionArg,
+  TransactionRes,
+} from "../../bot/types";
 import type { Transaction } from "./types";
 import { pickSiblings } from "../../bot/specs";
 import { isAccountEmpty } from "../../account";
 
 const currency = getCryptoCurrencyById("hedera");
+const memoTestMessage = "This is a test memo.";
 
 // Ensure that, when the recipient corresponds to an empty account,
 // the amount to send is greater or equal to the required minimum
@@ -41,7 +47,11 @@ const hedera: AppSpec<Transaction> = {
     {
       name: "Send ~50%",
       maxRun: 2,
-      transaction: ({ account, siblings, bridge }) => {
+      transaction: ({
+        account,
+        siblings,
+        bridge,
+      }: TransactionArg<Transaction>): TransactionRes<Transaction> => {
         const sibling = pickSiblings(siblings, 4);
         const recipient = sibling.freshAddress;
 
@@ -58,7 +68,11 @@ const hedera: AppSpec<Transaction> = {
           updates: [{ amount }, { recipient }],
         };
       },
-      test: ({ account, accountBeforeTransaction, operation }) => {
+      test: ({
+        account,
+        accountBeforeTransaction,
+        operation,
+      }: TransactionTestInput<Transaction>): void => {
         expect(account.balance.toString()).toBe(
           accountBeforeTransaction.balance.minus(operation.value).toString()
         );
@@ -67,7 +81,11 @@ const hedera: AppSpec<Transaction> = {
     {
       name: "Send max",
       maxRun: 2,
-      transaction: ({ account, siblings, bridge }) => {
+      transaction: ({
+        account,
+        siblings,
+        bridge,
+      }: TransactionArg<Transaction>): TransactionRes<Transaction> => {
         const sibling = pickSiblings(siblings, 4);
         const recipient = sibling.freshAddress;
 
@@ -78,7 +96,12 @@ const hedera: AppSpec<Transaction> = {
           updates: [{ recipient }, { useAllAmount: true }],
         };
       },
-      test: ({ accountBeforeTransaction, account, operation, transaction }) => {
+      test: ({
+        accountBeforeTransaction,
+        account,
+        operation,
+        transaction,
+      }: TransactionTestInput<Transaction>): void => {
         const accountBalanceAfterTx = account.balance.toNumber();
 
         // NOTE: operation.fee is the ACTUAL (not estimated) fee cost of the transaction
@@ -89,6 +112,34 @@ const hedera: AppSpec<Transaction> = {
         expect(accountBalanceAfterTx).toBe(amount);
       },
     },
+    {
+      name: "Memo",
+      maxRun: 2,
+      transaction: ({
+        account,
+        siblings,
+        bridge,
+      }: TransactionArg<Transaction>): TransactionRes<Transaction> => {
+        const sibling = pickSiblings(siblings, 4);
+        const recipient = sibling.freshAddress;
+
+        const transaction = bridge.createTransaction(account);
+
+        const amount = account.balance
+          .div(1.9 + 0.2 * Math.random())
+          .integerValue();
+
+        checkSendableToEmptyAccount(amount, sibling);
+
+        return {
+          transaction,
+          updates: [{ recipient }, { amount }, { memo: memoTestMessage }],
+        };
+      },
+      test: ({ transaction }: TransactionTestInput<Transaction>): void => {
+        expect(transaction.memo).toBe(memoTestMessage);
+      },
+    },
   ],
 };
 

package/src/families/hedera/speculos-deviceActions.ts

@@ -53,6 +53,7 @@ const acceptTransaction: DeviceAction<Transaction, any> = deviceActionFlow({
     {
       title: "Memo",
       button: "Rr",
+      expectedValue: ({ transaction }) => transaction.memo as string,
     },
     {
       title: "Confirm",

package/src/families/hedera/transaction.ts

@@ -29,6 +29,7 @@ export function fromTransactionRaw(tr: TransactionRaw): Transaction {
   return {
     ...common,
     family: tr.family,
+    memo: tr.memo,
   };
 }
 
@@ -38,6 +39,7 @@ export function toTransactionRaw(t: Transaction): TransactionRaw {
   return {
     ...common,
     family: t.family,
+    memo: t.memo,
   };
 }
 

package/src/families/hedera/types.ts

@@ -3,11 +3,6 @@ import type {
   TransactionCommonRaw,
 } from "../../types/transaction";
 
-export type CoreStatics = Record<string, never>;
-export type CoreAccountSpecifics = Record<string, never>;
-export type CoreOperationSpecifics = Record<string, never>;
-export type CoreCurrencySpecifics = Record<string, never>;
-
 export type NetworkInfo = {
   family: "hedera";
 };
@@ -18,11 +13,10 @@ export type NetworkInfoRaw = {
 
 export type Transaction = TransactionCommon & {
   family: "hedera";
+  memo?: string;
 };
 
 export type TransactionRaw = TransactionCommonRaw & {
   family: "hedera";
+  memo?: string;
 };
-
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/no-explicit-any
-export const reflect = (_declare: any) => {};

package/src/families/hedera/utils.ts

@@ -31,7 +31,7 @@ export async function calculateAmount({
 }
 
 // NOTE: convert from the non-url-safe version of base64 to the url-safe version (that the explorer uses)
-export function base64ToUrlSafeBase64(data: string) {
+export function base64ToUrlSafeBase64(data: string): string {
   // Might be nice to use this alternative if .nvmrc changes to >= Node v14.18.0
   // base64url encoding option isn't supported until then
   // Buffer.from(data, "base64").toString("base64url");

package/src/featureFlags/types.ts

@@ -6,6 +6,7 @@ export type FeatureId =
   | "ratings"
   | "counterValue"
   | "buyDeviceFromLive"
+  | "ptxSmartRouting"
   | string;
 
 // We use objects instead of direct booleans for potential future improvements

package/src/generated/deviceTransactionConfig.ts

@@ -2,6 +2,8 @@ import algorand from "../families/algorand/deviceTransactionConfig";
 
 import bitcoin from "../families/bitcoin/deviceTransactionConfig";
 
+import cardano from "../families/cardano/deviceTransactionConfig";
+
 import celo from "../families/celo/deviceTransactionConfig";
 
 import cosmos from "../families/cosmos/deviceTransactionConfig";
@@ -32,6 +34,7 @@ import tron from "../families/tron/deviceTransactionConfig";
 export default {
   algorand,
   bitcoin,
+  cardano,
   celo,
   cosmos,
   crypto_org,

package/src/platform/PlatformAppProvider/api/api.mock.ts

@@ -10,7 +10,7 @@ const manifest: AppManifest[] = [
     supportUrl: "https://paraswap.io",
     icon: "https://cdn.live.ledger.com/icons/platform/paraswap.png",
     platform: "all",
-    apiVersion: "0.0.1",
+    apiVersion: "^1.0.0 || ~0.0.1",
     manifestVersion: "1",
     branch: "stable",
     params: ["accountId"],
@@ -56,7 +56,7 @@ const manifest: AppManifest[] = [
     homepageUrl: "https://lido.fi/",
     icon: "https://cdn.live.ledger.com/icons/platform/lido.png",
     platform: "all",
-    apiVersion: "0.0.1",
+    apiVersion: "^1.0.0 || ~0.0.1",
     manifestVersion: "1",
     branch: "stable",
     categories: ["staking", "defi"],
@@ -79,7 +79,7 @@ const manifest: AppManifest[] = [
     homepageUrl: "https://www.sendwyre.com/",
     icon: "https://cdn.live.ledger.com/icons/platform/wyre.png",
     platform: "all",
-    apiVersion: "0.0.1",
+    apiVersion: "^1.0.0 || ~0.0.1",
     manifestVersion: "1",
     branch: "stable",
     categories: ["exchange", "buy"],
@@ -109,7 +109,7 @@ const manifest: AppManifest[] = [
     homepageUrl: "https://zerion.io/",
     icon: "https://cdn.live.ledger.com/icons/platform/zerion.png",
     platform: "all",
-    apiVersion: "0.0.1",
+    apiVersion: "^1.0.0 || ~0.0.1",
     manifestVersion: "1",
     branch: "stable",
     categories: ["portfolio", "defi"],
@@ -132,7 +132,7 @@ const manifest: AppManifest[] = [
     homepageUrl: "https://rainbow.me",
     icon: "https://cdn.live.ledger.com/icons/platform/rainbow.png",
     platform: "all",
-    apiVersion: "0.0.1",
+    apiVersion: "^1.0.0 || ~0.0.1",
     manifestVersion: "1",
     branch: "stable",
     categories: ["nft"],
@@ -155,7 +155,7 @@ const manifest: AppManifest[] = [
     homepageUrl: "https://aave.com/",
     icon: "https://cdn.live.ledger.com/icons/platform/aave.png",
     platform: "all",
-    apiVersion: "0.0.1",
+    apiVersion: "^1.0.0 || ~0.0.1",
     manifestVersion: "1",
     branch: "soon",
     categories: ["lend"],
@@ -178,7 +178,7 @@ const manifest: AppManifest[] = [
     homepageUrl: "https://compound.finance/",
     icon: "https://cdn.live.ledger.com/icons/platform/compound.png",
     platform: "all",
-    apiVersion: "0.0.1",
+    apiVersion: "^1.0.0 || ~0.0.1",
     manifestVersion: "1",
     branch: "soon",
     categories: ["lend", "compound"],
@@ -201,7 +201,7 @@ const manifest: AppManifest[] = [
     homepageUrl: "https://www.deversifi.com/",
     icon: "https://cdn.live.ledger.com/icons/platform/deversifi.png",
     platform: "all",
-    apiVersion: "0.0.1",
+    apiVersion: "^1.0.0 || ~0.0.1",
     manifestVersion: "1",
     branch: "soon",
     categories: ["dex"],
@@ -224,7 +224,7 @@ const manifest: AppManifest[] = [
     homepageUrl: "https://1inch.io/",
     icon: "https://cdn.live.ledger.com/icons/platform/1inch.png",
     platform: "all",
-    apiVersion: "0.0.1",
+    apiVersion: "^1.0.0 || ~0.0.1",
     manifestVersion: "1",
     branch: "soon",
     categories: ["swap", "defi"],
@@ -247,7 +247,7 @@ const manifest: AppManifest[] = [
     homepageUrl: "https://developers.ledger.com/",
     icon: "https://cdn.live.ledger.com/icons/platform/debugger.png",
     platform: "all",
-    apiVersion: "0.0.1",
+    apiVersion: "^1.0.0 || ~0.0.1",
     manifestVersion: "1",
     branch: "debug",
     categories: ["tools"],
@@ -274,7 +274,7 @@ const manifest: AppManifest[] = [
     homepageUrl: "https://developers.ledger.com/",
     icon: "",
     platform: "all",
-    apiVersion: "0.0.1",
+    apiVersion: "^1.0.0 || ~0.0.1",
     manifestVersion: "1",
     branch: "stable",
     categories: ["tools"],

package/src/platform/PlatformAppProvider/helpers.ts

@@ -1,54 +1,6 @@
 import type { AppManifest } from "../types";
-import semver from "semver";
-export type FilterParams = {
-  branches?: string[];
-  platform?: string;
-  private?: boolean;
-  version?: string;
-};
 import { getEnv } from "../../env";
 
-function matchVersion(filterParams: FilterParams, manifest: AppManifest) {
-  return (
-    !filterParams.version ||
-    semver.satisfies(
-      semver.coerce(filterParams.version) || "",
-      manifest.apiVersion
-    )
-  );
-}
-
-function matchBranches(filterParams: FilterParams, manifest: AppManifest) {
-  return (
-    !filterParams.branches || filterParams.branches.includes(manifest.branch)
-  );
-}
-
-function matchPlatform(filterParams: FilterParams, manifest: AppManifest) {
-  return (
-    !filterParams.platform ||
-    manifest.platform === "all" ||
-    filterParams.platform === manifest.platform
-  );
-}
-
-function matchPrivate(filterParams: FilterParams, manifest: AppManifest) {
-  return filterParams.private === true || !(manifest.private === true);
-}
-
-export function filterPlatformApps(
-  appManifests: AppManifest[],
-  filterParams: FilterParams
-): AppManifest[] {
-  return appManifests.filter((appManifest: AppManifest) => {
-    return (
-      matchBranches(filterParams, appManifest) &&
-      matchPlatform(filterParams, appManifest) &&
-      matchPrivate(filterParams, appManifest) &&
-      matchVersion(filterParams, appManifest)
-    );
-  });
-}
 export function mergeManifestLists(
   list1: AppManifest[],
   list2: AppManifest[]

package/src/platform/converters.ts

@@ -1,13 +1,44 @@
 import byFamily from "../generated/platformAdapter";
-
-import type { Account, CryptoCurrency, Transaction } from "../types";
-import type {
+import { isTokenAccount, isSubAccount } from "../account";
+import { Account, AccountLike, Transaction } from "../types";
+import {
   PlatformAccount,
   PlatformCurrency,
   PlatformTransaction,
+  PlatformCurrencyType,
+  PlatformTokenStandard,
+  PlatformSupportedCurrency,
 } from "./types";
 
-export function accountToPlatformAccount(account: Account): PlatformAccount {
+export function accountToPlatformAccount(
+  account: AccountLike,
+  parentAccount?: Account
+): PlatformAccount {
+  if (isSubAccount(account)) {
+    if (!parentAccount) {
+      throw new Error("No 'parentAccount' account provided for token account");
+    }
+
+    return {
+      id: account.id,
+      balance: account.balance,
+      address: parentAccount.freshAddress,
+      blockHeight: parentAccount.blockHeight,
+      lastSyncDate: parentAccount.lastSyncDate,
+      ...(isTokenAccount(account)
+        ? {
+            name: `${parentAccount.name} (${account.token.ticker})`,
+            currency: account.token.id,
+            spendableBalance: account.spendableBalance,
+          }
+        : {
+            name: account.name,
+            currency: account.currency.id,
+            spendableBalance: parentAccount.spendableBalance,
+          }),
+    };
+  }
+
   return {
     id: account.id,
     name: account.name,
@@ -19,11 +50,34 @@ export function accountToPlatformAccount(account: Account): PlatformAccount {
     lastSyncDate: account.lastSyncDate,
   };
 }
+
 export function currencyToPlatformCurrency(
-  currency: CryptoCurrency
+  currency: PlatformSupportedCurrency
 ): PlatformCurrency {
+  if (currency.type === "TokenCurrency") {
+    if (currency.parentCurrency.family !== "ethereum") {
+      throw new Error("Only ERC20 tokens are supported");
+    }
+
+    return {
+      type: PlatformCurrencyType.TokenCurrency,
+      standard: PlatformTokenStandard.ERC20,
+      id: currency.id,
+      ticker: currency.ticker,
+      contract: currency.contractAddress,
+      name: currency.name,
+      parent: currency.parentCurrency.id,
+      color: currency.parentCurrency.color,
+      units: currency.units.map((unit) => ({
+        name: unit.name,
+        code: unit.code,
+        magnitude: unit.magnitude,
+      })),
+    };
+  }
+
   return {
-    type: currency.type,
+    type: PlatformCurrencyType.CryptoCurrency,
     id: currency.id,
     ticker: currency.ticker,
     name: currency.name,

package/src/platform/filters.ts

@@ -0,0 +1,102 @@
+import { makeRe } from "minimatch";
+import { PlatformAccount, PlatformCurrency, AppManifest } from "./types";
+import { isPlatformTokenCurrency } from "./helpers";
+import semver from "semver";
+
+export type FilterParams = {
+  branches?: string[];
+  platform?: string;
+  private?: boolean;
+  version?: string;
+};
+
+export type AccountFilters = {
+  currencies?: string[];
+};
+
+export function filterPlatformAccounts(
+  accounts: PlatformAccount[],
+  filters: AccountFilters
+): PlatformAccount[] {
+  const filterCurrencyRegexes = filters.currencies
+    ? filters.currencies.map((filter) => makeRe(filter))
+    : null;
+
+  return accounts.filter((account) => {
+    if (
+      filterCurrencyRegexes &&
+      !filterCurrencyRegexes.some((regex) => account.currency.match(regex))
+    ) {
+      return false;
+    }
+    return true;
+  });
+}
+
+export type CurrencyFilters = {
+  includeTokens?: boolean;
+  currencies?: string[];
+};
+
+export function filterPlatformCurrencies(
+  currencies: PlatformCurrency[],
+  filters: CurrencyFilters
+): PlatformCurrency[] {
+  const filterCurrencyRegexes = filters.currencies
+    ? filters.currencies.map((filter) => makeRe(filter))
+    : null;
+
+  return currencies.filter((currency) => {
+    if (!filters.includeTokens && isPlatformTokenCurrency(currency)) {
+      return false;
+    }
+
+    if (
+      filterCurrencyRegexes &&
+      !filterCurrencyRegexes.some((regex) => currency.id.match(regex))
+    ) {
+      return false;
+    }
+
+    return true;
+  });
+}
+
+function matchVersion(filterParams: FilterParams, manifest: AppManifest) {
+  return (
+    !filterParams.version ||
+    semver.satisfies(filterParams.version, manifest.apiVersion)
+  );
+}
+
+function matchBranches(filterParams: FilterParams, manifest: AppManifest) {
+  return (
+    !filterParams.branches || filterParams.branches.includes(manifest.branch)
+  );
+}
+
+function matchPlatform(filterParams: FilterParams, manifest: AppManifest) {
+  return (
+    !filterParams.platform ||
+    manifest.platform === "all" ||
+    filterParams.platform === manifest.platform
+  );
+}
+
+function matchPrivate(filterParams: FilterParams, manifest: AppManifest) {
+  return filterParams.private === true || !(manifest.private === true);
+}
+
+export function filterPlatformApps(
+  appManifests: AppManifest[],
+  filterParams: FilterParams
+): AppManifest[] {
+  return appManifests.filter((appManifest: AppManifest) => {
+    return (
+      matchBranches(filterParams, appManifest) &&
+      matchPlatform(filterParams, appManifest) &&
+      matchPrivate(filterParams, appManifest) &&
+      matchVersion(filterParams, appManifest)
+    );
+  });
+}

package/src/platform/helpers.ts

@@ -0,0 +1,33 @@
+import { isCryptoCurrency, isTokenCurrency } from "../currencies";
+import { Currency } from "../types";
+import {
+  PlatformCurrency,
+  PlatformSupportedCurrency,
+  PlatformERC20TokenCurrency,
+  PlatformCryptoCurrency,
+  PlatformCurrencyType,
+} from "./types";
+
+export function isPlatformSupportedCurrency(
+  currency: Currency
+): currency is PlatformSupportedCurrency {
+  return isCryptoCurrency(currency) || isTokenCurrency(currency);
+}
+
+export function isPlatformCryptoCurrency(
+  currency: PlatformCurrency
+): currency is PlatformCryptoCurrency {
+  return currency.type === PlatformCurrencyType.CryptoCurrency;
+}
+
+export function isPlatformTokenCurrency(
+  currency: PlatformCurrency
+): currency is PlatformERC20TokenCurrency {
+  return currency.type === PlatformCurrencyType.TokenCurrency;
+}
+
+export function isPlatformERC20TokenCurrency(
+  currency: PlatformCurrency
+): currency is PlatformERC20TokenCurrency {
+  return (currency as PlatformERC20TokenCurrency).standard === "ERC20";
+}

package/src/platform/logic.ts

@@ -1,23 +1,4 @@
-import semver from "semver";
-import type { AppManifest, AppPlatform, AppBranch } from "./types";
-import { getPlatformVersion } from "./version";
-
-export function translateContent(content: any, locale = "en") {
+export function translateContent(content: any, locale = "en"): string {
   if (!content || typeof content !== "object") return content;
   return content[locale] || content.en;
 }
-
-export function isSupported(manifest: AppManifest) {
-  return semver.satisfies(
-    semver.coerce(getPlatformVersion()) || "",
-    manifest.apiVersion
-  );
-}
-
-export function matchBranches(manifest: AppManifest, branches: AppBranch[]) {
-  return branches.indexOf(manifest.branch) > -1;
-}
-
-export function matchPlatform(manifest: AppManifest, platform: AppPlatform) {
-  return manifest.platform === "all" || manifest.platform === platform;
-}