@ledgerhq/live-common 24.1.0 → 25.0.0-next.1

package/src/env.ts

@@ -105,6 +105,11 @@ const envDefinitions = {
     def: 200,
     desc: "Limit of operation that Horizon will fetch per page",
   },
+  API_STELLAR_HORIZON_STATIC_FEE: {
+    def: false,
+    parser: boolParser,
+    desc: "Static fee for Stellar account",
+  },
   API_TEZOS_BAKER: {
     parser: stringParser,
     def: "https://tezos-bakers.api.live.ledger.com",
@@ -419,6 +424,11 @@ const envDefinitions = {
     parser: boolParser,
     desc: "mock the cryptoassets config and test partner (in the context of app-exchange)",
   },
+  MOCK_REMOTE_LIVE_MANIFEST: {
+    def: "",
+    parser: stringParser,
+    desc: "mock remote live app manifest",
+  },
   NFT_CURRENCIES: {
     def: "ethereum,polygon",
     parser: stringParser,

package/src/errors.test.ts

@@ -0,0 +1,21 @@
+import { AccessDeniedError } from "./errors";
+
+function functionA() {
+  throw new AccessDeniedError();
+}
+
+describe("custom errors", () => {
+  test("error instanceof", () => {
+    try {
+      functionA();
+    } catch (e: any) {
+      expect(e).toBeInstanceOf(AccessDeniedError);
+    }
+  });
+
+  test("promise error instanceof", () => {
+    expect(Promise.reject(new AccessDeniedError())).rejects.toBeInstanceOf(
+      AccessDeniedError
+    );
+  });
+});

package/src/errors.ts

@@ -60,12 +60,6 @@ export const TronTransactionExpired = createCustomErrorClass(
 export const TronNotEnoughEnergy = createCustomErrorClass(
   "TronNotEnoughEnergy"
 );
-export const StellarMemoRecommended = createCustomErrorClass(
-  "StellarMemoRecommended"
-);
-export const StellarWrongMemoFormat = createCustomErrorClass(
-  "StellarWrongMemoFormat"
-);
 export const AccountAwaitingSendPendingOperations = createCustomErrorClass(
   "AccountAwaitingSendPendingOperations"
 );
@@ -213,5 +207,6 @@ export const UnsupportedDerivation = createCustomErrorClass(
 );
 
 export * from "./families/polkadot/errors";
+export * from "./families/stellar/errors";
 export * from "./families/solana/errors";
 export * from "./families/cardano/errors";

package/src/exchange/swap/utils/index.test.ts

@@ -1,4 +1,4 @@
-import { getTokenById } from "@ledgerhq/cryptoassets/lib/tokens";
+import { getTokenById } from "@ledgerhq/cryptoassets";
 import BigNumber from "bignumber.js";
 import { getCryptoCurrencyById } from "../../../currencies";
 import { genAccount } from "../../../mock/account";

package/src/families/bitcoin/datasets/bitcoin.ts

@@ -134,7 +134,6 @@ const dataset: CurrenciesData<Transaction> = {
         balance: "2757",
         blockHeight: 0,
         lastSyncDate: "",
-        xpub: "xpub6BuPWhjLqutPV8SF4RMrrn8c3t7uBZbz4CBbThpbg9GYjqRMncra9mjgSfWSK7uMDz37hhzJ8wvkbDDQQJt6VgwLoszvmPiSBtLA1bPLLSn",
       },
     },
     {
@@ -160,7 +159,6 @@ const dataset: CurrenciesData<Transaction> = {
         unitMagnitude: 8,
         lastSyncDate: "",
         balance: "2717",
-        xpub: "xpub6DEHKg8fgKcb9at2u9Xhjtx4tXGyWqUPQAx2zNCzr41gQRyCqpCn7onSoJU4VS96GXyCtAhhFxErnG2pGVvVexaqF7DEfqGGnGk7Havn7C2",
       },
     },
   ],

package/src/families/bitcoin/descriptor.ts

@@ -13,6 +13,8 @@ import {
 } from "../../derivation";
 import { withDevice } from "../../hw/deviceAccess";
 import getAddress from "../../hw/getAddress";
+import { decodeAccountId } from "../../account/accountId";
+
 export type AccountDescriptor = {
   internal: string;
   external: string;
@@ -57,7 +59,8 @@ export function inferDescriptorFromAccount(
   account: Account
 ): AccountDescriptor | null | undefined {
   if (account.currency.family !== "bitcoin") return;
-  const { xpub, derivationMode, seedIdentifier, currency, index } = account;
+  const { id, derivationMode, seedIdentifier, currency, index } = account;
+  const xpub = decodeAccountId(id).xpubOrAddress;
   const fingerprint = makeFingerprint(
     compressPublicKeySECP256(Buffer.from(seedIdentifier, "hex"))
   );

package/src/families/bitcoin/exchange.ts

@@ -1,4 +1,4 @@
-import { bip32asBuffer } from "@ledgerhq/hw-app-btc/lib/bip32";
+import { bip32asBuffer } from "@ledgerhq/hw-app-btc/bip32";
 import type { DerivationMode } from "../../derivation";
 import { getAddressFormatDerivationMode } from "../../derivation";
 import invariant from "invariant";

package/src/families/bitcoin/hw-getAddress.ts

@@ -10,7 +10,7 @@ import type {
 } from "../../hw/getAddress/types";
 import { UnsupportedDerivation } from "../../errors";
 import Transport from "@ledgerhq/hw-transport";
-import BtcOld from "@ledgerhq/hw-app-btc/lib/BtcOld";
+import BtcOld from "@ledgerhq/hw-app-btc/BtcOld";
 
 const oldP2SH = {
   digibyte: 5,

package/src/families/bitcoin/js-synchronisation.ts

@@ -19,6 +19,8 @@ import { perCoinLogic } from "./logic";
 import wallet from "./wallet-btc";
 import { getAddressWithBtcInstance } from "./hw-getAddress";
 import { mapTxToOperations } from "./logic";
+import { decodeAccountId } from "../../account/accountId";
+import { startSpan } from "../../performance";
 
 // Map LL's DerivationMode to wallet-btc's
 const toWalletDerivationMode = (
@@ -79,6 +81,7 @@ const deduplicateOperations = (
 };
 
 const getAccountShape: GetAccountShape = async (info) => {
+  let span;
   const {
     transport,
     currency,
@@ -93,7 +96,9 @@ const getAccountShape: GetAccountShape = async (info) => {
   const rootPath = derivationPath.split("/", 2).join("/");
   const accountPath = `${rootPath}/${index}'`;
 
-  const paramXpub = initialAccount?.xpub;
+  const paramXpub = initialAccount
+    ? decodeAccountId(initialAccount.id).xpubOrAddress
+    : undefined;
 
   let generatedXpub;
   if (!paramXpub) {
@@ -132,6 +137,7 @@ const getAccountShape: GetAccountShape = async (info) => {
     throw new Error(`Unsupported explorer version ${explorer.version}`);
   }
 
+  span = startSpan("sync", "generateAccount");
   const walletAccount =
     initialAccount?.bitcoinResources?.walletAccount ||
     (await wallet.generateAccount({
@@ -146,6 +152,7 @@ const getAccountShape: GetAccountShape = async (info) => {
       storage: "mock",
       storageParams: [],
     }));
+  span.finish();
 
   const oldOperations = initialAccount?.operations || [];
   await wallet.syncAccount(walletAccount);
@@ -153,22 +160,29 @@ const getAccountShape: GetAccountShape = async (info) => {
   const currentBlock = await walletAccount.xpub.explorer.getCurrentBlock();
   const blockHeight = currentBlock?.height;
 
+  span = startSpan("sync", "getAccountTransactions");
   // @ts-expect-error return from wallet-btc should be typed
   const { txs: transactions } = await wallet.getAccountTransactions(
     walletAccount
   );
+  span.finish();
 
+  span = startSpan("sync", "getXpubAddresses");
   const accountAddresses: Set<string> = new Set<string>();
   const accountAddressesWithInfo = await walletAccount.xpub.getXpubAddresses();
   accountAddressesWithInfo.forEach((a) => accountAddresses.add(a.address));
+  span.finish();
 
+  span = startSpan("sync", "getUniquesAddresses");
   const changeAddresses: Set<string> = new Set<string>();
   const changeAddressesWithInfo =
     await walletAccount.xpub.storage.getUniquesAddresses({
       account: 1,
     });
   changeAddressesWithInfo.forEach((a) => changeAddresses.add(a.address));
+  span.finish();
 
+  span = startSpan("sync", "mapTxToOperations");
   const newOperations = transactions
     ?.map((tx) =>
       mapTxToOperations(
@@ -180,10 +194,18 @@ const getAccountShape: GetAccountShape = async (info) => {
       )
     )
     .flat();
+  span.finish();
+
+  span = startSpan("sync", "unify operations");
   const newUniqueOperations = deduplicateOperations(newOperations);
   const operations = mergeOps(oldOperations, newUniqueOperations);
+  span.finish();
+
+  span = startSpan("sync", "gather utxos");
   const rawUtxos = await wallet.getAccountUnspentUtxos(walletAccount);
   const utxos = rawUtxos.map((utxo) => fromWalletUtxo(utxo, changeAddresses));
+  span.finish();
+
   return {
     id: accountId,
     xpub,

package/src/families/bitcoin/wallet-btc/storage/index.ts

@@ -1,4 +1,4 @@
-import { findLast, filter, uniqBy, findIndex, isEmpty } from "lodash";
+import { findLast, filter, uniqBy, findIndex } from "lodash";
 import Base from "../crypto/base";
 import { Input, IStorage, Output, TX, Address } from "./types";
 
@@ -78,13 +78,10 @@ class BitcoinLikeStorage implements IStorage {
       if (this.txs[this.primaryIndex[index]]) {
         return;
       }
-      if (
-        typeof this.accountIndex[`${tx.account}-${tx.index}`] === "undefined"
-      ) {
-        this.accountIndex[`${tx.account}-${tx.index}`] = [];
-      }
       const idx = this.txs.push(tx) - 1;
       this.primaryIndex[index] = idx;
+      this.accountIndex[`${tx.account}-${tx.index}`] =
+        this.accountIndex[`${tx.account}-${tx.index}`] || [];
       this.accountIndex[`${tx.account}-${tx.index}`].push(idx);
       this.unspentUtxos[indexAddress] = this.unspentUtxos[indexAddress] || [];
       this.spentUtxos[indexAddress] = this.spentUtxos[indexAddress] || [];
@@ -196,43 +193,32 @@ class BitcoinLikeStorage implements IStorage {
   exportSync() {
     return {
       txs: this.txs,
-      primaryIndex: this.primaryIndex,
-      accountIndex: this.accountIndex,
-      unspentUtxos: this.unspentUtxos,
       addressCache: this.addressCache,
     };
   }
 
-  loadSync(data: {
-    txs: TX[];
-    primaryIndex: { [key: string]: number };
-    accountIndex: { [key: string]: number[] };
-    unspentUtxos: { [key: string]: Output[] };
-    addressCache: { [key: string]: string };
-  }) {
-    this.txs = data.txs;
-    this.primaryIndex = data.primaryIndex;
-    this.accountIndex = data.accountIndex;
-    this.unspentUtxos = data.unspentUtxos;
+  loadSync(data: { txs: TX[]; addressCache: { [key: string]: string } }) {
+    this.txs = [];
+    this.primaryIndex = {};
+    this.accountIndex = {};
+    this.unspentUtxos = {};
+    this.spentUtxos = {};
+    data.txs.forEach((tx) => {
+      // migration from the field "hash" to "id" to adapt old data format
+      if (!tx.id && tx.hash) {
+        tx.id = tx.hash;
+      }
+    });
+    this.appendTxs(data.txs);
     this.addressCache = data.addressCache;
     Base.addressCache = { ...Base.addressCache, ...this.addressCache };
-    if (!this.accountIndex || isEmpty(this.accountIndex)) {
-      this.accountIndex = {};
-      this.createAccountIndex();
-    }
   }
 
   async export() {
     return this.exportSync();
   }
 
-  async load(data: {
-    txs: TX[];
-    primaryIndex: { [key: string]: number };
-    accountIndex: { [key: string]: number[] };
-    unspentUtxos: { [key: string]: Output[] };
-    addressCache: { [key: string]: string };
-  }) {
+  async load(data: { txs: TX[]; addressCache: { [key: string]: string } }) {
     return this.loadSync(data);
   }
 

package/src/families/bitcoin/wallet-btc/storage/types.ts

@@ -1,5 +1,6 @@
 export interface TX {
   id: string;
+  hash?: string;
   account: number;
   index: number;
   received_at: string;

package/src/families/bitcoin/wallet-btc/wallet.ts

@@ -4,7 +4,7 @@ import { flatten } from "lodash";
 import BigNumber from "bignumber.js";
 import Btc from "@ledgerhq/hw-app-btc";
 import { log } from "@ledgerhq/logs";
-import { Transaction } from "@ledgerhq/hw-app-btc/lib/types";
+import { Transaction } from "@ledgerhq/hw-app-btc/types";
 import { Currency } from "./crypto/types";
 import { TransactionInfo, DerivationModes } from "./types";
 import { Account, SerializedAccount } from "./account";

package/src/families/bitcoin/xpub.txs.loadExport.unit.test.ts

@@ -0,0 +1,101 @@
+import BitcoinLikeStorage from "./wallet-btc/storage";
+
+describe("testing transaction data load and export", () => {
+  it("testing transaction data load and export", async () => {
+    const storage = new BitcoinLikeStorage();
+    storage.appendTxs([
+      {
+        id: "9e1b337875c21f751e70ee2c2c6ee93d8a6733d0f3ba6d139ae6a0479ebcefb0",
+        inputs: [],
+        outputs: [
+          {
+            output_index: 0,
+            value: "5000000000",
+            address: "mwXTtHo8Yy3aNKUUZLkBDrTcKT9qG9TqLb",
+            output_hash:
+              "9e1b337875c21f751e70ee2c2c6ee93d8a6733d0f3ba6d139ae6a0479ebcefb0",
+            block_height: 1,
+            rbf: false,
+          },
+          {
+            output_index: 1,
+            value: "0",
+            address: "<unknown>",
+            output_hash:
+              "9e1b337875c21f751e70ee2c2c6ee93d8a6733d0f3ba6d139ae6a0479ebcefb0",
+            block_height: 1,
+            rbf: false,
+          },
+        ],
+        block: {
+          hash: "73c565a6f226978df23480e440b27eb02f307855f50aa3bc72ebb586938f23e0",
+          height: 1,
+          time: "2021-07-28T13:34:17Z",
+        },
+        account: 0,
+        index: 0,
+        address: "mwXTtHo8Yy3aNKUUZLkBDrTcKT9qG9TqLb",
+        received_at: "2021-07-28T13:34:17Z",
+      },
+      {
+        id: "0b9f98d07eb418fa20573112d3cba6b871d429a06c724a7888ff0886be5213d1",
+        inputs: [
+          {
+            output_hash:
+              "2772f3963856f3eb38cb706ec8c2b62fcdeb2ce10f32cf7160afb3873be6f60d",
+            output_index: 0,
+            value: "5000000000",
+            address: "2NCDBM9DAuMrD1T8XDHMxvbTmLutP7at4AB",
+            sequence: 4294967294,
+          },
+        ],
+        outputs: [
+          {
+            output_index: 0,
+            value: "300000000",
+            address: "mwXTtHo8Yy3aNKUUZLkBDrTcKT9qG9TqLb",
+            output_hash:
+              "0b9f98d07eb418fa20573112d3cba6b871d429a06c724a7888ff0886be5213d1",
+            block_height: 120,
+            rbf: false,
+          },
+          {
+            output_index: 1,
+            value: "4699983200",
+            address: "2MynSTpze5SDcuLr1DekSV7RVrFpQCo3LeP",
+            output_hash:
+              "0b9f98d07eb418fa20573112d3cba6b871d429a06c724a7888ff0886be5213d1",
+            block_height: 120,
+            rbf: false,
+          },
+        ],
+        block: {
+          hash: "305d4b8d4a6d6ecca0a3dd0216f8ecd090978ed346d1845883c8aa4529d72fc8",
+          height: 120,
+          time: "2021-07-28T13:34:38Z",
+        },
+        account: 0,
+        index: 0,
+        address: "mwXTtHo8Yy3aNKUUZLkBDrTcKT9qG9TqLb",
+        received_at: "2021-07-28T13:34:38Z",
+      },
+    ]);
+    const primaryIndexCopy = Object.assign({}, storage.primaryIndex);
+    const accountIndexCopy = Object.assign({}, storage.accountIndex);
+    expect(Object.keys(primaryIndexCopy).length).toEqual(2);
+    expect(Object.keys(accountIndexCopy).length).toEqual(1);
+    /* primaryIndex:
+    {
+      'mwXTtHo8Yy3aNKUUZLkBDrTcKT9qG9TqLb-9e1b337875c21f751e70ee2c2c6ee93d8a6733d0f3ba6d139ae6a0479ebcefb0': 0,
+      'mwXTtHo8Yy3aNKUUZLkBDrTcKT9qG9TqLb-0b9f98d07eb418fa20573112d3cba6b871d429a06c724a7888ff0886be5213d1': 1
+    }
+      accountIndex:
+      { '0-0': [ 0, 1 ] }
+    */
+    expect(Object.keys(accountIndexCopy["0-0"]).length).toEqual(2);
+    const txs = (await storage.export()).txs;
+    storage.load({ txs: txs, addressCache: {} });
+    expect(storage.primaryIndex).toMatchObject(primaryIndexCopy);
+    expect(storage.accountIndex).toMatchObject(accountIndexCopy);
+  }, 30000);
+});

package/src/families/ethereum/exchange.ts

@@ -1,4 +1,4 @@
-import { bip32asBuffer } from "@ledgerhq/hw-app-btc/lib/bip32";
+import { bip32asBuffer } from "@ledgerhq/hw-app-btc/bip32";
 
 const getSerializedAddressParameters = (
   path: string

package/src/families/ethereum/modules/index.ts

@@ -20,7 +20,7 @@ import type { Modes as ERC20Modes } from "./erc20";
 import type { Modes as SendModes } from "./send";
 import type { Modes as ERC721Modes } from "./erc721";
 import type { Modes as ERC1155Modes } from "./erc1155";
-import { ResolutionConfig } from "@ledgerhq/hw-app-eth/lib/services/types";
+import type { ResolutionConfig } from "@ledgerhq/hw-app-eth/lib/services/types";
 
 const modules = {
   erc20,

package/src/families/ethereum/signOperation.ts

@@ -8,7 +8,7 @@ import { log } from "@ledgerhq/logs";
 import { FeeNotLoaded } from "@ledgerhq/errors";
 import Eth from "@ledgerhq/hw-app-eth";
 import { byContractAddressAndChainId } from "@ledgerhq/hw-app-eth/erc20";
-import ethLedgerServices from "@ledgerhq/hw-app-eth/lib/services/ledger";
+import { ledgerService as ethLedgerServices } from "@ledgerhq/hw-app-eth";
 import type { Transaction } from "./types";
 import type { Operation, Account, SignOperationEvent } from "../../types";
 import { getGasLimit, buildEthereumTx } from "./transaction";
@@ -17,7 +17,7 @@ import { withDevice } from "../../hw/deviceAccess";
 import { modes } from "./modules";
 import { isNFTActive } from "../../nft";
 import { getEnv } from "../../env";
-import { LoadConfig } from "@ledgerhq/hw-app-eth/lib/services/types";
+import type { LoadConfig } from "@ledgerhq/hw-app-eth/lib/services/types";
 import { Transaction as EthereumTx } from "@ethereumjs/tx";
 export const signOperation = ({
   account,

package/src/families/ethereum/specs.ts

@@ -375,9 +375,9 @@ const ethereumClassic: AppSpec<Transaction> = {
     maxAccount: 4,
   }),
 };
-const ethereumRopsten: AppSpec<Transaction> = {
-  name: "Ethereum Ropsten",
-  currency: getCryptoCurrencyById("ethereum_ropsten"),
+const ethereumGoerli: AppSpec<Transaction> = {
+  name: "Ethereum Goerli",
+  currency: getCryptoCurrencyById("ethereum_goerli"),
   appQuery: {
     model: DeviceModelId.nanoS,
     appName: "Ethereum",
@@ -387,7 +387,7 @@ const ethereumRopsten: AppSpec<Transaction> = {
     invariant(
       maxSpendable.gt(
         parseCurrencyUnit(
-          getCryptoCurrencyById("ethereum_ropsten").units[0],
+          getCryptoCurrencyById("ethereum_goerli").units[0],
           "0.01"
         )
       ),
@@ -498,5 +498,5 @@ export default {
   polygon,
   ethereum,
   ethereumClassic,
-  ethereumRopsten,
+  ethereumGoerli,
 };

package/src/families/ripple/exchange.ts

@@ -1,4 +1,4 @@
-import { bip32asBuffer } from "@ledgerhq/hw-app-btc/lib/bip32";
+import { bip32asBuffer } from "@ledgerhq/hw-app-btc/bip32";
 
 const getSerializedAddressParameters = (
   path: string