@ledgerhq/live-common 23.1.0 → 24.0.0-next.0

package/src/families/ethereum/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,3 +1,6 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
+
 import invariant from "invariant";
 import { BigNumber } from "bignumber.js";
 import type { AccountRaw, DatasetTest } from "../../types";
@@ -11,24 +14,7 @@ import type { Transaction } from "./types";
 import ethereumScanAccounts1 from "./datasets/ethereum.scanAccounts.1";
 import ethereum_classic from "./datasets/ethereum_classic";
 import { syncAccount } from "../../__tests__/test-helpers/bridge";
-export const ethereum1: AccountRaw = {
-  id: "js:1:ethereum:0x0E3F0bb9516F01f2C34c25E0957518b8aC9414c5:",
-  seedIdentifier: "0x0E3F0bb9516F01f2C34c25E0957518b8aC9414c5",
-  name: "Ethereum legacy xpub6Bem...JyAdpYZy",
-  derivationMode: "",
-  index: 0,
-  freshAddress: "0x0E3F0bb9516F01f2C34c25E0957518b8aC9414c5",
-  freshAddressPath: "44'/60'/0'/0/0",
-  freshAddresses: [],
-  pendingOperations: [],
-  operations: [],
-  currencyId: "ethereum",
-  unitMagnitude: 18,
-  balance: "",
-  blockHeight: 0,
-  lastSyncDate: "",
-  xpub: "",
-};
+import { ethereum1 } from "./datasets/ethereum1";
 
 const expectedTokenAccount = (a) => {
   invariant(a && a.type === "TokenAccount", "expected token account");
@@ -171,4 +157,5 @@ const dataset: DatasetTest<Transaction> = {
     ethereum_classic,
   },
 };
-export default dataset;
+
+testBridge(dataset);

package/src/families/ethereum/datasets/ethereum1.ts

@@ -0,0 +1,20 @@
+import type { AccountRaw } from "../../../types";
+
+export const ethereum1: AccountRaw = {
+  id: "js:1:ethereum:0x0E3F0bb9516F01f2C34c25E0957518b8aC9414c5:",
+  seedIdentifier: "0x0E3F0bb9516F01f2C34c25E0957518b8aC9414c5",
+  name: "Ethereum legacy xpub6Bem...JyAdpYZy",
+  derivationMode: "",
+  index: 0,
+  freshAddress: "0x0E3F0bb9516F01f2C34c25E0957518b8aC9414c5",
+  freshAddressPath: "44'/60'/0'/0/0",
+  freshAddresses: [],
+  pendingOperations: [],
+  operations: [],
+  currencyId: "ethereum",
+  unitMagnitude: 18,
+  balance: "",
+  blockHeight: 0,
+  lastSyncDate: "",
+  xpub: "",
+};

package/src/families/ethereum/modules/{compound.resilience.test.ts → compound.resilience.integration.test.ts}

@@ -4,7 +4,7 @@ import { fromAccountRaw } from "../../../account";
 import type { Account } from "../../../types";
 import { getAccountBridge } from "../../../bridge";
 import { makeBridgeCacheSystem } from "../../../bridge/cache";
-import { ethereum1 } from "../test-dataset";
+import { ethereum1 } from "../datasets/ethereum1";
 import { setEnv } from "../../../env";
 setEnv("COMPOUND_API", "https://status.ledger.com"); // hack to hit an endpoint that actually is going to 404
 

package/src/families/ethereum/{synchronisation.test.ts → synchronisation.integration.test.ts}

@@ -5,7 +5,7 @@ import { getAccountCurrency } from "../../account/helpers";
 import type { Account, SubAccount } from "../../types";
 import { getAccountBridge } from "../../bridge";
 import { makeBridgeCacheSystem } from "../../bridge/cache";
-import { ethereum1 } from "./test-dataset";
+import { ethereum1 } from "./datasets/ethereum1";
 
 describe("blacklistedTokenIds functionality", () => {
   const account = fromAccountRaw(ethereum1);

package/src/families/filecoin/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,10 +1,17 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
+import { getAccountBridge } from "../../bridge";
+import {
+  decodeAccountId,
+  encodeAccountId,
+  fromAccountRaw,
+} from "../../account";
 import { BigNumber } from "bignumber.js";
 import {
   AmountRequired,
   InvalidAddress,
   NotEnoughBalance,
 } from "@ledgerhq/errors";
-
 import type { DatasetTest } from "../../types";
 import type { Transaction } from "./types";
 import { fromTransactionRaw } from "../filecoin/transaction";
@@ -13,7 +20,6 @@ import { CurrenciesData } from "../../types";
 const SEED_IDENTIFIER = "f1p74d4mlmeyc4agflhjqsnvoyzyfdai7fmkyso2a";
 const ACCOUNT_1 = "f1p74d4mlmeyc4agflhjqsnvoyzyfdai7fmkyso2a";
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
 const filecoin: CurrenciesData<Transaction> = {
   FIXME_ignoreAccountFields: [],
   scanAccounts: [
@@ -150,4 +156,30 @@ const dataset: DatasetTest<Transaction> = {
     filecoin,
   },
 };
-export default dataset;
+
+testBridge(dataset);
+
+describe("estimateMaxSpendable", () => {
+  test("it should failed on invalid recipient", async () => {
+    const accounts = dataset.currencies["filecoin"].accounts || [];
+    const accountData = accounts[0];
+
+    const account = fromAccountRaw({
+      ...accountData.raw,
+      id: encodeAccountId({
+        ...decodeAccountId(accountData.raw.id),
+        type: dataset.implementations[0],
+      }),
+    });
+
+    const accountBridge = getAccountBridge(account);
+    const estimate = async () => {
+      await accountBridge.estimateMaxSpendable({
+        account,
+        transaction: { recipient: "notavalidrecipient" },
+      });
+    };
+
+    await expect(estimate).rejects.toThrowError(new InvalidAddress());
+  });
+});

package/src/families/hedera/__snapshots__/bridge.integration.test.ts.snap

@@ -0,0 +1,5 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`hedera currency bridge scanAccounts hedera seed 1 1`] = `Array []`;
+
+exports[`hedera currency bridge scanAccounts hedera seed 1 2`] = `Array []`;

package/src/families/hedera/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,3 +1,5 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
 import type { CurrenciesData, DatasetTest } from "../../types";
 import type { Transaction } from "./types";
 import {
@@ -88,7 +90,8 @@ const hedera: CurrenciesData<Transaction> = {
 const dataset: DatasetTest<Transaction> = {
   implementations: ["js"],
   currencies: {
-    // hedera, // LIVE-2376
+    hedera,
   },
 };
-export default dataset;
+
+testBridge(dataset);

package/src/families/polkadot/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,4 +1,9 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
+import { disconnect } from "./api";
 import { BigNumber } from "bignumber.js";
+import { canUnbond, MAX_UNLOCKINGS } from "./logic";
+import type { Account } from "../../types";
 import {
   NotEnoughBalance,
   RecipientRequired,
@@ -15,7 +20,7 @@ import {
   PolkadotAllFundsWarning,
   PolkadotDoMaxSendInstead,
 } from "./errors";
-import type { DatasetTest } from "../../types";
+import type { DatasetTest, CurrenciesData } from "../../types";
 import { fromTransactionRaw } from "./transaction";
 import type { Transaction } from "./types";
 const ACCOUNT_SAME_STASHCONTROLLER =
@@ -26,8 +31,7 @@ const ACCOUNT_EMPTY = "111111111111111111111111111111111HC1";
 const ACCOUNT_WITH_NO_OPERATION =
   "12EsPA79dvhtjp1bYvCiEWPsQmmdKGss44GzE3CT9tTo9g4Q";
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-const polkadot = {
+const polkadot: CurrenciesData<Transaction> = {
   FIXME_ignoreAccountFields: [
     "polkadotResources.unlockings", // Due to completion date that change everyday (estimated time)
     "polkadotResources.nominations", // TODO: try to only ignore status
@@ -685,7 +689,79 @@ const polkadot = {
 const dataset: DatasetTest<Transaction> = {
   implementations: ["js"],
   currencies: {
-    // polkadot, // LL-7806
+    polkadot,
   },
 };
-export default dataset;
+
+// Disconnect all api clients that could be open.
+afterAll(async () => {
+  await disconnect();
+});
+
+testBridge(dataset);
+
+describe("canUnbond", () => {
+  test("can unbond", () => {
+    const account: Partial<Account> = {
+      polkadotResources: {
+        controller: "",
+        stash: "",
+        nonce: 0,
+        numSlashingSpans: 0,
+        lockedBalance: new BigNumber(10000),
+        unlockedBalance: new BigNumber(0),
+        unlockingBalance: new BigNumber(0),
+        nominations: [],
+        unlockings: [
+          ...Array(MAX_UNLOCKINGS - 1).map(() => ({
+            amount: new BigNumber(Math.random()),
+            completionDate: new Date(),
+          })),
+        ],
+      },
+    };
+    expect(canUnbond(account as Account)).toBeTruthy();
+  });
+  test("can't unbond because unlockings is too much", () => {
+    const account: Partial<Account> = {
+      polkadotResources: {
+        controller: "",
+        stash: "",
+        nonce: 0,
+        numSlashingSpans: 0,
+        lockedBalance: new BigNumber(1000000),
+        unlockedBalance: new BigNumber(0),
+        unlockingBalance: new BigNumber(0),
+        nominations: [],
+        unlockings: [
+          ...Array(MAX_UNLOCKINGS).map(() => ({
+            amount: new BigNumber(Math.random()),
+            completionDate: new Date(),
+          })),
+        ],
+      },
+    };
+    expect(canUnbond(account as Account)).toBeFalsy();
+  });
+  test("can't unbond because not enough lockedBalance", () => {
+    const account: Partial<Account> = {
+      polkadotResources: {
+        controller: "",
+        stash: "",
+        nonce: 0,
+        numSlashingSpans: 0,
+        lockedBalance: new BigNumber(100),
+        unlockedBalance: new BigNumber(0),
+        unlockingBalance: new BigNumber(100),
+        nominations: [],
+        unlockings: [
+          ...Array(MAX_UNLOCKINGS).map(() => ({
+            amount: new BigNumber(Math.random()),
+            completionDate: new Date(),
+          })),
+        ],
+      },
+    };
+    expect(canUnbond(account as Account)).toBeFalsy();
+  });
+});

package/src/families/ripple/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,3 +1,6 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
+
 // import { getCryptoCurrencyById } from "@ledgerhq/cryptoassets";
 import { BigNumber } from "bignumber.js";
 import type { DatasetTest } from "../../types";
@@ -160,4 +163,5 @@ const dataset: DatasetTest<Transaction> = {
     },
   },
 };
-export default dataset;
+
+testBridge(dataset);

package/src/families/solana/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,8 +1,8 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
 import BigNumber from "bignumber.js";
 import { CurrenciesData, DatasetTest, encodeAccountId } from "../../types";
-
-import { Transaction, TransactionModel } from "./types";
-
+import { SolanaStake, Transaction, TransactionModel } from "./types";
 import scanAccounts1 from "./datasets/solana.scanAccounts.1";
 import {
   AmountRequired,
@@ -32,9 +32,17 @@ import createTransaction from "./js-createTransaction";
 import { compact } from "lodash/fp";
 import { assertUnreachable } from "./utils";
 import { getEnv } from "../../env";
+import { Account, TransactionStatus } from "../../types";
+import { ChainAPI } from "./api";
+import {
+  SolanaStakeAccountIsNotDelegatable,
+  SolanaStakeAccountValidatorIsUnchangeable,
+} from "./errors";
+import getTransactionStatus from "./js-getTransactionStatus";
+import { prepareTransaction } from "./js-prepareTransaction";
 
 // do not change real properties or the test will break
-export const testOnChainData = {
+const testOnChainData = {
   //  --- real props ---
   unfundedAddress: "7b6Q3ap8qRzfyvDw1Qce3fUV8C7WgFNzJQwYNTJm3KQo",
   // 0/0
@@ -951,4 +959,161 @@ function stakingTests(): TransactionTestSpec[] {
   ];
 }
 
-export default dataset;
+testBridge(dataset);
+
+const baseAccount = {
+  balance: new BigNumber(0),
+  spendableBalance: new BigNumber(0),
+} as Account;
+
+const baseTx = {
+  family: "solana",
+  recipient: "",
+  amount: new BigNumber(0),
+} as Transaction;
+
+const baseAPI = {
+  getFeeForMessage: (_msg: unknown) =>
+    Promise.resolve(testOnChainData.fees.lamportsPerSignature),
+} as ChainAPI;
+
+type StakeTestSpec = {
+  activationState: SolanaStake["activation"]["state"];
+  txModel: Transaction["model"];
+  expectedErrors: Record<string, Error>;
+};
+
+/**
+ * Some business logic can not be described in terms of transactions and expected status
+ * in the test datasets, like stake activation/deactivation, because stake activation is
+ * not determenistic and changes with time. Hence the tests here to mock data
+ * to be determenistic.
+ */
+
+describe("solana staking", () => {
+  test("stake.delegate :: status is error: stake account is not delegatable", async () => {
+    const stakeDelegateModel: Transaction["model"] & {
+      kind: "stake.delegate";
+    } = {
+      kind: "stake.delegate",
+      uiState: {
+        stakeAccAddr: testOnChainData.unfundedAddress,
+        voteAccAddr: testOnChainData.validatorAddress,
+      },
+    };
+
+    const stakeTests: StakeTestSpec[] = [
+      {
+        activationState: "activating",
+        txModel: stakeDelegateModel,
+        expectedErrors: {
+          fee: new NotEnoughBalance(),
+          stakeAccAddr: new SolanaStakeAccountIsNotDelegatable(),
+        },
+      },
+      {
+        activationState: "active",
+        txModel: stakeDelegateModel,
+        expectedErrors: {
+          fee: new NotEnoughBalance(),
+          stakeAccAddr: new SolanaStakeAccountIsNotDelegatable(),
+        },
+      },
+      {
+        activationState: "deactivating",
+        txModel: {
+          ...stakeDelegateModel,
+          uiState: {
+            ...stakeDelegateModel.uiState,
+            voteAccAddr: testOnChainData.unfundedAddress,
+          },
+        },
+        expectedErrors: {
+          fee: new NotEnoughBalance(),
+          stakeAccAddr: new SolanaStakeAccountValidatorIsUnchangeable(),
+        },
+      },
+    ];
+
+    for (const stakeTest of stakeTests) {
+      await runStakeTest(stakeTest);
+    }
+  });
+});
+
+async function runStakeTest(stakeTestSpec: StakeTestSpec) {
+  const api = {
+    ...baseAPI,
+    getMinimumBalanceForRentExemption: () =>
+      Promise.resolve(testOnChainData.fees.stakeAccountRentExempt),
+    getAccountInfo: () => {
+      return Promise.resolve({ data: mockedVoteAccount } as any);
+    },
+  } as ChainAPI;
+
+  const account: Account = {
+    ...baseAccount,
+    solanaResources: {
+      stakes: [
+        {
+          stakeAccAddr: testOnChainData.unfundedAddress,
+          delegation: {
+            stake: 1,
+            voteAccAddr: testOnChainData.validatorAddress,
+          },
+          activation: {
+            state: stakeTestSpec.activationState,
+          },
+        } as SolanaStake,
+      ],
+    },
+  };
+
+  const tx: Transaction = {
+    ...baseTx,
+    model: stakeTestSpec.txModel,
+  };
+
+  const preparedTx = await prepareTransaction(account, tx, api);
+  const status = await getTransactionStatus(account, preparedTx);
+
+  const expectedStatus: TransactionStatus = {
+    amount: new BigNumber(0),
+    estimatedFees: new BigNumber(testOnChainData.fees.lamportsPerSignature),
+    totalSpent: new BigNumber(testOnChainData.fees.lamportsPerSignature),
+    errors: stakeTestSpec.expectedErrors,
+    warnings: {},
+  };
+
+  expect(status).toEqual(expectedStatus);
+}
+
+const mockedVoteAccount = {
+  parsed: {
+    info: {
+      authorizedVoters: [
+        {
+          authorizedVoter: "EvnRmnMrd69kFdbLMxWkTn1icZ7DCceRhvmb2SJXqDo4",
+          epoch: 283,
+        },
+      ],
+      authorizedWithdrawer: "EvnRmnMrd69kFdbLMxWkTn1icZ7DCceRhvmb2SJXqDo4",
+      commission: 7,
+      epochCredits: [
+        {
+          credits: "98854605",
+          epoch: 283,
+          previousCredits: "98728105",
+        },
+      ],
+      lastTimestamp: { slot: 122422797, timestamp: 1645796249 },
+      nodePubkey: "EvnRmnMrd69kFdbLMxWkTn1icZ7DCceRhvmb2SJXqDo4",
+      priorVoters: [],
+      rootSlot: 122422766,
+      votes: [{ confirmationCount: 1, slot: 122422797 }],
+    },
+    type: "vote",
+  },
+  program: "vote",
+  space: 3731,
+};

package/src/families/stellar/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,3 +1,5 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
 import { BigNumber } from "bignumber.js";
 import type { DatasetTest } from "../../types";
 import {
@@ -13,10 +15,10 @@ import {
   addMultisignStellarMockAddresses,
 } from "./bridge/mock";
 
-export const notCreatedStellarMockAddress =
+const notCreatedStellarMockAddress =
   "GAW46JE3SHIAYLNNNQCAZFQ437WB5ZH7LDRDWR5LVDWHCTHCKYB6RCCH";
 
-export const multisignStellarMockAddress =
+const multisignStellarMockAddress =
   "GCDDN6T2LJN3T7SPWJQV6BCCL5KNY5GBN7X4CMSZLDEXDHXAH32TOAHS";
 
 addNotCreatedStellarMockAddresses(notCreatedStellarMockAddress);
@@ -347,4 +349,4 @@ const dataset: DatasetTest<Transaction> = {
   },
 };
 
-export default dataset;
+testBridge(dataset);

package/src/families/stellar/js-estimateMaxSpendable.ts

@@ -2,11 +2,13 @@ import { getMainAccount } from "../../account";
 import createTransaction from "./js-createTransaction";
 import prepareTransaction from "./js-prepareTransaction";
 import getTransactionStatus from "./js-getTransactionStatus";
-import { notCreatedStellarMockAddress } from "./test-dataset";
 import type { Account, AccountLike } from "../../types";
 import type { Transaction } from "./types";
 import BigNumber from "bignumber.js";
 
+const notCreatedStellarMockAddress =
+  "GAW46JE3SHIAYLNNNQCAZFQ437WB5ZH7LDRDWR5LVDWHCTHCKYB6RCCH";
+
 const estimateMaxSpendable = async ({
   account,
   parentAccount,

package/src/families/tezos/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,3 +1,9 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
+import { fromAccountRaw } from "../../account";
+import { loadAccountDelegation, listBakers } from "./bakers";
+import whitelist from "./bakers.whitelist-default";
+
 import { AmountRequired, NotEnoughBalance } from "@ledgerhq/errors";
 import type { DatasetTest } from "../../types";
 import type { Transaction } from "./types";
@@ -100,7 +106,6 @@ const dataset: DatasetTest<Transaction> = {
     },
   },
 };
-export default dataset;
 
 function makeAccount(name, pubkey, address, derivationMode) {
   return {
@@ -123,3 +128,19 @@ function makeAccount(name, pubkey, address, derivationMode) {
     subAccounts: [],
   };
 }
+
+testBridge(dataset);
+
+describe("tezos bakers", () => {
+  // FIXME Flaky test that will fail every time a Tezos baker is discontinued
+  test("getting the bakers", async () => {
+    const list = await listBakers(whitelist);
+    expect(list.map((o) => o.address)).toEqual(whitelist);
+  });
+  // TODO we'll need two accounts to test diff cases
+  test("load account baker info", async () => {
+    const account = fromAccountRaw(accountTZrevealedDelegating);
+    const delegation = await loadAccountDelegation(account);
+    expect(delegation).toBe(null);
+  });
+});

package/src/families/tezos/synchronisation.ts

@@ -208,7 +208,7 @@ const txToOp =
         type = "CREATE";
         maybeValue = new BigNumber(tx.contractBalance || 0);
         senders = [address];
-        recipients = [tx.originatedContract.address];
+        recipients = [tx.originatedContract?.address || ""];
         break;
       case "activation":
         type = "IN";

package/src/families/tron/{test-dataset.ts → bridge.integration.test.ts}

@@ -1,6 +1,8 @@
+import "../../__tests__/test-helpers/setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
 import invariant from "invariant";
 import { BigNumber } from "bignumber.js";
-import type { DatasetTest } from "../../types";
+import type { CurrenciesData, DatasetTest } from "../../types";
 import { fromTransactionRaw } from "./transaction";
 import type { Transaction } from "./types";
 import { activationFees } from "./constants";
@@ -38,8 +40,7 @@ const getTokenAccountId = (account, id) =>
     )
   ).id;
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-const tron = {
+const tron: CurrenciesData<Transaction> = {
   FIXME_ignoreAccountFields: [
     "tronResources.cacheTransactionInfoById", // this is a cache, don't save it
     "tronResources.unwithdrawnReward", // it changes every vote cycles
@@ -771,8 +772,8 @@ const tron = {
 const dataset: DatasetTest<Transaction> = {
   implementations: ["tronjs"],
   currencies: {
-    // tron, // LL-7611
+    tron,
   },
 };
 
-export default dataset;
+testBridge(dataset);

package/src/load/speculos.ts

@@ -316,8 +316,11 @@ export function appCandidatesMatches(
           hackBadSemver(appCandidate.firmware),
           searchFirmware
         ))) &&
-    (!search.appVersion ||
-      semver.satisfies(appCandidate.appVersion, search.appVersion))
+    ((!search.appVersion &&
+      !appCandidate.appVersion.includes("prerelease") &&
+      !appCandidate.appVersion.includes("rc")) ||
+      (search.appVersion &&
+        semver.satisfies(appCandidate.appVersion, search.appVersion)))
   );
 }
 export const findAppCandidate = (

package/src/portfolio/v2/index.ts

@@ -24,8 +24,13 @@ import type {
   ValueChange,
 } from "./types";
 import { getPortfolioRangeConfig, getDates } from "./range";
-import { defaultAssetsDistribution } from "../";
-import type { AssetsDistributionOpts } from "../";
+
+export const defaultAssetsDistribution = {
+  minShowFirst: 1,
+  maxShowFirst: 6,
+  showFirstThreshold: 0.95,
+};
+export type AssetsDistributionOpts = typeof defaultAssetsDistribution;
 
 export function getPortfolioCount(
   accounts: AccountLike[],