@ledgerhq/live-common 21.8.2 → 21.10.0-btcjs.2

package/src/families/bitcoin/js-signOperation.ts

@@ -89,6 +89,10 @@ const signOperation = ({
           additionals.push("bech32");
         }
 
+        if (account.derivationMode === "taproot") {
+          additionals.push("bech32m");
+        }
+
         if (perCoin?.getAdditionals) {
           additionals = additionals.concat(
             perCoin.getAdditionals({

package/src/families/bitcoin/js-synchronisation.ts

@@ -9,6 +9,7 @@ import { DerivationModes as WalletDerivationModes } from "./wallet-btc";
 import { BigNumber } from "bignumber.js";
 import Btc from "@ledgerhq/hw-app-btc";
 import { log } from "@ledgerhq/logs";
+import { getCryptoCurrencyById } from "@ledgerhq/cryptoassets";
 import type {
   Account,
   Operation,
@@ -20,29 +21,30 @@ import { makeSync, makeScanAccounts, mergeOps } from "../../bridge/jsHelpers";
 import { findCurrencyExplorer } from "../../api/Ledger";
 import { encodeAccountId } from "../../account";
 import { encodeOperationId } from "../../operation";
+import {
+  isSegwitDerivationMode,
+  isNativeSegwitDerivationMode,
+  isTaprootDerivationMode,
+} from "../../derivation";
 import { BitcoinOutput } from "./types";
 import { perCoinLogic } from "./logic";
 import wallet from "./wallet-btc";
-import { getCryptoCurrencyById } from "@ledgerhq/cryptoassets";
+import { getAddressWithBtcInstance } from "./hw-getAddress";
 
 // Map LL's DerivationMode to wallet-btc's
 const toWalletDerivationMode = (
   mode: DerivationMode
 ): WalletDerivationModes => {
-  switch (mode) {
-    case "segwit":
-    case "segwit_on_legacy":
-    case "segwit_unsplit":
-    case "bch_on_bitcoin_segwit":
-    case "vertcoin_128_segwit":
-      return WalletDerivationModes.SEGWIT;
-
-    case "native_segwit":
-      return WalletDerivationModes.NATIVE_SEGWIT;
-
-    default:
-      return WalletDerivationModes.LEGACY;
+  if (isTaprootDerivationMode(mode)) {
+    return WalletDerivationModes.TAPROOT;
+  }
+  if (isNativeSegwitDerivationMode(mode)) {
+    return WalletDerivationModes.NATIVE_SEGWIT;
   }
+  if (isSegwitDerivationMode(mode)) {
+    return WalletDerivationModes.SEGWIT;
+  }
+  return WalletDerivationModes.LEGACY;
 };
 
 // Map LL's currency ID to wallet-btc's Account.params.network
@@ -241,6 +243,7 @@ const getAccountShape: GetAccountShape = async (info) => {
   // 44'/0'/0'/0/0 --> 44'/0'
   // FIXME Only the CLI provides a full derivationPath: why?
   const rootPath = derivationPath.split("/", 2).join("/");
+  const accountPath = `${rootPath}/${index}'`;
 
   const paramXpub = initialAccount?.xpub;
 
@@ -250,14 +253,16 @@ const getAccountShape: GetAccountShape = async (info) => {
 
     if (!transport) {
       // hwapp not provided
-      throw new Error("generateXpub needs a hwapp");
+      throw new Error("hwapp required to generate the xpub");
     }
-    generatedXpub = await wallet.generateXpub(
-      new Btc(transport),
-      <Currency>currency.id,
-      rootPath,
-      index
-    );
+    const btc = new Btc(transport);
+    const { bitcoinLikeInfo } = currency;
+    const { XPUBVersion: xpubVersion } = bitcoinLikeInfo as {
+      // FIXME It's supposed to be optional
+      //XPUBVersion?: number;
+      XPUBVersion: number;
+    };
+    generatedXpub = await btc.getWalletXpub({ path: accountPath, xpubVersion });
   }
   const xpub = paramXpub || generatedXpub;
 
@@ -380,5 +385,10 @@ const postSync = (initial: Account, synced: Account) => {
   return synced;
 };
 
-export const scanAccounts = makeScanAccounts(getAccountShape);
+const getAddressFn = (transport) => {
+  const btc = new Btc(transport);
+  return (opts) => getAddressWithBtcInstance(transport, btc, opts);
+};
+
+export const scanAccounts = makeScanAccounts(getAccountShape, getAddressFn);
 export const sync = makeSync(getAccountShape, postSync);

package/src/families/bitcoin/logic.ts

@@ -59,11 +59,13 @@ export const isValidRecipient = async (params: {
     valid = isValidAddress(params.recipient, <Currency>params.currency.id);
   } catch (e: any) {
     // isValidAddress() will throw Error if c is not an actual Currency
-    return Promise.reject(new InvalidAddress(e.message));
+    valid = false;
   }
   if (!valid) {
     return Promise.reject(
-      new InvalidAddress("Invalid address for currency " + params.currency.name)
+      new InvalidAddress("", {
+        currencyName: params.currency.name,
+      })
     );
   }
   return Promise.resolve(null);

package/src/families/bitcoin/specs.ts

@@ -270,13 +270,14 @@ const bitcoin: AppSpec<Transaction> = {
   mutations: bitcoinLikeMutations(),
 };
 const bitcoinTestnet: AppSpec<Transaction> = {
-  multipleRuns: 3,
+  multipleRuns: 2,
   name: "Bitcoin Testnet",
   currency: getCryptoCurrencyById("bitcoin_testnet"),
   dependency: "Bitcoin",
   appQuery: {
     model: DeviceModelId.nanoS,
     appName: "Bitcoin Test",
+    // appVersion: "2.0.0-alpha",
   },
   test: genericTest,
   mutations: bitcoinLikeMutations({

package/src/families/bitcoin/types.ts

@@ -56,6 +56,10 @@ export type BitcoinResourcesRaw = {
   walletAccount?: WalletAccountRaw;
 };
 
+export const initialBitcoinResourcesValue = {
+  utxos: [],
+};
+
 export const BitcoinLikeFeePolicy = Object.freeze({
   PER_BYTE: "PER_BYTE",
   PER_KBYTE: "PER_KBYTE",

package/src/families/bitcoin/wallet-btc/crypto/base.ts

@@ -7,7 +7,7 @@ import * as bip32 from "bip32";
 import { toOutputScript } from "bitcoinjs-lib/src/address";
 import bs58check from "bs58check";
 import { DerivationModes } from "../types";
-import { DerivationMode, ICrypto } from "./types";
+import { ICrypto } from "./types";
 
 export function fallbackValidateAddress(address: string): boolean {
   try {
@@ -28,12 +28,6 @@ class Base implements ICrypto {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   network: any;
 
-  derivationMode: DerivationMode = {
-    LEGACY: DerivationModes.LEGACY,
-    SEGWIT: DerivationModes.SEGWIT,
-    NATIVE_SEGWIT: DerivationModes.NATIVE_SEGWIT,
-  };
-
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   constructor({ network }: { network: any }) {
     this.network = network;
@@ -85,11 +79,11 @@ class Base implements ICrypto {
     index: number
   ): string {
     switch (derivationMode) {
-      case this.derivationMode.LEGACY:
+      case DerivationModes.LEGACY:
         return this.getLegacyAddress(xpub, account, index);
-      case this.derivationMode.SEGWIT:
+      case DerivationModes.SEGWIT:
         return this.getSegWitAddress(xpub, account, index);
-      case this.derivationMode.NATIVE_SEGWIT:
+      case DerivationModes.NATIVE_SEGWIT:
         return this.getNativeSegWitAddress(xpub, account, index);
       default:
         throw new Error(`Invalid derivation Mode: ${derivationMode}`);
@@ -99,13 +93,13 @@ class Base implements ICrypto {
   // infer address type from its syntax
   getDerivationMode(address: string): DerivationModes {
     if (address.match("^(bc1|tb1).*")) {
-      return this.derivationMode.NATIVE_SEGWIT;
+      return DerivationModes.NATIVE_SEGWIT;
     }
     if (address.match("^(3|2|M).*")) {
-      return this.derivationMode.SEGWIT;
+      return DerivationModes.SEGWIT;
     }
     if (address.match("^(1|n|m|L).*")) {
-      return this.derivationMode.LEGACY;
+      return DerivationModes.LEGACY;
     }
     throw new Error(
       "INVALID ADDRESS: ".concat(address).concat(" is not a valid address")

package/src/families/bitcoin/wallet-btc/crypto/bitcoin.ts

@@ -49,11 +49,7 @@ function fromBech32(address: string): {
   };
 }
 
-function toBech32(
-  data: Buffer,
-  version: number,
-  prefix: string,
-): string {
+function toBech32(data: Buffer, version: number, prefix: string): string {
   const words = bech32.toWords(data);
   words.unshift(version);
 

package/src/families/bitcoin/wallet-btc/crypto/bitcoincash.ts

@@ -6,17 +6,13 @@ import bchaddr from "bchaddrjs";
 // @ts-ignore
 import { toOutputScript } from "bitcoinjs-lib/src/address";
 import { DerivationModes } from "../types";
-import { ICrypto, DerivationMode } from "./types";
+import { ICrypto } from "./types";
 
 // a mock explorer class that just use js objects
 class BitcoinCash implements ICrypto {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   network: any;
 
-  derivationMode: DerivationMode = {
-    LEGACY: DerivationModes.LEGACY,
-  };
-
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   constructor({ network }: { network: any }) {
     this.network = network;
@@ -59,7 +55,7 @@ class BitcoinCash implements ICrypto {
   // could match a native Bitcoin address type for instance)
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   getDerivationMode(address: string) {
-    return this.derivationMode.LEGACY;
+    return DerivationModes.LEGACY;
   }
 
   toOutputScript(address: string) {

package/src/families/bitcoin/wallet-btc/crypto/litecoin.ts

@@ -5,7 +5,7 @@ import * as bip32 from "bip32";
 import { toOutputScript } from "bitcoinjs-lib/src/address";
 import { bech32 } from "bech32";
 import { DerivationModes } from "../types";
-import { ICrypto, DerivationMode } from "./types";
+import { ICrypto } from "./types";
 import Base from "./base";
 
 // Todo copy paste from bitcoin.ts. we can merge them later
@@ -13,12 +13,6 @@ class Litecoin extends Base implements ICrypto {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   network: any;
 
-  derivationMode: DerivationMode = {
-    LEGACY: DerivationModes.LEGACY,
-    SEGWIT: DerivationModes.SEGWIT,
-    NATIVE_SEGWIT: DerivationModes.NATIVE_SEGWIT,
-  };
-
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   constructor({ network }: { network: any }) {
     super({ network });
@@ -66,11 +60,11 @@ class Litecoin extends Base implements ICrypto {
     index: number
   ): string {
     switch (derivationMode) {
-      case this.derivationMode.LEGACY:
+      case DerivationModes.LEGACY:
         return this.getLegacyAddress(xpub, account, index);
-      case this.derivationMode.SEGWIT:
+      case DerivationModes.SEGWIT:
         return this.getSegWitAddress(xpub, account, index);
-      case this.derivationMode.NATIVE_SEGWIT:
+      case DerivationModes.NATIVE_SEGWIT:
         return this.getNativeSegWitAddress(xpub, account, index);
       default:
         throw new Error("Should not be reachable");
@@ -80,13 +74,13 @@ class Litecoin extends Base implements ICrypto {
   // infer address type from its syntax
   getDerivationMode(address: string) {
     if (address.match("^(ltc1).*")) {
-      return this.derivationMode.NATIVE_SEGWIT;
+      return DerivationModes.NATIVE_SEGWIT;
     }
     if (address.match("^(3|2|M).*")) {
-      return this.derivationMode.SEGWIT;
+      return DerivationModes.SEGWIT;
     }
     if (address.match("^(1|n|m|L).*")) {
-      return this.derivationMode.LEGACY;
+      return DerivationModes.LEGACY;
     }
     throw new Error(
       "INVALID ADDRESS: ".concat(address).concat(" is not a valid address")

package/src/families/bitcoin/wallet-btc/crypto/types.ts

@@ -1,14 +1,6 @@
-import { DerivationModes } from "../types";
-
-// all things derivation
-export interface DerivationMode {
-  [index: string]: DerivationModes;
-}
-
 export interface ICrypto {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   network: any;
-  derivationMode: DerivationMode;
   getAddress(
     derivationMode: string,
     xpub: string,

package/src/families/bitcoin/wallet-btc/crypto/zec.ts

@@ -6,12 +6,13 @@ import { toOutputScript } from "bitcoinjs-lib/src/address";
 import zec from "zcash-bitcore-lib";
 import bs58check from "bs58check";
 import { DerivationModes } from "../types";
-import { ICrypto, DerivationMode } from "./types";
+import { ICrypto } from "./types";
 import coininfo from "coininfo";
 
 class ZCash implements ICrypto {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   network: any;
+
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   constructor({ network }: { network: any }) {
     this.network = network;
@@ -20,10 +21,6 @@ class ZCash implements ICrypto {
     this.network.usesTimestampedTransaction = false;
   }
 
-  derivationMode: DerivationMode = {
-    LEGACY: DerivationModes.LEGACY,
-  };
-
   // eslint-disable-next-line
   baddrToTaddr(baddrStr: string) {
     const baddr = bs58check.decode(baddrStr).slice(1);
@@ -59,7 +56,7 @@ class ZCash implements ICrypto {
 
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   getDerivationMode(address: string) {
-    return this.derivationMode.LEGACY;
+    return DerivationModes.LEGACY;
   }
 
   toOutputScript(address: string) {

package/src/families/bitcoin/wallet-btc/crypto/zen.ts

@@ -6,7 +6,7 @@ import { toOutputScript } from "bitcoinjs-lib/src/address";
 import zec from "zcash-bitcore-lib";
 import bs58check from "bs58check";
 import { DerivationModes } from "../types";
-import { ICrypto, DerivationMode } from "./types";
+import { ICrypto } from "./types";
 import coininfo from "coininfo";
 
 class Zen implements ICrypto {
@@ -38,10 +38,6 @@ class Zen implements ICrypto {
     this.network.usesTimestampedTransaction = false;
   }
 
-  derivationMode: DerivationMode = {
-    LEGACY: DerivationModes.LEGACY,
-  };
-
   // eslint-disable-next-line
   baddrToTaddr(baddrStr: string) {
     const baddr = bs58check.decode(baddrStr).slice(1);
@@ -80,7 +76,7 @@ class Zen implements ICrypto {
 
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   getDerivationMode(address: string) {
-    return this.derivationMode.LEGACY;
+    return DerivationModes.LEGACY;
   }
 
   toOutputScript(address: string) {

package/src/families/bitcoin/wallet-btc/explorer/index.ts

@@ -200,7 +200,7 @@ class BitcoinLikeExplorer extends EventEmitter implements IExplorer {
 
     // TODO add a test for failure (at the sync level)
     const client = await this.client.acquire();
-    const res: { txs: TX[] } = (
+    const res = (
       await client.client.get(url, {
         params,
         // some altcoin may have outputs with values > MAX_SAFE_INTEGER
@@ -217,7 +217,7 @@ class BitcoinLikeExplorer extends EventEmitter implements IExplorer {
             return value;
           }),
       })
-    ).data;
+    ).data as { txs: TX[] };
     await this.client.release(client);
 
     this.emit("fetched-address-transaction", { url, params, res });

package/src/families/bitcoin/wallet-btc/pickingstrategies/CoinSelect.ts

@@ -6,6 +6,7 @@ import Xpub from "../xpub";
 import { PickingStrategy } from "./types";
 import * as utils from "../utils";
 import { DeepFirst } from "./DeepFirst";
+import { log } from "@ledgerhq/logs";
 
 export class CoinSelect extends PickingStrategy {
   // eslint-disable-next-line class-methods-use-this
@@ -18,6 +19,7 @@ export class CoinSelect extends PickingStrategy {
     // get the utxos to use as input
     // from all addresses of the account
     const addresses = await xpub.getXpubAddresses();
+    log("picking strategy", "Coinselect");
 
     const unspentUtxos = flatten(
       await Promise.all(
@@ -30,7 +32,7 @@ export class CoinSelect extends PickingStrategy {
         ).length
     );
     const TOTAL_TRIES = 100000;
-
+    log("picking strategy", "utxos", unspentUtxos);
     // Compute cost of change
     const fixedSize = utils.estimateTxSize(
       0,

package/src/families/bitcoin/wallet-btc/pickingstrategies/DeepFirst.ts

@@ -5,6 +5,7 @@ import { Output } from "../storage/types";
 import Xpub from "../xpub";
 import { PickingStrategy } from "./types";
 import * as utils from "../utils";
+import { log } from "@ledgerhq/logs";
 
 export class DeepFirst extends PickingStrategy {
   // eslint-disable-next-line class-methods-use-this
@@ -17,6 +18,7 @@ export class DeepFirst extends PickingStrategy {
     // get the utxos to use as input
     // from all addresses of the account
     const addresses = await xpub.getXpubAddresses();
+    log("picking strategy", "Deepfirst");
 
     let unspentUtxos = flatten(
       await Promise.all(

package/src/families/bitcoin/wallet-btc/pickingstrategies/Merge.ts

@@ -5,6 +5,7 @@ import { Output } from "../storage/types";
 import Xpub from "../xpub";
 import { PickingStrategy } from "./types";
 import * as utils from "../utils";
+import { log } from "@ledgerhq/logs";
 
 export class Merge extends PickingStrategy {
   // eslint-disable-next-line class-methods-use-this
@@ -17,6 +18,7 @@ export class Merge extends PickingStrategy {
     // get the utxos to use as input
     // from all addresses of the account
     const addresses = await xpub.getXpubAddresses();
+    log("picking strategy", "Merge");
 
     let unspentUtxos = flatten(
       await Promise.all(

package/src/families/bitcoin/wallet-btc/storage/types.ts

@@ -16,7 +16,7 @@ export interface Input {
   address: string;
   output_hash: string;
   output_index: number;
-  sequence: number | null;
+  sequence: number;
 }
 
 export interface Output {

package/src/families/bitcoin/wallet-btc/utils.ts

@@ -106,7 +106,12 @@ export function estimateTxSize(
   fixedSize += byteSize(inputCount); // Number of inputs
   fixedSize += byteSize(outputCount); // Number of outputs
   fixedSize += 4; // Timelock
-
+  // refer to https://medium.com/coinmonks/on-bitcoin-transaction-sizes-part-2-9445373d17f4
+  // and https://bitcoin.stackexchange.com/questions/96017/what-are-the-sizes-of-single-sig-and-2-of-3-multisig-taproot-inputs
+  if (derivationMode === DerivationModes.TAPROOT) {
+    txSize = fixedSize + 57.5 * inputCount + 43 * outputCount;
+    return Math.ceil(txSize);
+  }
   const isSegwit =
     derivationMode === DerivationModes.NATIVE_SEGWIT ||
     derivationMode === DerivationModes.SEGWIT;

package/src/families/bitcoin/wallet-btc/wallet.ts

@@ -5,7 +5,6 @@ import BigNumber from "bignumber.js";
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
 import { BufferWriter } from "bitcoinjs-lib/src/bufferutils";
-import * as bitcoin from "bitcoinjs-lib";
 
 import Btc from "@ledgerhq/hw-app-btc";
 import { log } from "@ledgerhq/logs";
@@ -52,54 +51,8 @@ class BitcoinLikeWallet {
     return this.explorerInstances[id];
   }
 
-  async generateXpub(
-    btc: Btc,
-    currency: Currency,
-    path: string,
-    index: number
-  ): Promise<string> {
-    const parentDerivation = await btc.getWalletPublicKey(`${path}`);
-    const accountDerivation = await btc.getWalletPublicKey(`${path}/${index}'`);
-
-    // parent
-    const publicKeyParentCompressed = utils.compressPublicKey(
-      parentDerivation.publicKey
-    );
-    const publicKeyParentCompressedHex = utils.parseHexString(
-      publicKeyParentCompressed
-    );
-    let result = bitcoin.crypto.sha256(
-      Buffer.from(publicKeyParentCompressedHex)
-    );
-    result = bitcoin.crypto.ripemd160(result);
-    // eslint-disable-next-line no-bitwise
-    const fingerprint =
-      ((result[0] << 24) | (result[1] << 16) | (result[2] << 8) | result[3]) >>>
-      0;
-
-    // account
-    const publicKeyAccountCompressed = utils.compressPublicKey(
-      accountDerivation.publicKey
-    );
-    // eslint-disable-next-line no-bitwise
-    const childnum = (0x80000000 | index) >>> 0;
-
-    const { network } = cryptoFactory(currency);
-    const xpubRaw = utils.createXPUB(
-      3,
-      fingerprint,
-      childnum,
-      accountDerivation.chainCode,
-      publicKeyAccountCompressed,
-      network.bip32.public
-    );
-
-    return utils.encodeBase58Check(xpubRaw);
-  }
-
   async generateAccount(params: {
-    xpub?: string;
-    btc?: Btc;
+    xpub: string;
     path: string;
     index: number;
     currency: Currency;
@@ -113,28 +66,6 @@ class BitcoinLikeWallet {
   }): Promise<Account> {
     const crypto = cryptoFactory(params.currency);
 
-    let { xpub } = params;
-
-    if (!xpub) {
-      // Xpub not provided, generate it using the hwapp
-
-      if (!params.btc) {
-        // hwapp not provided
-        throw new Error("generateAccount need either a hwapp or xpub");
-      }
-
-      xpub = await this.generateXpub(
-        params.btc,
-        params.currency,
-        params.path,
-        params.index
-      );
-    }
-
-    if (!xpub) {
-      throw new Error("Error while generating the xpub");
-    }
-
     const storage = this.accountStorages[params.storage](
       ...params.storageParams
     );
@@ -145,7 +76,7 @@ class BitcoinLikeWallet {
         storage,
         explorer,
         crypto,
-        xpub,
+        xpub: params.xpub,
         derivationMode: params.derivationMode,
       }),
     };
@@ -251,7 +182,7 @@ class BitcoinLikeWallet {
     amount: BigNumber;
     feePerByte: number;
     utxoPickingStrategy: PickingStrategy;
-    sequence?: number;
+    sequence: number;
   }): Promise<TransactionInfo> {
     const changeAddress = await params.fromAccount.xpub.getNewAddress(1, 1);
     const txInfo = await params.fromAccount.xpub.buildTx({
@@ -287,11 +218,7 @@ class BitcoinLikeWallet {
       btc,
       fromAccount,
       txInfo,
-      lockTime,
-      sigHashType,
-      segwit,
       additionals,
-      expiryHeight,
       onDeviceSignatureRequested,
       onDeviceSignatureGranted,
       onDeviceStreaming,
@@ -327,18 +254,23 @@ class BitcoinLikeWallet {
       null,
     ]);
 
+    const lastOutputIndex = txInfo.outputs.length - 1;
+
     log("hw", `createPaymentTransactionNew`, {
+      inputs,
       associatedKeysets,
       outputScriptHex,
-      lockTime,
-      sigHashType,
-      segwit,
+      ...(params.lockTime && { lockTime: params.lockTime }),
+      ...(params.sigHashType && { sigHashType: params.sigHashType }),
+      ...(params.segwit && { segwit: params.segwit }),
+      // initialTimestamp,
+      ...(params.expiryHeight && { expiryHeight: params.expiryHeight }),
+      ...(txInfo.outputs[lastOutputIndex]?.isChange && {
+        changePath: `${fromAccount.params.path}/${fromAccount.params.index}'/${txInfo.changeAddress.account}/${txInfo.changeAddress.index}`,
+      }),
       additionals: additionals || [],
-      expiryHeight: expiryHeight && expiryHeight.toString("hex"),
     });
 
-    const lastOutputIndex = txInfo.outputs.length - 1;
-
     const tx = await btc.createPaymentTransactionNew({
       inputs,
       associatedKeysets,

package/src/families/bitcoin/wallet-btc/xpub.ts

@@ -252,7 +252,7 @@ class Xpub extends EventEmitter {
     feePerByte: number;
     changeAddress: Address;
     utxoPickingStrategy: PickingStrategy;
-    sequence?: number;
+    sequence: number;
   }): Promise<TransactionInfo> {
     await this.whenSynced("all");
 
@@ -315,10 +315,7 @@ class Xpub extends EventEmitter {
         address: utxo.address,
         output_hash: utxo.output_hash,
         output_index: utxo.output_index,
-        sequence:
-          params.sequence && Number.isInteger(params.sequence)
-            ? params.sequence
-            : null,
+        sequence: params.sequence,
       };
     });
     const associatedDerivations: [number, number][] = unspentUtxoSelected.map(

package/src/families/elrond/js-synchronisation.ts

@@ -15,10 +15,8 @@ const getAccountShape: GetAccountShape = async (info) => {
   });
   const oldOperations = initialAccount?.operations || [];
   // Needed for incremental synchronisation
-  const startAt =
-    oldOperations.length && oldOperations[0].blockHeight
-      ? (new Date(oldOperations[0].date).getTime() / 1000 || 0) + 1
-      : 0;
+  const startAt = 0;
+
   // get the current account balance state depending your api implementation
   const { blockHeight, balance, nonce } = await getAccount(address);
   // Merge new operations with the previously synced ones