@ledgerhq/live-common 21.36.3 → 22.0.2

package/src/families/cosmos/api/Cosmos.ts

@@ -151,7 +151,7 @@ const getDelegations = async (address: string): Promise<any> => {
       if (r.validator_address === d.validatorAddress) {
         for (const reward of r.reward) {
           d.pendingRewards = d.pendingRewards.plus(
-            new BigNumber(reward.amount).integerValue(BigNumber.ROUND_CEIL)
+            new BigNumber(reward.amount).integerValue()
           );
         }
       }

package/src/families/cosmos/bridge.test.ts

@@ -0,0 +1,6 @@
+import { setup } from "../../__tests__/test-helpers/libcore-setup";
+import { testBridge } from "../../__tests__/test-helpers/bridge";
+import dataset from "./test-dataset";
+
+setup("cosmos");
+testBridge("cosmos", dataset);

package/src/families/cosmos/js-signOperation.ts

@@ -69,6 +69,14 @@ const signOperation = ({
         // Cosmos API expects a different sorting, resulting in a separate signature.
         // https://github.com/LedgerHQ/app-cosmos/blob/6c194daa28936e273f9548eabca9e72ba04bb632/app/src/tx_parser.c#L52
 
+        // Cosmos App sign data in Amino way only, not Protobuf.
+        // This is a legacy outdated standard and a long-term blocking point.
+
+        // @ledgerhq/hw-app-cosmos don't allow to push message to device message converted
+        // by the AminoConverter from @cosmjs/stargate. There's two things who don't work:
+        // 1st, the way who message is sorted.
+        // 2nd, cast of numeric value (integer/numeric versus string).
+
         const signed = await ledgerSigner.signAmino(account.freshAddress, {
           chain_id: chainId,
           account_number: accountNumber.toString(),

package/src/families/cosmos/js-synchronisation.ts

@@ -89,7 +89,8 @@ const txToOps = (info: any, id: string, txs: any): Operation[] => {
               op.value = new BigNumber(fees);
               op.extra.validators.push({
                 address: attributes.validator,
-                amount: attributes.amount.replace(currency.units[1].code, ""),
+                amount:
+                  attributes.amount.replace(currency.units[1].code, "") || 0,
               });
             }
             break;
@@ -205,6 +206,7 @@ export const getAccountShape: GetAccountShape = async (info) => {
 
   for (const unbonding of unbondings) {
     unbondingBalance = unbondingBalance.plus(unbonding.amount);
+    balance = balance.plus(unbonding.amount);
   }
 
   let spendableBalance = balance.minus(unbondingBalance.plus(delegatedBalance));

package/src/families/cosmos/logic.ts

@@ -13,11 +13,8 @@ import type {
   CosmosRedelegation,
   CosmosMappedRedelegation,
 } from "./types";
-import type { CacheRes } from "../../cache";
 import type { Unit, Account } from "../../types";
-import type { Transaction } from "./types";
-import { getFeesForTransaction } from "../../libcore/getFeesForTransaction";
-import { makeLRUCache } from "../../cache";
+import { calculateFees } from "./js-prepareTransaction";
 
 export const COSMOS_MAX_REDELEGATIONS = 7;
 export const COSMOS_MAX_UNBONDINGS = 7;
@@ -163,37 +160,7 @@ export const getMaxEstimatedBalance = (
 
   return amount;
 };
-export const calculateFees: CacheRes<
-  Array<{
-    a: Account;
-    t: Transaction;
-  }>,
-  {
-    estimatedFees: BigNumber;
-    estimatedGas: BigNumber | null | undefined;
-  }
-> = makeLRUCache(
-  async ({
-    a,
-    t,
-  }): Promise<{
-    estimatedFees: BigNumber;
-    estimatedGas: BigNumber | null | undefined;
-  }> => {
-    return getFeesForTransaction({
-      account: a,
-      transaction: t,
-    });
-  },
-  ({ a, t }) =>
-    `${a.id}_${a.currency.id}_${t.amount.toString()}_${t.recipient}_${String(
-      t.useAllAmount
-    )}_${t.mode}_${
-      t.validators ? t.validators.map((v) => v.address).join("-") : ""
-    }_${t.memo ? t.memo.toString() : ""}_${
-      t.cosmosSourceValidator ? t.cosmosSourceValidator : ""
-    }`
-);
+
 export function canUndelegate(account: Account): boolean {
   const { cosmosResources } = account;
   invariant(cosmosResources, "cosmosResources should exist");
@@ -230,8 +197,8 @@ export async function canClaimRewards(
   const { cosmosResources } = account;
   invariant(cosmosResources, "cosmosResources should exist");
   const res = await calculateFees({
-    a: account,
-    t: {
+    account,
+    transaction: {
       family: "cosmos",
       mode: "claimReward",
       amount: new BigNumber(0),