@ledgerhq/live-common 21.33.1-cosmos.2 → 21.34.0

package/src/account/support.ts

@@ -20,7 +20,7 @@ import { getMainAccount } from "../account";
 import { getAccountBridge } from "../bridge";
 import jsBridges from "../generated/bridge/js";
 
-const experimentalIntegrations = ["tezos, cosmos"];
+const experimentalIntegrations = ["tezos"];
 
 export function shouldUseJS(currency: CryptoCurrency) {
   const jsBridge = jsBridges[currency.family];

package/src/env.ts

@@ -156,7 +156,7 @@ const envDefinitions = {
     desc: "location of the compound API",
   },
   COSMOS_GAS_AMPLIFIER: {
-    def: 1.4,
+    def: 4,
     parser: intParser,
     desc: "estimate gas multiplier",
   },

package/src/families/bitcoin/bridge/js.ts

@@ -11,7 +11,6 @@ import { calculateFees } from "./../cache";
 import { perCoinLogic } from "../logic";
 import { makeAccountBridgeReceive } from "../../../bridge/jsHelpers";
 import * as explorerConfigAPI from "../../../api/explorerConfig";
-
 const receive = makeAccountBridgeReceive({
   injectGetAddressParams: (account) => {
     const perCoin = perCoinLogic[account.currency.id];

package/src/families/cosmos/libcore-buildTransaction.ts

@@ -136,10 +136,7 @@ export async function cosmosBuildTransaction({
     const gasRequest = await core.CosmosGasLimitRequest.init(
       memoTransaction,
       messages,
-      // COSMOS_GAS_AMPLIFIER env use by JS implementation
-      // Set as 4 int in order to not break libcore implementation
-      // String(getEnv("COSMOS_GAS_AMPLIFIER"))
-      String(4)
+      String(getEnv("COSMOS_GAS_AMPLIFIER"))
     );
     estimatedGas = await libcoreBigIntToBigNumber(
       // NOTE: With new cosmos code, this call might fail if the account hasn't been synchronized

package/src/families/cosmos/specs.ts

@@ -16,6 +16,7 @@ import { pickSiblings } from "../../bot/specs";
 import type { AppSpec } from "../../bot/types";
 import { toOperationRaw } from "../../account";
 import {
+  COSMOS_MIN_SAFE,
   canClaimRewards,
   canDelegate,
   canUndelegate,
@@ -23,21 +24,16 @@ import {
   getMaxDelegationAvailable,
 } from "./logic";
 import { DeviceModelId } from "@ledgerhq/devices";
-
-const minAmount = new BigNumber(50000);
-const maxAccounts = 12;
-
 const cosmos: AppSpec<Transaction> = {
   name: "Cosmos",
   currency: getCryptoCurrencyById("cosmos"),
   appQuery: {
     model: DeviceModelId.nanoS,
-    firmware: "2.0.0",
+    firmware: "<2",
     appName: "Cosmos",
   },
-  testTimeout: 2 * 60 * 1000,
   transactionCheck: ({ maxSpendable }) => {
-    invariant(maxSpendable.gt(minAmount), "balance is too low");
+    invariant(maxSpendable.gt(COSMOS_MIN_SAFE), "balance is too low");
   },
   test: ({ operation, optimisticOperation }) => {
     const opExpected: Record<string, any> = toOperationRaw({
@@ -49,28 +45,29 @@ const cosmos: AppSpec<Transaction> = {
     delete opExpected.blockHash;
     delete opExpected.blockHeight;
     expect(toOperationRaw(operation)).toMatchObject(opExpected); // TODO check it is between operation.value-fees (excluded) and operation.value
+
+    /*
+    // balance move
+    expect(account.balance.toString()).toBe(
+      accountBeforeTransaction.balance.minus(operation.value).toString()
+    );
+    */
   },
   mutations: [
     {
       name: "send some",
-      test: ({ account, accountBeforeTransaction, operation }) => {
-        expect(account.balance.toString()).toBe(
-          accountBeforeTransaction.balance.minus(operation.value).toString()
-        );
-      },
+      maxRun: 2,
       transaction: ({ account, siblings, bridge, maxSpendable }) => {
-        const amount = maxSpendable
-          .times(0.3 + 0.4 * Math.random())
-          .integerValue();
-        invariant(amount.gt(0), "random amount to be positive");
         return {
           transaction: bridge.createTransaction(account),
           updates: [
             {
-              recipient: pickSiblings(siblings, maxAccounts).freshAddress,
+              recipient: pickSiblings(siblings, 7).freshAddress,
             },
             {
-              amount,
+              amount: maxSpendable
+                .times(0.3 + 0.4 * Math.random())
+                .integerValue(),
             },
             Math.random() < 0.5
               ? {
@@ -89,7 +86,7 @@ const cosmos: AppSpec<Transaction> = {
           transaction: bridge.createTransaction(account),
           updates: [
             {
-              recipient: pickSiblings(siblings, maxAccounts).freshAddress,
+              recipient: pickSiblings(siblings, 7).freshAddress,
             },
             {
               useAllAmount: true,
@@ -103,23 +100,23 @@ const cosmos: AppSpec<Transaction> = {
     },
     {
       name: "delegate new validators",
-      maxRun: 1,
+      maxRun: 2,
       transaction: ({ account, bridge }) => {
         invariant(
-          account.index % 2 > 0,
-          "only one out of 2 accounts is not going to delegate"
+          account.index % 10 > 0,
+          "one out of 10 accounts is not going to delegate"
         );
         invariant(canDelegate(account), "can delegate");
         const { cosmosResources } = account;
         invariant(cosmosResources, "cosmos");
         invariant(
-          (cosmosResources as CosmosResources).delegations.length < 3,
+          (cosmosResources as CosmosResources).delegations.length < 10,
           "already enough delegations"
         );
         const data = getCurrentCosmosPreloadData();
-        const count = 1 + Math.floor(2 * Math.random());
+        const count = 1 + Math.floor(5 * Math.random());
         let remaining = getMaxDelegationAvailable(account, count).times(
-          0.5 * Math.random()
+          Math.random()
         );
         const all = data.validators.filter(
           (v) =>
@@ -205,12 +202,6 @@ const cosmos: AppSpec<Transaction> = {
           )
         );
         invariant(undelegateCandidate, "already pending");
-
-        const amount = (undelegateCandidate as CosmosDelegation).amount // most of the time, undelegate all
-          .times(Math.random() > 0.3 ? 1 : Math.random())
-          .integerValue();
-        invariant(amount.gt(0), "random amount to be positive");
-
         return {
           transaction: bridge.createTransaction(account),
           updates: [
@@ -223,7 +214,9 @@ const cosmos: AppSpec<Transaction> = {
                 {
                   address: (undelegateCandidate as CosmosDelegation)
                     .validatorAddress,
-                  amount,
+                  amount: (undelegateCandidate as CosmosDelegation).amount // most of the time, undelegate all
+                    .times(Math.random() > 0.3 ? 1 : Math.random())
+                    .integerValue(),
                 },
               ],
             },
@@ -274,13 +267,6 @@ const cosmos: AppSpec<Transaction> = {
               (sourceDelegation as CosmosDelegation).validatorAddress
           )
         );
-        const amount = (sourceDelegation as CosmosDelegation).amount
-          .times(
-            // most of the time redelegate all
-            Math.random() > 0.3 ? 1 : Math.random()
-          )
-          .integerValue();
-        invariant(amount.gt(0), "random amount to be positive");
         return {
           transaction: bridge.createTransaction(account),
           updates: [
@@ -292,7 +278,12 @@ const cosmos: AppSpec<Transaction> = {
               validators: [
                 {
                   address: (delegation as CosmosDelegation).validatorAddress,
-                  amount,
+                  amount: (sourceDelegation as CosmosDelegation).amount
+                    .times(
+                      // most of the time redelegate all
+                      Math.random() > 0.3 ? 1 : Math.random()
+                    )
+                    .integerValue(),
                 },
               ],
             },
@@ -339,10 +330,12 @@ const cosmos: AppSpec<Transaction> = {
         const { cosmosResources } = account;
         invariant(cosmosResources, "cosmos");
         const delegation = sample(
-          (cosmosResources as CosmosResources).delegations.filter((d) =>
-            d.pendingRewards.gt(1000)
+          (cosmosResources as CosmosResources).delegations.filter(
+            // FIXME
+            // (d) => canClaimRewards(account, d) && d.pendingRewards.gt(2000)
+            (d) => d.pendingRewards.gt(2000)
           )
-        ) as CosmosDelegation;
+        );
         invariant(delegation, "no delegation to claim");
         return {
           transaction: bridge.createTransaction(account),
@@ -352,8 +345,13 @@ const cosmos: AppSpec<Transaction> = {
               memo: "LedgerLiveBot",
               validators: [
                 {
-                  address: delegation.validatorAddress,
-                  amount: delegation.pendingRewards,
+                  address: (delegation as CosmosDelegation).validatorAddress,
+                  // TODO: the test should be
+                  // amount: delegation.pendingRewards,
+                  // but it won't work until COIN-665 is fixed until then,
+                  // amount is set to 0 in
+                  // src/families/cosmos/libcore-buildOperation in the REWARD case
+                  amount: new BigNumber(0),
                 },
               ],
             },

package/src/families/cosmos/test-dataset.ts

@@ -455,9 +455,9 @@ const cosmos: CurrenciesData<Transaction> = {
   ],
 };
 const dataset: DatasetTest<Transaction> = {
-  implementations: ["js"],
+  implementations: ["libcore"],
   currencies: {
-    cosmos,
+    // cosmos, // LL-7872
   },
 };
 export default dataset;

package/src/families/cosmos/validators.ts

@@ -181,8 +181,8 @@ const getRewardsState = makeLRUCache(
 );
 
 const getStargateRewardsState = makeLRUCache(
-  async (currency: CryptoCurrency) => {
-    /*
+  async (_currency: CryptoCurrency) => {
+    // Fake numbers until Gaia fixes its endpoints
     return {
       targetBondedRatio: 0.01,
       communityPoolCommission: 0.0,
@@ -196,102 +196,81 @@ const getStargateRewardsState = makeLRUCache(
       averageDailyFees: 0,
       currentValueInflation: 0.01,
     };
-    */
-
-    // All obtained values are strings ; so sometimes we will need to parse them as numbers
-    const inflationUrl = `${getBaseApiUrl(
-      currency
-    )}/cosmos/mint/v1beta1/inflation`;
-
-    const { data: inflationData } = await network({
-      url: inflationUrl,
-      method: "GET",
-    });
-
-    const currentValueInflation = parseFloat(inflationData.inflation);
-
-    const inflationParametersUrl = `${getBaseApiUrl(
-      currency
-    )}/cosmos/mint/v1beta1/params`;
-
-    const { data: inflationParametersData } = await network({
-      url: inflationParametersUrl,
-      method: "GET",
-    });
-
-    const inflationRateChange = parseFloat(
-      inflationParametersData.params.inflation_rate_change
-    );
-
-    const inflationMaxRate = parseFloat(
-      inflationParametersData.params.inflation_max
-    );
-
-    const inflationMinRate = parseFloat(
-      inflationParametersData.params.inflation_min
-    );
-
-    const targetBondedRatio = parseFloat(
-      inflationParametersData.params.goal_bonded
-    );
-
-    // Source for seconds per year : https://github.com/gavinly/CosmosParametersWiki/blob/master/Mint.md#notes-3
-    //  365.24 (days) * 24 (hours) * 60 (minutes) * 60 (seconds) = 31556736 seconds
-    const assumedTimePerBlock =
-      31556736.0 / parseFloat(inflationParametersData.params.blocks_per_year);
-
-    const communityTaxUrl = `${getBaseApiUrl(
-      currency
-    )}/cosmos/distribution/v1beta1/params`;
-
-    const { data: communityTax } = await network({
-      url: communityTaxUrl,
-      method: "GET",
-    });
-
-    const communityPoolCommission = parseFloat(
-      communityTax.params.community_tax
-    );
-
-    const supplyUrl = `${getBaseApiUrl(currency)}/cosmos/bank/v1beta1/supply/${
-      currency.id == "cosmos_testnet" ? "umuon" : "uatom"
-    }`;
-
-    const { data: totalSupplyData } = await network({
-      url: supplyUrl,
-      method: "GET",
-    });
-
-    const totalSupply = parseUatomStrAsAtomNumber(
-      totalSupplyData.amount.amount
-    );
-
-    const ratioUrl = `${getBaseApiUrl(currency)}/cosmos/staking/v1beta1/pool`;
-
-    const { data: ratioData } = await network({ url: ratioUrl, method: "GET" });
-
-    const actualBondedRatio =
-      parseUatomStrAsAtomNumber(ratioData.pool.bonded_tokens) / totalSupply;
-
-    // Arbitrary value in ATOM.
-    const averageDailyFees = 20;
-
-    // Arbitrary value in seconds
-    const averageTimePerBlock = 7.5;
-
-    return {
-      targetBondedRatio,
-      communityPoolCommission,
-      assumedTimePerBlock,
-      inflationRateChange,
-      inflationMaxRate,
-      inflationMinRate,
-      actualBondedRatio,
-      averageTimePerBlock,
-      totalSupply,
-      averageDailyFees,
-      currentValueInflation,
-    };
+    /*
+  // All obtained values are strings ; so sometimes we will need to parse them as numbers
+  const inflationUrl = `${getBaseApiUrl(
+    currency
+  )}/cosmos/mint/v1beta1/inflation`;
+  const { data: inflationData } = await network({
+    url: inflationUrl,
+    method: "GET",
+  });
+  const currentValueInflation = parseFloat(inflationData.inflation);
+   const inflationParametersUrl = `${getBaseApiUrl(
+    currency
+  )}/cosmos/mint/v1beta1/params`;
+  const { data: inflationParametersData } = await network({
+    url: inflationParametersUrl,
+    method: "GET",
+  });
+  const inflationRateChange = parseFloat(
+    inflationParametersData.params.inflation_rate_change
+  );
+  const inflationMaxRate = parseFloat(
+    inflationParametersData.params.inflation_max
+  );
+  const inflationMinRate = parseFloat(
+    inflationParametersData.params.inflation_min
+  );
+  const targetBondedRatio = parseFloat(
+    inflationParametersData.params.goal_bonded
+  );
+  // Source for seconds per year : https://github.com/gavinly/CosmosParametersWiki/blob/master/Mint.md#notes-3
+  //  365.24 (days) * 24 (hours) * 60 (minutes) * 60 (seconds) = 31556736 seconds
+  const assumedTimePerBlock =
+    31556736.0 / parseFloat(inflationParametersData.params.blocks_per_year);
+   const communityTaxUrl = `${getBaseApiUrl(
+    currency
+  )}/cosmos/distribution/v1beta1/params`;
+  const { data: communityTax } = await network({
+    url: communityTaxUrl,
+    method: "GET",
+  });
+  const communityPoolCommission = parseFloat(
+    communityTax.params.community_tax
+  );
+   const supplyUrl = `${getBaseApiUrl(currency)}/cosmos/bank/v1beta1/supply/${
+    currency.id == "cosmos_testnet" ? "umuon" : "uatom"
+  }`;
+  const { data: totalSupplyData } = await network({
+    url: supplyUrl,
+    method: "GET",
+  });
+  const totalSupply = parseUatomStrAsAtomNumber(
+    totalSupplyData.amount.amount
+  );
+   const ratioUrl = `${getBaseApiUrl(currency)}/cosmos/staking/v1beta1/pool`;
+  const { data: ratioData } = await network({ url: ratioUrl, method: "GET" });
+  const actualBondedRatio =
+    parseUatomStrAsAtomNumber(ratioData.pool.bonded_tokens) / totalSupply;
+   // Arbitrary value in ATOM.
+  const averageDailyFees = 20;
+   // Arbitrary value in seconds
+  const averageTimePerBlock = 7.5;
+   return {
+    targetBondedRatio,
+    communityPoolCommission,
+    assumedTimePerBlock,
+    inflationRateChange,
+    inflationMaxRate,
+    inflationMinRate,
+    actualBondedRatio,
+    averageTimePerBlock,
+    totalSupply,
+    averageDailyFees,
+    currentValueInflation,
+  };
+  */
   },
   (currency: CryptoCurrency) => currency.id
 );

package/src/families/filecoin/account.ts

@@ -0,0 +1,44 @@
+import BigNumber from "bignumber.js";
+
+export function fromOperationExtraRaw(
+  extra: Record<string, any> | null | undefined
+): Record<string, any> | null | undefined {
+  if (!extra) return extra;
+
+  const { gasLimit, gasPremium, gasFeeCap } = extra;
+
+  if (gasLimit !== undefined)
+    extra = { ...extra, gasLimit: new BigNumber(gasLimit) };
+
+  if (gasPremium !== undefined)
+    extra = { ...extra, gasPremium: new BigNumber(gasPremium) };
+
+  if (gasFeeCap !== undefined)
+    extra = { ...extra, gasFeeCap: new BigNumber(gasFeeCap) };
+
+  return extra;
+}
+
+export function toOperationExtraRaw(
+  extra: Record<string, any> | null | undefined
+): Record<string, any> | null | undefined {
+  if (!extra) return extra;
+
+  const { gasLimit, gasPremium, gasFeeCap } = extra;
+
+  if (gasLimit !== undefined)
+    extra = { ...extra, gasLimit: gasLimit.toNumber() };
+
+  if (gasPremium !== undefined)
+    extra = { ...extra, gasPremium: gasPremium.toFixed() };
+
+  if (gasFeeCap !== undefined)
+    extra = { ...extra, gasFeeCap: gasFeeCap.toFixed() };
+
+  return extra;
+}
+
+export default {
+  fromOperationExtraRaw,
+  toOperationExtraRaw,
+};

package/src/families/filecoin/bridge/account.ts

@@ -66,8 +66,10 @@ const getTransactionStatus = async (
   const errors: TransactionStatus["errors"] = {};
   const warnings: TransactionStatus["warnings"] = {};
 
+  const { balance } = a;
   const { address } = getAddress(a);
-  const { recipient, amount, gasPremium, gasFeeCap, gasLimit } = t;
+  const { recipient, useAllAmount, gasPremium, gasFeeCap, gasLimit } = t;
+  let { amount } = t;
 
   if (!recipient) errors.recipient = new RecipientRequired();
   else if (!validateAddress(recipient).isValid)
@@ -81,8 +83,8 @@ const getTransactionStatus = async (
   // This is the worst case scenario (the tx won't cost more than this value)
   const estimatedFees = calculateEstimatedFees(gasFeeCap, gasLimit);
 
-  // Add the estimated fees to the tx amount
-  const totalSpent = amount.plus(estimatedFees);
+  const totalSpent = useAllAmount ? balance : amount.plus(estimatedFees);
+  amount = useAllAmount ? balance.minus(estimatedFees) : amount;
 
   if (amount.lte(0)) errors.amount = new AmountRequired();
   if (totalSpent.gt(a.spendableBalance)) errors.amount = new NotEnoughBalance();
@@ -174,11 +176,13 @@ const prepareTransaction = async (
 const sync = makeSync(getAccountShape);
 
 const broadcast: BroadcastFnSignature = async ({
-  signedOperation: { operation },
+  signedOperation: { operation, signature },
 }) => {
   // log("debug", "[broadcast] start fn");
 
-  const resp = await broadcastTx(operation.extra.reqToBroadcast);
+  const tx = getTxToBroadcast(operation, signature);
+
+  const resp = await broadcastTx(tx);
   const { hash } = resp;
 
   const result = patchOperationWithHash(operation, hash);
@@ -199,8 +203,18 @@ const signOperation: SignOperationFnSignature<Transaction> = ({
         async function main() {
           // log("debug", "[signOperation] start fn");
 
-          const { recipient, amount, gasFeeCap, gasLimit } = transaction;
-          const { id: accountId } = account;
+          const {
+            recipient,
+            method,
+            version,
+            nonce,
+            gasFeeCap,
+            gasLimit,
+            gasPremium,
+            useAllAmount,
+          } = transaction;
+          let { amount } = transaction;
+          const { id: accountId, balance } = account;
           const { address, derivationPath } = getAddress(account);
 
           if (!gasFeeCap.gt(0) || !gasLimit.gt(0)) {
@@ -218,6 +232,11 @@ const signOperation: SignOperationFnSignature<Transaction> = ({
               type: "device-signature-requested",
             });
 
+            const fee = calculateEstimatedFees(gasFeeCap, gasLimit);
+            if (useAllAmount) amount = balance.minus(fee);
+
+            transaction = { ...transaction, amount };
+
             // Serialize tx
             const serializedTx = toCBOR(
               getAddressRaw(address),
@@ -243,21 +262,12 @@ const signOperation: SignOperationFnSignature<Transaction> = ({
               type: "device-signature-granted",
             });
 
-            const fee = calculateEstimatedFees(gasFeeCap, gasLimit);
-            const value = amount.plus(fee);
-
             // resolved at broadcast time
             const txHash = "";
 
             // build signature on the correct format
             const signature = `${result.signature_compact.toString("base64")}`;
 
-            const reqToBroadcast = getTxToBroadcast(
-              account,
-              transaction,
-              signature
-            );
-
             const operation: Operation = {
               id: `${accountId}-${txHash}-OUT`,
               hash: txHash,
@@ -265,13 +275,19 @@ const signOperation: SignOperationFnSignature<Transaction> = ({
               senders: [address],
               recipients: [recipient],
               accountId,
-              value,
+              value: amount,
               fee,
               blockHash: null,
               blockHeight: null,
               date: new Date(),
               extra: {
-                reqToBroadcast,
+                gasLimit,
+                gasFeeCap,
+                gasPremium,
+                method,
+                version,
+                nonce,
+                signatureType: 1,
               },
             };
 

package/src/families/filecoin/bridge/utils/utils.ts

@@ -12,7 +12,6 @@ import {
 import { fetchBalances, fetchBlockHeight, fetchTxs } from "./api";
 import { encodeAccountId } from "../../../../account";
 import flatMap from "lodash/flatMap";
-import { Transaction } from "../../types";
 
 type TxsById = {
   [id: string]: {
@@ -103,21 +102,19 @@ export const getAddress = (a: Account): Address =>
     : { address: a.freshAddress, derivationPath: a.freshAddressPath };
 
 export const getTxToBroadcast = (
-  account: Account,
-  transaction: Transaction,
+  operation: Operation,
   signature: string
 ): BroadcastTransactionRequest => {
-  const { address } = getAddress(account);
+  const { extra, senders, recipients, value } = operation;
   const {
-    recipient,
-    amount,
     gasLimit,
     gasFeeCap,
     gasPremium,
     method,
     version,
     nonce,
-  } = transaction;
+    signatureType,
+  } = extra;
 
   return {
     message: {
@@ -125,15 +122,15 @@ export const getTxToBroadcast = (
       method,
       nonce,
       params: "",
-      to: recipient,
-      from: address,
+      to: recipients[0],
+      from: senders[0],
       gaslimit: gasLimit.toNumber(),
       gaspremium: gasPremium.toString(),
       gasfeecap: gasFeeCap.toString(),
-      value: amount.toFixed(),
+      value: value.toFixed(),
     },
     signature: {
-      type: 1,
+      type: signatureType,
       data: signature,
     },
   };