@ledgerhq/live-common 21.32.1 → 21.32.5

package/src/__tests__/__snapshots__/all.libcore.ts.snap

@@ -852,7 +852,6 @@ Array [
         "bc1q73ngvy3pxn92d5zx8pwdxwelczqk5r9ceyka8a",
         "bc1qhzzzm86w9j5fvhr4pql303ehrhqnzk63npc0ge",
         "bc1qyanx2ql0yjxuzhaqe7tkqj5spx548sv04mpyfq",
-        "bc1qyanx2ql0yjxuzhaqe7tkqj5spx548sv04mpyfq",
       ],
       "standard": undefined,
       "tokenId": undefined,
@@ -1176,7 +1175,6 @@ Array [
       ],
       "senders": Array [
         "bc1q9m02yv9c53enxk247lxkgj5dgn6hm27f0rc34p",
-        "bc1q9m02yv9c53enxk247lxkgj5dgn6hm27f0rc34p",
       ],
       "standard": undefined,
       "tokenId": undefined,
@@ -1670,7 +1668,6 @@ Array [
         "bc1qkq3uad6kyje3sh4eqvlgudnzp2xc4y27maep7e",
         "bc1qsckgz236lhuh42v6nfrky4fn3hs9crhguw3cyl",
         "bc1q38wn8h2rxn56f02lulkyjantegnr7906ej0gdh",
-        "bc1q38wn8h2rxn56f02lulkyjantegnr7906ej0gdh",
         "bc1qff6tj478qzr6gl30pmfvy3h09ev20ta4x6y8sd",
       ],
       "standard": undefined,
@@ -2958,7 +2955,6 @@ Array [
         "bc1qwqfns0rs5zxrrwf80k4xlp4lpnuyc69feh2r3d",
         "bc1qpjgn3l5g6j8ry3jkfdwytxdd022ss4gxsll2pp",
         "bc1qq42nl3tdcl7zfgkvpa6fm7r899emv7n5ap7tup",
-        "bc1qq42nl3tdcl7zfgkvpa6fm7r899emv7n5ap7tup",
       ],
       "standard": undefined,
       "tokenId": undefined,
@@ -5710,7 +5706,6 @@ Array [
       ],
       "senders": Array [
         "bc1q9m02yv9c53enxk247lxkgj5dgn6hm27f0rc34p",
-        "bc1q9m02yv9c53enxk247lxkgj5dgn6hm27f0rc34p",
       ],
       "standard": undefined,
       "tokenId": undefined,
@@ -7133,8 +7128,6 @@ Array [
       "senders": Array [
         "1B9ib6VK7ZoZ74nCHjktFnV7G1tdrXEd41",
         "1Q8hwXu7Tw551AR3zYf72gZ8pAJpUXFNDY",
-        "1B9ib6VK7ZoZ74nCHjktFnV7G1tdrXEd41",
-        "1B9ib6VK7ZoZ74nCHjktFnV7G1tdrXEd41",
         "19zHW8VQ6MZsKWQfzwgPca4qfVLaKgDY4Q",
         "1NhBVwi2tWFh3yWmTUSG73NnTXiBbunoig",
       ],
@@ -9694,7 +9687,6 @@ Array [
         "bc1qwqfns0rs5zxrrwf80k4xlp4lpnuyc69feh2r3d",
         "bc1qpjgn3l5g6j8ry3jkfdwytxdd022ss4gxsll2pp",
         "bc1qq42nl3tdcl7zfgkvpa6fm7r899emv7n5ap7tup",
-        "bc1qq42nl3tdcl7zfgkvpa6fm7r899emv7n5ap7tup",
       ],
       "standard": undefined,
       "tokenId": undefined,
@@ -9991,8 +9983,6 @@ Array [
       "senders": Array [
         "1B9ib6VK7ZoZ74nCHjktFnV7G1tdrXEd41",
         "1Q8hwXu7Tw551AR3zYf72gZ8pAJpUXFNDY",
-        "1B9ib6VK7ZoZ74nCHjktFnV7G1tdrXEd41",
-        "1B9ib6VK7ZoZ74nCHjktFnV7G1tdrXEd41",
         "19zHW8VQ6MZsKWQfzwgPca4qfVLaKgDY4Q",
         "1NhBVwi2tWFh3yWmTUSG73NnTXiBbunoig",
       ],
@@ -11209,7 +11199,6 @@ Array [
         "bc1qkq3uad6kyje3sh4eqvlgudnzp2xc4y27maep7e",
         "bc1qsckgz236lhuh42v6nfrky4fn3hs9crhguw3cyl",
         "bc1q38wn8h2rxn56f02lulkyjantegnr7906ej0gdh",
-        "bc1q38wn8h2rxn56f02lulkyjantegnr7906ej0gdh",
         "bc1qff6tj478qzr6gl30pmfvy3h09ev20ta4x6y8sd",
       ],
       "standard": undefined,
@@ -13465,7 +13454,6 @@ Array [
       ],
       "senders": Array [
         "SfbEne7vYyByW6XAcHDJCqFGHAHp9XUUnk",
-        "SfbEne7vYyByW6XAcHDJCqFGHAHp9XUUnk",
       ],
       "standard": undefined,
       "tokenId": undefined,
@@ -18477,7 +18465,6 @@ Array [
         "RJXH5iiDG9GGP3uFN4y9nZznWm4H7WRpZr",
         "RNBip2PqrD9xhkoK613VptMqjfS1Sdwa2p",
         "RQeZqrkJuGpv3nCF3QriSUt7b7zRaE2WDj",
-        "RQeZqrkJuGpv3nCF3QriSUt7b7zRaE2WDj",
         "RHQeF3BUrN1ub5PqdQhWTAbJB2pv7xukML",
         "RKSuhHTzgmc5gnFDCdSJt3U8HWeNYnPuK6",
         "RRmshus5KvRKRY1oT56imffSFuxPUPS7s1",
@@ -18975,7 +18962,6 @@ Array [
       "senders": Array [
         "RLYGtUx7btUCBVZXu7NNYWZ7b8sBAuPrYw",
         "RSwtr8GTRhb7DaMxLxsHpJtSwKVvgQykMV",
-        "RSwtr8GTRhb7DaMxLxsHpJtSwKVvgQykMV",
         "RWcX7eETAYi5kY6tdnFUnB2Ym91ys8nDS3",
         "RL9A3qSt1sFmN53CFhgmgVfbqNcEQr3vb9",
         "RSLN3e8R5EAxxpQrTo7DnA28GS1vWWdMrg",
@@ -21624,7 +21610,6 @@ Array [
         "RJXH5iiDG9GGP3uFN4y9nZznWm4H7WRpZr",
         "RNBip2PqrD9xhkoK613VptMqjfS1Sdwa2p",
         "RQeZqrkJuGpv3nCF3QriSUt7b7zRaE2WDj",
-        "RQeZqrkJuGpv3nCF3QriSUt7b7zRaE2WDj",
         "RHQeF3BUrN1ub5PqdQhWTAbJB2pv7xukML",
         "RKSuhHTzgmc5gnFDCdSJt3U8HWeNYnPuK6",
         "RRmshus5KvRKRY1oT56imffSFuxPUPS7s1",
@@ -23091,7 +23076,6 @@ Array [
       ],
       "senders": Array [
         "ltc1qpx9fcj5qht64vymj469cfyun73tllcch7qeuwq",
-        "ltc1qpx9fcj5qht64vymj469cfyun73tllcch7qeuwq",
       ],
       "standard": undefined,
       "tokenId": undefined,
@@ -23115,7 +23099,6 @@ Array [
       ],
       "senders": Array [
         "ltc1qpx9fcj5qht64vymj469cfyun73tllcch7qeuwq",
-        "ltc1qpx9fcj5qht64vymj469cfyun73tllcch7qeuwq",
       ],
       "standard": undefined,
       "tokenId": undefined,
@@ -24010,7 +23993,6 @@ Array [
         "LRSwoGzTUJicczVJq9UzGG5GAdFg7BkDRn",
       ],
       "senders": Array [
-        "MFjxjn5xQxwyaq6TG8iTsQtDuYxrRoFNUP",
         "MFjxjn5xQxwyaq6TG8iTsQtDuYxrRoFNUP",
         "MGzg47wRQzhznkqa2zfFMeP6pgtnBx5jox",
       ],
@@ -24947,7 +24929,6 @@ Array [
         "LRSwoGzTUJicczVJq9UzGG5GAdFg7BkDRn",
       ],
       "senders": Array [
-        "MFjxjn5xQxwyaq6TG8iTsQtDuYxrRoFNUP",
         "MFjxjn5xQxwyaq6TG8iTsQtDuYxrRoFNUP",
         "MGzg47wRQzhznkqa2zfFMeP6pgtnBx5jox",
       ],
@@ -26644,7 +26625,6 @@ Array [
         "QandudfUt26efFQJ8KkUgadiiWUBEbFmtb",
         "QUte92ZdeDrscFk369jJNWMeUyMwj6fz21",
         "QgFuPJMkucK8mvFdMi2hUENpCervNY9dBt",
-        "QgFuPJMkucK8mvFdMi2hUENpCervNY9dBt",
         "QUMmwEdDC2ps2HRetdaboLeakSCWyCK4ja",
       ],
       "standard": undefined,
@@ -28598,7 +28578,6 @@ Array [
         "QandudfUt26efFQJ8KkUgadiiWUBEbFmtb",
         "QUte92ZdeDrscFk369jJNWMeUyMwj6fz21",
         "QgFuPJMkucK8mvFdMi2hUENpCervNY9dBt",
-        "QgFuPJMkucK8mvFdMi2hUENpCervNY9dBt",
         "QUMmwEdDC2ps2HRetdaboLeakSCWyCK4ja",
       ],
       "standard": undefined,
@@ -28728,6 +28707,115 @@ Array [
 ]
 `;
 
+exports[`solana currency bridge scanAccounts solana seed 1 1`] = `
+Array [
+  Object {
+    "balance": "83389840",
+    "currencyId": "solana",
+    "derivationMode": "solanaMain",
+    "freshAddress": "AQbkEagmPgmsdAfS4X8V8UyJnXXjVPMvjeD15etqQ3Jh",
+    "freshAddressPath": "44'/501'",
+    "freshAddresses": Array [
+      Object {
+        "address": "AQbkEagmPgmsdAfS4X8V8UyJnXXjVPMvjeD15etqQ3Jh",
+        "derivationPath": "44'/501'",
+      },
+    ],
+    "id": "js:2:solana:AQbkEagmPgmsdAfS4X8V8UyJnXXjVPMvjeD15etqQ3Jh:solanaMain",
+    "index": 0,
+    "name": "Solana 1",
+    "nfts": undefined,
+    "operationsCount": 2,
+    "pendingOperations": Array [],
+    "seedIdentifier": "AQbkEagmPgmsdAfS4X8V8UyJnXXjVPMvjeD15etqQ3Jh",
+    "spendableBalance": "83389840",
+    "starred": false,
+    "swapHistory": Array [],
+    "syncHash": undefined,
+    "unitMagnitude": 9,
+    "used": true,
+  },
+  Object {
+    "balance": "0",
+    "currencyId": "solana",
+    "derivationMode": "solanaSub",
+    "freshAddress": "6rEgdtB3sgjKJnRE172YEr9z6qUyr4nFW28vJokuD36A",
+    "freshAddressPath": "44'/501'/0'",
+    "freshAddresses": Array [
+      Object {
+        "address": "6rEgdtB3sgjKJnRE172YEr9z6qUyr4nFW28vJokuD36A",
+        "derivationPath": "44'/501'/0'",
+      },
+    ],
+    "id": "js:2:solana:6rEgdtB3sgjKJnRE172YEr9z6qUyr4nFW28vJokuD36A:solanaSub",
+    "index": 0,
+    "name": "Solana 1",
+    "nfts": undefined,
+    "operationsCount": 0,
+    "pendingOperations": Array [],
+    "seedIdentifier": "AQbkEagmPgmsdAfS4X8V8UyJnXXjVPMvjeD15etqQ3Jh",
+    "spendableBalance": "0",
+    "starred": false,
+    "swapHistory": Array [],
+    "syncHash": undefined,
+    "unitMagnitude": 9,
+    "used": false,
+  },
+]
+`;
+
+exports[`solana currency bridge scanAccounts solana seed 1 2`] = `
+Array [
+  Array [
+    Object {
+      "accountId": "js:2:solana:AQbkEagmPgmsdAfS4X8V8UyJnXXjVPMvjeD15etqQ3Jh:solanaMain",
+      "blockHash": "4NSL4VrfWd2eUccMD95dLQsdy5UGz8yhokpfH1et1R2c",
+      "blockHeight": 108520722,
+      "contract": undefined,
+      "extra": Object {},
+      "fee": "0",
+      "hasFailed": false,
+      "hash": "25KWBvKtVgKR3yoRmozTY6wmiW8atwrnzAnTXdsms8jqg5aR8GnCDxdJzWXtzMZPvbsE6SUuBkGFXudy2mrcTYna",
+      "id": "js:2:solana:AQbkEagmPgmsdAfS4X8V8UyJnXXjVPMvjeD15etqQ3Jh:solanaMain-25KWBvKtVgKR3yoRmozTY6wmiW8atwrnzAnTXdsms8jqg5aR8GnCDxdJzWXtzMZPvbsE6SUuBkGFXudy2mrcTYna-IN",
+      "operator": undefined,
+      "recipients": Array [
+        "AQbkEagmPgmsdAfS4X8V8UyJnXXjVPMvjeD15etqQ3Jh",
+      ],
+      "senders": Array [
+        "7CZgkK494jMdoY8xpXY3ViLjpDGMbNikCzMtAT5cAjKk",
+      ],
+      "standard": undefined,
+      "tokenId": undefined,
+      "type": "IN",
+      "value": "93394840",
+    },
+    Object {
+      "accountId": "js:2:solana:AQbkEagmPgmsdAfS4X8V8UyJnXXjVPMvjeD15etqQ3Jh:solanaMain",
+      "blockHash": "9tPbgLaETEenufCt5SzXMuWijgFJj549W9j5cJLbaogn",
+      "blockHeight": 108521109,
+      "contract": undefined,
+      "extra": Object {},
+      "fee": "5000",
+      "hasFailed": false,
+      "hash": "A29zPnK1jPr2tGziTnaAvSnadYR2kLCv9sPywj9FJsaEFjtpwmUonspN3WJgz4u6XWmjtVpoFsDrygEnvW51cgk",
+      "id": "js:2:solana:AQbkEagmPgmsdAfS4X8V8UyJnXXjVPMvjeD15etqQ3Jh:solanaMain-A29zPnK1jPr2tGziTnaAvSnadYR2kLCv9sPywj9FJsaEFjtpwmUonspN3WJgz4u6XWmjtVpoFsDrygEnvW51cgk-OUT",
+      "operator": undefined,
+      "recipients": Array [
+        "8RtwWeqdFz4EFuZU3MAadfYMWSdRMamjFrfq6BXkHuNN",
+      ],
+      "senders": Array [
+        "AQbkEagmPgmsdAfS4X8V8UyJnXXjVPMvjeD15etqQ3Jh",
+      ],
+      "standard": undefined,
+      "tokenId": undefined,
+      "type": "OUT",
+      "value": "10005000",
+    },
+  ],
+  Array [],
+]
+`;
+
 exports[`stellar currency bridge scanAccounts stellar seed 1 1`] = `
 Array [
   Object {
@@ -31722,7 +31810,6 @@ Array [
       ],
       "senders": Array [
         "Vhbc9ZzzH89S8fkEbqRWuatEzwPCRf3Uyp",
-        "Vhbc9ZzzH89S8fkEbqRWuatEzwPCRf3Uyp",
       ],
       "standard": undefined,
       "tokenId": undefined,
@@ -32003,7 +32090,6 @@ Array [
       ],
       "senders": Array [
         "Vhbc9ZzzH89S8fkEbqRWuatEzwPCRf3Uyp",
-        "Vhbc9ZzzH89S8fkEbqRWuatEzwPCRf3Uyp",
       ],
       "standard": undefined,
       "tokenId": undefined,

package/src/__tests__/families/bitcoin/wallet-btc/wallet.integration.test.ts

@@ -5,6 +5,8 @@ import { Account } from "../../../../families/bitcoin/wallet-btc/account";
 import { Merge } from "../../../../families/bitcoin/wallet-btc/pickingstrategies/Merge";
 import MockBtc from "../../../../mock/Btc";
 
+jest.setTimeout(180000);
+
 describe("testing wallet", () => {
   const wallet = new BitcoinLikeWallet();
   let account: Account;

package/src/__tests__/families/bitcoin/wallet-btc/xpub.getAddress.ts

@@ -0,0 +1,78 @@
+import { DerivationModes } from "../../../../families/bitcoin/wallet-btc";
+import BitcoinLikeStorage from "../../../../families/bitcoin/wallet-btc/storage";
+import BitcoinLikeExplorer from "../../../../families/bitcoin/wallet-btc/explorer";
+import Xpub from "../../../../families/bitcoin/wallet-btc/xpub";
+import coininfo from "coininfo";
+import BCHCrypto from "../../../../families/bitcoin/wallet-btc/crypto/bitcoincash";
+import BTCCrypto from "../../../../families/bitcoin/wallet-btc/crypto/bitcoin";
+import ZECCrypto from "../../../../families/bitcoin/wallet-btc/crypto/zec";
+import ZENCrypto from "../../../../families/bitcoin/wallet-btc/crypto/zen";
+
+describe("Unit tests for getAddress", () => {
+  it("Test getAddress for bch and btc", async () => {
+    const bchCrypto = new BCHCrypto({
+      network: coininfo.bitcoincash.main.toBitcoinJS(),
+    });
+    const btcCrypto = new BTCCrypto({
+      network: coininfo.bitcoin.main.toBitcoinJS(),
+    });
+    const bchxpub = new Xpub({
+      storage: new BitcoinLikeStorage(),
+      explorer: new BitcoinLikeExplorer({
+        explorerURI: "https://explorers.api.vault.ledger.com/blockchain/v3/bch",
+        explorerVersion: "v3",
+      }),
+      crypto: bchCrypto,
+      xpub: "xpub6BtWBf3Pu6hYwJBKvEwG7JtrTxxDrSGy39HaTgZz6GTSaFWFdoCtuEXSQtoKGaYdz1emg8xTXKYwjhu3xXRPzFnYS1z4yjKj7hLDQyNeDZr",
+      derivationMode: DerivationModes.LEGACY,
+    });
+    await bchxpub.syncAddress(0, 0);
+    let addresses = await bchxpub.getXpubAddresses();
+    expect(addresses[0].address).toEqual(
+      "bitcoincash:qrgwhfg7tn4xs9pg2vu5rhkud490j9yfnqd63uk64m"
+    );
+
+    const btcxpub = new Xpub({
+      storage: new BitcoinLikeStorage(),
+      explorer: new BitcoinLikeExplorer({
+        explorerURI: "https://explorers.api.vault.ledger.com/blockchain/v3/btc",
+        explorerVersion: "v3",
+      }),
+      crypto: btcCrypto,
+      xpub: "xpub6BtWBf3Pu6hYwJBKvEwG7JtrTxxDrSGy39HaTgZz6GTSaFWFdoCtuEXSQtoKGaYdz1emg8xTXKYwjhu3xXRPzFnYS1z4yjKj7hLDQyNeDZr",
+      derivationMode: DerivationModes.LEGACY,
+    });
+    await btcxpub.syncAddress(0, 0);
+    addresses = await btcxpub.getXpubAddresses();
+    expect(addresses[0].address).toEqual("1L3fqoWstvLqEA6TgXkuLoXX8xG1xhirG3");
+  }, 60000);
+
+  it("Test getoutputScriptFromAddress for btc, zcash and zen", async () => {
+    const btcCrypto = new BTCCrypto({
+      network: coininfo.bitcoin.main.toBitcoinJS(),
+    });
+    const zecCrypto = new ZECCrypto({
+      network: coininfo.zcash.main.toBitcoinJS(),
+    });
+    const zenCrypto = new ZENCrypto({
+      network: coininfo.zcash.main.toBitcoinJS(),
+    });
+    expect(
+      btcCrypto
+        .toOutputScript("1F1tAaz5x1HUXrCNLbtMDqcw6o5GNn4xqX")
+        .toString("hex")
+    ).toEqual("76a91499bc78ba577a95a11f1a344d4d2ae55f2f857b9888ac");
+    expect(
+      zecCrypto
+        .toOutputScript("t1T5XJvzQhh2gTsi3c5Vn9x5SMhpSWLSnVy")
+        .toString("hex")
+    ).toEqual("76a91464fa33fb6f8d72455af2a4e73ae30412af2c97ba88ac");
+    expect(
+      zenCrypto
+        .toOutputScript("znjbHth4PxBJM8FmHgvXYHkuq99nKFkWvMg")
+        .toString("hex")
+    ).toEqual(
+      "76a914cb009bf12fc17d28e61527951101fdabfeaa187288ac209ec9845acb02fab24e1c0368b3b517c1a4488fba97f0e3459ac053ea0100000003c01f02b4"
+    );
+  }, 30000);
+});

package/src/apps/hw.ts

@@ -315,9 +315,10 @@ export const listApps = (
           }
 
           const type =
-            application.description === AppType.PLUGIN
-              ? AppType.PLUGIN
-              : AppType.APP;
+            application.description &&
+            Object.values(AppType).includes(application.description as AppType)
+              ? AppType[application.description]
+              : AppType.app;
 
           const app: App = polyfillApp({
             id: version.id,

package/src/apps/logic.ts

@@ -1,7 +1,6 @@
 import { $Shape } from "utility-types";
 import { Subject } from "rxjs";
 import flatMap from "lodash/flatMap";
-import invariant from "invariant";
 import semver from "semver";
 import { getDeviceModel } from "@ledgerhq/devices";
 import type { App } from "../types/manager";
@@ -17,7 +16,7 @@ import {
   findCryptoCurrencyById,
   isCurrencySupported,
 } from "../currencies";
-import { LatestFirmwareVersionRequired } from "../errors";
+import { LatestFirmwareVersionRequired, NoSuchAppOnProvider } from "../errors";
 
 export const initState = (
   {
@@ -292,6 +291,7 @@ export const reducer = (state: State, action: Action): State => {
       // No app found but fw update is available
       if (
         !depApp &&
+        state.firmware?.updateAvailable?.final?.version &&
         semver.lt(
           state.deviceInfo.version,
           state.firmware?.updateAvailable?.final?.version
@@ -306,7 +306,10 @@ export const reducer = (state: State, action: Action): State => {
         );
       }
 
-      invariant(depApp, "no such app '%s'", name);
+      if (!depApp) {
+        throw new NoSuchAppOnProvider("", { appName: name });
+      }
+
       const deps = depApp.dependencies;
       const dependentsOfDep = flatMap(deps, (dep) =>
         findDependents(state.appByName, dep)

package/src/bot/engine.ts

@@ -81,6 +81,9 @@ export async function runWithAppSpec<T extends Transaction>(
   const mutationReports: MutationReport<T>[] = [];
   const { appQuery, currency, dependency } = spec;
   const appCandidate = findAppCandidate(appCandidates, appQuery);
+  if (!appCandidate) {
+    console.warn("no app found for " + spec.name, { appQuery, appCandidates });
+  }
   invariant(
     appCandidate,
     "%s: no app found. Are you sure your COINAPPS is up to date?",

package/src/env.ts

@@ -540,6 +540,11 @@ const envDefinitions = {
     parser: stringParser,
     desc: "url used to fetch platform app manifests (staging)",
   },
+  PLATFORM_LOCAL_MANIFEST_JSON: {
+    def: "",
+    parser: stringParser,
+    desc: 'json manifest for a local (test) platform app manifests. How to use: PLATFORM_LOCAL_MANIFEST_JSON="$(cat /path/to/file.json)"',
+  },
   PLATFORM_API_URL: {
     def: "",
     parser: stringParser,

package/src/errors.ts

@@ -141,6 +141,9 @@ export const SatStackDescriptorNotImported = createCustomErrorClass(
 export const SwapNoAvailableProviders = createCustomErrorClass(
   "SwapNoAvailableProviders"
 );
+export const NoSuchAppOnProvider = createCustomErrorClass(
+  "NoSuchAppOnProvider"
+);
 export const SwapExchangeRateAmountTooLow = createCustomErrorClass(
   "SwapExchangeRateAmountTooLow"
 );

package/src/exchange/platform/transfer/index.ts

@@ -32,7 +32,27 @@ const fundProviders: Record<
     curve: string;
   }
 > = {
-  // FIXME: no prod provider for now
+  baanx: {
+    /**
+     * nameAndPubkey is the concatenation of:
+     * - an empty buffer of the size of the partner name
+     * - a buffer created from the partner name string in ascii encoding
+     * - a buffer created from the hexadecimal version of the partner public key
+     */
+    nameAndPubkey: Buffer.concat([
+      Buffer.from([5]),
+      Buffer.from("Baanx", "ascii"),
+      Buffer.from(
+        "04551878b446b6a711949fa51cc5a8685602f8ffb1dfd08f6ab869019d7c125d7737a79e8b5022d860ec7dfbe062d510fec3b5fe0f6ebb1f5e55a074bb7e5dbc4e",
+        "hex"
+      ),
+    ]),
+    signature: Buffer.from(
+      "304402200345c39e93a22c5ac3f1e70f8b9938b3a60d3a4906067443cf11095af0e685a502201ee5d88dd5539ce36341e49e2505c2a1659e26d8ff08801ed33c50a9126aedd1",
+      "hex"
+    ),
+    curve: "secp256r1",
+  },
 };
 
 const getProvider = (

package/src/families/algorand/buildTransaction.ts

@@ -1,6 +1,5 @@
 import { encode as msgpackEncode } from "algo-msgpack-with-bigint";
 import type {
-  SuggestedParams as AlgoSuggestedParams,
   Transaction as AlgoTransaction,
   EncodedTransaction as AlgoTransactionPayload,
   EncodedSignedTransaction as AlgoSignedTransactionPayload,
@@ -28,8 +27,7 @@ export const buildTransactionPayload = async (
 
   const note = memo ? new TextEncoder().encode(memo) : undefined;
 
-  // Minor hack: cast the result as a algosdk.SuggestedParams, while it's actually a TransactionParametersResponse
-  const params = (await getTransactionParams()) as AlgoSuggestedParams;
+  const params = await getTransactionParams();
 
   let algoTxn: AlgoTransaction;
   if (subAccount || (assetId && mode === "optIn")) {
@@ -78,18 +76,16 @@ export const buildTransactionPayload = async (
   return sorted;
 };
 
-export const encodeToSign = async (
-  payload: AlgoTransactionPayload
-): Promise<string> => {
+export const encodeToSign = (payload: AlgoTransactionPayload): string => {
   const msgPackEncoded = msgpackEncode(payload);
 
   return Buffer.from(msgPackEncoded).toString("hex");
 };
 
-export const encodeToBroadcast = async (
+export const encodeToBroadcast = (
   payload: AlgoTransactionPayload,
   signature: Buffer
-): Promise<Buffer> => {
+): Buffer => {
   const signedPayload: AlgoSignedTransactionPayload = {
     sig: signature,
     txn: payload,

package/src/families/algorand/js-getFeesForTransaction.ts

@@ -17,7 +17,7 @@ export const getEstimatedFees = async (
   let suggestedFees = 0;
   if (params.fee) {
     const payload = await buildTransactionPayload(account, transaction);
-    const encoded = await encodeToSign(payload);
+    const encoded = encodeToSign(payload);
     suggestedFees =
       params.fee * (Buffer.from(encoded, "hex").length + SINGLE_SIGNATURE_SIZE);
   }

package/src/families/algorand/js-signOperation.ts

@@ -36,7 +36,7 @@ export const signOperation = ({
 
         const algoTx = await buildTransactionPayload(account, transaction);
 
-        const toSign = await encodeToSign(algoTx);
+        const toSign = encodeToSign(algoTx);
 
         const hwApp = new Algorand(transport);
         const { freshAddressPath } = account;
@@ -53,7 +53,7 @@ export const signOperation = ({
           throw new Error("No signature");
         }
 
-        const toBroadcast = await encodeToBroadcast(algoTx, signature);
+        const toBroadcast = encodeToBroadcast(algoTx, signature);
 
         const operation = buildOptimisticOperation(account, transaction);
 

package/src/families/algorand/js-synchronization.ts

@@ -291,6 +291,7 @@ const getAccountShape: GetAccountShape = async (
 
   const shape = {
     id: accountId,
+    xpub: address,
     blockHeight: round,
     balance,
     spendableBalance,

package/src/families/bitcoin/js-signOperation.ts

@@ -32,7 +32,7 @@ const signOperation = ({
       try {
         log("hw", `signTransaction ${currency.id} for account ${account.id}`);
         const txInfo = await buildTransaction(account, transaction);
-        let senders: string[] = [];
+        let senders = new Set<string>();
         let recipients: string[] = [];
         let fee = new BigNumber(0);
         // Maybe better not re-calculate these fields here, instead include them
@@ -41,9 +41,7 @@ const signOperation = ({
           account,
           transaction,
         }).then((res) => {
-          senders = res.txInputs
-            .map((i) => i.address)
-            .filter(Boolean) as string[];
+          senders = new Set(res.txInputs.map((i) => i.address).filter(Boolean));
           recipients = res.txOutputs
             .filter((o) => o.address && !o.isChange)
             .map((o) => o.address) as string[];
@@ -140,7 +138,7 @@ const signOperation = ({
           fee,
           blockHash: null,
           blockHeight: null,
-          senders,
+          senders: Array.from(senders),
           recipients,
           accountId: account.id,
           date: new Date(),

package/src/families/bitcoin/wallet-btc/crypto/base.ts

@@ -84,14 +84,22 @@ class Base implements ICrypto {
   }
 
   // derive legacy address at account and index positions
-  getLegacyAddress(xpub: string, account: number, index: number): string {
+  protected getLegacyAddress(
+    xpub: string,
+    account: number,
+    index: number
+  ): string {
     const publicKeyBuffer: Buffer = this.getPubkeyAt(xpub, account, index);
     const publicKeyHash160: Buffer = bjs.crypto.hash160(publicKeyBuffer);
     return bjs.address.toBase58Check(publicKeyHash160, this.network.pubKeyHash);
   }
 
   // derive native SegWit at account and index positions
-  getNativeSegWitAddress(xpub: string, account: number, index: number): string {
+  private getNativeSegWitAddress(
+    xpub: string,
+    account: number,
+    index: number
+  ): string {
     const publicKeyBuffer: Buffer = this.getPubkeyAt(xpub, account, index);
     const publicKeyHash160: Buffer = bjs.crypto.hash160(publicKeyBuffer);
     const words: number[] = bech32.toWords(publicKeyHash160);
@@ -100,7 +108,11 @@ class Base implements ICrypto {
   }
 
   // derive SegWit at account and index positions
-  getSegWitAddress(xpub: string, account: number, index: number): string {
+  private getSegWitAddress(
+    xpub: string,
+    account: number,
+    index: number
+  ): string {
     const publicKeyBuffer: Buffer = this.getPubkeyAt(xpub, account, index);
     const redeemOutput: Buffer = bjs.script.compile([
       0,
@@ -129,28 +141,29 @@ class Base implements ICrypto {
         `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
       ];
     }
+    const res = this.customGetAddress(derivationMode, xpub, account, index);
+    Base.addressCache[
+      `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
+    ] = res;
+    return res;
+  }
+
+  customGetAddress(
+    derivationMode: string,
+    xpub: string,
+    account: number,
+    index: number
+  ): string {
     switch (derivationMode) {
       case DerivationModes.LEGACY:
-        Base.addressCache[
-          `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-        ] = this.getLegacyAddress(xpub, account, index);
-        break;
+        return this.getLegacyAddress(xpub, account, index);
       case DerivationModes.SEGWIT:
-        Base.addressCache[
-          `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-        ] = this.getSegWitAddress(xpub, account, index);
-        break;
+        return this.getSegWitAddress(xpub, account, index);
       case DerivationModes.NATIVE_SEGWIT:
-        Base.addressCache[
-          `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-        ] = this.getNativeSegWitAddress(xpub, account, index);
-        break;
+        return this.getNativeSegWitAddress(xpub, account, index);
       default:
         throw new Error(`Invalid derivation Mode: ${derivationMode}`);
     }
-    return Base.addressCache[
-      `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-    ];
   }
 
   // infer address type from its syntax