@ledgerhq/live-common 21.30.1 → 21.32.2

package/src/__tests__/families/bitcoin/wallet-btc/xpub.getAddress.ts

@@ -0,0 +1,47 @@
+import { DerivationModes } from "../../../../families/bitcoin/wallet-btc";
+import BitcoinLikeStorage from "../../../../families/bitcoin/wallet-btc/storage";
+import BitcoinLikeExplorer from "../../../../families/bitcoin/wallet-btc/explorer";
+import Xpub from "../../../../families/bitcoin/wallet-btc/xpub";
+import coininfo from "coininfo";
+import BCHCrypto from "../../../../families/bitcoin/wallet-btc/crypto/bitcoincash";
+import BTCCrypto from "../../../../families/bitcoin/wallet-btc/crypto/bitcoin";
+
+describe("Unit tests for getAddress", () => {
+  it("Test getAddress for bch and btc", async () => {
+    const bchCrypto = new BCHCrypto({
+      network: coininfo.bitcoincash.main.toBitcoinJS(),
+    });
+    const btcCrypto = new BTCCrypto({
+      network: coininfo.bitcoin.main.toBitcoinJS(),
+    });
+    const bchxpub = new Xpub({
+      storage: new BitcoinLikeStorage(),
+      explorer: new BitcoinLikeExplorer({
+        explorerURI: "https://explorers.api.vault.ledger.com/blockchain/v3/bch",
+        explorerVersion: "v3",
+      }),
+      crypto: bchCrypto,
+      xpub: "xpub6BtWBf3Pu6hYwJBKvEwG7JtrTxxDrSGy39HaTgZz6GTSaFWFdoCtuEXSQtoKGaYdz1emg8xTXKYwjhu3xXRPzFnYS1z4yjKj7hLDQyNeDZr",
+      derivationMode: DerivationModes.LEGACY,
+    });
+    await bchxpub.syncAddress(0, 0);
+    let addresses = await bchxpub.getXpubAddresses();
+    expect(addresses[0].address).toEqual(
+      "bitcoincash:qrgwhfg7tn4xs9pg2vu5rhkud490j9yfnqd63uk64m"
+    );
+
+    const btcxpub = new Xpub({
+      storage: new BitcoinLikeStorage(),
+      explorer: new BitcoinLikeExplorer({
+        explorerURI: "https://explorers.api.vault.ledger.com/blockchain/v3/btc",
+        explorerVersion: "v3",
+      }),
+      crypto: btcCrypto,
+      xpub: "xpub6BtWBf3Pu6hYwJBKvEwG7JtrTxxDrSGy39HaTgZz6GTSaFWFdoCtuEXSQtoKGaYdz1emg8xTXKYwjhu3xXRPzFnYS1z4yjKj7hLDQyNeDZr",
+      derivationMode: DerivationModes.LEGACY,
+    });
+    await btcxpub.syncAddress(0, 0);
+    addresses = await btcxpub.getXpubAddresses();
+    expect(addresses[0].address).toEqual("1L3fqoWstvLqEA6TgXkuLoXX8xG1xhirG3");
+  }, 60000);
+});

package/src/__tests__/families/bitcoin/wallet-btc/xpub.pickingStrategies.integration.test.ts

@@ -67,7 +67,6 @@ describe("testing xpub legacy transactions", () => {
             output_index: 0,
             value: "5000000000",
             address: "mwXTtHo8Yy3aNKUUZLkBDrTcKT9qG9TqLb",
-            script_hex: "76a914af9ab6987aa41b37c8bcb7c61154165d23f09e3488ac",
             output_hash:
               "9e1b337875c21f751e70ee2c2c6ee93d8a6733d0f3ba6d139ae6a0479ebcefb0",
             block_height: 1,
@@ -77,8 +76,6 @@ describe("testing xpub legacy transactions", () => {
             output_index: 1,
             value: "0",
             address: "<unknown>",
-            script_hex:
-              "6a24aa21a9ede2f61c3f71d1defd3fa999dfa36953755c690689799962b48bebd836974e8cf9",
             output_hash:
               "9e1b337875c21f751e70ee2c2c6ee93d8a6733d0f3ba6d139ae6a0479ebcefb0",
             block_height: 1,
@@ -112,7 +109,6 @@ describe("testing xpub legacy transactions", () => {
             output_index: 0,
             value: "300000000",
             address: "mwXTtHo8Yy3aNKUUZLkBDrTcKT9qG9TqLb",
-            script_hex: "76a914af9ab6987aa41b37c8bcb7c61154165d23f09e3488ac",
             output_hash:
               "0b9f98d07eb418fa20573112d3cba6b871d429a06c724a7888ff0886be5213d1",
             block_height: 120,
@@ -122,7 +118,6 @@ describe("testing xpub legacy transactions", () => {
             output_index: 1,
             value: "4699983200",
             address: "2MynSTpze5SDcuLr1DekSV7RVrFpQCo3LeP",
-            script_hex: "a91447b810238a31777fc4e4de474419464c46aadf8187",
             output_hash:
               "0b9f98d07eb418fa20573112d3cba6b871d429a06c724a7888ff0886be5213d1",
             block_height: 120,
@@ -209,7 +204,6 @@ describe("testing xpub legacy transactions", () => {
             output_index: 0,
             value: "4599966400",
             address: "2NCSYYp4bWdHDYf9nYP1NDKb1GMBqa8e57H",
-            script_hex: "a914d28e7592fc2657433296eafc89e4a8d29289ebf087",
             output_hash:
               "8f30fe84da5a5846d668b4bad260730f2b0125fa66fb2633fa1cee23c6b11053",
             block_height: 122,
@@ -219,7 +213,6 @@ describe("testing xpub legacy transactions", () => {
             output_index: 1,
             value: "100000000",
             address: "mwXTtHo8Yy3aNKUUZLkBDrTcKT9qG9TqLb",
-            script_hex: "76a914af9ab6987aa41b37c8bcb7c61154165d23f09e3488ac",
             output_hash:
               "8f30fe84da5a5846d668b4bad260730f2b0125fa66fb2633fa1cee23c6b11053",
             block_height: 122,
@@ -253,7 +246,6 @@ describe("testing xpub legacy transactions", () => {
             output_index: 0,
             value: "4399949600",
             address: "2NFToPiLBtuKiqzZj43nPXknN8d4xNySe3o",
-            script_hex: "a914f3b3a49bd90e6e9ae30882a2b7e9b7edfe579a8c87",
             output_hash:
               "2f90f3312ffd4dce490cb2f7429c586a43ef68c99fc2f8e549127b72af7b4209",
             block_height: 123,
@@ -263,7 +255,6 @@ describe("testing xpub legacy transactions", () => {
             output_index: 1,
             value: "200000000",
             address: "mwXTtHo8Yy3aNKUUZLkBDrTcKT9qG9TqLb",
-            script_hex: "76a914af9ab6987aa41b37c8bcb7c61154165d23f09e3488ac",
             output_hash:
               "2f90f3312ffd4dce490cb2f7429c586a43ef68c99fc2f8e549127b72af7b4209",
             block_height: 123,
@@ -297,7 +288,6 @@ describe("testing xpub legacy transactions", () => {
             output_index: 0,
             value: "600000000",
             address: "mwXTtHo8Yy3aNKUUZLkBDrTcKT9qG9TqLb",
-            script_hex: "76a914af9ab6987aa41b37c8bcb7c61154165d23f09e3488ac",
             output_hash:
               "2fee0c4b55e08583aa5bc565d7e428f7cdcbd2b73262f62208a6a72a74e2c945",
             block_height: 124,
@@ -307,7 +297,6 @@ describe("testing xpub legacy transactions", () => {
             output_index: 1,
             value: "3799932800",
             address: "2N53XuFRxqbShpK4XKwC1VXT4zu1wCzbAMU",
-            script_hex: "a914816b7896ce2c4f21c39c865030fe07e7a042a9c687",
             output_hash:
               "2fee0c4b55e08583aa5bc565d7e428f7cdcbd2b73262f62208a6a72a74e2c945",
             block_height: 124,

package/src/__tests__/test-helpers/setup.ts

@@ -56,4 +56,5 @@ setSupportedCurrencies([
   "crypto_org",
   "filecoin",
   "solana",
+  "celo",
 ]);

package/src/account/support.ts

@@ -21,6 +21,7 @@ import { getAccountBridge } from "../bridge";
 import jsBridges from "../generated/bridge/js";
 
 const experimentalIntegrations = ["algorand", "tezos"];
+
 export function shouldUseJS(currency: CryptoCurrency) {
   const jsBridge = jsBridges[currency.family];
   if (!jsBridge) return false;

package/src/api/Ethereum.ts

@@ -138,6 +138,7 @@ export const apiForCurrency = (currency: CryptoCurrency): API => {
             noinput: true,
             no_input: true,
             no_token: true,
+            filtering: true,
             block_hash,
           },
         }),

package/src/apps/polyfill.ts

@@ -53,6 +53,7 @@ export const whitelistDependencies = ["Decred", "Decred Testnet"];
   ["POAP", "Ethereum"],
   ["OlympusDAO", "Ethereum"],
   ["Rarible", "Ethereum"],
+  ["Ricochet", "Ethereum"],
 ].forEach(([name, dep]) => declareDep(name, dep));
 export const getDependencies = (appName: string): string[] =>
   directDep[appName] || [];

package/src/bot/engine.ts

@@ -81,6 +81,9 @@ export async function runWithAppSpec<T extends Transaction>(
   const mutationReports: MutationReport<T>[] = [];
   const { appQuery, currency, dependency } = spec;
   const appCandidate = findAppCandidate(appCandidates, appQuery);
+  if (!appCandidate) {
+    console.warn("no app found for " + spec.name, { appQuery, appCandidates });
+  }
   invariant(
     appCandidate,
     "%s: no app found. Are you sure your COINAPPS is up to date?",
@@ -401,7 +404,7 @@ export async function runOnAccount<T extends Transaction>({
       }
     }
 
-    // without recovering mecanism, we simply assume an error is a failure
+    // without recovering mechanism, we simply assume an error is a failure
     if (errors.length) {
       throw errors[0];
     }

package/src/bridge/jsHelpers.ts

@@ -97,7 +97,7 @@ Operation[] {
   newOps.forEach((op) => {
     newOpsIds[op.id] = op;
   });
-  // return existins when there is no real new operations
+  // return existing when there is no real new operations
   if (newOps.length === 0) return existing;
   // edge case, existing can be empty. return the sorted list.
   if (existing.length === 0) return Object.values(newOpsIds);

package/src/data/icons/react/celo.tsx

@@ -0,0 +1,12 @@
+
+      import * as React from "react";
+interface Props {
+            size: number;
+            color?: string;
+          };
+
+function celo({size, color = "currentColor"}: Props) {
+  return <svg width={size} height={size} viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M10.1053 19.1053C12.9834 19.1053 15.3158 16.7728 15.3158 13.8947C15.3158 11.0166 12.9834 8.68421 10.1053 8.68421C7.22716 8.68421 4.89474 11.0166 4.89474 13.8947C4.89474 16.7728 7.22716 19.1053 10.1053 19.1053ZM10.1053 21C6.18126 21 3 17.8187 3 13.8947C3 9.97074 6.18126 6.78947 10.1053 6.78947C14.0293 6.78947 17.2105 9.97074 17.2105 13.8947C17.2105 17.8187 14.0293 21 10.1053 21Z" fill={color} /><path d="M13.8947 15.3158C16.7728 15.3158 19.1053 12.9834 19.1053 10.1053C19.1053 7.22716 16.7728 4.89474 13.8947 4.89474C11.0166 4.89474 8.68421 7.22716 8.68421 10.1053C8.68421 12.9834 11.0166 15.3158 13.8947 15.3158ZM13.8947 17.2105C9.97074 17.2105 6.78947 14.0293 6.78947 10.1053C6.78947 6.18126 9.97074 3 13.8947 3C17.8187 3 21 6.18126 21 10.1053C21 14.0293 17.8187 17.2105 13.8947 17.2105Z" fill={color} /><path d="M14.1297 17.2105C14.6223 16.6137 14.9747 15.9145 15.1623 15.1623C15.9126 14.9747 16.6118 14.6223 17.2105 14.1297C17.184 14.9994 16.9964 15.8558 16.6573 16.6592C15.8558 16.9964 14.9994 17.184 14.1297 17.2105ZM8.83768 8.83768C8.08737 9.02526 7.38821 9.37768 6.78947 9.87032C6.816 9.00063 7.00358 8.14421 7.34274 7.34274C8.14421 7.00547 9.00253 6.81789 9.87032 6.78947C9.37768 7.38632 9.02526 8.08547 8.83768 8.83768Z" fill={color} /></svg>;
+}
+
+export default celo;

package/src/data/icons/react/index.tsx

@@ -78,6 +78,7 @@ export { default as call } from "./call";
 export { default as cc } from "./cc";
 export { default as cdn } from "./cdn";
 export { default as cdt } from "./cdt";
+export { default as celo } from "./celo";
 export { default as cenz } from "./cenz";
 export { default as chain } from "./chain";
 export { default as chat } from "./chat";

package/src/data/icons/reactNative/celo.tsx

@@ -0,0 +1,13 @@
+
+      import * as React from "react";
+import Svg, { Path } from "react-native-svg";
+interface Props {
+              size: number;
+              color: string;
+            };
+
+function celo({ size, color }: Props) {
+  return <Svg width={size} height={size} viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"><Path d="M10.1053 19.1053C12.9834 19.1053 15.3158 16.7728 15.3158 13.8947C15.3158 11.0166 12.9834 8.68421 10.1053 8.68421C7.22716 8.68421 4.89474 11.0166 4.89474 13.8947C4.89474 16.7728 7.22716 19.1053 10.1053 19.1053ZM10.1053 21C6.18126 21 3 17.8187 3 13.8947C3 9.97074 6.18126 6.78947 10.1053 6.78947C14.0293 6.78947 17.2105 9.97074 17.2105 13.8947C17.2105 17.8187 14.0293 21 10.1053 21Z" fill={color} /><Path d="M13.8947 15.3158C16.7728 15.3158 19.1053 12.9834 19.1053 10.1053C19.1053 7.22716 16.7728 4.89474 13.8947 4.89474C11.0166 4.89474 8.68421 7.22716 8.68421 10.1053C8.68421 12.9834 11.0166 15.3158 13.8947 15.3158ZM13.8947 17.2105C9.97074 17.2105 6.78947 14.0293 6.78947 10.1053C6.78947 6.18126 9.97074 3 13.8947 3C17.8187 3 21 6.18126 21 10.1053C21 14.0293 17.8187 17.2105 13.8947 17.2105Z" fill={color} /><Path d="M14.1297 17.2105C14.6223 16.6137 14.9747 15.9145 15.1623 15.1623C15.9126 14.9747 16.6118 14.6223 17.2105 14.1297C17.184 14.9994 16.9964 15.8558 16.6573 16.6592C15.8558 16.9964 14.9994 17.184 14.1297 17.2105ZM8.83768 8.83768C8.08737 9.02526 7.38821 9.37768 6.78947 9.87032C6.816 9.00063 7.00358 8.14421 7.34274 7.34274C8.14421 7.00547 9.00253 6.81789 9.87032 6.78947C9.37768 7.38632 9.02526 8.08547 8.83768 8.83768Z" fill={color} /></Svg>;
+}
+
+export default celo;

package/src/data/icons/reactNative/index.tsx

@@ -78,6 +78,7 @@ export { default as call } from "./call";
 export { default as cc } from "./cc";
 export { default as cdn } from "./cdn";
 export { default as cdt } from "./cdt";
+export { default as celo } from "./celo";
 export { default as cenz } from "./cenz";
 export { default as chain } from "./chain";
 export { default as chat } from "./chat";

package/src/data/icons/svg/CELO.svg

@@ -0,0 +1,5 @@
+<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path d="M10.1053 19.1053C12.9834 19.1053 15.3158 16.7728 15.3158 13.8947C15.3158 11.0166 12.9834 8.68421 10.1053 8.68421C7.22716 8.68421 4.89474 11.0166 4.89474 13.8947C4.89474 16.7728 7.22716 19.1053 10.1053 19.1053ZM10.1053 21C6.18126 21 3 17.8187 3 13.8947C3 9.97074 6.18126 6.78947 10.1053 6.78947C14.0293 6.78947 17.2105 9.97074 17.2105 13.8947C17.2105 17.8187 14.0293 21 10.1053 21Z" fill="#42D689"/>
+<path d="M13.8947 15.3158C16.7728 15.3158 19.1053 12.9834 19.1053 10.1053C19.1053 7.22716 16.7728 4.89474 13.8947 4.89474C11.0166 4.89474 8.68421 7.22716 8.68421 10.1053C8.68421 12.9834 11.0166 15.3158 13.8947 15.3158ZM13.8947 17.2105C9.97074 17.2105 6.78947 14.0293 6.78947 10.1053C6.78947 6.18126 9.97074 3 13.8947 3C17.8187 3 21 6.18126 21 10.1053C21 14.0293 17.8187 17.2105 13.8947 17.2105Z" fill="#42D689"/>
+<path d="M14.1297 17.2105C14.6223 16.6137 14.9747 15.9145 15.1623 15.1623C15.9126 14.9747 16.6118 14.6223 17.2105 14.1297C17.184 14.9994 16.9964 15.8558 16.6573 16.6592C15.8558 16.9964 14.9994 17.184 14.1297 17.2105ZM8.83768 8.83768C8.08737 9.02526 7.38821 9.37768 6.78947 9.87032C6.816 9.00063 7.00358 8.14421 7.34274 7.34274C8.14421 7.00547 9.00253 6.81789 9.87032 6.78947C9.37768 7.38632 9.02526 8.08547 8.83768 8.83768Z" fill="#42D689"/>
+</svg>

package/src/env.ts

@@ -40,6 +40,16 @@ const envDefinitions = {
     parser: stringParser,
     desc: "Node API endpoint for algorand",
   },
+  API_CELO_INDEXER: {
+    def: "https://celo.coin.ledger.com/indexer/",
+    parser: stringParser,
+    desc: "Explorer API for celo",
+  },
+  API_CELO_NODE: {
+    def: "https://celo.coin.ledger.com/archive/",
+    parser: stringParser,
+    desc: "Node endpoint for celo",
+  },
   API_COSMOS_BLOCKCHAIN_EXPLORER_API_ENDPOINT: {
     def: "https://cosmoshub4.coin.ledger.com/",
     parser: stringParser,

package/src/exchange/platform/transfer/index.ts

@@ -32,7 +32,27 @@ const fundProviders: Record<
     curve: string;
   }
 > = {
-  // FIXME: no prod provider for now
+  baanx: {
+    /**
+     * nameAndPubkey is the concatenation of:
+     * - an empty buffer of the size of the partner name
+     * - a buffer created from the partner name string in ascii encoding
+     * - a buffer created from the hexadecimal version of the partner public key
+     */
+    nameAndPubkey: Buffer.concat([
+      Buffer.from([5]),
+      Buffer.from("Baanx", "ascii"),
+      Buffer.from(
+        "04551878b446b6a711949fa51cc5a8685602f8ffb1dfd08f6ab869019d7c125d7737a79e8b5022d860ec7dfbe062d510fec3b5fe0f6ebb1f5e55a074bb7e5dbc4e",
+        "hex"
+      ),
+    ]),
+    signature: Buffer.from(
+      "304402200345c39e93a22c5ac3f1e70f8b9938b3a60d3a4906067443cf11095af0e685a502201ee5d88dd5539ce36341e49e2505c2a1659e26d8ff08801ed33c50a9126aedd1",
+      "hex"
+    ),
+    curve: "secp256r1",
+  },
 };
 
 const getProvider = (

package/src/families/algorand/buildTransaction.ts

@@ -1,6 +1,5 @@
 import { encode as msgpackEncode } from "algo-msgpack-with-bigint";
 import type {
-  SuggestedParams as AlgoSuggestedParams,
   Transaction as AlgoTransaction,
   EncodedTransaction as AlgoTransactionPayload,
   EncodedSignedTransaction as AlgoSignedTransactionPayload,
@@ -28,8 +27,7 @@ export const buildTransactionPayload = async (
 
   const note = memo ? new TextEncoder().encode(memo) : undefined;
 
-  // Minor hack: cast the result as a algosdk.SuggestedParams, while it's actually a TransactionParametersResponse
-  const params = (await getTransactionParams()) as AlgoSuggestedParams;
+  const params = await getTransactionParams();
 
   let algoTxn: AlgoTransaction;
   if (subAccount || (assetId && mode === "optIn")) {
@@ -78,18 +76,16 @@ export const buildTransactionPayload = async (
   return sorted;
 };
 
-export const encodeToSign = async (
-  payload: AlgoTransactionPayload
-): Promise<string> => {
+export const encodeToSign = (payload: AlgoTransactionPayload): string => {
   const msgPackEncoded = msgpackEncode(payload);
 
   return Buffer.from(msgPackEncoded).toString("hex");
 };
 
-export const encodeToBroadcast = async (
+export const encodeToBroadcast = (
   payload: AlgoTransactionPayload,
   signature: Buffer
-): Promise<Buffer> => {
+): Buffer => {
   const signedPayload: AlgoSignedTransactionPayload = {
     sig: signature,
     txn: payload,

package/src/families/algorand/js-getFeesForTransaction.ts

@@ -17,7 +17,7 @@ export const getEstimatedFees = async (
   let suggestedFees = 0;
   if (params.fee) {
     const payload = await buildTransactionPayload(account, transaction);
-    const encoded = await encodeToSign(payload);
+    const encoded = encodeToSign(payload);
     suggestedFees =
       params.fee * (Buffer.from(encoded, "hex").length + SINGLE_SIGNATURE_SIZE);
   }

package/src/families/algorand/js-signOperation.ts

@@ -36,7 +36,7 @@ export const signOperation = ({
 
         const algoTx = await buildTransactionPayload(account, transaction);
 
-        const toSign = await encodeToSign(algoTx);
+        const toSign = encodeToSign(algoTx);
 
         const hwApp = new Algorand(transport);
         const { freshAddressPath } = account;
@@ -53,7 +53,7 @@ export const signOperation = ({
           throw new Error("No signature");
         }
 
-        const toBroadcast = await encodeToBroadcast(algoTx, signature);
+        const toBroadcast = encodeToBroadcast(algoTx, signature);
 
         const operation = buildOptimisticOperation(account, transaction);
 

package/src/families/algorand/js-synchronization.ts

@@ -291,6 +291,7 @@ const getAccountShape: GetAccountShape = async (
 
   const shape = {
     id: accountId,
+    xpub: address,
     blockHeight: round,
     balance,
     spendableBalance,

package/src/families/bitcoin/js-signOperation.ts

@@ -32,7 +32,7 @@ const signOperation = ({
       try {
         log("hw", `signTransaction ${currency.id} for account ${account.id}`);
         const txInfo = await buildTransaction(account, transaction);
-        let senders: string[] = [];
+        let senders = new Set<string>();
         let recipients: string[] = [];
         let fee = new BigNumber(0);
         // Maybe better not re-calculate these fields here, instead include them
@@ -41,9 +41,7 @@ const signOperation = ({
           account,
           transaction,
         }).then((res) => {
-          senders = res.txInputs
-            .map((i) => i.address)
-            .filter(Boolean) as string[];
+          senders = new Set(res.txInputs.map((i) => i.address).filter(Boolean));
           recipients = res.txOutputs
             .filter((o) => o.address && !o.isChange)
             .map((o) => o.address) as string[];
@@ -140,7 +138,7 @@ const signOperation = ({
           fee,
           blockHash: null,
           blockHeight: null,
-          senders,
+          senders: Array.from(senders),
           recipients,
           accountId: account.id,
           date: new Date(),

package/src/families/bitcoin/js-synchronisation.ts

@@ -100,7 +100,7 @@ const mapTxToOperations = (
   const blockHeight = tx.block?.height;
   const blockHash = tx.block?.hash;
   const date = new Date(tx.block?.time || tx.received_at);
-  const senders: string[] = [];
+  const senders = new Set<string>();
   const recipients: string[] = [];
   let type: OperationType = "OUT";
   let value = new BigNumber(0);
@@ -111,7 +111,7 @@ const mapTxToOperations = (
 
   for (const input of tx.inputs) {
     if (input.address) {
-      senders.push(
+      senders.add(
         syncReplaceAddress ? syncReplaceAddress(input.address) : input.address
       );
 
@@ -195,7 +195,7 @@ const mapTxToOperations = (
       type,
       value,
       fee,
-      senders,
+      senders: Array.from(senders),
       recipients,
       blockHeight,
       blockHash,
@@ -229,7 +229,7 @@ const mapTxToOperations = (
         type,
         value,
         fee,
-        senders,
+        senders: Array.from(senders),
         recipients,
         blockHeight,
         blockHash,

package/src/families/bitcoin/wallet-btc/crypto/base.ts

@@ -84,14 +84,22 @@ class Base implements ICrypto {
   }
 
   // derive legacy address at account and index positions
-  getLegacyAddress(xpub: string, account: number, index: number): string {
+  protected getLegacyAddress(
+    xpub: string,
+    account: number,
+    index: number
+  ): string {
     const publicKeyBuffer: Buffer = this.getPubkeyAt(xpub, account, index);
     const publicKeyHash160: Buffer = bjs.crypto.hash160(publicKeyBuffer);
     return bjs.address.toBase58Check(publicKeyHash160, this.network.pubKeyHash);
   }
 
   // derive native SegWit at account and index positions
-  getNativeSegWitAddress(xpub: string, account: number, index: number): string {
+  private getNativeSegWitAddress(
+    xpub: string,
+    account: number,
+    index: number
+  ): string {
     const publicKeyBuffer: Buffer = this.getPubkeyAt(xpub, account, index);
     const publicKeyHash160: Buffer = bjs.crypto.hash160(publicKeyBuffer);
     const words: number[] = bech32.toWords(publicKeyHash160);
@@ -100,7 +108,11 @@ class Base implements ICrypto {
   }
 
   // derive SegWit at account and index positions
-  getSegWitAddress(xpub: string, account: number, index: number): string {
+  private getSegWitAddress(
+    xpub: string,
+    account: number,
+    index: number
+  ): string {
     const publicKeyBuffer: Buffer = this.getPubkeyAt(xpub, account, index);
     const redeemOutput: Buffer = bjs.script.compile([
       0,
@@ -129,28 +141,29 @@ class Base implements ICrypto {
         `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
       ];
     }
+    const res = this.customGetAddress(derivationMode, xpub, account, index);
+    Base.addressCache[
+      `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
+    ] = res;
+    return res;
+  }
+
+  customGetAddress(
+    derivationMode: string,
+    xpub: string,
+    account: number,
+    index: number
+  ): string {
     switch (derivationMode) {
       case DerivationModes.LEGACY:
-        Base.addressCache[
-          `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-        ] = this.getLegacyAddress(xpub, account, index);
-        break;
+        return this.getLegacyAddress(xpub, account, index);
       case DerivationModes.SEGWIT:
-        Base.addressCache[
-          `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-        ] = this.getSegWitAddress(xpub, account, index);
-        break;
+        return this.getSegWitAddress(xpub, account, index);
       case DerivationModes.NATIVE_SEGWIT:
-        Base.addressCache[
-          `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-        ] = this.getNativeSegWitAddress(xpub, account, index);
-        break;
+        return this.getNativeSegWitAddress(xpub, account, index);
       default:
         throw new Error(`Invalid derivation Mode: ${derivationMode}`);
     }
-    return Base.addressCache[
-      `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-    ];
   }
 
   // infer address type from its syntax

package/src/families/bitcoin/wallet-btc/crypto/bitcoin.ts

@@ -119,31 +119,17 @@ class Bitcoin extends Base {
   }
 
   // get address given an address type
-  getAddress(
+  customGetAddress(
     derivationMode: string,
     xpub: string,
     account: number,
     index: number
   ): string {
-    if (
-      Base.addressCache[
-        `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-      ]
-    ) {
-      return Base.addressCache[
-        `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-      ];
-    }
     switch (derivationMode) {
       case DerivationModes.TAPROOT:
-        Base.addressCache[
-          `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-        ] = this.getTaprootAddress(xpub, account, index);
-        return Base.addressCache[
-          `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-        ];
+        return this.getTaprootAddress(xpub, account, index);
       default:
-        return super.getAddress(derivationMode, xpub, account, index);
+        return super.customGetAddress(derivationMode, xpub, account, index);
     }
   }
 

package/src/families/bitcoin/wallet-btc/crypto/bitcoincash.ts

@@ -1,73 +1,44 @@
-// Fix the "More than one instance of bitcore-lib-cash" issue. Refer to https://github.com/bitpay/bitcore/issues/1457
-delete global._bitcoreCash;
-import * as bch from "bitcore-lib-cash";
 import bchaddr from "bchaddrjs";
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
 import { toOutputScript } from "bitcoinjs-lib/src/address";
 import { InvalidAddress } from "@ledgerhq/errors";
 import { DerivationModes } from "../types";
-import { ICrypto } from "./types";
 import Base from "./base";
 
 // a mock explorer class that just use js objects
-class BitcoinCash implements ICrypto {
+class BitcoinCash extends Base {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   network: any;
 
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   constructor({ network }: { network: any }) {
+    super({ network });
     this.network = network;
     this.network.dustThreshold = 5430;
     this.network.dustPolicy = "FIXED";
     this.network.usesTimestampedTransaction = false;
   }
 
-  // Based on https://github.com/go-faast/bitcoin-cash-payments/blob/54397eb97c7a9bf08b32e10bef23d5f27aa5ab01/index.js#L63-L73
   // eslint-disable-next-line
   getLegacyBitcoinCashAddress(
     xpub: string,
     account: number,
     index: number
   ): string {
-    const node = new bch.HDPublicKey(xpub);
-    const child = node.derive(account).derive(index);
-    const address = new bch.Address(child.publicKey, bch.Networks.livenet);
-    const addrstr = address.toString().split(":");
-    if (addrstr.length === 2) {
-      return bchaddr.toCashAddress(bchaddr.toLegacyAddress(addrstr[1]));
-    }
-    throw new Error(`Unable to derive cash address for ${address}`);
+    return bchaddr.toCashAddress(super.getLegacyAddress(xpub, account, index));
   }
 
   // get address given an address type
-  getAddress(
+  customGetAddress(
     derivationMode: string,
     xpub: string,
     account: number,
     index: number
   ): string {
-    if (
-      Base.addressCache[
-        `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-      ]
-    ) {
-      return Base.addressCache[
-        `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-      ];
-    }
-    const address = this.getLegacyBitcoinCashAddress(xpub, account, index);
-    Base.addressCache[
-      `${this.network.name}-${derivationMode}-${xpub}-${account}-${index}`
-    ] = address;
-    return address;
+    return this.getLegacyBitcoinCashAddress(xpub, account, index);
   }
 
-  // infer address type from its syntax
-  //
-  // TODO: improve the prefix matching: make the expected prefix
-  // correspond to the actual type (currently, a `ltc1` prefix
-  // could match a native Bitcoin address type for instance)
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   getDerivationMode(address: string) {
     return DerivationModes.LEGACY;
@@ -85,11 +56,6 @@ class BitcoinCash implements ICrypto {
   validateAddress(address: string): boolean {
     return bchaddr.isValidAddress(address);
   }
-
-  // eslint-disable-next-line
-  isTaprootAddress(address: string): boolean {
-    return false;
-  }
 }
 
 export default BitcoinCash;