@ledgerhq/live-common 21.29.0 → 21.32.0-hotfix.0

package/src/families/celo/js-signOperation.ts

@@ -0,0 +1,149 @@
+import { BigNumber } from "bignumber.js";
+import { Observable } from "rxjs";
+import { FeeNotLoaded } from "@ledgerhq/errors";
+import type { Transaction } from "./types";
+import type { Account, Operation, SignOperationEvent } from "../../types";
+import { encodeOperationId } from "../../operation";
+import { CeloApp } from "./hw-app-celo";
+import buildTransaction from "./js-buildTransaction";
+import { rlpEncodedTx, encodeTransaction } from "@celo/wallet-base";
+import { tokenInfoByAddressAndChainId } from "@celo/wallet-ledger/lib/tokens";
+import { withDevice } from "../../hw/deviceAccess";
+
+const buildOptimisticOperation = (
+  account: Account,
+  transaction: Transaction,
+  fee: BigNumber
+): Operation => {
+  const type = "OUT";
+
+  const value = new BigNumber(transaction.amount).plus(fee);
+
+  const operation: Operation = {
+    id: encodeOperationId(account.id, "", type),
+    hash: "",
+    type,
+    value,
+    fee,
+    blockHash: null,
+    blockHeight: null,
+    senders: [account.freshAddress],
+    recipients: [transaction.recipient].filter(Boolean),
+    accountId: account.id,
+    date: new Date(),
+    extra: { additionalField: transaction.amount },
+  };
+
+  return operation;
+};
+
+const trimLeading0x = (input: string) =>
+  input.startsWith("0x") ? input.slice(2) : input;
+
+const parseSigningResponse = (
+  response: {
+    s: string;
+    v: string;
+    r: string;
+  },
+  chainId: number
+): {
+  s: Buffer;
+  v: number;
+  r: Buffer;
+} => {
+  // EIP155
+  const sigV = parseInt(response.v, 16);
+  let eip155V = chainId * 2 + 35;
+  if (sigV !== eip155V && (sigV & eip155V) !== sigV) {
+    eip155V += 1;
+  }
+
+  return {
+    s: Buffer.from(response.s, "hex"),
+    v: eip155V,
+    r: Buffer.from(response.r, "hex"),
+  };
+};
+
+/**
+ * Sign Transaction with Ledger hardware
+ */
+const signOperation = ({
+  account,
+  deviceId,
+  transaction,
+}: {
+  account: Account;
+  deviceId: any;
+  transaction: Transaction;
+}): Observable<SignOperationEvent> =>
+  withDevice(deviceId)(
+    (transport) =>
+      new Observable((o) => {
+        let cancelled;
+
+        async function main() {
+          if (!transaction.fees) {
+            throw new FeeNotLoaded();
+          }
+
+          const celo = new CeloApp(transport);
+          const unsignedTransaction = await buildTransaction(
+            account,
+            transaction
+          );
+          const { chainId, to } = unsignedTransaction;
+          const rlpEncodedTransaction = rlpEncodedTx(unsignedTransaction);
+
+          const tokenInfo = tokenInfoByAddressAndChainId(to!, chainId!);
+          if (tokenInfo) {
+            await celo.provideERC20TokenInformation(tokenInfo);
+          }
+
+          o.next({ type: "device-signature-requested" });
+
+          const response = await celo.signTransaction(
+            account.freshAddressPath,
+            trimLeading0x(rlpEncodedTransaction.rlpEncode)
+          );
+
+          if (cancelled) return;
+
+          const signature = parseSigningResponse(response, chainId!);
+
+          o.next({ type: "device-signature-granted" });
+
+          const encodedTransaction = await encodeTransaction(
+            rlpEncodedTransaction,
+            signature
+          );
+
+          const operation = buildOptimisticOperation(
+            account,
+            transaction,
+            transaction.fees ?? new BigNumber(0)
+          );
+
+          o.next({
+            type: "signed",
+            signedOperation: {
+              operation,
+              signature: encodedTransaction.raw,
+              expirationDate: null,
+            },
+          });
+        }
+
+        main().then(
+          () => o.complete(),
+          (e) => o.error(e)
+        );
+
+        return () => {
+          cancelled = true;
+        };
+      })
+  );
+
+export default signOperation;

package/src/families/celo/js-synchronisation.ts

@@ -0,0 +1,40 @@
+import type { Account } from "../../types";
+import { encodeAccountId } from "../../account";
+import type { GetAccountShape } from "../../bridge/jsHelpers";
+import { makeSync, makeScanAccounts, mergeOps } from "../../bridge/jsHelpers";
+import { getAccountDetails } from "./api";
+
+const getAccountShape: GetAccountShape = async (info) => {
+  const { address, currency, initialAccount, derivationMode } = info;
+  const oldOperations = initialAccount?.operations || [];
+
+  const accountId = encodeAccountId({
+    type: "js",
+    version: "2",
+    currencyId: currency.id,
+    xpubOrAddress: address,
+    derivationMode,
+  });
+  const {
+    blockHeight,
+    balance,
+    spendableBalance,
+    operations: newOperations,
+  } = await getAccountDetails(address, accountId);
+  const operations = mergeOps(oldOperations, newOperations);
+  const shape = {
+    id: accountId,
+    balance,
+    spendableBalance,
+    operationsCount: operations.length,
+    blockHeight,
+  };
+  return { ...shape, operations };
+};
+
+const postSync = (_initial: Account, parent: Account) => {
+  return parent;
+};
+
+export const scanAccounts = makeScanAccounts(getAccountShape);
+export const sync = makeSync(getAccountShape, postSync);

package/src/families/celo/specs.ts

@@ -0,0 +1,53 @@
+import invariant from "invariant";
+import type { Transaction } from "./types";
+import { getCryptoCurrencyById, parseCurrencyUnit } from "../../currencies";
+import { pickSiblings } from "../../bot/specs";
+import type { AppSpec } from "../../bot/types";
+import { DeviceModelId } from "@ledgerhq/devices";
+
+const currency = getCryptoCurrencyById("celo");
+const minimalAmount = parseCurrencyUnit(currency.units[0], "0.001");
+const maxAccount = 3;
+
+const celo: AppSpec<Transaction> = {
+  name: "Celo",
+  currency,
+  appQuery: {
+    model: DeviceModelId.nanoS,
+    appName: "Celo",
+  },
+  testTimeout: 2 * 60 * 1000,
+  mutations: [
+    {
+      name: "move 50% to another account",
+      maxRun: 2,
+      transaction: ({ account, siblings, bridge, maxSpendable }) => {
+        invariant(maxSpendable.gt(minimalAmount), "balance is too low");
+        const sibling = pickSiblings(siblings, maxAccount);
+        const recipient = sibling.freshAddress;
+        const amount = maxSpendable.div(2).integerValue();
+        return {
+          transaction: bridge.createTransaction(account),
+          updates: [{ recipient }, { amount }],
+        };
+      },
+    },
+    {
+      name: "send max to another account",
+      maxRun: 1,
+      transaction: ({ account, siblings, bridge, maxSpendable }) => {
+        invariant(maxSpendable.gt(minimalAmount), "balance is too low");
+        const sibling = pickSiblings(siblings, maxAccount);
+        const recipient = sibling.freshAddress;
+        return {
+          transaction: bridge.createTransaction(account),
+          updates: [{ recipient }, { useAllAmount: true }],
+        };
+      },
+    },
+  ],
+};
+
+export default {
+  celo,
+};

package/src/families/celo/speculos-deviceActions.ts

@@ -0,0 +1,50 @@
+import type { DeviceAction } from "../../bot/types";
+import type { Transaction } from "./types";
+import { deviceActionFlow } from "../../bot/specs";
+import { formatCurrencyUnit } from "../../currencies";
+const acceptTransaction: DeviceAction<Transaction, any> = deviceActionFlow({
+  steps: [
+    {
+      title: "Review",
+      button: "Rr",
+    },
+    {
+      title: "Amount",
+      button: "Rr",
+      expectedValue: ({ account, status }) => {
+        const formattedValue =
+          "CELO " +
+          formatCurrencyUnit(account.unit, status.amount, {
+            disableRounding: true,
+          });
+
+        if (!formattedValue.includes(".")) {
+          // if the value is pure integer, in the app it will automatically add an .0
+          return formattedValue + ".0";
+        }
+
+        return formattedValue;
+      },
+    },
+    {
+      title: "Address",
+      button: "Rr",
+      expectedValue: ({ transaction }) => transaction.recipient,
+    },
+    {
+      title: "Max Fees",
+      button: "Rr",
+    },
+    {
+      title: "No Gateway Fee",
+      button: "Rr",
+    },
+    {
+      title: "Accept",
+      button: "LRlr",
+    },
+  ],
+});
+export default {
+  acceptTransaction,
+};

package/src/families/celo/transaction.ts

@@ -0,0 +1,39 @@
+import type { Transaction, TransactionRaw } from "./types";
+import { BigNumber } from "bignumber.js";
+import {
+  fromTransactionCommonRaw,
+  toTransactionCommonRaw,
+} from "../../transaction/common";
+import type { Account } from "../../types";
+import { getAccountUnit } from "../../account";
+import { formatCurrencyUnit } from "../../currencies";
+export const formatTransaction = (t: Transaction, account: Account): string => `
+SEND ${formatCurrencyUnit(getAccountUnit(account), t.amount, {
+  showCode: true,
+  disableRounding: true,
+})}
+TO ${t.recipient}`;
+
+const fromTransactionRaw = (tr: TransactionRaw): Transaction => {
+  const common = fromTransactionCommonRaw(tr);
+  return {
+    ...common,
+    family: tr.family,
+    fees: tr.fees ? new BigNumber(tr.fees) : null,
+  };
+};
+
+export const toTransactionRaw = (t: Transaction): TransactionRaw => {
+  const common = toTransactionCommonRaw(t);
+  return {
+    ...common,
+    family: t.family,
+    fees: t.fees?.toString() || null,
+  };
+};
+
+export default {
+  formatTransaction,
+  fromTransactionRaw,
+  toTransactionRaw,
+};

package/src/families/celo/types.ts

@@ -0,0 +1,20 @@
+import { BigNumber } from "bignumber.js";
+import type {
+  TransactionCommon,
+  TransactionCommonRaw,
+} from "../../types/transaction";
+
+export type Transaction = TransactionCommon & {
+  family: "celo";
+  fees: BigNumber | null | undefined;
+};
+export type TransactionRaw = TransactionCommonRaw & {
+  family: "celo";
+  fees: string | null | undefined;
+};
+
+export type CoreStatics = Record<string, never>;
+export type CoreAccountSpecifics = Record<string, never>;
+export type CoreOperationSpecifics = Record<string, never>;
+export type CoreCurrencySpecifics = Record<string, never>;
+export const reflect = (_declare: any) => {};

package/src/families/ethereum/datasets/ethereum.scanAccounts.1.ts

@@ -1,5 +1,6 @@
 export default {
   name: "ethereum seed 1",
+  unstableAccounts: true, // FIXME LL-9155
   apdus: `
     => e00200000d038000002c8000003c80000000
     <= 410469877df9567b58e6ef8f6cf1fb8a8e1bf28a327dee31b183a6b9cd1f3da063af0924506a9912793ef31e41df19f8653fa31bb1fecc32d2e41abdddb22ccb621028373561453661383832363036353137343345356546433033373937313136413335363539663638359000

package/src/families/ethereum/modules/erc1155.ts

@@ -14,6 +14,9 @@ import { prepareTransaction } from "./erc721";
 const notOwnedNft = createCustomErrorClass("NotOwnedNft");
 const notEnoughNftOwned = createCustomErrorClass("NotEnoughNftOwned");
 const notTokenIdsProvided = createCustomErrorClass("NotTokenIdsProvided");
+const quantityNeedsToBePositive = createCustomErrorClass(
+  "QuantityNeedsToBePositive"
+);
 
 export type Modes = "erc1155.transfer";
 
@@ -43,6 +46,12 @@ const erc1155Transfer: ModeModule = {
         result.errors.amount = new NotEnoughBalanceInParentAccount();
       }
 
+      t.quantities?.forEach((quantity) => {
+        if (quantity.isLessThan(1)) {
+          result.errors.amount = new quantityNeedsToBePositive();
+        }
+      });
+
       const enoughTokensOwned: true | Error =
         t.tokenIds?.reduce((acc, tokenId, index) => {
           if (acc instanceof Error) {

package/src/families/ethereum/signOperation.ts

@@ -2,6 +2,7 @@ import invariant from "invariant";
 import { Observable, from, of } from "rxjs";
 import { mergeMap } from "rxjs/operators";
 import eip55 from "eip55";
+import { encode } from "rlp";
 import { BigNumber } from "bignumber.js";
 import { log } from "@ledgerhq/logs";
 import { FeeNotLoaded } from "@ledgerhq/errors";
@@ -17,6 +18,7 @@ import { modes } from "./modules";
 import { isNFTActive } from "../../nft";
 import { getEnv } from "../../env";
 import { LoadConfig } from "@ledgerhq/hw-app-eth/lib/services/types";
+import { Transaction as EthereumTx } from "@ethereumjs/tx";
 export const signOperation = ({
   account,
   deviceId,
@@ -54,18 +56,16 @@ export const signOperation = ({
                 throw new FeeNotLoaded();
               }
 
-              const { tx, fillTransactionDataResult } = buildEthereumTx(
-                account,
-                transaction,
-                nonce
-              );
-              const to = eip55.encode("0x" + tx.to.toString("hex"));
+              const { ethTxObject, tx, common, fillTransactionDataResult } =
+                buildEthereumTx(account, transaction, nonce);
+              const to = eip55.encode((tx.to || "").toString());
               const value = new BigNumber(
                 "0x" + (tx.value.toString("hex") || "0")
               );
-
-              const txHex = tx.serialize().toString("hex");
-
+              // rawData Format: `rlp([nonce, gasPrice, gasLimit, to, value, data, v, r, s])`
+              const rawData = tx.raw();
+              rawData[6] = Buffer.from([common.chainIdBN().toNumber()]);
+              const txHex = Buffer.from(encode(rawData)).toString("hex");
               const loadConfig: LoadConfig = {};
               if (isNFTActive(account.currency)) {
                 loadConfig.nftExplorerBaseURL =
@@ -106,26 +106,27 @@ export const signOperation = ({
                 }
               }
 
-              o.next({
-                type: "device-signature-requested",
-              });
+              o.next({ type: "device-signature-requested" });
               const result = await eth.signTransaction(
                 freshAddressPath,
                 txHex,
                 resolution
               );
               if (cancelled) return;
-              o.next({
-                type: "device-signature-granted",
-              });
+              o.next({ type: "device-signature-granted" });
               // Second, we re-set some tx fields from the device signature
-              const v = result.v;
+              const v = `0x${result.v}`;
+              const r = `0x${result.r}`;
+              const s = `0x${result.s}`;
+
+              const signedTx = new EthereumTx(
+                { ...ethTxObject, v, r, s },
+                { common }
+              );
 
-              tx.v = Buffer.from(v, "hex");
-              tx.r = Buffer.from(result.r, "hex");
-              tx.s = Buffer.from(result.s, "hex");
               // Generate the signature ready to be broadcasted
-              const signature = `0x${tx.serialize().toString("hex")}`;
+              const signature = `0x${signedTx.serialize().toString("hex")}`;
+
               // build optimistic operation
               const txHash = ""; // resolved at broadcast time
 

package/src/families/ethereum/specs.ts

@@ -118,7 +118,6 @@ const ethereum: AppSpec<Transaction> = {
   appQuery: {
     model: DeviceModelId.nanoS,
     appName: "Ethereum",
-    appVersion: "1.5.0-rc3",
   },
   testTimeout: 4 * 60 * 1000,
   transactionCheck: ({ maxSpendable }) => {
@@ -380,7 +379,6 @@ const ethereumRopsten: AppSpec<Transaction> = {
   appQuery: {
     model: DeviceModelId.nanoS,
     appName: "Ethereum",
-    appVersion: "1.5.0-rc3",
   },
   testTimeout: 2 * 60 * 1000,
   transactionCheck: ({ maxSpendable }) => {

package/src/families/ethereum/transaction.ts

@@ -6,8 +6,8 @@ import type {
   TransactionRaw,
   EthereumGasLimitRequest,
 } from "./types";
-import Common from "ethereumjs-common";
-import { Transaction as EthereumTx } from "ethereumjs-tx";
+import Common from "@ethereumjs/common";
+import { Transaction as EthereumTx } from "@ethereumjs/tx";
 import eip55 from "eip55";
 import {
   InvalidAddress,
@@ -196,23 +196,18 @@ function getEthereumjsTxCommon(currency) {
     `currency ${currency.id} did not set ethereumLikeInfo`
   );
   if (ethereumLikeInfo.chainId === 1) {
-    return new Common(
-      // $FlowFixMe
-      ethereumLikeInfo.baseChain || "mainnet",
-      // $FlowFixMe
-      ethereumLikeInfo.hardfork || "petersburg"
-    );
+    return new Common({
+      chain: ethereumLikeInfo.baseChain || "mainnet",
+      hardfork: ethereumLikeInfo.hardfork || "petersburg",
+    });
   }
   return Common.forCustomChain(
-    // $FlowFixMe
     ethereumLikeInfo.baseChain || "mainnet",
     {
       name: currency.ticker,
       chainId: ethereumLikeInfo.chainId,
-      // $FlowFixMe
       networkId: ethereumLikeInfo.networkId || ethereumLikeInfo.chainId,
     },
-    // $FlowFixMe
     ethereumLikeInfo.hardfork || "petersburg"
   );
 }
@@ -239,8 +234,6 @@ export function buildEthereumTx(
     "only token accounts expected"
   );
   const common = getEthereumjsTxCommon(currency);
-  invariant(common, `common not found for currency ${currency.name}`);
-  // FIXME: make sure it doesn't break
   if (!common) {
     throw new Error(`common not found for currency ${currency.name}`);
   }
@@ -258,18 +251,11 @@ export function buildEthereumTx(
     ethTxObject
   );
   log("ethereum", "buildEthereumTx", ethTxObject);
-  const tx = new EthereumTx(ethTxObject, {
-    common,
-  });
-  // these will be filled by device signature
-  tx.raw[6] = Buffer.from([common.chainId()]); // v
-
-  tx.raw[7] = Buffer.from([]); // r
-
-  tx.raw[8] = Buffer.from([]); // s
-
+  const tx = new EthereumTx(ethTxObject, { common });
   return {
     tx,
+    common,
+    ethTxObject,
     fillTransactionDataResult,
   };
 }
@@ -294,7 +280,7 @@ export function inferEthereumGasLimitRequest(
     }
 
     if (to) {
-      r.to = "0x" + to.toString("hex");
+      r.to = to.toString();
     }
 
     if (data) {

package/src/families/polkadot/cache.ts

@@ -87,7 +87,7 @@ export const getTransactionParams: CacheRes<
 );
 
 /**
- * Cache the payment info (fee estimate), with a hash deending on fees-changing transaction params and tx size.
+ * Cache the payment info (fee estimate), with a hash depending on fees-changing transaction params and tx size.
  *
  * @param {Account} arg1.a
  * @param {Transaction} arg1.t

package/src/families/solana/api/chain/index.ts

@@ -4,8 +4,6 @@ import {
   TOKEN_PROGRAM_ID,
 } from "@solana/spl-token";
 import {
-  Cluster,
-  clusterApiUrl,
   Connection,
   FeeCalculator,
   PublicKey,
@@ -15,7 +13,7 @@ import {
 import { Awaited } from "../../logic";
 
 export type Config = {
-  readonly cluster: Cluster;
+  readonly endpoint: string;
 };
 
 export type ChainAPI = Readonly<{
@@ -60,8 +58,7 @@ export type ChainAPI = Readonly<{
 }>;
 
 export function getChainAPI(config: Config): ChainAPI {
-  const connection = () =>
-    new Connection(clusterApiUrl(config.cluster), "finalized");
+  const connection = () => new Connection(config.endpoint, "finalized");
 
   return {
     getBalance: (address: string) =>

package/src/families/solana/bridge/bridge.ts

@@ -22,7 +22,7 @@ import { broadcastWithAPI } from "../js-broadcast";
 import { prepareTransaction as prepareTransactionWithAPI } from "../js-prepareTransaction";
 import { ChainAPI, Config } from "../api";
 import { makeLRUCache } from "../../../cache";
-import { clusterByCurrencyId } from "../utils";
+import { endpointByCurrencyId } from "../utils";
 import { minutes, seconds } from "../api/cached";
 import hash from "object-hash";
 import BigNumber from "bignumber.js";
@@ -32,8 +32,8 @@ function makePrepare(getChainAPI: (config: Config) => Promise<ChainAPI>) {
     mainAccount: Account,
     transaction: Transaction
   ) {
-    const config = {
-      cluster: clusterByCurrencyId(mainAccount.currency.id),
+    const config: Config = {
+      endpoint: endpointByCurrencyId(mainAccount.currency.id),
     };
 
     const chainAPI = await getChainAPI(config);
@@ -61,8 +61,8 @@ function makePrepare(getChainAPI: (config: Config) => Promise<ChainAPI>) {
 
 function makeSyncAndScan(getChainAPI: (config: Config) => Promise<ChainAPI>) {
   const getAccountShape: GetAccountShape = async (info) => {
-    const config = {
-      cluster: clusterByCurrencyId(info.currency.id),
+    const config: Config = {
+      endpoint: endpointByCurrencyId(info.currency.id),
     };
 
     const chainAPI = await getChainAPI(config);
@@ -91,8 +91,8 @@ function makeEstimateMaxSpendable(
       throw new Error("currency not found");
     }
 
-    const config = {
-      cluster: clusterByCurrencyId(currencyId),
+    const config: Config = {
+      endpoint: endpointByCurrencyId(currencyId),
     };
 
     const api = await getChainAPI(config);
@@ -110,8 +110,8 @@ function makeBroadcast(
   getChainAPI: (config: Config) => Promise<ChainAPI>
 ): BroadcastFnSignature {
   return async (info) => {
-    const config = {
-      cluster: clusterByCurrencyId(info.account.currency.id),
+    const config: Config = {
+      endpoint: endpointByCurrencyId(info.account.currency.id),
     };
     const api = await getChainAPI(config);
     return broadcastWithAPI(info, api);
@@ -122,8 +122,8 @@ function makeSign(
   getChainAPI: (config: Config) => Promise<ChainAPI>
 ): SignOperationFnSignature<Transaction> {
   return (info) => {
-    const config = {
-      cluster: clusterByCurrencyId(info.account.currency.id),
+    const config: Config = {
+      endpoint: endpointByCurrencyId(info.account.currency.id),
     };
     const api = () => getChainAPI(config);
     return signOperationWithAPI(info, api);

package/src/families/solana/bridge/js.ts

@@ -5,19 +5,19 @@ import { minutes } from "../api/cached";
 
 const getAPI = makeLRUCache(
   (config: Config) => Promise.resolve(getChainAPI(config)),
-  (config) => config.cluster,
+  (config) => config.endpoint,
   minutes(1000)
 );
 
 const getQueuedAPI = makeLRUCache(
   (config: Config) => getAPI(config).then((api) => queued(api, 100)),
-  (config) => config.cluster,
+  (config) => config.endpoint,
   minutes(1000)
 );
 
 const getQueuedAndCachedAPI = makeLRUCache(
   (config: Config) => getQueuedAPI(config).then(cached),
-  (config) => config.cluster,
+  (config) => config.endpoint,
   minutes(1000)
 );