@ledgerhq/live-common 21.24.0-beta.0 → 21.25.2

package/src/families/polkadot/js-getTransactionStatus.ts

@@ -58,7 +58,9 @@ const getSendTransactionStatus = async (
   } else if (a.freshAddress === t.recipient) {
     errors.recipient = new InvalidAddressBecauseDestinationIsAlsoSource();
   } else if (!isValidAddress(t.recipient)) {
-    errors.recipient = new InvalidAddress("");
+    errors.recipient = new InvalidAddress("", {
+      currencyName: a.currency.name,
+    });
   }
 
   const estimatedFees = t.fees || new BigNumber(0);
@@ -181,7 +183,9 @@ const getTransactionStatus = async (a: Account, t: Transaction) => {
         if (!t.recipient) {
           errors.recipient = new RecipientRequired("");
         } else if (!isValidAddress(t.recipient)) {
-          errors.recipient = new InvalidAddress("");
+          errors.recipient = new InvalidAddress("", {
+            currencyName: a.currency.name,
+          });
         } else if (await isControllerAddress(t.recipient)) {
           errors.recipient = new PolkadotUnauthorizedOperation(
             "Recipient is already a controller"

package/src/families/tezos/bridge/js.ts

@@ -182,11 +182,14 @@ const prepareTransaction = async (
     },
   });
 
+  const t: Transaction = { ...transaction, taquitoError: null };
+
+  let amount = transaction.amount;
   if (transaction.useAllAmount) {
     // taquito does not accept 0, so we do 1
     // only failing case is when the account precisely has fees + 1. which is
     // unlikely
-    transaction.amount = new BigNumber(1);
+    amount = new BigNumber(1);
   }
 
   try {
@@ -196,7 +199,7 @@ const prepareTransaction = async (
         out = await tezos.estimate.transfer({
           mutez: true,
           to: transaction.recipient,
-          amount: transaction.amount.toNumber(),
+          amount: amount.toNumber(),
         });
         break;
       case "delegate":
@@ -214,7 +217,7 @@ const prepareTransaction = async (
         throw new Error("unsupported mode=" + transaction.mode);
     }
 
-    if (transaction.useAllAmount) {
+    if (t.useAllAmount) {
       const totalFees = out.suggestedFeeMutez + out.burnFeeMutez;
       const maxAmount = account.balance
         .minus(totalFees + (tezosResources.revealed ? 0 : DEFAULT_FEE.REVEAL))
@@ -228,41 +231,59 @@ const prepareTransaction = async (
         return gasBuffer * MINIMAL_FEE_PER_GAS_MUTEZ + opSize;
       };
       const incr = increasedFee(gasBuffer, Number(out.opSize));
-      transaction.fees = new BigNumber(out.suggestedFeeMutez + incr);
-      transaction.gasLimit = new BigNumber(out.gasLimit + gasBuffer);
-      transaction.amount = new BigNumber(maxAmount - incr);
+      t.fees = new BigNumber(out.suggestedFeeMutez + incr);
+      t.gasLimit = new BigNumber(out.gasLimit + gasBuffer);
+      t.amount = new BigNumber(maxAmount - incr);
     } else {
-      transaction.fees = new BigNumber(out.suggestedFeeMutez);
-      transaction.gasLimit = new BigNumber(out.gasLimit);
-      transaction.storageLimit = new BigNumber(out.storageLimit);
+      t.fees = new BigNumber(out.suggestedFeeMutez);
+      t.gasLimit = new BigNumber(out.gasLimit);
+      t.storageLimit = new BigNumber(out.storageLimit);
     }
 
-    transaction.storageLimit = new BigNumber(out.storageLimit);
-    transaction.estimatedFees = transaction.fees;
+    t.storageLimit = new BigNumber(out.storageLimit);
+    t.estimatedFees = t.fees;
     if (!tezosResources.revealed) {
-      transaction.estimatedFees = transaction.estimatedFees.plus(
-        DEFAULT_FEE.REVEAL
-      );
+      t.estimatedFees = t.estimatedFees.plus(DEFAULT_FEE.REVEAL);
     }
   } catch (e) {
     if (typeof e !== "object" || !e) throw e;
     if ("id" in e) {
-      transaction.taquitoError = (e as { id: string }).id;
+      t.taquitoError = (e as { id: string }).id;
     } else if ("status" in e) {
       // in case of http 400, log & ignore (more case to handle)
       log(
         "taquito-network-error",
         String((e as { message: string }).message || ""),
-        { transaction }
+        { transaction: t }
       );
     } else {
       throw e;
     }
   }
 
-  return transaction;
+  // nothing changed
+  if (
+    bnEq(t.fees, transaction.fees) &&
+    bnEq(t.fees, transaction.fees) &&
+    bnEq(t.gasLimit, transaction.gasLimit) &&
+    bnEq(t.amount, transaction.amount) &&
+    bnEq(t.storageLimit, transaction.storageLimit) &&
+    bnEq(t.estimatedFees, transaction.estimatedFees) &&
+    t.taquitoError === transaction.taquitoError
+  ) {
+    return transaction;
+  }
+
+  return t;
 };
 
+function bnEq(
+  a: BigNumber | null | undefined,
+  b: BigNumber | null | undefined
+): boolean {
+  return !a && !b ? true : !a || !b ? false : a.eq(b);
+}
+
 const estimateMaxSpendable = async ({
   account,
   parentAccount,

package/src/generated/deviceTransactionConfig.ts

@@ -4,6 +4,8 @@ import bitcoin from "../families/bitcoin/deviceTransactionConfig";
 
 import cosmos from "../families/cosmos/deviceTransactionConfig";
 
+import crypto_org from "../families/crypto_org/deviceTransactionConfig";
+
 import elrond from "../families/elrond/deviceTransactionConfig";
 
 import ethereum from "../families/ethereum/deviceTransactionConfig";
@@ -25,6 +27,7 @@ export default {
   algorand,
   bitcoin,
   cosmos,
+  crypto_org,
   elrond,
   ethereum,
   polkadot,

package/src/hw/actions/transaction.ts

@@ -17,7 +17,7 @@ import { getMainAccount } from "../../account";
 import { getAccountBridge } from "../../bridge";
 import type { ConnectAppEvent, Input as ConnectAppInput } from "../connectApp";
 import type { Action, Device } from "./types";
-import type { AppState } from "./app";
+import type { AppRequest, AppState } from "./app";
 import { createAction as createAppAction } from "./app";
 type State = {
   signedOperation: SignedOperation | null | undefined;
@@ -33,6 +33,8 @@ type TransactionRequest = {
   transaction: Transaction;
   status: TransactionStatus;
   appName?: string;
+  dependencies?: AppRequest[];
+  requireLatestFirmware?: boolean;
 };
 type TransactionResult =
   | {
@@ -112,7 +114,8 @@ export const createAction = (
     reduxDevice: Device | null | undefined,
     txRequest: TransactionRequest
   ): TransactionState => {
-    const { transaction, appName } = txRequest;
+    const { transaction, appName, dependencies, requireLatestFirmware } =
+      txRequest;
     const mainAccount = getMainAccount(
       txRequest.account,
       txRequest.parentAccount
@@ -120,6 +123,8 @@ export const createAction = (
     const appState = createAppAction(connectAppExec).useHook(reduxDevice, {
       account: mainAccount,
       appName,
+      dependencies,
+      requireLatestFirmware,
     });
     const { device, opened, inWrongDeviceForAccount, error } = appState;
     const [state, setState] = useState(initialState);