@ledgerhq/live-common 21.16.1 → 21.17.0

package/src/__tests__/families/bitcoin/wallet-btc/utils.test.ts

@@ -1,6 +1,9 @@
-import { bech32m, bech32, BechLib } from "bech32";
+import * as bech32 from "bech32";
+import { bech32m } from "../../../../families/bitcoin/bech32m";
 import * as utils from "../../../../families/bitcoin/wallet-btc/utils";
 import { Currency } from "../../../../families/bitcoin/wallet-btc/crypto/types";
+import cryptoFactory from "../../../../families/bitcoin/wallet-btc/crypto/factory";
+import { DerivationModes } from "../../../../families/bitcoin/wallet-btc";
 
 function validateAddrs(
   addresses: string[],
@@ -16,7 +19,8 @@ function toBech32(
   data: Buffer,
   version: number,
   prefix: string,
-  bech32variant: BechLib
+  //bech32variant: BechLib // FIXME Restore this
+  bech32variant: any
 ): string {
   const words = bech32.toWords(data);
   words.unshift(version);
@@ -208,3 +212,106 @@ describe("Unit tests for various utils functions", () => {
     validateAddrs(["S6NMcEfYbavHrP3Uo1wbEUvKhAbKeMugaa"], "stealthcoin", false);
   });
 });
+
+describe("Unit tests for maxTxSize", () => {
+  const btc = cryptoFactory("bitcoin_testnet");
+  it("Empty tx non-segwit", () => {
+    const s = utils.maxTxSizeCeil(0, [], false, btc, DerivationModes.LEGACY);
+    expect(s).toEqual(10);
+  });
+  it("Empty tx segwit", () => {
+    const s = utils.maxTxSizeCeil(
+      0,
+      [],
+      false,
+      btc,
+      DerivationModes.NATIVE_SEGWIT
+    );
+    expect(s).toEqual(11);
+  });
+  it("1 p2wpkh input 1 p2wpkh output", () => {});
+
+  const tr = "tb1pdedptfps5k6hmzars9ks93ejsujh28kw5dhe06gutt9svap40j8qql2dw2";
+  const sh = "2Mv9bnjkBUr1GfCybJc7XmnJ5VG4SAT3shT";
+  const pkh = "mkQiYQGCkCC7Wus3vfhfTDjgJzQK554evn";
+  const wpkh = "tb1qhff3j7euu6t3lv8s5gsy9t5x82wuhfw5z863gj";
+  const p2tr = DerivationModes.TAPROOT;
+  const p2sh = DerivationModes.SEGWIT;
+  const p2pkh = DerivationModes.LEGACY;
+  const p2wpkh = DerivationModes.NATIVE_SEGWIT;
+
+  test.each([
+    // In 148 out 34
+    [0, [], false, p2pkh, 10],
+    [0, [], true, p2pkh, 44],
+    [0, [pkh], false, p2pkh, 44],
+    [0, [pkh], true, p2pkh, 78],
+    [1, [pkh], true, p2pkh, 226],
+    [2, [pkh], true, p2pkh, 374],
+    [1, [wpkh], true, p2pkh, 223],
+    [1, [sh], true, p2pkh, 224],
+    [1, [tr], true, p2pkh, 235],
+
+    // In 68 out 31
+    [0, [], false, p2wpkh, 11],
+    [0, [], true, p2wpkh, 42],
+    [1, [], false, p2wpkh, 79],
+    [1, [], true, p2wpkh, 110],
+    [2, [], true, p2wpkh, 178],
+
+    // In 90 out 32, scriptSig 22
+    [0, [], false, p2sh, 11],
+    [0, [], true, p2sh, 43],
+    [1, [], false, p2sh, 101],
+    [1, [sh], false, p2sh, 133],
+    [2, [sh], false, p2sh, 223],
+
+    // Fixed 10.5 In 57.75 out 43
+    [0, [], false, p2tr, 11],
+    [0, [], true, p2tr, 54],
+    [1, [], true, p2tr, Math.ceil(53.5 + 57.75 * 1)],
+    [2, [], true, p2tr, Math.ceil(53.5 + 57.75 * 2)],
+    [3, [], true, p2tr, Math.ceil(53.5 + 57.75 * 3)],
+
+    // 0xfc=252 inputs
+    [247, [], true, p2tr, Math.ceil(53.5 + 57.75 * 247)],
+    [248, [], true, p2tr, Math.ceil(53.5 + 57.75 * 248)],
+    [249, [], true, p2tr, Math.ceil(53.5 + 57.75 * 249)],
+    [250, [], true, p2tr, Math.ceil(53.5 + 57.75 * 250)],
+    [251, [], true, p2tr, Math.ceil(53.5 + 57.75 * 251)],
+    [252, [], true, p2tr, Math.ceil(53.5 + 57.75 * 252)],
+    // 0xfd=253 inputs will add 2 bytes for >= 0xfd
+    [253, [], true, p2tr, Math.ceil(53.5 + 57.75 * 253 + 2)],
+    [
+      256 * 256 - 1,
+      [],
+      true,
+      p2tr,
+      Math.ceil(53.5 + 57.75 * (256 * 256 - 1) + 2),
+    ],
+    // 0xffff inputs will add 4 bytes
+    [256 * 256, [], true, p2tr, Math.ceil(53.5 + 57.75 * (256 * 256) + 4)],
+
+    // test address with witness version 16 and witness program [0x01, 0x02] => tb1sqypqyuzpgh
+    [
+      2,
+      [tr, sh, pkh, wpkh, "tb1sqypqyuzpgh"],
+      false,
+      p2wpkh,
+      Math.ceil(10.5 + 68 * 2 + 43 + 32 + 34 + 31 + 13),
+    ],
+  ])(
+    "%i, %s, %s, %s => %i",
+    (inputCount, outputAddrs, useChange, derivationMode, exp) => {
+      const s = utils.maxTxSizeCeil(
+        inputCount,
+        outputAddrs,
+        useChange,
+        btc,
+        derivationMode
+      );
+      //const s = utils.estimateTxSize(inputCount, outputAddrs.length + (useChange ? 1 : 0), btc, derivationMode);
+      expect(s).toEqual(exp);
+    }
+  );
+});

package/src/__tests__/families/bitcoin/wallet-btc/wallet.estimateMaxSpendable.test.ts

@@ -57,9 +57,10 @@ describe("testing estimateMaxSpendable", () => {
     expect(maxSpendable.toNumber()).toEqual(
       balance -
         feesPerByte *
-          utils.estimateTxSize(
+          utils.maxTxSizeCeil(
             2,
-            1,
+            [],
+            true,
             account.xpub.crypto,
             account.xpub.derivationMode
           )

package/src/__tests__/families/bitcoin/wallet-btc/wallet.integration.test.ts

@@ -63,7 +63,7 @@ describe("testing wallet", () => {
       fromAccount: account,
       txInfo,
     });
-    expect(tx).toEqual("d6154bba4915d07453bb09d4fa02d62e975b4475");
+    expect(Buffer.from(tx, "hex")).toHaveLength(20);
   });
 
   it("should allow to build a transaction splitting outputs", async () => {
@@ -87,7 +87,7 @@ describe("testing wallet", () => {
       fromAccount: account,
       txInfo,
     });
-    expect(tx).toEqual("d922a70d6a66b96cdaba4565270a21f97eb23a6d");
+    expect(Buffer.from(tx, "hex")).toHaveLength(20);
   });
 
   it("should throw during sync if there is an error in explorer", async () => {

package/src/__tests__/families/bitcoin/wallet-btc/xpub.pickingStrategies.integration.test.ts

@@ -3,7 +3,10 @@ import * as bip39 from "bip39";
 import * as bitcoin from "bitcoinjs-lib";
 import coininfo from "coininfo";
 import BigNumber from "bignumber.js";
-import { DerivationModes } from "../../../../families/bitcoin/wallet-btc/types";
+import {
+  DerivationModes,
+  OutputInfo,
+} from "../../../../families/bitcoin/wallet-btc/types";
 import Xpub from "../../../../families/bitcoin/wallet-btc/xpub";
 import BitcoinLikeExplorer from "../../../../families/bitcoin/wallet-btc/explorer";
 import Crypto from "../../../../families/bitcoin/wallet-btc/crypto/bitcoin";
@@ -42,6 +45,17 @@ describe("testing xpub legacy transactions", () => {
     xpub,
   };
 
+  function outputs(amount: number): OutputInfo[] {
+    return [
+      {
+        address: "mwXTtHo8Yy3aNKUUZLkBDrTcKT9qG9TqLb",
+        isChange: false,
+        script: Buffer.from([]),
+        value: new BigNumber(amount),
+      },
+    ];
+  }
+
   it("merge output strategy should be correct", async () => {
     // Initialize the xpub with 2 txs. So that it has 2 utxo
     dataset.xpub.storage.appendTxs([
@@ -134,17 +148,15 @@ describe("testing xpub legacy transactions", () => {
     );
     let res = await utxoPickingStrategy.selectUnspentUtxosToUse(
       dataset.xpub,
-      new BigNumber(10000),
-      0,
-      1
+      outputs(10000),
+      0
     );
     expect(res.unspentUtxos.length).toEqual(1); // only 1 utxo is enough
     expect(Number(res.unspentUtxos[0].value)).toEqual(300000000); // use cheaper utxo first
     res = await utxoPickingStrategy.selectUnspentUtxosToUse(
       dataset.xpub,
-      new BigNumber(500000000),
-      0,
-      1
+      outputs(500000000),
+      0
     );
     expect(res.unspentUtxos.length).toEqual(2); // need 2 utxo
     expect(
@@ -161,17 +173,15 @@ describe("testing xpub legacy transactions", () => {
     );
     let res = await utxoPickingStrategy.selectUnspentUtxosToUse(
       dataset.xpub,
-      new BigNumber(10000),
-      0,
-      1
+      outputs(10000),
+      0
     );
     expect(res.unspentUtxos.length).toEqual(1); // only 1 utxo is enough
     expect(Number(res.unspentUtxos[0].value)).toEqual(5000000000); // use old utxo first
     res = await utxoPickingStrategy.selectUnspentUtxosToUse(
       dataset.xpub,
-      new BigNumber(5200000000),
-      0,
-      1
+      outputs(5200000000),
+      0
     );
     expect(res.unspentUtxos.length).toEqual(2); // need 2 utxo
     expect(
@@ -323,45 +333,40 @@ describe("testing xpub legacy transactions", () => {
     );
     let res = await utxoPickingStrategy.selectUnspentUtxosToUse(
       dataset.xpub,
-      new BigNumber(10000),
-      10,
-      1
+      outputs(10000),
+      10
     );
     expect(res.unspentUtxos.length).toEqual(1);
     expect(Number(res.unspentUtxos[0].value)).toEqual(100000000);
 
     res = await utxoPickingStrategy.selectUnspentUtxosToUse(
       dataset.xpub,
-      new BigNumber(290000000),
-      10,
-      1
+      outputs(290000000),
+      10
     );
     expect(res.unspentUtxos.length).toEqual(1);
     expect(Number(res.unspentUtxos[0].value)).toEqual(300000000);
 
     res = await utxoPickingStrategy.selectUnspentUtxosToUse(
       dataset.xpub,
-      new BigNumber(500000000),
-      10,
-      1
+      outputs(500000000),
+      10
     );
     expect(res.unspentUtxos.length).toEqual(1);
     expect(Number(res.unspentUtxos[0].value)).toEqual(600000000);
 
     res = await utxoPickingStrategy.selectUnspentUtxosToUse(
       dataset.xpub,
-      new BigNumber(800000000),
-      10,
-      1
+      outputs(800000000),
+      10
     );
     expect(res.unspentUtxos.length).toEqual(1);
     expect(Number(res.unspentUtxos[0].value)).toEqual(5000000000);
 
     res = await utxoPickingStrategy.selectUnspentUtxosToUse(
       dataset.xpub,
-      new BigNumber(5000000000),
-      10,
-      1
+      outputs(5000000000),
+      10
     );
     expect(res.unspentUtxos.length).toEqual(2);
     expect(
@@ -370,9 +375,8 @@ describe("testing xpub legacy transactions", () => {
 
     res = await utxoPickingStrategy.selectUnspentUtxosToUse(
       dataset.xpub,
-      new BigNumber(5600000000),
-      10,
-      1
+      outputs(5600000000),
+      10
     );
     expect(res.unspentUtxos.length).toEqual(3);
     expect(

package/src/__tests__/families/bitcoin/wallet-btc/xpub.txs.NP2WPKH.integration.test.ts

@@ -178,9 +178,10 @@ describe.skip("testing xpub segwit transactions", () => {
     await xpubs[1].xpub.sync();
 
     expectedFee1 =
-      utils.estimateTxSize(
+      utils.maxTxSizeCeil(
         inputs.length,
-        outputs.length,
+        outputs.map((o) => o.address),
+        false,
         crypto,
         DerivationModes.SEGWIT
       ) * 100;

package/src/__tests__/families/bitcoin/wallet-btc/xpub.txs.P2WPKH.integration.test.ts

@@ -167,9 +167,10 @@ describe.skip("testing xpub native segwit transactions", () => {
     await xpubs[1].xpub.sync();
 
     expectedFee1 =
-      utils.estimateTxSize(
+      utils.maxTxSizeCeil(
         inputs.length,
-        outputs.length,
+        outputs.map((o) => o.address),
+        false,
         crypto,
         DerivationModes.NATIVE_SEGWIT
       ) * 100;

package/src/__tests__/families/bitcoin/wallet-btc/xpub.txs.integration.test.ts

@@ -148,9 +148,10 @@ describe.skip("testing xpub legacy transactions", () => {
     }
 
     expectedFee1 =
-      utils.estimateTxSize(
+      utils.maxTxSizeCeil(
         inputs.length,
-        outputs.length,
+        outputs.map((o) => o.address),
+        false,
         crypto,
         DerivationModes.LEGACY
       ) * 100;
@@ -280,9 +281,10 @@ describe.skip("testing xpub legacy transactions", () => {
     await xpubs[1].xpub.sync();
 
     expectedFee2 =
-      utils.estimateTxSize(
+      utils.maxTxSizeCeil(
         inputs.length,
-        outputs.length,
+        outputs.map((o) => o.address),
+        false,
         crypto,
         DerivationModes.LEGACY
       ) * 100;

package/src/apps/polyfill.ts

@@ -49,6 +49,9 @@ export const whitelistDependencies = ["Decred", "Decred Testnet"];
   ["Opensea", "Ethereum"],
   ["StakeDAO", "Ethereum"],
   ["Yearn", "Ethereum"],
+  ["RocketPool", "Ethereum"],
+  ["POAP", "Ethereum"],
+  ["OlympusDAO", "Ethereum"],
 ].forEach(([name, dep]) => declareDep(name, dep));
 export const getDependencies = (appName: string): string[] =>
   directDep[appName] || [];