@ledgerhq/live-common 21.14.1 → 21.16.2

package/src/currencies/sortByMarketcap.ts

@@ -81,7 +81,15 @@ export const getMarketcapTickers: () => Promise<string[]> = makeLRUCache(() =>
 export const useMarketcapTickers = (): string[] | null | undefined => {
   const [tickers, setMarketcapTickers] = useState(marketcapTickersCache);
   useEffect(() => {
-    getMarketcapTickers().then(setMarketcapTickers);
+    let isMounted = true;
+
+    getMarketcapTickers().then((data) => {
+      if (isMounted) setMarketcapTickers(data);
+    });
+
+    return () => {
+      isMounted = false;
+    };
   }, []);
   return tickers;
 };

package/src/currencies/support.ts

@@ -9,6 +9,7 @@ import {
   hasCryptoCurrencyId,
 } from "@ledgerhq/cryptoassets";
 import { getEnv } from "../env";
+
 // set by user side effect to precise which currencies are considered supported (typically by live)
 let userSupportedCurrencies: CryptoCurrency[] = [];
 let userSupportedFiats: FiatCurrency[] = [];

package/src/env.ts

@@ -376,6 +376,17 @@ const envDefinitions = {
     parser: stringParser,
     desc: "mock the server response for the exchange KYC check, options are 'open', 'pending', 'closed' or 'approved'.",
   },
+  NFT: {
+    def: false,
+    parser: boolParser,
+    desc: "synchronizing nfts",
+  },
+  NFT_ETH_METADATA_SERVICE: {
+    // FIXME LL-8001
+    def: "https://nft.staging.aws.ledger.fr/v1/ethereum/1/contracts/tokens/infos",
+    parser: stringParser,
+    desc: "service uri used to get the metadata of an nft",
+  },
   OPERATION_ADDRESSES_LIMIT: {
     def: 100,
     parser: intParser,

package/src/families/bitcoin/datasets/bitcoin.ts

@@ -28,6 +28,10 @@ const networkInfo: NetworkInfoRaw = {
   },
 };
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [scanAccounts1],
   accounts: [
     {

package/src/families/bitcoin/datasets/bitcoin_cash.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "bitcoin_cash seed 1",

package/src/families/bitcoin/datasets/bitcoin_gold.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "bitcoin_gold seed 1",

package/src/families/bitcoin/datasets/dash.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "dash seed 1",

package/src/families/bitcoin/datasets/decred.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "decred seed 1",

package/src/families/bitcoin/datasets/digibyte.ts

@@ -27,6 +27,10 @@ const networkInfo: NetworkInfoRaw = {
   },
 };
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [scanAccounts1],
   accounts: [
     {

package/src/families/bitcoin/datasets/dogecoin.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "dogecoin seed 1",

package/src/families/bitcoin/datasets/komodo.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "komodo seed 1",

package/src/families/bitcoin/datasets/litecoin.ts

@@ -27,6 +27,10 @@ const networkInfo: NetworkInfoRaw = {
   },
 };
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [scanAccounts1],
   accounts: [
     {

package/src/families/bitcoin/datasets/peercoin.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "peercoin seed 1",

package/src/families/bitcoin/datasets/pivx.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "pivx seed 1",

package/src/families/bitcoin/datasets/qtum.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "qtum seed 1",

package/src/families/bitcoin/datasets/stakenet.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "stakenet seed 1",

package/src/families/bitcoin/datasets/vertcoin.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "vertcoin seed 1",

package/src/families/bitcoin/datasets/viacoin.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "viacoin seed 1",

package/src/families/bitcoin/datasets/zcash.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "zcash seed 1",

package/src/families/bitcoin/datasets/zencash.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "zencash seed 1",

package/src/families/bitcoin/js-buildTransaction.ts

@@ -44,7 +44,8 @@ export const buildTransaction = async (
     walletAccount,
     transaction.feePerByte.toNumber(), //!\ wallet-btc handles fees as JS number
     transaction.utxoStrategy.excludeUTXOs,
-    transaction.utxoStrategy.pickUnconfirmedRBF
+    transaction.utxoStrategy.pickUnconfirmedRBF,
+    [transaction.recipient]
   );
   log("btcwallet", "building transaction", transaction);
   const txInfo = await wallet.buildAccountTx({

package/src/families/bitcoin/js-estimateMaxSpendable.ts

@@ -30,7 +30,8 @@ const estimateMaxSpendable = async ({
     walletAccount,
     feePerByte.toNumber(), //!\ wallet-btc handles fees as JS number
     transaction?.utxoStrategy?.excludeUTXOs || [],
-    transaction?.utxoStrategy?.pickUnconfirmedRBF || false
+    transaction?.utxoStrategy?.pickUnconfirmedRBF || false,
+    transaction ? [transaction.recipient] : []
   );
   return maxSpendable.lt(0) ? new BigNumber(0) : maxSpendable;
 };

package/src/families/bitcoin/js-synchronisation.ts

@@ -128,18 +128,44 @@ const mapTxToOperations = (
   // All inputs of a same transaction have the same sequence
   const transactionSequenceNumber =
     (accountInputs.length > 0 && accountInputs[0].sequence) || undefined;
+
   const hasSpentNothing = value.eq(0);
+  // Change output is always the last one
+  const changeOutputIndex = tx.outputs
+    .map((o) => o.output_index)
+    .reduce((p, c) => (p > c ? p : c));
 
   for (const output of tx.outputs) {
     if (output.address) {
-      if (accountAddresses.includes(output.address)) {
+      if (!accountAddresses.includes(output.address)) {
+        // The output doesn't belong to this account
+        if (
+          tx.outputs.length === 1 || // The transaction has only 1 output
+          output.output_index < changeOutputIndex // The output isn't the change output
+        ) {
+          recipients.push(
+            syncReplaceAddress
+              ? syncReplaceAddress(output.address)
+              : output.address
+          );
+        }
+      } else {
+        // The output belongs to this account
         accountOutputs.push(output);
 
-        if (changeAddresses.includes(output.address)) {
+        if (!changeAddresses.includes(output.address)) {
+          // The output isn't a change output of this account
+          recipients.push(
+            syncReplaceAddress
+              ? syncReplaceAddress(output.address)
+              : output.address
+          );
+        } else {
+          // The output is a change output of this account,
+          // we count it as a recipient only in some special cases
           if (
             (recipients.length === 0 &&
-              output.output_hash ===
-                tx.outputs[tx.outputs.length - 1].output_hash) ||
+              output.output_index >= changeOutputIndex) ||
             hasSpentNothing
           ) {
             recipients.push(
@@ -148,19 +174,7 @@ const mapTxToOperations = (
                 : output.address
             );
           }
-        } else {
-          recipients.push(
-            syncReplaceAddress
-              ? syncReplaceAddress(output.address)
-              : output.address
-          );
         }
-      } else {
-        recipients.push(
-          syncReplaceAddress
-            ? syncReplaceAddress(output.address)
-            : output.address
-        );
       }
     }
   }

package/src/families/bitcoin/logic.ts

@@ -79,7 +79,7 @@ export function isChangeOutput(output: BitcoinOutput): boolean {
 type UTXOStatus =
   | {
       excluded: true;
-      reason: "pickUnconfirmedRBF" | "userExclusion";
+      reason: "pickUnconfirmedRBF" | "pickPendingNonRBF" | "userExclusion";
     }
   | {
       excluded: false;
@@ -94,7 +94,12 @@ export const getUTXOStatus = (
       reason: "pickUnconfirmedRBF",
     };
   }
-
+  if (!utxo.rbf && !utxo.blockHeight) {
+    return {
+      excluded: true,
+      reason: "pickPendingNonRBF",
+    };
+  }
   if (
     utxoStrategy.excludeUTXOs.some(
       (u) => u.hash === utxo.hash && u.outputIndex === utxo.outputIndex

package/src/families/bitcoin/specs.ts

@@ -254,7 +254,12 @@ const bitcoinLikeMutations = ({
     },
     recoverBadTransactionStatus,
     test: ({ account }) => {
-      expect(account.balance.toString()).toBe("0");
+      expect(
+        account.bitcoinResources?.utxos
+          .filter((u) => u.blockHeight) // Exclude pending UTXOs
+          .reduce((p, c) => p.plus(c.value), new BigNumber(0))
+          .toString()
+      ).toBe("0");
     },
   },
 ];

package/src/families/bitcoin/test-dataset.ts

@@ -1,7 +1,7 @@
 import type { DatasetTest } from "../../types";
 import type { Transaction } from "./types";
 import bitcoin_cash from "./datasets/bitcoin_cash";
-import bitcoin_gold from "./datasets/bitcoin_gold";
+// import bitcoin_gold from "./datasets/bitcoin_gold";
 import bitcoin from "./datasets/bitcoin";
 import dash from "./datasets/dash";
 // import decred from "./datasets/decred";
@@ -22,7 +22,7 @@ const dataset: DatasetTest<Transaction> = {
   currencies: {
     bitcoin,
     bitcoin_cash,
-    bitcoin_gold,
+    // bitcoin_gold,
     dash,
     // decred, // BACK-2443
     digibyte,

package/src/families/bitcoin/wallet-btc/pickingstrategies/CoinSelect.ts

@@ -7,14 +7,14 @@ import { PickingStrategy } from "./types";
 import * as utils from "../utils";
 import { DeepFirst } from "./DeepFirst";
 import { log } from "@ledgerhq/logs";
+import { OutputInfo } from "..";
 
 export class CoinSelect extends PickingStrategy {
   // eslint-disable-next-line class-methods-use-this
   async selectUnspentUtxosToUse(
     xpub: Xpub,
-    amount: BigNumber,
-    feePerByte: number,
-    nbOutputsWithoutChange: number
+    outputs: OutputInfo[],
+    feePerByte: number
   ) {
     // get the utxos to use as input
     // from all addresses of the account
@@ -34,18 +34,30 @@ export class CoinSelect extends PickingStrategy {
     const TOTAL_TRIES = 100000;
     log("picking strategy", "utxos", unspentUtxos);
     // Compute cost of change
-    const fixedSize = utils.estimateTxSize(
-      0,
+    const fixedSize = utils.maxTxSize(
       0,
+      [],
+      false,
       this.crypto,
       this.derivationMode
     );
+    const outputAddresses = outputs.map((o) => o.address);
     // Size of only 1 output (without fixed size)
     const oneOutputSize =
-      utils.estimateTxSize(0, 1, this.crypto, this.derivationMode) - fixedSize;
+      outputAddresses.length > 0
+        ? utils.maxTxSize(
+            0,
+            [outputAddresses[0]],
+            false,
+            this.crypto,
+            this.derivationMode
+          ) - fixedSize
+        : utils.maxTxSize(0, [], true, this.crypto, this.derivationMode) -
+          fixedSize;
     // Size 1 signed UTXO (signed input)
     const oneInputSize =
-      utils.estimateTxSize(1, 0, this.crypto, this.derivationMode) - fixedSize;
+      utils.maxTxSize(1, [], false, this.crypto, this.derivationMode) -
+      fixedSize;
 
     // Calculate effective value of outputs
     let currentAvailableValue = 0;
@@ -70,12 +82,16 @@ export class CoinSelect extends PickingStrategy {
     // Get no inputs fees
     // At beginning, there are no outputs in tx, so noInputFees are fixed fees
     const notInputFees =
-      feePerByte * (fixedSize + oneOutputSize * nbOutputsWithoutChange);
+      feePerByte * (fixedSize + oneOutputSize * outputs.length);
 
     // Start coin selection algorithm (according to SelectCoinBnb from Bitcoin Core)
     let currentValue = 0;
     const currentSelection: boolean[] = [];
 
+    const amount = outputs.reduce(
+      (sum, output) => sum.plus(output.value),
+      new BigNumber(0)
+    );
     // Actual amount we are targetting
     const actualTarget = notInputFees + amount.toNumber();
 
@@ -102,9 +118,10 @@ export class CoinSelect extends PickingStrategy {
           currentSelectionNeedChangeoutput = true;
           currentWaste =
             feePerByte *
-            utils.estimateTxSize(
+            utils.maxTxSizeCeil(
               nbInput,
-              nbOutputsWithoutChange + 1,
+              outputAddresses,
+              true,
               this.crypto,
               this.derivationMode
             );
@@ -113,9 +130,10 @@ export class CoinSelect extends PickingStrategy {
           currentSelectionNeedChangeoutput = false;
           currentWaste =
             feePerByte *
-              utils.estimateTxSize(
+              utils.maxTxSizeCeil(
                 nbInput,
-                nbOutputsWithoutChange,
+                outputAddresses,
+                false,
                 this.crypto,
                 this.derivationMode
               ) +
@@ -170,11 +188,10 @@ export class CoinSelect extends PickingStrategy {
       }
       const fee =
         feePerByte *
-        utils.estimateTxSize(
+        utils.maxTxSizeCeil(
           unspentUtxoSelected.length,
-          bestSelectionNeedChangeoutput
-            ? nbOutputsWithoutChange + 1
-            : nbOutputsWithoutChange,
+          outputAddresses,
+          bestSelectionNeedChangeoutput,
           this.crypto,
           this.derivationMode
         );
@@ -191,11 +208,6 @@ export class CoinSelect extends PickingStrategy {
       this.derivationMode,
       this.excludedUTXOs
     );
-    return pickingStrategy.selectUnspentUtxosToUse(
-      xpub,
-      amount,
-      feePerByte,
-      nbOutputsWithoutChange
-    );
+    return pickingStrategy.selectUnspentUtxosToUse(xpub, outputs, feePerByte);
   }
 }

package/src/families/bitcoin/wallet-btc/pickingstrategies/DeepFirst.ts

@@ -6,14 +6,14 @@ import Xpub from "../xpub";
 import { PickingStrategy } from "./types";
 import * as utils from "../utils";
 import { log } from "@ledgerhq/logs";
+import { OutputInfo } from "..";
 
 export class DeepFirst extends PickingStrategy {
   // eslint-disable-next-line class-methods-use-this
   async selectUnspentUtxosToUse(
     xpub: Xpub,
-    amount: BigNumber,
-    feePerByte: number,
-    nbOutputsWithoutChange: number
+    outputs: OutputInfo[],
+    feePerByte: number
   ) {
     // get the utxos to use as input
     // from all addresses of the account
@@ -31,26 +31,47 @@ export class DeepFirst extends PickingStrategy {
         ).length
     );
 
+    const outputAddresses = outputs.map((o) => o.address);
     unspentUtxos = sortBy(unspentUtxos, "block_height");
     // https://metamug.com/article/security/bitcoin-transaction-fee-satoshi-per-byte.html
-    const txSizeNoInput = utils.estimateTxSize(
+    const txSizeNoInput = utils.maxTxSize(
       0,
-      nbOutputsWithoutChange,
+      outputAddresses,
+      false,
       this.crypto,
       this.derivationMode
     );
     let fee = txSizeNoInput * feePerByte;
+    const emptyTxSize = utils.maxTxSizeCeil(
+      0,
+      [],
+      false,
+      this.crypto,
+      this.derivationMode
+    );
     const sizePerInput =
-      utils.estimateTxSize(1, 0, this.crypto, this.derivationMode) -
-      utils.estimateTxSize(0, 0, this.crypto, this.derivationMode);
+      utils.maxTxSize(1, [], false, this.crypto, this.derivationMode) -
+      emptyTxSize;
 
     const sizePerOutput =
-      utils.estimateTxSize(0, 1, this.crypto, this.derivationMode) -
-      utils.estimateTxSize(0, 0, this.crypto, this.derivationMode);
+      (outputAddresses[0]
+        ? utils.maxTxSize(
+            0,
+            [outputAddresses[0]],
+            false,
+            this.crypto,
+            this.derivationMode
+          )
+        : utils.maxTxSize(0, [], true, this.crypto, this.derivationMode)) -
+      emptyTxSize;
 
     let total = new BigNumber(0);
     const unspentUtxoSelected: Output[] = [];
 
+    const amount = outputs.reduce(
+      (sum, output) => sum.plus(output.value),
+      new BigNumber(0)
+    );
     let i = 0;
     while (total.lt(amount.plus(fee))) {
       if (!unspentUtxos[i]) {

package/src/families/bitcoin/wallet-btc/pickingstrategies/Merge.ts

@@ -6,14 +6,14 @@ import Xpub from "../xpub";
 import { PickingStrategy } from "./types";
 import * as utils from "../utils";
 import { log } from "@ledgerhq/logs";
+import { OutputInfo } from "..";
 
 export class Merge extends PickingStrategy {
   // eslint-disable-next-line class-methods-use-this
   async selectUnspentUtxosToUse(
     xpub: Xpub,
-    amount: BigNumber,
-    feePerByte: number,
-    nbOutputsWithoutChange: number
+    outputs: OutputInfo[],
+    feePerByte: number
   ) {
     // get the utxos to use as input
     // from all addresses of the account
@@ -31,19 +31,36 @@ export class Merge extends PickingStrategy {
         ).length
     );
 
+    const outputAddresses = outputs.map((o) => o.address);
+    const emptyTxSize = utils.maxTxSizeCeil(
+      0,
+      [],
+      false,
+      this.crypto,
+      this.derivationMode
+    );
     const sizePerInput =
-      utils.estimateTxSize(1, 0, this.crypto, this.derivationMode) -
-      utils.estimateTxSize(0, 0, this.crypto, this.derivationMode);
+      utils.maxTxSize(1, [], false, this.crypto, this.derivationMode) -
+      emptyTxSize;
 
     const sizePerOutput =
-      utils.estimateTxSize(0, 1, this.crypto, this.derivationMode) -
-      utils.estimateTxSize(0, 0, this.crypto, this.derivationMode);
+      (outputAddresses[0]
+        ? utils.maxTxSize(
+            0,
+            [outputAddresses[0]],
+            false,
+            this.crypto,
+            this.derivationMode
+          )
+        : utils.maxTxSize(0, [], true, this.crypto, this.derivationMode)) -
+      emptyTxSize;
 
     unspentUtxos = sortBy(unspentUtxos, (utxo) => parseInt(utxo.value, 10));
     // https://metamug.com/article/security/bitcoin-transaction-fee-satoshi-per-byte.html
-    const txSizeNoInput = utils.estimateTxSize(
+    const txSizeNoInput = utils.maxTxSize(
       0,
-      nbOutputsWithoutChange,
+      outputAddresses,
+      false,
       this.crypto,
       this.derivationMode
     );
@@ -53,6 +70,10 @@ export class Merge extends PickingStrategy {
     const unspentUtxoSelected: Output[] = [];
 
     let i = 0;
+    const amount = outputs.reduce(
+      (sum, output) => sum.plus(output.value),
+      new BigNumber(0)
+    );
     while (total.lt(amount.plus(fee))) {
       if (!unspentUtxos[i]) {
         throw new NotEnoughBalance();