@ledgerhq/live-common 21.14.0 → 21.16.1

package/src/currencies/sortByMarketcap.ts

@@ -81,7 +81,15 @@ export const getMarketcapTickers: () => Promise<string[]> = makeLRUCache(() =>
 export const useMarketcapTickers = (): string[] | null | undefined => {
   const [tickers, setMarketcapTickers] = useState(marketcapTickersCache);
   useEffect(() => {
-    getMarketcapTickers().then(setMarketcapTickers);
+    let isMounted = true;
+
+    getMarketcapTickers().then((data) => {
+      if (isMounted) setMarketcapTickers(data);
+    });
+
+    return () => {
+      isMounted = false;
+    };
   }, []);
   return tickers;
 };

package/src/env.ts

@@ -376,6 +376,17 @@ const envDefinitions = {
     parser: stringParser,
     desc: "mock the server response for the exchange KYC check, options are 'open', 'pending', 'closed' or 'approved'.",
   },
+  NFT: {
+    def: false,
+    parser: boolParser,
+    desc: "synchronizing nfts",
+  },
+  NFT_ETH_METADATA_SERVICE: {
+    // FIXME LL-8001
+    def: "https://nft.staging.aws.ledger.fr/v1/ethereum/1/contracts/tokens/infos",
+    parser: stringParser,
+    desc: "service uri used to get the metadata of an nft",
+  },
   OPERATION_ADDRESSES_LIMIT: {
     def: 100,
     parser: intParser,

package/src/families/bitcoin/datasets/bitcoin.ts

@@ -28,6 +28,10 @@ const networkInfo: NetworkInfoRaw = {
   },
 };
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [scanAccounts1],
   accounts: [
     {

package/src/families/bitcoin/datasets/bitcoin_cash.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "bitcoin_cash seed 1",

package/src/families/bitcoin/datasets/bitcoin_gold.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "bitcoin_gold seed 1",

package/src/families/bitcoin/datasets/dash.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "dash seed 1",

package/src/families/bitcoin/datasets/decred.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "decred seed 1",

package/src/families/bitcoin/datasets/digibyte.ts

@@ -27,6 +27,10 @@ const networkInfo: NetworkInfoRaw = {
   },
 };
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [scanAccounts1],
   accounts: [
     {

package/src/families/bitcoin/datasets/dogecoin.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "dogecoin seed 1",

package/src/families/bitcoin/datasets/komodo.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "komodo seed 1",

package/src/families/bitcoin/datasets/litecoin.ts

@@ -27,6 +27,10 @@ const networkInfo: NetworkInfoRaw = {
   },
 };
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [scanAccounts1],
   accounts: [
     {

package/src/families/bitcoin/datasets/peercoin.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "peercoin seed 1",

package/src/families/bitcoin/datasets/pivx.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "pivx seed 1",

package/src/families/bitcoin/datasets/qtum.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "qtum seed 1",

package/src/families/bitcoin/datasets/stakenet.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "stakenet seed 1",

package/src/families/bitcoin/datasets/vertcoin.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "vertcoin seed 1",

package/src/families/bitcoin/datasets/viacoin.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "viacoin seed 1",

package/src/families/bitcoin/datasets/zcash.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "zcash seed 1",

package/src/families/bitcoin/datasets/zencash.ts

@@ -1,6 +1,10 @@
 import type { CurrenciesData } from "../../../types";
 import type { Transaction } from "../types";
 const dataset: CurrenciesData<Transaction> = {
+  FIXME_ignoreAccountFields: [
+    "bitcoinResources.walletAccount", // it is not "stable"
+    "bitcoinResources.utxos", // TODO: fix ordering
+  ],
   scanAccounts: [
     {
       name: "zencash seed 1",

package/src/families/bitcoin/js-synchronisation.ts

@@ -128,18 +128,42 @@ const mapTxToOperations = (
   // All inputs of a same transaction have the same sequence
   const transactionSequenceNumber =
     (accountInputs.length > 0 && accountInputs[0].sequence) || undefined;
+
   const hasSpentNothing = value.eq(0);
+  // Change output is always the last one
+  const changeOutputIndex = tx.outputs
+    .map((o) => o.output_index)
+    .reduce((p, c) => (p > c ? p : c));
 
   for (const output of tx.outputs) {
     if (output.address) {
-      if (accountAddresses.includes(output.address)) {
+      if (!accountAddresses.includes(output.address)) {
+        // The output doesn't belong to this account
+        if (output.output_index < changeOutputIndex) {
+          // The output isn't the change output
+          recipients.push(
+            syncReplaceAddress
+              ? syncReplaceAddress(output.address)
+              : output.address
+          );
+        }
+      } else {
+        // The output belongs to this account
         accountOutputs.push(output);
 
-        if (changeAddresses.includes(output.address)) {
+        if (!changeAddresses.includes(output.address)) {
+          // The output isn't a change output of this account
+          recipients.push(
+            syncReplaceAddress
+              ? syncReplaceAddress(output.address)
+              : output.address
+          );
+        } else {
+          // The output is a change output of this account,
+          // we count it as a recipient only in some special cases
           if (
             (recipients.length === 0 &&
-              output.output_hash ===
-                tx.outputs[tx.outputs.length - 1].output_hash) ||
+              output.output_index >= changeOutputIndex) ||
             hasSpentNothing
           ) {
             recipients.push(
@@ -148,19 +172,7 @@ const mapTxToOperations = (
                 : output.address
             );
           }
-        } else {
-          recipients.push(
-            syncReplaceAddress
-              ? syncReplaceAddress(output.address)
-              : output.address
-          );
         }
-      } else {
-        recipients.push(
-          syncReplaceAddress
-            ? syncReplaceAddress(output.address)
-            : output.address
-        );
       }
     }
   }

package/src/families/bitcoin/logic.ts

@@ -79,7 +79,7 @@ export function isChangeOutput(output: BitcoinOutput): boolean {
 type UTXOStatus =
   | {
       excluded: true;
-      reason: "pickUnconfirmedRBF" | "userExclusion";
+      reason: "pickUnconfirmedRBF" | "pickPendingNonRBF" | "userExclusion";
     }
   | {
       excluded: false;
@@ -94,7 +94,12 @@ export const getUTXOStatus = (
       reason: "pickUnconfirmedRBF",
     };
   }
-
+  if (!utxo.rbf && !utxo.blockHeight) {
+    return {
+      excluded: true,
+      reason: "pickPendingNonRBF",
+    };
+  }
   if (
     utxoStrategy.excludeUTXOs.some(
       (u) => u.hash === utxo.hash && u.outputIndex === utxo.outputIndex

package/src/families/bitcoin/specs.ts

@@ -254,7 +254,12 @@ const bitcoinLikeMutations = ({
     },
     recoverBadTransactionStatus,
     test: ({ account }) => {
-      expect(account.balance.toString()).toBe("0");
+      expect(
+        account.bitcoinResources?.utxos
+          .filter((u) => u.blockHeight) // Exclude pending UTXOs
+          .reduce((p, c) => p.plus(c.value), new BigNumber(0))
+          .toString()
+      ).toBe("0");
     },
   },
 ];

package/src/families/bitcoin/test-dataset.ts

@@ -1,7 +1,7 @@
 import type { DatasetTest } from "../../types";
 import type { Transaction } from "./types";
 import bitcoin_cash from "./datasets/bitcoin_cash";
-import bitcoin_gold from "./datasets/bitcoin_gold";
+// import bitcoin_gold from "./datasets/bitcoin_gold";
 import bitcoin from "./datasets/bitcoin";
 import dash from "./datasets/dash";
 // import decred from "./datasets/decred";
@@ -22,7 +22,7 @@ const dataset: DatasetTest<Transaction> = {
   currencies: {
     bitcoin,
     bitcoin_cash,
-    bitcoin_gold,
+    // bitcoin_gold,
     dash,
     // decred, // BACK-2443
     digibyte,

package/src/families/bitcoin/wallet-btc/crypto/base.ts

@@ -150,6 +150,7 @@ class Base implements ICrypto {
     );
   }
 
+  // eslint-disable-next-line
   isTaprootAddress(address: string): boolean {
     return false;
   }

package/src/families/bitcoin/wallet-btc/crypto/bitcoincash.ts

@@ -71,7 +71,7 @@ class BitcoinCash implements ICrypto {
     return bchaddr.isValidAddress(address);
   }
 
-  // eslint-disable-next-line class-methods-use-this
+  // eslint-disable-next-line
   isTaprootAddress(address: string): boolean {
     return false;
   }

package/src/families/bitcoin/wallet-btc/crypto/zec.ts

@@ -75,7 +75,7 @@ class ZCash implements ICrypto {
     return zec.Address.isValid(address, "livenet");
   }
 
-  // eslint-disable-next-line class-methods-use-this
+  // eslint-disable-next-line
   isTaprootAddress(address: string): boolean {
     return false;
   }

package/src/families/bitcoin/wallet-btc/crypto/zen.ts

@@ -103,7 +103,7 @@ class Zen implements ICrypto {
     );
   }
 
-  // eslint-disable-next-line class-methods-use-this
+  // eslint-disable-next-line
   isTaprootAddress(address: string): boolean {
     return false;
   }

package/src/families/bitcoin/wallet-btc/pickingstrategies/CoinSelect.ts

@@ -34,7 +34,7 @@ export class CoinSelect extends PickingStrategy {
     const TOTAL_TRIES = 100000;
     log("picking strategy", "utxos", unspentUtxos);
     // Compute cost of change
-    const fixedSize = utils.estimateTxSize(
+    const fixedSize = utils.accurateTxSize(
       0,
       0,
       this.crypto,
@@ -42,10 +42,10 @@ export class CoinSelect extends PickingStrategy {
     );
     // Size of only 1 output (without fixed size)
     const oneOutputSize =
-      utils.estimateTxSize(0, 1, this.crypto, this.derivationMode) - fixedSize;
+      utils.accurateTxSize(0, 1, this.crypto, this.derivationMode) - fixedSize;
     // Size 1 signed UTXO (signed input)
     const oneInputSize =
-      utils.estimateTxSize(1, 0, this.crypto, this.derivationMode) - fixedSize;
+      utils.accurateTxSize(1, 0, this.crypto, this.derivationMode) - fixedSize;
 
     // Calculate effective value of outputs
     let currentAvailableValue = 0;

package/src/families/bitcoin/wallet-btc/pickingstrategies/DeepFirst.ts

@@ -33,7 +33,7 @@ export class DeepFirst extends PickingStrategy {
 
     unspentUtxos = sortBy(unspentUtxos, "block_height");
     // https://metamug.com/article/security/bitcoin-transaction-fee-satoshi-per-byte.html
-    const txSizeNoInput = utils.estimateTxSize(
+    const txSizeNoInput = utils.accurateTxSize(
       0,
       nbOutputsWithoutChange,
       this.crypto,
@@ -41,12 +41,12 @@ export class DeepFirst extends PickingStrategy {
     );
     let fee = txSizeNoInput * feePerByte;
     const sizePerInput =
-      utils.estimateTxSize(1, 0, this.crypto, this.derivationMode) -
-      utils.estimateTxSize(0, 0, this.crypto, this.derivationMode);
+      utils.accurateTxSize(1, 0, this.crypto, this.derivationMode) -
+      utils.accurateTxSize(0, 0, this.crypto, this.derivationMode);
 
     const sizePerOutput =
-      utils.estimateTxSize(0, 1, this.crypto, this.derivationMode) -
-      utils.estimateTxSize(0, 0, this.crypto, this.derivationMode);
+      utils.accurateTxSize(0, 1, this.crypto, this.derivationMode) -
+      utils.accurateTxSize(0, 0, this.crypto, this.derivationMode);
 
     let total = new BigNumber(0);
     const unspentUtxoSelected: Output[] = [];

package/src/families/bitcoin/wallet-btc/pickingstrategies/Merge.ts

@@ -32,16 +32,16 @@ export class Merge extends PickingStrategy {
     );
 
     const sizePerInput =
-      utils.estimateTxSize(1, 0, this.crypto, this.derivationMode) -
-      utils.estimateTxSize(0, 0, this.crypto, this.derivationMode);
+      utils.accurateTxSize(1, 0, this.crypto, this.derivationMode) -
+      utils.accurateTxSize(0, 0, this.crypto, this.derivationMode);
 
     const sizePerOutput =
-      utils.estimateTxSize(0, 1, this.crypto, this.derivationMode) -
-      utils.estimateTxSize(0, 0, this.crypto, this.derivationMode);
+      utils.accurateTxSize(0, 1, this.crypto, this.derivationMode) -
+      utils.accurateTxSize(0, 0, this.crypto, this.derivationMode);
 
     unspentUtxos = sortBy(unspentUtxos, (utxo) => parseInt(utxo.value, 10));
     // https://metamug.com/article/security/bitcoin-transaction-fee-satoshi-per-byte.html
-    const txSizeNoInput = utils.estimateTxSize(
+    const txSizeNoInput = utils.accurateTxSize(
       0,
       nbOutputsWithoutChange,
       this.crypto,

package/src/families/bitcoin/wallet-btc/utils.ts

@@ -83,16 +83,16 @@ export function byteSize(count: number) {
     return 1;
   }
   if (count <= 0xffff) {
-    return 2;
+    return 3;
   }
   if (count <= 0xffffffff) {
-    return 4;
+    return 5;
   }
-  return 8;
+  return 9;
 }
 
 // refer to https://github.com/LedgerHQ/lib-ledger-core/blob/fc9d762b83fc2b269d072b662065747a64ab2816/core/src/wallet/bitcoin/api_impl/BitcoinLikeTransactionApi.cpp#L217
-export function estimateTxSize(
+export function accurateTxSize(
   inputCount: number,
   outputCount: number,
   currency: ICrypto,
@@ -106,11 +106,15 @@ export function estimateTxSize(
   fixedSize += byteSize(inputCount); // Number of inputs
   fixedSize += byteSize(outputCount); // Number of outputs
   fixedSize += 4; // Timelock
+  if (derivationMode !== DerivationModes.LEGACY) {
+    fixedSize += 0.5; // Segwit marker & segwit flag
+  }
   // refer to https://medium.com/coinmonks/on-bitcoin-transaction-sizes-part-2-9445373d17f4
   // and https://bitcoin.stackexchange.com/questions/96017/what-are-the-sizes-of-single-sig-and-2-of-3-multisig-taproot-inputs
+  // and https://bitcoinops.org/en/tools/calc-size/
   if (derivationMode === DerivationModes.TAPROOT) {
-    txSize = fixedSize + 57.5 * inputCount + 43 * outputCount;
-    return Math.ceil(txSize);
+    txSize = fixedSize + 57.75 * inputCount + 43 * outputCount;
+    return txSize;
   }
   const isSegwit =
     derivationMode === DerivationModes.NATIVE_SEGWIT ||
@@ -120,14 +124,25 @@ export function estimateTxSize(
     // P2SH: 32 PrevTxHash + 4 Index + 23 scriptPubKey + 4 sequence
     const isNativeSegwit = derivationMode === DerivationModes.NATIVE_SEGWIT;
     const inputSize = isNativeSegwit ? 41 : 63;
-    const noWitness = fixedSize + inputSize * inputCount + 34 * outputCount;
+    const noWitness = fixedSize + inputSize * inputCount + 43 * outputCount; //43 is the biggest output(taproot output) size, we use the biggest one for safety
     // Include flag and marker size (one byte each)
     const witnessSize = noWitness + 108 * inputCount + 2;
     txSize = (noWitness * 3 + witnessSize) / 4;
   } else {
-    txSize = fixedSize + 148 * inputCount + 34 * outputCount;
+    txSize = fixedSize + 148 * inputCount + 43 * outputCount;
   }
-  return Math.ceil(txSize); // We don't allow floating value
+  return txSize;
+}
+
+export function estimateTxSize(
+  inputCount: number,
+  outputCount: number,
+  currency: ICrypto,
+  derivationMode: string
+) {
+  return Math.ceil(
+    accurateTxSize(inputCount, outputCount, currency, derivationMode)
+  ); // We don't allow floating value
 }
 
 // refer to https://github.com/LedgerHQ/lib-ledger-core/blob/fc9d762b83fc2b269d072b662065747a64ab2816/core/src/wallet/bitcoin/api_impl/BitcoinLikeTransactionApi.cpp#L253

package/src/families/bitcoin/wallet-btc/wallet.ts

@@ -133,6 +133,7 @@ class BitcoinLikeWallet {
       )
     );
     let balance = new BigNumber(0);
+    let availableUtxoCount = 0;
     log("btcwallet", "estimateAccountMaxSpendable utxos", utxos);
     utxos.forEach((utxo) => {
       if (
@@ -144,6 +145,7 @@ class BitcoinLikeWallet {
       ) {
         if ((pickUnconfirmedRBF && utxo.rbf) || utxo.block_height !== null) {
           balance = balance.plus(utxo.value);
+          availableUtxoCount += 1;
         }
       }
     });
@@ -151,7 +153,7 @@ class BitcoinLikeWallet {
     const fees =
       feePerByte *
       utils.estimateTxSize(
-        utxos.length,
+        availableUtxoCount,
         1,
         account.xpub.crypto,
         account.xpub.derivationMode
@@ -263,7 +265,7 @@ class BitcoinLikeWallet {
       return [
         btc.splitTransaction(
           i.txHex,
-          segwit,
+          true,
           false, // FIXME hasTimestamp needed for LL-7539
           hasExtraData,
           additionals