@ledgerhq/live-common 21.13.2-btcjs.0 → 21.15.0

package/src/derivation.ts

@@ -470,7 +470,7 @@ export const getDerivationModesForCurrency = (
 
   // taproot logic. FIXME should move per family
   if (currency.family === "bitcoin") {
-    if (currency.id === "bitcoin_testnet") {
+    if (currency.id === "bitcoin" || currency.id === "bitcoin_testnet") {
       all.push("taproot");
     }
   }

package/src/env.ts

@@ -376,6 +376,17 @@ const envDefinitions = {
     parser: stringParser,
     desc: "mock the server response for the exchange KYC check, options are 'open', 'pending', 'closed' or 'approved'.",
   },
+  NFT: {
+    def: false,
+    parser: boolParser,
+    desc: "synchronizing nfts",
+  },
+  NFT_ETH_METADATA_SERVICE: {
+    // FIXME LL-8001
+    def: "https://nft.staging.aws.ledger.fr/v1/ethereum/1/contracts/tokens/infos",
+    parser: stringParser,
+    desc: "service uri used to get the metadata of an nft",
+  },
   OPERATION_ADDRESSES_LIMIT: {
     def: 100,
     parser: intParser,

package/src/families/bitcoin/cache.ts

@@ -4,6 +4,7 @@ import type { Account, CryptoCurrency } from "./../../types";
 import type { Transaction } from "./types";
 import getFeesForTransaction from "./js-getFeesForTransaction";
 import { isValidRecipient } from "./logic";
+import { Currency, isTaprootAddress } from "./wallet-btc";
 
 const getCacheKeyForCalculateFees = ({
   a,
@@ -41,6 +42,7 @@ export const calculateFees = makeLRUCache(
     maxAge: 5 * 60 * 1000, // 5 minutes
   }
 );
+
 export const validateRecipient: (
   arg0: CryptoCurrency,
   arg1: string | null | undefined
@@ -74,3 +76,13 @@ export const validateRecipient: (
   },
   (currency, recipient) => `${currency.id}_${recipient || ""}`
 );
+
+export const isTaprootRecipient: (
+  arg0: CryptoCurrency,
+  arg1: string
+) => Promise<boolean> = makeLRUCache(
+  async (currency, recipient) => {
+    return isTaprootAddress(recipient, <Currency>currency.id);
+  },
+  (currency, recipient) => `${currency.id}_${recipient || ""}`
+);

package/src/families/bitcoin/errors.ts

@@ -0,0 +1,5 @@
+import { createCustomErrorClass } from "@ledgerhq/errors";
+
+export const TaprootNotActivated = createCustomErrorClass(
+  "TaprootNotActivated"
+);

package/src/families/bitcoin/js-getTransactionStatus.ts

@@ -9,7 +9,8 @@ import {
 } from "@ledgerhq/errors";
 import type { Account, TransactionStatus } from "./../../types";
 import type { Transaction } from "./types";
-import { calculateFees, validateRecipient } from "./cache";
+import { calculateFees, validateRecipient, isTaprootRecipient } from "./cache";
+import { TaprootNotActivated } from "./errors";
 
 const getTransactionStatus = async (
   a: Account,
@@ -31,6 +32,19 @@ const getTransactionStatus = async (
     warnings.recipient = recipientWarning;
   }
 
+  // Safeguard before Taproot activation
+  if (
+    t.recipient &&
+    !errors.recipient &&
+    a.currency.id === "bitcoin" &&
+    a.blockHeight <= 709632
+  ) {
+    const isTaproot = await isTaprootRecipient(a.currency, t.recipient);
+    if (isTaproot) {
+      errors.recipient = new TaprootNotActivated();
+    }
+  }
+
   let txInputs;
   let txOutputs;
   let estimatedFees = new BigNumber(0);

package/src/families/bitcoin/test-dataset.ts

@@ -1,7 +1,7 @@
 import type { DatasetTest } from "../../types";
 import type { Transaction } from "./types";
 import bitcoin_cash from "./datasets/bitcoin_cash";
-import bitcoin_gold from "./datasets/bitcoin_gold";
+// import bitcoin_gold from "./datasets/bitcoin_gold";
 import bitcoin from "./datasets/bitcoin";
 import dash from "./datasets/dash";
 // import decred from "./datasets/decred";
@@ -22,7 +22,7 @@ const dataset: DatasetTest<Transaction> = {
   currencies: {
     bitcoin,
     bitcoin_cash,
-    bitcoin_gold,
+    // bitcoin_gold,
     dash,
     // decred, // BACK-2443
     digibyte,

package/src/families/bitcoin/wallet-btc/crypto/base.ts

@@ -149,6 +149,11 @@ class Base implements ICrypto {
       (res[0] === this.network.pubKeyHash || res[0] === this.network.scriptHash)
     );
   }
+
+  // eslint-disable-next-line
+  isTaprootAddress(address: string): boolean {
+    return false;
+  }
 }
 
 export default Base;

package/src/families/bitcoin/wallet-btc/crypto/bitcoin.ts

@@ -209,6 +209,19 @@ class Bitcoin extends Base {
     // Create address
     return toBech32(outputSchnorrKey, 1, this.network.bech32);
   }
+
+  isTaprootAddress(address: string): boolean {
+    // This prefix check is to avoid returning false in cases where a valid base58 address also happens
+    // to be a valid bech32(m) string (but invalid segwit address).
+    if (address.toLowerCase().startsWith(`${this.network.bech32}1`)) {
+      try {
+        bjs.address.fromBech32(address);
+      } catch {
+        return true;
+      }
+    }
+    return false;
+  }
 }
 
 export default Bitcoin;

package/src/families/bitcoin/wallet-btc/crypto/bitcoincash.ts

@@ -70,6 +70,11 @@ class BitcoinCash implements ICrypto {
   validateAddress(address: string): boolean {
     return bchaddr.isValidAddress(address);
   }
+
+  // eslint-disable-next-line
+  isTaprootAddress(address: string): boolean {
+    return false;
+  }
 }
 
 export default BitcoinCash;

package/src/families/bitcoin/wallet-btc/crypto/types.ts

@@ -11,6 +11,7 @@ export interface ICrypto {
 
   toOutputScript(address: string): Buffer;
   validateAddress(address: string): boolean;
+  isTaprootAddress(address: string): boolean;
 }
 
 export type Currency =

package/src/families/bitcoin/wallet-btc/crypto/zec.ts

@@ -74,6 +74,11 @@ class ZCash implements ICrypto {
   validateAddress(address: string): boolean {
     return zec.Address.isValid(address, "livenet");
   }
+
+  // eslint-disable-next-line
+  isTaprootAddress(address: string): boolean {
+    return false;
+  }
 }
 
 export default ZCash;

package/src/families/bitcoin/wallet-btc/crypto/zen.ts

@@ -102,6 +102,11 @@ class Zen implements ICrypto {
       (res[1] === 0x89 || res[1] === 0x96)
     );
   }
+
+  // eslint-disable-next-line
+  isTaprootAddress(address: string): boolean {
+    return false;
+  }
 }
 
 export default Zen;

package/src/families/bitcoin/wallet-btc/index.ts

@@ -11,7 +11,7 @@ import { TX, Input, Output } from "./storage/types";
 import { CoinSelect } from "./pickingstrategies/CoinSelect";
 import { DeepFirst } from "./pickingstrategies/DeepFirst";
 import { Merge } from "./pickingstrategies/Merge";
-import { isValidAddress } from "./utils";
+import { isValidAddress, isTaprootAddress } from "./utils";
 
 import type { Account as WalletAccount } from "./account";
 import type { Account as LiveAccount } from "./../../../types";
@@ -32,16 +32,16 @@ export {
   DeepFirst,
   Merge,
   isValidAddress,
+  isTaprootAddress,
   Currency,
 };
 
 let wallet: BitcoinLikeWallet | null = null;
 
 export const getWalletAccount = (account: LiveAccount): WalletAccount => {
-  if (account.id.startsWith("libcore")) throw new AccountNeedResync();
   const walletAccount = account.bitcoinResources?.walletAccount;
-  if (!walletAccount) {
-    throw new Error("bitcoin wallet account expected");
+  if (account.id.startsWith("libcore") || !walletAccount) {
+    throw new AccountNeedResync();
   }
   return walletAccount;
 };

package/src/families/bitcoin/wallet-btc/utils.ts

@@ -83,12 +83,12 @@ export function byteSize(count: number) {
     return 1;
   }
   if (count <= 0xffff) {
-    return 2;
+    return 3;
   }
   if (count <= 0xffffffff) {
-    return 4;
+    return 5;
   }
-  return 8;
+  return 9;
 }
 
 // refer to https://github.com/LedgerHQ/lib-ledger-core/blob/fc9d762b83fc2b269d072b662065747a64ab2816/core/src/wallet/bitcoin/api_impl/BitcoinLikeTransactionApi.cpp#L217
@@ -106,10 +106,14 @@ export function estimateTxSize(
   fixedSize += byteSize(inputCount); // Number of inputs
   fixedSize += byteSize(outputCount); // Number of outputs
   fixedSize += 4; // Timelock
+  if (derivationMode !== DerivationModes.LEGACY) {
+    fixedSize += 0.5; // Segwit marker & segwit flag
+  }
   // refer to https://medium.com/coinmonks/on-bitcoin-transaction-sizes-part-2-9445373d17f4
   // and https://bitcoin.stackexchange.com/questions/96017/what-are-the-sizes-of-single-sig-and-2-of-3-multisig-taproot-inputs
+  // and https://bitcoinops.org/en/tools/calc-size/
   if (derivationMode === DerivationModes.TAPROOT) {
-    txSize = fixedSize + 57.5 * inputCount + 43 * outputCount;
+    txSize = fixedSize + 57.75 * inputCount + 43 * outputCount;
     return Math.ceil(txSize);
   }
   const isSegwit =
@@ -120,12 +124,12 @@ export function estimateTxSize(
     // P2SH: 32 PrevTxHash + 4 Index + 23 scriptPubKey + 4 sequence
     const isNativeSegwit = derivationMode === DerivationModes.NATIVE_SEGWIT;
     const inputSize = isNativeSegwit ? 41 : 63;
-    const noWitness = fixedSize + inputSize * inputCount + 34 * outputCount;
+    const noWitness = fixedSize + inputSize * inputCount + 43 * outputCount; //43 is the biggest output(taproot output) size, we use the biggest one for safety
     // Include flag and marker size (one byte each)
     const witnessSize = noWitness + 108 * inputCount + 2;
     txSize = (noWitness * 3 + witnessSize) / 4;
   } else {
-    txSize = fixedSize + 148 * inputCount + 34 * outputCount;
+    txSize = fixedSize + 148 * inputCount + 43 * outputCount;
   }
   return Math.ceil(txSize); // We don't allow floating value
 }
@@ -156,3 +160,13 @@ export function isValidAddress(address: string, currency?: Currency) {
   const crypto = cryptoFactory(currency);
   return crypto.validateAddress(address);
 }
+
+export function isTaprootAddress(address: string, currency?: Currency) {
+  if (currency === "bitcoin") {
+    return cryptoFactory("bitcoin").isTaprootAddress(address);
+  } else if (currency === "bitcoin_testnet") {
+    return cryptoFactory("bitcoin_testnet").isTaprootAddress(address);
+  } else {
+    return false;
+  }
+}

package/src/families/bitcoin/wallet-btc/wallet.ts

@@ -263,7 +263,7 @@ class BitcoinLikeWallet {
       return [
         btc.splitTransaction(
           i.txHex,
-          segwit,
+          true,
           false, // FIXME hasTimestamp needed for LL-7539
           hasExtraData,
           additionals

package/src/families/elrond/js-getTransactionStatus.ts

@@ -32,6 +32,10 @@ const getTransactionStatus = async (
   }
 
   const estimatedFees = t.fees || new BigNumber(0);
+  if (estimatedFees.gt(a.balance)) {
+    errors.amount = new NotEnoughBalance();
+  }
+
   const totalSpent = useAllAmount
     ? a.balance
     : new BigNumber(t.amount).plus(estimatedFees);

package/src/families/elrond/js-signOperation.ts

@@ -15,7 +15,9 @@ const buildOptimisticOperation = (
   fee: BigNumber
 ): Operation => {
   const type = "OUT";
-  const value = new BigNumber(transaction.amount);
+  const value = transaction.useAllAmount
+    ? account.balance.minus(fee)
+    : new BigNumber(transaction.amount);
   const operation: Operation = {
     id: encodeOperationId(account.id, "", type),
     hash: "",