@ledgerhq/live-common 21.10.0 → 21.13.0

package/src/families/bitcoin/wallet-btc/storage/index.ts

@@ -116,18 +116,18 @@ class BitcoinLikeStorage implements IStorage {
 
   async removeTxs(txsFilter: { account: number; index: number }) {
     const newTxs: TX[] = [];
+    this.primaryIndex = {};
 
     this.txs.forEach((tx: TX) => {
-      if (tx.account !== txsFilter.account || tx.index !== txsFilter.index) {
-        newTxs.push(tx);
-        return;
-      }
-
       // clean
       const indexAddress = tx.address;
       const index = `${indexAddress}-${tx.hash}`;
 
-      delete this.primaryIndex[index];
+      if (tx.account !== txsFilter.account || tx.index !== txsFilter.index) {
+        this.primaryIndex[index] = newTxs.push(tx) - 1;
+        return;
+      }
+
       delete this.unspentUtxos[indexAddress];
       delete this.spentUtxos[indexAddress];
     });
@@ -140,10 +140,15 @@ class BitcoinLikeStorage implements IStorage {
   async removePendingTxs(txsFilter: { account: number; index: number }) {
     const newTxs: TX[] = [];
     const txsToReAdd: TX[] = [];
+    this.primaryIndex = {};
 
     this.txs.forEach((tx: TX) => {
+      // clean
+      const indexAddress = tx.address;
+      const index = `${indexAddress}-${tx.hash}`;
+
       if (tx.account !== txsFilter.account || tx.index !== txsFilter.index) {
-        newTxs.push(tx);
+        this.primaryIndex[index] = newTxs.push(tx) - 1;
         return;
       }
 
@@ -151,11 +156,6 @@ class BitcoinLikeStorage implements IStorage {
         txsToReAdd.push(tx);
       }
 
-      // clean
-      const indexAddress = tx.address;
-      const index = `${indexAddress}-${tx.hash}`;
-
-      delete this.primaryIndex[index];
       delete this.unspentUtxos[indexAddress];
       delete this.spentUtxos[indexAddress];
     });

package/src/families/bitcoin/wallet-btc/wallet.ts

@@ -209,6 +209,7 @@ class BitcoinLikeWallet {
     segwit?: boolean;
     additionals?: Array<string>;
     expiryHeight?: Buffer;
+    hasExtraData?: boolean;
     onDeviceSignatureRequested?: () => void;
     onDeviceSignatureGranted?: () => void;
     onDeviceStreaming?: (arg0: {
@@ -221,7 +222,9 @@ class BitcoinLikeWallet {
       btc,
       fromAccount,
       txInfo,
+      segwit,
       additionals,
+      hasExtraData,
       onDeviceSignatureRequested,
       onDeviceSignatureGranted,
       onDeviceStreaming,
@@ -239,7 +242,6 @@ class BitcoinLikeWallet {
       bufferWriter.writeVarSlice(txOut.script);
     });
     const outputScriptHex = buffer.toString("hex");
-
     const associatedKeysets = txInfo.associatedDerivations.map(
       ([account, index]) =>
         `${fromAccount.params.path}/${fromAccount.params.index}'/${account}/${index}`
@@ -250,12 +252,27 @@ class BitcoinLikeWallet {
       string | null | undefined,
       number | null | undefined
     ][];
-    const inputs: Inputs = txInfo.inputs.map((i) => [
-      btc.splitTransaction(i.txHex, true),
-      i.output_index,
-      null,
-      null,
-    ]);
+    const inputs: Inputs = txInfo.inputs.map((i) => {
+      log("hw", `splitTransaction`, {
+        transactionHex: i.txHex,
+        isSegwitSupported: segwit,
+        hasTimestamp: false,
+        hasExtraData,
+        additionals,
+      });
+      return [
+        btc.splitTransaction(
+          i.txHex,
+          segwit,
+          false, // FIXME hasTimestamp needed for LL-7539
+          hasExtraData,
+          additionals
+        ),
+        i.output_index,
+        null,
+        i.sequence,
+      ];
+    });
 
     const lastOutputIndex = txInfo.outputs.length - 1;
 

package/src/families/cosmos/test-dataset.ts

@@ -1,5 +1,5 @@
 import { BigNumber } from "bignumber.js";
-import type { DatasetTest } from "../../types";
+import type { CurrenciesData, DatasetTest } from "../../types";
 import {
   InvalidAddress,
   InvalidAddressBecauseDestinationIsAlsoSource,
@@ -10,8 +10,9 @@ import { ClaimRewardsFeesWarning } from "../../errors";
 import invariant from "invariant";
 import type { Transaction } from "./types";
 import transactionTransformer from "./transaction";
-// eslint-disable-next-line no-unused-vars
-const cosmos = {
+
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+const cosmos: CurrenciesData<Transaction> = {
   FIXME_ignoreAccountFields: [
     "cosmosResources.unbondingBalance", // They move once all unbonding are done
     "cosmosResources.pendingRewardsBalance", // They are always movings
@@ -60,11 +61,6 @@ const cosmos = {
         spendableBalance: "2180673",
         blockHeight: 1615299,
         currencyId: "cosmos",
-        unit: {
-          name: "Muon",
-          code: "MUON",
-          magnitude: 6,
-        },
         unitMagnitude: 6,
         operationsCount: 85,
         operations: [],
@@ -117,7 +113,8 @@ const cosmos = {
           }),
           expectedStatus: (account) => {
             const { cosmosResources } = account;
-            invariant(cosmosResources, "Should exist because it's cosmos");
+            if (!cosmosResources)
+              throw new Error("Should exist because it's cosmos");
             const totalSpent = account.balance.minus(
               cosmosResources.unbondingBalance.plus(
                 cosmosResources.delegatedBalance
@@ -147,7 +144,8 @@ const cosmos = {
           }),
           expectedStatus: (account, t) => {
             const { cosmosResources } = account;
-            invariant(cosmosResources, "Should exist because it's cosmos");
+            if (!cosmosResources)
+              throw new Error("Should exist because it's cosmos");
             invariant(t.memo === "test", "Should have a memo");
             const totalSpent = account.balance.minus(
               cosmosResources.unbondingBalance.plus(
@@ -442,7 +440,6 @@ const cosmos = {
         lastSyncDate: "2020-06-11T07:44:10.266Z",
         balance: "1000000",
         spendableBalance: "0",
-        balanceHistory: {},
         xpub: "cosmospub1addwnpepqd3nvwwx39pqqvw88sg409675u6wyt4wtzqyt2t0e9y4629t50cdzftxnvz",
         cosmosResources: {
           delegations: [],
@@ -457,12 +454,10 @@ const cosmos = {
     },
   ],
 };
-const currencies = {
-  cosmos,
-};
 const dataset: DatasetTest<Transaction> = {
   implementations: ["libcore"],
-  // FIXEM: bad any
-  currencies: currencies as any,
+  currencies: {
+    // cosmos, // LL-7872
+  },
 };
 export default dataset;

package/src/families/crypto_org/api/sdk.ts

@@ -148,7 +148,8 @@ function convertSendTransactionToOperation(
   addr: string,
   messageSendContent: CryptoOrgMsgSendContent,
   transaction: CryptoOrgAccountTransaction,
-  currencyId: string
+  currencyId: string,
+  memo: string
 ): Operation {
   const type = getOperationType(messageSendContent, addr);
   return {
@@ -164,7 +165,7 @@ function convertSendTransactionToOperation(
     senders: [messageSendContent.fromAddress],
     recipients: [messageSendContent.toAddress],
     hasFailed: !transaction.success,
-    extra: {},
+    extra: { memo },
   };
 }
 
@@ -191,6 +192,8 @@ export const getOperations = async (
 
   for (let i = 0; i < accountTransactions.length; i++) {
     const msgs = accountTransactions[i].messages;
+    const memo = accountTransactions[i].memo;
+    const memoTransaction = memo || "";
 
     for (let j = 0; j < msgs.length; j++) {
       switch (msgs[j].type) {
@@ -202,7 +205,8 @@ export const getOperations = async (
               addr,
               msgSend,
               accountTransactions[i],
-              currencyId
+              currencyId,
+              memoTransaction
             )
           );
           break;

package/src/families/crypto_org/cli-transaction.ts

@@ -7,6 +7,11 @@ const options = [
     type: String,
     desc: "mode of transaction: send",
   },
+  {
+    name: "memo",
+    type: String,
+    desc: "add a memo to a transaction",
+  },
 ];
 
 function inferTransactions(
@@ -27,7 +32,12 @@ function inferTransactions(
       if (!account.cryptoOrgResources) throw new Error("unactivated account");
     }
 
-    return { ...transaction, family: "crypto_org", mode: opts.mode || "send" };
+    return {
+      ...transaction,
+      family: "crypto_org",
+      mode: opts.mode || "send",
+      memo: opts.memo,
+    };
   });
 }
 

package/src/families/crypto_org/js-buildTransaction.ts

@@ -45,6 +45,11 @@ export const buildTransaction = async (
     toAddress: t.recipient,
     amount: getTransactionAmount(a, t),
   });
+
+  const { memo } = t;
+  const memoTransaction = memo || "";
+  rawTx.setMemo(memoTransaction);
+
   const signableTx = rawTx
     .appendMessage(msgSend)
     .addSigner({

package/src/families/crypto_org/js-transaction.ts

@@ -17,6 +17,7 @@ export const createTransaction = (): Transaction => ({
   recipient: "",
   useAllAmount: false,
   fees: new BigNumber(0),
+  memo: null,
 });
 
 /**
@@ -38,10 +39,16 @@ export const updateTransaction = (
  */
 export const prepareTransaction = async (a: Account, t: Transaction) => {
   let fees = t.fees;
+  let memo = t.memo;
+
   fees = await getEstimatedFees();
 
-  if (!sameFees(t.fees, fees)) {
-    return { ...t, fees };
+  if (t.mode !== "send" && !memo) {
+    memo = "Ledger Live";
+  }
+
+  if (t.memo !== memo || !sameFees(t.fees, fees)) {
+    return { ...t, memo, fees };
   }
 
   return t;

package/src/families/crypto_org/transaction.ts

@@ -8,7 +8,7 @@ import type { Account } from "../../types";
 import { getAccountUnit } from "../../account";
 import { formatCurrencyUnit } from "../../currencies";
 export const formatTransaction = (
-  { mode, amount, recipient, useAllAmount }: Transaction,
+  { mode, amount, recipient, useAllAmount, memo }: Transaction,
   account: Account
 ): string => `
 ${mode.toUpperCase()} ${
@@ -21,7 +21,7 @@ ${mode.toUpperCase()} ${
         showCode: true,
         disableRounding: true,
       })
-}${recipient ? `\nTO ${recipient}` : ""}`;
+}${recipient ? `\nTO ${recipient}` : ""}${!memo ? "" : `\n with memo=${memo}`}`;
 export const fromTransactionRaw = (tr: TransactionRaw): Transaction => {
   const common = fromTransactionCommonRaw(tr);
   return {
@@ -29,6 +29,7 @@ export const fromTransactionRaw = (tr: TransactionRaw): Transaction => {
     family: tr.family,
     mode: tr.mode,
     fees: tr.fees ? new BigNumber(tr.fees) : new BigNumber(0),
+    memo: tr.memo,
   };
 };
 export const toTransactionRaw = (t: Transaction): TransactionRaw => {
@@ -38,6 +39,7 @@ export const toTransactionRaw = (t: Transaction): TransactionRaw => {
     family: t.family,
     mode: t.mode,
     fees: t.fees?.toString() || "",
+    memo: t.memo,
   };
 };
 export default {

package/src/families/crypto_org/types.ts

@@ -23,11 +23,13 @@ export type Transaction = TransactionCommon & {
   mode: string;
   family: "crypto_org";
   fees?: BigNumber; // add here all transaction-specific fields if you implement other modes than "send"
+  memo: string | null | undefined;
 };
 export type TransactionRaw = TransactionCommonRaw & {
   family: "crypto_org";
   mode: string;
   fees?: string; // also the transaction fields as raw JSON data
+  memo: string | null | undefined;
 };
 export type CryptoOrgPreloadData = Record<any, any>;
 export type NetworkInfo = {

package/src/families/elrond/api/apiCalls.ts

@@ -1,7 +1,6 @@
 import network from "../../../network";
 import {
   HASH_TRANSACTION,
-  RAW_TRANSACTION,
   METACHAIN_SHARD,
   TRANSACTIONS_SIZE,
 } from "../constants";
@@ -69,9 +68,8 @@ export default class ElrondApi {
     };
   }
 
-  async submit({ operation, signature, signUsingHash }) {
+  async submit({ operation, signature }) {
     const { chainId, gasLimit, gasPrice } = await this.getNetworkConfig();
-    const transactionType = signUsingHash ? HASH_TRANSACTION : RAW_TRANSACTION;
     const {
       senders: [sender],
       recipients: [receiver],
@@ -94,7 +92,7 @@ export default class ElrondApi {
         gasLimit,
         chainID: chainId,
         signature,
-        ...transactionType,
+        ...HASH_TRANSACTION,
       },
     });
     return {

package/src/families/elrond/api/sdk.ts

@@ -122,7 +122,5 @@ export const getFees = async (unsigned): Promise<BigNumber> => {
 export const broadcastTransaction = async (blob: any) => {
   const { hash } = await api.submit(blob);
   // Transaction hash is likely to be returned
-  return {
-    hash,
-  };
+  return hash;
 };

package/src/families/elrond/constants.ts

@@ -2,9 +2,5 @@ export const HASH_TRANSACTION = {
   version: 2,
   options: 1,
 };
-export const RAW_TRANSACTION = {
-  version: 1,
-  options: 0,
-};
 export const METACHAIN_SHARD = 4294967295;
 export const TRANSACTIONS_SIZE = 10000;

package/src/families/elrond/js-broadcast.ts

@@ -11,14 +11,11 @@ const broadcast = async ({
 }: {
   signedOperation: SignedOperation;
 }): Promise<Operation> => {
-  const {
-    extra: { signUsingHash },
-  } = operation;
-  const { hash } = await broadcastTransaction({
+  const hash = await broadcastTransaction({
     operation,
     signature,
-    signUsingHash,
   });
+
   return patchOperationWithHash(operation, hash);
 };
 

package/src/families/elrond/js-buildTransaction.ts

@@ -2,7 +2,7 @@ import type { Transaction } from "./types";
 import type { Account } from "../../types";
 import { getNonce } from "./logic";
 import { getNetworkConfig } from "./api";
-import { HASH_TRANSACTION, RAW_TRANSACTION } from "./constants";
+import { HASH_TRANSACTION } from "./constants";
 import BigNumber from "bignumber.js";
 
 /**
@@ -10,15 +10,11 @@ import BigNumber from "bignumber.js";
  * @param {Account} a
  * @param {Transaction} t
  */
-export const buildTransaction = async (
-  a: Account,
-  t: Transaction,
-  signUsingHash = true
-) => {
+export const buildTransaction = async (a: Account, t: Transaction) => {
   const address = a.freshAddress;
   const nonce = getNonce(a);
   const { gasPrice, gasLimit, chainId } = await getNetworkConfig();
-  const transactionType = signUsingHash ? HASH_TRANSACTION : RAW_TRANSACTION;
+
   const unsigned = {
     nonce,
     value: t.useAllAmount
@@ -29,7 +25,7 @@ export const buildTransaction = async (
     gasPrice,
     gasLimit,
     chainID: chainId,
-    ...transactionType,
+    ...HASH_TRANSACTION,
   };
   // Will likely be a call to Elrond SDK
   return JSON.stringify(unsigned);

package/src/families/elrond/js-estimateMaxSpendable.ts

@@ -28,7 +28,6 @@ const estimateMaxSpendable = async ({
   const fees = await getEstimatedFees({
     a,
     t,
-    signUsingHash: true,
   });
 
   if (fees.gt(a.spendableBalance)) {

package/src/families/elrond/js-getFeesForTransaction.ts

@@ -13,13 +13,11 @@ import { buildTransaction } from "./js-buildTransaction";
 const getEstimatedFees = async ({
   a,
   t,
-  signUsingHash = true,
 }: {
   a: Account;
   t: Transaction;
-  signUsingHash: boolean | undefined;
 }): Promise<BigNumber> => {
-  const unsigned = await buildTransaction(a, t, signUsingHash);
+  const unsigned = await buildTransaction(a, t);
   return await getFees(JSON.parse(unsigned));
 };
 

package/src/families/elrond/js-signOperation.ts

@@ -7,13 +7,12 @@ import { open, close } from "../../hw";
 import { encodeOperationId } from "../../operation";
 import Elrond from "./hw-app-elrond";
 import { buildTransaction } from "./js-buildTransaction";
-import { getNonce, compareVersions } from "./logic";
+import { getNonce } from "./logic";
 
 const buildOptimisticOperation = (
   account: Account,
   transaction: Transaction,
-  fee: BigNumber,
-  signUsingHash: boolean
+  fee: BigNumber
 ): Operation => {
   const type = "OUT";
   const value = new BigNumber(transaction.amount);
@@ -30,9 +29,7 @@ const buildOptimisticOperation = (
     accountId: account.id,
     transactionSequenceNumber: getNonce(account),
     date: new Date(),
-    extra: {
-      signUsingHash,
-    },
+    extra: {},
   };
   return operation;
 };
@@ -60,29 +57,27 @@ const signOperation = ({
 
         const elrond = new Elrond(transport);
         await elrond.setAddress(account.freshAddressPath);
-        const { version } = await elrond.getAppConfiguration();
-        const signUsingHash = compareVersions(version, "1.0.11") >= 0;
-        const unsigned = await buildTransaction(
-          account,
-          transaction,
-          signUsingHash
-        );
+
+        const unsigned = await buildTransaction(account, transaction);
+
         o.next({
           type: "device-signature-requested",
         });
+
         const r = await elrond.signTransaction(
           account.freshAddressPath,
           unsigned,
-          signUsingHash
+          true
         );
+
         o.next({
           type: "device-signature-granted",
         });
+
         const operation = buildOptimisticOperation(
           account,
           transaction,
-          transaction.fees ?? new BigNumber(0),
-          signUsingHash
+          transaction.fees ?? new BigNumber(0)
         );
         o.next({
           type: "signed",

package/src/families/elrond/js-synchronisation.ts

@@ -32,6 +32,7 @@ const getAccountShape: GetAccountShape = async (info) => {
       nonce,
     },
   };
+
   return { ...shape, operations };
 };
 

package/src/families/elrond/js-transaction.ts

@@ -46,7 +46,6 @@ export const prepareTransaction = async (a: Account, t: Transaction) => {
   fees = await getEstimatedFees({
     a,
     t,
-    signUsingHash: true,
   });
 
   if (!sameFees(t.fees, fees)) {

package/src/families/elrond/logic.ts

@@ -12,30 +12,6 @@ const HRP = "erd";
  */
 const PUBKEY_LENGTH = 32;
 
-export const compareVersions = (versionA: string, versionB: string): number => {
-  let i, diff;
-  const regExStrip0 = /(\.0+)+$/;
-  const segmentsA = versionA.replace(regExStrip0, "").split(".");
-  const segmentsB = versionB.replace(regExStrip0, "").split(".");
-  const minVersionLength = Math.min(segmentsA.length, segmentsB.length);
-
-  for (i = 0; i < minVersionLength; i++) {
-    diff = parseInt(segmentsA[i], 10) - parseInt(segmentsB[i], 10);
-
-    if (diff == 0) {
-      continue;
-    }
-
-    if (diff < 0) {
-      return -1;
-    }
-
-    return 1;
-  }
-
-  return segmentsA.length - segmentsB.length;
-};
-
 function fromBech32(value: string): string {
   let decoded;
 

package/src/families/elrond/test-dataset.ts

@@ -103,7 +103,7 @@ const dataset: DatasetTest<Transaction> = {
   implementations: ["js"],
   currencies: {
     // FIXME: temporarily disabled until a solution is found for an inconstency between two sync
-    elrond,
+    // elrond, // infra issue
   },
 };
 

package/src/families/polkadot/api/sidecar.ts

@@ -657,7 +657,7 @@ export const getRegistry = async (): Promise<{
   extrinsics: Extrinsics;
 }> => {
   const [material, spec] = await Promise.all([
-    fetchTransactionMaterial(true),
+    getTransactionMaterialWithMetadata(),
     fetchChainSpec(),
   ]);
   const registry: any = new TypeRegistry();
@@ -710,3 +710,22 @@ export const getConstants: CacheRes<
     maxAge: 60 * 60 * 1000, // 1 hour
   }
 );
+
+/**
+ * Cache the fetchTransactionMaterial(true) to avoid too many calls
+ *
+ * @async
+ *
+ * @returns {Promise<Object>} consts
+ */
+export const getTransactionMaterialWithMetadata: CacheRes<
+  Array<void>,
+  SidecarTransactionMaterial
+> = makeLRUCache(
+  async (): Promise<SidecarTransactionMaterial> =>
+    fetchTransactionMaterial(true),
+  () => "polkadot",
+  {
+    maxAge: 60 * 60 * 1000, // 1 hour - could be Infinity
+  }
+);

package/src/families/tezos/bakers.whitelist-default.ts

@@ -14,7 +14,6 @@ tz1Lhf4J9Qxoe3DZ2nfe8FGDnvVj7oKjnMY6
 tz1Ldzz6k1BHdhuKvAtMRX7h5kJSMHESMHLC
 tz1Kf25fX1VdmYGSEzwFy1wNmkbSEZ2V83sY
 tz1RCFbB9GpALpsZtu6J58sb74dm8qe6XBzv
-tz1LLNkQK4UQV6QcFShiXJ2vT2ELw449MzAA
 tz1dbfppLAAxXZNtf2SDps7rch3qfUznKSoK
 tz1Q8QkSBS63ZQnH3fBTiAMPes9R666Rn6Sc
 tz2FCNBrERXtaTtNX6iimR1UJ5JSDxvdHM93
@@ -24,7 +23,6 @@ tz1SohptP53wDPZhzTWzDUFAUcWF6DMBpaJV
 tz1P2Po7YM526ughEsRbY4oR9zaUPDZjxFrb
 tz1KzSC1J9aBxKp7u8TUnpN8L7S65PBRkgdF
 tz1STeamwbp68THcny9zk3LsbG3H36DMvbRK
-tz1bLwpPfr3xqy1gWBF4sGvv8bLJyPHR11kx
 tz1fJHFn6sWEd3NnBPngACuw2dggTv6nQZ7g
 tz1NEKxGEHsFufk87CVZcrqWu8o22qh46GK6
 tz1V3yg82mcrPJbegqVCPn6bC8w1CSTRp3f8

package/src/reconciliation.ts

@@ -168,7 +168,8 @@ function shouldRefreshBitcoinResources(
   const { bitcoinResources: raw } = updatedRaw;
   // FIXME Need more typing in wallet-btc to have a meaningful comparison
   //if (!isEqual(raw.walletAccount?.xpub?.data, existing.walletAccount?.xpub?.data)) return true;
-  return raw.utxos.length !== existing.utxos.length;
+  if (raw.utxos.length !== existing.utxos.length) return true;
+  return !isEqual(raw.utxos, existing.utxos);
 }
 
 export function patchAccount(