@ledgerhq/live-common 21.10.0 → 21.11.0

package/package.json

@@ -8,7 +8,7 @@
     "type": "git",
     "url": "https://github.com/LedgerHQ/ledger-live-common"
   },
-  "version": "21.10.0",
+  "version": "21.11.0",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
   "license": "Apache-2.0",
@@ -48,7 +48,7 @@
     "@ledgerhq/devices": "6.11.0",
     "@ledgerhq/errors": "6.10.0",
     "@ledgerhq/hw-app-algorand": "6.11.0",
-    "@ledgerhq/hw-app-btc": "6.11.0",
+    "@ledgerhq/hw-app-btc": "6.11.1",
     "@ledgerhq/hw-app-cosmos": "6.11.0",
     "@ledgerhq/hw-app-eth": "6.11.0",
     "@ledgerhq/hw-app-polkadot": "6.11.0",
@@ -62,8 +62,8 @@
     "@ledgerhq/json-bignumber": "^1.1.0",
     "@ledgerhq/live-app-sdk": "^0.2.0",
     "@ledgerhq/logs": "6.10.0",
-    "@polkadot/types": "6.4.2",
-    "@polkadot/types-known": "6.4.2",
+    "@polkadot/types": "6.5.2",
+    "@polkadot/types-known": "6.5.2",
     "@taquito/ledger-signer": "^10.2.1",
     "@taquito/taquito": "10.2.1",
     "@types/bchaddrjs": "^0.4.0",
@@ -108,7 +108,7 @@
     "performance-now": "^2.1.0",
     "prando": "^6.0.1",
     "redux": "^4.1.1",
-    "reselect": "^4.0.0",
+    "reselect": "^4.1.0",
     "ripemd160": "^2.0.2",
     "ripple-binary-codec": "^1.1.3",
     "ripple-bs58check": "^2.0.2",
@@ -131,7 +131,7 @@
     "@types/cbor": "^6.0.0",
     "@types/jest": "^27.0.2",
     "@types/lodash": "^4.14.176",
-    "@types/node": "16.11.2",
+    "@types/node": "16.11.6",
     "@types/object-hash": "^2.1.0",
     "@typescript-eslint/eslint-plugin": "^4.33.0",
     "@typescript-eslint/parser": "^4.33.0",
@@ -157,12 +157,12 @@
     "prettier": "2.3.2",
     "react": "17.0.2",
     "react-dom": "17.0.2",
-    "react-redux": "7.2.5",
+    "react-redux": "7.2.6",
     "react-test-renderer": "^17.0.2",
     "rimraf": "^3.0.2",
     "timemachine": "^0.3.2",
     "ts-jest": "^27.0.7",
-    "ts-node": "^10.3.0",
+    "ts-node": "^10.4.0",
     "typescript": "^4.4.4",
     "typescript-eslint-parser": "^22.0.0"
   }

package/src/__tests__/families/bitcoin/wallet-btc/wallet.integration.test.ts

@@ -63,7 +63,7 @@ describe("testing wallet", () => {
       fromAccount: account,
       txInfo,
     });
-    expect(tx).toEqual("a1e3e67bfc06cc1ae259474beebc423b2890a19a");
+    expect(tx).toEqual("66ad13fd62ca677ae4d169ec5fe84be2f846562a");
   });
 
   it("should allow to build a transaction splitting outputs", async () => {
@@ -87,7 +87,7 @@ describe("testing wallet", () => {
       fromAccount: account,
       txInfo,
     });
-    expect(tx).toEqual("637a8cb808fa1cd8b81a97e27b6bab94d87b899f");
+    expect(tx).toEqual("23ab414d38fe836e22619d6ee84fdebafa6b5168");
   });
 
   it("should throw during sync if there is an error in explorer", async () => {

package/src/apps/support.ts

@@ -29,7 +29,8 @@ export function shouldUpgrade(
 const appVersionsRequired = {
   Cosmos: ">= 2.14",
   Algorand: ">= 1.2.9",
-  Polkadot: ">= 7.9050.0",
+  Polkadot: ">= 8.9100.0",
+  Elrond: ">= 1.0.11",
 };
 export function mustUpgrade(
   deviceModel: DeviceModelId,

package/src/bridge/jsHelpers.ts

@@ -369,7 +369,7 @@ export const makeScanAccounts =
                 });
                 derivationsCache[freshAddressPath] = res;
               }
-              log("scanAccounts", "derivationsCache", res);
+
               const account = await stepAccount(
                 index,
                 res,
@@ -377,6 +377,14 @@ export const makeScanAccounts =
                 seedIdentifier,
                 transport
               );
+              // Bitcoin needs to compute the freshAddressPath itself,
+              // so we update it afterwards
+              if (account?.freshAddressPath) {
+                res.address = account.freshAddress;
+                derivationsCache[account.freshAddressPath] = res;
+              }
+              log("scanAccounts", "derivationsCache", res);
+
               log(
                 "scanAccounts",
                 `scanning ${currency.id} at ${freshAddressPath}: ${

package/src/bridge/react/BridgeSync.tsx

@@ -103,6 +103,7 @@ function useHydrate({ accounts, hydrateCurrency }) {
 }
 
 const lastTimeAnalyticsTrackPerAccountId: Record<string, number> = {};
+const lastTimeSuccessSyncPerAccountId: Record<string, number> = {};
 const nothingState = {
   pending: false,
   error: null,
@@ -160,6 +161,15 @@ function useSyncQueue({
           const account = accounts.find((a) => a.id === accountId);
           if (!account) return;
           const subAccounts: SubAccount[] = account.subAccounts || [];
+
+          if (event === "SyncSuccess") {
+            // Nb Only emit SyncSuccess/SyncSuccessToken event once per launch
+            if (lastTimeSuccessSyncPerAccountId[accountId]) {
+              return;
+            }
+            lastTimeSuccessSyncPerAccountId[accountId] = startSyncTime;
+          }
+
           trackAnalytics(event, {
             duration: (Date.now() - startSyncTime) / 1000,
             currencyName: account.currency.name,

package/src/families/bitcoin/js-synchronisation.ts

@@ -342,6 +342,8 @@ const getAccountShape: GetAccountShape = async (info) => {
     spendableBalance: balance,
     operations,
     operationsCount: operations.length,
+    freshAddress: walletAccount.xpub.freshAddress[0],
+    freshAddressPath: `${accountPath}/0/${walletAccount.xpub.freshAddressIndex[0]}`,
     blockHeight,
     bitcoinResources: {
       utxos,

package/src/families/bitcoin/wallet-btc/explorer/index.ts

@@ -239,17 +239,13 @@ class BitcoinLikeExplorer extends EventEmitter implements IExplorer {
     tx.index = address.index;
     // eslint-disable-next-line no-param-reassign
     tx.address = address.address;
-
     tx.outputs.forEach((output) => {
       // eslint-disable-next-line no-param-reassign
       output.output_hash = tx.hash;
       // eslint-disable-next-line no-param-reassign
       output.block_height = tx.block ? tx.block.height : null;
       // Definition of replaceable, per the standard: https://github.com/bitcoin/bips/blob/61ccc84930051e5b4a99926510d0db4a8475a4e6/bip-0125.mediawiki#summary
-      // eslint-disable-next-line no-param-reassign
-      output.rbf = !!(
-        tx.inputs[0]?.sequence && tx.inputs[0].sequence < 0xffffffff
-      );
+      output.rbf = tx.inputs[0] ? tx.inputs[0].sequence < 0xffffffff : false;
     });
   }
 

package/src/families/bitcoin/wallet-btc/wallet.ts

@@ -254,7 +254,7 @@ class BitcoinLikeWallet {
       btc.splitTransaction(i.txHex, true),
       i.output_index,
       null,
-      null,
+      i.sequence,
     ]);
 
     const lastOutputIndex = txInfo.outputs.length - 1;

package/src/families/cosmos/test-dataset.ts

@@ -1,5 +1,5 @@
 import { BigNumber } from "bignumber.js";
-import type { DatasetTest } from "../../types";
+import type { CurrenciesData, DatasetTest } from "../../types";
 import {
   InvalidAddress,
   InvalidAddressBecauseDestinationIsAlsoSource,
@@ -10,8 +10,9 @@ import { ClaimRewardsFeesWarning } from "../../errors";
 import invariant from "invariant";
 import type { Transaction } from "./types";
 import transactionTransformer from "./transaction";
-// eslint-disable-next-line no-unused-vars
-const cosmos = {
+
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+const cosmos: CurrenciesData<Transaction> = {
   FIXME_ignoreAccountFields: [
     "cosmosResources.unbondingBalance", // They move once all unbonding are done
     "cosmosResources.pendingRewardsBalance", // They are always movings
@@ -60,11 +61,6 @@ const cosmos = {
         spendableBalance: "2180673",
         blockHeight: 1615299,
         currencyId: "cosmos",
-        unit: {
-          name: "Muon",
-          code: "MUON",
-          magnitude: 6,
-        },
         unitMagnitude: 6,
         operationsCount: 85,
         operations: [],
@@ -117,7 +113,8 @@ const cosmos = {
           }),
           expectedStatus: (account) => {
             const { cosmosResources } = account;
-            invariant(cosmosResources, "Should exist because it's cosmos");
+            if (!cosmosResources)
+              throw new Error("Should exist because it's cosmos");
             const totalSpent = account.balance.minus(
               cosmosResources.unbondingBalance.plus(
                 cosmosResources.delegatedBalance
@@ -147,7 +144,8 @@ const cosmos = {
           }),
           expectedStatus: (account, t) => {
             const { cosmosResources } = account;
-            invariant(cosmosResources, "Should exist because it's cosmos");
+            if (!cosmosResources)
+              throw new Error("Should exist because it's cosmos");
             invariant(t.memo === "test", "Should have a memo");
             const totalSpent = account.balance.minus(
               cosmosResources.unbondingBalance.plus(
@@ -442,7 +440,6 @@ const cosmos = {
         lastSyncDate: "2020-06-11T07:44:10.266Z",
         balance: "1000000",
         spendableBalance: "0",
-        balanceHistory: {},
         xpub: "cosmospub1addwnpepqd3nvwwx39pqqvw88sg409675u6wyt4wtzqyt2t0e9y4629t50cdzftxnvz",
         cosmosResources: {
           delegations: [],
@@ -457,12 +454,10 @@ const cosmos = {
     },
   ],
 };
-const currencies = {
-  cosmos,
-};
 const dataset: DatasetTest<Transaction> = {
   implementations: ["libcore"],
-  // FIXEM: bad any
-  currencies: currencies as any,
+  currencies: {
+    // cosmos, // LL-7872
+  },
 };
 export default dataset;

package/src/families/elrond/api/apiCalls.ts

@@ -1,7 +1,6 @@
 import network from "../../../network";
 import {
   HASH_TRANSACTION,
-  RAW_TRANSACTION,
   METACHAIN_SHARD,
   TRANSACTIONS_SIZE,
 } from "../constants";
@@ -69,9 +68,8 @@ export default class ElrondApi {
     };
   }
 
-  async submit({ operation, signature, signUsingHash }) {
+  async submit({ operation, signature }) {
     const { chainId, gasLimit, gasPrice } = await this.getNetworkConfig();
-    const transactionType = signUsingHash ? HASH_TRANSACTION : RAW_TRANSACTION;
     const {
       senders: [sender],
       recipients: [receiver],
@@ -94,7 +92,7 @@ export default class ElrondApi {
         gasLimit,
         chainID: chainId,
         signature,
-        ...transactionType,
+        ...HASH_TRANSACTION,
       },
     });
     return {

package/src/families/elrond/api/sdk.ts

@@ -122,7 +122,5 @@ export const getFees = async (unsigned): Promise<BigNumber> => {
 export const broadcastTransaction = async (blob: any) => {
   const { hash } = await api.submit(blob);
   // Transaction hash is likely to be returned
-  return {
-    hash,
-  };
+  return hash;
 };

package/src/families/elrond/constants.ts

@@ -2,9 +2,5 @@ export const HASH_TRANSACTION = {
   version: 2,
   options: 1,
 };
-export const RAW_TRANSACTION = {
-  version: 1,
-  options: 0,
-};
 export const METACHAIN_SHARD = 4294967295;
 export const TRANSACTIONS_SIZE = 10000;

package/src/families/elrond/js-broadcast.ts

@@ -11,14 +11,11 @@ const broadcast = async ({
 }: {
   signedOperation: SignedOperation;
 }): Promise<Operation> => {
-  const {
-    extra: { signUsingHash },
-  } = operation;
-  const { hash } = await broadcastTransaction({
+  const hash = await broadcastTransaction({
     operation,
     signature,
-    signUsingHash,
   });
+
   return patchOperationWithHash(operation, hash);
 };
 

package/src/families/elrond/js-buildTransaction.ts

@@ -2,7 +2,7 @@ import type { Transaction } from "./types";
 import type { Account } from "../../types";
 import { getNonce } from "./logic";
 import { getNetworkConfig } from "./api";
-import { HASH_TRANSACTION, RAW_TRANSACTION } from "./constants";
+import { HASH_TRANSACTION } from "./constants";
 import BigNumber from "bignumber.js";
 
 /**
@@ -10,15 +10,11 @@ import BigNumber from "bignumber.js";
  * @param {Account} a
  * @param {Transaction} t
  */
-export const buildTransaction = async (
-  a: Account,
-  t: Transaction,
-  signUsingHash = true
-) => {
+export const buildTransaction = async (a: Account, t: Transaction) => {
   const address = a.freshAddress;
   const nonce = getNonce(a);
   const { gasPrice, gasLimit, chainId } = await getNetworkConfig();
-  const transactionType = signUsingHash ? HASH_TRANSACTION : RAW_TRANSACTION;
+
   const unsigned = {
     nonce,
     value: t.useAllAmount
@@ -29,7 +25,7 @@ export const buildTransaction = async (
     gasPrice,
     gasLimit,
     chainID: chainId,
-    ...transactionType,
+    ...HASH_TRANSACTION,
   };
   // Will likely be a call to Elrond SDK
   return JSON.stringify(unsigned);

package/src/families/elrond/js-estimateMaxSpendable.ts

@@ -28,7 +28,6 @@ const estimateMaxSpendable = async ({
   const fees = await getEstimatedFees({
     a,
     t,
-    signUsingHash: true,
   });
 
   if (fees.gt(a.spendableBalance)) {

package/src/families/elrond/js-getFeesForTransaction.ts

@@ -13,13 +13,11 @@ import { buildTransaction } from "./js-buildTransaction";
 const getEstimatedFees = async ({
   a,
   t,
-  signUsingHash = true,
 }: {
   a: Account;
   t: Transaction;
-  signUsingHash: boolean | undefined;
 }): Promise<BigNumber> => {
-  const unsigned = await buildTransaction(a, t, signUsingHash);
+  const unsigned = await buildTransaction(a, t);
   return await getFees(JSON.parse(unsigned));
 };
 

package/src/families/elrond/js-signOperation.ts

@@ -7,13 +7,12 @@ import { open, close } from "../../hw";
 import { encodeOperationId } from "../../operation";
 import Elrond from "./hw-app-elrond";
 import { buildTransaction } from "./js-buildTransaction";
-import { getNonce, compareVersions } from "./logic";
+import { getNonce } from "./logic";
 
 const buildOptimisticOperation = (
   account: Account,
   transaction: Transaction,
-  fee: BigNumber,
-  signUsingHash: boolean
+  fee: BigNumber
 ): Operation => {
   const type = "OUT";
   const value = new BigNumber(transaction.amount);
@@ -30,9 +29,7 @@ const buildOptimisticOperation = (
     accountId: account.id,
     transactionSequenceNumber: getNonce(account),
     date: new Date(),
-    extra: {
-      signUsingHash,
-    },
+    extra: {},
   };
   return operation;
 };
@@ -60,29 +57,27 @@ const signOperation = ({
 
         const elrond = new Elrond(transport);
         await elrond.setAddress(account.freshAddressPath);
-        const { version } = await elrond.getAppConfiguration();
-        const signUsingHash = compareVersions(version, "1.0.11") >= 0;
-        const unsigned = await buildTransaction(
-          account,
-          transaction,
-          signUsingHash
-        );
+
+        const unsigned = await buildTransaction(account, transaction);
+
         o.next({
           type: "device-signature-requested",
         });
+
         const r = await elrond.signTransaction(
           account.freshAddressPath,
           unsigned,
-          signUsingHash
+          true
         );
+
         o.next({
           type: "device-signature-granted",
         });
+
         const operation = buildOptimisticOperation(
           account,
           transaction,
-          transaction.fees ?? new BigNumber(0),
-          signUsingHash
+          transaction.fees ?? new BigNumber(0)
         );
         o.next({
           type: "signed",

package/src/families/elrond/js-synchronisation.ts

@@ -32,6 +32,7 @@ const getAccountShape: GetAccountShape = async (info) => {
       nonce,
     },
   };
+
   return { ...shape, operations };
 };
 

package/src/families/elrond/js-transaction.ts

@@ -46,7 +46,6 @@ export const prepareTransaction = async (a: Account, t: Transaction) => {
   fees = await getEstimatedFees({
     a,
     t,
-    signUsingHash: true,
   });
 
   if (!sameFees(t.fees, fees)) {

package/src/families/elrond/logic.ts

@@ -12,30 +12,6 @@ const HRP = "erd";
  */
 const PUBKEY_LENGTH = 32;
 
-export const compareVersions = (versionA: string, versionB: string): number => {
-  let i, diff;
-  const regExStrip0 = /(\.0+)+$/;
-  const segmentsA = versionA.replace(regExStrip0, "").split(".");
-  const segmentsB = versionB.replace(regExStrip0, "").split(".");
-  const minVersionLength = Math.min(segmentsA.length, segmentsB.length);
-
-  for (i = 0; i < minVersionLength; i++) {
-    diff = parseInt(segmentsA[i], 10) - parseInt(segmentsB[i], 10);
-
-    if (diff == 0) {
-      continue;
-    }
-
-    if (diff < 0) {
-      return -1;
-    }
-
-    return 1;
-  }
-
-  return segmentsA.length - segmentsB.length;
-};
-
 function fromBech32(value: string): string {
   let decoded;
 

package/src/families/polkadot/api/sidecar.ts

@@ -657,7 +657,7 @@ export const getRegistry = async (): Promise<{
   extrinsics: Extrinsics;
 }> => {
   const [material, spec] = await Promise.all([
-    fetchTransactionMaterial(true),
+    getTransactionMaterialWithMetadata(),
     fetchChainSpec(),
   ]);
   const registry: any = new TypeRegistry();
@@ -710,3 +710,22 @@ export const getConstants: CacheRes<
     maxAge: 60 * 60 * 1000, // 1 hour
   }
 );
+
+/**
+ * Cache the fetchTransactionMaterial(true) to avoid too many calls
+ *
+ * @async
+ *
+ * @returns {Promise<Object>} consts
+ */
+export const getTransactionMaterialWithMetadata: CacheRes<
+  Array<void>,
+  SidecarTransactionMaterial
+> = makeLRUCache(
+  async (): Promise<SidecarTransactionMaterial> =>
+    fetchTransactionMaterial(true),
+  () => "polkadot",
+  {
+    maxAge: 60 * 60 * 1000, // 1 hour - could be Infinity
+  }
+);