@ledgerhq/device-core 0.3.2-nightly.5 → 0.3.3-next.0

package/src/commands/use-cases/app-backup/restoreAppStorageInit.ts

@@ -1,7 +1,13 @@
 import Transport, { StatusCodes, TransportStatusError } from "@ledgerhq/hw-transport";
 import { LocalTracer } from "@ledgerhq/logs";
 import type { APDU } from "../../entities/APDU";
-import { AppNotFound, InvalidAppNameLength, InvalidBackupLength, PinNotSet } from "../../../errors";
+import {
+  AppNotFound,
+  InvalidAppNameLength,
+  InvalidBackupLength,
+  PinNotSet,
+  UserRefusedOnDevice,
+} from "../../../errors";
 
 /**
  * Name in documentation: INS_APP_STORAGE_RESTORE_INIT
@@ -58,7 +64,6 @@ export async function restoreAppStorageInit(
   tracer.trace("Start");
 
   const params: Buffer = Buffer.concat([
-    Buffer.from([appName.length + 4]), // LC
     Buffer.from(backupSize.toString(16).padStart(8, "0"), "hex"), // BACKUP_LEN
     Buffer.from(appName, "ascii"), // APP_NAME
   ]);
@@ -82,8 +87,9 @@ export function parseResponse(data: Buffer): void {
     case StatusCodes.APP_NOT_FOUND_OR_INVALID_CONTEXT:
       throw new AppNotFound("Application not found.");
     case StatusCodes.DEVICE_IN_RECOVERY_MODE:
-    case StatusCodes.USER_REFUSED_ON_DEVICE:
       break;
+    case StatusCodes.USER_REFUSED_ON_DEVICE:
+      throw new UserRefusedOnDevice("User refused on device.");
     case StatusCodes.PIN_NOT_SET:
       throw new PinNotSet("Invalid consent, PIN is not set.");
     case StatusCodes.INVALID_APP_NAME_LENGTH:

package/src/errors.ts

@@ -27,3 +27,5 @@ export const InvalidBackupState = createCustomErrorClass("InvalidBackupState");
 export const InvalidRestoreState = createCustomErrorClass("InvalidRestoreState");
 // 0x6734
 export const InvalidChunkLength = createCustomErrorClass("InvalidChunkLength");
+// 0x5501
+export const UserRefusedOnDevice = createCustomErrorClass("UserRefusedOnDevice");

package/src/index.ts

@@ -40,3 +40,5 @@ export { supportedDeviceModelIds } from "./capabilities/isCustomLockScreenSuppor
 export * from "./customLockScreen/screenSpecs";
 // src/firmwareUpdate/
 export { shouldForceFirmwareUpdate } from "./firmwareUpdate/shouldForceFirmwareUpdate";
+// errors
+export * from "./errors";

package/src/managerApi/repositories/HttpManagerApiRepository.test.ts

@@ -43,13 +43,14 @@ describe("HttpManagerApiRepository", () => {
     });
 
     expect(networkSpy).toHaveBeenCalledWith({
-      method: "POST",
-      url: "http://managerApiBase.com/get_latest_firmware?livecommonversion=1.2.3&salt=mockedFirmwareSalt",
-      data: {
-        current_se_firmware_final_version: 888,
-        device_version: 123,
-        provider: 12,
-      },
+      method: "GET",
+      url:
+        "http://managerApiBase.com/get_latest_firmware" +
+        "?livecommonversion=1.2.3" +
+        "&salt=mockedFirmwareSalt" +
+        "&current_se_firmware_final_version=888" +
+        "&device_version=123" +
+        "&provider=12",
     });
   });
 
@@ -128,12 +129,12 @@ describe("HttpManagerApiRepository", () => {
     });
 
     expect(networkSpy).toHaveBeenCalledWith({
-      method: "POST",
-      url: "http://managerApiBase.com/get_device_version?livecommonversion=1.2.3",
-      data: {
-        target_id: 123,
-        provider: 12,
-      },
+      method: "GET",
+      url:
+        "http://managerApiBase.com/get_device_version" +
+        "?livecommonversion=1.2.3" +
+        "&provider=12" +
+        "&target_id=123",
     });
   });
 
@@ -190,13 +191,13 @@ describe("HttpManagerApiRepository", () => {
     });
 
     expect(networkSpy).toHaveBeenCalledWith({
-      method: "POST",
-      url: "http://managerApiBase.com/get_osu_version?livecommonversion=1.2.3",
-      data: {
-        device_version: 123,
-        provider: 12,
-        version_name: "mockedVersion-osu",
-      },
+      method: "GET",
+      url:
+        "http://managerApiBase.com/get_osu_version" +
+        "?livecommonversion=1.2.3" +
+        "&device_version=123" +
+        "&version_name=mockedVersion-osu" +
+        "&provider=12",
     });
   });
 
@@ -226,13 +227,13 @@ describe("HttpManagerApiRepository", () => {
     });
 
     expect(networkSpy).toHaveBeenCalledWith({
-      method: "POST",
-      url: "http://managerApiBase.com/get_firmware_version?livecommonversion=1.2.3",
-      data: {
-        device_version: 123,
-        provider: 12,
-        version_name: "mockedVersion",
-      },
+      method: "GET",
+      url:
+        "http://managerApiBase.com/get_firmware_version" +
+        "?livecommonversion=1.2.3" +
+        "&device_version=123" +
+        "&version_name=mockedVersion" +
+        "&provider=12",
     });
   });
 

package/src/managerApi/repositories/HttpManagerApiRepository.ts

@@ -37,19 +37,17 @@ export class HttpManagerApiRepository implements ManagerApiRepository {
           se_firmware_osu_version: OsuFirmware;
         };
       } = await network({
-        method: "POST",
+        method: "GET",
         url: URL.format({
           pathname: `${this.managerApiBase}/get_latest_firmware`,
           query: {
             livecommonversion: this.liveCommonVersion,
             salt,
+            current_se_firmware_final_version,
+            device_version,
+            provider: providerId,
           },
         }),
-        data: {
-          current_se_firmware_final_version,
-          device_version,
-          provider: providerId,
-        },
       });
 
       if (data.result === "null") {
@@ -84,17 +82,15 @@ export class HttpManagerApiRepository implements ManagerApiRepository {
       }: {
         data: DeviceVersionEntity;
       } = await network({
-        method: "POST",
+        method: "GET",
         url: URL.format({
           pathname: `${this.managerApiBase}/get_device_version`,
           query: {
             livecommonversion: this.liveCommonVersion,
+            provider: providerId,
+            target_id: targetId,
           },
         }),
-        data: {
-          provider: providerId,
-          target_id: targetId,
-        },
       }).catch(error => {
         const status = error?.status || error?.response?.status;
 
@@ -113,18 +109,16 @@ export class HttpManagerApiRepository implements ManagerApiRepository {
   readonly getCurrentOSU: ManagerApiRepository["getCurrentOSU"] = makeLRUCache(
     async input => {
       const { data } = await network({
-        method: "POST",
+        method: "GET",
         url: URL.format({
           pathname: `${this.managerApiBase}/get_osu_version`,
           query: {
             livecommonversion: this.liveCommonVersion,
+            device_version: input.deviceId,
+            version_name: `${input.version}-osu`,
+            provider: input.providerId,
           },
         }),
-        data: {
-          device_version: input.deviceId,
-          version_name: `${input.version}-osu`,
-          provider: input.providerId,
-        },
       });
       return data;
     },
@@ -138,18 +132,16 @@ export class HttpManagerApiRepository implements ManagerApiRepository {
       }: {
         data: FinalFirmware;
       } = await network({
-        method: "POST",
+        method: "GET",
         url: URL.format({
           pathname: `${this.managerApiBase}/get_firmware_version`,
           query: {
             livecommonversion: this.liveCommonVersion,
+            device_version: input.deviceId,
+            version_name: input.version,
+            provider: input.providerId,
           },
         }),
-        data: {
-          device_version: input.deviceId,
-          version_name: input.version,
-          provider: input.providerId,
-        },
       }).catch(error => {
         const status = error?.status || error?.response?.status;