@ledgerhq/coin-xrp 7.7.0-nightly.5 → 7.7.0-nightly.6

package/.turbo/turbo-build.log

@@ -1,4 +1,4 @@
 
-> @ledgerhq/coin-xrp@7.7.0-nightly.4 build /home/runner/work/ledger-live/ledger-live/libs/coin-modules/coin-xrp
+> @ledgerhq/coin-xrp@7.7.0-nightly.5 build /home/runner/work/ledger-live/ledger-live/libs/coin-modules/coin-xrp
 > tsc && tsc -m esnext --moduleResolution bundler --outDir lib-es
 

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @ledgerhq/coin-xrp
 
+## 7.7.0-nightly.6
+
+### Minor Changes
+
+- [#12502](https://github.com/LedgerHQ/ledger-live/pull/12502) [`ca46e69`](https://github.com/LedgerHQ/ledger-live/commit/ca46e69b57011db61deeb9a862896afe62038829) Thanks [@jnicoulaud-ledger](https://github.com/jnicoulaud-ledger)! - fix(coin-module,xrp): fix destinationTag=0 ignored
+
+### Patch Changes
+
+- Updated dependencies [[`607e4be`](https://github.com/LedgerHQ/ledger-live/commit/607e4be33145c102debce1606224b08579888aa8)]:
+  - @ledgerhq/cryptoassets@13.32.0-nightly.4
+  - @ledgerhq/coin-framework@6.8.0-nightly.6
+
 ## 7.7.0-nightly.5
 
 ### Patch Changes

package/lib/logic/craftTransaction.js

@@ -39,7 +39,7 @@ async function craftTransaction(account, transaction, publicKey) {
     if (transaction.memos) {
         xrplTransaction.Memos = transaction.memos.map(memoMapper);
     }
-    if (transaction.destinationTag) {
+    if (transaction.destinationTag !== null && transaction.destinationTag !== undefined) {
         (0, invariant_1.default)((0, utils_1.validateTag)(new bignumber_js_1.default(transaction.destinationTag)), `tag is set but is not in a valid format, should be between [0 - ${utils_1.UINT32_MAX.toString()}]`);
         xrplTransaction.DestinationTag = transaction.destinationTag;
     }

package/lib/logic/craftTransaction.js.map

@@ -1 +1 @@
-{"version":3,"file":"craftTransaction.js","sourceRoot":"","sources":["../../src/logic/craftTransaction.ts"],"names":[],"mappings":";;;;;AAsCA,4CAmEC;AAzGD,gEAAqC;AACrC,0DAAkC;AAClC,6DAA6C;AAC7C,uGAA8E;AAC9E,wCAA4C;AAC5C,mCAAkD;AAElD,MAAM,aAAa,GAAG,EAAE,CAAC;AAEzB,MAAM,EAAE,iBAAiB,EAAE,GAAG,0BAAe,CAAC;AA6BvC,KAAK,UAAU,gBAAgB,CACpC,OAGC,EACD,WAMC,EACD,SAAkB;IAKlB,MAAM,eAAe,GAAoB;QACvC,eAAe,EAAE,SAAS;QAC1B,OAAO,EAAE,OAAO,CAAC,OAAO;QACxB,MAAM,EAAE,WAAW,CAAC,MAAM,CAAC,QAAQ,EAAE;QACrC,WAAW,EAAE,WAAW,CAAC,SAAS;QAClC,GAAG,EAAE,WAAW,CAAC,IAAI,CAAC,QAAQ,EAAE;QAChC,KAAK,EAAE,UAAU;QACjB,QAAQ,EAAE,OAAO,CAAC,kBAAkB;QACpC,kBAAkB,EAAE,CAAC,MAAM,IAAA,wBAAc,GAAE,CAAC,GAAG,aAAa;KAC7D,CAAC;IAEF,SAAS,UAAU,CAAC,SAAoB;QACtC,MAAM,IAAI,GAAS,EAAE,CAAC;QACtB,IAAI,SAAS,CAAC,IAAI,EAAE,CAAC;YACnB,IAAI,CAAC,QAAQ,GAAG,SAAS,CAAC,IAAI,CAAC;QACjC,CAAC;QACD,IAAI,SAAS,CAAC,MAAM,EAAE,CAAC;YACrB,IAAI,CAAC,UAAU,GAAG,SAAS,CAAC,MAAM,CAAC;QACrC,CAAC;QACD,IAAI,SAAS,CAAC,IAAI,EAAE,CAAC;YACnB,IAAI,CAAC,QAAQ,GAAG,SAAS,CAAC,IAAI,CAAC;QACjC,CAAC;QACD,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;IACxB,CAAC;IAED,IAAI,WAAW,CAAC,KAAK,EAAE,CAAC;QACtB,eAAe,CAAC,KAAK,GAAG,WAAW,CAAC,KAAK,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;IAC5D,CAAC;IAED,IAAI,WAAW,CAAC,cAAc,EAAE,CAAC;QAC/B,IAAA,mBAAS,EACP,IAAA,mBAAW,EAAC,IAAI,sBAAS,CAAC,WAAW,CAAC,cAAc,CAAC,CAAC,EACtD,mEAAmE,kBAAU,CAAC,QAAQ,EAAE,GAAG,CAC5F,CAAC;QACF,eAAe,CAAC,cAAc,GAAG,WAAW,CAAC,cAAc,CAAC;IAC9D,CAAC;IAED,MAAM,qBAAqB,GAAG,SAAS;QACrC,CAAC,CAAC,IAAA,4BAAM,EAAC;YACL,GAAG,eAAe;YAClB,aAAa,EAAE,SAAS;SACzB,CAAC;QACJ,CAAC,CAAC,IAAA,4BAAM,EAAC;YACL,GAAG,eAAe;SACnB,CAAC,CAAC;IAEP,OAAO;QACL,eAAe;QACf,qBAAqB;KACtB,CAAC;AACJ,CAAC"}
+{"version":3,"file":"craftTransaction.js","sourceRoot":"","sources":["../../src/logic/craftTransaction.ts"],"names":[],"mappings":";;;;;AAsCA,4CAmEC;AAzGD,gEAAqC;AACrC,0DAAkC;AAClC,6DAA6C;AAC7C,uGAA8E;AAC9E,wCAA4C;AAC5C,mCAAkD;AAElD,MAAM,aAAa,GAAG,EAAE,CAAC;AAEzB,MAAM,EAAE,iBAAiB,EAAE,GAAG,0BAAe,CAAC;AA6BvC,KAAK,UAAU,gBAAgB,CACpC,OAGC,EACD,WAMC,EACD,SAAkB;IAKlB,MAAM,eAAe,GAAoB;QACvC,eAAe,EAAE,SAAS;QAC1B,OAAO,EAAE,OAAO,CAAC,OAAO;QACxB,MAAM,EAAE,WAAW,CAAC,MAAM,CAAC,QAAQ,EAAE;QACrC,WAAW,EAAE,WAAW,CAAC,SAAS;QAClC,GAAG,EAAE,WAAW,CAAC,IAAI,CAAC,QAAQ,EAAE;QAChC,KAAK,EAAE,UAAU;QACjB,QAAQ,EAAE,OAAO,CAAC,kBAAkB;QACpC,kBAAkB,EAAE,CAAC,MAAM,IAAA,wBAAc,GAAE,CAAC,GAAG,aAAa;KAC7D,CAAC;IAEF,SAAS,UAAU,CAAC,SAAoB;QACtC,MAAM,IAAI,GAAS,EAAE,CAAC;QACtB,IAAI,SAAS,CAAC,IAAI,EAAE,CAAC;YACnB,IAAI,CAAC,QAAQ,GAAG,SAAS,CAAC,IAAI,CAAC;QACjC,CAAC;QACD,IAAI,SAAS,CAAC,MAAM,EAAE,CAAC;YACrB,IAAI,CAAC,UAAU,GAAG,SAAS,CAAC,MAAM,CAAC;QACrC,CAAC;QACD,IAAI,SAAS,CAAC,IAAI,EAAE,CAAC;YACnB,IAAI,CAAC,QAAQ,GAAG,SAAS,CAAC,IAAI,CAAC;QACjC,CAAC;QACD,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;IACxB,CAAC;IAED,IAAI,WAAW,CAAC,KAAK,EAAE,CAAC;QACtB,eAAe,CAAC,KAAK,GAAG,WAAW,CAAC,KAAK,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;IAC5D,CAAC;IAED,IAAI,WAAW,CAAC,cAAc,KAAK,IAAI,IAAI,WAAW,CAAC,cAAc,KAAK,SAAS,EAAE,CAAC;QACpF,IAAA,mBAAS,EACP,IAAA,mBAAW,EAAC,IAAI,sBAAS,CAAC,WAAW,CAAC,cAAc,CAAC,CAAC,EACtD,mEAAmE,kBAAU,CAAC,QAAQ,EAAE,GAAG,CAC5F,CAAC;QACF,eAAe,CAAC,cAAc,GAAG,WAAW,CAAC,cAAc,CAAC;IAC9D,CAAC;IAED,MAAM,qBAAqB,GAAG,SAAS;QACrC,CAAC,CAAC,IAAA,4BAAM,EAAC;YACL,GAAG,eAAe;YAClB,aAAa,EAAE,SAAS;SACzB,CAAC;QACJ,CAAC,CAAC,IAAA,4BAAM,EAAC;YACL,GAAG,eAAe;SACnB,CAAC,CAAC;IAEP,OAAO;QACL,eAAe;QACf,qBAAqB;KACtB,CAAC;AACJ,CAAC"}

package/lib-es/logic/craftTransaction.js

@@ -33,7 +33,7 @@ export async function craftTransaction(account, transaction, publicKey) {
     if (transaction.memos) {
         xrplTransaction.Memos = transaction.memos.map(memoMapper);
     }
-    if (transaction.destinationTag) {
+    if (transaction.destinationTag !== null && transaction.destinationTag !== undefined) {
         invariant(validateTag(new BigNumber(transaction.destinationTag)), `tag is set but is not in a valid format, should be between [0 - ${UINT32_MAX.toString()}]`);
         xrplTransaction.DestinationTag = transaction.destinationTag;
     }

package/lib-es/logic/craftTransaction.js.map

@@ -1 +1 @@
-{"version":3,"file":"craftTransaction.js","sourceRoot":"","sources":["../../src/logic/craftTransaction.ts"],"names":[],"mappings":"AAAA,OAAO,SAAS,MAAM,cAAc,CAAC;AACrC,OAAO,SAAS,MAAM,WAAW,CAAC;AAClC,OAAO,EAAE,MAAM,EAAE,MAAM,qBAAqB,CAAC;AAC7C,OAAO,eAAe,MAAM,iDAAiD,CAAC;AAC9E,OAAO,EAAE,cAAc,EAAE,MAAM,YAAY,CAAC;AAC5C,OAAO,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,SAAS,CAAC;AAElD,MAAM,aAAa,GAAG,EAAE,CAAC;AAEzB,MAAM,EAAE,iBAAiB,EAAE,GAAG,eAAe,CAAC;AA6B9C,MAAM,CAAC,KAAK,UAAU,gBAAgB,CACpC,OAGC,EACD,WAMC,EACD,SAAkB;IAKlB,MAAM,eAAe,GAAoB;QACvC,eAAe,EAAE,SAAS;QAC1B,OAAO,EAAE,OAAO,CAAC,OAAO;QACxB,MAAM,EAAE,WAAW,CAAC,MAAM,CAAC,QAAQ,EAAE;QACrC,WAAW,EAAE,WAAW,CAAC,SAAS;QAClC,GAAG,EAAE,WAAW,CAAC,IAAI,CAAC,QAAQ,EAAE;QAChC,KAAK,EAAE,UAAU;QACjB,QAAQ,EAAE,OAAO,CAAC,kBAAkB;QACpC,kBAAkB,EAAE,CAAC,MAAM,cAAc,EAAE,CAAC,GAAG,aAAa;KAC7D,CAAC;IAEF,SAAS,UAAU,CAAC,SAAoB;QACtC,MAAM,IAAI,GAAS,EAAE,CAAC;QACtB,IAAI,SAAS,CAAC,IAAI,EAAE,CAAC;YACnB,IAAI,CAAC,QAAQ,GAAG,SAAS,CAAC,IAAI,CAAC;QACjC,CAAC;QACD,IAAI,SAAS,CAAC,MAAM,EAAE,CAAC;YACrB,IAAI,CAAC,UAAU,GAAG,SAAS,CAAC,MAAM,CAAC;QACrC,CAAC;QACD,IAAI,SAAS,CAAC,IAAI,EAAE,CAAC;YACnB,IAAI,CAAC,QAAQ,GAAG,SAAS,CAAC,IAAI,CAAC;QACjC,CAAC;QACD,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;IACxB,CAAC;IAED,IAAI,WAAW,CAAC,KAAK,EAAE,CAAC;QACtB,eAAe,CAAC,KAAK,GAAG,WAAW,CAAC,KAAK,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;IAC5D,CAAC;IAED,IAAI,WAAW,CAAC,cAAc,EAAE,CAAC;QAC/B,SAAS,CACP,WAAW,CAAC,IAAI,SAAS,CAAC,WAAW,CAAC,cAAc,CAAC,CAAC,EACtD,mEAAmE,UAAU,CAAC,QAAQ,EAAE,GAAG,CAC5F,CAAC;QACF,eAAe,CAAC,cAAc,GAAG,WAAW,CAAC,cAAc,CAAC;IAC9D,CAAC;IAED,MAAM,qBAAqB,GAAG,SAAS;QACrC,CAAC,CAAC,MAAM,CAAC;YACL,GAAG,eAAe;YAClB,aAAa,EAAE,SAAS;SACzB,CAAC;QACJ,CAAC,CAAC,MAAM,CAAC;YACL,GAAG,eAAe;SACnB,CAAC,CAAC;IAEP,OAAO;QACL,eAAe;QACf,qBAAqB;KACtB,CAAC;AACJ,CAAC"}
+{"version":3,"file":"craftTransaction.js","sourceRoot":"","sources":["../../src/logic/craftTransaction.ts"],"names":[],"mappings":"AAAA,OAAO,SAAS,MAAM,cAAc,CAAC;AACrC,OAAO,SAAS,MAAM,WAAW,CAAC;AAClC,OAAO,EAAE,MAAM,EAAE,MAAM,qBAAqB,CAAC;AAC7C,OAAO,eAAe,MAAM,iDAAiD,CAAC;AAC9E,OAAO,EAAE,cAAc,EAAE,MAAM,YAAY,CAAC;AAC5C,OAAO,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,SAAS,CAAC;AAElD,MAAM,aAAa,GAAG,EAAE,CAAC;AAEzB,MAAM,EAAE,iBAAiB,EAAE,GAAG,eAAe,CAAC;AA6B9C,MAAM,CAAC,KAAK,UAAU,gBAAgB,CACpC,OAGC,EACD,WAMC,EACD,SAAkB;IAKlB,MAAM,eAAe,GAAoB;QACvC,eAAe,EAAE,SAAS;QAC1B,OAAO,EAAE,OAAO,CAAC,OAAO;QACxB,MAAM,EAAE,WAAW,CAAC,MAAM,CAAC,QAAQ,EAAE;QACrC,WAAW,EAAE,WAAW,CAAC,SAAS;QAClC,GAAG,EAAE,WAAW,CAAC,IAAI,CAAC,QAAQ,EAAE;QAChC,KAAK,EAAE,UAAU;QACjB,QAAQ,EAAE,OAAO,CAAC,kBAAkB;QACpC,kBAAkB,EAAE,CAAC,MAAM,cAAc,EAAE,CAAC,GAAG,aAAa;KAC7D,CAAC;IAEF,SAAS,UAAU,CAAC,SAAoB;QACtC,MAAM,IAAI,GAAS,EAAE,CAAC;QACtB,IAAI,SAAS,CAAC,IAAI,EAAE,CAAC;YACnB,IAAI,CAAC,QAAQ,GAAG,SAAS,CAAC,IAAI,CAAC;QACjC,CAAC;QACD,IAAI,SAAS,CAAC,MAAM,EAAE,CAAC;YACrB,IAAI,CAAC,UAAU,GAAG,SAAS,CAAC,MAAM,CAAC;QACrC,CAAC;QACD,IAAI,SAAS,CAAC,IAAI,EAAE,CAAC;YACnB,IAAI,CAAC,QAAQ,GAAG,SAAS,CAAC,IAAI,CAAC;QACjC,CAAC;QACD,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;IACxB,CAAC;IAED,IAAI,WAAW,CAAC,KAAK,EAAE,CAAC;QACtB,eAAe,CAAC,KAAK,GAAG,WAAW,CAAC,KAAK,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;IAC5D,CAAC;IAED,IAAI,WAAW,CAAC,cAAc,KAAK,IAAI,IAAI,WAAW,CAAC,cAAc,KAAK,SAAS,EAAE,CAAC;QACpF,SAAS,CACP,WAAW,CAAC,IAAI,SAAS,CAAC,WAAW,CAAC,cAAc,CAAC,CAAC,EACtD,mEAAmE,UAAU,CAAC,QAAQ,EAAE,GAAG,CAC5F,CAAC;QACF,eAAe,CAAC,cAAc,GAAG,WAAW,CAAC,cAAc,CAAC;IAC9D,CAAC;IAED,MAAM,qBAAqB,GAAG,SAAS;QACrC,CAAC,CAAC,MAAM,CAAC;YACL,GAAG,eAAe;YAClB,aAAa,EAAE,SAAS;SACzB,CAAC;QACJ,CAAC,CAAC,MAAM,CAAC;YACL,GAAG,eAAe;SACnB,CAAC,CAAC;IAEP,OAAO;QACL,eAAe;QACf,qBAAqB;KACtB,CAAC;AACJ,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ledgerhq/coin-xrp",
-  "version": "7.7.0-nightly.5",
+  "version": "7.7.0-nightly.6",
   "description": "Ledger XRP Coin integration",
   "keywords": [
     "Ledger",
@@ -103,13 +103,13 @@
     "invariant": "^2.2.4",
     "ripple-address-codec": "^5.0.0",
     "ripple-binary-codec": "^1.3.0",
-    "@ledgerhq/coin-framework": "^6.8.0-nightly.5",
-    "@ledgerhq/cryptoassets": "^13.32.0-nightly.3",
+    "@ledgerhq/coin-framework": "^6.8.0-nightly.6",
+    "@ledgerhq/cryptoassets": "^13.32.0-nightly.4",
     "@ledgerhq/devices": "8.7.0-nightly.1",
     "@ledgerhq/errors": "^6.27.0-nightly.0",
     "@ledgerhq/live-network": "^2.1.0-nightly.1",
-    "@ledgerhq/types-live": "^6.88.0-nightly.3",
-    "@ledgerhq/logs": "^6.13.0"
+    "@ledgerhq/logs": "^6.13.0",
+    "@ledgerhq/types-live": "^6.88.0-nightly.3"
   },
   "devDependencies": {
     "@faker-js/faker": "^8.4.1",

package/src/logic/craftTransaction.test.ts

@@ -36,7 +36,7 @@ describe("craftTransaction", () => {
     expect(result.serializedTransaction).toBeDefined();
   });
 
-  it("returns a valid transaction object when pubky is provided", async () => {
+  it("returns a valid transaction object when pubkey is provided", async () => {
     // Given
     const account = {
       address: "rPDf6SQStnNmw1knCu1ei7h6BcDAEUUqn5",
@@ -75,4 +75,36 @@ describe("craftTransaction", () => {
     ]);
     expect(binDecodedTx.DestinationTag).toEqual(123);
   });
+
+  it("returns expected transaction when destinationTag is set to zero", async () => {
+    // Given
+    const account = {
+      address: "rPDf6SQStnNmw1knCu1ei7h6BcDAEUUqn5",
+      nextSequenceNumber: 2,
+    };
+    const transaction = {
+      recipient: "rJe1St1G6BWMFmdrrcT7NdD3XT1NxTMEWN",
+      amount: BigInt(100_000_000),
+      fees: BigInt(100),
+      destinationTag: 0,
+    };
+
+    // When
+    const result = await craftTransaction(account, transaction);
+
+    // Then
+    expect(result).toBeDefined();
+    expect(result.xrplTransaction).toEqual({
+      TransactionType: "Payment",
+      Account: "rPDf6SQStnNmw1knCu1ei7h6BcDAEUUqn5",
+      Amount: "100000000",
+      Destination: "rJe1St1G6BWMFmdrrcT7NdD3XT1NxTMEWN",
+      DestinationTag: 0,
+      Fee: "100",
+      Flags: 2147483648,
+      Sequence: 2,
+      LastLedgerSequence: 21,
+    });
+    expect(result.serializedTransaction).toBeDefined();
+  });
 });

package/src/logic/craftTransaction.ts

@@ -82,7 +82,7 @@ export async function craftTransaction(
     xrplTransaction.Memos = transaction.memos.map(memoMapper);
   }
 
-  if (transaction.destinationTag) {
+  if (transaction.destinationTag !== null && transaction.destinationTag !== undefined) {
     invariant(
       validateTag(new BigNumber(transaction.destinationTag)),
       `tag is set but is not in a valid format, should be between [0 - ${UINT32_MAX.toString()}]`,