@ledgerhq/coin-xrp 7.24.0 → 7.25.2

package/lib-es/utils/predicates.d.ts

@@ -0,0 +1,5 @@
+import type { ErrorResponse } from '../network/types';
+import type { SignerEntry } from '../types';
+export declare function isSignerEntry(obj: unknown): obj is SignerEntry;
+export declare function isErrorResponse(obj: object): obj is ErrorResponse;
+//# sourceMappingURL=predicates.d.ts.map

package/lib-es/utils/predicates.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"predicates.d.ts","sourceRoot":"","sources":["../../src/utils/predicates.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAA;AACrD,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,UAAU,CAAA;AAE3C,wBAAgB,aAAa,CAAC,GAAG,EAAE,OAAO,GAAG,GAAG,IAAI,WAAW,CAc9D;AAED,wBAAgB,eAAe,CAAC,GAAG,EAAE,MAAM,GAAG,GAAG,IAAI,aAAa,CAEjE"}

package/lib-es/utils/predicates.js

@@ -0,0 +1,19 @@
+// SPDX-FileCopyrightText: © 2024 LEDGER SAS
+// SPDX-License-Identifier: Apache-2.0
+export function isSignerEntry(obj) {
+    return (typeof obj === 'object' &&
+        obj !== null &&
+        'Signer' in obj &&
+        typeof obj.Signer === 'object' &&
+        obj.Signer !== null &&
+        'Account' in obj.Signer &&
+        typeof obj.Signer.Account === 'string' &&
+        'SigningPubKey' in obj.Signer &&
+        typeof obj.Signer.SigningPubKey === 'string' &&
+        'TxnSignature' in obj.Signer &&
+        typeof obj.Signer.TxnSignature === 'string');
+}
+export function isErrorResponse(obj) {
+    return 'status' in obj && obj.status === 'error';
+}
+//# sourceMappingURL=predicates.js.map

package/lib-es/utils/predicates.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"predicates.js","sourceRoot":"","sources":["../../src/utils/predicates.ts"],"names":[],"mappings":"AAAA,4CAA4C;AAC5C,sCAAsC;AAKtC,MAAM,UAAU,aAAa,CAAC,GAAY;IACxC,OAAO,CACL,OAAO,GAAG,KAAK,QAAQ;QACvB,GAAG,KAAK,IAAI;QACZ,QAAQ,IAAI,GAAG;QACf,OAAO,GAAG,CAAC,MAAM,KAAK,QAAQ;QAC9B,GAAG,CAAC,MAAM,KAAK,IAAI;QACnB,SAAS,IAAI,GAAG,CAAC,MAAM;QACvB,OAAO,GAAG,CAAC,MAAM,CAAC,OAAO,KAAK,QAAQ;QACtC,eAAe,IAAI,GAAG,CAAC,MAAM;QAC7B,OAAO,GAAG,CAAC,MAAM,CAAC,aAAa,KAAK,QAAQ;QAC5C,cAAc,IAAI,GAAG,CAAC,MAAM;QAC5B,OAAO,GAAG,CAAC,MAAM,CAAC,YAAY,KAAK,QAAQ,CAC5C,CAAA;AACH,CAAC;AAED,MAAM,UAAU,eAAe,CAAC,GAAW;IACzC,OAAO,QAAQ,IAAI,GAAG,IAAI,GAAG,CAAC,MAAM,KAAK,OAAO,CAAA;AAClD,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ledgerhq/coin-xrp",
-  "version": "7.24.0",
+  "version": "7.25.2",
   "description": "Ledger XRP Coin integration",
   "keywords": [
     "Ledger",
@@ -20,6 +20,12 @@
   "publishConfig": {
     "access": "public"
   },
+  "files": [
+    "lib",
+    "lib-es",
+    "src",
+    "CHANGELOG.md"
+  ],
   "typesVersions": {
     "*": {
       "lib/*": [
@@ -72,10 +78,9 @@
     "invariant": "^2.2.4",
     "ripple-address-codec": "^5.0.0",
     "ripple-binary-codec": "^1.3.0",
-    "@ledgerhq/coin-module-framework": "^3.5.1"
+    "@ledgerhq/coin-module-framework": "^4.0.0"
   },
   "devDependencies": {
-    "@faker-js/faker": "^8.4.1",
     "@swc/core": "1.15.11",
     "@swc/jest": "0.2.39",
     "@types/invariant": "^2.2.37",
@@ -104,7 +109,7 @@
     "test": "jest",
     "test:debug": "node --inspect-brk ./node_modules/jest/bin/jest.js --runInBand",
     "test-watch": "jest --watch",
-    "test-integ": "jest --config=jest.integ.config.js --passWithNoTests",
+    "test-integ": "jest --config=jest.integ.config.js",
     "test-integ:debug": "node --inspect-brk ./node_modules/jest/bin/jest.js --runInBand --config=jest.integ.config.js",
     "typecheck": "tsc --noEmit --customConditions node",
     "unimported": "knip --include=files,dependencies",

package/src/api/combine.test.ts

@@ -5,12 +5,6 @@ import { decode, encode } from 'ripple-binary-codec'
 import { SignerEntry } from '../types'
 import { combine } from './combine'
 
-type DecodedTx = {
-  SigningPubKey?: string
-  TxnSignature?: string
-  Signers?: SignerEntry[]
-}
-
 function signerEntry(account: string, signingPubKey: string, txnSignature = ''): SignerEntry {
   return {
     Signer: {
@@ -45,12 +39,13 @@ describe('combine', () => {
       ],
     })
 
-    const combined = combine(tx, 'A1B2')
-    const decoded = decode(combined) as DecodedTx
-
-    expect(decoded.Signers?.[0]?.Signer.TxnSignature).toBe('A1B2')
-    expect(decoded.Signers?.[1]?.Signer.TxnSignature).toBe('')
-    expect(decoded.Signers?.[2]?.Signer.TxnSignature).toBe('DEADBEEF')
+    expect(decode(combine(tx, 'A1B2'))).toMatchObject({
+      Signers: [
+        { Signer: { TxnSignature: 'A1B2' } },
+        { Signer: { TxnSignature: '' } },
+        { Signer: { TxnSignature: 'DEADBEEF' } },
+      ],
+    })
   })
 
   it('fills the matching multi-sign signer signature when public key is provided', () => {
@@ -63,11 +58,9 @@ describe('combine', () => {
       Signers: [signerEntry(signer1, pubKey1, ''), signerEntry(signer2, pubKey2, '')],
     })
 
-    const combined = combine(tx, 'B2C3', pubKey2)
-    const decoded = decode(combined) as DecodedTx
-
-    expect(decoded.Signers?.[0]?.Signer.TxnSignature).toBe('')
-    expect(decoded.Signers?.[1]?.Signer.TxnSignature).toBe('B2C3')
+    expect(decode(combine(tx, 'B2C3', pubKey2))).toMatchObject({
+      Signers: [{ Signer: { TxnSignature: '' } }, { Signer: { TxnSignature: 'B2C3' } }],
+    })
   })
 
   it('sets TxnSignature and missing SigningPubKey for single-sign transactions', () => {
@@ -78,11 +71,10 @@ describe('combine', () => {
       Destination: destination,
     })
 
-    const combined = combine(tx, 'C3D4', pubKey1)
-    const decoded = decode(combined) as DecodedTx
-
-    expect(decoded.TxnSignature).toBe('C3D4')
-    expect(decoded.SigningPubKey).toBe(pubKey1)
+    expect(decode(combine(tx, 'C3D4', pubKey1))).toMatchObject({
+      TxnSignature: 'C3D4',
+      SigningPubKey: pubKey1,
+    })
   })
 
   it('does not overwrite existing SigningPubKey for single-sign transactions', () => {
@@ -94,10 +86,9 @@ describe('combine', () => {
       SigningPubKey: pubKey2,
     })
 
-    const combined = combine(tx, 'D4E5', pubKey3)
-    const decoded = decode(combined) as DecodedTx
-
-    expect(decoded.TxnSignature).toBe('D4E5')
-    expect(decoded.SigningPubKey).toBe(pubKey2)
+    expect(decode(combine(tx, 'D4E5', pubKey3))).toMatchObject({
+      TxnSignature: 'D4E5',
+      SigningPubKey: pubKey2,
+    })
   })
 })

package/src/api/craftRawTransaction.test.ts

@@ -3,6 +3,7 @@
 
 import { encode, decode } from 'ripple-binary-codec'
 import { SignerEntry } from '../types'
+import { isSignerEntry } from '../utils/predicates'
 import { craftRawTransaction } from './craftRawTransaction'
 
 // --- Mocks ---
@@ -45,12 +46,10 @@ describe('craftRawTransaction', () => {
 
   // Helper to safely extract Signers array without relying on type assertions elsewhere
   function getSigners(obj: unknown): SignerEntry[] | undefined {
-    if (!obj || typeof obj !== 'object') return undefined
-    const potential = (obj as { Signers?: unknown }).Signers
-    if (Array.isArray(potential)) {
-      return potential as SignerEntry[]
-    }
-    return undefined
+    if (!obj || typeof obj !== 'object' || !('Signers' in obj)) return undefined
+    const signers = obj.Signers
+    if (!Array.isArray(signers)) return undefined
+    return signers.filter(isSignerEntry)
   }
 
   it('fills missing Fee, Sequence, LastLedgerSequence & SigningPubKey for a standard payment', async () => {

package/src/api/craftRawTransaction.ts

@@ -7,6 +7,7 @@ import { JsonObject } from 'ripple-binary-codec/dist/types/serialized-type'
 import { getLedgerIndex } from '../network'
 import { SignerEntry } from '../types'
 import { sortSignersByNumericAddress } from '../utils'
+import { isSignerEntry } from '../utils/predicates'
 import { estimateFees } from './estimateFees'
 
 const LEDGER_OFFSET = 20
@@ -37,7 +38,9 @@ function craftRawTransactionMultiSign(
     xrplTransaction.Signers.push(signer)
     // The Signers array must be sorted based on the numeric value of the signer addresses
     // We could probably insert it at the right place directly but like this we make sure the rest is also sorted.
-    xrplTransaction.Signers = sortSignersByNumericAddress(xrplTransaction.Signers as SignerEntry[])
+    xrplTransaction.Signers = sortSignersByNumericAddress(
+      xrplTransaction.Signers.filter(isSignerEntry)
+    )
   }
 
   const serializedTransaction = encode(xrplTransaction)

package/src/api/getBalance.test.ts

@@ -1,7 +1,6 @@
 // SPDX-FileCopyrightText: © 2024 LEDGER SAS
 // SPDX-License-Identifier: Apache-2.0
 
-import { faker } from '@faker-js/faker'
 import { getBalance } from './getBalance'
 
 const address = 'ACCOUNT_ADDRESS'
@@ -28,9 +27,8 @@ describe('getBalance', () => {
       },
     })
     // Given
-    const balance = faker.number.bigInt(100_000_000)
     mockGetAccountInfo.mockResolvedValue({
-      balance: balance.toString(),
+      balance: '100000000',
       ownerCount: 0,
     })
 
@@ -41,7 +39,7 @@ describe('getBalance', () => {
     expect(mockGetAccountInfo).toHaveBeenCalledTimes(1)
     expect(mockGetServerInfos).toHaveBeenCalledTimes(1)
     expect(mockGetAccountInfo.mock.lastCall[0]).toEqual(address)
-    expect(result).toEqual([{ value: balance, asset: { type: 'native' }, locked: 23000000n }])
+    expect(result).toEqual([{ value: 100000000n, asset: { type: 'native' }, locked: 23000000n }])
   })
 
   it('returns from account with empty balance', async () => {

package/src/api/getBlock.integ.test.ts

@@ -1,7 +1,7 @@
 // SPDX-FileCopyrightText: © 2024 LEDGER SAS
 // SPDX-License-Identifier: Apache-2.0
 
-import coinConfig, { XrpCoinConfig } from '../config'
+import coinConfig, { type XrpCoinConfig } from '../config'
 import { getBlock } from './getBlock'
 
 let originalGetCoinConfig: () => XrpCoinConfig
@@ -9,12 +9,10 @@ let originalGetCoinConfig: () => XrpCoinConfig
 describe('getBlock', () => {
   beforeAll(() => {
     originalGetCoinConfig = coinConfig.getCoinConfig
-    coinConfig.setCoinConfig(
-      () =>
-        ({
-          node: 'https://s.altnet.rippletest.net:51234',
-        }) as XrpCoinConfig
-    )
+    coinConfig.setCoinConfig(() => ({
+      node: 'https://s.altnet.rippletest.net:51234',
+      status: { type: 'active' },
+    }))
   })
 
   afterAll(() => {

package/src/api/getBlockInfo.integ.test.ts

@@ -1,7 +1,7 @@
 // SPDX-FileCopyrightText: © 2024 LEDGER SAS
 // SPDX-License-Identifier: Apache-2.0
 
-import coinConfig, { XrpCoinConfig } from '../config'
+import coinConfig, { type XrpCoinConfig } from '../config'
 import { getBlock } from './getBlock'
 import { getBlockInfo } from './getBlockInfo'
 
@@ -10,12 +10,10 @@ let originalGetCoinConfig: () => XrpCoinConfig
 describe('getBlockInfo', () => {
   beforeAll(() => {
     originalGetCoinConfig = coinConfig.getCoinConfig
-    coinConfig.setCoinConfig(
-      () =>
-        ({
-          node: 'https://s.altnet.rippletest.net:51234',
-        }) as XrpCoinConfig
-    )
+    coinConfig.setCoinConfig(() => ({
+      node: 'https://s.altnet.rippletest.net:51234',
+      status: { type: 'active' },
+    }))
   })
 
   afterAll(() => {

package/src/api/index.integ.test.ts

@@ -1,7 +1,7 @@
 // SPDX-FileCopyrightText: © 2024 LEDGER SAS
 // SPDX-License-Identifier: Apache-2.0
 
-import { Operation } from '@ledgerhq/coin-module-framework/api/types'
+import type { Operation } from '@ledgerhq/coin-module-framework/api/types'
 import { decode, encodeForSigning } from 'ripple-binary-codec'
 import { deriveKeypair, generateSeed, sign } from 'ripple-keypairs'
 import { createApi } from '.'
@@ -313,14 +313,21 @@ describe('Xrp Api (mainnet)', () => {
         type: 'IN',
         fees: 0.00001,
       }
-      const op = ops.find((o) => o.tx.hash === inTx.hash) as Operation
-      expect(op.tx.hash).toEqual(inTx.hash)
-      expect(op.value).toEqual(BigInt(inTx.amount * 1e6))
-      expect(op.recipients).toContain(inTx.recipient)
-      expect(op.senders).toContain(inTx.sender)
-      expect(op.type).toEqual(inTx.type)
-      expect(op.tx.fees).toEqual(BigInt(inTx.fees * 1e6))
-      expect(op.tx.feesPayer).toBe(inTx.sender)
+      expect(ops).toEqual(
+        expect.arrayContaining([
+          expect.objectContaining({
+            tx: expect.objectContaining({
+              hash: inTx.hash,
+              fees: BigInt(inTx.fees * 1e6),
+              feesPayer: inTx.sender,
+            }),
+            value: BigInt(inTx.amount * 1e6),
+            recipients: expect.arrayContaining([inTx.recipient]),
+            senders: expect.arrayContaining([inTx.sender]),
+            type: inTx.type,
+          }),
+        ])
+      )
     })
 
     it('returns OUT operation', async () => {
@@ -333,14 +340,21 @@ describe('Xrp Api (mainnet)', () => {
         type: 'OUT',
         fees: 0.00001,
       }
-      const op = ops.find((o) => o.tx.hash === outTx.hash) as Operation
-      expect(op.tx.hash).toEqual(outTx.hash)
-      expect(op.value).toEqual(BigInt(outTx.amount * 1e6))
-      expect(op.recipients).toContain(outTx.recipient)
-      expect(op.senders).toContain(outTx.sender)
-      expect(op.type).toEqual(outTx.type)
-      expect(op.tx.fees).toEqual(BigInt(outTx.fees * 1e6))
-      expect(op.tx.feesPayer).toBe(SENDER)
+      expect(ops).toEqual(
+        expect.arrayContaining([
+          expect.objectContaining({
+            tx: expect.objectContaining({
+              hash: outTx.hash,
+              fees: BigInt(outTx.fees * 1e6),
+              feesPayer: SENDER,
+            }),
+            value: BigInt(outTx.amount * 1e6),
+            recipients: expect.arrayContaining([outTx.recipient]),
+            senders: expect.arrayContaining([outTx.sender]),
+            type: outTx.type,
+          }),
+        ])
+      )
     })
 
     it('returns OUT operation for OfferCreate that trades XRP via DEX', async () => {
@@ -356,14 +370,20 @@ describe('Xrp Api (mainnet)', () => {
         type: 'OUT',
         fees: 0.00001,
       }
-      const op = ops.find((o) => o.tx.hash === outTx.hash) as Operation
-
-      expect(op.tx.hash).toEqual(outTx.hash)
-      expect(op.value).toEqual(BigInt(outTx.amount * 1e6))
-      expect(op.recipients).toEqual([])
-      expect(op.senders).toContain(outTx.sender)
-      expect(op.type).toEqual(outTx.type)
-      expect(op.tx.fees).toEqual(BigInt(outTx.fees * 1e6))
+      expect(ops).toEqual(
+        expect.arrayContaining([
+          expect.objectContaining({
+            tx: expect.objectContaining({
+              hash: outTx.hash,
+              fees: BigInt(outTx.fees * 1e6),
+            }),
+            value: BigInt(outTx.amount * 1e6),
+            recipients: [],
+            senders: expect.arrayContaining([outTx.sender]),
+            type: outTx.type,
+          }),
+        ])
+      )
     })
 
     it('returns IN operation on account delete', async () => {
@@ -380,23 +400,26 @@ describe('Xrp Api (mainnet)', () => {
         type: 'IN',
         fees: 2.0,
       }
-      const op = opsAccountDelete.find((o) => o.tx.hash === inTx.hash) as Operation
-      expect(op).toMatchObject({
-        id: inTx.hash,
-        tx: {
-          hash: inTx.hash,
-          fees: BigInt(inTx.fees * 1e6),
-          feesPayer: inTx.sender,
-          failed: false,
-        },
-        type: inTx.type,
-        value: BigInt(inTx.amount * 1e6),
-        senders: [inTx.sender],
-        recipients: [inTx.recipient],
-        details: {
-          xrpTxType: 'AccountDelete',
-        },
-      })
+      expect(opsAccountDelete).toEqual(
+        expect.arrayContaining([
+          expect.objectContaining({
+            id: inTx.hash,
+            tx: expect.objectContaining({
+              hash: inTx.hash,
+              fees: BigInt(inTx.fees * 1e6),
+              feesPayer: inTx.sender,
+              failed: false,
+            }),
+            type: inTx.type,
+            value: BigInt(inTx.amount * 1e6),
+            senders: [inTx.sender],
+            recipients: [inTx.recipient],
+            details: expect.objectContaining({
+              xrpTxType: 'AccountDelete',
+            }),
+          }),
+        ])
+      )
     })
   })
 

package/src/api/index.test.ts

@@ -1,7 +1,9 @@
 // SPDX-FileCopyrightText: © 2024 LEDGER SAS
 // SPDX-License-Identifier: Apache-2.0
 
-import { Operation, SendTransactionIntent } from '@ledgerhq/coin-module-framework/api/types'
+import type { Operation } from '@ledgerhq/coin-module-framework/api/types'
+import { createSendTransactionIntentMockData } from '@ledgerhq/coin-module-framework/test-utils'
+import BigNumber from 'bignumber.js'
 import { GetTransactionsOptions } from '../network'
 import { NetworkInfo, XrpMapMemo } from '../types'
 import { RIPPLE_EPOCH } from '../utils'
@@ -280,7 +282,7 @@ describe('listOperations', () => {
     }
     expect(mockGetTransactions).toHaveBeenNthCalledWith(1, 'src', baseOptions)
     expect(token).toEqual(expect.any(String))
-    await api.listOperations('src', { minHeight: 0, cursor: token as string, order: 'asc' })
+    await api.listOperations('src', { minHeight: 0, cursor: token, order: 'asc' })
     const optionsWithToken = {
       ...baseOptions,
       marker: defaultMarker,
@@ -415,14 +417,15 @@ describe('Testing craftTransaction function', () => {
 
   beforeAll(() => {
     mockCraftTransaction.mockImplementation((_address, _transaction, _publicKey) => {
-      return Promise.resolve({ xrplTransaction: {} as never, serializedTransaction: '' })
+      return Promise.resolve({ xrplTransaction: {}, serializedTransaction: '' })
     })
 
     mockGetSequence.mockImplementation((_address) => Promise.resolve(0n))
 
     mockEstimateFees.mockImplementation((_networkInfo) => {
+      const networkInfo: NetworkInfo = { family: 'xrp', serverFee: new BigNumber(0) }
       return Promise.resolve({
-        networkInfo: {} as NetworkInfo,
+        networkInfo,
         fees: DEFAULT_ESTIMATED_FEES,
       })
     })
@@ -435,10 +438,12 @@ describe('Testing craftTransaction function', () => {
   it('should use custom user fees when user provides it for crafting a transaction', async () => {
     const customFees = 99n
     await api.craftTransaction(
-      { intentType: 'transaction', sender: 'foo' } as SendTransactionIntent<XrpMapMemo>,
-      {
-        value: customFees,
-      }
+      createSendTransactionIntentMockData<XrpMapMemo>({
+        type: 'Payment',
+        sender: 'foo',
+        memo: { type: 'map', memos: new Map() },
+      }),
+      { value: customFees }
     )
 
     expect(mockCraftTransaction).toHaveBeenCalledWith(
@@ -451,10 +456,13 @@ describe('Testing craftTransaction function', () => {
   })
 
   it('should use default fees when user does not provide them for crafting a transaction', async () => {
-    await api.craftTransaction({
-      intentType: 'transaction',
-      sender: 'foo',
-    } as SendTransactionIntent<XrpMapMemo>)
+    await api.craftTransaction(
+      createSendTransactionIntentMockData<XrpMapMemo>({
+        type: 'Payment',
+        sender: 'foo',
+        memo: { type: 'map', memos: new Map() },
+      })
+    )
 
     expect(mockCraftTransaction).toHaveBeenCalledWith(
       expect.any(Object),
@@ -466,24 +474,26 @@ describe('Testing craftTransaction function', () => {
   })
 
   it('should pass signing pub key when user provides it for crafting a transaction', async () => {
-    await api.craftTransaction({
-      intentType: 'transaction',
-      sender: 'foo',
-      senderPublicKey: 'bar',
-    } as SendTransactionIntent<XrpMapMemo>)
+    await api.craftTransaction(
+      createSendTransactionIntentMockData<XrpMapMemo>({
+        type: 'Payment',
+        sender: 'foo',
+        senderPublicKey: 'bar',
+        memo: { type: 'map', memos: new Map() },
+      })
+    )
 
     expect(mockCraftTransaction).toHaveBeenCalledWith(expect.any(Object), expect.any(Object), 'bar')
   })
 
   it('should pass memos when user provides it for crafting a transaction', async () => {
-    await api.craftTransaction({
-      intentType: 'transaction',
-      sender: 'foo',
-      memo: {
-        type: 'map',
-        memos: new Map([['memos', ['testdata']]]),
-      },
-    } as SendTransactionIntent<XrpMapMemo>)
+    await api.craftTransaction(
+      createSendTransactionIntentMockData<XrpMapMemo>({
+        type: 'Payment',
+        sender: 'foo',
+        memo: { type: 'map', memos: new Map([['memos', ['testdata']]]) },
+      })
+    )
 
     expect(mockCraftTransaction).toHaveBeenCalledWith(
       expect.any(Object),
@@ -497,10 +507,13 @@ describe('Testing craftTransaction function', () => {
   })
 
   it('should not pass memos when user does not provide it for crafting a transaction', async () => {
-    await api.craftTransaction({
-      intentType: 'transaction',
-      sender: 'foo',
-    } as SendTransactionIntent<XrpMapMemo>)
+    await api.craftTransaction(
+      createSendTransactionIntentMockData<XrpMapMemo>({
+        type: 'Payment',
+        sender: 'foo',
+        memo: { type: 'map', memos: new Map() },
+      })
+    )
 
     expect(mockCraftTransaction).toHaveBeenCalledWith(
       expect.any(Object),
@@ -512,14 +525,13 @@ describe('Testing craftTransaction function', () => {
   })
 
   it('should not pass memos when user provides an empty memo list it for crafting a transaction', async () => {
-    await api.craftTransaction({
-      intentType: 'transaction',
-      sender: 'foo',
-      memo: {
-        type: 'map',
-        memos: new Map(),
-      },
-    } as SendTransactionIntent<XrpMapMemo>)
+    await api.craftTransaction(
+      createSendTransactionIntentMockData<XrpMapMemo>({
+        type: 'Payment',
+        sender: 'foo',
+        memo: { type: 'map', memos: new Map() },
+      })
+    )
 
     expect(mockCraftTransaction).toHaveBeenCalledWith(
       expect.any(Object),
@@ -531,14 +543,13 @@ describe('Testing craftTransaction function', () => {
   })
 
   it('should pass destination tag when user provides it for crafting a transaction', async () => {
-    await api.craftTransaction({
-      intentType: 'transaction',
-      sender: 'foo',
-      memo: {
-        type: 'map',
-        memos: new Map([['destinationTag', '1337']]),
-      },
-    } as SendTransactionIntent<XrpMapMemo>)
+    await api.craftTransaction(
+      createSendTransactionIntentMockData<XrpMapMemo>({
+        type: 'Payment',
+        sender: 'foo',
+        memo: { type: 'map', memos: new Map([['destinationTag', '1337']]) },
+      })
+    )
 
     expect(mockCraftTransaction).toHaveBeenCalledWith(
       expect.any(Object),

package/src/api/index.ts

@@ -13,6 +13,7 @@ import {
   TransactionIntent,
   CraftedTransaction,
   CoinModuleApi,
+  notSupported,
 } from '@ledgerhq/coin-module-framework/api/index'
 import { craftTransactionData } from '@ledgerhq/coin-module-framework/logic/craftTransactionData'
 import { isSendTransactionIntent } from '@ledgerhq/coin-module-framework/utils'
@@ -48,6 +49,7 @@ export function createApi(config: XrpConfig): CoinModuleApi<XrpMapMemo> {
     validateIntent,
     getBlock,
     getBlockInfo,
+    call: notSupported('call'),
     getNextSequence: getSequence,
     getStakes(_address: string, _cursor?: Cursor): Promise<Page<Stake>> {
       throw new Error('getStakes is not supported')
@@ -73,13 +75,16 @@ async function craft(
   const nextSequenceNumber = Number(await getSequence(transactionIntent.sender))
   const estimatedFees = customFees?.value ?? (await estimateFees()).fees
 
-  const memosMap = transactionIntent.memo?.type === 'map' ? transactionIntent.memo.memos : new Map()
+  const memosMap =
+    transactionIntent.memo?.type === 'map'
+      ? transactionIntent.memo.memos
+      : new Map<string, string | string[]>()
 
   const destinationTagValue = memosMap.get('destinationTag')
   const destinationTag =
     typeof destinationTagValue === 'string' ? Number(destinationTagValue) : undefined
 
-  const memoStrings = memosMap.get('memos') as string[] | undefined
+  const memoStrings = memosMap.get('memos')
 
   let memoEntries: MemoInput[] | undefined = undefined
 

package/src/api/listOperations.test.ts

@@ -1,9 +1,10 @@
 // SPDX-FileCopyrightText: © 2024 LEDGER SAS
 // SPDX-License-Identifier: Apache-2.0
 
+import type { GetTransactionsOptions } from '../network'
+import type { Marker } from '../network/types'
 import { assert } from 'console'
 import { Operation } from '@ledgerhq/coin-module-framework/api/types'
-import { Marker } from '../network/types'
 import { RIPPLE_EPOCH } from '../utils'
 import { listOperations } from './listOperations'
 
@@ -17,7 +18,8 @@ const mockGetServerInfos = jest.fn().mockResolvedValue({
 const mockNetworkGetTransactions = jest.fn()
 jest.mock('../network', () => ({
   getServerInfos: () => mockGetServerInfos(),
-  getTransactions: (...args: any[]) => mockNetworkGetTransactions(...args),
+  getTransactions: (address: string, options: GetTransactionsOptions | undefined) =>
+    mockNetworkGetTransactions(address, options),
 }))
 
 describe('listOperations', () => {