@ledgerhq/coin-xrp 6.1.3 → 6.1.4-nightly.0

package/lib-es/test/bridgeDatasetTest.js

@@ -1,6 +1,6 @@
 import BigNumber from "bignumber.js";
 import { InvalidAddressBecauseDestinationIsAlsoSource } from "@ledgerhq/errors";
-import { fromTransactionRaw } from "../bridge/transaction";
+import { fromTransactionRaw } from "../transaction";
 export const newAddress1 = "rZvBc5e2YR1A9otS3r9DyGh3NDP8XLLp4";
 export const dataset = {
     implementations: ["mock", "ripplejs"],
@@ -91,18 +91,18 @@ export const dataset = {
                                 recipient: "rageXHB6Q4VbvvWdTzKANwjeCT4HXFCKX7",
                                 amount: "10000000",
                                 tag: null,
-                                fee: "1",
+                                fee: "10", // NOTE: fee is not customizable, this field is ignored
                                 feeCustomUnit: null,
                                 networkInfo: null,
                             }),
                             expectedStatus: {
                                 amount: new BigNumber("10000000"),
-                                estimatedFees: new BigNumber("1"),
+                                estimatedFees: new BigNumber("10"), // NOTE: hardcoded fee
                                 errors: {
                                     recipient: new InvalidAddressBecauseDestinationIsAlsoSource(),
                                 },
                                 warnings: {},
-                                totalSpent: new BigNumber("10000001"),
+                                totalSpent: new BigNumber("10000010"), // NOTE: amount + hardcoded fee
                             },
                         },
                         {
@@ -112,16 +112,16 @@ export const dataset = {
                                 recipient: "rB6pwovsyrFWhPYUsjj9V3CHck985QjiXi",
                                 amount: "10000000",
                                 tag: 12345,
-                                fee: "1",
+                                fee: "10", // NOTE: fee is not customizable, this field is ignored
                                 feeCustomUnit: null,
                                 networkInfo: null,
                             }),
                             expectedStatus: {
                                 amount: new BigNumber("10000000"),
-                                estimatedFees: new BigNumber("1"),
+                                estimatedFees: new BigNumber("10"), // NOTE: hardcoded fee
                                 errors: {},
                                 warnings: {},
-                                totalSpent: new BigNumber("10000001"),
+                                totalSpent: new BigNumber("10000010"), // NOTE: amount + hardcoded fee
                             },
                         },
                     ],

package/lib-es/test/bridgeDatasetTest.js.map

@@ -1 +1 @@
-{"version":3,"file":"bridgeDatasetTest.js","sourceRoot":"","sources":["../../src/test/bridgeDatasetTest.ts"],"names":[],"mappings":"AAAA,OAAO,SAAS,MAAM,cAAc,CAAC;AAErC,OAAO,EAAE,4CAA4C,EAAE,MAAM,kBAAkB,CAAC;AAChF,OAAO,EAAE,kBAAkB,EAAE,MAAM,uBAAuB,CAAC;AAG3D,MAAM,CAAC,MAAM,WAAW,GAAG,mCAAmC,CAAC;AAE/D,MAAM,CAAC,MAAM,OAAO,GAA6B;IAC/C,eAAe,EAAE,CAAC,MAAM,EAAE,UAAU,CAAC;IACrC,UAAU,EAAE;QACV,MAAM,EAAE;YACN,YAAY,EAAE;gBACZ;oBACE,IAAI,EAAE,eAAe;oBACrB,gBAAgB,EAAE,IAAI;oBACtB,oCAAoC;oBACpC,KAAK,EAAE;;;;;;;;;WASN;iBACF;aACF;YACD,QAAQ,EAAE;gBACR;oBACE,YAAY,EAAE;wBACZ,QAAQ;wBAER;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;sBAgCF;wBACE,QAAQ;wBAER;;;;;;;;;;;;;;;;;;;;;;sBAsBF;wBACE;4BACE,IAAI,EAAE,2CAA2C;4BACjD,WAAW,EAAE,kBAAkB,CAAC;gCAC9B,MAAM,EAAE,KAAK;gCACb,SAAS,EAAE,oCAAoC;gCAC/C,MAAM,EAAE,UAAU;gCAClB,GAAG,EAAE,IAAI;gCACT,GAAG,EAAE,GAAG;gCACR,aAAa,EAAE,IAAI;gCACnB,WAAW,EAAE,IAAI;6BAClB,CAAC;4BACF,cAAc,EAAE;gCACd,MAAM,EAAE,IAAI,SAAS,CAAC,UAAU,CAAC;gCACjC,aAAa,EAAE,IAAI,SAAS,CAAC,GAAG,CAAC;gCACjC,MAAM,EAAE;oCACN,SAAS,EAAE,IAAI,4CAA4C,EAAE;iCAC9D;gCACD,QAAQ,EAAE,EAAE;gCACZ,UAAU,EAAE,IAAI,SAAS,CAAC,UAAU,CAAC;6BACtC;yBACF;wBACD;4BACE,IAAI,EAAE,4BAA4B;4BAClC,WAAW,EAAE,kBAAkB,CAAC;gCAC9B,MAAM,EAAE,KAAK;gCACb,SAAS,EAAE,oCAAoC;gCAC/C,MAAM,EAAE,UAAU;gCAClB,GAAG,EAAE,KAAK;gCACV,GAAG,EAAE,GAAG;gCACR,aAAa,EAAE,IAAI;gCACnB,WAAW,EAAE,IAAI;6BAClB,CAAC;4BACF,cAAc,EAAE;gCACd,MAAM,EAAE,IAAI,SAAS,CAAC,UAAU,CAAC;gCACjC,aAAa,EAAE,IAAI,SAAS,CAAC,GAAG,CAAC;gCACjC,MAAM,EAAE,EAAE;gCACV,QAAQ,EAAE,EAAE;gCACZ,UAAU,EAAE,IAAI,SAAS,CAAC,UAAU,CAAC;6BACtC;yBACF;qBACF;oBACD,GAAG,EAAE;wBACH,EAAE,EAAE,uDAAuD;wBAC3D,cAAc,EAAE,oCAAoC;wBACpD,IAAI,EAAE,OAAO;wBACb,cAAc,EAAE,EAAE;wBAClB,KAAK,EAAE,CAAC;wBACR,YAAY,EAAE,oCAAoC;wBAClD,gBAAgB,EAAE,iBAAiB;wBACnC,WAAW,EAAE,CAAC;wBACd,UAAU,EAAE,EAAE;wBACd,iBAAiB,EAAE,EAAE;wBACrB,UAAU,EAAE,QAAQ;wBACpB,YAAY,EAAE,EAAE;wBAChB,OAAO,EAAE,UAAU;qBACpB;iBACF;aACF;SACF;KACF;CACF,CAAC"}
+{"version":3,"file":"bridgeDatasetTest.js","sourceRoot":"","sources":["../../src/test/bridgeDatasetTest.ts"],"names":[],"mappings":"AAAA,OAAO,SAAS,MAAM,cAAc,CAAC;AAErC,OAAO,EAAE,4CAA4C,EAAE,MAAM,kBAAkB,CAAC;AAChF,OAAO,EAAE,kBAAkB,EAAE,MAAM,gBAAgB,CAAC;AAGpD,MAAM,CAAC,MAAM,WAAW,GAAG,mCAAmC,CAAC;AAE/D,MAAM,CAAC,MAAM,OAAO,GAA6B;IAC/C,eAAe,EAAE,CAAC,MAAM,EAAE,UAAU,CAAC;IACrC,UAAU,EAAE;QACV,MAAM,EAAE;YACN,YAAY,EAAE;gBACZ;oBACE,IAAI,EAAE,eAAe;oBACrB,gBAAgB,EAAE,IAAI;oBACtB,oCAAoC;oBACpC,KAAK,EAAE;;;;;;;;;WASN;iBACF;aACF;YACD,QAAQ,EAAE;gBACR;oBACE,YAAY,EAAE;wBACZ,QAAQ;wBAER;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;sBAgCF;wBACE,QAAQ;wBAER;;;;;;;;;;;;;;;;;;;;;;sBAsBF;wBACE;4BACE,IAAI,EAAE,2CAA2C;4BACjD,WAAW,EAAE,kBAAkB,CAAC;gCAC9B,MAAM,EAAE,KAAK;gCACb,SAAS,EAAE,oCAAoC;gCAC/C,MAAM,EAAE,UAAU;gCAClB,GAAG,EAAE,IAAI;gCACT,GAAG,EAAE,IAAI,EAAE,uDAAuD;gCAClE,aAAa,EAAE,IAAI;gCACnB,WAAW,EAAE,IAAI;6BAClB,CAAC;4BACF,cAAc,EAAE;gCACd,MAAM,EAAE,IAAI,SAAS,CAAC,UAAU,CAAC;gCACjC,aAAa,EAAE,IAAI,SAAS,CAAC,IAAI,CAAC,EAAE,sBAAsB;gCAE1D,MAAM,EAAE;oCACN,SAAS,EAAE,IAAI,4CAA4C,EAAE;iCAC9D;gCACD,QAAQ,EAAE,EAAE;gCACZ,UAAU,EAAE,IAAI,SAAS,CAAC,UAAU,CAAC,EAAE,+BAA+B;6BACvE;yBACF;wBACD;4BACE,IAAI,EAAE,4BAA4B;4BAClC,WAAW,EAAE,kBAAkB,CAAC;gCAC9B,MAAM,EAAE,KAAK;gCACb,SAAS,EAAE,oCAAoC;gCAC/C,MAAM,EAAE,UAAU;gCAClB,GAAG,EAAE,KAAK;gCACV,GAAG,EAAE,IAAI,EAAE,uDAAuD;gCAClE,aAAa,EAAE,IAAI;gCACnB,WAAW,EAAE,IAAI;6BAClB,CAAC;4BACF,cAAc,EAAE;gCACd,MAAM,EAAE,IAAI,SAAS,CAAC,UAAU,CAAC;gCACjC,aAAa,EAAE,IAAI,SAAS,CAAC,IAAI,CAAC,EAAE,sBAAsB;gCAC1D,MAAM,EAAE,EAAE;gCACV,QAAQ,EAAE,EAAE;gCACZ,UAAU,EAAE,IAAI,SAAS,CAAC,UAAU,CAAC,EAAE,+BAA+B;6BACvE;yBACF;qBACF;oBACD,GAAG,EAAE;wBACH,EAAE,EAAE,uDAAuD;wBAC3D,cAAc,EAAE,oCAAoC;wBACpD,IAAI,EAAE,OAAO;wBACb,cAAc,EAAE,EAAE;wBAClB,KAAK,EAAE,CAAC;wBACR,YAAY,EAAE,oCAAoC;wBAClD,gBAAgB,EAAE,iBAAiB;wBACnC,WAAW,EAAE,CAAC;wBACd,UAAU,EAAE,EAAE;wBACd,iBAAiB,EAAE,EAAE;wBACrB,UAAU,EAAE,QAAQ;wBACpB,YAAY,EAAE,EAAE;wBAChB,OAAO,EAAE,UAAU;qBACpB;iBACF;aACF;SACF;KACF;CACF,CAAC"}

package/lib-es/{bridge/transaction.d.ts → transaction.d.ts}

@@ -1,4 +1,4 @@
-import type { Transaction, TransactionRaw } from "../types";
+import type { Transaction, TransactionRaw } from "./types";
 import type { Account } from "@ledgerhq/types-live";
 export declare const formatTransaction: ({ amount, recipient, fee, tag, useAllAmount }: Transaction, account: Account) => string;
 export declare const fromTransactionRaw: (tr: TransactionRaw) => Transaction;

package/lib-es/transaction.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"transaction.d.ts","sourceRoot":"","sources":["../src/transaction.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,WAAW,EAAE,cAAc,EAAE,MAAM,SAAS,CAAC;AAQ3D,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,sBAAsB,CAAC;AAIpD,eAAO,MAAM,iBAAiB,kDACmB,WAAW,WACjD,OAAO,KACf,MAiB6B,CAAC;AAEjC,eAAO,MAAM,kBAAkB,OAAQ,cAAc,KAAG,WAgBvD,CAAC;AAEF,eAAO,MAAM,gBAAgB,MAAO,WAAW,KAAG,cAgBjD,CAAC;;uEAvD+C,WAAW,WACjD,OAAO,KACf,MAAM;6BAmB8B,cAAc,KAAG,WAAW;0BAkB/B,WAAW,KAAG,cAAc;;;;;AAkBhE,wBAOE"}

package/lib-es/transaction.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"transaction.js","sourceRoot":"","sources":["../src/transaction.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,MAAM,cAAc,CAAC;AAEzC,OAAO,EAAE,uBAAuB,EAAE,MAAM,qCAAqC,CAAC;AAC9E,OAAO,EACL,wBAAwB,EACxB,8BAA8B,IAAI,wBAAwB,EAC1D,sBAAsB,EACtB,4BAA4B,IAAI,sBAAsB,GACvD,MAAM,oDAAoD,CAAC;AAE5D,OAAO,EAAE,kBAAkB,EAAE,MAAM,wCAAwC,CAAC;AAC5E,OAAO,EAAE,kBAAkB,EAAE,MAAM,2CAA2C,CAAC;AAE/E,MAAM,CAAC,MAAM,iBAAiB,GAAG,CAC/B,EAAE,MAAM,EAAE,SAAS,EAAE,GAAG,EAAE,GAAG,EAAE,YAAY,EAAe,EAC1D,OAAgB,EACR,EAAE,CAAC;OAEX,YAAY;IACV,CAAC,CAAC,KAAK;IACP,CAAC,CAAC,kBAAkB,CAAC,kBAAkB,CAAC,OAAO,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,MAAM,EAAE;QAC/D,QAAQ,EAAE,IAAI;QACd,eAAe,EAAE,IAAI;KACtB,CACP;KACK,SAAS;WAEZ,CAAC,GAAG;IACF,CAAC,CAAC,GAAG;IACL,CAAC,CAAC,kBAAkB,CAAC,kBAAkB,CAAC,OAAO,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,GAAG,EAAE;QAC5D,QAAQ,EAAE,IAAI;QACd,eAAe,EAAE,IAAI;KACtB,CACP,GAAG,GAAG,CAAC,CAAC,CAAC,UAAU,GAAG,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC;AAEjC,MAAM,CAAC,MAAM,kBAAkB,GAAG,CAAC,EAAkB,EAAe,EAAE;IACpE,MAAM,MAAM,GAAG,wBAAwB,CAAC,EAAE,CAAC,CAAC;IAC5C,MAAM,EAAE,WAAW,EAAE,GAAG,EAAE,CAAC;IAC3B,OAAO;QACL,GAAG,MAAM;QACT,MAAM,EAAE,EAAE,CAAC,MAAM;QACjB,GAAG,EAAE,EAAE,CAAC,GAAG;QACX,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,SAAS,CAAC,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI;QAC1C,aAAa,EAAE,EAAE,CAAC,aAAa;QAC/B,6IAA6I;QAC7I,WAAW,EAAE,WAAW,IAAI;YAC1B,MAAM,EAAE,WAAW,CAAC,MAAM;YAC1B,SAAS,EAAE,IAAI,SAAS,CAAC,WAAW,CAAC,SAAS,CAAC;YAC/C,WAAW,EAAE,IAAI,SAAS,CAAC,WAAW,CAAC,WAAW,CAAC;SACpD;KACF,CAAC;AACJ,CAAC,CAAC;AAEF,MAAM,CAAC,MAAM,gBAAgB,GAAG,CAAC,CAAc,EAAkB,EAAE;IACjE,MAAM,MAAM,GAAG,sBAAsB,CAAC,CAAC,CAAC,CAAC;IACzC,MAAM,EAAE,WAAW,EAAE,GAAG,CAAC,CAAC;IAC1B,OAAO;QACL,GAAG,MAAM;QACT,MAAM,EAAE,CAAC,CAAC,MAAM;QAChB,GAAG,EAAE,CAAC,CAAC,GAAG;QACV,GAAG,EAAE,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAC,CAAC,CAAC,IAAI;QACpC,aAAa,EAAE,CAAC,CAAC,aAAa;QAC9B,6IAA6I;QAC7I,WAAW,EAAE,WAAW,IAAI;YAC1B,MAAM,EAAE,WAAW,CAAC,MAAM;YAC1B,SAAS,EAAE,WAAW,CAAC,SAAS,CAAC,QAAQ,EAAE;YAC3C,WAAW,EAAE,WAAW,CAAC,WAAW,CAAC,QAAQ,EAAE;SAChD;KACF,CAAC;AACJ,CAAC,CAAC;AAEF,eAAe;IACb,iBAAiB;IACjB,kBAAkB;IAClB,gBAAgB;IAChB,wBAAwB;IACxB,sBAAsB;IACtB,uBAAuB;CACxB,CAAC"}

package/lib-es/types/model.d.ts

@@ -1,3 +1,4 @@
+import { TypedMapMemo } from "@ledgerhq/coin-framework/api/types";
 export type AccountInfo = {
     isNewAccount: boolean;
     balance: string;
@@ -9,6 +10,12 @@ export type XrpMemo = {
     format?: string;
     type?: string;
 };
+export type XrpMemoKind = "destinationTag" | "memo";
+export type XrpMemoValueMap = {
+    destinationTag: string;
+    memos: string[];
+};
+export type XrpMapMemo = TypedMapMemo<XrpMemoValueMap>;
 type Order = "asc" | "desc";
 export type ListOperationsOptions = {
     limit?: number;

package/lib-es/types/model.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"model.d.ts","sourceRoot":"","sources":["../../src/types/model.ts"],"names":[],"mappings":"AAAA,MAAM,MAAM,WAAW,GAAG;IACxB,YAAY,EAAE,OAAO,CAAC;IACtB,OAAO,EAAE,MAAM,CAAC;IAChB,UAAU,EAAE,MAAM,CAAC;IACnB,QAAQ,EAAE,MAAM,CAAC;CAClB,CAAC;AAEF,MAAM,MAAM,OAAO,GAAG;IACpB,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,IAAI,CAAC,EAAE,MAAM,CAAC;CACf,CAAC;AAEF,KAAK,KAAK,GAAG,KAAK,GAAG,MAAM,CAAC;AAC5B,MAAM,MAAM,qBAAqB,GAAG;IAElC,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,KAAK,CAAC;IAEd,SAAS,CAAC,EAAE,MAAM,CAAC;CACpB,CAAC"}
+{"version":3,"file":"model.d.ts","sourceRoot":"","sources":["../../src/types/model.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,YAAY,EAAE,MAAM,oCAAoC,CAAC;AAElE,MAAM,MAAM,WAAW,GAAG;IACxB,YAAY,EAAE,OAAO,CAAC;IACtB,OAAO,EAAE,MAAM,CAAC;IAChB,UAAU,EAAE,MAAM,CAAC;IACnB,QAAQ,EAAE,MAAM,CAAC;CAClB,CAAC;AAEF,MAAM,MAAM,OAAO,GAAG;IACpB,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,IAAI,CAAC,EAAE,MAAM,CAAC;CACf,CAAC;AAEF,MAAM,MAAM,WAAW,GAAG,gBAAgB,GAAG,MAAM,CAAC;AAEpD,MAAM,MAAM,eAAe,GAAG;IAC5B,cAAc,EAAE,MAAM,CAAC;IACvB,KAAK,EAAE,MAAM,EAAE,CAAC;CACjB,CAAC;AACF,MAAM,MAAM,UAAU,GAAG,YAAY,CAAC,eAAe,CAAC,CAAC;AAEvD,KAAK,KAAK,GAAG,KAAK,GAAG,MAAM,CAAC;AAE5B,MAAM,MAAM,qBAAqB,GAAG;IAElC,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,KAAK,CAAC;IAEd,SAAS,CAAC,EAAE,MAAM,CAAC;CACpB,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ledgerhq/coin-xrp",
-  "version": "6.1.3",
+  "version": "6.1.4-nightly.0",
   "description": "Ledger XRP Coin integration",
   "keywords": [
     "Ledger",
@@ -41,7 +41,7 @@
         "lib/test/bot-specs"
       ],
       "transaction": [
-        "lib/bridge/transaction"
+        "lib/transaction"
       ],
       "types": [
         "lib/types/index"
@@ -80,8 +80,8 @@
       "default": "./lib-es/test/bot-specs.js"
     },
     "./transaction": {
-      "require": "./lib/bridge/transaction.js",
-      "default": "./lib-es/bridge/transaction.js"
+      "require": "./lib/transaction.js",
+      "default": "./lib-es/transaction.js"
     },
     "./types": {
       "require": "./lib/types/index.js",
@@ -104,12 +104,12 @@
     "ripple-address-codec": "^5.0.0",
     "ripple-binary-codec": "^1.3.0",
     "rxjs": "^7.8.1",
-    "@ledgerhq/coin-framework": "^5.2.0",
-    "@ledgerhq/cryptoassets": "^13.18.0",
+    "@ledgerhq/cryptoassets": "^13.18.1-nightly.0",
+    "@ledgerhq/coin-framework": "^5.2.1-nightly.0",
     "@ledgerhq/devices": "8.4.6",
     "@ledgerhq/errors": "^6.21.0",
     "@ledgerhq/live-network": "^2.0.9",
-    "@ledgerhq/types-live": "^6.72.0",
+    "@ledgerhq/types-live": "^6.73.0-nightly.0",
     "@ledgerhq/logs": "^6.13.0"
   },
   "devDependencies": {
@@ -121,7 +121,6 @@
     "jest": "^29.7.0",
     "ripple-keypairs": "^2.0.0",
     "ts-jest": "^29.1.1",
-    "jest-sonar": "0.2.16",
     "typescript": "^5.4.5",
     "@ledgerhq/disable-network-setup": "^0.0.0",
     "@ledgerhq/types-cryptoassets": "^7.23.0"

package/src/api/index.integ.test.ts

@@ -4,7 +4,7 @@ import { createApi } from ".";
 //import { sign } from "ripple-keypairs";
 
 describe("Xrp Api", () => {
-  const SENDER = { address: "rh1HPuRVsYYvThxG2Bs1MfjmrVC73S16Fb" };
+  const SENDER = "rh1HPuRVsYYvThxG2Bs1MfjmrVC73S16Fb";
   const api = createApi({ node: "https://s.altnet.rippletest.net:51234" });
 
   describe("estimateFees", () => {
@@ -19,6 +19,10 @@ describe("Xrp Api", () => {
         sender: SENDER,
         amount,
         recipient: "rKtXXTVno77jhu6tto1MAXjepyuaKaLcqB",
+        memo: {
+          type: "map",
+          memos: new Map(),
+        },
       });
 
       // Then
@@ -29,15 +33,14 @@ describe("Xrp Api", () => {
   describe("listOperations", () => {
     it.skip("returns a list regarding address parameter", async () => {
       // When
-      const [tx, _] = await api.listOperations(SENDER.address, { minHeight: 200 });
+      const [tx, _] = await api.listOperations(SENDER, { minHeight: 200 });
 
       // https://blockexplorer.one/xrp/testnet/address/rh1HPuRVsYYvThxG2Bs1MfjmrVC73S16Fb
       // as of 2025-03-18, the address has 287 transactions
       expect(tx.length).toBeGreaterThanOrEqual(287);
       tx.forEach(operation => {
         const isSenderOrReceipt =
-          operation.senders.includes(SENDER.address) ||
-          operation.recipients.includes(SENDER.address);
+          operation.senders.includes(SENDER) || operation.recipients.includes(SENDER);
         expect(isSenderOrReceipt).toBeTruthy();
       });
     });
@@ -81,7 +84,7 @@ describe("Xrp Api", () => {
 
     it("returns an amount above 0 when address has transactions", async () => {
       // When
-      const result = await api.getBalance(SENDER.address);
+      const result = await api.getBalance(SENDER);
 
       // Then
       expect(result[0].asset).toEqual({ type: "native" });
@@ -93,7 +96,9 @@ describe("Xrp Api", () => {
       const result = await api.getBalance(SENDER_WITH_NO_TRANSACTION);
 
       // Then
-      expect(result).toEqual([{ value: BigInt(0), asset: { type: "native" } }]);
+      expect(result).toEqual([
+        { locked: BigInt(1000000n), value: BigInt(0), asset: { type: "native" } },
+      ]);
     });
   });
 
@@ -108,10 +113,13 @@ describe("Xrp Api", () => {
         sender: SENDER,
         recipient: RECIPIENT,
         amount: BigInt(10),
+        memo: {
+          type: "map",
+          memos: new Map([["memos", ["testdata"]]]),
+        },
       });
-
       // Then
-      expect(result.length).toEqual(162);
+      expect(result.length).toEqual(178);
     });
 
     it("should use default fees when user does not provide them for crafting a transaction", async () => {
@@ -121,6 +129,10 @@ describe("Xrp Api", () => {
         sender: SENDER,
         recipient: RECIPIENT,
         amount: BigInt(10),
+        memo: {
+          type: "map",
+          memos: new Map(),
+        },
       });
 
       const decodedTransaction = decode(result) as { Fee: string };
@@ -136,6 +148,10 @@ describe("Xrp Api", () => {
           sender: SENDER,
           recipient: RECIPIENT,
           amount: BigInt(10),
+          memo: {
+            type: "map",
+            memos: new Map(),
+          },
         },
         customFees,
       );

package/src/api/index.test.ts

@@ -1,8 +1,8 @@
 import { Operation, TransactionIntent } from "@ledgerhq/coin-framework/api/types";
 import * as LogicFunctions from "../logic";
 import { GetTransactionsOptions } from "../network";
-import { NetworkInfo, XrpAsset } from "../types";
-import { createApi, TransactionIntentExtra, XrpSender } from "./index";
+import { NetworkInfo, XrpAsset, XrpMapMemo } from "../types";
+import { createApi } from "./index";
 
 const mockGetServerInfos = jest.fn().mockResolvedValue({
   info: {
@@ -285,11 +285,7 @@ describe("Testing craftTransaction function", () => {
   it("should use custom user fees when user provides it for crafting a transaction", async () => {
     const customFees = 99n;
     await api.craftTransaction(
-      { sender: { address: "foo" } } as TransactionIntent<
-        XrpAsset,
-        TransactionIntentExtra,
-        XrpSender
-      >,
+      { sender: "foo" } as TransactionIntent<XrpAsset, XrpMapMemo>,
       customFees,
     );
 
@@ -303,11 +299,7 @@ describe("Testing craftTransaction function", () => {
   });
 
   it("should use default fees when user does not provide them for crafting a transaction", async () => {
-    await api.craftTransaction({ sender: { address: "foo" } } as TransactionIntent<
-      XrpAsset,
-      TransactionIntentExtra,
-      XrpSender
-    >);
+    await api.craftTransaction({ sender: "foo" } as TransactionIntent<XrpAsset, XrpMapMemo>);
 
     expect(logicCraftTransactionSpy).toHaveBeenCalledWith(
       expect.any(Object),
@@ -320,8 +312,9 @@ describe("Testing craftTransaction function", () => {
 
   it("should pass signing pub key when user provides it for crafting a transaction", async () => {
     await api.craftTransaction({
-      sender: { address: "foo", publicKey: "bar" },
-    } as TransactionIntent<XrpAsset, TransactionIntentExtra, XrpSender>);
+      sender: "foo",
+      senderPublicKey: "bar",
+    } as TransactionIntent<XrpAsset, XrpMapMemo>);
 
     expect(logicCraftTransactionSpy).toHaveBeenCalledWith(
       expect.any(Object),
@@ -332,14 +325,19 @@ describe("Testing craftTransaction function", () => {
 
   it("should pass memos when user provides it for crafting a transaction", async () => {
     await api.craftTransaction({
-      sender: { address: "foo" },
-      memos: [{ data: "testdata", format: "testformat", type: "testtype" }],
-    } as TransactionIntent<XrpAsset, TransactionIntentExtra, XrpSender>);
+      sender: "foo",
+      memo: {
+        type: "map",
+        memos: new Map([["memos", ["testdata"]]]),
+      },
+    } as TransactionIntent<XrpAsset, XrpMapMemo>);
 
     expect(logicCraftTransactionSpy).toHaveBeenCalledWith(
       expect.any(Object),
       expect.objectContaining({
-        memos: [{ data: "testdata", format: "testformat", type: "testtype" }],
+        // NOTE: before
+        // memos: [{ data: "testdata", format: "testformat", type: "testtype" }],
+        memos: [{ data: "testdata", type: "memo" }],
       }),
       undefined,
     );
@@ -347,14 +345,17 @@ describe("Testing craftTransaction function", () => {
 
   it("should pass destination tag when user provides it for crafting a transaction", async () => {
     await api.craftTransaction({
-      sender: { address: "foo" },
-      destinationTag: 1337,
-    } as TransactionIntent<XrpAsset, TransactionIntentExtra, XrpSender>);
+      sender: "foo",
+      memo: {
+        type: "map",
+        memos: new Map([["destinationTag", "1337"]]),
+      },
+    } as TransactionIntent<XrpAsset, XrpMapMemo>);
 
     expect(logicCraftTransactionSpy).toHaveBeenCalledWith(
       expect.any(Object),
       expect.objectContaining({
-        destinationTag: 1337,
+        destinationTag: 1337, // logic should convert `value: string` -> `number`
       }),
       undefined,
     );

package/src/api/index.ts

@@ -16,11 +16,11 @@ import {
   getNextValidSequence,
   lastBlock,
   listOperations,
-  MemoInput,
+  getTransactionStatus,
 } from "../logic";
-import { ListOperationsOptions, XrpAsset } from "../types";
+import { ListOperationsOptions, XrpAsset, XrpMapMemo } from "../types";
 
-export function createApi(config: XrpConfig): Api<XrpAsset, TransactionIntentExtra, XrpSender> {
+export function createApi(config: XrpConfig): Api<XrpAsset, XrpMapMemo> {
   coinConfig.setCoinConfig(() => ({ ...config, status: { type: "active" } }));
 
   return {
@@ -31,36 +31,45 @@ export function createApi(config: XrpConfig): Api<XrpAsset, TransactionIntentExt
     getBalance,
     lastBlock,
     listOperations: operations,
+    validateIntent: getTransactionStatus,
   };
 }
 
-export type TransactionIntentExtra = {
-  destinationTag?: number | null | undefined;
-  memos?: MemoInput[];
-};
-
-export type XrpSender = {
-  address: string;
-  publicKey?: string;
-};
-
 async function craft(
-  transactionIntent: TransactionIntent<XrpAsset, TransactionIntentExtra, XrpSender>,
+  transactionIntent: TransactionIntent<XrpAsset, XrpMapMemo>,
   customFees?: bigint,
 ): Promise<string> {
-  const nextSequenceNumber = await getNextValidSequence(transactionIntent.sender.address);
+  const nextSequenceNumber = await getNextValidSequence(transactionIntent.sender);
   const estimatedFees = customFees !== undefined ? customFees : (await estimateFees()).fee;
+
+  const memosMap =
+    transactionIntent.memo?.type === "map" ? transactionIntent.memo.memos : new Map();
+
+  const destinationTagValue = memosMap.get("destinationTag");
+  const destinationTag =
+    typeof destinationTagValue === "string" ? Number(destinationTagValue) : undefined;
+
+  const memoStrings = memosMap.get("memos") as string[] | undefined;
+
+  let memoEntries: { type: string; data: string }[] = [];
+
+  if (Array.isArray(memoStrings) && memoStrings.length > 0) {
+    memoEntries = memoStrings.map(value => ({ type: "memo", data: value }));
+  }
+
   const tx = await craftTransaction(
-    { address: transactionIntent.sender.address, nextSequenceNumber },
+    { address: transactionIntent.sender, nextSequenceNumber },
     {
       recipient: transactionIntent.recipient,
       amount: transactionIntent.amount,
       fee: estimatedFees,
-      destinationTag: transactionIntent.destinationTag,
-      memos: transactionIntent.memos,
+      destinationTag,
+      // NOTE: double check before/after here
+      memos: memoEntries,
     },
-    transactionIntent.sender.publicKey,
+    transactionIntent.senderPublicKey,
   );
+
   return tx.serializedTransaction;
 }
 

package/src/index.ts

@@ -1,4 +1,3 @@
 export * from "./types";
 
-export { createBridges } from "./bridge/index";
 export type { XrpCoinConfig } from "./config";

package/src/logic/combine.ts

@@ -8,11 +8,18 @@ type XRPTransaction = JsonObject & {
 
 export function combine(transaction: string, signature: string, publicKey?: string): string {
   const xrplTransaction: JsonObject = decode(transaction);
-  let transactionWithSignature: XRPTransaction = { ...xrplTransaction, TxnSignature: signature };
+
+  let transactionWithSignature: XRPTransaction = { ...xrplTransaction } as any;
 
   if (publicKey) {
-    transactionWithSignature = { ...transactionWithSignature, SigningPubKey: publicKey };
+    transactionWithSignature = {
+      ...transactionWithSignature,
+      SigningPubKey: publicKey,
+    };
   }
 
-  return encode(transactionWithSignature);
+  transactionWithSignature = { ...transactionWithSignature, TxnSignature: signature };
+
+  const encoded = encode(transactionWithSignature).toUpperCase();
+  return encoded;
 }

package/src/logic/getBalance.test.ts

@@ -2,21 +2,33 @@ import { faker } from "@faker-js/faker";
 import { getBalance } from "./getBalance";
 
 const mockGetAccountInfo = jest.fn();
+const mockGetServerInfos = jest.fn();
 jest.mock("../network", () => ({
   getAccountInfo: (address: string) => mockGetAccountInfo(address),
+  getServerInfos: () => mockGetServerInfos(),
 }));
 
 describe("getBalance", () => {
   afterEach(() => {
     mockGetAccountInfo.mockClear();
+    mockGetServerInfos.mockClear();
   });
 
   it("returns the balance from Explorer", async () => {
+    mockGetServerInfos.mockResolvedValue({
+      info: {
+        validated_ledger: {
+          reserve_base_xrp: 23,
+          reserve_inc_xrp: 5,
+        },
+      },
+    });
     // Given
     const balance = faker.number.bigInt(100_000_000);
     const address = "ACCOUNT_ADDRESS";
     mockGetAccountInfo.mockResolvedValue({
       balance,
+      ownerCount: 0,
     });
 
     // When
@@ -24,7 +36,8 @@ describe("getBalance", () => {
 
     // Then
     expect(mockGetAccountInfo).toHaveBeenCalledTimes(1);
+    expect(mockGetServerInfos).toHaveBeenCalledTimes(1);
     expect(mockGetAccountInfo.mock.lastCall[0]).toEqual(address);
-    expect(result).toEqual([{ value: balance, asset: { type: "native" } }]);
+    expect(result).toEqual([{ value: balance, asset: { type: "native" }, locked: 23000000n }]);
   });
 });

package/src/logic/getBalance.ts

@@ -1,8 +1,24 @@
 import { Balance } from "@ledgerhq/coin-framework/api/types";
-import { getAccountInfo } from "../network";
+import { getAccountInfo, getServerInfos } from "../network";
 import { XrpAsset } from "../types";
+import { parseAPIValue } from "./common";
 
 export async function getBalance(address: string): Promise<Balance<XrpAsset>[]> {
   const accountInfo = await getAccountInfo(address);
-  return [{ value: BigInt(accountInfo.balance), asset: { type: "native" } }];
+  const serverInfo = await getServerInfos();
+
+  const reserveMinXRP = parseAPIValue(serverInfo.info.validated_ledger.reserve_base_xrp.toString());
+  const reservePerTrustline = parseAPIValue(
+    serverInfo.info.validated_ledger.reserve_inc_xrp.toString(),
+  );
+  const trustlines = accountInfo.ownerCount;
+
+  const locked = reserveMinXRP.plus(reservePerTrustline.times(trustlines));
+  return [
+    {
+      value: BigInt(accountInfo.balance),
+      asset: { type: "native" },
+      locked: BigInt(locked.toString()),
+    },
+  ];
 }