@ledgerhq/coin-tron 3.1.0-nightly.1 → 4.0.0-next.0

package/src/logic/listOperations.unit.test.ts

@@ -2,7 +2,7 @@ import BigNumber from "bignumber.js";
 import { defaultFetchParams, fetchTronAccountTxs, getBlock } from "../network";
 import { fromTrongridTxInfoToOperation } from "../network/trongrid/trongrid-adapters";
 import { TrongridTxInfo, TronAsset } from "../types";
-import { defaultOptions, listOperations } from "./listOperations";
+import { listOperations } from "./listOperations";
 import type { Operation } from "@ledgerhq/coin-framework/api/index";
 
 // Mock the fetchTronAccountTxs and fromTrongridTxInfoToOperation functions
@@ -30,8 +30,6 @@ describe("listOperations", () => {
   const expectedFetchParams = {
     ...defaultFetchParams,
     minTimestamp: mockBlockTimestamp,
-    hintGlobalLimit: 1000,
-    order: "desc",
   };
 
   it("should fetch transactions and return operations", async () => {
@@ -53,7 +51,7 @@ describe("listOperations", () => {
       };
     });
 
-    const [operations, token] = await listOperations(mockAddress, defaultOptions);
+    const [operations, token] = await listOperations(mockAddress, 0);
 
     expect(fetchTronAccountTxs).toHaveBeenCalledWith(
       mockAddress,
@@ -73,7 +71,7 @@ describe("listOperations", () => {
     (fetchTronAccountTxs as jest.Mock).mockResolvedValue(mockTxs);
     (fromTrongridTxInfoToOperation as jest.Mock).mockImplementation(() => null);
 
-    const [operations, token] = await listOperations(mockAddress, defaultOptions);
+    const [operations, token] = await listOperations(mockAddress, 0);
 
     expect(fetchTronAccountTxs).toHaveBeenCalledWith(
       mockAddress,
@@ -89,8 +87,6 @@ describe("listOperations", () => {
     const exampleError = new Error("Network error!");
     (fetchTronAccountTxs as jest.Mock).mockRejectedValue(exampleError);
 
-    await expect(listOperations(mockAddress, defaultOptions)).rejects.toThrow(
-      new Error(exampleError.message),
-    );
+    await expect(listOperations(mockAddress, 0)).rejects.toThrow(new Error(exampleError.message));
   });
 });

package/src/network/index.ts

@@ -483,18 +483,13 @@ export type FetchTxsStopPredicate = (
 ) => boolean;
 
 export type FetchParams = {
-  /** The maximum number of transactions to fetch per call. */
-  limitPerCall: number;
-  /** Hint about the number of transactions to be fetched in total (hint to optimize `limitPerCall`) */
-  hintGlobalLimit?: number;
+  limit: number;
   minTimestamp: number;
-  order: "asc" | "desc";
 };
 
 export const defaultFetchParams: FetchParams = {
-  limitPerCall: 100,
+  limit: 100,
   minTimestamp: 0,
-  order: "desc",
 } as const;
 
 export async function fetchTronAccountTxs(
@@ -503,15 +498,12 @@ export async function fetchTronAccountTxs(
   cacheTransactionInfoById: Record<string, TronTransactionInfo>,
   params: FetchParams,
 ): Promise<TrongridTxInfo[]> {
-  const adjustedLimitPerCall = params.hintGlobalLimit
-    ? Math.min(params.limitPerCall, params.hintGlobalLimit)
-    : params.limitPerCall;
-  const queryParams = `limit=${adjustedLimitPerCall}&min_timestamp=${params.minTimestamp}&order_by=block_timestamp,${params.order}`;
+  const queryParamsNativeTxs = `limit=${params.limit}&min_timestamp=${params.minTimestamp}`;
   const nativeTxs = (
     await getAllTransactions<
       (TransactionTronAPI & { detail?: TronTransactionInfo }) | MalformedTransactionTronAPI
     >(
-      `${getBaseApiUrl()}/v1/accounts/${addr}/transactions?${queryParams}`,
+      `${getBaseApiUrl()}/v1/accounts/${addr}/transactions?${queryParamsNativeTxs}`,
       shouldFetchMoreTxs,
       getTransactions(cacheTransactionInfoById),
     )
@@ -536,9 +528,10 @@ export async function fetchTronAccountTxs(
 
   // we need to fetch and filter trc20 transactions from another endpoint
   // doc https://developers.tron.network/reference/get-trc20-transaction-info-by-account-address
+  const queryParamsTrc20Txs = `limit=${params.limit}&min_timestamp=${params.minTimestamp}`;
   const trc20Txs = (
     await getAllTransactions<Trc20API>(
-      `${getBaseApiUrl()}/v1/accounts/${addr}/transactions/trc20?${queryParams}&get_detail=true`,
+      `${getBaseApiUrl()}/v1/accounts/${addr}/transactions/trc20?${queryParamsTrc20Txs}&get_detail=true`,
       shouldFetchMoreTxs,
       getTrc20,
     )