@ledgerhq/coin-tezos 6.6.0 → 6.7.0-nightly.1

package/lib-es/utils.js

@@ -0,0 +1,100 @@
+import { validatePublicKey, ValidationResult, b58Encode, PrefixV2 } from "@taquito/utils";
+import { DerivationType } from "@taquito/ledger-signer";
+import { compressPublicKey } from "@taquito/ledger-signer/dist/lib/utils";
+import coinConfig from "./config";
+/**
+ * Dust margin in mutez to prevent transaction failures on send max operations
+ * This ensures a small safety buffer remains in the account after send max
+ * Based on production behavior where ~281-287 mutez typically remain
+ * Increased to 500 to handle edge cases and fee estimation variations
+ */
+export const DUST_MARGIN_MUTEZ = 500;
+/**
+ * Suggested fee returned by Taquito for a minimal amount pre-estimation (mutez)
+ * Used as a stable fallback for send-max when RPC estimation is unavailable.
+ */
+export const MIN_SUGGESTED_FEE_SMALL_TRANSFER = 489;
+/**
+ * Typical operation size (bytes) for a simple XTZ transfer used to approximate
+ * the increased fee component when computing send-max in fallback mode.
+ * Chosen to match Taquito’s behavior closely in integration tests.
+ */
+export const OP_SIZE_XTZ_TRANSFER = 154;
+/**
+ * Helper function to map generic staking intents to Tezos operation modes
+ */
+export function mapIntentTypeToTezosMode(intentType) {
+    switch (intentType) {
+        case "stake":
+        case "delegate":
+            return "delegate";
+        case "unstake":
+        case "undelegate":
+            return "undelegate";
+        default:
+            return "send";
+    }
+}
+/**
+ * Creates a mock signer for Taquito operations (estimation and crafting)
+ */
+export function createMockSigner(publicKeyHash, publicKey) {
+    return {
+        publicKeyHash: async () => publicKeyHash,
+        publicKey: async () => publicKey,
+        sign: () => Promise.reject(new Error("unsupported")),
+        secretKey: () => Promise.reject(new Error("unsupported")),
+    };
+}
+/**
+ * Normalize a Tezos public key to base58 format (edpk/sppk/p2pk) based on the
+ * sender address prefix (tz1/tz2/tz3). Accepts either an already base58-encoded
+ * key or a hex key returned by the Ledger app. Returns undefined if input is
+ * empty or cannot be parsed.
+ */
+export function normalizePublicKeyForAddress(maybeKey, address) {
+    if (!maybeKey)
+        return undefined;
+    // If it's already a valid base58 public key, keep it
+    if (validatePublicKey(maybeKey) === ValidationResult.VALID)
+        return maybeKey;
+    // Attempt to convert hex → base58 according to address curve
+    try {
+        const pkHex = maybeKey.trim().toLowerCase();
+        if (pkHex === "")
+            return undefined;
+        const keyBuf = Buffer.from(pkHex, "hex");
+        // Choose curve/prefix from address tz1/tz2/tz3
+        // default are values for tz1 and fallbacks to it
+        let derivationType = DerivationType.ED25519;
+        let prefix = PrefixV2.Ed25519PublicKey;
+        if (address.startsWith("tz2")) {
+            derivationType = DerivationType.SECP256K1;
+            prefix = PrefixV2.Secp256k1PublicKey;
+        }
+        else if (address.startsWith("tz3")) {
+            derivationType = DerivationType.P256;
+            prefix = PrefixV2.P256PublicKey;
+        }
+        return b58Encode(compressPublicKey(keyBuf, derivationType), prefix);
+    }
+    catch {
+        return undefined;
+    }
+}
+/**
+ * Creates default fallback estimation values
+ */
+export function createFallbackEstimation() {
+    const config = coinConfig.getCoinConfig();
+    return {
+        fees: BigInt(config.fees.minEstimatedFees),
+        gasLimit: BigInt(config.fees.minGasLimit),
+        storageLimit: BigInt(config.fees.minStorageLimit),
+        estimatedFees: BigInt(config.fees.minEstimatedFees),
+    };
+}
+export function hasEmptyBalance(account) {
+    return (account.type === "user" && account.balance === 0) || account.type === "empty";
+}
+//# sourceMappingURL=utils.js.map

package/lib-es/utils.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"utils.js","sourceRoot":"","sources":["../src/utils.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,gBAAgB,EAAE,SAAS,EAAE,QAAQ,EAAE,MAAM,gBAAgB,CAAC;AAC1F,OAAO,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AACxD,OAAO,EAAE,iBAAiB,EAAE,MAAM,uCAAuC,CAAC;AAE1E,OAAO,UAAU,MAAM,UAAU,CAAC;AAElC;;;;;GAKG;AACH,MAAM,CAAC,MAAM,iBAAiB,GAAG,GAAG,CAAC;AAErC;;;GAGG;AACH,MAAM,CAAC,MAAM,gCAAgC,GAAG,GAAG,CAAC;AAEpD;;;;GAIG;AACH,MAAM,CAAC,MAAM,oBAAoB,GAAG,GAAG,CAAC;AAExC;;GAEG;AACH,MAAM,UAAU,wBAAwB,CAAC,UAAkB;IACzD,QAAQ,UAAU,EAAE,CAAC;QACnB,KAAK,OAAO,CAAC;QACb,KAAK,UAAU;YACb,OAAO,UAAU,CAAC;QACpB,KAAK,SAAS,CAAC;QACf,KAAK,YAAY;YACf,OAAO,YAAY,CAAC;QACtB;YACE,OAAO,MAAM,CAAC;IAClB,CAAC;AACH,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,gBAAgB,CAAC,aAAqB,EAAE,SAAiB;IACvE,OAAO;QACL,aAAa,EAAE,KAAK,IAAI,EAAE,CAAC,aAAa;QACxC,SAAS,EAAE,KAAK,IAAI,EAAE,CAAC,SAAS;QAChC,IAAI,EAAE,GAAG,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC,IAAI,KAAK,CAAC,aAAa,CAAC,CAAC;QACpD,SAAS,EAAE,GAAG,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC,IAAI,KAAK,CAAC,aAAa,CAAC,CAAC;KAC1D,CAAC;AACJ,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,4BAA4B,CAC1C,QAA4B,EAC5B,OAAe;IAEf,IAAI,CAAC,QAAQ;QAAE,OAAO,SAAS,CAAC;IAEhC,qDAAqD;IACrD,IAAI,iBAAiB,CAAC,QAAQ,CAAC,KAAK,gBAAgB,CAAC,KAAK;QAAE,OAAO,QAAQ,CAAC;IAE5E,6DAA6D;IAC7D,IAAI,CAAC;QACH,MAAM,KAAK,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;QAC5C,IAAI,KAAK,KAAK,EAAE;YAAE,OAAO,SAAS,CAAC;QACnC,MAAM,MAAM,GAAG,MAAM,CAAC,IAAI,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QAEzC,+CAA+C;QAC/C,iDAAiD;QACjD,IAAI,cAAc,GAAmB,cAAc,CAAC,OAAO,CAAC;QAC5D,IAAI,MAAM,GAAa,QAAQ,CAAC,gBAAgB,CAAC;QAEjD,IAAI,OAAO,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,CAAC;YAC9B,cAAc,GAAG,cAAc,CAAC,SAAS,CAAC;YAC1C,MAAM,GAAG,QAAQ,CAAC,kBAAkB,CAAC;QACvC,CAAC;aAAM,IAAI,OAAO,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,CAAC;YACrC,cAAc,GAAG,cAAc,CAAC,IAAI,CAAC;YACrC,MAAM,GAAG,QAAQ,CAAC,aAAa,CAAC;QAClC,CAAC;QAED,OAAO,SAAS,CAAC,iBAAiB,CAAC,MAAM,EAAE,cAAc,CAAC,EAAE,MAAM,CAAC,CAAC;IACtE,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,SAAS,CAAC;IACnB,CAAC;AACH,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,wBAAwB;IACtC,MAAM,MAAM,GAAG,UAAU,CAAC,aAAa,EAAE,CAAC;IAC1C,OAAO;QACL,IAAI,EAAE,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,gBAAgB,CAAC;QAC1C,QAAQ,EAAE,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,WAAW,CAAC;QACzC,YAAY,EAAE,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,eAAe,CAAC;QACjD,aAAa,EAAE,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,gBAAgB,CAAC;KACpD,CAAC;AACJ,CAAC;AAED,MAAM,UAAU,eAAe,CAAC,OAAmB;IACjD,OAAO,CAAC,OAAO,CAAC,IAAI,KAAK,MAAM,IAAI,OAAO,CAAC,OAAO,KAAK,CAAC,CAAC,IAAI,OAAO,CAAC,IAAI,KAAK,OAAO,CAAC;AACxF,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ledgerhq/coin-tezos",
-  "version": "6.6.0",
+  "version": "6.7.0-nightly.1",
   "description": "Tezos Coin integration",
   "keywords": [
     "Ledger",
@@ -56,8 +56,8 @@
       "default": "./lib-es/test/bot-specs.js"
     },
     "./transaction": {
-      "require": "./lib/bridge/transaction.js",
-      "default": "./lib-es/bridge/transaction.js"
+      "require": "./lib/transaction.js",
+      "default": "./lib-es/transaction.js"
     },
     "./*": {
       "require": "./lib/*.js",
@@ -72,24 +72,20 @@
     "@taquito/taquito": "^23.0.0-RC.0",
     "@taquito/utils": "^23.0.0-RC.0",
     "bignumber.js": "^9.1.2",
-    "@noble/hashes": "1.8.0",
-    "bs58check": "^3.0.1",
     "invariant": "^2.2.4",
     "lodash": "^4.17.21",
     "rxjs": "^7.8.1",
-    "@ledgerhq/coin-framework": "^6.6.0",
-    "@ledgerhq/cryptoassets": "^13.30.0",
+    "@ledgerhq/coin-framework": "^6.7.0-nightly.1",
+    "@ledgerhq/cryptoassets": "^13.31.0-nightly.1",
     "@ledgerhq/devices": "8.6.1",
     "@ledgerhq/errors": "^6.26.0",
-    "@ledgerhq/live-network": "^2.0.19",
+    "@ledgerhq/live-network": "^2.0.20-nightly.0",
     "@ledgerhq/logs": "^6.13.0",
-    "@ledgerhq/types-cryptoassets": "^7.28.0",
-    "@ledgerhq/types-live": "^6.86.0"
+    "@ledgerhq/types-live": "^6.87.0-nightly.1"
   },
   "devDependencies": {
     "@faker-js/faker": "^8.4.1",
     "@taquito/local-forging": "^23.0.0-RC.0",
-    "@types/bs58check": "^2.1.2",
     "@types/invariant": "^2.2.37",
     "@types/jest": "^29.5.12",
     "@types/lodash": "^4.17.4",
@@ -97,7 +93,8 @@
     "msw": "^2.7.3",
     "ts-jest": "^29.1.4",
     "typescript": "^5.4.5",
-    "@ledgerhq/disable-network-setup": "^0.0.0"
+    "@ledgerhq/disable-network-setup": "^0.0.0",
+    "@ledgerhq/types-cryptoassets": "^7.29.0-nightly.0"
   },
   "overrides": {
     "@taquito/ledger-signer": {

package/src/api/index.integ.test.ts

@@ -1,6 +1,7 @@
 import { localForger } from "@taquito/local-forging";
 import { createApi } from ".";
 import type { TezosApi } from "./types";
+import { SendTransactionIntent } from "@ledgerhq/coin-framework/api/types";
 
 /**
  * https://teztnets.com/ghostnet-about
@@ -39,6 +40,7 @@ describe("Tezos Api", () => {
 
       // When
       const result = await module.estimateFees({
+        intentType: "transaction",
         asset: { type: "native" },
         type: "send",
         sender: address,
@@ -73,13 +75,14 @@ describe("Tezos Api", () => {
   ])("does not fail when providing a %s address with pub key", async (_, sender, pubKey) => {
     // When
     const result = await module.estimateFees({
+      intentType: "transaction",
       asset: { type: "native" },
       type: "send",
       sender: "tz3DvEBHrtFkq9pTXqt6yavnf4sPe2jut2XH",
       senderPublicKey: pubKey,
       recipient: sender,
       amount: BigInt(100),
-    });
+    } as SendTransactionIntent);
 
     // Then
     expect(result.value).toBeGreaterThanOrEqual(BigInt(0));
@@ -91,6 +94,7 @@ describe("Tezos Api", () => {
   it("fails when using an unsupported address type", async () => {
     await expect(
       module.estimateFees({
+        intentType: "transaction",
         asset: { type: "native" },
         type: "send",
         sender: address,
@@ -172,6 +176,7 @@ describe("Tezos Api", () => {
       const amount = BigInt(10);
       // When
       const { transaction: encodedTransaction } = await module.craftTransaction({
+        intentType: "transaction",
         asset: { type: "native" },
         type,
         sender: address,
@@ -196,6 +201,7 @@ describe("Tezos Api", () => {
 
     it("should use estimated fees when user does not provide them for crafting a transaction", async () => {
       const { transaction: encodedTransaction } = await module.craftTransaction({
+        intentType: "transaction",
         asset: { type: "native" },
         type: "send",
         sender: address,
@@ -213,6 +219,7 @@ describe("Tezos Api", () => {
       async (customFees: bigint) => {
         const { transaction: encodedTransaction } = await module.craftTransaction(
           {
+            intentType: "transaction",
             asset: { type: "native" },
             type: "send",
             sender: address,

package/src/api/index.test.ts

@@ -2,7 +2,7 @@ import type { Operation } from "@ledgerhq/coin-framework/api/types";
 import type { APIAccount } from "../network/types";
 import networkApi from "../network/tzkt";
 import { createApi } from "./index";
-import type { TezosTransactionIntent } from "./types";
+import { TransactionIntent } from "@ledgerhq/coin-framework/api/types";
 
 const DEFAULT_ESTIMATED_FEES = 300n;
 const DEFAULT_GAS_LIMIT = 30n;
@@ -24,11 +24,18 @@ jest.mock("../logic", () => ({
   rawEncode: () => Promise.resolve("tz1heMGVHQnx7ALDcDKqez8fan64Eyicw4DJ"),
 }));
 
-jest
-  .spyOn(networkApi, "getAccountByAddress")
-  .mockImplementation((_adress: string) =>
-    Promise.resolve({ type: "user", balance: 1000 } as APIAccount),
-  );
+jest.spyOn(networkApi, "getAccountByAddress").mockResolvedValue({
+  type: "user",
+  balance: 1000,
+  revealed: true,
+  address: "tz1test",
+  publicKey: "edpktest",
+  counter: 0,
+  delegationLevel: 0,
+  delegationTime: "2021-01-01T00:00:00Z",
+  numTransactions: 0,
+  firstActivityTime: "2021-01-01T00:00:00Z",
+} as APIAccount);
 
 const api = createApi({
   baker: {
@@ -94,12 +101,28 @@ describe("Testing craftTransaction function", () => {
   beforeEach(() => jest.clearAllMocks());
 
   it("should use estimated fees when user does not provide them for crafting a transaction ", async () => {
-    logicEstimateFees.mockResolvedValue({ estimatedFees: DEFAULT_ESTIMATED_FEES });
-    await api.craftTransaction({ type: "send", sender: {} } as TezosTransactionIntent);
+    logicEstimateFees.mockResolvedValue({
+      estimatedFees: DEFAULT_ESTIMATED_FEES,
+      gasLimit: DEFAULT_GAS_LIMIT,
+      storageLimit: DEFAULT_STORAGE_LIMIT,
+    });
+    await api.craftTransaction({
+      intentType: "transaction",
+      type: "send",
+      sender: "tz1test",
+      recipient: "tz1recipient",
+      amount: 1000n,
+    } as TransactionIntent);
     expect(logicEstimateFees).toHaveBeenCalledTimes(1);
     expect(logicCraftTransactionMock).toHaveBeenCalledWith(
-      expect.any(Object),
-      expect.objectContaining({ fee: { fees: DEFAULT_ESTIMATED_FEES.toString() } }),
+      expect.objectContaining({ address: "tz1test" }),
+      expect.objectContaining({
+        fee: expect.objectContaining({
+          fees: DEFAULT_ESTIMATED_FEES.toString(),
+          gasLimit: DEFAULT_GAS_LIMIT.toString(),
+          storageLimit: DEFAULT_STORAGE_LIMIT.toString(),
+        }),
+      }),
     );
   });
 
@@ -110,10 +133,23 @@ describe("Testing craftTransaction function", () => {
         estimatedFees: DEFAULT_ESTIMATED_FEES,
         gasLimit: DEFAULT_GAS_LIMIT,
         storageLimit: DEFAULT_STORAGE_LIMIT,
+        parameters: {
+          gasLimit: DEFAULT_GAS_LIMIT,
+          storageLimit: DEFAULT_STORAGE_LIMIT,
+        },
       });
-      await api.craftTransaction({ type: "send", sender: {} } as TezosTransactionIntent, {
-        value: customFees,
-      });
+      await api.craftTransaction(
+        {
+          intentType: "transaction",
+          type: "send",
+          sender: "tz1test",
+          recipient: "tz1recipient",
+          amount: 1000n,
+        } as TransactionIntent,
+        {
+          value: customFees,
+        },
+      );
       expect(logicEstimateFees).toHaveBeenCalledTimes(1);
       expect(logicCraftTransactionMock).toHaveBeenCalledWith(
         expect.any(Object),
@@ -138,7 +174,13 @@ describe("Testing estimateFees function", () => {
       gasLimit: DEFAULT_GAS_LIMIT,
       storageLimit: DEFAULT_STORAGE_LIMIT,
     });
-    const result = await api.estimateFees({ type: "send", sender: {} } as TezosTransactionIntent);
+    const result = await api.estimateFees({
+      intentType: "transaction",
+      type: "send",
+      sender: "tz1test",
+      recipient: "tz1recipient",
+      amount: 1000n,
+    } as TransactionIntent);
     expect(result).toEqual({
       value: DEFAULT_ESTIMATED_FEES,
       parameters: {
@@ -149,9 +191,44 @@ describe("Testing estimateFees function", () => {
   });
 
   it("should throw taquito errors", async () => {
-    logicEstimateFees.mockResolvedValue({ taquitoError: "test" });
+    logicEstimateFees.mockResolvedValue({
+      estimatedFees: DEFAULT_ESTIMATED_FEES,
+      gasLimit: DEFAULT_GAS_LIMIT,
+      storageLimit: DEFAULT_STORAGE_LIMIT,
+      taquitoError: "test",
+    });
     await expect(
-      api.estimateFees({ type: "send", sender: {} } as TezosTransactionIntent),
+      api.estimateFees({
+        intentType: "transaction",
+        type: "send",
+        sender: "tz1test",
+        recipient: "tz1recipient",
+        amount: 1000n,
+      } as TransactionIntent),
     ).rejects.toThrow("Fees estimation failed: test");
   });
+
+  it("should not throw for delegate.unchanged errors", async () => {
+    logicEstimateFees.mockResolvedValue({
+      estimatedFees: DEFAULT_ESTIMATED_FEES,
+      gasLimit: DEFAULT_GAS_LIMIT,
+      storageLimit: DEFAULT_STORAGE_LIMIT,
+      taquitoError: "proto.022-PsRiotum.delegate.unchanged",
+    });
+    const result = await api.estimateFees({
+      intentType: "staking",
+      type: "delegate",
+      sender: "tz1test",
+      recipient: "tz1validator",
+      amount: 0n,
+    } as TransactionIntent);
+
+    expect(result).toEqual({
+      value: DEFAULT_ESTIMATED_FEES,
+      parameters: {
+        gasLimit: DEFAULT_GAS_LIMIT,
+        storageLimit: DEFAULT_STORAGE_LIMIT,
+      },
+    });
+  });
 });