@ledgerhq/coin-sui 0.15.0 → 0.16.0-nightly.1

package/src/logic/craftTransaction.test.ts

@@ -10,7 +10,7 @@ describe("craftTransaction", () => {
 
   beforeEach(() => {
     jest.clearAllMocks();
-    mockCreateTransaction.mockResolvedValue(mockUnsignedTx);
+    mockCreateTransaction.mockResolvedValue({ unsigned: mockUnsignedTx });
   });
 
   it("should create a transaction with correct parameters", async () => {
@@ -18,8 +18,10 @@ describe("craftTransaction", () => {
     const amount = BigInt("1000000000");
     const recipient = "0x456";
     const type = "send";
+    const intentType = "transaction";
 
     const result = await craftTransaction({
+      intentType,
       sender,
       amount,
       recipient,
@@ -27,12 +29,17 @@ describe("craftTransaction", () => {
       asset: { type: "native" },
     });
 
-    expect(mockCreateTransaction).toHaveBeenCalledWith(sender, {
-      amount: new BigNumber(amount.toString()),
-      recipient,
-      mode: type,
-      coinType: "0x2::sui::SUI",
-    });
+    expect(mockCreateTransaction).toHaveBeenCalledWith(
+      sender,
+      {
+        intentType,
+        amount: new BigNumber(amount.toString()),
+        recipient,
+        mode: type,
+        coinType: "0x2::sui::SUI",
+      },
+      false,
+    );
     expect(result).toEqual({ unsigned: mockUnsignedTx });
   });
 
@@ -41,8 +48,10 @@ describe("craftTransaction", () => {
     const amount = BigInt("500000000");
     const recipient = "0x456";
     const type = "send";
+    const intentType = "transaction";
 
     const result = await craftTransaction({
+      intentType,
       sender,
       amount,
       recipient,
@@ -50,12 +59,17 @@ describe("craftTransaction", () => {
       asset: { type: "native" },
     });
 
-    expect(mockCreateTransaction).toHaveBeenCalledWith(sender, {
-      amount: new BigNumber(amount.toString()),
-      recipient,
-      mode: type,
-      coinType: "0x2::sui::SUI",
-    });
+    expect(mockCreateTransaction).toHaveBeenCalledWith(
+      sender,
+      {
+        intentType,
+        amount: new BigNumber(amount.toString()),
+        recipient,
+        mode: type,
+        coinType: "0x2::sui::SUI",
+      },
+      false,
+    );
     expect(result).toEqual({ unsigned: mockUnsignedTx });
   });
 
@@ -64,8 +78,10 @@ describe("craftTransaction", () => {
     const amount = BigInt("0");
     const recipient = "0x456";
     const type = "send";
+    const intentType = "transaction";
 
     const result = await craftTransaction({
+      intentType,
       sender,
       amount,
       recipient,
@@ -73,12 +89,17 @@ describe("craftTransaction", () => {
       asset: { type: "native" },
     });
 
-    expect(mockCreateTransaction).toHaveBeenCalledWith(sender, {
-      amount: new BigNumber(amount.toString()),
-      recipient,
-      mode: type,
-      coinType: "0x2::sui::SUI",
-    });
+    expect(mockCreateTransaction).toHaveBeenCalledWith(
+      sender,
+      {
+        intentType,
+        amount: new BigNumber(amount.toString()),
+        recipient,
+        mode: type,
+        coinType: "0x2::sui::SUI",
+      },
+      false,
+    );
     expect(result).toEqual({ unsigned: mockUnsignedTx });
   });
 
@@ -87,8 +108,10 @@ describe("craftTransaction", () => {
     const amount = BigInt("1000000000000000000"); // 1 SUI (assuming 9 decimals)
     const recipient = "0x456";
     const type = "send";
+    const intentType = "transaction";
 
     const result = await craftTransaction({
+      intentType,
       sender,
       amount,
       recipient,
@@ -96,12 +119,17 @@ describe("craftTransaction", () => {
       asset: { type: "native" },
     });
 
-    expect(mockCreateTransaction).toHaveBeenCalledWith(sender, {
-      amount: new BigNumber(amount.toString()),
-      recipient,
-      mode: type,
-      coinType: "0x2::sui::SUI",
-    });
+    expect(mockCreateTransaction).toHaveBeenCalledWith(
+      sender,
+      {
+        intentType,
+        amount: new BigNumber(amount.toString()),
+        recipient,
+        mode: type,
+        coinType: "0x2::sui::SUI",
+      },
+      false,
+    );
     expect(result).toEqual({ unsigned: mockUnsignedTx });
   });
 
@@ -113,9 +141,11 @@ describe("craftTransaction", () => {
     const amount = BigInt("1000000000");
     const recipient = "0x456";
     const type = "send";
+    const intentType = "transaction";
 
     await expect(
       craftTransaction({
+        intentType,
         sender,
         amount,
         recipient,

package/src/logic/craftTransaction.ts

@@ -4,28 +4,33 @@ import type { SuiTransactionMode, CoreTransaction } from "../types";
 import suiAPI from "../network";
 import { DEFAULT_COIN_TYPE } from "../network/sdk";
 
-export async function craftTransaction({
-  amount,
-  asset,
-  recipient,
-  sender,
-  type,
-  ...extra
-}: TransactionIntent & {
-  useAllAmount?: boolean;
-  stakedSuiId?: string;
-}): Promise<CoreTransaction> {
+export async function craftTransaction(
+  {
+    amount,
+    asset,
+    recipient,
+    sender,
+    type,
+    ...extra
+  }: TransactionIntent & {
+    useAllAmount?: boolean;
+    stakedSuiId?: string;
+  },
+  withObjects: boolean = false,
+): Promise<CoreTransaction> {
   let coinType = DEFAULT_COIN_TYPE;
   if (asset.type === "token" && asset.assetReference) {
     coinType = asset.assetReference;
   }
-  const unsigned = await suiAPI.createTransaction(sender, {
-    amount: BigNumber(amount.toString()),
-    coinType,
-    mode: type as SuiTransactionMode,
-    recipient,
-    ...extra,
-  });
-
-  return { unsigned };
+  return suiAPI.createTransaction(
+    sender,
+    {
+      amount: BigNumber(amount.toString()),
+      coinType,
+      mode: type as SuiTransactionMode,
+      recipient,
+      ...extra,
+    },
+    withObjects,
+  );
 }

package/src/logic/estimateFees.integration.test.ts

@@ -3,7 +3,7 @@ import { getFullnodeUrl } from "@mysten/sui/client";
 import coinConfig from "../config";
 import { estimateFees } from "./estimateFees";
 
-const SENDER = "0x6e143fe0a8ca010a86580dafac44298e5b1b7d73efc345356a59a15f0d7824f0";
+const SENDER = "0xad79719ac7edb44f6e253f1f771e8291e281a6aaf1e4789b52bf85336f525e8e";
 const RECIPIENT = "0x33444cf803c690db96527cec67e3c9ab512596f4ba2d4eace43f0b4f716e0164";
 
 describe("estimateFees", () => {
@@ -20,6 +20,7 @@ describe("estimateFees", () => {
 
   it("should estimate fees for native SUI transaction", async () => {
     const transactionIntent: TransactionIntent = {
+      intentType: "transaction",
       sender: SENDER,
       recipient: RECIPIENT,
       amount: BigInt(1000),
@@ -39,6 +40,7 @@ describe("estimateFees", () => {
       "0x375f70cf2ae4c00bf37117d0c85a2c71545e6ee05c4a5c7d282cd66a4504b068::usdt::USDT";
 
     const transactionIntent: TransactionIntent = {
+      intentType: "transaction",
       sender: SENDER,
       recipient: RECIPIENT,
       amount: BigInt(1000),
@@ -58,6 +60,7 @@ describe("estimateFees", () => {
 
   it("should handle concurrent fee estimations", async () => {
     const transactionIntent: TransactionIntent = {
+      intentType: "transaction",
       sender: SENDER,
       recipient: RECIPIENT,
       amount: BigInt(1000),

package/src/logic/estimateFees.test.ts

@@ -23,6 +23,7 @@ describe("estimateFees", () => {
     });
 
     const transactionIntent = {
+      intentType: "transaction" as const,
       sender: "0x123",
       recipient: "0x456",
       amount: BigInt("1000000000"),
@@ -50,6 +51,7 @@ describe("estimateFees", () => {
     });
 
     const transactionIntent = {
+      intentType: "transaction" as const,
       sender: "0x123",
       recipient: "0x456",
       amount: BigInt("0"),

package/src/network/sdk.integration.test.ts

@@ -155,14 +155,14 @@ describe("SUI SDK Integration tests", () => {
         recipient: "0x33444cf803c690db96527cec67e3c9ab512596f4ba2d4eace43f0b4f716e0164",
         errors: {},
       };
-      const tx = await createTransaction(address, transaction);
+      const { unsigned: tx } = await createTransaction(address, transaction);
       expect(tx).toBeInstanceOf(Uint8Array);
     });
   });
 
   describe("paymentInfo", () => {
     test("paymentInfo should return gas budget and fees", async () => {
-      const sender = "0x6e143fe0a8ca010a86580dafac44298e5b1b7d73efc345356a59a15f0d7824f0";
+      const sender = "0xad79719ac7edb44f6e253f1f771e8291e281a6aaf1e4789b52bf85336f525e8e";
       const fakeTransaction = {
         mode: "send" as const,
         family: "sui" as const,