@ledgerhq/coin-polkadot 0.1.0 → 0.1.1-next.0

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @ledgerhq/coin-polkadot
 
+## 0.1.1-next.0
+
+### Patch Changes
+
+- Updated dependencies [[`5785155282`](https://github.com/LedgerHQ/ledger-live/commit/5785155282d61d0dbdc30f7a66d3243a74fce117), [`197d28697b`](https://github.com/LedgerHQ/ledger-live/commit/197d28697b173c3f6b2badfe4d1deddeadc912d4), [`d4834aad3f`](https://github.com/LedgerHQ/ledger-live/commit/d4834aad3f58d904850be9a3ab40b46260d9f7d4)]:
+  - @ledgerhq/cryptoassets@9.3.0-next.0
+  - @ledgerhq/types-live@6.32.0-next.0
+  - @ledgerhq/coin-framework@0.2.2-next.0
+  - @ledgerhq/live-portfolio@0.0.2-next.0
+
 ## 0.1.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ledgerhq/coin-polkadot",
-  "version": "0.1.0",
+  "version": "0.1.1-next.0",
   "description": "Ledger Polkadot Coin integration",
   "keywords": [
     "Ledger",
@@ -54,20 +54,22 @@
     "invariant": "^2.2.2",
     "lodash": "^4.17.21",
     "rxjs": "^6.6.7",
-    "@ledgerhq/coin-framework": "^0.2.1",
-    "@ledgerhq/cryptoassets": "^9.2.0",
+    "@ledgerhq/coin-framework": "^0.2.2-next.0",
+    "@ledgerhq/cryptoassets": "^9.3.0-next.0",
     "@ledgerhq/devices": "^8.0.1",
     "@ledgerhq/errors": "^6.12.4",
     "@ledgerhq/hw-app-polkadot": "^6.27.13",
     "@ledgerhq/live-env": "^0.0.1",
-    "@ledgerhq/live-portfolio": "^0.0.1",
+    "@ledgerhq/live-portfolio": "^0.0.2-next.0",
     "@ledgerhq/live-promise": "^0.0.1",
     "@ledgerhq/logs": "^6.10.1",
     "@ledgerhq/types-cryptoassets": "^7.0.0",
-    "@ledgerhq/types-live": "^6.31.0"
+    "@ledgerhq/types-live": "^6.32.0-next.0"
   },
   "devDependencies": {
+    "@types/invariant": "^2.2.2",
     "@types/jest": "^29.2.4",
+    "@types/lodash": "^4.14.191",
     "@typescript-eslint/eslint-plugin": "^5.46.1",
     "@typescript-eslint/parser": "^5.46.1",
     "eslint": "^7.32.0",

package/src/account.ts

@@ -18,7 +18,7 @@ function formatOperationSpecifics(
     validatorStash,
     amount,
   } = op.extra;
-  let str = (validators || []).map((v) => `\n    ${v}`).join("");
+  let str = (validators || []).map((v: any) => `\n    ${v}`).join("");
   const formatConfig = {
     disableRounding: true,
     alwaysShowSign: false,

package/src/api/bisontrails.ts

@@ -38,9 +38,9 @@ const getAccountOperationUrl = (
     startAt,
   })}`;
 
-const getWithdrawUnbondedAmount = (extrinsic) => {
+const getWithdrawUnbondedAmount = (extrinsic: any) => {
   return (
-    extrinsic?.staking?.eventStaking.reduce((acc, curr) => {
+    extrinsic?.staking?.eventStaking.reduce((acc: any, curr: any) => {
       return curr.method === "Withdrawn"
         ? new BigNumber(acc).plus(curr.value)
         : new BigNumber(0);
@@ -48,7 +48,7 @@ const getWithdrawUnbondedAmount = (extrinsic) => {
   );
 };
 
-const getController = (_extrinsic) => {
+const getController = (_extrinsic: any) => {
   // TODO: ask BisonTrails to provide the info
   return "";
 };
@@ -126,7 +126,7 @@ const getExtra = (type: OperationType, extrinsic: any): Record<string, any> => {
       extra = {
         ...extra,
         validators:
-          extrinsic.staking?.validators?.reduce((acc, current) => {
+          extrinsic.staking?.validators?.reduce((acc: any, current: any) => {
             return [...acc, current.address];
           }, []) ?? [],
       };
@@ -144,7 +144,7 @@ const getExtra = (type: OperationType, extrinsic: any): Record<string, any> => {
  *
  * @returns {BigNumber}
  */
-const getValue = (extrinsic, type: OperationType): BigNumber => {
+const getValue = (extrinsic: any, type: OperationType): BigNumber => {
   if (!extrinsic.isSuccess) {
     return type === "IN"
       ? new BigNumber(0)
@@ -178,7 +178,7 @@ const getValue = (extrinsic, type: OperationType): BigNumber => {
 const extrinsicToOperation = (
   addr: string,
   accountId: string,
-  extrinsic
+  extrinsic: any
 ): Partial<Operation> | null => {
   let type = getOperationType(extrinsic.section, extrinsic.method);
 
@@ -226,7 +226,7 @@ const extrinsicToOperation = (
 const rewardToOperation = (
   addr: string,
   accountId: string,
-  reward
+  reward: any
 ): Partial<Operation> => {
   const hash = reward.extrinsicHash;
   const type = "REWARD_PAYOUT";
@@ -257,7 +257,7 @@ const rewardToOperation = (
 const slashToOperation = (
   addr: string,
   accountId: string,
-  slash
+  slash: any
 ): Partial<Operation> => {
   const hash = `${slash.blockNumber}`;
   const type = "SLASH";
@@ -294,18 +294,18 @@ const fetchOperationList =
     startAt: number,
     offset = 0,
     prevOperations: Operation[] = []
-  ) => {
+  ): Promise<Operation[]> => {
     const { data } = await network({
       method: "GET",
       url: getAccountOperationUrl(addr, offset, startAt),
     });
-    const operations = data.extrinsics.map((extrinsic) =>
+    const operations = data.extrinsics.map((extrinsic: any) =>
       extrinsicToOperation(addr, accountId, extrinsic)
     );
-    const rewards = data.rewards.map((reward) =>
+    const rewards = data.rewards.map((reward: any) =>
       rewardToOperation(addr, accountId, reward)
     );
-    const slashes = data.slashes.map((slash) =>
+    const slashes = data.slashes.map((slash: any) =>
       slashToOperation(addr, accountId, slash)
     );
     const mergedOp = [...prevOperations, ...operations, ...rewards, ...slashes];

package/src/api/sidecar.ts

@@ -44,7 +44,8 @@ const getBaseSidecarUrl = (): string => getEnv("API_POLKADOT_SIDECAR");
  *
  * @returns {string}
  */
-const getSidecarUrl = (route): string => `${getBaseSidecarUrl()}${route || ""}`;
+const getSidecarUrl = (route: string): string =>
+  `${getBaseSidecarUrl()}${route || ""}`;
 
 const VALIDATOR_COMISSION_RATIO = 1000000000;
 const ELECTION_STATUS_OPTIMISTIC_THRESHOLD =

package/src/bridge/js.ts

@@ -27,7 +27,10 @@ import { getPreloadStrategy, hydrate, preload } from "../preload";
 import type { Transaction } from "../types";
 import { LRUCacheFn } from "@ledgerhq/coin-framework/cache";
 
-const updateTransaction = (t, patch) => ({ ...t, ...patch });
+const updateTransaction = (t: Transaction, patch: Partial<Transaction>) => ({
+  ...t,
+  ...patch,
+});
 
 /**
  * Broadcast the signed transaction

package/src/cli-transaction.ts

@@ -12,7 +12,7 @@ import {
   SidecarValidatorsParamStatus,
 } from "./api/sidecar.types";
 import { AccountLike } from "@ledgerhq/types-live";
-import { PolkadotAccount, Transaction } from "./types";
+import { PolkadotAccount, PolkadotValidator, Transaction } from "./types";
 import { PolkadotAPI } from "./api";
 import { NetworkRequestCall } from "@ledgerhq/coin-framework/network";
 import { LRUCacheFn } from "@ledgerhq/coin-framework/cache";
@@ -50,59 +50,61 @@ const options = [
     desc: "Reward destination",
   },
 ];
-const polkadotValidatorsFormatters = {
-  json: (list) => JSON.stringify(list),
-  csv: (list) => {
-    const polkadotUnit = getCryptoCurrencyById("polkadot").units[0];
-    const csvHeader =
-      "ADDRESS IDENTITY TOTAL_BONDED SELF_BONDED NOMINATORS_COUNT COMMISSION REWARD_POINTS\n";
-    const csvList = list
-      .map(
-        (v) =>
-          `${v.address} "${v.identity}" ${formatCurrencyUnit(
-            polkadotUnit,
-            v.totalBonded,
-            {
+type PolkadotValidatorFormatter = (list: PolkadotValidator[]) => string;
+const polkadotValidatorsFormatters: Record<string, PolkadotValidatorFormatter> =
+  {
+    json: (list: PolkadotValidator[]) => JSON.stringify(list),
+    csv: (list: PolkadotValidator[]) => {
+      const polkadotUnit = getCryptoCurrencyById("polkadot").units[0];
+      const csvHeader =
+        "ADDRESS IDENTITY TOTAL_BONDED SELF_BONDED NOMINATORS_COUNT COMMISSION REWARD_POINTS\n";
+      const csvList = list
+        .map(
+          (v) =>
+            `${v.address} "${v.identity}" ${formatCurrencyUnit(
+              polkadotUnit,
+              v.totalBonded,
+              {
+                showCode: false,
+                disableRounding: true,
+                useGrouping: false,
+              }
+            )} ${formatCurrencyUnit(polkadotUnit, v.selfBonded, {
               showCode: false,
               disableRounding: true,
               useGrouping: false,
-            }
-          )} ${formatCurrencyUnit(polkadotUnit, v.selfBonded, {
-            showCode: false,
-            disableRounding: true,
-            useGrouping: false,
-          })} ${v.nominatorsCount} ${v.commission
-            .multipliedBy(100)
-            .toFixed(2)} ${v.rewardPoints}`
-      )
-      .join("\n");
-    return csvHeader + csvList;
-  },
-  default: (list) => {
-    const polkadotUnit = getCryptoCurrencyById("polkadot").units[0];
-    const tableList = list
-      .map(
-        (v) =>
-          `${v.address} "${v.identity}" ${formatCurrencyUnit(
-            polkadotUnit,
-            v.totalBonded,
-            {
+            })} ${v.nominatorsCount} ${v.commission
+              .multipliedBy(100)
+              .toFixed(2)} ${v.rewardPoints}`
+        )
+        .join("\n");
+      return csvHeader + csvList;
+    },
+    default: (list: PolkadotValidator[]) => {
+      const polkadotUnit = getCryptoCurrencyById("polkadot").units[0];
+      const tableList = list
+        .map(
+          (v) =>
+            `${v.address} "${v.identity}" ${formatCurrencyUnit(
+              polkadotUnit,
+              v.totalBonded,
+              {
+                showCode: true,
+                disableRounding: true,
+                useGrouping: false,
+              }
+            )} ${formatCurrencyUnit(polkadotUnit, v.selfBonded, {
               showCode: true,
               disableRounding: true,
               useGrouping: false,
-            }
-          )} ${formatCurrencyUnit(polkadotUnit, v.selfBonded, {
-            showCode: true,
-            disableRounding: true,
-            useGrouping: false,
-          })} ${v.nominatorsCount} ${
-            v.commission.multipliedBy(100).toFixed(2) + "%"
-          } ${v.rewardPoints + " PTS"}`
-      )
-      .join("\n");
-    return tableList;
-  },
-};
+            })} ${v.nominatorsCount} ${
+              v.commission.multipliedBy(100).toFixed(2) + "%"
+            } ${v.rewardPoints + " PTS"}`
+        )
+        .join("\n");
+      return tableList;
+    },
+  };
 function createValidators(polkadotAPI: PolkadotAPI) {
   return {
     args: [
@@ -139,8 +141,9 @@ function createValidators(polkadotAPI: PolkadotAPI) {
       ).pipe(
         map((validators) => {
           const f =
-            (format && polkadotValidatorsFormatters[format]) ||
-            polkadotValidatorsFormatters.default;
+            format && format in polkadotValidatorsFormatters
+              ? polkadotValidatorsFormatters[format]
+              : polkadotValidatorsFormatters.default;
           return f(validators);
         })
       ),
@@ -155,30 +158,39 @@ function inferTransactions(
   opts: Record<string, any>,
   { inferAmount }: any
 ): Transaction[] {
-  return flatMap(transactions, ({ transaction, account }) => {
-    invariant(transaction.family === "polkadot", "polkadot family");
+  return flatMap(
+    transactions,
+    ({
+      transaction,
+      account,
+    }: {
+      account: AccountLike;
+      transaction: Transaction;
+    }) => {
+      invariant(transaction.family === "polkadot", "polkadot family");
 
-    if (isAccount(account)) {
-      invariant(
-        (account as PolkadotAccount).polkadotResources,
-        "unactivated account"
-      );
-    }
+      if (isAccount(account)) {
+        invariant(
+          (account as PolkadotAccount).polkadotResources,
+          "unactivated account"
+        );
+      }
 
-    const validators: string[] = opts["validator"] || [];
-    return {
-      ...transaction,
-      family: "polkadot",
-      fees: opts.fees ? inferAmount(account, opts.fees) : null,
-      mode: opts.mode || "send",
-      validators,
-      era: opts.era || null,
-      rewardDestination: opts.rewardDestination || null,
-      numSlashingSpans: isAccount(account)
-        ? (account as PolkadotAccount).polkadotResources?.numSlashingSpans
-        : null,
-    };
-  });
+      const validators: string[] = opts["validator"] || [];
+      return {
+        ...transaction,
+        family: "polkadot",
+        fees: opts.fees ? inferAmount(account, opts.fees) : null,
+        mode: opts.mode || "send",
+        validators,
+        era: opts.era || null,
+        rewardDestination: opts.rewardDestination || null,
+        numSlashingSpans: isAccount(account)
+          ? (account as PolkadotAccount).polkadotResources?.numSlashingSpans
+          : null,
+      };
+    }
+  );
 }
 
 export default function makeCliTools(

package/src/js-buildTransaction.ts

@@ -10,7 +10,15 @@ const DEFAULTS = {
   eraPeriod: 64,
 };
 
-const getExtrinsicParams = (a: PolkadotAccount, t: Transaction) => {
+type ExtrinsicParams = {
+  name: string;
+  pallet: "staking" | "balances";
+  args: Record<string, any>;
+};
+const getExtrinsicParams = (
+  a: PolkadotAccount,
+  t: Transaction
+): ExtrinsicParams => {
   const validator = t.validators ? t.validators[0] : null;
 
   switch (t.mode) {
@@ -170,10 +178,8 @@ export const buildTransaction =
     const methodArgs = methodFunction.meta.args;
     const method = methodFunction(
       ...methodArgs.map((arg) => {
-        if (
-          extrinsicParams.args[stringCamelCase(arg.name.toString())] ===
-          undefined
-        ) {
+        const param = extrinsicParams.args[stringCamelCase(arg.name)];
+        if (param === undefined) {
           throw new Error(
             `Method ${extrinsicParams.pallet}::${
               extrinsicParams.name
@@ -181,7 +187,7 @@ export const buildTransaction =
           );
         }
 
-        return extrinsicParams.args[stringCamelCase(arg.name.toString())];
+        return param;
       })
     ).toHex();
     const unsigned = {

package/src/js-prepareTransaction.ts

@@ -2,8 +2,10 @@ import type { PolkadotAccount, Transaction } from "./types";
 import getEstimatedFees from "./js-getFeesForTransaction";
 import { loadPolkadotCrypto } from "./polkadot-crypto";
 import { PolkadotAPI } from "./api";
+import BigNumber from "bignumber.js";
 
-const sameFees = (a, b) => (!a || !b ? a === b : a.eq(b));
+const sameFees = (a: BigNumber, b?: BigNumber | null) =>
+  !a || !b ? a === b : a.eq(b);
 
 /**
  * Calculate fees for the current transaction
@@ -19,7 +21,7 @@ const prepareTransaction =
       t,
     });
 
-    if (!sameFees(t.fees, fees)) {
+    if (!sameFees(fees, t.fees)) {
       return { ...t, fees };
     }
 

package/src/preload.ts

@@ -2,7 +2,11 @@
 import { BigNumber } from "bignumber.js";
 import { Observable, Subject } from "rxjs";
 import { log } from "@ledgerhq/logs";
-import type { PolkadotPreloadData, PolkadotValidator } from "./types";
+import type {
+  PolkadotPreloadData,
+  PolkadotStakingProgress,
+  PolkadotValidator,
+} from "./types";
 import { loadPolkadotCrypto } from "./polkadot-crypto";
 import { PolkadotAPI } from "./api";
 
@@ -101,7 +105,10 @@ export const getPreloadStrategy = () => ({
   preloadMaxAge: PRELOAD_MAX_AGE,
 });
 
-const shouldRefreshValidators = (previousState, currentState) => {
+const shouldRefreshValidators = (
+  previousState: PolkadotStakingProgress | undefined,
+  currentState: PolkadotStakingProgress
+) => {
   return !previousState || currentState.activeEra !== previousState.activeEra;
 };
 

package/src/specs.ts

@@ -39,7 +39,7 @@ const polkadot: AppSpec<Transaction> = {
   name: "Polkadot",
   currency: getCryptoCurrencyById("polkadot"),
   appQuery: {
-    model: DeviceModelId.nanoS,
+    model: DeviceModelId.nanoSP,
     appName: "Polkadot",
   },
   testTimeout: 2 * 60 * 1000,

package/tsconfig.json

@@ -4,8 +4,6 @@
     "declarationMap": true,
     "sourceMap": true,
     "strict": true,
-    "noImplicitAny": false,
-    "noImplicitThis": false,
     "allowSyntheticDefaultImports": true,
     "esModuleInterop": true,
     "skipLibCheck": true,
@@ -16,6 +14,6 @@
     "lib": ["es2020", "dom"],
     "outDir": "lib"
   },
-  "include": ["src/**/*"]
+  "include": ["src/**/*"],
+  "exclude": ["src/api/subscan.ts", "src/api/websocket.ts"]
 }
-