@ledgerhq/coin-hypercore 0.4.2 → 0.4.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @ledgerhq/coin-hypercore
 
+## 0.4.3
+
+### Patch Changes
+
+- [#758](https://github.com/LedgerHQ/coin-modules/pull/758) [`aa464dd`](https://github.com/LedgerHQ/coin-modules/commit/aa464dd83fe9fcaf730ab9857a9b5853b23544bf) Thanks [@YazhuEth](https://github.com/YazhuEth)! - Implement `validateAddress` so the generic coin framework can validate HyperCore recipients/addresses. It previously threw `notSupported`, which broke address validation now that the framework consumes it from the `CoinModuleApi` instance. HyperCore addresses are Ethereum-format, so this checks the `0x`-prefixed 40-hex-character shape.
+
 ## 0.4.2
 
 ### Patch Changes

package/lib/api/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/api/index.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,KAAK,aAAa,EAAgB,MAAM,2CAA2C,CAAA;AAC5F,OAAmB,EAAE,KAAK,eAAe,EAAE,MAAM,WAAW,CAAA;AAK5D,wBAAgB,SAAS,CAAC,MAAM,EAAE,eAAe,GAAG,aAAa,CAuBhE"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/api/index.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,KAAK,aAAa,EAAgB,MAAM,2CAA2C,CAAA;AAC5F,OAAmB,EAAE,KAAK,eAAe,EAAE,MAAM,WAAW,CAAA;AAM5D,wBAAgB,SAAS,CAAC,MAAM,EAAE,eAAe,GAAG,aAAa,CAuBhE"}

package/lib/api/index.js

@@ -11,6 +11,7 @@ const config_1 = __importDefault(require("../config"));
 const getBalance_1 = require("./getBalance");
 const lastBlock_1 = require("./lastBlock");
 const listOperations_1 = require("./listOperations");
+const validateAddress_1 = require("./validateAddress");
 function createApi(config) {
     config_1.default.setCoinConfig(() => ({ ...config, status: { type: 'active' } }));
     return {
@@ -30,7 +31,7 @@ function createApi(config) {
         broadcast: (0, index_1.notSupported)('broadcast'),
         validateIntent: (0, index_1.notSupported)('validateIntent'),
         getNextSequence: (0, index_1.notSupported)('getNextSequence'),
-        validateAddress: (0, index_1.notSupported)('validateAddress'),
+        validateAddress: validateAddress_1.validateAddress,
         craftTransactionData: (0, index_1.notSupported)('craftTransactionData'),
     };
 }

package/lib/api/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../../src/api/index.ts"],"names":[],"mappings":";AAAA,4CAA4C;AAC5C,sCAAsC;;;;;AAQtC,8BAuBC;AA7BD,qEAA4F;AAC5F,uDAA4D;AAC5D,6CAAyC;AACzC,2CAAuC;AACvC,qDAAiD;AAEjD,SAAgB,SAAS,CAAC,MAAuB;IAC/C,gBAAU,CAAC,aAAa,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,GAAG,MAAM,EAAE,MAAM,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,EAAE,CAAC,CAAC,CAAA;IAE3E,OAAO;QACL,SAAS,EAAT,qBAAS;QACT,YAAY,EAAE,IAAA,oBAAY,EAAC,cAAc,CAAC;QAC1C,QAAQ,EAAE,IAAA,oBAAY,EAAC,UAAU,CAAC;QAClC,IAAI,EAAE,IAAA,oBAAY,EAAC,MAAM,CAAC;QAC1B,aAAa,EAAE,IAAA,oBAAY,EAAC,eAAe,CAAC;QAC5C,UAAU,EAAV,uBAAU;QACV,cAAc,EAAd,+BAAc;QACd,SAAS,EAAE,IAAA,oBAAY,EAAC,WAAW,CAAC;QACpC,UAAU,EAAE,IAAA,oBAAY,EAAC,YAAY,CAAC;QACtC,gBAAgB,EAAE,IAAA,oBAAY,EAAC,kBAAkB,CAAC;QAClD,mBAAmB,EAAE,IAAA,oBAAY,EAAC,qBAAqB,CAAC;QACxD,YAAY,EAAE,IAAA,oBAAY,EAAC,cAAc,CAAC;QAC1C,OAAO,EAAE,IAAA,oBAAY,EAAC,SAAS,CAAC;QAChC,SAAS,EAAE,IAAA,oBAAY,EAAC,WAAW,CAAC;QACpC,cAAc,EAAE,IAAA,oBAAY,EAAC,gBAAgB,CAAC;QAC9C,eAAe,EAAE,IAAA,oBAAY,EAAC,iBAAiB,CAAC;QAChD,eAAe,EAAE,IAAA,oBAAY,EAAC,iBAAiB,CAAC;QAChD,oBAAoB,EAAE,IAAA,oBAAY,EAAC,sBAAsB,CAAC;KAC3D,CAAA;AACH,CAAC"}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../src/api/index.ts"],"names":[],"mappings":";AAAA,4CAA4C;AAC5C,sCAAsC;;;;;AAStC,8BAuBC;AA9BD,qEAA4F;AAC5F,uDAA4D;AAC5D,6CAAyC;AACzC,2CAAuC;AACvC,qDAAiD;AACjD,uDAAmD;AAEnD,SAAgB,SAAS,CAAC,MAAuB;IAC/C,gBAAU,CAAC,aAAa,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,GAAG,MAAM,EAAE,MAAM,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,EAAE,CAAC,CAAC,CAAA;IAE3E,OAAO;QACL,SAAS,EAAT,qBAAS;QACT,YAAY,EAAE,IAAA,oBAAY,EAAC,cAAc,CAAC;QAC1C,QAAQ,EAAE,IAAA,oBAAY,EAAC,UAAU,CAAC;QAClC,IAAI,EAAE,IAAA,oBAAY,EAAC,MAAM,CAAC;QAC1B,aAAa,EAAE,IAAA,oBAAY,EAAC,eAAe,CAAC;QAC5C,UAAU,EAAV,uBAAU;QACV,cAAc,EAAd,+BAAc;QACd,SAAS,EAAE,IAAA,oBAAY,EAAC,WAAW,CAAC;QACpC,UAAU,EAAE,IAAA,oBAAY,EAAC,YAAY,CAAC;QACtC,gBAAgB,EAAE,IAAA,oBAAY,EAAC,kBAAkB,CAAC;QAClD,mBAAmB,EAAE,IAAA,oBAAY,EAAC,qBAAqB,CAAC;QACxD,YAAY,EAAE,IAAA,oBAAY,EAAC,cAAc,CAAC;QAC1C,OAAO,EAAE,IAAA,oBAAY,EAAC,SAAS,CAAC;QAChC,SAAS,EAAE,IAAA,oBAAY,EAAC,WAAW,CAAC;QACpC,cAAc,EAAE,IAAA,oBAAY,EAAC,gBAAgB,CAAC;QAC9C,eAAe,EAAE,IAAA,oBAAY,EAAC,iBAAiB,CAAC;QAChD,eAAe,EAAf,iCAAe;QACf,oBAAoB,EAAE,IAAA,oBAAY,EAAC,sBAAsB,CAAC;KAC3D,CAAA;AACH,CAAC"}

package/lib/api/validateAddress.d.ts

@@ -0,0 +1,3 @@
+import type { AddressValidationCurrencyParameters } from '@ledgerhq/coin-module-framework/api/types';
+export declare function validateAddress(address: string, _parameters: Partial<AddressValidationCurrencyParameters>): Promise<boolean>;
+//# sourceMappingURL=validateAddress.d.ts.map

package/lib/api/validateAddress.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"validateAddress.d.ts","sourceRoot":"","sources":["../../src/api/validateAddress.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,mCAAmC,EAAE,MAAM,2CAA2C,CAAA;AAKpG,wBAAsB,eAAe,CACnC,OAAO,EAAE,MAAM,EACf,WAAW,EAAE,OAAO,CAAC,mCAAmC,CAAC,GACxD,OAAO,CAAC,OAAO,CAAC,CAElB"}

package/lib/api/validateAddress.js

@@ -0,0 +1,11 @@
+"use strict";
+// SPDX-FileCopyrightText: © 2024 LEDGER SAS
+// SPDX-License-Identifier: Apache-2.0
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.validateAddress = validateAddress;
+// Ethereum-format address; validate hex shape only (no EIP-55 checksum — no keccak dep).
+const ETH_ADDRESS_REGEX = /^0x[0-9a-fA-F]{40}$/;
+async function validateAddress(address, _parameters) {
+    return ETH_ADDRESS_REGEX.test(address);
+}
+//# sourceMappingURL=validateAddress.js.map

package/lib/api/validateAddress.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"validateAddress.js","sourceRoot":"","sources":["../../src/api/validateAddress.ts"],"names":[],"mappings":";AAAA,4CAA4C;AAC5C,sCAAsC;;AAOtC,0CAKC;AARD,yFAAyF;AACzF,MAAM,iBAAiB,GAAG,qBAAqB,CAAA;AAExC,KAAK,UAAU,eAAe,CACnC,OAAe,EACf,WAAyD;IAEzD,OAAO,iBAAiB,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;AACxC,CAAC"}

package/lib-es/api/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/api/index.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,KAAK,aAAa,EAAgB,MAAM,2CAA2C,CAAA;AAC5F,OAAmB,EAAE,KAAK,eAAe,EAAE,MAAM,WAAW,CAAA;AAK5D,wBAAgB,SAAS,CAAC,MAAM,EAAE,eAAe,GAAG,aAAa,CAuBhE"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/api/index.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,KAAK,aAAa,EAAgB,MAAM,2CAA2C,CAAA;AAC5F,OAAmB,EAAE,KAAK,eAAe,EAAE,MAAM,WAAW,CAAA;AAM5D,wBAAgB,SAAS,CAAC,MAAM,EAAE,eAAe,GAAG,aAAa,CAuBhE"}

package/lib-es/api/index.js

@@ -5,6 +5,7 @@ import coinConfig from '../config';
 import { getBalance } from './getBalance';
 import { lastBlock } from './lastBlock';
 import { listOperations } from './listOperations';
+import { validateAddress } from './validateAddress';
 export function createApi(config) {
     coinConfig.setCoinConfig(() => ({ ...config, status: { type: 'active' } }));
     return {
@@ -24,7 +25,7 @@ export function createApi(config) {
         broadcast: notSupported('broadcast'),
         validateIntent: notSupported('validateIntent'),
         getNextSequence: notSupported('getNextSequence'),
-        validateAddress: notSupported('validateAddress'),
+        validateAddress,
         craftTransactionData: notSupported('craftTransactionData'),
     };
 }

package/lib-es/api/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../../src/api/index.ts"],"names":[],"mappings":"AAAA,4CAA4C;AAC5C,sCAAsC;AAEtC,OAAO,EAAsB,YAAY,EAAE,MAAM,2CAA2C,CAAA;AAC5F,OAAO,UAAoC,MAAM,WAAW,CAAA;AAC5D,OAAO,EAAE,UAAU,EAAE,MAAM,cAAc,CAAA;AACzC,OAAO,EAAE,SAAS,EAAE,MAAM,aAAa,CAAA;AACvC,OAAO,EAAE,cAAc,EAAE,MAAM,kBAAkB,CAAA;AAEjD,MAAM,UAAU,SAAS,CAAC,MAAuB;IAC/C,UAAU,CAAC,aAAa,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,GAAG,MAAM,EAAE,MAAM,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,EAAE,CAAC,CAAC,CAAA;IAE3E,OAAO;QACL,SAAS;QACT,YAAY,EAAE,YAAY,CAAC,cAAc,CAAC;QAC1C,QAAQ,EAAE,YAAY,CAAC,UAAU,CAAC;QAClC,IAAI,EAAE,YAAY,CAAC,MAAM,CAAC;QAC1B,aAAa,EAAE,YAAY,CAAC,eAAe,CAAC;QAC5C,UAAU;QACV,cAAc;QACd,SAAS,EAAE,YAAY,CAAC,WAAW,CAAC;QACpC,UAAU,EAAE,YAAY,CAAC,YAAY,CAAC;QACtC,gBAAgB,EAAE,YAAY,CAAC,kBAAkB,CAAC;QAClD,mBAAmB,EAAE,YAAY,CAAC,qBAAqB,CAAC;QACxD,YAAY,EAAE,YAAY,CAAC,cAAc,CAAC;QAC1C,OAAO,EAAE,YAAY,CAAC,SAAS,CAAC;QAChC,SAAS,EAAE,YAAY,CAAC,WAAW,CAAC;QACpC,cAAc,EAAE,YAAY,CAAC,gBAAgB,CAAC;QAC9C,eAAe,EAAE,YAAY,CAAC,iBAAiB,CAAC;QAChD,eAAe,EAAE,YAAY,CAAC,iBAAiB,CAAC;QAChD,oBAAoB,EAAE,YAAY,CAAC,sBAAsB,CAAC;KAC3D,CAAA;AACH,CAAC"}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../src/api/index.ts"],"names":[],"mappings":"AAAA,4CAA4C;AAC5C,sCAAsC;AAEtC,OAAO,EAAsB,YAAY,EAAE,MAAM,2CAA2C,CAAA;AAC5F,OAAO,UAAoC,MAAM,WAAW,CAAA;AAC5D,OAAO,EAAE,UAAU,EAAE,MAAM,cAAc,CAAA;AACzC,OAAO,EAAE,SAAS,EAAE,MAAM,aAAa,CAAA;AACvC,OAAO,EAAE,cAAc,EAAE,MAAM,kBAAkB,CAAA;AACjD,OAAO,EAAE,eAAe,EAAE,MAAM,mBAAmB,CAAA;AAEnD,MAAM,UAAU,SAAS,CAAC,MAAuB;IAC/C,UAAU,CAAC,aAAa,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,GAAG,MAAM,EAAE,MAAM,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,EAAE,CAAC,CAAC,CAAA;IAE3E,OAAO;QACL,SAAS;QACT,YAAY,EAAE,YAAY,CAAC,cAAc,CAAC;QAC1C,QAAQ,EAAE,YAAY,CAAC,UAAU,CAAC;QAClC,IAAI,EAAE,YAAY,CAAC,MAAM,CAAC;QAC1B,aAAa,EAAE,YAAY,CAAC,eAAe,CAAC;QAC5C,UAAU;QACV,cAAc;QACd,SAAS,EAAE,YAAY,CAAC,WAAW,CAAC;QACpC,UAAU,EAAE,YAAY,CAAC,YAAY,CAAC;QACtC,gBAAgB,EAAE,YAAY,CAAC,kBAAkB,CAAC;QAClD,mBAAmB,EAAE,YAAY,CAAC,qBAAqB,CAAC;QACxD,YAAY,EAAE,YAAY,CAAC,cAAc,CAAC;QAC1C,OAAO,EAAE,YAAY,CAAC,SAAS,CAAC;QAChC,SAAS,EAAE,YAAY,CAAC,WAAW,CAAC;QACpC,cAAc,EAAE,YAAY,CAAC,gBAAgB,CAAC;QAC9C,eAAe,EAAE,YAAY,CAAC,iBAAiB,CAAC;QAChD,eAAe;QACf,oBAAoB,EAAE,YAAY,CAAC,sBAAsB,CAAC;KAC3D,CAAA;AACH,CAAC"}

package/lib-es/api/validateAddress.d.ts

@@ -0,0 +1,3 @@
+import type { AddressValidationCurrencyParameters } from '@ledgerhq/coin-module-framework/api/types';
+export declare function validateAddress(address: string, _parameters: Partial<AddressValidationCurrencyParameters>): Promise<boolean>;
+//# sourceMappingURL=validateAddress.d.ts.map

package/lib-es/api/validateAddress.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"validateAddress.d.ts","sourceRoot":"","sources":["../../src/api/validateAddress.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,mCAAmC,EAAE,MAAM,2CAA2C,CAAA;AAKpG,wBAAsB,eAAe,CACnC,OAAO,EAAE,MAAM,EACf,WAAW,EAAE,OAAO,CAAC,mCAAmC,CAAC,GACxD,OAAO,CAAC,OAAO,CAAC,CAElB"}

package/lib-es/api/validateAddress.js

@@ -0,0 +1,8 @@
+// SPDX-FileCopyrightText: © 2024 LEDGER SAS
+// SPDX-License-Identifier: Apache-2.0
+// Ethereum-format address; validate hex shape only (no EIP-55 checksum — no keccak dep).
+const ETH_ADDRESS_REGEX = /^0x[0-9a-fA-F]{40}$/;
+export async function validateAddress(address, _parameters) {
+    return ETH_ADDRESS_REGEX.test(address);
+}
+//# sourceMappingURL=validateAddress.js.map

package/lib-es/api/validateAddress.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"validateAddress.js","sourceRoot":"","sources":["../../src/api/validateAddress.ts"],"names":[],"mappings":"AAAA,4CAA4C;AAC5C,sCAAsC;AAItC,yFAAyF;AACzF,MAAM,iBAAiB,GAAG,qBAAqB,CAAA;AAE/C,MAAM,CAAC,KAAK,UAAU,eAAe,CACnC,OAAe,EACf,WAAyD;IAEzD,OAAO,iBAAiB,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;AACxC,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ledgerhq/coin-hypercore",
-  "version": "0.4.2",
+  "version": "0.4.3",
   "description": "Ledger Hypercore Coin integration",
   "keywords": [
     "Ledger",

package/src/api/index.integ.test.ts

@@ -23,7 +23,6 @@ describe('Hypercore Api (Alpaca stub)', () => {
     'broadcast',
     'validateIntent',
     'getNextSequence',
-    'validateAddress',
     'craftTransactionData',
   ])('%s throws "not supported"', (name) => {
     expect(api[name]).toThrow('not supported')

package/src/api/index.ts

@@ -6,6 +6,7 @@ import coinConfig, { type HypercoreConfig } from '../config'
 import { getBalance } from './getBalance'
 import { lastBlock } from './lastBlock'
 import { listOperations } from './listOperations'
+import { validateAddress } from './validateAddress'
 
 export function createApi(config: HypercoreConfig): CoinModuleApi {
   coinConfig.setCoinConfig(() => ({ ...config, status: { type: 'active' } }))
@@ -27,7 +28,7 @@ export function createApi(config: HypercoreConfig): CoinModuleApi {
     broadcast: notSupported('broadcast'),
     validateIntent: notSupported('validateIntent'),
     getNextSequence: notSupported('getNextSequence'),
-    validateAddress: notSupported('validateAddress'),
+    validateAddress,
     craftTransactionData: notSupported('craftTransactionData'),
   }
 }

package/src/api/validateAddress.test.ts

@@ -0,0 +1,23 @@
+// SPDX-FileCopyrightText: © 2024 LEDGER SAS
+// SPDX-License-Identifier: Apache-2.0
+
+import { validateAddress } from './validateAddress'
+
+describe('validateAddress', () => {
+  it.each([
+    '0x90D5b3f3FaA3cd61fBd78bF1CE3DdB2100F4BFb2', // checksummed
+    '0x90d5b3f3faa3cd61fbd78bf1ce3ddb2100f4bfb2', // lowercase
+  ])('accepts a well-formed Ethereum address (%s)', async (address) => {
+    expect(await validateAddress(address, {})).toBe(true)
+  })
+
+  it.each([
+    '', // empty
+    '90D5b3f3FaA3cd61fBd78bF1CE3DdB2100F4BFb2', // missing 0x prefix
+    '0x90D5b3f3FaA3cd61fBd78bF1CE3DdB2100F4BF', // too short
+    '0x90D5b3f3FaA3cd61fBd78bF1CE3DdB2100F4BFb2ab', // too long
+    '0xZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ', // non-hex
+  ])('rejects a malformed address (%s)', async (address) => {
+    expect(await validateAddress(address, {})).toBe(false)
+  })
+})

package/src/api/validateAddress.ts

@@ -0,0 +1,14 @@
+// SPDX-FileCopyrightText: © 2024 LEDGER SAS
+// SPDX-License-Identifier: Apache-2.0
+
+import type { AddressValidationCurrencyParameters } from '@ledgerhq/coin-module-framework/api/types'
+
+// Ethereum-format address; validate hex shape only (no EIP-55 checksum — no keccak dep).
+const ETH_ADDRESS_REGEX = /^0x[0-9a-fA-F]{40}$/
+
+export async function validateAddress(
+  address: string,
+  _parameters: Partial<AddressValidationCurrencyParameters>
+): Promise<boolean> {
+  return ETH_ADDRESS_REGEX.test(address)
+}