@ledgerhq/coin-hedera 1.15.0-nightly.20251205111238 → 1.15.0

package/src/logic/listOperations.test.ts

@@ -1,14 +1,11 @@
-import BigNumber from "bignumber.js";
-import { setupMockCryptoAssetsStore } from "@ledgerhq/cryptoassets/cal-client/test-helpers";
 import { encodeTokenAccountId } from "@ledgerhq/coin-framework/account/accountId";
 import { encodeOperationId } from "@ledgerhq/coin-framework/operation";
 import type { Pagination } from "@ledgerhq/coin-framework/api/types";
-import { getEnv } from "@ledgerhq/live-env";
 import { listOperations } from "./listOperations";
 import { apiClient } from "../network/api";
 import { getMockedCurrency } from "../test/fixtures/currency.fixture";
-import type { HederaMirrorTransaction } from "../types";
 import * as utils from "./utils";
+import { setupMockCryptoAssetsStore } from "@ledgerhq/cryptoassets/cal-client/test-helpers";
 
 setupMockCryptoAssetsStore();
 jest.mock("@ledgerhq/coin-framework/account/accountId");
@@ -76,7 +73,7 @@ describe("listOperations", () => {
       order: "desc",
     };
 
-    const mockTransactions: Partial<HederaMirrorTransaction>[] = [
+    const mockTransactions = [
       {
         consensus_timestamp: "1625097600.000000000",
         transaction_hash: "hash1",
@@ -84,10 +81,9 @@ describe("listOperations", () => {
         result: "SUCCESS",
         memo_base64: "test-memo",
         token_transfers: [],
-        staking_reward_transfers: [],
         transfers: [
-          { account: address, amount: -1000000 },
-          { account: "0.0.67890", amount: 1000000 },
+          { account: address, amount: "-1000000" },
+          { account: "0.0.67890", amount: "1000000" },
         ],
         name: "CRYPTOTRANSFER",
       },
@@ -109,8 +105,9 @@ describe("listOperations", () => {
       useSyntheticBlocks: false,
     });
 
-    expect(result.tokenOperations).toEqual([]);
     expect(result.coinOperations).toHaveLength(1);
+    expect(result.tokenOperations).toEqual([]);
+
     expect(result.coinOperations).toMatchObject([
       {
         type: "OUT",
@@ -147,17 +144,16 @@ describe("listOperations", () => {
       units: [{ name: "TT", code: "tt", magnitude: 6 }],
     };
 
-    const mockTransactions: Partial<HederaMirrorTransaction>[] = [
+    const mockTransactions = [
       {
         consensus_timestamp: "1625097600.000000000",
         transaction_hash: "hash1",
         charged_tx_fee: 500000,
         result: "SUCCESS",
         token_transfers: [
-          { token_id: tokenId, account: address, amount: -1000 },
-          { token_id: tokenId, account: "0.0.67890", amount: 1000 },
+          { token_id: tokenId, account: address, amount: "-1000" },
+          { token_id: tokenId, account: "0.0.67890", amount: "1000" },
         ],
-        staking_reward_transfers: [],
         transfers: [],
         name: "CRYPTOTRANSFER",
       },
@@ -184,12 +180,16 @@ describe("listOperations", () => {
       useSyntheticBlocks: false,
     });
 
+    expect(result.coinOperations).toHaveLength(1);
+    expect(result.tokenOperations).toHaveLength(1);
+
     expect(result.coinOperations).toMatchObject([
       {
         type: "FEES",
         fee: expect.any(Object),
       },
     ]);
+
     expect(result.tokenOperations).toMatchObject([
       {
         type: "OUT",
@@ -216,15 +216,14 @@ describe("listOperations", () => {
       order: "desc",
     };
 
-    const mockTransactions: Partial<HederaMirrorTransaction>[] = [
+    const mockTransactions = [
       {
         consensus_timestamp: "1625097600.000000000",
         transaction_hash: "hash1",
         charged_tx_fee: 500000,
         result: "SUCCESS",
         token_transfers: [],
-        staking_reward_transfers: [],
-        transfers: [{ account: address, amount: -500000 }],
+        transfers: [{ account: address, amount: "-500000" }],
         name: "TOKENASSOCIATE",
       },
     ];
@@ -245,7 +244,9 @@ describe("listOperations", () => {
       useSyntheticBlocks: false,
     });
 
-    expect(result.tokenOperations).toEqual([]);
+    expect(result.coinOperations).toHaveLength(1);
+    expect(result.tokenOperations).toHaveLength(0);
+
     expect(result.coinOperations).toMatchObject([
       {
         type: "ASSOCIATE_TOKEN",
@@ -272,17 +273,16 @@ describe("listOperations", () => {
       order: "desc",
     };
 
-    const mockTransactions: Partial<HederaMirrorTransaction>[] = [
+    const mockTransactions = [
       {
         consensus_timestamp: "1625097600.000000000",
         transaction_hash: "hash1",
         charged_tx_fee: 500000,
         result: "SUCCESS",
         token_transfers: [
-          { token_id: tokenId, account: address, amount: -1000 },
-          { token_id: tokenId, account: "0.0.67890", amount: 1000 },
+          { token_id: tokenId, account: address, amount: "-1000" },
+          { token_id: tokenId, account: "0.0.67890", amount: "1000" },
         ],
-        staking_reward_transfers: [],
         transfers: [],
         name: "CRYPTOTRANSFER",
       },
@@ -309,8 +309,8 @@ describe("listOperations", () => {
       useSyntheticBlocks: false,
     });
 
-    expect(result.coinOperations).toEqual([]);
-    expect(result.tokenOperations).toEqual([]);
+    expect(result.coinOperations).toHaveLength(0);
+    expect(result.tokenOperations).toHaveLength(0);
   });
 
   it("should use pagination parameters correctly", async () => {
@@ -358,18 +358,17 @@ describe("listOperations", () => {
       order: "desc",
     };
 
-    const mockTransactions: Partial<HederaMirrorTransaction>[] = [
+    const mockTransactions = [
       {
         consensus_timestamp: "1625097600.000000000",
         transaction_hash: "hash1",
         charged_tx_fee: 500000,
         result: "INVALID_SIGNATURE",
-        memo_base64: "",
+        memo_base64: null,
         token_transfers: [],
-        staking_reward_transfers: [],
         transfers: [
-          { account: address, amount: -1000000 },
-          { account: "0.0.67890", amount: 1000000 },
+          { account: address, amount: "-1000000" },
+          { account: "0.0.67890", amount: "1000000" },
         ],
         name: "CRYPTOTRANSFER",
       },
@@ -391,63 +390,7 @@ describe("listOperations", () => {
       useSyntheticBlocks: false,
     });
 
-    expect(result.coinOperations).toMatchObject([{ hasFailed: true }]);
-  });
-
-  it("should create REWARD operation when staking rewards are present", async () => {
-    const address = "0.0.1234567";
-    const mockCurrency = getMockedCurrency();
-    const pagination: Pagination = {
-      minHeight: 0,
-      limit: 10,
-      order: "desc",
-    };
-    const mockTransaction: Partial<HederaMirrorTransaction> = {
-      consensus_timestamp: "1625097600.000000000",
-      transaction_hash: "hash1",
-      charged_tx_fee: 500000,
-      result: "SUCCESS",
-      memo_base64: "",
-      token_transfers: [],
-      staking_reward_transfers: [{ account: address, amount: 1000000 }],
-      transfers: [{ account: address, amount: -500000 }],
-      name: "CRYPTOTRANSFER",
-    };
-
-    (apiClient.getAccountTransactions as jest.Mock).mockResolvedValue({
-      transactions: [mockTransaction],
-      nextCursor: null,
-    });
-
-    const result = await listOperations({
-      currency: mockCurrency,
-      address,
-      pagination,
-      mirrorTokens: [],
-      fetchAllPages: true,
-      skipFeesForTokenOperations: false,
-      useEncodedHash: false,
-      useSyntheticBlocks: false,
-    });
-
-    const rewardTimestamp = result.coinOperations[0].date.getTime();
-    const mainTimestamp = result.coinOperations[1].date.getTime();
-
-    expect(result.tokenOperations).toEqual([]);
-    expect(rewardTimestamp).toBe(mainTimestamp + 1);
-    expect(result.coinOperations).toMatchObject([
-      {
-        type: "REWARD",
-        hash: `${mockTransaction.transaction_hash}-staking-reward`,
-        value: new BigNumber(1000000),
-        fee: new BigNumber(0),
-        senders: [getEnv("HEDERA_STAKING_REWARD_ACCOUNT_ID")],
-        recipients: [address],
-      },
-      {
-        type: "OUT",
-        hash: mockTransaction.transaction_hash,
-      },
-    ]);
+    expect(result.coinOperations).toHaveLength(1);
+    expect(result.coinOperations[0].hasFailed).toBe(true);
   });
 });

package/src/logic/listOperations.ts

@@ -1,5 +1,4 @@
 import BigNumber from "bignumber.js";
-import { getEnv } from "@ledgerhq/live-env";
 import type { Operation, OperationType } from "@ledgerhq/types-live";
 import type { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
 import type { Pagination } from "@ledgerhq/coin-framework/api/types";
@@ -14,7 +13,6 @@ import { base64ToUrlSafeBase64, getMemoFromBase64, getSyntheticBlock } from "./u
 const txNameToCustomOperationType: Record<string, OperationType> = {
   TOKENASSOCIATE: "ASSOCIATE_TOKEN",
   CONTRACTCALL: "CONTRACT_CALL",
-  CRYPTOUPDATEACCOUNT: "UPDATE_ACCOUNT",
 };
 
 function getCommonOperationData(
@@ -135,27 +133,14 @@ function processTransfers({
   ledgerAccountId: string;
   commonData: ReturnType<typeof getCommonOperationData>;
   mirrorTokens: HederaMirrorToken[];
-}): Operation<HederaOperationExtra>[] {
-  const coinOperations: Operation<HederaOperationExtra>[] = [];
+}): Operation<HederaOperationExtra> | null {
   const transfers = rawTx.transfers ?? [];
-
-  if (transfers.length === 0) {
-    return [];
-  }
+  if (transfers.length === 0) return null;
 
   const { type, value, senders, recipients } = parseTransfers(transfers, address);
   const { hash, fee, timestamp, blockHeight, blockHash, hasFailed } = commonData;
   const extra = { ...commonData.extra };
   const operationType = txNameToCustomOperationType[rawTx.name] ?? type;
-  const stakingReward = rawTx.staking_reward_transfers.reduce((acc, transfer) => {
-    const transferAmount = new BigNumber(transfer.amount);
-
-    if (transfer.account === address) {
-      acc = acc.plus(transferAmount);
-    }
-
-    return acc;
-  }, new BigNumber(0));
 
   // try to enrich ASSOCIATE_TOKEN operation with extra.associatedTokenId
   // this value is used by custom OperationDetails components in Hedera family
@@ -170,30 +155,7 @@ function processTransfers({
     }
   }
 
-  // add REWARD operation representing staking reward transfers
-  if (stakingReward.gt(0)) {
-    const stakingRewardHash = `${hash}-staking-reward`;
-    const stakingRewardType: OperationType = "REWARD";
-    // offset timestamp by +1ms to ensure it appears just before the operation that triggered it
-    const stakingRewardTimestamp = new Date(timestamp.getTime() + 1);
-
-    coinOperations.push({
-      id: encodeOperationId(ledgerAccountId, stakingRewardHash, stakingRewardType),
-      accountId: ledgerAccountId,
-      type: stakingRewardType,
-      value: stakingReward,
-      recipients: [address],
-      senders: [getEnv("HEDERA_STAKING_REWARD_ACCOUNT_ID")],
-      hash: stakingRewardHash,
-      fee: new BigNumber(0),
-      date: stakingRewardTimestamp,
-      blockHeight,
-      blockHash,
-      extra,
-    });
-  }
-
-  coinOperations.push({
+  return {
     id: encodeOperationId(ledgerAccountId, hash, operationType),
     accountId: ledgerAccountId,
     type: operationType,
@@ -207,9 +169,7 @@ function processTransfers({
     blockHash,
     hasFailed,
     extra,
-  });
-
-  return coinOperations;
+  };
 }
 
 export async function listOperations({
@@ -271,7 +231,7 @@ export async function listOperations({
 
     // process regular transfers only if there were no token transfers
     if (!tokenResult) {
-      const newCoinOperations = processTransfers({
+      const coinOperation = processTransfers({
         rawTx,
         address,
         ledgerAccountId,
@@ -279,7 +239,7 @@ export async function listOperations({
         mirrorTokens,
       });
 
-      coinOperations.push(...newCoinOperations);
+      if (coinOperation) coinOperations.push(coinOperation);
     }
   }