@ledgerhq/coin-framework 0.9.0 → 0.10.0-next.0

package/src/account/helpers.ts

@@ -107,6 +107,10 @@ export const getAccountSpendableBalance = (account: AccountLike): BigNumber => {
 
 export const isAccountEmpty = (a: AccountLike): boolean => {
   // FIXME LIVE-5966 why do we need this? also this shouldn't be implemented here / this part must be removed back to the coin specifics
+  if (a.type == "Account" && a.currency.family == "vechain") {
+    const checkSubAccounts = a.subAccounts && !a.subAccounts[0].balance.isZero();
+    return a.operationsCount === 0 && a.balance.isZero() && !checkSubAccounts;
+  }
   if (a.type === "Account" && a.currency.family === "tron") {
     return (a as any).tronResources && (a as any).tronResources.bandwidth.freeLimit.eq(0);
   }

package/src/account/serialization.ts

@@ -1,3 +1,4 @@
+import { log } from "@ledgerhq/logs";
 import { BigNumber } from "bignumber.js";
 import type { Operation, OperationRaw, SubAccount } from "@ledgerhq/types-live";
 
@@ -30,6 +31,34 @@ export const toOperationRaw = (
   }: Operation,
   preserveSubOperation?: boolean,
 ): OperationRaw => {
+  // -- THIS CAN BE REMOVED ONCE THE DATE ERROR HAS BEEN FIGURED OUT
+  if (date instanceof Date && !isNaN(date as unknown as number)) {
+    log("Ethereum Date Error", "Date is invalid while serializing", {
+      date,
+      value,
+      fee,
+      subOperations,
+      internalOperations,
+      nftOperations,
+      id,
+      hash,
+      type,
+      senders,
+      recipients,
+      blockHeight,
+      blockHash,
+      transactionSequenceNumber,
+      accountId,
+      hasFailed,
+      contract,
+      operator,
+      standard,
+      tokenId,
+      transactionRaw,
+    });
+  }
+  // -- THIS CAN BE REMOVED ONCE THE DATE ERROR HAS BEEN FIGURED OUT
+
   const copy: OperationRaw = {
     id,
     hash,

package/src/bot/specs.ts

@@ -1,5 +1,3 @@
-// helpers for spec
-import { DeviceModelId } from "@ledgerhq/devices";
 import { log } from "@ledgerhq/logs";
 import { CryptoCurrency, TokenCurrency } from "@ledgerhq/types-cryptoassets";
 import { Account, TransactionCommon } from "@ledgerhq/types-live";
@@ -84,11 +82,7 @@ export function deviceActionFlow<T extends TransactionCommon>(
               expect({
                 [stepTitle]: stepValueTransform(stepValue),
               }).toMatchObject({
-                // FIXME: OCR of speculos couldn't retrieve S properly
-                // Issue on speculos repository : https://github.com/LedgerHQ/speculos/issues/204
-                [stepTitle]: expectedValue(arg, acc)
-                  .replace(/S/g, arg.appCandidate.model === DeviceModelId.nanoS ? "S" : "")
-                  .trim(),
+                [stepTitle]: expectedValue(arg, acc).trim(),
               });
             });
           }

package/src/currencies/__snapshots__/formatCurrencyUnit.test.ts.snap

@@ -62,11 +62,11 @@ exports[`formatCurrencyUnit with custom options with locale de-DE should correct
 
 exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format Cosmos unit (Atom) 1`] = `"12.345.678.900,000000- -ATOM"`;
 
-exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format Cronos unit (CRO) 1`] = `"0,012345678900000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format Cronos POS Chain Croeseid unit (TCRO) 1`] = `"123.456.789,00000000- -tcro"`;
 
-exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format Crypto.org Croeseid unit (TCRO) 1`] = `"123.456.789,00000000- -tcro"`;
+exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format Cronos POS Chain unit (CRO) 1`] = `"123.456.789,00000000- -CRO"`;
 
-exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format Crypto.org unit (CRO) 1`] = `"123.456.789,00000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format Cronos unit (CRO) 1`] = `"0,012345678900000000- -CRO"`;
 
 exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format DEXON unit (dexon) 1`] = `"12.345.678.900,000000- -DXN"`;
 
@@ -294,7 +294,7 @@ exports[`formatCurrencyUnit with custom options with locale de-DE should correct
 
 exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format Umee unit (Umee) 1`] = `"12.345.678.900,000000- -UMEE"`;
 
-exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format VeChain unit (VET) 1`] = `"123.456.789,00000000- -VET"`;
+exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format Vechain unit (VET) 1`] = `"0,012345678900000000- -VET"`;
 
 exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format Velas EVM unit (VLX) 1`] = `"0,012345678900000000- -VLX"`;
 
@@ -384,11 +384,11 @@ exports[`formatCurrencyUnit with custom options with locale en-US should correct
 
 exports[`formatCurrencyUnit with custom options with locale en-US should correctly format Cosmos unit (Atom) 1`] = `"12,345,678,900.000000- -ATOM"`;
 
-exports[`formatCurrencyUnit with custom options with locale en-US should correctly format Cronos unit (CRO) 1`] = `"0.012345678900000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale en-US should correctly format Cronos POS Chain Croeseid unit (TCRO) 1`] = `"123,456,789.00000000- -tcro"`;
 
-exports[`formatCurrencyUnit with custom options with locale en-US should correctly format Crypto.org Croeseid unit (TCRO) 1`] = `"123,456,789.00000000- -tcro"`;
+exports[`formatCurrencyUnit with custom options with locale en-US should correctly format Cronos POS Chain unit (CRO) 1`] = `"123,456,789.00000000- -CRO"`;
 
-exports[`formatCurrencyUnit with custom options with locale en-US should correctly format Crypto.org unit (CRO) 1`] = `"123,456,789.00000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale en-US should correctly format Cronos unit (CRO) 1`] = `"0.012345678900000000- -CRO"`;
 
 exports[`formatCurrencyUnit with custom options with locale en-US should correctly format DEXON unit (dexon) 1`] = `"12,345,678,900.000000- -DXN"`;
 
@@ -616,7 +616,7 @@ exports[`formatCurrencyUnit with custom options with locale en-US should correct
 
 exports[`formatCurrencyUnit with custom options with locale en-US should correctly format Umee unit (Umee) 1`] = `"12,345,678,900.000000- -UMEE"`;
 
-exports[`formatCurrencyUnit with custom options with locale en-US should correctly format VeChain unit (VET) 1`] = `"123,456,789.00000000- -VET"`;
+exports[`formatCurrencyUnit with custom options with locale en-US should correctly format Vechain unit (VET) 1`] = `"0.012345678900000000- -VET"`;
 
 exports[`formatCurrencyUnit with custom options with locale en-US should correctly format Velas EVM unit (VLX) 1`] = `"0.012345678900000000- -VLX"`;
 
@@ -706,11 +706,11 @@ exports[`formatCurrencyUnit with custom options with locale es-ES should correct
 
 exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format Cosmos unit (Atom) 1`] = `"12.345.678.900,000000- -ATOM"`;
 
-exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format Cronos unit (CRO) 1`] = `"0,012345678900000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format Cronos POS Chain Croeseid unit (TCRO) 1`] = `"123.456.789,00000000- -tcro"`;
 
-exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format Crypto.org Croeseid unit (TCRO) 1`] = `"123.456.789,00000000- -tcro"`;
+exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format Cronos POS Chain unit (CRO) 1`] = `"123.456.789,00000000- -CRO"`;
 
-exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format Crypto.org unit (CRO) 1`] = `"123.456.789,00000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format Cronos unit (CRO) 1`] = `"0,012345678900000000- -CRO"`;
 
 exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format DEXON unit (dexon) 1`] = `"12.345.678.900,000000- -DXN"`;
 
@@ -938,7 +938,7 @@ exports[`formatCurrencyUnit with custom options with locale es-ES should correct
 
 exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format Umee unit (Umee) 1`] = `"12.345.678.900,000000- -UMEE"`;
 
-exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format VeChain unit (VET) 1`] = `"123.456.789,00000000- -VET"`;
+exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format Vechain unit (VET) 1`] = `"0,012345678900000000- -VET"`;
 
 exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format Velas EVM unit (VLX) 1`] = `"0,012345678900000000- -VLX"`;
 
@@ -1028,11 +1028,11 @@ exports[`formatCurrencyUnit with custom options with locale fr-FR should correct
 
 exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format Cosmos unit (Atom) 1`] = `"12 345 678 900,000000- -ATOM"`;
 
-exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format Cronos unit (CRO) 1`] = `"0,012345678900000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format Cronos POS Chain Croeseid unit (TCRO) 1`] = `"123 456 789,00000000- -tcro"`;
 
-exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format Crypto.org Croeseid unit (TCRO) 1`] = `"123 456 789,00000000- -tcro"`;
+exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format Cronos POS Chain unit (CRO) 1`] = `"123 456 789,00000000- -CRO"`;
 
-exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format Crypto.org unit (CRO) 1`] = `"123 456 789,00000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format Cronos unit (CRO) 1`] = `"0,012345678900000000- -CRO"`;
 
 exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format DEXON unit (dexon) 1`] = `"12 345 678 900,000000- -DXN"`;
 
@@ -1260,7 +1260,7 @@ exports[`formatCurrencyUnit with custom options with locale fr-FR should correct
 
 exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format Umee unit (Umee) 1`] = `"12 345 678 900,000000- -UMEE"`;
 
-exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format VeChain unit (VET) 1`] = `"123 456 789,00000000- -VET"`;
+exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format Vechain unit (VET) 1`] = `"0,012345678900000000- -VET"`;
 
 exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format Velas EVM unit (VLX) 1`] = `"0,012345678900000000- -VLX"`;
 
@@ -1350,11 +1350,11 @@ exports[`formatCurrencyUnit with custom options with locale ja-JP should correct
 
 exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format Cosmos unit (Atom) 1`] = `"12,345,678,900.000000- -ATOM"`;
 
-exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format Cronos unit (CRO) 1`] = `"0.012345678900000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format Cronos POS Chain Croeseid unit (TCRO) 1`] = `"123,456,789.00000000- -tcro"`;
 
-exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format Crypto.org Croeseid unit (TCRO) 1`] = `"123,456,789.00000000- -tcro"`;
+exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format Cronos POS Chain unit (CRO) 1`] = `"123,456,789.00000000- -CRO"`;
 
-exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format Crypto.org unit (CRO) 1`] = `"123,456,789.00000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format Cronos unit (CRO) 1`] = `"0.012345678900000000- -CRO"`;
 
 exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format DEXON unit (dexon) 1`] = `"12,345,678,900.000000- -DXN"`;
 
@@ -1582,7 +1582,7 @@ exports[`formatCurrencyUnit with custom options with locale ja-JP should correct
 
 exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format Umee unit (Umee) 1`] = `"12,345,678,900.000000- -UMEE"`;
 
-exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format VeChain unit (VET) 1`] = `"123,456,789.00000000- -VET"`;
+exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format Vechain unit (VET) 1`] = `"0.012345678900000000- -VET"`;
 
 exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format Velas EVM unit (VLX) 1`] = `"0.012345678900000000- -VLX"`;
 
@@ -1672,11 +1672,11 @@ exports[`formatCurrencyUnit with custom options with locale ko-KR should correct
 
 exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format Cosmos unit (Atom) 1`] = `"12,345,678,900.000000- -ATOM"`;
 
-exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format Cronos unit (CRO) 1`] = `"0.012345678900000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format Cronos POS Chain Croeseid unit (TCRO) 1`] = `"123,456,789.00000000- -tcro"`;
 
-exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format Crypto.org Croeseid unit (TCRO) 1`] = `"123,456,789.00000000- -tcro"`;
+exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format Cronos POS Chain unit (CRO) 1`] = `"123,456,789.00000000- -CRO"`;
 
-exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format Crypto.org unit (CRO) 1`] = `"123,456,789.00000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format Cronos unit (CRO) 1`] = `"0.012345678900000000- -CRO"`;
 
 exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format DEXON unit (dexon) 1`] = `"12,345,678,900.000000- -DXN"`;
 
@@ -1904,7 +1904,7 @@ exports[`formatCurrencyUnit with custom options with locale ko-KR should correct
 
 exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format Umee unit (Umee) 1`] = `"12,345,678,900.000000- -UMEE"`;
 
-exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format VeChain unit (VET) 1`] = `"123,456,789.00000000- -VET"`;
+exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format Vechain unit (VET) 1`] = `"0.012345678900000000- -VET"`;
 
 exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format Velas EVM unit (VLX) 1`] = `"0.012345678900000000- -VLX"`;
 
@@ -1994,11 +1994,11 @@ exports[`formatCurrencyUnit with custom options with locale pt-BR should correct
 
 exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format Cosmos unit (Atom) 1`] = `"12.345.678.900,000000- -ATOM"`;
 
-exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format Cronos unit (CRO) 1`] = `"0,012345678900000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format Cronos POS Chain Croeseid unit (TCRO) 1`] = `"123.456.789,00000000- -tcro"`;
 
-exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format Crypto.org Croeseid unit (TCRO) 1`] = `"123.456.789,00000000- -tcro"`;
+exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format Cronos POS Chain unit (CRO) 1`] = `"123.456.789,00000000- -CRO"`;
 
-exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format Crypto.org unit (CRO) 1`] = `"123.456.789,00000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format Cronos unit (CRO) 1`] = `"0,012345678900000000- -CRO"`;
 
 exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format DEXON unit (dexon) 1`] = `"12.345.678.900,000000- -DXN"`;
 
@@ -2226,7 +2226,7 @@ exports[`formatCurrencyUnit with custom options with locale pt-BR should correct
 
 exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format Umee unit (Umee) 1`] = `"12.345.678.900,000000- -UMEE"`;
 
-exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format VeChain unit (VET) 1`] = `"123.456.789,00000000- -VET"`;
+exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format Vechain unit (VET) 1`] = `"0,012345678900000000- -VET"`;
 
 exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format Velas EVM unit (VLX) 1`] = `"0,012345678900000000- -VLX"`;
 
@@ -2316,11 +2316,11 @@ exports[`formatCurrencyUnit with custom options with locale ru-RU should correct
 
 exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format Cosmos unit (Atom) 1`] = `"12 345 678 900,000000- -ATOM"`;
 
-exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format Cronos unit (CRO) 1`] = `"0,012345678900000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format Cronos POS Chain Croeseid unit (TCRO) 1`] = `"123 456 789,00000000- -tcro"`;
 
-exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format Crypto.org Croeseid unit (TCRO) 1`] = `"123 456 789,00000000- -tcro"`;
+exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format Cronos POS Chain unit (CRO) 1`] = `"123 456 789,00000000- -CRO"`;
 
-exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format Crypto.org unit (CRO) 1`] = `"123 456 789,00000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format Cronos unit (CRO) 1`] = `"0,012345678900000000- -CRO"`;
 
 exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format DEXON unit (dexon) 1`] = `"12 345 678 900,000000- -DXN"`;
 
@@ -2548,7 +2548,7 @@ exports[`formatCurrencyUnit with custom options with locale ru-RU should correct
 
 exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format Umee unit (Umee) 1`] = `"12 345 678 900,000000- -UMEE"`;
 
-exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format VeChain unit (VET) 1`] = `"123 456 789,00000000- -VET"`;
+exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format Vechain unit (VET) 1`] = `"0,012345678900000000- -VET"`;
 
 exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format Velas EVM unit (VLX) 1`] = `"0,012345678900000000- -VLX"`;
 
@@ -2638,11 +2638,11 @@ exports[`formatCurrencyUnit with custom options with locale tr-TR should correct
 
 exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format Cosmos unit (Atom) 1`] = `"12.345.678.900,000000- -ATOM"`;
 
-exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format Cronos unit (CRO) 1`] = `"0,012345678900000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format Cronos POS Chain Croeseid unit (TCRO) 1`] = `"123.456.789,00000000- -tcro"`;
 
-exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format Crypto.org Croeseid unit (TCRO) 1`] = `"123.456.789,00000000- -tcro"`;
+exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format Cronos POS Chain unit (CRO) 1`] = `"123.456.789,00000000- -CRO"`;
 
-exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format Crypto.org unit (CRO) 1`] = `"123.456.789,00000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format Cronos unit (CRO) 1`] = `"0,012345678900000000- -CRO"`;
 
 exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format DEXON unit (dexon) 1`] = `"12.345.678.900,000000- -DXN"`;
 
@@ -2870,7 +2870,7 @@ exports[`formatCurrencyUnit with custom options with locale tr-TR should correct
 
 exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format Umee unit (Umee) 1`] = `"12.345.678.900,000000- -UMEE"`;
 
-exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format VeChain unit (VET) 1`] = `"123.456.789,00000000- -VET"`;
+exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format Vechain unit (VET) 1`] = `"0,012345678900000000- -VET"`;
 
 exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format Velas EVM unit (VLX) 1`] = `"0,012345678900000000- -VLX"`;
 
@@ -2960,11 +2960,11 @@ exports[`formatCurrencyUnit with custom options with locale zh-CN should correct
 
 exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format Cosmos unit (Atom) 1`] = `"12,345,678,900.000000- -ATOM"`;
 
-exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format Cronos unit (CRO) 1`] = `"0.012345678900000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format Cronos POS Chain Croeseid unit (TCRO) 1`] = `"123,456,789.00000000- -tcro"`;
 
-exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format Crypto.org Croeseid unit (TCRO) 1`] = `"123,456,789.00000000- -tcro"`;
+exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format Cronos POS Chain unit (CRO) 1`] = `"123,456,789.00000000- -CRO"`;
 
-exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format Crypto.org unit (CRO) 1`] = `"123,456,789.00000000- -CRO"`;
+exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format Cronos unit (CRO) 1`] = `"0.012345678900000000- -CRO"`;
 
 exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format DEXON unit (dexon) 1`] = `"12,345,678,900.000000- -DXN"`;
 
@@ -3192,7 +3192,7 @@ exports[`formatCurrencyUnit with custom options with locale zh-CN should correct
 
 exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format Umee unit (Umee) 1`] = `"12,345,678,900.000000- -UMEE"`;
 
-exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format VeChain unit (VET) 1`] = `"123,456,789.00000000- -VET"`;
+exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format Vechain unit (VET) 1`] = `"0.012345678900000000- -VET"`;
 
 exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format Velas EVM unit (VLX) 1`] = `"0.012345678900000000- -VLX"`;
 
@@ -3282,11 +3282,11 @@ exports[`formatCurrencyUnit with default options should correctly format Cosmos
 
 exports[`formatCurrencyUnit with default options should correctly format Cosmos unit (Atom) 1`] = `"12,345,678,900"`;
 
-exports[`formatCurrencyUnit with default options should correctly format Cronos unit (CRO) 1`] = `"0.0123456"`;
+exports[`formatCurrencyUnit with default options should correctly format Cronos POS Chain Croeseid unit (TCRO) 1`] = `"123,456,789"`;
 
-exports[`formatCurrencyUnit with default options should correctly format Crypto.org Croeseid unit (TCRO) 1`] = `"123,456,789"`;
+exports[`formatCurrencyUnit with default options should correctly format Cronos POS Chain unit (CRO) 1`] = `"123,456,789"`;
 
-exports[`formatCurrencyUnit with default options should correctly format Crypto.org unit (CRO) 1`] = `"123,456,789"`;
+exports[`formatCurrencyUnit with default options should correctly format Cronos unit (CRO) 1`] = `"0.0123456"`;
 
 exports[`formatCurrencyUnit with default options should correctly format DEXON unit (dexon) 1`] = `"12,345,678,900"`;
 
@@ -3514,7 +3514,7 @@ exports[`formatCurrencyUnit with default options should correctly format Ubiq un
 
 exports[`formatCurrencyUnit with default options should correctly format Umee unit (Umee) 1`] = `"12,345,678,900"`;
 
-exports[`formatCurrencyUnit with default options should correctly format VeChain unit (VET) 1`] = `"123,456,789"`;
+exports[`formatCurrencyUnit with default options should correctly format Vechain unit (VET) 1`] = `"0.0123456"`;
 
 exports[`formatCurrencyUnit with default options should correctly format Velas EVM unit (VLX) 1`] = `"0.0123456"`;
 

package/src/derivation.test.ts

@@ -1,32 +1,110 @@
+import { getEnv, setEnv } from "@ledgerhq/live-env";
 import { getCryptoCurrencyById } from "./currencies";
-import { getPreferredNewAccountScheme, getDefaultPreferredNewAccountScheme } from "./derivation";
-describe("derivation", () => {
-  test("getPreferredNewAccountScheme should return a list of schemes for a given currency", () => {
-    const testData = [
-      ["bitcoin", ["native_segwit", "taproot", "segwit", ""]],
-      ["ethereum", null],
-      ["cosmos", null],
-      ["litecoin", ["native_segwit", "segwit", ""]],
-      ["qtum", ["segwit", ""]],
-    ];
-    testData.forEach(([currencyId, derivationModes]) => {
-      const currency = getCryptoCurrencyById(<string>currencyId);
-      const p = getPreferredNewAccountScheme(currency);
-      expect(p).toEqual(derivationModes);
+import {
+  getPreferredNewAccountScheme,
+  getDefaultPreferredNewAccountScheme,
+  getDerivationModesForCurrency,
+  isInvalidDerivationMode,
+  DerivationMode,
+} from "./derivation";
+
+describe("derivation.ts", () => {
+  describe("getPreferredNewAccountScheme", () => {
+    it("should return a list of schemes for a given currency", () => {
+      const testData: [string, string[] | null][] = [
+        ["bitcoin", ["native_segwit", "taproot", "segwit", ""]],
+        ["ethereum", null],
+        ["cosmos", null],
+        ["litecoin", ["native_segwit", "segwit", ""]],
+        ["qtum", ["segwit", ""]],
+      ];
+      testData.forEach(([currencyId, derivationModes]) => {
+        if (!currencyId) return;
+        const currency = getCryptoCurrencyById(currencyId);
+        const p = getPreferredNewAccountScheme(currency);
+        expect(p).toEqual(derivationModes);
+      });
+    });
+  });
+
+  describe("getDefaultPreferredNewAccountScheme", () => {
+    it("should return a default scheme for a given currency", () => {
+      const testData = [
+        ["bitcoin", "native_segwit"],
+        ["ethereum", null],
+        ["cosmos", null],
+        ["litecoin", "native_segwit"],
+        ["qtum", "segwit"],
+      ];
+      testData.forEach(([currencyId, derivationMode]) => {
+        if (!currencyId) return;
+        const currency = getCryptoCurrencyById(currencyId);
+        const defaultP = getDefaultPreferredNewAccountScheme(currency);
+        expect(defaultP).toEqual(derivationMode);
+      });
     });
   });
-  test("getDefaultPreferredNewAccountScheme should return a default scheme for a given currency", () => {
-    const testData = [
-      ["bitcoin", "native_segwit"],
-      ["ethereum", null],
-      ["cosmos", null],
-      ["litecoin", "native_segwit"],
-      ["qtum", "segwit"],
+
+  describe("getDerivationModesForCurrency", () => {
+    const expectations: [string, DerivationMode[]][] = [
+      ["ethereum", ["ethM", "ethMM", ""]], // test for fixing missing legacy derivation
+      ["ethereum_classic", ["ethM", "ethMM", "etcM", ""]], // test for fixing missing legacy derivation
+      ["polygon", [""]], // test absence of impact on other EVMs
+      [
+        "bitcoin",
+        [
+          "legacy_on_bch",
+          "segwit_on_legacy",
+          "legacy_on_segwit",
+          "legacy_on_native_segwit",
+          "native_segwit",
+          "taproot",
+          "segwit",
+          "",
+        ],
+      ], // supportsSegwit + supportsNativeSegwit + taproot + segwit
+      ["bitcoin_cash", ["unsplit", ""]], // forkedFrom
+      [
+        "bitcoin_gold",
+        [
+          "unsplit",
+          "segwit_unsplit",
+          "segwit_on_legacy",
+          "legacy_on_segwit",
+          "legacy_on_native_segwit",
+          "segwit",
+          "",
+        ],
+      ], // forkedFrom + supportsSegwit
+      ["tezos", ["galleonL", "tezboxL", "tezosbip44h", "tezbox"]], // disableBIP44
+      ["solana", ["solanaMain", "solanaSub"]], // backward compatible change in getDerivationModesForCurrency
     ];
-    testData.forEach(([currencyId, derivationMode]) => {
-      const currency = getCryptoCurrencyById(<string>currencyId);
-      const defaultP = getDefaultPreferredNewAccountScheme(currency);
-      expect(defaultP).toEqual(derivationMode);
+
+    let envBackup: boolean;
+    beforeAll(() => {
+      envBackup = getEnv("SCAN_FOR_INVALID_PATHS");
+    });
+
+    afterEach(() => {
+      setEnv("SCAN_FOR_INVALID_PATHS", envBackup);
     });
+
+    it.each(expectations)(
+      "should return the expected derivation paths for %s with SCAN_FOR_INVALID_PATHS false",
+      (currency, paths) => {
+        setEnv("SCAN_FOR_INVALID_PATHS", false);
+        expect(getDerivationModesForCurrency(getCryptoCurrencyById(currency))).toEqual(
+          paths.filter(path => !isInvalidDerivationMode(path)),
+        );
+      },
+    );
+
+    it.each(expectations)(
+      "should return the expected derivation paths for %s with SCAN_FOR_INVALID_PATHS true",
+      (currency, paths) => {
+        setEnv("SCAN_FOR_INVALID_PATHS", true);
+        expect(getDerivationModesForCurrency(getCryptoCurrencyById(currency))).toEqual(paths);
+      },
+    );
   });
 });

package/src/derivation.ts

@@ -6,7 +6,7 @@ import { TransportStatusError, UserRefusedAddress } from "@ledgerhq/errors";
 import type { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
 import { getCryptoCurrencyById } from "./currencies";
 import { getEnv } from "@ledgerhq/live-env";
-import type { CryptoCurrencyIds } from "@ledgerhq/types-live";
+
 export type ModeSpec = {
   mandatoryEmptyAccountSkip?: number;
   isNonIterable?: boolean;
@@ -198,6 +198,9 @@ const modes = Object.freeze({
     overridesDerivation: "44'/397'/0'/0'/<account>'",
     mandatoryEmptyAccountSkip: 1,
   },
+  vechain: {
+    overridesDerivation: "44'/818'/0'/0/<account>",
+  },
   internet_computer: {
     overridesDerivation: "44'/223'/0'/0/<account>",
   },
@@ -209,14 +212,11 @@ const modes = Object.freeze({
 });
 modes as Record<DerivationMode, ModeSpec>; // eslint-disable-line
 
-// FIXME: CryptoCurrencyConfig was a flowtype we could not easily convert to ts so it has been deleted
-// previous types: Partial<CryptoCurrencyConfig<DerivationMode[]>>
-const legacyDerivations: Record<CryptoCurrencyIds, DerivationMode[]> = {
+const legacyDerivations: Partial<Record<CryptoCurrency["id"], DerivationMode[]>> = {
   aeternity: ["aeternity"],
   bitcoin_cash: [],
   bitcoin: ["legacy_on_bch"],
   vertcoin: ["vertcoin_128", "vertcoin_128_segwit"],
-  ethereum_classic: ["etcM"],
   tezos: ["galleonL", "tezboxL", "tezosbip44h", "tezbox"],
   stellar: ["sep5"],
   polkadot: ["polkadotbip44"],
@@ -227,11 +227,13 @@ const legacyDerivations: Record<CryptoCurrencyIds, DerivationMode[]> = {
   cardano: ["cardano"],
   cardano_testnet: ["cardano"],
   near: ["nearbip44h"],
+  vechain: ["vechain"],
   stacks: ["stacks_wallet"],
-};
-
-const legacyDerivationsPerFamily: Record<string, DerivationMode[]> = {
   ethereum: ["ethM", "ethMM"],
+  ethereum_classic: ["ethM", "ethMM", "etcM"],
+  solana: ["solanaMain", "solanaSub"],
+  solana_devnet: ["solanaMain", "solanaSub"],
+  solana_testnet: ["solanaMain", "solanaSub"],
 };
 
 export const asDerivationMode = (derivationMode: string): DerivationMode => {
@@ -364,6 +366,7 @@ const disableBIP44: Record<string, boolean> = {
   cardano: true,
   cardano_testnet: true,
   near: true,
+  vechain: true,
   internet_computer: true,
   casper: true,
 };
@@ -383,6 +386,7 @@ const seedIdentifierPath: Record<string, SeedPathFn> = {
   cardano_testnet: ({ purpose, coinType }) => `${purpose}'/${coinType}'/0'/0/0`,
   internet_computer: ({ purpose, coinType }) => `${purpose}'/${coinType}'/0'/0/0`,
   near: ({ purpose, coinType }) => `${purpose}'/${coinType}'/0'/0'/0'`,
+  vechain: ({ purpose, coinType }) => `${purpose}'/${coinType}'/0'/0/0`,
   _: ({ purpose, coinType }) => `${purpose}'/${coinType}'/0'`,
 };
 export const getSeedIdentifierDerivation = (
@@ -401,11 +405,8 @@ export const getSeedIdentifierDerivation = (
 // return an array of ways to derivate, by convention the latest is the standard one.
 export const getDerivationModesForCurrency = (currency: CryptoCurrency): DerivationMode[] => {
   let all: DerivationMode[] = [];
-  if (currency.family in legacyDerivationsPerFamily) {
-    all = all.concat(legacyDerivationsPerFamily[currency.family]);
-  }
   if (currency.id in legacyDerivations) {
-    all = all.concat(legacyDerivations[currency.id]);
+    all = all.concat(legacyDerivations[currency.id] || []);
   }
   if (currency.forkedFrom) {
     all.push("unsplit");
@@ -416,9 +417,7 @@ export const getDerivationModesForCurrency = (currency: CryptoCurrency): Derivat
   }
 
   if (currency.supportsSegwit) {
-    all.push("segwit_on_legacy");
-    all.push("legacy_on_segwit");
-    all.push("legacy_on_native_segwit");
+    all.push("segwit_on_legacy", "legacy_on_segwit", "legacy_on_native_segwit");
   }
 
   if (currency.supportsNativeSegwit) {
@@ -432,6 +431,7 @@ export const getDerivationModesForCurrency = (currency: CryptoCurrency): Derivat
     }
   }
 
+  // Can't this be concatenated with the first `supportsSegwit` condition ?
   if (currency.supportsSegwit) {
     all.push("segwit");
   }
@@ -440,10 +440,6 @@ export const getDerivationModesForCurrency = (currency: CryptoCurrency): Derivat
     all.push("");
   }
 
-  if (currency.family === "solana") {
-    all.push("solanaMain", "solanaSub");
-  }
-
   if (!getEnv("SCAN_FOR_INVALID_PATHS")) {
     return all.filter(a => !isInvalidDerivationMode(a));
   }