@ledgerhq/coin-canton 0.9.0-nightly.1 → 0.9.0-nightly.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ledgerhq/coin-canton",
-  "version": "0.9.0-nightly.1",
+  "version": "0.9.0-nightly.2",
   "description": "Canton coin integration",
   "keywords": [
     "Ledger",
@@ -100,15 +100,16 @@
   "dependencies": {
     "bignumber.js": "^9.1.2",
     "invariant": "^2.2.4",
+    "protobufjs": "7.5.4",
     "rxjs": "^7.8.1",
-    "@ledgerhq/coin-framework": "^6.8.0-nightly.1",
-    "@ledgerhq/cryptoassets": "^13.31.1-nightly.0",
+    "@ledgerhq/cryptoassets": "^13.32.0-nightly.1",
+    "@ledgerhq/coin-framework": "^6.8.0-nightly.2",
     "@ledgerhq/devices": "8.6.2-nightly.0",
     "@ledgerhq/errors": "^6.27.0-nightly.0",
     "@ledgerhq/live-env": "^2.19.0",
-    "@ledgerhq/live-network": "^2.0.20",
+    "@ledgerhq/live-network": "^2.1.0-nightly.0",
     "@ledgerhq/logs": "^6.13.0",
-    "@ledgerhq/types-live": "^6.88.0-nightly.0"
+    "@ledgerhq/types-live": "^6.88.0-nightly.1"
   },
   "devDependencies": {
     "@types/invariant": "^2.2.37",
@@ -116,13 +117,15 @@
     "dotenv": "^16.4.5",
     "expect": "^27.4.6",
     "jest": "^29.7.0",
+    "protobufjs-cli": "1.1.2",
     "ts-jest": "^29.1.1",
     "typescript": "^5.4.5",
-    "@ledgerhq/types-cryptoassets": "^7.29.0",
-    "@ledgerhq/disable-network-setup": "^0.0.0"
+    "@ledgerhq/disable-network-setup": "^0.1.0-nightly.0",
+    "@ledgerhq/types-cryptoassets": "^7.29.0"
   },
   "scripts": {
     "clean": "rimraf lib lib-es",
+    "generate-proto": "node scripts/generate.js",
     "build": "tsc && tsc -m esnext --moduleResolution bundler --outDir lib-es",
     "coverage": "jest --coverage",
     "prewatch": "pnpm build",

package/scripts/generate.js

@@ -0,0 +1,261 @@
+#!/usr/bin/env node
+/* eslint @typescript-eslint/no-var-requires: off */
+/* eslint no-console: off */
+import fs from "node:fs";
+import path from "node:path";
+import { execSync } from "node:child_process";
+import https from "node:https";
+import { fileURLToPath } from "node:url";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+
+const outputFile = path.join(__dirname, "../src/types/transaction-proto.json");
+const tempDir = path.join(__dirname, "temp-proto");
+
+const APP_CANTON_REPO = "LedgerHQ/app-canton";
+const APP_CANTON_BRANCH = "develop";
+const APP_CANTON_BASE_URL = `https://raw.githubusercontent.com/${APP_CANTON_REPO}/${APP_CANTON_BRANCH}`;
+
+const DAML_REPO = "digital-asset/daml";
+const DAML_BRANCH = "main";
+const DAML_BASE_URL = `https://raw.githubusercontent.com/${DAML_REPO}/${DAML_BRANCH}`;
+
+const RESERVED_WORDS = [
+  { pattern: /\bbool bool\b/g, replacement: "bool bool_" },
+  { pattern: /\bEnum enum\b/g, replacement: "Enum enum_" },
+  { pattern: /\bstring constructor = (\d+);/g, replacement: "string constructor_ = $1;" },
+];
+
+function handleFileFinish(file, resolve) {
+  file.close();
+  resolve();
+}
+
+function handleFileError(filePath, reject) {
+  return err => {
+    fs.unlink(filePath, () => {
+      /* empty function */
+    });
+    reject(err);
+  };
+}
+
+function handleHttpResponse(url, file, filePath, resolve, reject) {
+  return response => {
+    if (response.statusCode !== 200) {
+      reject(new Error(`Failed to download ${url}: ${response.statusCode}`));
+      return;
+    }
+
+    response.pipe(file);
+
+    file.on("finish", () => handleFileFinish(file, resolve));
+    file.on("error", handleFileError(filePath, reject));
+  };
+}
+
+function downloadFile(url, filePath) {
+  return new Promise((resolve, reject) => {
+    const file = fs.createWriteStream(filePath);
+
+    https.get(url, handleHttpResponse(url, file, filePath, resolve, reject)).on("error", err => {
+      reject(err instanceof Error ? err : new Error(err));
+    });
+  });
+}
+
+const PROTO_FILES = [
+  {
+    repoPath: "proto/device.proto",
+    localPath: "device.proto",
+    source: "app-canton",
+  },
+  {
+    repoPath: "proto/com/daml/ledger/api/v2/value.proto",
+    localPath: "com/daml/ledger/api/v2/value.proto",
+    source: "app-canton",
+  },
+  {
+    repoPath: "proto/com/daml/ledger/api/v2/value_cb.proto",
+    localPath: "com/daml/ledger/api/v2/value_cb.proto",
+    source: "app-canton",
+  },
+  {
+    repoPath:
+      "sdk/canton/community/ledger-api/src/main/protobuf/com/daml/ledger/api/v2/interactive/interactive_submission_common_data.proto",
+    localPath: "com/daml/ledger/api/v2/interactive/interactive_submission_common_data.proto",
+    source: "daml",
+  },
+  {
+    repoPath:
+      "sdk/canton/community/ledger-api/src/main/protobuf/com/daml/ledger/api/v2/interactive/transaction/v1/interactive_submission_data.proto",
+    localPath:
+      "com/daml/ledger/api/v2/interactive/transaction/v1/interactive_submission_data.proto",
+    source: "daml",
+  },
+  {
+    repoPath: "proto/interactive_submission_data_cb.proto",
+    localPath:
+      "com/daml/ledger/api/v2/interactive/transaction/v1/interactive_submission_data_cb.proto",
+    source: "app-canton",
+  },
+  {
+    repoPath: "proto/google/protobuf/any.proto",
+    localPath: "google/protobuf/any.proto",
+    source: "app-canton",
+  },
+  {
+    repoPath: "proto/google/protobuf/duration.proto",
+    localPath: "google/protobuf/duration.proto",
+    source: "app-canton",
+  },
+  {
+    repoPath: "proto/google/protobuf/empty.proto",
+    localPath: "google/protobuf/empty.proto",
+    source: "app-canton",
+  },
+  {
+    repoPath: "proto/google/protobuf/timestamp.proto",
+    localPath: "google/protobuf/timestamp.proto",
+    source: "app-canton",
+  },
+  {
+    repoPath: "proto/google/rpc/error_details.proto",
+    localPath: "google/rpc/error_details.proto",
+    source: "app-canton",
+  },
+  {
+    repoPath: "proto/google/rpc/status.proto",
+    localPath: "google/rpc/status.proto",
+    source: "app-canton",
+  },
+];
+
+function ensureDirectoryExists(dirPath) {
+  if (!fs.existsSync(dirPath)) {
+    fs.mkdirSync(dirPath, { recursive: true });
+  }
+}
+
+function getDownloadUrl(protoFile) {
+  const baseUrl = protoFile.source === "daml" ? DAML_BASE_URL : APP_CANTON_BASE_URL;
+  return `${baseUrl}/${protoFile.repoPath}`;
+}
+
+async function downloadProtoFile(protoFile) {
+  const url = getDownloadUrl(protoFile);
+  const localPath = path.join(tempDir, protoFile.localPath);
+
+  ensureDirectoryExists(path.dirname(localPath));
+
+  try {
+    await downloadFile(url, localPath);
+    console.log(`Downloaded: ${protoFile.localPath}`);
+  } catch (error) {
+    console.error(`Failed to download ${protoFile.localPath}:`, error.message);
+    throw error;
+  }
+}
+
+async function downloadProtoFiles() {
+  console.log("Downloading proto files from...");
+
+  if (!fs.existsSync(tempDir)) {
+    fs.mkdirSync(tempDir, { recursive: true });
+  }
+
+  for (const protoFile of PROTO_FILES) {
+    await downloadProtoFile(protoFile);
+  }
+
+  console.log("All proto files downloaded successfully!");
+}
+
+// Replace reserved words to make sure only C allowed names are used
+// see https://github.com/LedgerHQ/app-canton/blob/develop/proto/proto_gen.sh#L257
+function replaceReservedWords(filePath) {
+  if (!fs.existsSync(filePath)) return;
+
+  let content = fs.readFileSync(filePath, "utf8");
+
+  for (const { pattern, replacement } of RESERVED_WORDS) {
+    content = content.replace(pattern, replacement);
+  }
+
+  fs.writeFileSync(filePath, content);
+  console.log(`Updated field names in ${path.basename(filePath)}`);
+}
+
+// Clean up temp directory
+function cleanup() {
+  if (fs.existsSync(tempDir)) {
+    fs.rmSync(tempDir, { recursive: true, force: true });
+    console.log("Cleaned up temporary files");
+  }
+}
+
+function processProtoFiles() {
+  // Replace field names in proto files
+  replaceReservedWords(path.join(tempDir, "com/daml/ledger/api/v2/value.proto"));
+  replaceReservedWords(path.join(tempDir, "com/daml/ledger/api/v2/value_cb.proto"));
+}
+
+function generateProtobufBindings() {
+  // Sanitize paths to prevent command injection
+  const sanitizedTempDir = path.resolve(tempDir);
+  const sanitizedOutputFile = path.resolve(outputFile);
+  const deviceProtoPath = path.join(sanitizedTempDir, "device.proto");
+
+  // Validate that paths exist and are within expected directories
+  if (!fs.existsSync(deviceProtoPath)) {
+    throw new Error(`Device proto file not found: ${deviceProtoPath}`);
+  }
+
+  if (!sanitizedTempDir.startsWith(path.resolve(__dirname))) {
+    throw new Error("Invalid temp directory path");
+  }
+
+  if (!sanitizedOutputFile.startsWith(path.resolve(__dirname, ".."))) {
+    throw new Error("Invalid output file path");
+  }
+
+  // Use npx from the same Node.js installation directory to avoid PATH manipulation
+  const npxPath = path.join(process.execPath, "..", "npx");
+  const absoluteNpxPath = path.resolve(npxPath);
+
+  execSync(
+    absoluteNpxPath,
+    [
+      "pbjs",
+      "-t",
+      "json",
+      "-w",
+      "es6",
+      "--path",
+      sanitizedTempDir,
+      "-o",
+      sanitizedOutputFile,
+      deviceProtoPath,
+    ],
+    {
+      stdio: "inherit",
+      cwd: __dirname,
+    },
+  );
+}
+
+try {
+  console.log("Generating protobuf bindings...");
+
+  await downloadProtoFiles();
+  processProtoFiles();
+  generateProtobufBindings();
+
+  console.log("Protobuf bindings generated successfully!");
+} catch (error) {
+  console.error("Error generating protobuf bindings:", error.message);
+  process.exit(1);
+} finally {
+  cleanup();
+}

package/src/bridge/deviceTransactionConfig.test.ts

@@ -2,21 +2,25 @@ import getDeviceTransactionConfig from "./deviceTransactionConfig";
 import BigNumber from "bignumber.js";
 
 describe("getDeviceTransactionConfig", () => {
-  it("should return amount field when it's more than 0", () => {
+  it("should return amount field when it's more than 0", async () => {
     expect(
-      getDeviceTransactionConfig({
-        transaction: {},
-        status: { amount: new BigNumber(1), estimatedFees: new BigNumber(0) },
-      } as any)[0],
+      (
+        await getDeviceTransactionConfig({
+          transaction: {},
+          status: { amount: new BigNumber(1), estimatedFees: new BigNumber(0) },
+        } as any)
+      )[0],
     ).toEqual({ type: "amount", label: "Amount" });
   });
 
-  it("should return fee field when it's more than 0", () => {
+  it("should return fee field when it's more than 0", async () => {
     expect(
-      getDeviceTransactionConfig({
-        transaction: {},
-        status: { amount: new BigNumber(0), estimatedFees: new BigNumber(1) },
-      } as any)[0],
+      (
+        await getDeviceTransactionConfig({
+          transaction: {},
+          status: { amount: new BigNumber(0), estimatedFees: new BigNumber(1) },
+        } as any)
+      )[0],
     ).toEqual({ type: "fees", label: "Fees" });
   });
 });

package/src/bridge/deviceTransactionConfig.ts

@@ -3,7 +3,7 @@ import type { Transaction, TransactionStatus } from "../types";
 import type { CommonDeviceTransactionField } from "@ledgerhq/coin-framework/transaction/common";
 
 // This method adds additional fields that need to be reviewed when signing a transaction on the device.
-function getDeviceTransactionConfig({
+async function getDeviceTransactionConfig({
   transaction: {},
   status: { amount, estimatedFees },
 }: {
@@ -11,7 +11,7 @@ function getDeviceTransactionConfig({
   parentAccount: Account | null | undefined;
   transaction: Transaction;
   status: TransactionStatus;
-}): Array<CommonDeviceTransactionField> {
+}): Promise<Array<CommonDeviceTransactionField>> {
   const fields: Array<CommonDeviceTransactionField> = [];
 
   if (!amount.isZero()) {

package/src/bridge/getTransactionStatus.test.ts

@@ -56,7 +56,7 @@ describe("getTransactionStatus", () => {
     currency: mockCurrency,
     balance: new BigNumber(1000), // 1000 units
     spendableBalance: new BigNumber(1000),
-    freshAddress: "test::123",
+    freshAddress: "test::33333333333333333333333333333333333333333333333333333333333333333333",
     freshAddressPath: "44'/60'/0'/0/0",
     index: 0,
     derivationMode: "canton",
@@ -93,7 +93,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(100),
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: null,
         tokenId: "",
       };
@@ -108,7 +108,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(100),
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(0),
         tokenId: "",
       };
@@ -123,7 +123,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(100), // Use larger amount to avoid balance issues
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(1500), // 15x the amount
         tokenId: "",
       };
@@ -138,7 +138,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(100),
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(10), // 0.1x the amount
         tokenId: "",
       };
@@ -155,7 +155,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(950), // 950 + 10 fee = 960, but balance is 1000 and reserve is 100
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(10),
         tokenId: "",
       };
@@ -169,7 +169,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(50), // Below reserve amount of 100
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(10),
         tokenId: "",
       };
@@ -183,7 +183,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(800), // 800 + 10 fee = 810, balance is 1000, reserve is 100, so 900 available
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(10),
         tokenId: "",
       };
@@ -213,7 +213,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(100),
-        recipient: "test::123", // Same as account.freshAddress
+        recipient: "test::33333333333333333333333333333333333333333333333333333333333333333333", // Same as account.freshAddress
         fee: new BigNumber(10),
         tokenId: "",
       };
@@ -241,7 +241,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(100),
-        recipient: "valid::456",
+        recipient: "valid::22222222222222222222222222222222222222222222222222222222222222222222",
         fee: new BigNumber(10),
         tokenId: "",
       };
@@ -272,7 +272,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(0),
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(10),
         tokenId: "",
       };
@@ -286,7 +286,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(100),
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(10),
         tokenId: "",
       };
@@ -302,7 +302,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(100),
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(10),
         tokenId: "",
       };
@@ -318,7 +318,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(100),
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(10),
         tokenId: "",
       };
@@ -340,7 +340,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(50),
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(10),
         tokenId: "",
       };
@@ -359,7 +359,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(50),
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(10),
         tokenId: "",
       };
@@ -380,7 +380,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(50),
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(10),
         tokenId: "",
       };
@@ -400,7 +400,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(50),
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(10),
         tokenId: "",
       };
@@ -432,7 +432,7 @@ describe("getTransactionStatus", () => {
       const transaction: Transaction = {
         family: "canton",
         amount: new BigNumber(5), // Small amount
-        recipient: "valid::123",
+        recipient: "valid::11111111111111111111111111111111111111111111111111111111111111111111",
         fee: new BigNumber(100), // High fee relative to amount
         tokenId: "",
       };

package/src/bridge/onboard.integ.test.ts

@@ -221,25 +221,5 @@ describe("onboard (devnet)", () => {
       expect(finalResult.isApproved).toBe(true);
       expect(typeof finalResult.isApproved).toBe("boolean");
     }, 30000);
-
-    it("should handle invalid party ID gracefully", async () => {
-      // GIVEN
-      const keyPair = generateMockKeyPair();
-      const mockSigner = createMockSigner(keyPair);
-      const mockSignerContext = jest.fn().mockImplementation((deviceId, callback) => {
-        return callback(mockSigner);
-      });
-      const preapprovalObservable = buildAuthorizePreapproval(mockSignerContext);
-
-      // WHEN & THEN
-      try {
-        await firstValueFrom(
-          preapprovalObservable(mockCurrency, mockDeviceId, mockAccount, "invalid-party-id-123"),
-        );
-        expect(true).toBe(true);
-      } catch (error) {
-        expect(error).toBeDefined();
-      }
-    }, 30000);
   });
 });