@ledgerhq/coin-canton 0.5.0-nightly.4 → 0.5.0

package/src/bridge/sync.ts

@@ -1,14 +1,14 @@
 import BigNumber from "bignumber.js";
 import { Operation } from "@ledgerhq/types-live";
-import { decodeAccountId, encodeAccountId } from "@ledgerhq/coin-framework/account/index";
+import { encodeAccountId } from "@ledgerhq/coin-framework/account/index";
 import { GetAccountShape, mergeOps } from "@ledgerhq/coin-framework/bridge/jsHelpers";
-import { encodeOperationId } from "@ledgerhq/coin-framework/operation";
 import { getBalance, getLedgerEnd, getOperations, type OperationInfo } from "../network/gateway";
-import { CantonAccount } from "../types";
+
+import { encodeOperationId } from "@ledgerhq/coin-framework/operation";
 import coinConfig from "../config";
 
 const txInfoToOperationAdapter =
-  (accountId: string, partyId: string) =>
+  (accountId: string, address: string) =>
   (txInfo: OperationInfo): Operation => {
     const {
       transaction_hash,
@@ -20,7 +20,8 @@ const txInfoToOperationAdapter =
       fee: { value: fee },
       transfers: [{ value: transferValue }],
     } = txInfo;
-    const type = senders.includes(partyId) ? "OUT" : "IN";
+
+    const type = senders.includes(address) ? "OUT" : "IN";
     const value = new BigNumber(transferValue);
     const feeValue = new BigNumber(fee);
 
@@ -48,31 +49,24 @@ const txInfoToOperationAdapter =
 const filterOperations = (
   transactions: OperationInfo[],
   accountId: string,
-  partyId: string,
+  address: string,
 ): Operation[] => {
   return transactions
     .filter(tx => tx.type === "Receive" || tx.type === "Send")
-    .map(txInfoToOperationAdapter(accountId, partyId));
+    .map(txInfoToOperationAdapter(accountId, address));
 };
 
-export const getAccountShape: GetAccountShape<CantonAccount> = async info => {
-  const { address, initialAccount, currency, derivationMode, derivationPath, rest } = info;
-
-  const xpubOrAddress = (
-    (initialAccount && initialAccount.id && decodeAccountId(initialAccount.id).xpubOrAddress) ||
-    ""
-  ).replace(/:/g, "_");
-  const partyId =
-    rest?.cantonResources?.partyId ||
-    initialAccount?.cantonResources?.partyId ||
-    xpubOrAddress.replace(/_/g, ":");
+export const getAccountShape: GetAccountShape = async info => {
+  const { address, initialAccount, currency, derivationMode } = info;
+  // TODO: we need better solution ?
+  const xpubOrAddress = address?.replace(/:/g, "_") || "";
 
   const accountId = encodeAccountId({
     type: "js",
     version: "2",
     currencyId: currency.id,
     xpubOrAddress,
-    derivationMode,
+    derivationMode: "",
   });
 
   // blockheight retrieval
@@ -80,32 +74,20 @@ export const getAccountShape: GetAccountShape<CantonAccount> = async info => {
 
   // Account info retrieval + spendable balance calculation
   // const accountInfo = await getAccountInfo(address);
-  const balances = await getBalance(partyId);
-
-  // TODO change to balance.instrument_id === "Amulet" after update on backend
-  const balanceData = balances.find(balance => balance.instrument_id.includes("Amulet")) || {
-    instrument_id: "Amulet",
-    amount: 0,
-    locked: false,
-  };
-
-  const balance = new BigNumber(balanceData.amount);
+  const balanceData = await getBalance(address);
+  const balance = new BigNumber(balanceData[0]?.amount || "0");
   const reserveMin = coinConfig.getCoinConfig().minReserve || 0;
-  const lockedAmount = balanceData.locked ? balance : new BigNumber(0);
-  const spendableBalance = BigNumber.max(
-    0,
-    balance.minus(lockedAmount).minus(BigNumber(reserveMin)),
-  );
+  const spendableBalance = balance.minus(BigNumber(reserveMin));
 
   // Tx history fetching
   const oldOperations = initialAccount?.operations || [];
   const startAt = oldOperations.length ? (oldOperations[0].blockHeight || 0) + 1 : 0;
-  const transactionData = await getOperations(partyId, {
-    cursor: startAt,
+  const transactionData = await getOperations(address, {
+    cursor: 0,
     limit: 100,
   });
 
-  const newOperations = filterOperations(transactionData.operations, accountId, partyId);
+  const newOperations = filterOperations(transactionData.operations, accountId, address);
   const operations = mergeOps(oldOperations, newOperations);
 
   // We return the new account shape
@@ -117,11 +99,6 @@ export const getAccountShape: GetAccountShape<CantonAccount> = async info => {
     spendableBalance,
     operations,
     operationsCount: operations.length,
-    freshAddress: address,
-    freshAddressPath: derivationPath,
-    cantonResources: {
-      partyId,
-    },
   };
 
   return shape;

package/src/bridge/updateTransaction.ts

@@ -8,5 +8,10 @@ import type { Transaction } from "../types";
 // NOTE: here is an example transaction updater function
 // in this case, it resets fee to null depending on the patch content
 export const updateTransaction: AccountBridge<Transaction>["updateTransaction"] = (tx, patch) => {
+  // eslint-disable-next-line no-constant-condition
+  if (patch.recipient === "boilerplate1" || true) {
+    patch = { ...patch, fee: null };
+  }
+
   return defaultUpdateTransaction(tx, patch);
 };

package/src/common-logic/transaction/broadcast.test.ts

@@ -8,7 +8,7 @@ jest.mock("../../network/gateway", () => ({
 
 const mockSerialized = JSON.stringify({
   serialized: "serialized-tx",
-  signature: "signature__PARTY__alice:123",
+  signature: "signature",
 });
 
 describe("broadcast", () => {
@@ -23,11 +23,11 @@ describe("broadcast", () => {
       useGateway: true,
     } as any);
 
-    (submit as jest.Mock).mockResolvedValue({ update_id: "my-update-id" });
+    (submit as jest.Mock).mockResolvedValue({ updateId: "my-update-id" });
 
     const result = await broadcast(mockSerialized);
 
-    expect(submit).toHaveBeenCalledWith("alice:123", "serialized-tx", "signature");
+    expect(submit).toHaveBeenCalledWith("serialized-tx", "signature");
     expect(result).toEqual("my-update-id");
   });
 

package/src/common-logic/transaction/broadcast.ts

@@ -5,7 +5,6 @@ const useGateway = () => coinConfig.getCoinConfig().useGateway === true;
 
 export async function broadcast(signedTx: string): Promise<string> {
   const parsed: { serialized: string; signature: string } = JSON.parse(signedTx);
-  const [sig, party] = parsed.signature.split("__PARTY__");
-  if (useGateway()) return (await submit(party, parsed.serialized, sig)).update_id;
+  if (useGateway()) return (await submit(parsed.serialized, parsed.signature)).updateId;
   else throw new Error("Not implemented");
 }

package/src/common-logic/transaction/combine.test.ts

@@ -3,15 +3,25 @@ import { combine } from "./combine";
 describe("combine", () => {
   it("responds with a Stringify version of the payload to broadcast", () => {
     // GIVEN
-    const transaction = "0x000000001";
+    const transaction = {
+      transaction: {
+        serialized: "SERIALIZED",
+        json: "JSON",
+        hash: "HASH",
+      },
+    };
     const signature = "SIGNATURE";
 
     // WHEN
-    const result = combine(transaction, signature);
+    const result = combine(JSON.stringify(transaction), signature);
 
     // THEN
     expect(JSON.parse(result)).toEqual({
-      serialized: "0x000000001",
+      transaction: {
+        serialized: "SERIALIZED",
+        json: "JSON",
+        hash: "HASH",
+      },
       signature: "SIGNATURE",
     });
   });

package/src/common-logic/transaction/combine.ts

@@ -1,7 +1,9 @@
 // Combines signature with raw transaction
-export function combine(serialized: string, signature: string): string {
+export function combine(transaction: string, signature: string): string {
+  const tx = JSON.parse(transaction);
+
   return JSON.stringify({
-    serialized,
+    ...tx,
     signature,
   });
 }

package/src/common-logic/transaction/craftTransaction.ts

@@ -1,5 +1,7 @@
 import BigNumber from "bignumber.js";
-import { prepareTransferRequest, PrepareTransferResponse } from "../../network/gateway";
+import { BoilerplateNativeTransaction } from "../../types";
+
+const encodeNativeTx = (nativeTx: BoilerplateNativeTransaction) => JSON.stringify(nativeTx);
 
 export async function craftTransaction(
   account: {
@@ -10,25 +12,25 @@ export async function craftTransaction(
   transaction: {
     recipient?: string;
     amount: BigNumber;
-    tokenId: string;
-    expireInSeconds: number;
+    fee?: BigNumber;
   },
 ): Promise<{
-  nativeTransaction: PrepareTransferResponse;
+  nativeTransaction: BoilerplateNativeTransaction;
   serializedTransaction: string;
-  hash: string;
 }> {
-  const { serialized, json, hash } = await prepareTransferRequest(account.address, {
-    recipient: transaction.recipient || "",
-    amount: transaction.amount.toNumber(),
-    type: "token-transfer-request",
-    execute_before_secs: transaction.expireInSeconds,
-    instrument_id: transaction.tokenId,
-  });
+  const nativeTransaction: BoilerplateNativeTransaction = {
+    TransactionType: "Payment",
+    Account: account.address,
+    Amount: transaction.amount.toString(),
+    Destination: transaction.recipient || "",
+    Fee: transaction.fee?.toString() || "0",
+    Sequence: account.nextSequenceNumber || 0,
+  };
+
+  const serializedTransaction = encodeNativeTx(nativeTransaction);
 
   return {
-    nativeTransaction: json,
-    serializedTransaction: serialized,
-    hash,
+    nativeTransaction,
+    serializedTransaction,
   };
 }

package/src/common-logic/transaction/estimateFees.ts

@@ -1,8 +1,4 @@
-import coinConfig from "../../config";
-
-const feeValue = () => coinConfig.getCoinConfig().fee ?? 10_000;
-
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 export async function estimateFees(serializedTransaction: string): Promise<bigint> {
-  return Promise.resolve(BigInt(feeValue())); // TODO replace with real implementation
+  return Promise.resolve(BigInt(10_000)); // TODO replace with real implementation
 }

package/src/config.ts

@@ -10,7 +10,6 @@ export type CantonConfig = {
   networkType: "mainnet" | "devnet" | "localnet";
   useGateway?: boolean;
   nativeInstrumentId?: string;
-  fee?: number;
 };
 
 export type CantonCoinConfig = CurrencyConfig & CantonConfig;

package/src/network/gateway.integ.test.ts

@@ -58,8 +58,7 @@ describe("gateway (devnet)", () => {
       expect(response).toHaveProperty("public_key_fingerprint");
       expect(response).toHaveProperty("transactions");
       expect(response.transactions).toHaveProperty("combined_hash");
-      expect(response.party_name).toBeDefined();
-      expect(typeof response.party_name).toBe("string");
+      expect(response.party_name).toBe(keyPair.publicKeyHex);
 
       expect(response.public_key_fingerprint).toBe(keyPair.fingerprint);
     }, 30000);

package/src/network/gateway.ts

@@ -1,6 +1,4 @@
 import network from "@ledgerhq/live-network";
-import type { LiveNetworkRequest } from "@ledgerhq/live-network/network";
-import { getEnv } from "@ledgerhq/live-env";
 import coinConfig from "../config";
 import {
   PrepareTransactionRequest,
@@ -39,21 +37,6 @@ type OnboardingPrepareRequest = {
   public_key_type: string;
 };
 
-export type PrepareTransferResponse = {
-  hash: string;
-  json: any; // The actual structure is complex, using any for now
-  serialized: string;
-};
-
-export type PrepareTransferRequest = {
-  type: "token-transfer-request";
-  amount: number;
-  recipient: string;
-  execute_before_secs: number;
-  instrument_id: string;
-  reason?: string;
-};
-
 type OnboardingSubmitRequest = {
   prepare_request: OnboardingPrepareRequest;
   prepare_response: OnboardingPrepareResponse;
@@ -72,7 +55,7 @@ type TransactionSubmitRequest = {
   signature: string;
 };
 
-type TransactionSubmitResponse = { update_id: string };
+type TransactionSubmitResponse = { updateId: string };
 
 export type InstrumentBalance = {
   instrument_id: string;
@@ -264,18 +247,6 @@ export type OperationInfo =
 
 const getGatewayUrl = () => coinConfig.getCoinConfig().gatewayUrl;
 const getNodeId = () => coinConfig.getCoinConfig().nodeId || "ledger-devnet-stg";
-const getNetworkType = () => coinConfig.getCoinConfig().networkType;
-
-const gatewayNetwork = <T, U = unknown>(req: LiveNetworkRequest<U>) => {
-  const API_KEY = getEnv("CANTON_API_KEY");
-  return network<T, U>({
-    ...req,
-    headers: {
-      ...(req.headers || {}),
-      ...(API_KEY && { "X-Ledger-Canton-Api-Key": API_KEY }),
-    },
-  });
-};
 
 export async function prepareOnboarding(
   pubKey: string,
@@ -285,13 +256,13 @@ export async function prepareOnboarding(
   const nodeId = getNodeId();
   const fullUrl = `${gatewayUrl}/v1/node/${nodeId}/onboarding/prepare`;
 
-  const { data } = await gatewayNetwork<OnboardingPrepareResponse, OnboardingPrepareRequest>({
+  const { data } = await network<OnboardingPrepareResponse>({
     method: "POST",
     url: fullUrl,
     data: {
       public_key: pubKey,
       public_key_type: pubKeyType,
-    },
+    } satisfies OnboardingPrepareRequest,
   });
 
   return data;
@@ -302,34 +273,35 @@ export async function submitOnboarding(
   prepareResponse: OnboardingPrepareResponse,
   signature: string,
 ) {
-  const { data } = await gatewayNetwork<OnboardingSubmitResponse, OnboardingSubmitRequest>({
+  const { data } = await network<OnboardingSubmitResponse>({
     method: "POST",
     url: `${getGatewayUrl()}/v1/node/${getNodeId()}/onboarding/submit`,
     data: {
       prepare_request: prepareRequest,
       prepare_response: prepareResponse,
       signature,
-    },
+    } satisfies OnboardingSubmitRequest,
   });
   return data;
 }
 
-export async function submit(partyId: string, serialized: string, signature: string) {
-  const { data } = await gatewayNetwork<TransactionSubmitResponse, TransactionSubmitRequest>({
+export async function submit(serializedTx: string, signature: string) {
+  const { data } = await network<TransactionSubmitResponse>({
     method: "POST",
-    url: `${getGatewayUrl()}/v1/node/${getNodeId()}/party/${partyId}/transaction/submit`,
+    url: `${getGatewayUrl()}/v1/node/${getNodeId()}/transaction/submit`,
     data: {
-      serialized,
+      serialized: serializedTx,
       signature,
-    },
+    } satisfies TransactionSubmitRequest,
   });
   return data;
 }
 
 export async function getBalance(partyId: string): Promise<InstrumentBalance[]> {
-  const { data } = await gatewayNetwork<InstrumentBalance[]>({
+  const { data } = await network<InstrumentBalance[]>({
     method: "GET",
-    url: `${getGatewayUrl()}/v1/node/${getNodeId()}/party/${partyId}/balance`,
+    // TODO: we need better solution ?
+    url: `${getGatewayUrl()}/v1/node/${getNodeId()}/party/${partyId.replace(/_/g, ":")}/balance`,
   });
   return data;
 }
@@ -343,7 +315,7 @@ export async function getPartyByPubKey(pubKey: string): Promise<PartyInfo> {
 }
 
 async function getParty(identifier: string, by: "party-id" | "public-key"): Promise<PartyInfo> {
-  const { data } = await gatewayNetwork<PartyInfo>({
+  const { data } = await network<PartyInfo>({
     method: "GET",
     url: `${getGatewayUrl()}/v1/node/${getNodeId()}/party/${identifier}?by=${by}`,
   });
@@ -362,26 +334,26 @@ export async function getOperations(
   next: number;
   operations: OperationInfo[];
 }> {
-  const { data } = await gatewayNetwork<{
+  const { data } = await network<{
     next: number;
     operations: OperationInfo[];
   }>({
     method: "GET",
-    url: `${getGatewayUrl()}/v1/node/${getNodeId()}/party/${partyId}/operations`,
-    params: options,
+    url: `${getGatewayUrl()}/v1/node/${getNodeId()}/party/${partyId.replace(/_/g, ":")}/operations`,
+    data: options,
   });
   return data;
 }
 
-type PrepareTapRequest = {
+type PrepareTapRequestRequest = {
   partyId: string;
   amount?: number;
 };
 
-type PrepareTapResponse = {
-  serialized: string;
+type PrepareTapRequestResponse = {
+  serialized: "string";
   json: null;
-  hash: string;
+  hash: "string";
 };
 
 enum TransactionType {
@@ -392,15 +364,8 @@ enum TransactionType {
 export async function prepareTapRequest({
   partyId,
   amount = 1000000,
-}: PrepareTapRequest): Promise<PrepareTapResponse> {
-  if (getNetworkType() === "mainnet") {
-    return {
-      serialized: "",
-      json: null,
-      hash: "",
-    };
-  }
-  const { data } = await gatewayNetwork<PrepareTapResponse, { amount: number; type: string }>({
+}: PrepareTapRequestRequest): Promise<PrepareTapRequestResponse> {
+  const { data } = await network<PrepareTapRequestResponse>({
     method: "POST",
     url: `${getGatewayUrl()}/v1/node/${getNodeId()}/party/${partyId}/transaction/prepare`,
     data: {
@@ -427,34 +392,19 @@ export async function submitTapRequest({
   serialized,
   signature,
 }: SubmitTapRequestRequest): Promise<SubmitTapRequestResponse> {
-  const { data } = await gatewayNetwork<
-    SubmitTapRequestResponse,
-    Omit<SubmitTapRequestRequest, "partyId">
-  >({
+  const { data } = await network<SubmitTapRequestResponse>({
     method: "POST",
     url: `${getGatewayUrl()}/v1/node/${getNodeId()}/party/${partyId}/transaction/submit`,
     data: {
       serialized,
       signature,
-    },
-  });
-  return data;
-}
-
-export async function prepareTransferRequest(
-  partyId: string,
-  params: PrepareTransferRequest,
-): Promise<PrepareTransferResponse> {
-  const { data } = await gatewayNetwork<PrepareTransferResponse, PrepareTransferRequest>({
-    method: "POST",
-    url: `${getGatewayUrl()}/v1/node/${getNodeId()}/party/${partyId}/transaction/prepare`,
-    data: params,
+    } satisfies Omit<SubmitTapRequestRequest, "partyId">,
   });
   return data;
 }
 
 export async function getLedgerEnd(): Promise<number> {
-  const { data } = await gatewayNetwork<number>({
+  const { data } = await network<number>({
     method: "GET",
     url: `${getGatewayUrl()}/v1/node/${getNodeId()}/ledger-end`,
   });
@@ -464,29 +414,31 @@ export async function getLedgerEnd(): Promise<number> {
 export async function preparePreApprovalTransaction(
   partyId: string,
 ): Promise<PrepareTransactionResponse> {
-  const { data } = await gatewayNetwork<PrepareTransactionResponse, PrepareTransactionRequest>({
+  const { data } = await network<PrepareTransactionResponse>({
     method: "POST",
     url: `${getGatewayUrl()}/v1/node/${getNodeId()}/party/${partyId}/transaction/prepare`,
     data: {
       type: TransactionType.TRANSFER_PRE_APPROVAL_PROPOSAL,
       receiver: partyId,
-    },
+    } satisfies PrepareTransactionRequest,
   });
   return data;
 }
 
 export async function submitPreApprovalTransaction(
   partyId: string,
-  { serialized }: PrepareTransactionResponse,
+  preparedTransaction: PrepareTransactionResponse,
   signature: string,
 ): Promise<PreApprovalResult> {
-  const { data } = await gatewayNetwork<SubmitTransactionResponse, SubmitTransactionRequest>({
+  const submitRequest: SubmitTransactionRequest = {
+    serialized: preparedTransaction.serialized,
+    signature,
+  };
+
+  const { data } = await network<SubmitTransactionResponse>({
     method: "POST",
     url: `${getGatewayUrl()}/v1/node/${getNodeId()}/party/${partyId}/transaction/submit`,
-    data: {
-      serialized,
-      signature,
-    },
+    data: submitRequest,
   });
 
   return {

package/src/network/node.ts

@@ -3,7 +3,7 @@ import network from "@ledgerhq/live-network";
 import type { LiveNetworkRequest } from "@ledgerhq/live-network/network";
 import { getEnv } from "@ledgerhq/live-env";
 import coinConfig from "../config";
-import { AccountInfoResponse, SubmitResponse } from "./types";
+import { AccountInfoResponse, SubmitReponse } from "./types";
 import crypto from "crypto";
 
 const getNodeUrl = () => coinConfig.getCoinConfig().nodeUrl || "";
@@ -86,10 +86,10 @@ export const getLedgerEnd = async (): Promise<number> => {
   return data.offset;
 };
 
-export const submit = async (signedTx: string): Promise<SubmitResponse> => {
+export const submit = async (signedTx: string): Promise<SubmitReponse> => {
   // @ts-expect-error: add NODE_BOILERPLATE to libs/env/src/env.ts
   const url = `${getEnv("NODE_BOILERPLATE")}/submit`;
-  const { data } = await network<SubmitResponse>({
+  const { data } = await network<SubmitReponse>({
     url,
     method: "GET",
   });

package/src/network/types.ts

@@ -40,7 +40,7 @@ export type AccountInfoResponse = {
   validated: boolean;
 } & ResponseStatus;
 
-export type SubmitResponse = {
+export type SubmitReponse = {
   accepted: boolean;
   tx_hash: string;
 };

package/src/signer/getAddress.ts

@@ -1,19 +1,17 @@
 import { GetAddressOptions } from "@ledgerhq/coin-framework/derivation";
 import { GetAddressFn } from "@ledgerhq/coin-framework/bridge/getAddressWrapper";
 import { SignerContext } from "@ledgerhq/coin-framework/signer";
-import { CantonSigner, CantonAddress } from "../types";
+import { CantonSigner } from "../types";
 
 const getAddress = (signerContext: SignerContext<CantonSigner>): GetAddressFn => {
-  return async (deviceId: string, { path, verify }: GetAddressOptions) => {
-    const { address, publicKey } = await signerContext(deviceId, signer =>
-      signer.getAddress(path, verify),
-    );
+  return async (deviceId: string, { path }: GetAddressOptions) => {
+    const { address, publicKey } = await signerContext(deviceId, signer => signer.getAddress(path));
 
     return {
       path,
       address,
       publicKey,
-    } satisfies CantonAddress;
+    };
   };
 };
 

package/src/types/bridge.ts

@@ -1,8 +1,6 @@
 import type { BigNumber } from "bignumber.js";
 import type { Observable } from "rxjs";
 import type {
-  Account,
-  AccountRaw,
   CurrencyBridge,
   TransactionCommon,
   TransactionCommonRaw,
@@ -52,17 +50,3 @@ export type TransactionRaw = TransactionCommonRaw & {
 
 export type TransactionStatus = TransactionStatusCommon;
 export type TransactionStatusRaw = TransactionStatusCommonRaw;
-
-export type CantonResources = {
-  partyId: string;
-};
-export type CantonResourcesRaw = {
-  partyId: string;
-};
-
-export type CantonAccount = Account & {
-  cantonResources?: CantonResources;
-};
-export type CantonAccountRaw = AccountRaw & {
-  cantonResources: CantonResourcesRaw;
-};

package/src/types/index.ts

@@ -1,3 +1,14 @@
 export * from "./bridge";
 export * from "./onboard";
 export * from "./signer";
+
+export type BoilerplateNativeTransaction = {
+  TransactionType: "Payment";
+  Account: string;
+  Amount: string;
+  Destination: string;
+  Fee: string;
+  Sequence: number;
+  SigningPubKey?: string;
+  TxnSignature?: string;
+};

package/src/types/onboard.ts

@@ -1,5 +1,3 @@
-import { Account } from "@ledgerhq/types-live";
-
 export enum OnboardStatus {
   INIT,
   PREPARE,
@@ -24,7 +22,6 @@ export type CantonOnboardProgress = {
 
 export type CantonOnboardResult = {
   partyId: string;
-  account: Partial<Account>;
 };
 
 export type CantonPreApprovalProgress = {

package/src/types/signer.ts

@@ -1,12 +1,11 @@
 export type CantonAddress = {
   publicKey: string;
   address: string;
-  path: string; // TODO: check if necessary
 };
 
 export type CantonSignature = string; // `0x${string}`
 
 export interface CantonSigner {
-  getAddress(path: string, display?: boolean): Promise<CantonAddress>;
+  getAddress(path: string): Promise<CantonAddress>;
   signTransaction(path: string, rawTx: string): Promise<CantonSignature>;
 }