@ledgerhq/coin-canton 0.23.2 → 0.24.0

package/CHANGELOG.md

@@ -1,5 +1,49 @@
 # @ledgerhq/coin-canton
 
+## 0.24.0
+
+### Minor Changes
+
+- [#16996](https://github.com/LedgerHQ/ledger-live/pull/16996) [`3be5049`](https://github.com/LedgerHQ/ledger-live/commit/3be5049c9462d5760d6fec2c99647f0b9773b5b2) Thanks [@YazhuEth](https://github.com/YazhuEth)! - fix: ensure broadcast throws on network errors at all layers (canton, concordium, mina)
+
+### Patch Changes
+
+- Updated dependencies [[`ed0dc8a`](https://github.com/LedgerHQ/ledger-live/commit/ed0dc8abc2c8f5054e655c4e12efe6fb433fbaca), [`4ddd97a`](https://github.com/LedgerHQ/ledger-live/commit/4ddd97a99bab5b581ad5ccfd36eb420ec4ee6352), [`7fafa10`](https://github.com/LedgerHQ/ledger-live/commit/7fafa10d8af581f4433a60ea908980a726d3a777), [`ac26c8b`](https://github.com/LedgerHQ/ledger-live/commit/ac26c8bffa9b5cc9f28bed5ce3d44e32982d655c), [`fb79639`](https://github.com/LedgerHQ/ledger-live/commit/fb79639eb81258bae4830ed6ffe375ae625054ad), [`0d11df6`](https://github.com/LedgerHQ/ledger-live/commit/0d11df6ef8dc781171071824ad1c39e3beed7730), [`b866ea6`](https://github.com/LedgerHQ/ledger-live/commit/b866ea67bcbd408a33dbc9233ef55298e2a8ef25), [`321a0e2`](https://github.com/LedgerHQ/ledger-live/commit/321a0e2ce948fac11f7bdf0e106eb0af57168caa), [`d308b1a`](https://github.com/LedgerHQ/ledger-live/commit/d308b1a6b9c629839f051cf367a527f4232120c7), [`21e69fe`](https://github.com/LedgerHQ/ledger-live/commit/21e69fea49cffc0b1204903e539a64b83e4b28f0), [`e6dc658`](https://github.com/LedgerHQ/ledger-live/commit/e6dc658b83ebd2102e19a1fead021443457c05d9), [`fb4d165`](https://github.com/LedgerHQ/ledger-live/commit/fb4d1656be8dc8e933e55600970a2e991fbaeebb), [`5bd95a9`](https://github.com/LedgerHQ/ledger-live/commit/5bd95a9ceaac4d08c87d635f721265357368f8ee), [`73bfe05`](https://github.com/LedgerHQ/ledger-live/commit/73bfe055ec23e0d630f2da9f4dbc9731b6fe5190)]:
+  - @ledgerhq/types-live@6.107.0
+  - @ledgerhq/ledger-wallet-framework@1.4.0
+  - @ledgerhq/live-env@2.34.0
+  - @ledgerhq/errors@6.35.0
+  - @ledgerhq/cryptoassets@13.47.0
+  - @ledgerhq/live-network@2.6.0
+  - @ledgerhq/devices@8.14.2
+  - @ledgerhq/hw-app-canton@0.12.1
+
+## 0.24.0-next.1
+
+### Patch Changes
+
+- Updated dependencies [[`e6dc658`](https://github.com/LedgerHQ/ledger-live/commit/e6dc658b83ebd2102e19a1fead021443457c05d9)]:
+  - @ledgerhq/cryptoassets@13.47.0-next.1
+  - @ledgerhq/ledger-wallet-framework@1.4.0-next.1
+
+## 0.24.0-next.0
+
+### Minor Changes
+
+- [#16996](https://github.com/LedgerHQ/ledger-live/pull/16996) [`3be5049`](https://github.com/LedgerHQ/ledger-live/commit/3be5049c9462d5760d6fec2c99647f0b9773b5b2) Thanks [@YazhuEth](https://github.com/YazhuEth)! - fix: ensure broadcast throws on network errors at all layers (canton, concordium, mina)
+
+### Patch Changes
+
+- Updated dependencies [[`ed0dc8a`](https://github.com/LedgerHQ/ledger-live/commit/ed0dc8abc2c8f5054e655c4e12efe6fb433fbaca), [`4ddd97a`](https://github.com/LedgerHQ/ledger-live/commit/4ddd97a99bab5b581ad5ccfd36eb420ec4ee6352), [`7fafa10`](https://github.com/LedgerHQ/ledger-live/commit/7fafa10d8af581f4433a60ea908980a726d3a777), [`ac26c8b`](https://github.com/LedgerHQ/ledger-live/commit/ac26c8bffa9b5cc9f28bed5ce3d44e32982d655c), [`fb79639`](https://github.com/LedgerHQ/ledger-live/commit/fb79639eb81258bae4830ed6ffe375ae625054ad), [`0d11df6`](https://github.com/LedgerHQ/ledger-live/commit/0d11df6ef8dc781171071824ad1c39e3beed7730), [`b866ea6`](https://github.com/LedgerHQ/ledger-live/commit/b866ea67bcbd408a33dbc9233ef55298e2a8ef25), [`321a0e2`](https://github.com/LedgerHQ/ledger-live/commit/321a0e2ce948fac11f7bdf0e106eb0af57168caa), [`d308b1a`](https://github.com/LedgerHQ/ledger-live/commit/d308b1a6b9c629839f051cf367a527f4232120c7), [`21e69fe`](https://github.com/LedgerHQ/ledger-live/commit/21e69fea49cffc0b1204903e539a64b83e4b28f0), [`fb4d165`](https://github.com/LedgerHQ/ledger-live/commit/fb4d1656be8dc8e933e55600970a2e991fbaeebb), [`5bd95a9`](https://github.com/LedgerHQ/ledger-live/commit/5bd95a9ceaac4d08c87d635f721265357368f8ee), [`73bfe05`](https://github.com/LedgerHQ/ledger-live/commit/73bfe055ec23e0d630f2da9f4dbc9731b6fe5190)]:
+  - @ledgerhq/types-live@6.107.0-next.0
+  - @ledgerhq/ledger-wallet-framework@1.4.0-next.0
+  - @ledgerhq/live-env@2.34.0-next.0
+  - @ledgerhq/errors@6.35.0-next.0
+  - @ledgerhq/cryptoassets@13.47.0-next.0
+  - @ledgerhq/live-network@2.6.0-next.0
+  - @ledgerhq/devices@8.14.2-next.0
+  - @ledgerhq/hw-app-canton@0.12.1-next.0
+
 ## 0.23.2
 
 ### Patch Changes

package/jest.config.js

@@ -25,6 +25,7 @@ module.exports = {
   workerThreads: true,
   reporters: [
     "default",
+    ...(process.env.CI ? ["github-actions"] : []),
     ["jest-sonar", { outputName: "sonar-executionTests-report.xml", reportedFilePath: "absolute" }],
   ],
 };

package/lib/bridge/broadcast.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"broadcast.d.ts","sourceRoot":"","sources":["../../src/bridge/broadcast.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,aAAa,EAAE,MAAM,sBAAsB,CAAC;AAErD,OAAO,EAAE,WAAW,EAAE,MAAM,UAAU,CAAC;AAEvC,eAAO,MAAM,SAAS,EAAE,aAAa,CAAC,WAAW,CAAC,CAAC,WAAW,CAO7D,CAAC"}
+{"version":3,"file":"broadcast.d.ts","sourceRoot":"","sources":["../../src/bridge/broadcast.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,aAAa,EAAE,MAAM,sBAAsB,CAAC;AAErD,OAAO,EAAE,WAAW,EAAE,MAAM,UAAU,CAAC;AAEvC,eAAO,MAAM,SAAS,EAAE,aAAa,CAAC,WAAW,CAAC,CAAC,WAAW,CAU7D,CAAC"}

package/lib/bridge/broadcast.js

@@ -6,6 +6,9 @@ const common_logic_1 = require("../common-logic");
 const broadcast = async ({ account, signedOperation, }) => {
     const { operation, signature } = signedOperation;
     const hash = await (0, common_logic_1.broadcast)(account.currency, signature);
+    if (!hash) {
+        throw new Error("canton: broadcast returned no transaction id");
+    }
     return (0, operation_1.patchOperationWithHash)(operation, hash);
 };
 exports.broadcast = broadcast;

package/lib/bridge/broadcast.js.map

@@ -1 +1 @@
-{"version":3,"file":"broadcast.js","sourceRoot":"","sources":["../../src/bridge/broadcast.ts"],"names":[],"mappings":";;;AAAA,2EAAqF;AAErF,kDAA8D;AAGvD,MAAM,SAAS,GAA4C,KAAK,EAAE,EACvE,OAAO,EACP,eAAe,GAChB,EAAE,EAAE;IACH,MAAM,EAAE,SAAS,EAAE,SAAS,EAAE,GAAG,eAAe,CAAC;IACjD,MAAM,IAAI,GAAG,MAAM,IAAA,wBAAc,EAAC,OAAO,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC;IAC/D,OAAO,IAAA,kCAAsB,EAAC,SAAS,EAAE,IAAI,CAAC,CAAC;AACjD,CAAC,CAAC;AAPW,QAAA,SAAS,aAOpB"}
+{"version":3,"file":"broadcast.js","sourceRoot":"","sources":["../../src/bridge/broadcast.ts"],"names":[],"mappings":";;;AAAA,2EAAqF;AAErF,kDAA8D;AAGvD,MAAM,SAAS,GAA4C,KAAK,EAAE,EACvE,OAAO,EACP,eAAe,GAChB,EAAE,EAAE;IACH,MAAM,EAAE,SAAS,EAAE,SAAS,EAAE,GAAG,eAAe,CAAC;IACjD,MAAM,IAAI,GAAG,MAAM,IAAA,wBAAc,EAAC,OAAO,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC;IAC/D,IAAI,CAAC,IAAI,EAAE,CAAC;QACV,MAAM,IAAI,KAAK,CAAC,8CAA8C,CAAC,CAAC;IAClE,CAAC;IACD,OAAO,IAAA,kCAAsB,EAAC,SAAS,EAAE,IAAI,CAAC,CAAC;AACjD,CAAC,CAAC;AAVW,QAAA,SAAS,aAUpB"}

package/lib-es/bridge/broadcast.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"broadcast.d.ts","sourceRoot":"","sources":["../../src/bridge/broadcast.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,aAAa,EAAE,MAAM,sBAAsB,CAAC;AAErD,OAAO,EAAE,WAAW,EAAE,MAAM,UAAU,CAAC;AAEvC,eAAO,MAAM,SAAS,EAAE,aAAa,CAAC,WAAW,CAAC,CAAC,WAAW,CAO7D,CAAC"}
+{"version":3,"file":"broadcast.d.ts","sourceRoot":"","sources":["../../src/bridge/broadcast.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,aAAa,EAAE,MAAM,sBAAsB,CAAC;AAErD,OAAO,EAAE,WAAW,EAAE,MAAM,UAAU,CAAC;AAEvC,eAAO,MAAM,SAAS,EAAE,aAAa,CAAC,WAAW,CAAC,CAAC,WAAW,CAU7D,CAAC"}

package/lib-es/bridge/broadcast.js

@@ -3,6 +3,9 @@ import { broadcast as broadcastLogic } from "../common-logic";
 export const broadcast = async ({ account, signedOperation, }) => {
     const { operation, signature } = signedOperation;
     const hash = await broadcastLogic(account.currency, signature);
+    if (!hash) {
+        throw new Error("canton: broadcast returned no transaction id");
+    }
     return patchOperationWithHash(operation, hash);
 };
 //# sourceMappingURL=broadcast.js.map

package/lib-es/bridge/broadcast.js.map

@@ -1 +1 @@
-{"version":3,"file":"broadcast.js","sourceRoot":"","sources":["../../src/bridge/broadcast.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,sBAAsB,EAAE,MAAM,6CAA6C,CAAC;AAErF,OAAO,EAAE,SAAS,IAAI,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAG9D,MAAM,CAAC,MAAM,SAAS,GAA4C,KAAK,EAAE,EACvE,OAAO,EACP,eAAe,GAChB,EAAE,EAAE;IACH,MAAM,EAAE,SAAS,EAAE,SAAS,EAAE,GAAG,eAAe,CAAC;IACjD,MAAM,IAAI,GAAG,MAAM,cAAc,CAAC,OAAO,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC;IAC/D,OAAO,sBAAsB,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;AACjD,CAAC,CAAC"}
+{"version":3,"file":"broadcast.js","sourceRoot":"","sources":["../../src/bridge/broadcast.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,sBAAsB,EAAE,MAAM,6CAA6C,CAAC;AAErF,OAAO,EAAE,SAAS,IAAI,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAG9D,MAAM,CAAC,MAAM,SAAS,GAA4C,KAAK,EAAE,EACvE,OAAO,EACP,eAAe,GAChB,EAAE,EAAE;IACH,MAAM,EAAE,SAAS,EAAE,SAAS,EAAE,GAAG,eAAe,CAAC;IACjD,MAAM,IAAI,GAAG,MAAM,cAAc,CAAC,OAAO,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC;IAC/D,IAAI,CAAC,IAAI,EAAE,CAAC;QACV,MAAM,IAAI,KAAK,CAAC,8CAA8C,CAAC,CAAC;IAClE,CAAC;IACD,OAAO,sBAAsB,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;AACjD,CAAC,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ledgerhq/coin-canton",
-  "version": "0.23.2",
+  "version": "0.24.0",
   "description": "Canton coin integration",
   "keywords": [
     "Ledger",
@@ -110,15 +110,15 @@
     "bignumber.js": "^9.1.2",
     "invariant": "^2.2.4",
     "rxjs": "7.8.2",
-    "@ledgerhq/cryptoassets": "^13.46.2",
+    "@ledgerhq/cryptoassets": "^13.47.0",
     "@ledgerhq/devices": "8.14.2",
-    "@ledgerhq/errors": "^6.34.1",
+    "@ledgerhq/errors": "^6.35.0",
     "@ledgerhq/hw-app-canton": "^0.12.1",
-    "@ledgerhq/ledger-wallet-framework": "^1.3.2",
-    "@ledgerhq/live-env": "^2.33.0",
-    "@ledgerhq/live-network": "^2.5.2",
+    "@ledgerhq/ledger-wallet-framework": "^1.4.0",
+    "@ledgerhq/live-env": "^2.34.0",
+    "@ledgerhq/live-network": "^2.6.0",
     "@ledgerhq/logs": "^6.17.0",
-    "@ledgerhq/types-live": "^6.106.0"
+    "@ledgerhq/types-live": "^6.107.0"
   },
   "devDependencies": {
     "@swc/core": "1.15.11",

package/src/bridge/broadcast.integ.test.ts

@@ -0,0 +1,26 @@
+import { createMockCantonAccount, setupMockCoinConfig } from "../test/fixtures";
+import { broadcast } from "./broadcast";
+
+describe("Broadcast", () => {
+  beforeAll(() => {
+    setupMockCoinConfig();
+  });
+
+  it("throws when submitting with an invalid party id", async () => {
+    const account = createMockCantonAccount();
+    const signedTx = JSON.stringify({
+      serialized: "garbage-serialized",
+      signature: "garbage-sig__PARTY__fake-party-id",
+    });
+
+    await expect(
+      broadcast({
+        account,
+        signedOperation: {
+          signature: signedTx,
+          operation: { id: "integ", hash: "", extra: {} },
+        },
+      } as any),
+    ).rejects.toThrow(/Invalid value for: path parameter party_id/);
+  });
+});

package/src/bridge/broadcast.ts

@@ -9,5 +9,8 @@ export const broadcast: AccountBridge<Transaction>["broadcast"] = async ({
 }) => {
   const { operation, signature } = signedOperation;
   const hash = await broadcastLogic(account.currency, signature);
+  if (!hash) {
+    throw new Error("canton: broadcast returned no transaction id");
+  }
   return patchOperationWithHash(operation, hash);
 };

package/src/common-logic/transaction/broadcast.integ.test.ts

@@ -0,0 +1,20 @@
+import { createMockCantonCurrency, setupMockCoinConfig } from "../../test/fixtures";
+import { broadcast } from "./broadcast";
+
+describe("Broadcast", () => {
+  beforeAll(() => {
+    setupMockCoinConfig();
+  });
+
+  it("throws when submitting with an invalid party id", async () => {
+    const currency = createMockCantonCurrency();
+    const signedTx = JSON.stringify({
+      serialized: "garbage-serialized",
+      signature: "garbage-sig__PARTY__fake-party-id",
+    });
+
+    await expect(broadcast(currency, signedTx)).rejects.toThrow(
+      /Invalid value for: path parameter party_id/,
+    );
+  });
+});

package/src/network/gateway.integ.test.ts

@@ -11,6 +11,7 @@ import {
   prepareOnboarding,
   preparePreApprovalTransaction,
   prepareTapRequest,
+  submit,
   submitOnboarding,
   submitPreApprovalTransaction,
   submitTapRequest,
@@ -378,4 +379,12 @@ describe("gateway (devnet)", () => {
       expect(typeof response.updateId).toBe("string");
     }, 30000);
   });
+
+  describe("submit", () => {
+    it("throws when submitting with a non-existent party", async () => {
+      await expect(
+        submit(mockCurrency, "fake-party-id", "garbage-serialized", "garbage-signature"),
+      ).rejects.toThrow(/Invalid value for: path parameter party_id/);
+    });
+  });
 });