@ledgerhq/coin-aptos 3.2.0 → 3.3.0-nightly.1

package/src/__tests__/network/client.test.ts

@@ -860,7 +860,7 @@ describe("Aptos API", () => {
     it("list of operations", async () => {
       const api = new AptosAPI("aptos");
       const address = "0x12345";
-      const pagination: Pagination = { minHeight: 0 };
+      const pagination: Pagination = { minHeight: 0, order: "asc" };
 
       const txs: AptosTransaction[] = [
         {
@@ -1297,7 +1297,7 @@ describe("Aptos API", () => {
 
       api.getAccountInfo = jest.fn().mockResolvedValue({ transactions });
 
-      const ops = await api.listOperations(address, pagination);
+      const ops = await api.listOperations(address, pagination.minHeight);
 
       expect(ops[0]).toHaveLength(2);
       expect(ops[1]).toBe("");

package/src/api/index.ts

@@ -1,4 +1,4 @@
-import type {
+import {
   AlpacaApi,
   Block,
   BlockInfo,
@@ -6,6 +6,7 @@ import type {
   Stake,
   Reward,
   Page,
+  CraftedTransaction,
 } from "@ledgerhq/coin-framework/api/index";
 import type { AptosConfig as AptosConfigApi } from "../config";
 import type { Balance, Pagination, TransactionIntent } from "@ledgerhq/coin-framework/api/types";
@@ -23,13 +24,13 @@ export function createApi(config: AptosConfigApi): AlpacaApi {
   return {
     broadcast: (tx: string) => client.broadcast(tx),
     combine: (tx, signature, pubkey): string => combine(tx, signature, pubkey),
-    craftTransaction: (transactionIntent, _customFees): Promise<string> =>
+    craftTransaction: (transactionIntent, _customFees): Promise<CraftedTransaction> =>
       craftTransaction(client, transactionIntent),
     estimateFees: (transactionIntent: TransactionIntent) => client.estimateFees(transactionIntent),
     getBalance: (address): Promise<Balance[]> => getBalances(client, address),
     lastBlock: () => client.getLastBlock(),
     listOperations: (address: string, pagination: Pagination) =>
-      client.listOperations(address, pagination),
+      client.listOperations(address, pagination.minHeight),
     getBlock(_height): Promise<Block> {
       throw new Error("getBlock is not supported");
     },

package/src/logic/craftTransaction.ts

@@ -1,4 +1,4 @@
-import type { TransactionIntent } from "@ledgerhq/coin-framework/lib/api/types";
+import { CraftedTransaction, TransactionIntent } from "@ledgerhq/coin-framework/lib/api/types";
 import type { Account, TokenAccount } from "@ledgerhq/types-live";
 import type { AptosAPI } from "../network";
 import buildTransaction, { isTokenType } from "./buildTransaction";
@@ -10,7 +10,7 @@ import type { AptosBalance } from "../types";
 export async function craftTransaction(
   aptosClient: AptosAPI,
   transactionIntent: TransactionIntent,
-): Promise<string> {
+): Promise<CraftedTransaction> {
   const newTx = createTransaction();
   newTx.amount = BigNumber(transactionIntent.amount.toString());
   newTx.recipient = transactionIntent.recipient;
@@ -50,7 +50,7 @@ export async function craftTransaction(
     tokenType ?? undefined,
   );
 
-  return aptosTx.bcsToHex().toString();
+  return { transaction: aptosTx.bcsToHex().toString() };
 }
 
 function getContractAddress(txIntent: TransactionIntent): string {

package/src/network/client.ts

@@ -46,7 +46,6 @@ import {
   BlockInfo,
   FeeEstimation,
   Operation,
-  Pagination,
   TransactionIntent,
 } from "@ledgerhq/coin-framework/api/types";
 import { log } from "@ledgerhq/logs";
@@ -290,9 +289,9 @@ export class AptosAPI {
     }
   }
 
-  async listOperations(rawAddress: string, pagination: Pagination): Promise<[Operation[], string]> {
+  async listOperations(rawAddress: string, minHeight: number): Promise<[Operation[], string]> {
     const address = normalizeAddress(rawAddress);
-    const transactions = await this.getAccountInfo(address, pagination.minHeight.toString());
+    const transactions = await this.getAccountInfo(address, minHeight.toString());
     const newOperations = transactionsToOperations(address, transactions.transactions);
 
     return [newOperations, ""];