@lebronj/pi-suite 0.1.7 → 0.1.8

package/README.md

@@ -15,7 +15,7 @@ pi install npm:pi-subagents
 Or use the bootstrap script to install Pi, configure the team OpenAI-compatible endpoint, install this suite, and set up Bun + qmd for memory search:
 
 ```bash
-curl -fsSL https://registry.npmjs.org/@lebronj/pi-suite/-/pi-suite-0.1.7.tgz | tar -xzO package/scripts/bootstrap.sh | bash
+curl -fsSL https://registry.npmjs.org/@lebronj/pi-suite/-/pi-suite-0.1.8.tgz | tar -xzO package/scripts/bootstrap.sh | bash
 ```
 
 ## What Is Included
@@ -67,7 +67,7 @@ qmd collection add ~/.pi/agent/memory --name pi-memory
 qmd embed
 ```
 
-Memory versioning is enabled by default. It snapshots `~/.pi/agent/memory` and `~/.pi/agent/skill-drafts` into `~/.pi/agent/evolution`, commits local changes automatically, and leaves push manual by default.
+Memory versioning is enabled by default. It snapshots `~/.pi/agent/memory` and `~/.pi/agent/skill-drafts` into `~/.pi/agent/evolution`, commits local changes automatically, and leaves push manual by default. `memory_curate` also scans yesterday's daily log into `REVIEW.md` when learning is enabled and the daily file changed since the last scan.
 
 Useful commands:
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lebronj/pi-suite",
-  "version": "0.1.7",
+  "version": "0.1.8",
   "description": "JHP's Pi extension suite for team coding workflows",
   "type": "module",
   "keywords": [

package/skills/pi-skill/SKILL.md

@@ -46,7 +46,7 @@ Memory tools:
 - `memory_edit`: read/add/replace/remove/replace_all/compact structured entries in `MEMORY.md`, `USER.md`, `STATE.md`, and `REVIEW.md`.
 - `scratchpad`: add/done/undo/clear/list checklist items.
 - `memory_search`: qmd-backed keyword, semantic, or deep search across memory files.
-- `memory_curate`: manually run curator lifecycle rules.
+- `memory_curate`: manually run curator lifecycle rules and scan yesterday's daily log into `REVIEW.md` when learning is enabled.
 - `memory_learning_approve`: approve a proposed memory promotion or disabled skill draft by exact id.
 - `memory_learning_reject`: reject or archive a review candidate/proposal without deleting it.
 - `memory_skill_drafts`: list proposed skill drafts.
@@ -74,6 +74,7 @@ Curator and learning behavior:
 - Quotas reset when `month` or `reset` rolls over.
 - Mutations are audited to `audit/curator.jsonl`.
 - Session shutdown may extract conservative learning candidates into `REVIEW.md`; they are not injected as normal memory and are not auto-enabled.
+- `memory_curate` scans yesterday's daily log once per content hash into review candidates, then curator lifecycle and proposal rules process those candidates.
 - Repeated candidates can become proposed memory promotions or proposed disabled skill drafts after `memory_curate`.
 - Approval is explicit by default: memory proposals write to memory stores; skill proposals write disabled drafts under `~/.pi/agent/skill-drafts/`.
 - The curator avoids semantic auto-delete/merge; ambiguous learning stays in review first.

package/vendor/pi-memory/README.md

@@ -196,7 +196,7 @@ Pi-memory mirrors the authoritative runtime directories into a local evolution r
 
 Authoritative runtime data remains `~/.pi/agent/memory` and `~/.pi/agent/skill-drafts`; `~/.pi/agent/evolution` is a versioned mirror and backup repo.
 
-Automatic hooks snapshot before and sync/commit after `memory_write`, mutating `memory_edit`, mutating `scratchpad`, `memory_curate`, learning approve/reject, session summary/handoff writes, compaction handoffs, and external `jhp-pi-memory-curator run-once`. Read-only operations do not snapshot.
+Automatic hooks snapshot before and sync/commit after `memory_write`, mutating `memory_edit`, mutating `scratchpad`, `memory_curate`, learning approve/reject, session summary/handoff writes, compaction handoffs, and external `jhp-pi-memory-curator run-once`. `memory_curate` also scans yesterday's daily log into `REVIEW.md` when learning is enabled and that daily file changed since the last scan. Read-only operations do not snapshot.
 
 Tools and slash commands:
 
@@ -242,7 +242,7 @@ The controller uses a systemd user timer when available and falls back to cron.
 | `PI_MEMORY_QMD_UPDATE` | `background`, `manual`, `off` | `background` | Control qmd update after writes |
 | `PI_MEMORY_NO_SEARCH` | `1` | unset | Disable per-turn search injection |
 | `PI_MEMORY_SUMMARIZE_TRANSITIONS` | `1`, `true`, `yes`, `on` | unset | Also summarize lifecycle transitions |
-| `PI_MEMORY_LEARNING` | `off`, `review`, `auto-review` | `review` | Control session learning candidate extraction |
+| `PI_MEMORY_LEARNING` | `off`, `review`, `auto-review` | `review` | Control session and curator daily learning candidate extraction |
 | `PI_MEMORY_LEARNING_MIN_CONFIDENCE` | `low`, `medium`, `high` | `medium` | Minimum extractor confidence to keep |
 | `PI_MEMORY_SKILL_DRAFTS` | `off`, `review` | `review` | Allow curator to propose disabled skill drafts |
 | `PI_MEMORY_AUTO_APPROVE_MEMORY` | `1`, `true`, `yes`, `on` | unset | YOLO mode for approving newly created memory proposals |

package/vendor/pi-memory/index.ts

@@ -26,6 +26,7 @@
  */
 
 import { type ExecFileOptions, execFile } from "node:child_process";
+import { createHash } from "node:crypto";
 import * as fs from "node:fs";
 import * as path from "node:path";
 import { complete, type Message, StringEnum } from "@earendil-works/pi-ai";
@@ -89,6 +90,7 @@ let USER_FILE = path.join(MEMORY_DIR, "USER.md");
 let STATE_FILE = path.join(MEMORY_DIR, "STATE.md");
 let REVIEW_FILE = path.join(MEMORY_DIR, "REVIEW.md");
 let SCRATCHPAD_FILE = path.join(MEMORY_DIR, "SCRATCHPAD.md");
+let LEARNING_STATE_FILE = path.join(MEMORY_DIR, ".learning-state.json");
 let DAILY_DIR = path.join(MEMORY_DIR, "daily");
 let SKILL_DRAFTS_DIR = path.join(path.dirname(MEMORY_DIR), "skill-drafts");
 
@@ -104,6 +106,7 @@ export function _setBaseDir(baseDir: string) {
 	STATE_FILE = path.join(baseDir, "STATE.md");
 	REVIEW_FILE = path.join(baseDir, "REVIEW.md");
 	SCRATCHPAD_FILE = path.join(baseDir, "SCRATCHPAD.md");
+	LEARNING_STATE_FILE = path.join(baseDir, ".learning-state.json");
 	DAILY_DIR = path.join(baseDir, "daily");
 	SKILL_DRAFTS_DIR = path.join(path.dirname(baseDir), "skill-drafts");
 }
@@ -562,9 +565,9 @@ function shouldKeepLearningCandidate(confidence: "low" | "medium" | "high", env:
 	return confidenceRank(confidence) >= confidenceRank(getMemoryLearningMinConfidence(env));
 }
 
-function buildLearningExtractorPrompt(conversationText: string, truncated: boolean, totalChars: number): string {
+function buildLearningExtractorPrompt(conversationText: string, truncated: boolean, totalChars: number, sourceLabel = "session transcript"): string {
 	const lines = [
-		"Extract zero or more review candidates from this session transcript.",
+		`Extract zero or more review candidates from this ${sourceLabel}.`,
 		"Return JSON exactly shaped as: {\"candidates\":[{\"kind\":\"bug_fix|skill_candidate|preference|project_fact\",\"confidence\":\"low|medium|high\",\"signature\":\"short stable signature\",\"summary\":\"optional concise summary\",\"targetHints\":[\"memory\",\"skill\"],\"evidence\":\"optional compact evidence\"}]}",
 		"Only include verified bug fixes when a failure was followed by an edit/action and successful validation.",
 		"Drop one-off trivia, transient status, workflow artifacts, and loop artifacts.",
@@ -671,31 +674,90 @@ export function parseLearningExtractorResponse(raw: string): ReviewCandidateInpu
 	return candidates;
 }
 
-async function runSessionLearningExtractor(ctx: ExtensionContext): Promise<number> {
-	if (getMemoryLearningMode() === "off") return 0;
-	const branch = getSessionBranch(ctx);
-	if (!branch || !ctx.model) return 0;
+type DailyLearningState = {
+	daily?: Record<string, { hash: string; scannedAt: string; candidates: number }>;
+};
+
+function readLearningState(): DailyLearningState {
+	try {
+		const parsed = JSON.parse(fs.readFileSync(LEARNING_STATE_FILE, "utf-8"));
+		return parsed && typeof parsed === "object" ? parsed as DailyLearningState : {};
+	} catch {
+		return {};
+	}
+}
+
+function writeLearningState(state: DailyLearningState): void {
+	fs.writeFileSync(LEARNING_STATE_FILE, `${JSON.stringify(state, null, 2)}\n`, "utf-8");
+}
+
+function contentHash(content: string): string {
+	return createHash("sha256").update(content).digest("hex");
+}
+
+async function extractLearningCandidates(
+	ctx: ExtensionContext,
+	text: string,
+	sourceLabel: string,
+	source: string,
+	date?: string,
+): Promise<ReviewCandidateInput[]> {
+	if (getMemoryLearningMode() === "off" || !ctx.model) return [];
 	const apiKey = await resolveExitSummaryApiKey(ctx);
-	if (!apiKey) return 0;
-	const conversation = serializeSessionConversation(branch);
-	if (!conversation.hasMessages || !conversation.text.trim()) return 0;
-	const truncated = truncateText(conversation.text.trim(), LEARNING_EXTRACTOR_MAX_CHARS, "end");
+	if (!apiKey) return [];
+	const trimmed = text.trim();
+	if (!trimmed) return [];
+	const truncated = truncateText(trimmed, LEARNING_EXTRACTOR_MAX_CHARS, "end");
 	const messages: Message[] = [{
 		role: "user",
-		content: [{ type: "text", text: buildLearningExtractorPrompt(truncated.text, truncated.truncated, conversation.text.trim().length) }],
+		content: [{ type: "text", text: buildLearningExtractorPrompt(truncated.text, truncated.truncated, trimmed.length, sourceLabel) }],
 		timestamp: Date.now(),
 	}];
+	const response = await complete(ctx.model, { systemPrompt: LEARNING_EXTRACTOR_SYSTEM_PROMPT, messages }, { apiKey, reasoningEffort: "low" });
+	const raw = response.content.filter((part): part is { type: "text"; text: string } => part.type === "text").map((part) => part.text).join("\n");
+	return parseLearningExtractorResponse(raw).map((candidate) => ({ ...candidate, source, date }));
+}
+
+async function writeLearningCandidates(candidates: ReviewCandidateInput[]): Promise<number> {
+	let written = 0;
+	const store = new FileMemoryStore(MEMORY_DIR);
+	for (const candidate of candidates) {
+		const result = await upsertReviewCandidate(store, candidate);
+		if (result.changed) written += 1;
+	}
+	return written;
+}
+
+type DailyLearningScanResult = { scanned: boolean; changed: number; skipped?: string };
+
+async function runYesterdayDailyLearningScan(ctx: ExtensionContext): Promise<DailyLearningScanResult> {
+	if (getMemoryLearningMode() === "off") return { scanned: false, changed: 0, skipped: "learning off" };
+	const date = yesterdayStr();
+	const dailyContent = readFileSafe(dailyPath(date));
+	if (!dailyContent?.trim()) return { scanned: false, changed: 0, skipped: `daily/${date}.md empty or missing` };
+	const hash = contentHash(dailyContent);
+	const state = readLearningState();
+	const previous = state.daily?.[date];
+	if (previous?.hash === hash) return { scanned: false, changed: 0, skipped: `daily/${date}.md already scanned` };
 	try {
-		const response = await complete(ctx.model, { systemPrompt: LEARNING_EXTRACTOR_SYSTEM_PROMPT, messages }, { apiKey, reasoningEffort: "low" });
-		const raw = response.content.filter((part): part is { type: "text"; text: string } => part.type === "text").map((part) => part.text).join("\n");
-		const candidates = parseLearningExtractorResponse(raw);
-		let written = 0;
-		const store = new FileMemoryStore(MEMORY_DIR);
-		for (const candidate of candidates) {
-			const result = await upsertReviewCandidate(store, candidate);
-			if (result.changed) written += 1;
-		}
-		return written;
+		const candidates = await extractLearningCandidates(ctx, dailyContent, `daily log for ${date}`, `daily/${date}`, date);
+		const changed = await writeLearningCandidates(candidates);
+		state.daily = { ...(state.daily || {}), [date]: { hash, scannedAt: new Date().toISOString(), candidates: candidates.length } };
+		writeLearningState(state);
+		return { scanned: true, changed };
+	} catch {
+		return { scanned: false, changed: 0, skipped: `daily/${date}.md scan failed` };
+	}
+}
+
+async function runSessionLearningExtractor(ctx: ExtensionContext): Promise<number> {
+	const branch = getSessionBranch(ctx);
+	if (!branch) return 0;
+	const conversation = serializeSessionConversation(branch);
+	if (!conversation.hasMessages || !conversation.text.trim()) return 0;
+	try {
+		const candidates = await extractLearningCandidates(ctx, conversation.text, "session transcript", "session_shutdown");
+		return writeLearningCandidates(candidates);
 	} catch {
 		return 0;
 	}
@@ -1439,7 +1501,7 @@ function getSnapshotMode(): "stable" | "per-turn" {
 }
 
 
-async function runCurator(reason: string): Promise<string> {
+async function runCurator(reason: string, ctx?: ExtensionContext): Promise<string> {
 	ensureDirs();
 	await evolutionBeforeChange(`curator before ${reason}`, "memory: snapshot before curate", "tool");
 	const store = new FileMemoryStore(MEMORY_DIR);
@@ -1448,6 +1510,7 @@ async function runCurator(reason: string): Promise<string> {
 		auditLog: new JsonlAuditLog(MEMORY_DIR),
 		reason,
 	});
+	const dailyLearningResult = ctx ? await runYesterdayDailyLearningScan(ctx) : { scanned: false, changed: 0 };
 	const lifecycleResult = await applyReviewLifecycle(store);
 	const memoryResult = await proposeMemoryPromotions(store);
 	const skillResult = getMemorySkillDraftsMode() === "off" ? { created: 0, proposals: [] } : await proposeSkillDrafts(store, { draftsDir: SKILL_DRAFTS_DIR });
@@ -1465,7 +1528,7 @@ async function runCurator(reason: string): Promise<string> {
 			autoApprovedSkills += 1;
 		}
 	}
-	const learningChanges = lifecycleResult.changed + memoryResult.created + skillResult.created + autoApprovedMemory + autoApprovedSkills;
+	const learningChanges = dailyLearningResult.changed + lifecycleResult.changed + memoryResult.created + skillResult.created + autoApprovedMemory + autoApprovedSkills;
 	if (result.patches.length > 0 || learningChanges > 0) {
 		snapshotDirty = true;
 		await ensureQmdAvailableForUpdate();
@@ -1473,6 +1536,7 @@ async function runCurator(reason: string): Promise<string> {
 	}
 	await evolutionAfterChange("memory: sync after curate");
 	const notes = [
+		dailyLearningResult.scanned ? `scanned yesterday daily, wrote ${dailyLearningResult.changed} review candidate change(s)` : dailyLearningResult.skipped ? `daily learning skipped: ${dailyLearningResult.skipped}` : "",
 		memoryResult.created > 0 ? `proposed ${memoryResult.created} memory promotion(s)` : "",
 		skillResult.created > 0 ? `proposed ${skillResult.created} skill draft(s)` : "",
 		autoApprovedMemory > 0 ? `auto-approved ${autoApprovedMemory} memory promotion(s)` : "",
@@ -2270,11 +2334,11 @@ export default function (pi: ExtensionAPI) {
 	pi.registerTool({
 		name: "memory_curate",
 		label: "Memory Curate",
-		description: "Run the time-aware memory curator now. It deduplicates exact entries, updates event/quota lifecycle metadata, and appends stale temporary memories to REVIEW.md.",
+		description: "Run the time-aware memory curator now. It scans yesterday's daily log into REVIEW.md, deduplicates exact entries, updates event/quota lifecycle metadata, and appends stale temporary memories to REVIEW.md.",
 		parameters: Type.Object({}),
 		async execute(_toolCallId, _params, _signal, _onUpdate, _ctx) {
 			try {
-				const summary = await runCurator("memory_curate tool");
+				const summary = await runCurator("memory_curate tool", _ctx);
 				return { content: [{ type: "text", text: summary }], details: { summary } };
 			} catch (error) {
 				const message = error instanceof Error ? error.message : String(error);