@learnpack/learnpack 5.0.347 → 5.0.349

package/lib/commands/serve.js

@@ -3271,6 +3271,7 @@ class ServeCommand extends SessionCommand_1.default {
                 const addedLessons = [];
                 let repairedTranslationsInLessons = 0;
                 let repairedTranslationEntries = 0;
+                let fixedLessons = 0;
                 console.log(`📋 Checking ${syllabus.lessons.length} lessons in syllabus...`);
                 // First pass: Check each lesson to see if it exists in the bucket and count files.
                 // We try two possible folder names because they can differ by source:
@@ -3468,15 +3469,39 @@ class ServeCommand extends SessionCommand_1.default {
                             repairedTranslationsInLessons += 1;
                         }
                     }
+                    // Fifth pass: fix lessons stuck in GENERATING or ERROR when the file exists in the bucket
+                    const primaryLanguage = syllabus.courseInfo.language || "en";
+                    for (const lesson of syllabus.lessons) {
+                        if (lesson.generated !== false)
+                            continue;
+                        if (lesson.status !== "GENERATING" && lesson.status !== "ERROR")
+                            continue;
+                        const candidateSlugs = [
+                            (0, creatorUtilities_2.slugify)(lesson.id + "-" + lesson.title),
+                            lesson.uid,
+                        ].filter(Boolean);
+                        const matchedSlug = candidateSlugs.find(s => translationsBySlug.has(s));
+                        if (!matchedSlug)
+                            continue;
+                        const langs = translationsBySlug.get(matchedSlug) || [];
+                        if (!langs.includes(primaryLanguage))
+                            continue;
+                        const prevStatus = lesson.status;
+                        lesson.generated = true;
+                        lesson.status = "DONE";
+                        fixedLessons += 1;
+                        console.log(`🔧 Fixed lesson: ${lesson.id} - "${lesson.title}" (was generated:false status:${prevStatus}, primary language "${primaryLanguage}" exists in bucket)`);
+                    }
                 }
                 catch (error) {
                     console.error("⚠️ Could not reconcile lesson translations during syllabus sync:", error);
                 }
                 if (totalRemoved > 0 ||
                     addedLessons.length > 0 ||
-                    repairedTranslationsInLessons > 0) {
+                    repairedTranslationsInLessons > 0 ||
+                    fixedLessons > 0) {
                     await saveSyllabus(courseSlug, syllabus, bucket);
-                    console.log(`✅ Syllabus synchronized. Removed ${removedLessons.length} non-existent, ${duplicatesRemoved.length} duplicate(s); added ${addedLessons.length} from bucket; repaired translations in ${repairedTranslationsInLessons} lesson(s).`);
+                    console.log(`✅ Syllabus synchronized. Removed ${removedLessons.length} non-existent, ${duplicatesRemoved.length} duplicate(s); added ${addedLessons.length} from bucket; repaired translations in ${repairedTranslationsInLessons} lesson(s); fixed ${fixedLessons} stuck lesson(s).`);
                 }
                 else {
                     console.log(`✅ Syllabus is already in sync. No changes.`);
@@ -3489,6 +3514,7 @@ class ServeCommand extends SessionCommand_1.default {
                     removedLessons: removedLessons.length,
                     duplicatesResolved: duplicatesRemoved.length,
                     addedLessons: addedLessons.length,
+                    fixedLessons,
                     repairedTranslationsInLessons,
                     repairedTranslationEntries,
                     removed: removedLessons,

package/lib/utils/export/scorm.js

@@ -9,7 +9,7 @@ const rimraf = require("rimraf");
 const uuid_1 = require("uuid");
 const shared_1 = require("./shared");
 async function exportToScorm(options) {
-    var _a, _b;
+    var _a;
     const { courseSlug, bucket, outDir } = options;
     // 1. Create temporary folder
     const tmpName = (0, uuid_1.v4)();
@@ -22,23 +22,24 @@ async function exportToScorm(options) {
     // Paths
     const appDir = path.resolve(__dirname, "../../ui/_app");
     const configDir = path.join(scormOutDir, "config");
-    // Check if _app exists and has content
-    if (fs.existsSync(appDir) && fs.readdirSync(appDir).length > 0) {
-        // Copy app.css and app.js to config/
-        for (const file of ["app.css", "app.js"]) {
-            const src = path.join(appDir, file);
-            const dest = path.join(configDir, file);
-            if (fs.existsSync(src)) {
-                fs.copyFileSync(src, dest);
-            }
+    // Copy the IDE bundle. app.js/app.css are declared as required files in the
+    // manifest, so their absence must be a hard error (otherwise we would ship a
+    // broken, blank package that references non-existent files).
+    for (const file of ["app.css", "app.js"]) {
+        const src = path.join(appDir, file);
+        const dest = path.join(configDir, file);
+        if (!fs.existsSync(src)) {
+            throw new Error(`SCORM export failed: IDE bundle (${file}) not found in ${appDir}. ` +
+                "Ensure the editor was downloaded/extracted before exporting.");
         }
-        // Copy logo-192.png and logo-512.png to SCORM build root
-        for (const file of ["logo-192.png", "logo-512.png"]) {
-            const src = path.join(appDir, file);
-            const dest = path.join(scormOutDir, file);
-            if (fs.existsSync(src)) {
-                fs.copyFileSync(src, dest);
-            }
+        fs.copyFileSync(src, dest);
+    }
+    // Copy logo-192.png and logo-512.png to SCORM build root (optional assets)
+    for (const file of ["logo-192.png", "logo-512.png"]) {
+        const src = path.join(appDir, file);
+        const dest = path.join(scormOutDir, file);
+        if (fs.existsSync(src)) {
+            fs.copyFileSync(src, dest);
         }
     }
     // 3. Download exercises and .learn from bucket
@@ -46,26 +47,27 @@ async function exportToScorm(options) {
     await (0, shared_1.downloadS3Folder)(bucket, `courses/${courseSlug}/.learn/`, path.join(scormOutDir, ".learn"));
     // 4. Read learn.json for course info
     const learnJson = await (0, shared_1.getCourseMetadata)(bucket, courseSlug);
+    // Resolve the course title once, escaped for safe XML/HTML embedding
+    const courseTitle = (0, shared_1.escapeXml)(((_a = learnJson.title) === null || _a === void 0 ? void 0 : _a.en) || learnJson.title || courseSlug);
     // 5. Replace imsmanifest.xml
     const manifestPath = path.join(scormOutDir, "imsmanifest.xml");
     let manifest = fs.readFileSync(manifestPath, "utf-8");
-    manifest = manifest.replace(/{{organization_name}}/g, "FourGeeksAcademy");
-    manifest = manifest.replace(/{{course_title}}/g, ((_a = learnJson.title) === null || _a === void 0 ? void 0 : _a.en) || learnJson.title || courseSlug);
+    manifest = manifest.replace(/{{organization_name}}/g, (0, shared_1.escapeXml)("FourGeeksAcademy"));
+    manifest = manifest.replace(/{{course_title}}/g, courseTitle);
     // Generate exercises list
     const exercisesList = (0, shared_1.getFilesList)(path.join(scormOutDir, "exercises"), "exercises").join("\n      ");
     manifest = manifest.replace(/{{exercises_list}}/g, exercisesList);
-    // Generate images list (optional, if you have assets)
-    let imagesList = "";
-    const assetsDir = path.join(scormOutDir, ".learn", "assets");
-    if (fs.existsSync(assetsDir)) {
-        imagesList = (0, shared_1.getFilesList)(assetsDir, ".learn/assets").join("\n      ");
-    }
-    manifest = manifest.replace(/{{images_list}}/g, imagesList);
+    // Declare all .learn/ files (config.json + assets) that ship in the package
+    const learnDir = path.join(scormOutDir, ".learn");
+    const learnFilesList = fs.existsSync(learnDir)
+        ? (0, shared_1.getFilesList)(learnDir, ".learn").join("\n      ")
+        : "";
+    manifest = manifest.replace(/{{learn_files_list}}/g, learnFilesList);
     fs.writeFileSync(manifestPath, manifest, "utf-8");
     // 6. Replace title in config/index.html
     const configIndexPath = path.join(scormOutDir, "config", "index.html");
     let indexHtml = fs.readFileSync(configIndexPath, "utf-8");
-    indexHtml = indexHtml.replace(/{{title}}/g, ((_b = learnJson.title) === null || _b === void 0 ? void 0 : _b.en) || learnJson.title || courseSlug);
+    indexHtml = indexHtml.replace(/{{title}}/g, courseTitle);
     fs.writeFileSync(configIndexPath, indexHtml, "utf-8");
     // 7. Compress as ZIP
     const zipPath = `${scormOutDir}.zip`;

package/lib/utils/export/shared.d.ts

@@ -1,3 +1,4 @@
+export declare function escapeXml(value: string): string;
 export declare function copyDir(src: string, dest: string): void;
 export declare function downloadS3Folder(bucket: any, prefix: string, localPath: string): Promise<void>;
 export declare function getFilesList(folder: string, base: string): string[];

package/lib/utils/export/shared.js

@@ -1,5 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.escapeXml = escapeXml;
 exports.copyDir = copyDir;
 exports.downloadS3Folder = downloadS3Folder;
 exports.getFilesList = getFilesList;
@@ -7,6 +8,15 @@ exports.getCourseMetadata = getCourseMetadata;
 const path = require("path");
 const fs = require("fs");
 const mkdirp = require("mkdirp");
+// Escape a string so it can be safely embedded inside XML text or attributes
+function escapeXml(value) {
+    return String(value)
+        .replace(/&/g, "&")
+        .replace(/</g, "&lt;")
+        .replace(/>/g, "&gt;")
+        .replace(/"/g, "&quot;")
+        .replace(/'/g, "&apos;");
+}
 // Utility function to copy directory recursively
 function copyDir(src, dest) {
     if (!fs.existsSync(dest))
@@ -47,7 +57,7 @@ function getFilesList(folder, base) {
             list = list.concat(getFilesList(filePath, path.join(base, file.name)));
         }
         else {
-            list.push(`<file href="${path.join(base, file.name).replace(/\\/g, "/")}" />`);
+            list.push(`<file href="${escapeXml(path.join(base, file.name).replace(/\\/g, "/"))}" />`);
         }
     }
     return list;

package/lib/utils/templates/scorm/config/api.js

@@ -109,6 +109,35 @@ function ScormProcessFinish() {
   }
 }
 
+function ScormProcessCommit() {
+  var result;
+
+  if (initialized == false || finishCalled == true) {
+    return;
+  }
+
+  result = API.LMSCommit("");
+
+  if (result == SCORM_FALSE) {
+    var errorNumber = API.LMSGetLastError();
+    var errorString = API.LMSGetErrorString(errorNumber);
+    var diagnostic = API.LMSGetDiagnostic(errorNumber);
+
+    var errorDescription =
+      "Number: " +
+      errorNumber +
+      "\nDescription: " +
+      errorString +
+      "\nDiagnostic: " +
+      diagnostic;
+
+    alert(
+      "Error - Could not persist data to the LMS.\n\nYour results may not be recorded.\n\n" +
+        errorDescription
+    );
+  }
+}
+
 function ScormProcessGetValue(element) {
   var result;
 

package/lib/utils/templates/scorm/imsmanifest.xml

@@ -25,13 +25,12 @@
 
       {{exercises_list}}
 
-      {{images_list}}
+      {{learn_files_list}}
 
       <file href="config/index.html" />
       <file href="config/api.js" />
       <file href="config/app.js" />
       <file href="config/app.css" />
-      <file href="config/config.json" />
 
     </resource>
   </resources>

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@learnpack/learnpack",
   "description": "Seamlessly build, sell and/or take interactive & auto-graded tutorials, start learning now or build a new tutorial to your audience.",
-  "version": "5.0.347",
+  "version": "5.0.349",
   "author": "Alejandro Sanchez @alesanchezr",
   "contributors": [
     {

package/src/commands/serve.ts

@@ -4741,6 +4741,7 @@ class ServeCommand extends SessionCommand {
         }> = []
         let repairedTranslationsInLessons = 0
         let repairedTranslationEntries = 0
+        let fixedLessons = 0
 
         console.log(
           `📋 Checking ${syllabus.lessons.length} lessons in syllabus...`
@@ -4983,6 +4984,35 @@ class ServeCommand extends SessionCommand {
               repairedTranslationsInLessons += 1
             }
           }
+
+          // Fifth pass: fix lessons stuck in GENERATING or ERROR when the file exists in the bucket
+          const primaryLanguage = syllabus.courseInfo.language || "en"
+          for (const lesson of syllabus.lessons) {
+            if (lesson.generated !== false) continue
+            if (lesson.status !== "GENERATING" && lesson.status !== "ERROR")
+              continue
+
+            const candidateSlugs = [
+              slugify(lesson.id + "-" + lesson.title),
+              lesson.uid,
+            ].filter(Boolean) as string[]
+
+            const matchedSlug = candidateSlugs.find(s =>
+              translationsBySlug.has(s)
+            )
+            if (!matchedSlug) continue
+
+            const langs = translationsBySlug.get(matchedSlug) || []
+            if (!langs.includes(primaryLanguage)) continue
+
+            const prevStatus = lesson.status
+            lesson.generated = true
+            lesson.status = "DONE"
+            fixedLessons += 1
+            console.log(
+              `🔧 Fixed lesson: ${lesson.id} - "${lesson.title}" (was generated:false status:${prevStatus}, primary language "${primaryLanguage}" exists in bucket)`
+            )
+          }
         } catch (error) {
           console.error(
             "⚠️ Could not reconcile lesson translations during syllabus sync:",
@@ -4993,11 +5023,12 @@ class ServeCommand extends SessionCommand {
         if (
           totalRemoved > 0 ||
           addedLessons.length > 0 ||
-          repairedTranslationsInLessons > 0
+          repairedTranslationsInLessons > 0 ||
+          fixedLessons > 0
         ) {
           await saveSyllabus(courseSlug, syllabus, bucket)
           console.log(
-            `✅ Syllabus synchronized. Removed ${removedLessons.length} non-existent, ${duplicatesRemoved.length} duplicate(s); added ${addedLessons.length} from bucket; repaired translations in ${repairedTranslationsInLessons} lesson(s).`
+            `✅ Syllabus synchronized. Removed ${removedLessons.length} non-existent, ${duplicatesRemoved.length} duplicate(s); added ${addedLessons.length} from bucket; repaired translations in ${repairedTranslationsInLessons} lesson(s); fixed ${fixedLessons} stuck lesson(s).`
           )
         } else {
           console.log(`✅ Syllabus is already in sync. No changes.`)
@@ -5011,6 +5042,7 @@ class ServeCommand extends SessionCommand {
           removedLessons: removedLessons.length,
           duplicatesResolved: duplicatesRemoved.length,
           addedLessons: addedLessons.length,
+          fixedLessons,
           repairedTranslationsInLessons,
           repairedTranslationEntries,
           removed: removedLessons,