@learnpack/learnpack 2.1.54 → 2.1.56

package/README.md

@@ -21,7 +21,7 @@ $ npm install -g @learnpack/learnpack
 $ learnpack COMMAND
 running command...
 $ learnpack (-v|--version|version)
-@learnpack/learnpack/2.1.54 win32-x64 node-v20.10.0
+@learnpack/learnpack/2.1.56 win32-x64 node-v20.10.0
 $ learnpack --help [COMMAND]
 USAGE
   $ learnpack COMMAND
@@ -74,7 +74,7 @@ DESCRIPTION
        12. If there is a file within the exercises folder but not inside of any particular exercise's folder. (Warning)
 ```
 
-_See code: [src\commands\audit.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.54/src\commands\audit.ts)_
+_See code: [src\commands\audit.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.56/src\commands\audit.ts)_
 
 ## `learnpack clean`
 
@@ -89,7 +89,7 @@ DESCRIPTION
      Extra documentation goes here
 ```
 
-_See code: [src\commands\clean.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.54/src\commands\clean.ts)_
+_See code: [src\commands\clean.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.56/src\commands\clean.ts)_
 
 ## `learnpack download [PACKAGE]`
 
@@ -107,7 +107,7 @@ DESCRIPTION
   Extra documentation goes here
 ```
 
-_See code: [src\commands\download.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.54/src\commands\download.ts)_
+_See code: [src\commands\download.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.56/src\commands\download.ts)_
 
 ## `learnpack help [COMMAND]`
 
@@ -138,7 +138,7 @@ OPTIONS
   -h, --grading  show CLI help
 ```
 
-_See code: [src\commands\init.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.54/src\commands\init.ts)_
+_See code: [src\commands\init.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.56/src\commands\init.ts)_
 
 ## `learnpack login [PACKAGE]`
 
@@ -156,7 +156,7 @@ DESCRIPTION
      Extra documentation goes here
 ```
 
-_See code: [src\commands\login.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.54/src\commands\login.ts)_
+_See code: [src\commands\login.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.56/src\commands\login.ts)_
 
 ## `learnpack logout [PACKAGE]`
 
@@ -174,7 +174,7 @@ DESCRIPTION
      Extra documentation goes here
 ```
 
-_See code: [src\commands\logout.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.54/src\commands\logout.ts)_
+_See code: [src\commands\logout.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.56/src\commands\logout.ts)_
 
 ## `learnpack plugins`
 
@@ -309,7 +309,7 @@ DESCRIPTION
      Extra documentation goes here
 ```
 
-_See code: [src\commands\publish.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.54/src\commands\publish.ts)_
+_See code: [src\commands\publish.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.56/src\commands\publish.ts)_
 
 ## `learnpack start`
 
@@ -330,7 +330,7 @@ OPTIONS
   -w, --watch                         Watch for file changes
 ```
 
-_See code: [src\commands\start.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.54/src\commands\start.ts)_
+_See code: [src\commands\start.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.56/src\commands\start.ts)_
 
 ## `learnpack test [EXERCISESLUG]`
 
@@ -344,7 +344,7 @@ ARGUMENTS
   EXERCISESLUG  The name of the exercise to test
 ```
 
-_See code: [src\commands\test.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.54/src\commands\test.ts)_
+_See code: [src\commands\test.ts](https://github.com/learnpack/learnpack-cli/blob/v2.1.56/src\commands\test.ts)_
 <!-- commandsstop -->
 
 > > > > > > > 0cb3e56d84c197f9d008836bb573eade212b7e57

package/lib/commands/start.js

@@ -166,26 +166,33 @@ class StartCommand extends SessionCommand_1.default {
                         exercise,
                         telemetry: telemetry_1.default,
                     });
-                    // Check if ${configObject.dirPath}/reports/${exercise.slug}/report.md or /reports/${exercise.slug}/report.txt exists
-                    // If it does, then send the content of the file to the frontend
-                    // If it doesn't, then send an empty object
-                    if (!configObject.config) {
-                        return;
-                    }
-                    const markdownReportPath = path.join(configObject.config.dirPath, "reports", `${exercise.slug}`, "report.md");
-                    const textReportPath = path.join(configObject.config.dirPath, "reports", `${exercise.slug}`, "report.txt");
-                    const reportExists = fs.existsSync(markdownReportPath) || fs.existsSync(textReportPath);
-                    if (reportExists) {
-                        try {
-                            const reportContent = 
-                            // fs.readFileSync(markdownReportPath, "utf8") ||
-                            fs.readFileSync(textReportPath, "utf8");
+                    try {
+                        if (!configObject.config) {
+                            return;
+                        }
+                        const getReportPath = (ext) => {
+                            var _a;
+                            if (!((_a = configObject.config) === null || _a === void 0 ? void 0 : _a.dirPath)) {
+                                throw new Error("No directory path found in config");
+                            }
+                            return path.join(configObject.config.dirPath, "reports", `${exercise.slug}`, `report.${ext}`);
+                        };
+                        const markdownReportPath = getReportPath("md");
+                        const textReportPath = getReportPath("txt");
+                        if (fs.existsSync(markdownReportPath)) {
+                            let reportContent = "";
+                            reportContent = fs.readFileSync(markdownReportPath, "utf8");
                             socket_1.default.dialog(reportContent);
                         }
-                        catch (error) {
-                            console.log(error);
+                        if (fs.existsSync(textReportPath)) {
+                            let reportContent = "";
+                            reportContent = fs.readFileSync(textReportPath, "utf8");
+                            socket_1.default.dialog(reportContent);
                         }
                     }
+                    catch (error) {
+                        console_1.default.debug("Error finding report for exercise.slug", error);
+                    }
                     (_b = this.configManager) === null || _b === void 0 ? void 0 : _b.save();
                     return true;
                 });

package/lib/managers/socket.js

@@ -151,7 +151,10 @@ const SocketManager = {
             this.log((type + "-success"), [stdout]);
     },
     error: function (type, stdout) {
-        fileQueue_1.default.dispatcher().enqueue(fileQueue_1.default.events.OPEN_TERMINAL, "");
+        var _a;
+        if (!((_a = this.config) === null || _a === void 0 ? void 0 : _a.editor.hideTerminal)) {
+            fileQueue_1.default.dispatcher().enqueue(fileQueue_1.default.events.OPEN_TERMINAL, "");
+        }
         this.log(type, [stdout]);
         if (this.isTestingEnvironment) {
             this.onTestingFinished({

package/lib/models/config.d.ts

@@ -13,6 +13,7 @@ export interface IEditor {
     mode?: TMode;
     version: string;
     agent?: TAgent;
+    hideTerminal?: boolean;
 }
 export interface TEntries {
     python3?: string;

package/oclif.manifest.json

@@ -1 +1 @@
-{"version":"2.1.54","commands":{"audit":{"id":"audit","description":"learnpack audit is the command in charge of creating an auditory of the repository\n...\nlearnpack audit checks for the following information in a repository:\n    1. The configuration object has slug, repository and description. (Error)\n    2. The command learnpack clean has been run. (Error)\n    3. If a markdown or test file doesn't have any content. (Error)\n    4. The links are accessing to valid servers. (Error)\n    5. The relative images are working (If they have the shortest path to the image or if the images exists in the assets). (Error)\n    6. The external images are working (If they are pointing to a valid server). (Error)\n    7. The exercises directory names are valid. (Error)\n    8. If an exercise doesn't have a README file. (Error)\n    9. The exercises array (Of the config file) has content. (Error)\n    10. The exercses have the same translations. (Warning)\n    11. The .gitignore file exists. (Warning)\n    12. If there is a file within the exercises folder but not inside of any particular exercise's folder. (Warning)\n","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[]},"clean":{"id":"clean","description":"Clean the configuration object\n  ...\n  Extra documentation goes here\n  ","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[]},"download":{"id":"download","description":"Describe the command here\n...\nExtra documentation goes here\n","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[{"name":"package","description":"The unique string that identifies this package on learnpack","required":false,"hidden":false}]},"init":{"id":"init","description":"Create a new learning package: Book, Tutorial or Exercise","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{"grading":{"name":"grading","type":"boolean","char":"h","description":"show CLI help","allowNo":false}},"args":[]},"login":{"id":"login","description":"Describe the command here\n  ...\n  Extra documentation goes here\n  ","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[{"name":"package","description":"The unique string that identifies this package on learnpack","required":false,"hidden":false}]},"logout":{"id":"logout","description":"Describe the command here\n  ...\n  Extra documentation goes here\n  ","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[{"name":"package","description":"The unique string that identifies this package on learnpack","required":false,"hidden":false}]},"publish":{"id":"publish","description":"Describe the command here\n  ...\n  Extra documentation goes here\n  ","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[{"name":"package","description":"The unique string that identifies this package on learnpack","required":false,"hidden":false}]},"start":{"id":"start","description":"Runs a small server with all the exercise instructions","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{"port":{"name":"port","type":"option","char":"p","description":"server port"},"host":{"name":"host","type":"option","char":"h","description":"server host"},"disableGrading":{"name":"disableGrading","type":"boolean","char":"D","description":"disble grading functionality","allowNo":false},"watch":{"name":"watch","type":"boolean","char":"w","description":"Watch for file changes","allowNo":false},"editor":{"name":"editor","type":"option","char":"e","description":"[preview, extension]","options":["extension","preview"]},"version":{"name":"version","type":"option","char":"v","description":"E.g: 1.0.1"},"grading":{"name":"grading","type":"option","char":"g","description":"[isolated, incremental]","options":["isolated","incremental"]},"debug":{"name":"debug","type":"boolean","char":"d","description":"debugger mode for more verbage","allowNo":false}},"args":[]},"test":{"id":"test","description":"Test exercises","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[{"name":"exerciseSlug","description":"The name of the exercise to test","required":false,"hidden":false}]}}}
+{"version":"2.1.56","commands":{"audit":{"id":"audit","description":"learnpack audit is the command in charge of creating an auditory of the repository\n...\nlearnpack audit checks for the following information in a repository:\n    1. The configuration object has slug, repository and description. (Error)\n    2. The command learnpack clean has been run. (Error)\n    3. If a markdown or test file doesn't have any content. (Error)\n    4. The links are accessing to valid servers. (Error)\n    5. The relative images are working (If they have the shortest path to the image or if the images exists in the assets). (Error)\n    6. The external images are working (If they are pointing to a valid server). (Error)\n    7. The exercises directory names are valid. (Error)\n    8. If an exercise doesn't have a README file. (Error)\n    9. The exercises array (Of the config file) has content. (Error)\n    10. The exercses have the same translations. (Warning)\n    11. The .gitignore file exists. (Warning)\n    12. If there is a file within the exercises folder but not inside of any particular exercise's folder. (Warning)\n","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[]},"clean":{"id":"clean","description":"Clean the configuration object\n  ...\n  Extra documentation goes here\n  ","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[]},"download":{"id":"download","description":"Describe the command here\n...\nExtra documentation goes here\n","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[{"name":"package","description":"The unique string that identifies this package on learnpack","required":false,"hidden":false}]},"init":{"id":"init","description":"Create a new learning package: Book, Tutorial or Exercise","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{"grading":{"name":"grading","type":"boolean","char":"h","description":"show CLI help","allowNo":false}},"args":[]},"login":{"id":"login","description":"Describe the command here\n  ...\n  Extra documentation goes here\n  ","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[{"name":"package","description":"The unique string that identifies this package on learnpack","required":false,"hidden":false}]},"logout":{"id":"logout","description":"Describe the command here\n  ...\n  Extra documentation goes here\n  ","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[{"name":"package","description":"The unique string that identifies this package on learnpack","required":false,"hidden":false}]},"publish":{"id":"publish","description":"Describe the command here\n  ...\n  Extra documentation goes here\n  ","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[{"name":"package","description":"The unique string that identifies this package on learnpack","required":false,"hidden":false}]},"start":{"id":"start","description":"Runs a small server with all the exercise instructions","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{"port":{"name":"port","type":"option","char":"p","description":"server port"},"host":{"name":"host","type":"option","char":"h","description":"server host"},"disableGrading":{"name":"disableGrading","type":"boolean","char":"D","description":"disble grading functionality","allowNo":false},"watch":{"name":"watch","type":"boolean","char":"w","description":"Watch for file changes","allowNo":false},"editor":{"name":"editor","type":"option","char":"e","description":"[preview, extension]","options":["extension","preview"]},"version":{"name":"version","type":"option","char":"v","description":"E.g: 1.0.1"},"grading":{"name":"grading","type":"option","char":"g","description":"[isolated, incremental]","options":["isolated","incremental"]},"debug":{"name":"debug","type":"boolean","char":"d","description":"debugger mode for more verbage","allowNo":false}},"args":[]},"test":{"id":"test","description":"Test exercises","pluginName":"@learnpack/learnpack","pluginType":"core","aliases":[],"flags":{},"args":[{"name":"exerciseSlug","description":"The name of the exercise to test","required":false,"hidden":false}]}}}

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@learnpack/learnpack",
   "description": "Create, sell or download and take learning amazing learning packages",
-  "version": "2.1.54",
+  "version": "2.1.56",
   "author": "Alejandro Sanchez @alesanchezr",
   "contributors": [
     {

package/src/commands/start.ts

@@ -289,37 +289,40 @@ export default class StartCommand extends SessionCommand {
             telemetry: TelemetryManager,
           })
 
-          // Check if ${configObject.dirPath}/reports/${exercise.slug}/report.md or /reports/${exercise.slug}/report.txt exists
-          // If it does, then send the content of the file to the frontend
-          // If it doesn't, then send an empty object
+          try {
+            if (!configObject.config) {
+              return
+            }
 
-          if (!configObject.config) {
-            return
-          }
+            const getReportPath = (ext: string) => {
+              if (!configObject.config?.dirPath) {
+                throw new Error("No directory path found in config")
+              }
+
+              return path.join(
+                configObject.config.dirPath,
+                "reports",
+                `${exercise.slug}`,
+                `report.${ext}`
+              )
+            }
 
-          const markdownReportPath = path.join(
-            configObject.config.dirPath,
-            "reports",
-            `${exercise.slug}`,
-            "report.md"
-          )
-          const textReportPath = path.join(
-            configObject.config.dirPath,
-            "reports",
-            `${exercise.slug}`,
-            "report.txt"
-          )
-          const reportExists =
-            fs.existsSync(markdownReportPath) || fs.existsSync(textReportPath)
-          if (reportExists) {
-            try {
-              const reportContent =
-                // fs.readFileSync(markdownReportPath, "utf8") ||
-                fs.readFileSync(textReportPath, "utf8")
+            const markdownReportPath = getReportPath("md")
+            const textReportPath = getReportPath("txt")
+
+            if (fs.existsSync(markdownReportPath)) {
+              let reportContent = ""
+              reportContent = fs.readFileSync(markdownReportPath, "utf8")
+              socket.dialog(reportContent)
+            }
+
+            if (fs.existsSync(textReportPath)) {
+              let reportContent = ""
+              reportContent = fs.readFileSync(textReportPath, "utf8")
               socket.dialog(reportContent)
-            } catch (error) {
-              console.log(error)
             }
+          } catch (error) {
+            Console.debug("Error finding report for exercise.slug", error)
           }
 
           this.configManager?.save()

package/src/managers/socket.ts

@@ -224,7 +224,10 @@ actions = [actions]
 this.log((type + "-success") as TSuccessType, [stdout])
   },
   error: function (type: TStatus, stdout: string) {
-    queue.dispatcher().enqueue(queue.events.OPEN_TERMINAL, "")
+    if (!this.config?.editor.hideTerminal) {
+      queue.dispatcher().enqueue(queue.events.OPEN_TERMINAL, "")
+    }
+
     this.log(type, [stdout])
 
     if (this.isTestingEnvironment) {

package/src/models/config.ts

@@ -1,91 +1,93 @@
-import { IExercise } from "./exercise-obj"
-import { TTelemetryUrls } from "../managers/telemetry"
-
-export type TGrading = "isolated" | "incremental" | "no-grading";
-
-export type TMode = "preview" | "extension";
-
-export type TConfigAction =
-  | "test"
-  | "build"
-  | "tutorial"
-  | "reset"
-  | "generate";
-
-export type TConfigObjAttributes = "config" | "exercises" | "grading";
-
-export type TCompiler =
-  | "webpack"
-  | "vanillajs"
-  | "react"
-  | "html"
-  | "node"
-  | "python"
-  | "css";
-
-export interface IConfigPath {
-  base: string;
-}
-
-type TAgent = "vscode" | "os";
-
-export interface IEditor {
-  mode?: TMode;
-  version: string;
-  agent?: TAgent;
-}
-
-export interface TEntries {
-  python3?: string;
-  html?: string;
-  node?: string;
-  react?: string;
-  java?: string;
-}
-
-export interface IConfig {
-  os: string;
-  port?: string;
-  repository?: string;
-  description?: string;
-  slug?: string;
-  dirPath: string;
-  preview?: string; // Picture thumbnail
-  entries: TEntries;
-  grading: TGrading;
-  configPath: string;
-  translations: Array<string>;
-  outputPath?: string;
-  editor: IEditor;
-  language: string;
-  title: string;
-  duration: number;
-  difficulty?: string;
-  exercisesPath: string;
-  disableGrading: boolean; // TODO: Deprecate
-  actions: Array<string>; // TODO: Deprecate
-  autoPlay: boolean;
-  projectType?: string;
-  // TODO: nameExerciseValidation
-  contact?: string;
-  disabledActions?: Array<TConfigAction>;
-  compiler: TCompiler;
-  compilers: Array<TCompiler>;
-  publicPath: string;
-  publicUrl?: string;
-  bugsLink?: string;
-  videoSolutions?: boolean;
-  skills: Array<string>;
-  telemetry?: TTelemetryUrls;
-  runHook: (...agrs: Array<any>) => void;
-  testingFinishedCallback: (arg: any | undefined) => void;
-}
-
-export interface IConfigObj {
-  session?: number;
-  currentExercise?: any;
-  config?: IConfig;
-  exercises?: Array<IExercise>;
-  confPath?: IConfigPath;
-  address?: string; // Maybe
-}
+import { IExercise } from "./exercise-obj"
+import { TTelemetryUrls } from "../managers/telemetry"
+
+export type TGrading = "isolated" | "incremental" | "no-grading";
+
+export type TMode = "preview" | "extension";
+
+export type TConfigAction =
+  | "test"
+  | "build"
+  | "tutorial"
+  | "reset"
+  | "generate";
+
+export type TConfigObjAttributes = "config" | "exercises" | "grading";
+
+export type TCompiler =
+  | "webpack"
+  | "vanillajs"
+  | "react"
+  | "html"
+  | "node"
+  | "python"
+  | "css";
+
+export interface IConfigPath {
+  base: string;
+}
+
+type TAgent = "vscode" | "os";
+
+export interface IEditor {
+  mode?: TMode;
+  version: string;
+  agent?: TAgent;
+  hideTerminal?: boolean;
+}
+
+export interface TEntries {
+  python3?: string;
+  html?: string;
+  node?: string;
+  react?: string;
+  java?: string;
+}
+
+export interface IConfig {
+  os: string;
+  port?: string;
+  repository?: string;
+  description?: string;
+  slug?: string;
+  dirPath: string;
+  preview?: string; // Picture thumbnail
+  entries: TEntries;
+  grading: TGrading;
+  configPath: string;
+  translations: Array<string>;
+  outputPath?: string;
+  editor: IEditor;
+  language: string;
+  title: string;
+  duration: number;
+  difficulty?: string;
+  exercisesPath: string;
+  disableGrading: boolean; // TODO: Deprecate
+  actions: Array<string>; // TODO: Deprecate
+  autoPlay: boolean;
+  projectType?: string;
+  // TODO: nameExerciseValidation
+  contact?: string;
+  disabledActions?: Array<TConfigAction>;
+  compiler: TCompiler;
+  compilers: Array<TCompiler>;
+  publicPath: string;
+  publicUrl?: string;
+  bugsLink?: string;
+  videoSolutions?: boolean;
+  skills: Array<string>;
+  telemetry?: TTelemetryUrls;
+
+  runHook: (...agrs: Array<any>) => void;
+  testingFinishedCallback: (arg: any | undefined) => void;
+}
+
+export interface IConfigObj {
+  session?: number;
+  currentExercise?: any;
+  config?: IConfig;
+  exercises?: Array<IExercise>;
+  confPath?: IConfigPath;
+  address?: string; // Maybe
+}