@learncard/network-brain-service 3.19.0 → 4.0.0

package/src/routes/boosts.ts

@@ -115,6 +115,7 @@ import {
     prepareCredentialFromBoost,
     appendTemplateEvidenceToCredential,
 } from '@helpers/boost.helpers';
+import { setCredentialSubjectIds } from '@helpers/credentialSubject.helpers';
 import {
     BoostValidator,
     BoostGenerateClaimLinkInput,
@@ -1865,6 +1866,7 @@ export const boostsRouter = t.router({
                                 });
                             }
 
+                            // encrypt=false on purpose: the federated receiving server may not accept LearnCard JWEs. See LC-2201.
                             signedVc = await traceInternal(
                                 'issueCredentialWithSigningAuthority:remoteInbox',
                                 async () =>
@@ -1998,7 +2000,7 @@ export const boostsRouter = t.router({
                         contractUri,
                     });
 
-                    let signedVc: VC | JWE;
+                    let signedVc: VC | JWE | IssuedCredential;
 
                     if (input.signedCredential) {
                         signedVc = input.signedCredential;
@@ -2038,19 +2040,16 @@ export const boostsRouter = t.router({
                         signedVc = await traceInternal(
                             'issueCredentialWithSigningAuthority',
                             async () =>
-                                (
-                                    await issueCredentialWithSigningAuthority(
-                                        { type: 'profile', profile },
-                                        await appendBitstringStatusListEntries(
-                                            unsignedVc,
-                                            profile.profileId,
-                                            domain
-                                        ),
-                                        signingAuthority,
-                                        domain,
-                                        false
-                                    )
-                                ).credential
+                                issueCredentialWithSigningAuthority(
+                                    { type: 'profile', profile },
+                                    await appendBitstringStatusListEntries(
+                                        unsignedVc,
+                                        profile.profileId,
+                                        domain
+                                    ),
+                                    signingAuthority,
+                                    domain
+                                )
                         );
                     }
 
@@ -4549,17 +4548,7 @@ export const boostsRouter = t.router({
                 }
                 unsignedVc.issuer = { id: getDidWeb(ctx.domain, profile.profileId) };
 
-                if (Array.isArray(unsignedVc.credentialSubject)) {
-                    unsignedVc.credentialSubject = unsignedVc.credentialSubject.map(subject => ({
-                        ...subject,
-                        id: getDidWeb(ctx.domain, targetProfile.profileId),
-                    }));
-                } else {
-                    unsignedVc.credentialSubject = {
-                        ...unsignedVc.credentialSubject,
-                        id: getDidWeb(ctx.domain, targetProfile.profileId),
-                    };
-                }
+                setCredentialSubjectIds(unsignedVc, getDidWeb(ctx.domain, targetProfile.profileId));
                 if (unsignedVc?.type?.includes('BoostCredential')) unsignedVc.boostId = boostUri;
                 // Inject OBv3 skill alignments based on boost's framework/skills
                 await injectObv3AlignmentsIntoCredentialForBoost(unsignedVc, boost, ctx.domain);