@leancodepl/eslint-config 9.7.2 → 9.7.3

package/CHANGELOG.md

@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file. See
 [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [9.7.3](https://github.com/leancodepl/js_corelibrary/compare/v9.7.2...v9.7.3) (2026-02-10)
+
+### Features
+
+- add eslint unicorn rules
+  ([0c821f2](https://github.com/leancodepl/js_corelibrary/commit/0c821f20f0f7e667c1616161a173e7501baa94cb))
+
+# Change Log
+
+All notable changes to this project will be documented in this file. See
+[Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+
 ## [9.7.2](https://github.com/leancodepl/js_corelibrary/compare/v9.7.1...v9.7.2) (2026-01-20)
 
 **Note:** Version bump only for package @leancodepl/eslint-config

package/README.md

@@ -45,3 +45,32 @@ export default [
   },
 ]
 ```
+
+## Migration from CommonJS to ES Modules
+
+Starting from 10.0.0 version, the package is built as an ES Module. If your ESLint configuration currently uses CommonJS
+syntax, follow these steps to migrate:
+
+- Rename `eslint.config.js` to `eslint.config.mjs` (if your `package.json` does not have `"type": "module"`)
+- Convert `require` statements to `import` syntax
+- Replace CommonJS variables like `__dirname` with ES Module equivalents:
+
+  ```javascript
+  import { dirname } from "node:path"
+  import { fileURLToPath } from "node:url"
+
+  const __filename = fileURLToPath(import.meta.url)
+  const __dirname = dirname(__filename)
+
+  // or
+
+  const __filename = import.meta.filename
+  const __dirname = import.meta.dirname
+  ```
+
+- If importing a CommonJS package with named imports fails, import the default export and destructure separately:
+
+  ```javascript
+  import commonjsPackage from "commonjs-package"
+  const { someExport } = commonjsPackage
+  ```

package/package.json

@@ -1,20 +1,22 @@
 {
   "name": "@leancodepl/eslint-config",
-  "version": "9.7.2",
+  "version": "9.7.3",
   "license": "Apache-2.0",
+  "type": "module",
   "main": "src/index.js",
   "dependencies": {
-    "@leancodepl/eslint-plugin": "9.7.2",
+    "@leancodepl/eslint-plugin": "9.7.3",
     "eslint-plugin-import": ">=2.31.0",
     "eslint-plugin-jsx-a11y": ">=6.10.0",
-    "eslint-plugin-perfectionist": ">=4.0.0 <5.0.0",
+    "eslint-plugin-perfectionist": ">=5.0.0",
     "eslint-plugin-react-hooks": ">=5.2.0",
+    "eslint-plugin-unicorn": ">=62.0.0",
     "eslint-plugin-unused-imports": ">=4.1.0",
     "globals": ">=15.0.0"
   },
   "peerDependencies": {
     "@types/eslint-plugin-jsx-a11y": ">=6.10.0",
-    "eslint": ">=8.9.0",
+    "eslint": ">=9.20.0",
     "eslint-config-prettier": ">=9.1.0",
     "eslint-plugin-react": ">=7.34.1",
     "prettier": ">=3.0.0",
@@ -25,7 +27,7 @@
     "registry": "https://registry.npmjs.org/"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=22.0.0"
   },
   "repository": {
     "type": "git",

package/project.json

@@ -19,13 +19,6 @@
     "publish": {
       "command": "node tools/scripts/publish.mjs @leancodepl/eslint-config {args.registry} {args.ver} {args.tag}",
       "dependsOn": ["build"]
-    },
-    "test": {
-      "executor": "@nx/jest:jest",
-      "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
-      "options": {
-        "jestConfig": "packages/linters/eslint-config/jest.config.js"
-      }
     }
   }
 }

package/src/index.js

@@ -1,6 +1,4 @@
-const { a11y } = require("./lib/a11y.js")
-const { baseReact } = require("./lib/base-react.js")
-const { base } = require("./lib/base.js")
-const { imports } = require("./lib/imports.js")
-
-module.exports = { a11y, base, baseReact, imports }
+export { a11y } from "./lib/a11y.js"
+export { baseReact } from "./lib/base-react.js"
+export { base } from "./lib/base.js"
+export { imports } from "./lib/imports.js"

package/src/lib/a11y.js

@@ -1,10 +1,8 @@
-const jsxA11y = require("eslint-plugin-jsx-a11y")
+import jsxA11y from "eslint-plugin-jsx-a11y"
 
 /**
  * @typedef {import('@typescript-eslint/utils').TSESLint.FlatConfig.Config} Config
  */
 
 /** @type {Config[]} */
-const a11y = [jsxA11y.flatConfigs.recommended]
-
-module.exports = { a11y }
+export const a11y = [jsxA11y.flatConfigs.recommended]

package/src/lib/base-react.js

@@ -1,13 +1,13 @@
-const react = require("eslint-plugin-react")
-const reactHooks = require("eslint-plugin-react-hooks")
-const globals = require("globals")
+import react from "eslint-plugin-react"
+import reactHooks from "eslint-plugin-react-hooks"
+import globals from "globals"
 
 /**
  * @typedef {import('@typescript-eslint/utils').TSESLint.FlatConfig.Config} Config
  */
 
 /** @type {Config[]} */
-const baseReact = [
+export const baseReact = [
   {
     plugins: {
       react,
@@ -49,5 +49,3 @@ const baseReact = [
     },
   },
 ]
-
-module.exports = { baseReact }

package/src/lib/base.js

@@ -1,15 +1,16 @@
-const parser = require("@typescript-eslint/parser")
-const eslintConfigPrettier = require("eslint-config-prettier")
-const perfectionist = require("eslint-plugin-perfectionist")
-const tseslint = require("typescript-eslint")
-const { leancodePlugin } = require("@leancodepl/eslint-plugin")
+import eslintConfigPrettier from "eslint-config-prettier"
+import perfectionist from "eslint-plugin-perfectionist"
+import eslintPluginUnicorn from "eslint-plugin-unicorn"
+import globals from "globals"
+import tseslint from "typescript-eslint"
+import { leancodePlugin } from "@leancodepl/eslint-plugin"
 
 /**
  * @typedef {import('@typescript-eslint/utils').TSESLint.FlatConfig.Config} Config
  */
 
 /** @type {Config[]} */
-const base = [
+export const base = [
   {
     languageOptions: {
       parser: tseslint.parser,
@@ -72,7 +73,82 @@ const base = [
       ],
     },
   },
+  {
+    languageOptions: {
+      globals: globals.builtin,
+    },
+    plugins: {
+      unicorn: eslintPluginUnicorn,
+    },
+    rules: {
+      "unicorn/better-regex": "error",
+      "unicorn/catch-error-name": "error",
+      "unicorn/consistent-destructuring": "error",
+      "unicorn/consistent-existence-index-check": "error",
+      "unicorn/custom-error-definition": "error",
+      "unicorn/error-message": "error",
+      "unicorn/expiring-todo-comments": "error",
+      "unicorn/no-array-method-this-argument": "error",
+      "unicorn/no-array-reverse": "error",
+      "unicorn/no-array-sort": "error",
+      "unicorn/no-await-expression-member": "error",
+      "unicorn/no-await-in-promise-methods": "error",
+      "unicorn/no-document-cookie": "error",
+      "unicorn/no-immediate-mutation": "error",
+      "unicorn/no-instanceof-builtins": "error",
+      "unicorn/no-lonely-if": "error",
+      "unicorn/no-magic-array-flat-depth": "error",
+      "unicorn/no-negation-in-equality-check": "error",
+      "unicorn/no-nested-ternary": "error",
+      "unicorn/no-new-buffer": "error",
+      "unicorn/no-single-promise-in-promise-methods": "error",
+      "unicorn/no-static-only-class": "error",
+      "unicorn/no-unnecessary-array-flat-depth": "error",
+      "unicorn/no-useless-collection-argument": "error",
+      "unicorn/no-useless-fallback-in-spread": "error",
+      "unicorn/no-useless-promise-resolve-reject": "error",
+      "unicorn/no-useless-switch-case": "error",
+      "unicorn/no-useless-undefined": ["error", { checkArguments: false }],
+      "unicorn/no-zero-fractions": "error",
+      "unicorn/numeric-separators-style": [
+        "error",
+        {
+          number: {
+            minimumDigits: 6,
+          },
+        },
+      ],
+      "unicorn/prefer-array-flat-map": "error",
+      "unicorn/prefer-array-index-of": "error",
+      "unicorn/prefer-array-some": "error",
+      "unicorn/prefer-at": "error",
+      "unicorn/prefer-default-parameters": "error",
+      "unicorn/prefer-export-from": "error",
+      "unicorn/prefer-global-this": "error",
+      "unicorn/prefer-includes": "error",
+      "unicorn/prefer-logical-operator-over-ternary": "error",
+      "unicorn/prefer-math-min-max": "error",
+      "unicorn/prefer-negative-index": "error",
+      "unicorn/prefer-node-protocol": "error",
+      "unicorn/prefer-number-properties": "error",
+      "unicorn/prefer-object-from-entries": "error",
+      "unicorn/prefer-optional-catch-binding": "error",
+      "unicorn/prefer-regexp-test": "error",
+      "unicorn/prefer-set-has": "error",
+      "unicorn/prefer-set-size": "error",
+      "unicorn/prefer-single-call": "error",
+      "unicorn/prefer-spread": "error",
+      "unicorn/prefer-string-raw": "error",
+      "unicorn/prefer-string-replace-all": "error",
+      "unicorn/prefer-string-slice": "error",
+      "unicorn/prefer-structured-clone": "error",
+      "unicorn/prefer-switch": "error",
+      "unicorn/prefer-type-error": "error",
+      "unicorn/require-array-join-separator": "error",
+      "unicorn/require-number-to-fixed-digits-argument": "error",
+      "unicorn/template-indent": "error",
+      "unicorn/throw-new-error": "error",
+    },
+  },
   eslintConfigPrettier,
 ]
-
-module.exports = { base }

package/src/lib/imports.js

@@ -1,12 +1,12 @@
-const importsPlugin = require("eslint-plugin-import")
-const unusedImports = require("eslint-plugin-unused-imports")
+import importsPlugin from "eslint-plugin-import"
+import unusedImports from "eslint-plugin-unused-imports"
 
 /**
  * @typedef {import('@typescript-eslint/utils').TSESLint.FlatConfig.Config} Config
  */
 
 /** @type {Config[]} */
-const imports = [
+export const imports = [
   {
     plugins: {
       "unused-imports": unusedImports,
@@ -34,25 +34,32 @@ const imports = [
           order: "asc",
           groups: [
             "client-server-only",
+            "type-import",
             "react",
-            ["builtin", "external"],
-            ["internal-type", "internal"],
-            ["parent", "sibling", "index"],
-            ["type", "parent-type", "sibling-type", "index-type"],
+            ["value-builtin", "value-external"],
+            ["type-internal", "value-internal"],
+            ["type-parent", "type-sibling", "type-index"],
+            ["value-parent", "value-sibling", "value-index"],
             "side-effect",
             "style",
             "unknown",
           ],
-          customGroups: {
-            value: {
-              react: ["^react$", "^react-.+"],
-              "client-server-only": ["^client-only$", "^server-only$"],
+          customGroups: [
+            {
+              selector: "type",
+              groupName: "react",
+              elementNamePattern: "^react$",
             },
-            type: {
-              react: "^react$",
+            {
+              groupName: "react",
+              elementNamePattern: ["^react$", "^react-.+"],
             },
-          },
-          newlinesBetween: "never",
+            {
+              groupName: "client-server-only",
+              elementNamePattern: ["^client-only$", "^server-only$"],
+            },
+          ],
+          newlinesBetween: 0,
           internalPattern: ["^@leancodepl/.+"],
         },
       ],
@@ -76,5 +83,3 @@ const imports = [
     },
   },
 ]
-
-module.exports = { imports }

package/jest.config.js

@@ -1,8 +0,0 @@
-module.exports = {
-  displayName: "@leancodepl/eslint-config",
-  moduleFileExtensions: ["js"],
-  testEnvironment: "node",
-  coverageDirectory: "../../../coverage/packages/linters/eslint-config",
-  testMatch: ["<rootDir>/src/**/__tests__/**/*.spec.js"],
-  transform: {},
-}