@leanandmean/coding-agent 0.74.1-scramjet.7 → 0.74.1-scramjet.71

package/dist/core/extensions/runner.js

@@ -22,8 +22,18 @@ const RESERVED_KEYBINDINGS_FOR_EXTENSION_CONFLICTS = [
     "tui.select.confirm",
     "tui.select.cancel",
     "tui.input.copy",
+    "tui.viewport.pageUp",
+    "tui.viewport.pageDown",
     "tui.editor.deleteToLineEnd",
 ];
+function deepFreeze(value) {
+    Object.freeze(value);
+    for (const nested of Object.values(value)) {
+        if (nested && typeof nested === "object" && !Object.isFrozen(nested))
+            deepFreeze(nested);
+    }
+    return value;
+}
 const buildBuiltinKeybindings = (resolvedKeybindings) => {
     const builtinKeybindings = {};
     for (const [keybinding, keys] of Object.entries(resolvedKeybindings)) {
@@ -89,6 +99,7 @@ const noOpUIContext = {
     setFooter: () => { },
     setHeader: () => { },
     setTitle: () => { },
+    setTitleProvider: () => { },
     custom: async () => undefined,
     pasteToEditor: () => { },
     setEditorText: () => { },
@@ -115,6 +126,7 @@ export class ExtensionRunner {
     modelRegistry;
     errorListeners = new Set();
     getModel = () => undefined;
+    getScopedModelsFn = () => [];
     isIdleFn = () => true;
     getSignalFn = () => undefined;
     waitForIdleFn = async () => { };
@@ -173,6 +185,7 @@ export class ExtensionRunner {
         this.runtime.setThinkingLevel = actions.setThinkingLevel;
         // Context actions (required)
         this.getModel = contextActions.getModel;
+        this.getScopedModelsFn = contextActions.getScopedModels;
         this.isIdleFn = contextActions.isIdle;
         this.getSignalFn = contextActions.getSignal;
         this.abortFn = contextActions.abort;
@@ -421,6 +434,7 @@ export class ExtensionRunner {
     createContext() {
         const runner = this;
         const getModel = this.getModel;
+        const getScopedModels = this.getScopedModelsFn;
         return {
             get ui() {
                 runner.assertActive();
@@ -446,6 +460,10 @@ export class ExtensionRunner {
                 runner.assertActive();
                 return getModel();
             },
+            get scopedModels() {
+                runner.assertActive();
+                return getScopedModels();
+            },
             isIdle: () => {
                 runner.assertActive();
                 return runner.isIdleFn();
@@ -521,7 +539,28 @@ export class ExtensionRunner {
             event.type === "session_before_compact" ||
             event.type === "session_before_tree");
     }
+    // SCRAMJET-DIVERGENCE: issue 326 — after invalidate() (session replacement/teardown),
+    // remaining or subsequent handler invocations are skipped instead of running against a
+    // dead ctx and throwing the stale-ctx error. session_shutdown is the exception: skipping
+    // it silently would drop teardown hooks, so that ordering violation is reported.
+    skipStale(eventType) {
+        if (!this.staleMessage)
+            return false;
+        if (eventType === "session_shutdown") {
+            this.emitError({
+                extensionPath: "<runner>",
+                event: "session_shutdown",
+                error: "session_shutdown emitted after runner invalidation; teardown hooks were skipped (ordering bug)",
+            });
+        }
+        else if (process.env.SCRAMJET_DEBUG || process.env.PI_DEBUG) {
+            console.debug(`ExtensionRunner: skipping ${eventType} handlers on invalidated runner (issue 326)`);
+        }
+        return true;
+    }
     async emit(event) {
+        if (this.skipStale(event.type))
+            return undefined;
         const ctx = this.createContext();
         let result;
         for (const ext of this.extensions) {
@@ -529,6 +568,8 @@ export class ExtensionRunner {
             if (!handlers || handlers.length === 0)
                 continue;
             for (const handler of handlers) {
+                if (this.skipStale(event.type))
+                    return result;
                 try {
                     const handlerResult = await handler(event, ctx);
                     if (this.isSessionBeforeEvent(event) && handlerResult) {
@@ -553,6 +594,8 @@ export class ExtensionRunner {
         return result;
     }
     async emitMessageEnd(event) {
+        if (this.skipStale("message_end"))
+            return undefined;
         const ctx = this.createContext();
         let currentMessage = event.message;
         let modified = false;
@@ -561,6 +604,8 @@ export class ExtensionRunner {
             if (!handlers || handlers.length === 0)
                 continue;
             for (const handler of handlers) {
+                if (this.skipStale("message_end"))
+                    return modified ? currentMessage : undefined;
                 try {
                     const currentEvent = { ...event, message: currentMessage };
                     const handlerResult = (await handler(currentEvent, ctx));
@@ -592,6 +637,8 @@ export class ExtensionRunner {
         return modified ? currentMessage : undefined;
     }
     async emitToolResult(event) {
+        if (this.skipStale("tool_result"))
+            return undefined;
         const ctx = this.createContext();
         const currentEvent = { ...event };
         let modified = false;
@@ -600,6 +647,8 @@ export class ExtensionRunner {
             if (!handlers || handlers.length === 0)
                 continue;
             for (const handler of handlers) {
+                if (this.skipStale("tool_result"))
+                    break;
                 try {
                     const handlerResult = (await handler(currentEvent, ctx));
                     if (!handlerResult)
@@ -639,6 +688,8 @@ export class ExtensionRunner {
         };
     }
     async emitToolCall(event) {
+        if (this.skipStale("tool_call"))
+            return undefined;
         const ctx = this.createContext();
         let result;
         for (const ext of this.extensions) {
@@ -646,6 +697,8 @@ export class ExtensionRunner {
             if (!handlers || handlers.length === 0)
                 continue;
             for (const handler of handlers) {
+                if (this.skipStale("tool_call"))
+                    return result;
                 const handlerResult = await handler(event, ctx);
                 if (handlerResult) {
                     result = handlerResult;
@@ -658,12 +711,16 @@ export class ExtensionRunner {
         return result;
     }
     async emitUserBash(event) {
+        if (this.skipStale("user_bash"))
+            return undefined;
         const ctx = this.createContext();
         for (const ext of this.extensions) {
             const handlers = ext.handlers.get("user_bash");
             if (!handlers || handlers.length === 0)
                 continue;
             for (const handler of handlers) {
+                if (this.skipStale("user_bash"))
+                    return undefined;
                 try {
                     const handlerResult = await handler(event, ctx);
                     if (handlerResult) {
@@ -685,6 +742,8 @@ export class ExtensionRunner {
         return undefined;
     }
     async emitContext(messages) {
+        if (this.skipStale("context"))
+            return messages;
         const ctx = this.createContext();
         let currentMessages = structuredClone(messages);
         for (const ext of this.extensions) {
@@ -692,6 +751,8 @@ export class ExtensionRunner {
             if (!handlers || handlers.length === 0)
                 continue;
             for (const handler of handlers) {
+                if (this.skipStale("context"))
+                    return currentMessages;
                 try {
                     const event = { type: "context", messages: currentMessages };
                     const handlerResult = await handler(event, ctx);
@@ -713,7 +774,45 @@ export class ExtensionRunner {
         }
         return currentMessages;
     }
-    async emitBeforeProviderRequest(payload) {
+    async emitBeforeProviderCall(context, model) {
+        if (this.skipStale("before_provider_call"))
+            return context;
+        const ctx = this.createContext();
+        let systemPrompt = context.systemPrompt;
+        for (const ext of this.extensions) {
+            const handlers = ext.handlers.get("before_provider_call");
+            if (!handlers || handlers.length === 0)
+                continue;
+            for (const handler of handlers) {
+                if (this.skipStale("before_provider_call"))
+                    return { ...context, systemPrompt };
+                try {
+                    // SCRAMJET-DIVERGENCE: isolate exact routed identity from extension mutation (#491).
+                    const modelSnapshot = deepFreeze(structuredClone(model));
+                    const event = {
+                        type: "before_provider_call",
+                        model: modelSnapshot,
+                        systemPrompt,
+                    };
+                    const handlerResult = (await handler(event, ctx));
+                    if (handlerResult?.systemPrompt !== undefined)
+                        systemPrompt = handlerResult.systemPrompt;
+                }
+                catch (err) {
+                    this.emitError({
+                        extensionPath: ext.path,
+                        event: "before_provider_call",
+                        error: err instanceof Error ? err.message : String(err),
+                        stack: err instanceof Error ? err.stack : undefined,
+                    });
+                }
+            }
+        }
+        return systemPrompt === context.systemPrompt ? context : { ...context, systemPrompt };
+    }
+    async emitBeforeProviderRequest(payload, model) {
+        if (this.skipStale("before_provider_request"))
+            return payload;
         const ctx = this.createContext();
         let currentPayload = payload;
         for (const ext of this.extensions) {
@@ -721,9 +820,14 @@ export class ExtensionRunner {
             if (!handlers || handlers.length === 0)
                 continue;
             for (const handler of handlers) {
+                if (this.skipStale("before_provider_request"))
+                    return currentPayload;
                 try {
+                    // SCRAMJET-DIVERGENCE: isolate exact routed identity from extension mutation (#491).
+                    const modelSnapshot = deepFreeze(structuredClone(model));
                     const event = {
                         type: "before_provider_request",
+                        model: modelSnapshot,
                         payload: currentPayload,
                     };
                     const handlerResult = await handler(event, ctx);
@@ -745,7 +849,21 @@ export class ExtensionRunner {
         }
         return currentPayload;
     }
+    // SCRAMJET-DIVERGENCE: isolate immutable final-schema observations from extension mutation (#524).
+    async emitProviderRequestToolInventory(model, requestContextToolNames, inventory) {
+        if (this.skipStale("provider_request_tool_inventory"))
+            return;
+        const event = Object.freeze({
+            type: "provider_request_tool_inventory",
+            model: Object.freeze({ ...model }),
+            requestContextToolNames: Object.freeze([...requestContextToolNames]),
+            inventory: deepFreeze(structuredClone(inventory)),
+        });
+        await this.emit(event);
+    }
     async emitBeforeAgentStart(prompt, images, systemPromptSections, systemPromptOptions) {
+        if (this.skipStale("before_agent_start"))
+            return undefined;
         let currentSystemPrompt = flattenSystemPrompt(systemPromptSections);
         const ctx = Object.defineProperties({}, Object.getOwnPropertyDescriptors(this.createContext()));
         ctx.getSystemPrompt = () => {
@@ -770,6 +888,8 @@ export class ExtensionRunner {
                         systemPromptSections,
                         systemPromptOptions,
                     };
+                    if (this.skipStale("before_agent_start"))
+                        break;
                     const handlerResult = await handler(event, ctx);
                     if (handlerResult) {
                         const result = handlerResult;
@@ -857,6 +977,8 @@ export class ExtensionRunner {
         return undefined;
     }
     async emitResourcesDiscover(cwd, reason) {
+        if (this.skipStale("resources_discover"))
+            return { skillPaths: [], promptPaths: [], themePaths: [] };
         const ctx = this.createContext();
         const skillPaths = [];
         const promptPaths = [];
@@ -866,6 +988,8 @@ export class ExtensionRunner {
             if (!handlers || handlers.length === 0)
                 continue;
             for (const handler of handlers) {
+                if (this.skipStale("resources_discover"))
+                    return { skillPaths, promptPaths, themePaths };
                 try {
                     const event = { type: "resources_discover", cwd, reason };
                     const handlerResult = await handler(event, ctx);
@@ -896,11 +1020,38 @@ export class ExtensionRunner {
     }
     /** Emit input event. Transforms chain, "handled" short-circuits. */
     async emitInput(text, images, source) {
+        if (this.skipStale("input"))
+            return { action: "continue" };
         const ctx = this.createContext();
         let currentText = text;
         let currentImages = images;
+        const sessionEntries = [];
+        const acceptanceCallbacks = [];
+        const transformResult = () => {
+            const result = {
+                action: "transform",
+                text: currentText,
+                images: currentImages,
+                sessionEntries,
+            };
+            if (acceptanceCallbacks.length > 0) {
+                result.onAccepted = () => {
+                    for (const callback of acceptanceCallbacks)
+                        callback();
+                };
+            }
+            return result;
+        };
         for (const ext of this.extensions) {
             for (const handler of ext.handlers.get("input") ?? []) {
+                if (this.skipStale("input")) {
+                    return currentText !== text ||
+                        currentImages !== images ||
+                        sessionEntries.length > 0 ||
+                        acceptanceCallbacks.length > 0
+                        ? transformResult()
+                        : { action: "continue" };
+                }
                 try {
                     const event = { type: "input", text: currentText, images: currentImages, source };
                     const result = (await handler(event, ctx));
@@ -909,6 +1060,9 @@ export class ExtensionRunner {
                     if (result?.action === "transform") {
                         currentText = result.text;
                         currentImages = result.images ?? currentImages;
+                        sessionEntries.push(...(result.sessionEntries ?? []));
+                        if (result.onAccepted)
+                            acceptanceCallbacks.push(result.onAccepted);
                     }
                 }
                 catch (err) {
@@ -921,8 +1075,11 @@ export class ExtensionRunner {
                 }
             }
         }
-        return currentText !== text || currentImages !== images
-            ? { action: "transform", text: currentText, images: currentImages }
+        return currentText !== text ||
+            currentImages !== images ||
+            sessionEntries.length > 0 ||
+            acceptanceCallbacks.length > 0
+            ? transformResult()
             : { action: "continue" };
     }
 }