@leaflow/sdk 0.5.0 → 0.5.1

package/dist/http.d.ts

@@ -96,5 +96,31 @@ export type Bound<T> = {
  * `scripts/check-generated-arity.mjs` fails the build if that changes: a slot
  * that silently shifts by one would pass the client as somebody's request body,
  * and no amount of type checking on generated code would catch it.
+ *
+ * # Why this builds an object instead of returning a Proxy
+ *
+ * It used to be a `Proxy` over the namespace, which is smaller and binds lazily.
+ * It also threw, in production only:
+ *
+ *     'get' on proxy: property 'getAccount' is a read-only and non-configurable
+ *     data property on the proxy target but the proxy did not return its actual
+ *     value
+ *
+ * That is a Proxy invariant, not a bug in the trap. `api` is an ES module
+ * namespace object, and a bundler is free to emit its exports as non-writable and
+ * non-configurable — Next's production build does, its dev server does not. When
+ * a target property is a read-only non-configurable data property, `get` **must**
+ * return that exact value, so a trap whose entire purpose is to return a wrapper
+ * cannot be correct. The old code was not wrong about the bundler; it was wrong
+ * about Proxy.
+ *
+ * It failed the worst possible way: every local check passes, `pnpm dev` passes,
+ * the production bundle throws on the first call. In the console that first call
+ * is `getAccount` during sign-in, so the symptom was "nobody can log in" with an
+ * error naming IAM — a service that was fine.
+ *
+ * Copying costs one pass over a few dozen keys per client. Clients are made per
+ * request here, which sounds like a lot until you notice the request that follows
+ * goes over a network.
  */
 export declare function bindClient<T extends object>(api: T, client: Client): Bound<T>;

package/dist/http.js

@@ -83,23 +83,56 @@ export async function request(config, options) {
  * `scripts/check-generated-arity.mjs` fails the build if that changes: a slot
  * that silently shifts by one would pass the client as somebody's request body,
  * and no amount of type checking on generated code would catch it.
+ *
+ * # Why this builds an object instead of returning a Proxy
+ *
+ * It used to be a `Proxy` over the namespace, which is smaller and binds lazily.
+ * It also threw, in production only:
+ *
+ *     'get' on proxy: property 'getAccount' is a read-only and non-configurable
+ *     data property on the proxy target but the proxy did not return its actual
+ *     value
+ *
+ * That is a Proxy invariant, not a bug in the trap. `api` is an ES module
+ * namespace object, and a bundler is free to emit its exports as non-writable and
+ * non-configurable — Next's production build does, its dev server does not. When
+ * a target property is a read-only non-configurable data property, `get` **must**
+ * return that exact value, so a trap whose entire purpose is to return a wrapper
+ * cannot be correct. The old code was not wrong about the bundler; it was wrong
+ * about Proxy.
+ *
+ * It failed the worst possible way: every local check passes, `pnpm dev` passes,
+ * the production bundle throws on the first call. In the console that first call
+ * is `getAccount` during sign-in, so the symptom was "nobody can log in" with an
+ * error naming IAM — a service that was fine.
+ *
+ * Copying costs one pass over a few dozen keys per client. Clients are made per
+ * request here, which sounds like a lot until you notice the request that follows
+ * goes over a network.
  */
 export function bindClient(api, client) {
-    return new Proxy(api, {
-        get(target, property, receiver) {
-            const value = Reflect.get(target, property, receiver);
-            if (typeof value !== 'function') {
-                return value;
+    const bound = {};
+    /*
+     * `for...in` rather than `Object.keys`: a namespace object's exports are its
+     * own enumerable properties either way, but re-exported members can arrive on
+     * the prototype chain depending on how the bundler emitted them, and an
+     * operation that is silently missing is worse than one that is bound twice.
+     */
+    for (const property in api) {
+        const value = api[property];
+        if (typeof value !== 'function') {
+            bound[property] = value;
+            continue;
+        }
+        const operation = value;
+        bound[property] = (...args) => {
+            const slot = Math.max(operation.length - 1, 0);
+            const head = args.slice(0, slot);
+            while (head.length < slot) {
+                head.push(undefined);
             }
-            const operation = value;
-            return (...args) => {
-                const slot = Math.max(operation.length - 1, 0);
-                const head = args.slice(0, slot);
-                while (head.length < slot) {
-                    head.push(undefined);
-                }
-                return operation(...head, { client });
-            };
-        },
-    });
+            return operation(...head, { client });
+        };
+    }
+    return bound;
 }

package/dist/index.js

@@ -61,7 +61,7 @@ export function createMonitoringClient(options) {
 /** Service versions the bundled specs were generated from. */
 export const SERVICE_VERSIONS = {
     assistant: "v2.2.0",
-    compute: "v2.5.0",
+    compute: "v2.7.0",
     iam: "v0.32.0",
     monitoring: "v9.2.0",
 };

package/openapi/compute.version

@@ -1 +1 @@
-v2.5.0
+v2.7.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@leaflow/sdk",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "TypeScript SDK for the Leaflow platform APIs",
   "license": "MIT",
   "type": "module",