@lde/search-typesense 0.25.0 → 0.26.0

package/dist/query-compiler.d.ts

@@ -45,7 +45,8 @@ export interface BuildSearchParamsOptions {
      * usable bound. Skipping keeps a malformed clause from reaching the engine
      * as garbage; supply this to log it instead of losing it silently. Through
      * the engine, a structurally invalid query throws up front
-     * (`assertValidQuery`), so there only the vacuous clauses reach this.
+     * (`assertValidQuery`), so there only the clauses that state no constraint
+     * reach this.
      */
     readonly onIgnoredFilter?: (filter: Filter) => void;
 }

package/dist/query-compiler.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"query-compiler.d.ts","sourceRoot":"","sources":["../src/query-compiler.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,sCAAsC,CAAC;AAEzE,OAAO,EAGL,KAAK,MAAM,EACX,KAAK,QAAQ,EAEb,KAAK,WAAW,EAChB,KAAK,UAAU,EAEhB,MAAM,aAAa,CAAC;AAarB;mDACmD;AACnD,MAAM,WAAW,UAAU;IACzB,QAAQ,CAAC,UAAU,EAAE,QAAQ,CAAC;IAC9B,QAAQ,CAAC,UAAU,EAAE,MAAM,CAAC;CAC7B;AAED;;;;GAIG;AACH,MAAM,WAAW,wBAAwB;IACvC;;;;;;;;;;;;;;;;OAgBG;IACH,QAAQ,CAAC,aAAa,CAAC,EAAE,CACvB,IAAI,EAAE,UAAU,EAChB,IAAI,EAAE,SAAS,MAAM,EAAE,KACpB,UAAU,GAAG,SAAS,CAAC;IAC5B;;;;;;OAMG;IACH,QAAQ,CAAC,cAAc,CAAC,EAAE,MAAM,CAAC;IACjC;;;;;;;;OAQG;IACH,QAAQ,CAAC,eAAe,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,IAAI,CAAC;CACrD;AAED;;;;;;;;;;;GAWG;AACH,wBAAgB,iBAAiB,CAC/B,KAAK,EAAE,WAAW,EAClB,UAAU,EAAE,UAAU,EACtB,OAAO,GAAE,wBAA6B,GACrC,YAAY,CAAC,MAAM,CAAC,CA8BtB;AAsSD;;;;GAIG;AACH,wBAAgB,iBAAiB,CAAC,KAAK,EAAE,MAAM,GAAG,MAAM,CAEvD"}
+{"version":3,"file":"query-compiler.d.ts","sourceRoot":"","sources":["../src/query-compiler.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,sCAAsC,CAAC;AAEzE,OAAO,EAGL,KAAK,MAAM,EACX,KAAK,QAAQ,EAEb,KAAK,WAAW,EAChB,KAAK,UAAU,EAEhB,MAAM,aAAa,CAAC;AAarB;mDACmD;AACnD,MAAM,WAAW,UAAU;IACzB,QAAQ,CAAC,UAAU,EAAE,QAAQ,CAAC;IAC9B,QAAQ,CAAC,UAAU,EAAE,MAAM,CAAC;CAC7B;AAED;;;;GAIG;AACH,MAAM,WAAW,wBAAwB;IACvC;;;;;;;;;;;;;;;;OAgBG;IACH,QAAQ,CAAC,aAAa,CAAC,EAAE,CACvB,IAAI,EAAE,UAAU,EAChB,IAAI,EAAE,SAAS,MAAM,EAAE,KACpB,UAAU,GAAG,SAAS,CAAC;IAC5B;;;;;;OAMG;IACH,QAAQ,CAAC,cAAc,CAAC,EAAE,MAAM,CAAC;IACjC;;;;;;;;;OASG;IACH,QAAQ,CAAC,eAAe,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,IAAI,CAAC;CACrD;AAED;;;;;;;;;;;GAWG;AACH,wBAAgB,iBAAiB,CAC/B,KAAK,EAAE,WAAW,EAClB,UAAU,EAAE,UAAU,EACtB,OAAO,GAAE,wBAA6B,GACrC,YAAY,CAAC,MAAM,CAAC,CA8BtB;AAuTD;;;;GAIG;AACH,wBAAgB,iBAAiB,CAAC,KAAK,EAAE,MAAM,GAAG,MAAM,CAEvD"}

package/dist/query-compiler.js

@@ -134,8 +134,15 @@ function compileFilterBy(where, searchType, options) {
  *   unknown field, an operator that mismatches the field’s kind) is *false*, and
  *   `false || X` is X, so it drops out and its siblings still stand.
  *
- * A clause left with no terms either way is skipped and reported to
- * `onIgnoredFilter`.
+ * Both readings hold **within** a clause. Neither survives a clause left with
+ * no terms: it is skipped and reported to `onIgnoredFilter`, and a clause
+ * missing from the conjunction constrains nothing – so a *false* criterion
+ * alone in its clause still WIDENS the query. `filter_by` has no term meaning
+ * “matches nothing” to compile it to instead. The engine never meets this
+ * (`assertValidQuery` rejects every malformed criterion, and `isUnsatisfiable`
+ * short-circuits the empty `id` membership before a query is dispatched); a
+ * direct caller should read `onIgnoredFilter` firing as “this query no longer
+ * asks what you asked”.
  */
 function compileFilter(filter, searchType, options) {
     const terms = [];
@@ -237,11 +244,21 @@ function compileMembership(field, values) {
         ? `${field.name}:=${list}`
         : `${field.name}:${list}`;
 }
-/** An inclusive Typesense range clause, or `undefined` when neither bound is set. */
+/** An inclusive Typesense range clause, or `undefined` when neither bound is
+ *  usable. Which of the two readings that is – the caller set no bounds, or the
+ *  codec rejected the ones they set – is deliberately NOT decided here: a
+ *  criterion dropped from a clause narrows the query while a clause dropped
+ *  from the conjunction widens it, so the same reading cannot be right in both
+ *  positions. `validateQuery` rejects an unreadable bound outright instead,
+ *  which is the only answer that neither widens nor narrows. */
 function compileRange(field, range) {
     const name = field.name;
-    const min = storedBound(field, range.min);
-    const max = storedBound(field, range.max);
+    // A bound a caller sent as `null` – a GraphQL variable left unfilled, which
+    // the surface passes through – is a bound NOT SET, not a bound of `null`.
+    // Read literally it reaches the engine as `datePosted:[null..…]`, which
+    // Typesense rejects outright.
+    const min = storedBound(field, range.min ?? undefined);
+    const max = storedBound(field, range.max ?? undefined);
     if (min !== undefined && max !== undefined) {
         return `${name}:[${min}..${max}]`;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lde/search-typesense",
-  "version": "0.25.0",
+  "version": "0.26.0",
   "description": "Typesense implementation of the @lde/search SearchEngine port: collection-schema builder, query compiler, label-resolving result reconstruction, and blue/green index lifecycle. Engine-specific (Typesense) but domain-agnostic.",
   "repository": {
     "url": "git+https://github.com/ldelements/lde.git",
@@ -25,7 +25,7 @@
     "!**/*.tsbuildinfo"
   ],
   "dependencies": {
-    "@lde/search": "^0.22.0",
+    "@lde/search": "^0.23.0",
     "@lde/text-normalization": "^0.1.2",
     "tslib": "^2.3.0",
     "typesense": "^3.0.6"